Re: [PATCH] ACPI: small formatting fixes

2017-01-11 Thread Pavel Machek
On Thu 2016-12-22 19:19:43, Nick Desaulniers wrote: > On Tue, Dec 13, 2016 at 08:00:01PM +0100, Pavel Machek wrote: > > Actually.. the ACPI cleanup is fine. You did well :-). > > Pavel > > Cool, so (forgive the naive question) wha

Re: [PATCH] ACPI: small formatting fixes

2016-12-23 Thread Rafael J. Wysocki
On Fri, Dec 23, 2016 at 4:19 AM, Nick Desaulniers wrote: > On Tue, Dec 13, 2016 at 08:00:01PM +0100, Pavel Machek wrote: >> Actually.. the ACPI cleanup is fine. You did well :-). >> Pavel > > Cool, so (forgive the naive question

Re: [PATCH] ACPI: small formatting fixes

2016-12-22 Thread Nick Desaulniers
On Tue, Dec 13, 2016 at 08:00:01PM +0100, Pavel Machek wrote: > Actually.. the ACPI cleanup is fine. You did well :-). > Pavel Cool, so (forgive the naive question) what happens next? Maybe I'm too used to the immediate gratifi

Re: [PATCH] ACPI: small formatting fixes

2016-12-13 Thread Pavel Machek
On Mon 2016-12-12 15:22:22, Joe Perches wrote: > On Mon, 2016-12-12 at 15:20 -0800, Nick Desaulniers wrote: > > > Please... don't encourage people more, we have enough cleanup patches > > > as is. > > > > I recognize that this patch is relatively inconsequential, but it is my > > first patch to th

Re: [PATCH] ACPI: small formatting fixes

2016-12-13 Thread Bjørn Mork
Joe Perches writes: > On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: >> On Mon 2016-12-12 10:39:15, Joe Perches wrote: >> > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: >> > > A quick cleanup that passes scripts/checkpatch.pl -f . > [] >> > > diff --git a/arch/x86/kernel/acpi

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 15:20 -0800, Nick Desaulniers wrote: > > Please... don't encourage people more, we have enough cleanup patches > > as is. > > I recognize that this patch is relatively inconsequential, but it is my > first patch to the Linux kernel, and is teaching me how to wrangle my > emai

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Nick Desaulniers
> Please... don't encourage people more, we have enough cleanup patches > as is. I recognize that this patch is relatively inconsequential, but it is my first patch to the Linux kernel, and is teaching me how to wrangle my email client and about the development work flow. I plan to write a blog p

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Joe Perches
On Tue, 2016-12-13 at 00:08 +0100, Pavel Machek wrote: > On Mon 2016-12-12 14:32:12, Joe Perches wrote: > > On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: > > > On Mon 2016-12-12 10:39:15, Joe Perches wrote: > > > > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > > > > A quic

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Pavel Machek
On Mon 2016-12-12 14:32:12, Joe Perches wrote: > On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: > > On Mon 2016-12-12 10:39:15, Joe Perches wrote: > > > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > > > A quick cleanup that passes scripts/checkpatch.pl -f . > [] > > > > dif

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: > On Mon 2016-12-12 10:39:15, Joe Perches wrote: > > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > > A quick cleanup that passes scripts/checkpatch.pl -f . [] > > > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/a

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Pavel Machek
On Mon 2016-12-12 10:39:15, Joe Perches wrote: > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > A quick cleanup that passes scripts/checkpatch.pl -f . > > You might use the --strict option for acpi files. Please... don't encourage people more, we have enough cleanup patches as is.

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Joe Perches
On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > A quick cleanup that passes scripts/checkpatch.pl -f . You might use the --strict option for acpi files. > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c [] > @@ -103,9 +103,8 @@ static long acpi_processor_ff

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Nick Desaulniers
>From 47d3bcb76ef89ddbe74c8d8aacee1c0c6203a766 Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Mon, 12 Dec 2016 09:50:23 -0800 Subject: [PATCH v2] ACPI: small formatting fixes A quick cleanup that passes scripts/checkpatch.pl -f . Signed-off-by: Nick Desaulniers --- arch/x86/kernel/acpi/

Re: [PATCH] ACPI: small formatting fixes

2016-12-12 Thread Pavel Machek
Hi! > A quick cleanup that passes scripts/checkpatch.pl -f . > > Signed-off-by: Nick Desaulniers > --- a/arch/x86/kernel/acpi/cstate.c > +++ b/arch/x86/kernel/acpi/cstate.c > @@ -1,7 +1,7 @@ > /* > * Copyright (C) 2005 Intel Corporation > - * Venkatesh Pallipadi > - * - Added _PDC for S

[PATCH] ACPI: small formatting fixes

2016-12-11 Thread Nick Desaulniers
A quick cleanup that passes scripts/checkpatch.pl -f . Signed-off-by: Nick Desaulniers --- arch/x86/kernel/acpi/cstate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c index af15f44..ed52aec

[PATCH] ACPI: small formatting fixes

2016-11-20 Thread Nick Desaulniers
A quick cleanup that passes scripts/checkpatch.pl -f . Signed-off-by: Nick Desaulniers --- arch/x86/kernel/acpi/cstate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c index af15f44..ed52aec