On Tue, 2016-12-13 at 00:08 +0100, Pavel Machek wrote: > On Mon 2016-12-12 14:32:12, Joe Perches wrote: > > On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote: > > > On Mon 2016-12-12 10:39:15, Joe Perches wrote: > > > > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote: > > > > > A quick cleanup that passes scripts/checkpatch.pl -f <file>. > > > > [] > > > > > diff --git a/arch/x86/kernel/acpi/cstate.c > > > > > b/arch/x86/kernel/acpi/cstate.c > > > > [] > > > > It's generally better not to convert > > > > these printk(KERN_DEBUG uses. > > > > > > > > There are behavior differences between > > > > printk(KERN_DEBUG ...); > > > > and > > > > pr_debug(...); > > > > > > > > The first will always be emitted as long > > > > as the console level is appropriate. > > > > > > > > The second depends on a #define DEBUG > > > > before it gets emitted or a kernel > > > > with CONFIG_DYNAMIC_DEBUG enabled and > > > > this entry specifically enabled in the > > > > control file. > > > > > > Hmm. Perhaps pr_debug should be called pr_c_debug() or something? This > > > is rather nice trap. > > > > Yeah, I've suggested veriants like pr_always_debug (from 2009) > > http://lkml.iu.edu/hypermail/linux/kernel/0910.0/00399.html > > I'd very much like to see it other way around. > > pr_err is equivalent to printk(KERN_ERR) > pr_warn is equivalent to printk(KERN_WARN)
That bus left the station more than a decade ago. > pr_debug _NOT_ beging equivalent to printk(KERN_DEBUG) is a trap :-(. true
