Re: [PATCH v2 49/62] kbuild,objtool: Defer objtool validation step for CONFIG_LIVEPATCH

2025-05-28 Thread Joe Lawrence
it/version-timestamp.o --no-whole-archive --start-group --end-group .tmp_vmlinux0.kallsyms.o arch/powerpc/tools/vmlinux.arch.o vmlinux.o:(__ftr_alt_97+0x20): relocation truncated to fit: R_PPC64_REL14 against `.text'+4b54 vmlinux.o:(__ftr_alt_97+0x270): relocation truncated to fit: R_PPC64_REL14

Re: [PATCH v2 45/62] x86/extable: Define ELF section entry size for exception tables

2025-05-28 Thread Joe Lawrence
On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > In preparation for the objtool klp diff subcommand, define the entry > size for the __ex_table section in its ELF header. This will allow > tooling to extract individual entries. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/asm/asm.h | 20

Re: [RFC PATCH v2 3/9] KVM: arm64: nv: selftests: Enable hypervisor timer tests to run in vEL2

2025-05-28 Thread Eric Auger
Hi Ganapatrao, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > Adding required changes to enable and test HVTIMER and HPTIMER > in vEL2. In default case, PTIMER and VTIMER are validated and with > NV enabled (with argument "-g 1"), HPTIMER and HVTIMER are validated > by injecting respective time

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Arnaldo Carvalho de Melo
On Wed, May 28, 2025 at 11:28:54AM +0200, Toke Høiland-Jørgensen wrote: > Mina Almasry writes: > > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > > wrote: > >> Back when you posted the first RFC, Jesper and I chatted about ways to > >> avoid the ugly "load module and read the output fr

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
>>>>> 3800-3fff : PCI ECAM >>>>> 4000-5fff : PCI Bus :00 >>>>> ... >>>>> >>>>> Whereas my x86 box has some reserved memory: >>>>> >>>>> $ sudo cat /proc/iomem >>>>&

Re: [RESEND PATCH v2] dt-bindings: pmem: Convert binding to YAML

2025-05-28 Thread Conor Dooley
On Tue, May 27, 2025 at 11:17:04PM -0700, Drew Fustini wrote: > Convert the PMEM device tree binding from text to YAML. This will allow > device trees with pmem-region nodes to pass dtbs_check. > > Signed-off-by: Drew Fustini > --- > v2 resend: > - actually put v2 in the Subject > - add Conor's

Re: [RFC PATCH v2 1/9] KVM: arm64: nv: selftests: Add support to run guest code in vEL2.

2025-05-28 Thread Eric Auger
Hi, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > This patch adds required changes to vcpu init to run a guest code > in vEL2 context and also adds NV specific helper functions. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/testing/selftests/kvm/Makefile.kvm

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-05-28 Thread Eric Auger
Hi Ganapatrao, On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > This patch series makes the selftest work with NV enabled. The guest code > is run in vEL2 instead of EL1. We add a command line option to enable > testing of NV. The NV tests are disabled by default. For commodity, I wou

Re: [PATCH] virtio: document ENOSPC

2025-05-28 Thread Stefan Hajnoczi
On Tue, May 27, 2025 at 10:28 AM Michael S. Tsirkin wrote: > > drivers handle ENOSPC specially since it's an error one can > get from a working VQ. Document the semantics. > > Reported-by: Parav Pandit > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 4 > 1 file c

Re: [PATCH V2 00/19] virtio_ring in order support

2025-05-28 Thread Michael S. Tsirkin
On Wed, May 28, 2025 at 02:42:15PM +0800, Jason Wang wrote: > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were impl

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
s have the lower two pages IIRC (BIOS stuff etc). I'm not sure how far along this patch is? I'm guessing mm-stable? Perhaps you can do the quick fix, then I'd be happy to make this more robust for arm64 later? Can you give the following a quick test on that machine? Then, I can s

Re: [PATCH next] tools/testing: Check correct variable in open_procmap()

2025-05-28 Thread Lorenzo Stoakes
Thanks so much for catching this Dan! On Wed, May 28, 2025 at 11:13:45AM +0300, Dan Carpenter wrote: > Check if "procmap_out->fd" is negative instead of "procmap_out" (which > is a pointer). Ye gods, so sorry for such a clanger! Entirely my fault, though I may mutter a grumble about C type safety

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
PCI ECAM >>> 4000-5fff : PCI Bus :00 >>> ... >>> >>> Whereas my x86 box has some reserved memory: >>> >>> $ sudo cat /proc/iomem >>> -0fff : Reserved >>> 1000-0003dfff : System RAM >>>

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:44, David Hildenbrand wrote: On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cover some PAT (Page Attribute Handling) handling on x86. These tests wil

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
s have the lower two pages IIRC (BIOS stuff etc). I'm not sure how far along this patch is? I'm guessing mm-stable? Perhaps you can do the quick fix, then I'd be happy to make this more robust for arm64 later? Already hacking on the parsing :) -- Cheers, David / dhildenb

Re: [PATCH v3] media: add virtio-media driver

2025-05-28 Thread Alexandre Courbot
Hi Michael, On Wed, May 28, 2025 at 12:06 AM Michael S. Tsirkin wrote: > > On Tue, May 27, 2025 at 04:39:27PM +0200, Mauro Carvalho Chehab wrote: > > > It's up to you though. > > > I can keep it in next for now, so it gets some coverage by > > > tools scanning that tree. > > > > Sure, feel free t

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread David Hildenbrand
On 28.05.25 12:34, Ryan Roberts wrote: Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cover some PAT (Page Attribute Handling) handling on x86. These tests will only run when /dev/mem access to the first

[PATCH V2 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) di

Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-28 Thread Ryan Roberts
Hi David, On 09/05/2025 16:30, David Hildenbrand wrote: > Let's test some basic functionality using /dev/mem. These tests will > implicitly cover some PAT (Page Attribute Handling) handling on x86. > > These tests will only run when /dev/mem access to the first two pages > in physical address sp

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-05-28 Thread Peter Zijlstra
On Mon, May 26, 2025 at 12:52:40PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:16:56PM -0700, Josh Poimboeuf wrote: > > It's common to use --dryrun on binaries that have already been > > processed. Don't print the section skipping warnings in that case. > > Ah, I rather like this wa

[PATCH V2 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-)

Re: [PATCH] rust: replace length checks with match

2025-05-28 Thread Alice Ryhl
On Tue, May 27, 2025 at 12:09:36PM -0400, Tamir Duberstein wrote: > Use a match expression with slice patterns instead of length checks and > indexing. The result is more idiomatic, which is a better example for > future Rust code authors. > > Signed-off-by: Tamir Duberstein Reviewed-by: Alice R

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Michal Luczaj
On 5/27/25 10:41, Stefano Garzarella wrote: > On Mon, May 26, 2025 at 10:44:05PM +0200, Michal Luczaj wrote: >> On 5/26/25 16:39, Stefano Garzarella wrote: >>> On Mon, May 26, 2025 at 02:51:18PM +0200, Michal Luczaj wrote: On 5/26/25 10:25, Stefano Garzarella wrote: > On Fri, May 23, 2025

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-28 Thread Toke Høiland-Jørgensen
Mina Almasry writes: > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > wrote: >> > Fast path results: >> > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns >> > >> > ptr_ring results: >> > no-softirq-page_pool02 Per elem: 527 cycles(tsc) 195.187 ns >> > >> > slow path results:

Re: [PATCH net-next] vsock/test: Cover more CIDs in transport_uaf test

2025-05-28 Thread Stefano Garzarella
On Wed, May 28, 2025 at 10:58:28AM +0200, Michal Luczaj wrote: On 5/27/25 10:41, Stefano Garzarella wrote: On Mon, May 26, 2025 at 10:44:05PM +0200, Michal Luczaj wrote: On 5/26/25 16:39, Stefano Garzarella wrote: On Mon, May 26, 2025 at 02:51:18PM +0200, Michal Luczaj wrote: On 5/26/25 10:25

Re: [PATCH net-next v9] selftests/vsock: add initial vmtest.sh for vsock

2025-05-28 Thread Stefano Garzarella
other than loopback, this patch adds vmtest.sh as a kselftest itself. This is different than other systems that have a "vmtest.sh", where it is used as a utility script to spin up a VM to run the selftests as a guest (but isn't hooked into kselftest). Signed-off-by: Bobby Eshleman

[PATCH next] tools/testing: Check correct variable in open_procmap()

2025-05-28 Thread Dan Carpenter
Check if "procmap_out->fd" is negative instead of "procmap_out" (which is a pointer). Fixes: bd23f293a0d5 ("tools/testing: add PROCMAP_QUERY helper functions in mm self tests") Signed-off-by: Dan Carpenter --- tools/testing/selftests/mm/vm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Tue, 27 May 2025 11:11:38 +0530 you wrote: > On linux-next, build for bpf selftest displays a warning: > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' > differs from late

Re: [PATCH 0/7] Rust KUnit `#[test]` support improvements

2025-05-28 Thread Miguel Ojeda
On Tue, May 27, 2025 at 2:10 AM Miguel Ojeda wrote: > > [ Used the `cfg_attr` from the TODO comment and clarified its comment > now that the stabilization is in beta and thus quite likely stable > in Rust 1.88.0. Simplified the `new_body` code by introducing a new > variable.

[PATCH V2 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

[PATCH V2 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx()

2025-05-28 Thread Jason Wang
To be consistent with virtqueue_reset(). Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index b784aab66867..afdd51fc3c9

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread Daniel Borkmann
On 5/27/25 7:41 AM, Saket Kumar Bhaskar wrote: On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UAPI to the header guard in var

Re: [PATCH V2 00/19] virtio_ring in order support

2025-05-28 Thread Eugenio Perez Martin
On Wed, May 28, 2025 at 8:42 AM Jason Wang wrote: > > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were implemented

Re: [PATCH] fs/dax: Fix "don't skip locked entries when scanning entries"

2025-05-28 Thread Alistair Popple
On Tue, May 27, 2025 at 02:46:28PM -0700, Dan Williams wrote: > Alistair Popple wrote: > > Commit 6be3e21d25ca ("fs/dax: don't skip locked entries when scanning > > entries") introduced a new function, wait_entry_unlocked_exclusive(), > > which waits for the current entry to become unlocked without

[PATCH V2 07/19] virtio: switch to use vring_virtqueue for virtqueue_add variants

2025-05-28 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

[PATCH V2 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 40 +--- 1 file changed, 19 insertio

[PATCH V2 18/19] virtio_ring: factor out split detaching logic

2025-05-27 Thread Jason Wang
This patch factors out the split core detaching logic that could be reused by in order feature into a dedicated function. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a

[PATCH V2 16/19] virtio_ring: factor out core logic for updating last_used_idx

2025-05-27 Thread Jason Wang
Factor out the core logic for updating last_used_idx to be reused by the packed in order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 43 +--- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/d

[PATCH V2 19/19] virtio_ring: add in order support

2025-05-27 Thread Jason Wang
This patch implements in order support for both split virtqueue and packed virtqueue. Benchmark with KVM guest + testpmd on the host shows: For split virtqueue: no obvious differences were noticed For packed virtqueue: 1) RX gets 3.1% PPS improvements from 6.3 Mpps to 6.5 Mpps 2) TX gets 4.6

[PATCH V2 17/19] virtio_ring: factor out split indirect detaching logic

2025-05-27 Thread Jason Wang
Factor out the split indirect descriptor detaching logic in order to make it be reused by the in order support. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 63 1 file changed, 35 insertions(+), 28 deletions(-) diff --

[PATCH V2 14/19] virtio_ring: determine descriptor flags at one time

2025-05-27 Thread Jason Wang
Let's determine the last descriptor by counting the number of sg. This would be consistent with packed virtqueue implementation and ease the future in-order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 25 + 1 file c

[PATCH V2 13/19] virtio_ring: introduce virtqueue ops

2025-05-27 Thread Jason Wang
This patch introduces virtqueue ops which is a set of the callbacks that will be called for different queue layout or features. This would help to avoid branches for split/packed and will ease the future implementation like in order. Note that in order to eliminate the indirect calls this patch

[PATCH V2 15/19] virtio_ring: factor out core logic of buffer detaching

2025-05-27 Thread Jason Wang
Factor out core logic of buffer detaching and leave the id population to the caller so in order can just call the core logic. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/

[PATCH V2 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split()

2025-05-27 Thread Jason Wang
Use u16 for last_used_idx in virtqueue_poll_split() to align with the spec. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 03b

[PATCH V2 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[PATCH V2 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used()

2025-05-27 Thread Jason Wang
This patch unifies the logic of virtqueue_poll() and more_used() for better code reusing and ease the future in order implementation. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 48 +++- 1 file changed, 20 insertions

[PATCH V2 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants

2025-05-27 Thread Jason Wang
Those variants are used internally so let's switch to use vring_virtqueue as parameter to be consistent with other internal virtqueue helpers. Reviewed-by: Xuan Zhuo Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-)

[PATCH V2 00/19] virtio_ring in order support

2025-05-27 Thread Jason Wang
Hello all: This sereis tries to implement the VIRTIO_F_IN_ORDER to virtio_ring. This is done by introducing virtqueue ops so we can implement separate helpers for different virtqueue layout/features then the in-order were implemented on top. Tests shows 3%-5% imporvment with packed virtqueue PPS

[PATCH v3] kselftest: x86: Improve MOV SS test result message

2025-05-27 Thread Brigham Campbell
Make test result message more descriptive and grammatically correct. Signed-off-by: Brigham Campbell --- No changes in v3. I'm resending this patch to adjust patch format suggestions made by Shuah. tools/testing/selftests/x86/mov_ss_trap.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH net-next v2 0/8] Devmem TCP minor cleanups and ksft improvements

2025-05-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 23 May 2025 23:05:16 + you wrote: > v2: > https://lore.kernel.org/netdev/20250519023517.4062941-1-almasrym...@google.com/ > > Changelog: > - Collect acks and tested-bys (Thanks!) >

Re: [PATCH net-next v9] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Jakub Kicinski
On Tue, 27 May 2025 17:36:54 -0700 Bobby Eshleman wrote: > This commit introduces a new vmtest.sh runner for vsock. ## Form letter - net-next-closed The merge window for v6.16 has begun and therefore net-next is closed for new drivers, features, code refactoring and optimizations. Please repost

Re: [PATCH net-next 1/3] net: devmem: support single IOV with sendmsg

2025-05-27 Thread Jakub Kicinski
On Tue, 20 May 2025 13:30:42 -0700 Stanislav Fomichev wrote: > sendmsg() with a single iov becomes ITER_UBUF, sendmsg() with multiple > iovs becomes ITER_IOVEC. iter_iov_len does not return correct > value for UBUF, so teach to treat UBUF differently. Looks like this has been merged (silently), th

Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes

2025-05-27 Thread Jakub Kicinski
On Fri, 23 May 2025 03:22:42 +0100 Praveen Balakrishnan wrote: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests

[PATCH v2] selftests/seccomp: Improve error logging in get_proc_stat()

2025-05-27 Thread Sameeksha Sankpal
Use TH_LOG to report failure when reading /proc//stat in get_proc_stat(), following kernel test framework conventions. Previously, printf() was used which is discouraged. Suggested-by: Kees Cook Signed-off-by: Sameeksha Sankpal --- v1 -> v2: - Used TH_LOG instead of printf for error logging -

[PATCH net-next v9] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
vm_server_host_client # ok 1 vm_client_host_server # ok 2 vm_loopback # SUMMARY: PASS=3 SKIP=0 FAIL=0 # Log: /tmp/vsock_vmtest_svEl.log ok 1 selftests: vsock: vmtest.sh Future work can include vsock_diag_test. Because vsock requires a VM to test anything other than loopback, this patch adds vmtest.sh as

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
On Tue, May 27, 2025 at 05:55:13PM +0200, Stefano Garzarella wrote: > On Tue, May 27, 2025 at 07:30:29AM -0700, Bobby Eshleman wrote: > > On Mon, May 26, 2025 at 01:18:18PM +0200, Stefano Garzarella wrote: > > > On Thu, May 22, 2025 at 09:59:07PM -0700, Bobby Eshleman wrote: > > Yes, that would be

Re: [PATCH] fs/dax: Fix "don't skip locked entries when scanning entries"

2025-05-27 Thread Dan Williams
Alistair Popple wrote: > Commit 6be3e21d25ca ("fs/dax: don't skip locked entries when scanning > entries") introduced a new function, wait_entry_unlocked_exclusive(), > which waits for the current entry to become unlocked without advancing > the XArray iterator state. > > Waiting for the entry to

Re: [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE

2025-05-27 Thread James Bottomley
On Tue, 2025-05-27 at 15:15 +0200, Alexey Gladkov wrote: > Since MODULE_DEVICE_TABLE no longer depends on whether the module is > built separately or compiled into the kernel, it now makes sense to > always define DEVICE_TABLE. In this case, even if the module is in > the > kernel, correct module.b

Re: [PATCH] rust: kunit: use crate-level mapping for `c_void`

2025-05-27 Thread Benno Lossin
t; > Hmm... But the prelude isn't there yet in this patch, no? i.e. our > prelude is (so far) not a "real prelude" that gets injected > automatically. So I guess you mean importing the prelude instead. Ah right it's only auto-imported in the doctests. Forgot that, wo

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-05-27 Thread Mina Almasry
On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen wrote: > > Fast path results: > > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns > > > > ptr_ring results: > > no-softirq-page_pool02 Per elem: 527 cycles(tsc) 195.187 ns > > > > slow path results: > > no-softirq-page_pool03 Per elem

Re: [PATCH v4 1/5] ASoC: dt-bindings: qcom,sm8250: Add Fairphone 5 sound card

2025-05-27 Thread Rob Herring
On Wed, May 07, 2025 at 10:01:37AM +0200, Luca Weiss wrote: > Document the bindings for the sound card on Fairphone 5 which uses the > older non-audioreach audio architecture. > > Acked-by: Rob Herring (Arm) > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/sound/qcom,sm8250

[RFC PATCH net-next v2 1/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-27 Thread Bui Quang Minh
Currently, in zerocopy mode with mergeable receive buffer, virtio-net does not support multi buffer but a single buffer only. This commit adds support for multi mergeable receive buffer in the zerocopy XDP path by utilizing XDP buffer with frags. Signed-off-by: Bui Quang Minh --- drivers/net/vir

Re: [External] : Re: [PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread ALOK TIWARI
On 28-05-2025 00:42, David Hildenbrand wrote:   /*    * Test if we could add memory without creating too much offline memory - - * to avoid running OOM if memory is getting onlined deferred. + * to avoid running OOM if memory is getting online deferred. The system/user is onlining the me

Re: [PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread David Hildenbrand
/* * Test if we could add memory without creating too much offline memory - - * to avoid running OOM if memory is getting onlined deferred. + * to avoid running OOM if memory is getting online deferred. The system/user is onlining the memory, so the memory is getting "onlined"? If it wo

Re: [PATCH net v2] vsock/test: Fix occasional failure in SOCK_STREAM SHUT_RD test

2025-05-27 Thread Konstantin Shkolnyy
On 26-May-25 08:55, Stefano Garzarella wrote: BTW I think I already fixed the same issue in this series: https://lore.kernel.org/netdev/20250514141927.159456-1-sgarz...@redhat.com/ Can you check it? Yes, it looks like the same issue.

[PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE

2025-05-27 Thread Alexey Gladkov
Since MODULE_DEVICE_TABLE no longer depends on whether the module is built separately or compiled into the kernel, it now makes sense to always define DEVICE_TABLE. In this case, even if the module is in the kernel, correct module.builtin.modaliases will be generated. Suggested-by: James Bottomley

[PATCH 2/3] virtio-mem: fix multiple typos in struct comments and function docs

2025-05-27 Thread Alok Tiwari
Corrected several spelling mistakes in code comments, including: - "bock" -> "block" - "valued" -> "value" - "actipn" -> "action" - "accidentially" -> "accidentally" - Improved grammar in a few places for clarity. These changes are purely cosmetic and do not affect functionality. Signed-off-by: A

[PATCH 3/3] virtio_ring: Fix typos in comments and documentation

2025-05-27 Thread Alok Tiwari
Corrected several typos in virtio_ring.c for improved clarity and consistency. Fixes include: - "dind't" -> "didn't" - "use" -> "uses" in DMA mapping context - "can been used" -> "can be used" - "buf size for sync" -> "buffer size to synchronize" No functional changes. Signed-off-by: Alok Tiwari

[PATCH 1/3] virtio: Fix typo in register_virtio_device() doc comment

2025-05-27 Thread Alok Tiwari
Corrected "suceess" to "success" in the function documentation for clarity. Signed-off-by: Alok Tiwari --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 95d5d7993e5b..2c022640ec4b 100644 --- a/d

[PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-05-27 Thread Mark Brown
The kselftest framework uses the string logged when a test result is reported as the unique identifier for a test, using it to track test results between runs. The gup_longterm test fails to follow this pattern, it runs a single test function repeatedly with various parameters but each result repor

Re: [PATCH bpf-next v3 0/2] bpf, arm64: support up to 12 arguments

2025-05-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Tue, 27 May 2025 12:06:02 +0200 you wrote: > Hello, > > this is the v2 of the many args series for arm64, being itself a revival > of Xu Kuhoai's work to enable larger arguments count for BPF programs on > ARM

[RFC PATCH net-next v2 2/2] selftests: net: add XDP socket tests for virtio-net

2025-05-27 Thread Bui Quang Minh
This adds a test to test the virtio-net rx when there is a XDP socket bound to it. There are tests for both copy mode and zerocopy mode, both cases when XDP program returns XDP_PASS and XDP_REDIRECT to a XDP socket. Signed-off-by: Bui Quang Minh --- .../selftests/drivers/net/hw/.gitignore

[RFC PATCH net-next v2 0/2] virtio-net: support zerocopy multi buffer XDP in mergeable

2025-05-27 Thread Bui Quang Minh
Currently, in zerocopy mode with mergeable receive buffer, virtio-net does not support multi buffer but a single buffer only. This commit adds support for multi mergeable receive buffer in the zerocopy XDP path by utilizing XDP buffer with frags. This happens when the MTU of tap device is set to 90

[PATCH v2 3/4] selftests/mm: Report unique test names for each cow test

2025-05-27 Thread Mark Brown
The kselftest framework uses the string logged when a test result is reported as the unique identifier for a test, using it to track test results between runs. The cow test completely fails to follow this pattern, it runs test functions repeatedly with various parameters with each result report fro

[PATCH v2 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm

2025-05-27 Thread Mark Brown
The cow and gup_longterm test programs open code something that looks a lot like the standard ksft_finished() helper to summarise the test results and provide an exit code, convert to use ksft_finished(). Acked-by: David Hildenbrand Signed-off-by: Mark Brown --- tools/testing/selftests/mm/cow.c

[PATCH v2 0/4] selftests/mm: cow and gup_longterm cleanups

2025-05-27 Thread Mark Brown
The bulk of these changes modify the cow and gup_longterm tests to report unique and stable names for each test, bringing them into line with the expectations of tooling that works with kselftest. The string reported as a test result is used by tooling to both deduplicate tests and track tests bet

[PATCH v2 2/4] selftests/mm: Add helper for logging test start and results

2025-05-27 Thread Mark Brown
Several of the MM tests have a pattern of printing a description of the test to be run then reporting the actual TAP result using a generic string not connected to the specific test, often in a shared function used by many tests. The name reported typically varies depending on the specific result r

[PATCH] rust: replace length checks with match

2025-05-27 Thread Tamir Duberstein
Use a match expression with slice patterns instead of length checks and indexing. The result is more idiomatic, which is a better example for future Rust code authors. Signed-off-by: Tamir Duberstein --- scripts/rustdoc_test_gen.rs | 33 + 1 file changed, 17 inser

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Michael S. Tsirkin
On Tue, May 27, 2025 at 04:39:27PM +0200, Mauro Carvalho Chehab wrote: > > It's up to you though. > > I can keep it in next for now, so it gets some coverage by > > tools scanning that tree. > > Sure, feel free to keep it on next if you prefer so. Just > please don't submit it upstream while we do

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Stefano Garzarella
TAP version 13 > 1..1 > # timeout set to 300 > # selftests: vsock: vmtest.sh > # 1..3 > # ok 0 vm_server_host_client > # ok 1 vm_client_host_server > # ok 2 vm_loopback > # SUMMARY: PASS=3 SKIP=0 FAIL=0 > # Log: /tmp/vsock_vmtest_svEl.log > ok 1 selftests: vsock: vmtest.sh &

Re: [PATCH net-next v2 3/8] net: devmem: preserve sockc_err

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > Preserve the error code returned by sock_cmsg_send and return that on > err. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 1/8] net: devmem: move list_add to net_devmem_bind_dmabuf.

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > It's annoying for the list_add to be outside net_devmem_bind_dmabuf, but > the list_del is in net_devmem_unbind_dmabuf. Make it consistent by > having both the list_add/del be inside the net_devmem_[un]bind_dmabuf. > > Cc: ap420...@gmail.com > Signed-off-by: Mina Al

Re: [PATCH net-next v2 2/8] page_pool: fix ugly page_pool formatting

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > Minor cleanup; this line is badly formatted. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH 2/7] rust: kunit: support checked `-> Result`s in KUnit `#[test]`s

2025-05-27 Thread Miguel Ojeda
On Tue, May 6, 2025 at 8:33 AM David Gow wrote: > > FWIW, having out-of-memory situations trigger a test failure is > consistent with what other KUnit tests (written in C) do. > > There's both advantages and disadvantages to this: on the one hand, > it's prone to false positives (as you mention),

Re: [PATCH net-next v2 4/8] net: devmem: ksft: add ipv4 support

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > ncdevmem supports both ipv4 and ipv6, but the ksft is currently > ipv6-only. Propagate the ipv4 support to the ksft, so that folks that > are limited to these networks can also test. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

Re: [PATCH net-next v2 6/8] net: devmem: ksft: add 5 tuple FS support

2025-05-27 Thread Stanislav Fomichev
On 05/23, Mina Almasry wrote: > ncdevmem supports drivers that are limited to either 3-tuple or 5-tuple > FS support, but the ksft is currently 3-tuple only. Support drivers that > have 5-tuple FS supported by adding a ksft arg. > > Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev

[PATCH v2 3/3] KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width

2025-05-27 Thread Sebastian Ott
arch_timer_edge_cases uses ~0 as the maximum counter value, however there's no architectural guarantee that this is valid. Figure out the effective counter width based on the effective frequency like it's done by the kernel. Note that the following subtest only worked since the counter initialize

[PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary

2025-05-27 Thread Alexey Gladkov
Define MODULE_DEVICE_TABLE only if a structure is defined for it. drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier 'blogic_pci_tbl' 3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl); Fixes: 1079a2d251f2 ("[SCSI] BusLogic: stop using check_region") Cc: Khalid Aziz Cc: "James E

Re: [PATCH v4 1/2] livepatch, x86/module: Generalize late module relocation locking.

2025-05-27 Thread Petr Mladek
, pmod); > - return 0; > + if (!early) > + mutex_lock(&text_mutex); I understand why you do this but it opens some questions. As this patch suggests, the "text_mutex" has been used to sychronize apply_relocate_add() only on x86_64 so far. s390x seems to

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
t; > It sounds that you applied this one at the virtio tree, but it > > > > > > hasn't > > > > > > being reviewed or acked by media maintainers. > > > > > > > > > > > > Please drop it. > > > > > &

[PATCH v2 1/3] KVM: arm64: selftests: fix help text for arch_timer_edge_cases

2025-05-27 Thread Sebastian Ott
Fix the help text for arch_timer_edge_cases to show the correct option for setting the wait time. Signed-off-by: Sebastian Ott --- tools/testing/selftests/kvm/arm64/arch_timer_edge_cases.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/arm64/arch_

[PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-05-27 Thread Sebastian Ott
Some small fixes for arch_timer_edge_cases that I stumbled upon while debugging failures for this selftest on ampere-one. Changes since v1: modified patch 3 based on suggestions from Marc. I've done some tests with this on various machines - seems to be all good, however on ampere-one I no

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Mauro Carvalho Chehab
ocess is allowed to have exclusive streaming access to the device: all other opens on the same device get permission denied (by default - there is an optional ioctl that allows a process to "abdicate" its streaming rights). We need to double-check how this is implemented and how this wou

[PATCH v2 2/3] KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases

2025-05-27 Thread Sebastian Ott
arch_timer_edge_cases tries to migrate itself across host cpus. Before the first test it migrates to cpu 0 by setting up an affinity mask with only bit 0 set. After that it looks for the next possible cpu in the current affinity mask which still has only bit 0 set. So there is no migration at all.

Re: [PATCH net-next v8] selftests/vsock: add initial vmtest.sh for vsock

2025-05-27 Thread Bobby Eshleman
m_server_host_client > > # ok 1 vm_client_host_server > > # ok 2 vm_loopback > > # SUMMARY: PASS=3 SKIP=0 FAIL=0 > > # Log: /tmp/vsock_vmtest_svEl.log > > ok 1 selftests: vsock: vmtest.sh > > > > Future work can include vsock_diag_test. > > > &g

[PATCH] virtio: document ENOSPC

2025-05-27 Thread Michael S. Tsirkin
drivers handle ENOSPC specially since it's an error one can get from a working VQ. Document the semantics. Reported-by: Parav Pandit Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_ring.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Michael S. Tsirkin
er this merge window, as it is too late > for it to be applied during this one. > > Regards, > Mauro New drivers generally can be merged during the merge window, especially early. It's up to you though. I can keep it in next for now, so it gets some coverage by tools scanning that t

Re: [PATCH v3] media: add virtio-media driver

2025-05-27 Thread Alexandre Courbot
wed or acked by media maintainers. > > > > > > > > > > Please drop it. > > > > > > > > > > Alexandre, > > > > > > > > > > Please send media patches to media maintainers, c/c other subsystem > > > > > mainta

  1   2   3   4   5   6   7   8   9   10   >