Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Yinghai Lu
On 8/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > My PCI domains patch add support for multiple peer root buses. That's > the definition of PCI domain support. one one segment, we can not have multi peer root buses? > > Branch 'pciseg' of > git://git.kernel.org/pub/scm/linux/kernel/git/jgarz

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Yinghai Lu
On 8/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > > the sysdata stuff try to fix: > > when calgary iommu code was introduced, it is trying to share sysdata > > that orginally is initialized k8_bus.c and used by pcibus_to_node. but > > that only happen with AMD K8 platform. and

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Jeff Garzik
Yinghai Lu wrote: the sysdata stuff try to fix: when calgary iommu code was introduced, it is trying to share sysdata that orginally is initialized k8_bus.c and used by pcibus_to_node. but that only happen with AMD K8 platform. and have nothing to do with calgary. incorrect: sysdata is initial

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Yinghai Lu
On 8/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Muli Ben-Yehuda wrote: > > Strongly agreed. It overall fixes bugs that existing _before_ the > sysdata stuff went in. what are those bugs? the sysdata stuff try to fix: when calgary iommu code was introduced, it is trying to share sysdata that

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Jeff Garzik
Muli Ben-Yehuda wrote: On Tue, Aug 07, 2007 at 03:49:11PM -0700, Andrew Morton wrote: I am sooo tired of this thing. Andi, someone, can we for heaven's sake please just get it all sorted out? With regards to the sysdata conversion: Riku says he cannot test new kernel. I haven't heard any

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Muli Ben-Yehuda
On Tue, Aug 07, 2007 at 03:49:11PM -0700, Andrew Morton wrote: > I am sooo tired of this thing. Andi, someone, can we for heaven's > sake please just get it all sorted out? With regards to the sysdata conversion: Riku says he cannot test new kernel. I haven't heard anything from Andy Whitcro

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-07 Thread Andrew Morton
On Sun, 5 Aug 2007 10:53:07 +0300 Muli Ben-Yehuda <[EMAIL PROTECTED]> wrote: > This patch finishes the i386 and x86-64 ->sysdata conversion and > hopefully also fixes Riku's and Andy's observed bugs. It is based on > Yinghai Lu's and Andy Whitcroft's patches (thanks!) with some changes: > > - int

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Yinghai Lu
On 8/5/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > > pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node) > > x86_pci_scan_root_bus(int bus) > > { > > pci_scan_bus_on_node(bus, &pci_root_ops, -1); > > } > > > > i need node as one param for my patch later in irq.c and

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Jeff Garzik
Yinghai Lu wrote: pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node) x86_pci_scan_root_bus(int bus) { pci_scan_bus_on_node(bus, &pci_root_ops, -1); } i need node as one param for my patch later in irq.c and legacy.c It is a mistake to start coding NUMA details into pci scan functi

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Yinghai Lu
On 8/5/07, Muli Ben-Yehuda <[EMAIL PROTECTED]> wrote: > On Sun, Aug 05, 2007 at 01:49:57AM -0700, Yinghai Lu wrote: > > > Can you change > > pci_scan_bus_with_sysdata(int busno) > > to > > pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node)? > > Do you anticipate passing in a different pci

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Muli Ben-Yehuda
On Sun, Aug 05, 2007 at 01:49:57AM -0700, Yinghai Lu wrote: > Can you change > pci_scan_bus_with_sysdata(int busno) > to > pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node)? Do you anticipate passing in a different pci_ops or node? In any case please remember I am aiming for the minim

Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Yinghai Lu
On 8/5/07, Muli Ben-Yehuda <[EMAIL PROTECTED]> wrote: > This patch finishes the i386 and x86-64 ->sysdata conversion and > hopefully also fixes Riku's and Andy's observed bugs. It is based on > Yinghai Lu's and Andy Whitcroft's patches (thanks!) with some changes: > > - introduce pci_scan_bus_with_

[PATCH/RFT] finish i386 and x86-64 sysdata conversion

2007-08-05 Thread Muli Ben-Yehuda
This patch finishes the i386 and x86-64 ->sysdata conversion and hopefully also fixes Riku's and Andy's observed bugs. It is based on Yinghai Lu's and Andy Whitcroft's patches (thanks!) with some changes: - introduce pci_scan_bus_with_sysdata() and use it instead of pci_scan_bus() where appropri