On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert <[EMAIL PROTECTED]> wrote:
> Al Viro <[EMAIL PROTECTED]> wrote:
> > On Wed, Apr 13, 2005 at 04:17:42AM +0200, Adrian Bunk wrote:
>
> >> This patch fixes two check after use found by the Coverity checker.
> >
> > Bullshit. ->private_data is se
On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert <[EMAIL PROTECTED]> wrote:
> If there are checks, they should be there for a purpose,
emphasis here is on _should_
> and any sane reader will asume these checks to be nescensary.
That's a bad assumptions when you're deadling with drivers or s
Al Viro <[EMAIL PROTECTED]> wrote:
> On Wed, Apr 13, 2005 at 04:17:42AM +0200, Adrian Bunk wrote:
>> This patch fixes two check after use found by the Coverity checker.
>
> Bullshit. ->private_data is set by rme96xx_open() to guaranteed non-NULL
> and never changed elsewhere. Same comment about
On Wed, Apr 13, 2005 at 04:17:42AM +0200, Adrian Bunk wrote:
> This patch fixes two check after use found by the Coverity checker.
Bullshit. ->private_data is set by rme96xx_open() to guaranteed non-NULL
and never changed elsewhere. Same comment about reading the fscking
source, BUG_ON(), etc.
-
This patch fixes two check after use found by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 27 Mar 2005
--- linux-2.6.12-rc1-mm3-full/sound/oss/rme96xx.c.old 2005-03-27
23:16:02.0 +0200
+++ linux-2.6.12-rc1-mm3-full/sound/o
This patch fixes two check after use found by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-full/sound/oss/rme96xx.c.old 2005-03-27
23:16:02.0 +0200
+++ linux-2.6.12-rc1-mm3-full/sound/oss/rme96xx.c 2005-03-27
23:16:11.0 +0
6 matches
Mail list logo