Re: [PATCH net v3] selftest:net: Fix uninit return values

2025-10-01 Thread Simon Horman
On Tue, Sep 30, 2025 at 03:17:02PM +0530, Sidharth Seela wrote: > On Tue, Sep 30, 2025 at 2:39 PM Simon Horman wrote: > > Hi, > > > > I don't want to block progress. > > But there are some format problems with the commit message. > > > > Locally, git tr

Re: [PATCH net-next] selftests/net: add tcp_port_share to .gitignore

2025-09-30 Thread Simon Horman
'm not entirely sure this qualifies for a fixes tag. It is user-visible. It's probably annoying. But I'm not sure it's a bug. > Signed-off-by: Gopi Krishna Menon > --- > tools/testing/selftests/net/.gitignore | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: S

[PATCH net-next v5 4/8] TUN & TAP: Wake netdev queue after consuming an entry

2025-09-29 Thread Simon Schippers
On 29.09.25 00:33, Michael S. Tsirkin wrote: > On Sun, Sep 28, 2025 at 11:27:25PM +0200, Simon Schippers wrote: >> On 23.09.25 18:36, Michael S. Tsirkin wrote: >>> On Tue, Sep 23, 2025 at 12:15:49AM +0200, Simon Schippers wrote: >>>> The new wrappers tun_ring_cons

Re: [PATCH v2] selftest: net: Fix error message if empty variable

2025-09-26 Thread Simon Horman
; The issue can be reproduced with the command: > make kselftest TARGETS=net > > It solves the error: > ./tfo_passive.sh: line 98: [: -eq: unary operator expected > > Signed-off-by: Alessandro Zanni > --- > > Notes: > v2: edit condition to handle strings Thanks. T

Re: [PATCH net] vhost: vringh: Fix copy_to_iter return value check

2025-09-26 Thread Simon Horman
quot;) And nicer still to include some description of the failure scenario. In any case, the code change looks good to me. Reviewed-by: Simon Horman

Re: [PATCH] selftest: net: Fix error message if empty variable

2025-09-25 Thread Simon Horman
On Thu, Sep 25, 2025 at 01:04:07AM +0200, Alessandro Zanni wrote: > Fix to avoid cases where the `res` shell variable is > empty in script comparisons. > > The issue can be reproduced with the command: > make kselftest TARGETS=net > > It solves the error: > ./tfo_passive.sh: line 98: [: -eq: unar

[PATCH net-next v5 0/8] TUN/TAP & vhost_net: netdev queue flow control to avoid ptr_ring tail drop

2025-09-25 Thread Simon Schippers
n_net_xmit and removed unnecessary netif_tx_wake_queue in tun_ring_recv. Thanks, Simon :) Simon Schippers (8): __ptr_ring_full_next: Returns if ring will be full after next insertion Move the decision of invalidation out of __ptr_ring_discard_one TUN, TAP & vhost_net: Stop netdev queu

[PATCH net-next v5 3/8] TUN, TAP & vhost_net: Stop netdev queue before reaching a full ptr_ring

2025-09-25 Thread Simon Schippers
of trans_start in tun_net_xmit is also removed. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- drivers/net/tun.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 86a9e927d

Re: [PATCH net-next v5 4/8] TUN & TAP: Wake netdev queue after consuming an entry

2025-09-24 Thread Simon Schippers
On 24.09.25 09:49, Michael S. Tsirkin wrote: > On Wed, Sep 24, 2025 at 09:42:45AM +0200, Simon Schippers wrote: >> On 24.09.25 08:55, Michael S. Tsirkin wrote: >>> On Wed, Sep 24, 2025 at 07:56:33AM +0200, Simon Schippers wrote: >>>> On 23.09.25 18:36, Michael S. Ts

[PATCH net-next v5 0/8] TUN/TAP & vhost_net: netdev queue flow control to avoid ptr_ring tail drop

2025-09-23 Thread Simon Schippers
On 23.09.25 16:55, Michael S. Tsirkin wrote: > On Tue, Sep 23, 2025 at 12:15:45AM +0200, Simon Schippers wrote: >> This patch series deals with TUN, TAP and vhost_net which drop incoming >> SKBs whenever their internal ptr_ring buffer is full. Instead, with this >> patch s

[PATCH net-next v5 4/8] TUN & TAP: Wake netdev queue after consuming an entry

2025-09-23 Thread Simon Schippers
On 23.09.25 18:36, Michael S. Tsirkin wrote: > On Tue, Sep 23, 2025 at 12:15:49AM +0200, Simon Schippers wrote: >> The new wrappers tun_ring_consume/tap_ring_consume deal with consuming an >> entry of the ptr_ring and then waking the netdev queue when entries got >> invalidate

[PATCH net-next v5 5/8] TUN & TAP: Provide ptr_ring_consume_batched wrappers for vhost_net

2025-09-22 Thread Simon Schippers
guarantees that the information about the netdev queue being stopped is visible after __ptr_ring_peek is called. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- drivers/net/tap.c | 52 drivers/net/tun.c

[PATCH net-next v5 6/8] TUN & TAP: Provide ptr_ring_unconsume wrappers for vhost_net

2025-09-22 Thread Simon Schippers
Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- drivers/net/tap.c | 9 + drivers/net/tun.c | 9 + include/linux/if_tap.h | 4 include/linux/if_tun.h | 5 + 4 files changed, 27 insertions(+) diff --git a/drivers/net

[PATCH net-next v5 2/8] Move the decision of invalidation out of __ptr_ring_discard_one

2025-09-22 Thread Simon Schippers
Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- include/linux/ptr_ring.h | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h index c45e95071d7e..78fb3efedc7a 100644 --- a/include

[PATCH net-next v5 1/8] __ptr_ring_full_next: Returns if ring will be full after next insertion

2025-09-22 Thread Simon Schippers
Useful if the caller would like to act before the ptr_ring gets full after the next __ptr_ring_produce call. Because __ptr_ring_produce has a smp_wmb(), taking action before ensures memory ordering. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers

Re: [PATCH RFC net-next 4/7] net: ethtool: add get_rxrings callback to optimize RX ring queries

2025-09-17 Thread Simon Horman
On Fri, Sep 05, 2025 at 10:07:23AM -0700, Breno Leitao wrote: > Add a new optional get_rxrings callback in ethtool_ops to allow drivers > to provide the number of RX rings directly without going through the > full get_rxnfc flow classification interface. > > Modify ethtool_get_rxrings() to use get

Re: [PATCH v2 net 0/2] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py

2025-09-17 Thread Simon Horman
On Tue, Sep 09, 2025 at 01:13:51PM +0300, Carolina Jubran wrote: > This series fixes issues in devlink_rate_tc_bw.py selftest that made > its checks unreliable and its documentation inconsistent with the > actual configuration. > > V2: > - Dropped the patch that relaxed the total bandwidth check.

Re: [PATCH v2 net 2/2] selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py

2025-09-11 Thread Simon Horman
viewed-by: Cosmin Ratiu > Reviewed-by: Nimrod Oren Reviewed-by: Simon Horman

Re: [PATCH v2 net 1/2] selftests: drv-net: Fix and clarify TC bandwidth split in devlink_rate_tc_bw.py

2025-09-11 Thread Simon Horman
ftests: drv-net: Add test for devlink-rate traffic > class bandwidth distribution") > Tested-by: Carolina Jubran > Signed-off-by: Carolina Jubran > Reviewed-by: Cosmin Ratiu > Reviewed-by: Nimrod Oren Reviewed-by: Simon Horman

Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

2025-09-11 Thread Simon Horman
eanup. > > Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib > dependency is properly cleaned. > > Signed-off-by: Nai-Chen Cheng Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested

[PATCH 4/4] netdev queue flow control for vhost_net

2025-09-10 Thread Simon Schippers
Jason Wang wrote: > On Wed, Sep 3, 2025 at 9:52 PM Willem de Bruijn > wrote: >> >> Jason Wang wrote: >>> On Wed, Sep 3, 2025 at 5:31 AM Willem de Bruijn >>> wrote: >>>> >>>> Simon Schippers wrote: >>>>> Stopping the que

Re: [PATCH net v3 3/3] selftest: netcons: create a torture test

2025-09-08 Thread Simon Horman
leak-v1-1-34a181977...@debian.org/ > [1] > Signed-off-by: Breno Leitao > Reviewed-by: Andre Carvalho Reviewed-by: Simon Horman

Re: [PATCH net v3 2/3] selftest: netcons: refactor target creation

2025-09-08 Thread Simon Horman
t; arbitrary parameters and no sleep. > > The new helper will be utilized by forthcoming torture-type selftests > that require dynamic target management. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net v3 1/3] netpoll: fix incorrect refcount handling causing incorrect cleanup

2025-09-08 Thread Simon Horman
which is clearly reported by > kmemleak. > > Revert commit efa95b01da18 ("netpoll: fix use after free") and adds > clarifying comments emphasizing that npinfo cleanup should only happen > once the refcount reaches zero, ensuring stable and correct netpoll > behavior. > > Cc: sta...@vger.kernel.org > Cc: j...@jvosburgh.net > Fixes: efa95b01da18 ("netpoll: fix use after free") > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

[PATCH net-next v4 0/4] TUN/TAP & vhost_net: netdev queue flow control to avoid ptr_ring tail drop

2025-09-03 Thread Simon Schippers
Jason Wang wrote: > On Tue, Sep 2, 2025 at 4:10 PM Simon Schippers > wrote: >> >> This patch series deals with TUN/TAP and vhost_net which drop incoming >> SKBs whenever their internal ptr_ring buffer is full. Instead, with this >> patch series, the associated netde

[PATCH 2/4] netdev queue flow control for TUN

2025-09-03 Thread Simon Schippers
Michael S. Tsirkin wrote: > On Tue, Sep 02, 2025 at 10:09:55AM +0200, Simon Schippers wrote: >> The netdev queue is stopped in tun_net_xmit after inserting an SKB into >> the ring buffer if the ring buffer became full because of that. If the >> insertion into the ptr_ring fa

Re: [PATCH 2/4] netdev queue flow control for TUN

2025-09-03 Thread Simon Schippers
Michael S. Tsirkin wrote: > On Tue, Sep 02, 2025 at 10:09:55AM +0200, Simon Schippers wrote: >> The netdev queue is stopped in tun_net_xmit after inserting an SKB into >> the ring buffer if the ring buffer became full because of that. If the >> insertion into the ptr_ring fa

[PATCH 2/4] netdev queue flow control for TUN

2025-09-03 Thread Simon Schippers
Jason Wang wrote: > On Tue, Sep 2, 2025 at 4:10 PM Simon Schippers > wrote: >> >> The netdev queue is stopped in tun_net_xmit after inserting an SKB into >> the ring buffer if the ring buffer became full because of that. If the >> insertion into the ptr_ring f

[PATCH 2/4] netdev queue flow control for TUN

2025-09-03 Thread Simon Schippers
Willem de Bruijn wrote: > Simon Schippers wrote: >> The netdev queue is stopped in tun_net_xmit after inserting an SKB into >> the ring buffer if the ring buffer became full because of that. If the >> insertion into the ptr_ring fails, the netdev queue is also stopped and

[PATCH 1/4] ptr_ring_spare: Helper to check if spare capacity of size cnt is available

2025-09-03 Thread Simon Schippers
Michael S. Tsirkin wrote: > On Tue, Sep 02, 2025 at 10:09:54AM +0200, Simon Schippers wrote: >> The implementation is inspired by ptr_ring_empty. >> >> Co-developed-by: Tim Gebauer >> Signed-off-by: Tim Gebauer >> Signed-off-by: Simon Schippers >>

[PATCH 2/4] netdev queue flow control for TUN

2025-09-03 Thread Simon Schippers
Gebauer Signed-off-by: Simon Schippers --- drivers/net/tun.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index cc6c50180663..735498e221d8 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1060,13

[PATCH 4/4] netdev queue flow control for vhost_net

2025-09-02 Thread Simon Schippers
. Then, each time after consuming a batch in vhost_net_buf_produce, wake_netdev_queue is called. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- drivers/net/tap.c | 6 ++ drivers/net/tun.c | 6 ++ drivers/vhost/net.c| 34

[PATCH net-next v4 0/4] TUN/TAP & vhost_net: netdev queue flow control to avoid ptr_ring tail drop

2025-09-02 Thread Simon Schippers
ny packet drops that happened rarely before - Use safer logic for vhost_net using RCU read locks to access TUN/TAP data V2 -> V3: Added support for TAP and TAP+vhost_net. V1 -> V2: Removed NETDEV_TX_BUSY return case in tun_net_xmit and removed unnecessary netif_tx_wake_queue in tun_ring_

[PATCH 3/4] netdev queue flow control for TAP

2025-09-02 Thread Simon Schippers
method ptr_ring_spare. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- drivers/net/tap.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 1197f245e873..4d874672bcd7 100644 --- a

[PATCH 1/4] ptr_ring_spare: Helper to check if spare capacity of size cnt is available

2025-09-02 Thread Simon Schippers
The implementation is inspired by ptr_ring_empty. Co-developed-by: Tim Gebauer Signed-off-by: Tim Gebauer Signed-off-by: Simon Schippers --- include/linux/ptr_ring.h | 71 1 file changed, 71 insertions(+) diff --git a/include/linux/ptr_ring.h b

Re: [PATCH net-next] net: selftests: clean up tools/testing/selftests/net/lib/py/utils.py

2025-09-02 Thread Simon Horman
bility and maintainability without > affecting functionality. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH v3] selftests: net: avoid memory leak

2025-09-01 Thread Simon Horman
2: > - add the label to use instead of directly to use on each case. Reviewed-by: Simon Horman

Re: [PATCH 1/3] selftests: drv-net: Fix and clarify TC bandwidth split in devlink_rate_tc_bw.py

2025-09-01 Thread Simon Horman
ftests: drv-net: Add test for devlink-rate traffic > class bandwidth distribution") > Tested-by: Carolina Jubran > Signed-off-by: Carolina Jubran > Reviewed-by: Cosmin Ratiu > Reviewed-by: Nimrod Oren Reviewed-by: Simon Horman

Re: [PATCH 2/3] selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py

2025-09-01 Thread Simon Horman
viewed-by: Cosmin Ratiu > Reviewed-by: Nimrod Oren Reviewed-by: Simon Horman

Re: [PATCH 3/3] selftests: drv-net: Relax total BW check in devlink_rate_tc_bw.py

2025-09-01 Thread Simon Horman
bandwidth distribution") > Tested-by: Carolina Jubran > Signed-off-by: Carolina Jubran > Reviewed-by: Cosmin Ratiu > Reviewed-by: Nimrod Oren Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH] selftests/net: openvswitch: Fix spelling error in print message

2025-08-29 Thread Simon Horman
+ Aaron Conole, Praveen Balakrishnan On Tue, Aug 26, 2025 at 06:34:15PM +0100, Simon Horman via dev wrote: > On Thu, Aug 14, 2025 at 11:30:01PM +0530, Madhur Kumar wrote: > > Fix a typo in a print statement in ovs-dpctl.py: > > "Unkonwn" → "Unknown". > &

Re: [PATCH] selftests: net: fix spelling and grammar mistakes

2025-08-29 Thread Simon Horman
tional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan Reviewed-by: Simon Horman

Re: [PATCH v2] selftests: net: avoid memory leak

2025-08-28 Thread Simon Horman
. Thanks for the update. Reviewed-by: Simon Horman

Re: [PATCH] selftests: net: avoid memory leak

2025-08-27 Thread Simon Horman
On Tue, Aug 26, 2025 at 11:15:40AM +0800, Zongmin Zhou wrote: > From: Zongmin Zhou > > The buffer be used without free,fix it to avoid memory leak. I'm assuming this is a short-lived user-space program. And any memory is freed when it exits. So I'm unsure about the value of this change. > > Si

Re: [PATCH net] ipvs: Fix estimator kthreads preferred affinity

2025-08-27 Thread Simon Horman
otplug events and CPU > isolation constraints. > > Fixes: d1a89197589c ("kthread: Default affine kthread to its preferred NUMA > node") > Signed-off-by: Frederic Weisbecker Acked-by: Simon Horman

Re: [PATCH] selftests/net: openvswitch: Fix spelling error in print message

2025-08-26 Thread Simon Horman
On Thu, Aug 14, 2025 at 11:30:01PM +0530, Madhur Kumar wrote: > Fix a typo in a print statement in ovs-dpctl.py: > "Unkonwn" → "Unknown". Hi Madhur, You need to include a Signed-off-by line here. Please see [1] and [2]. [1] https://docs.kernel.org/process/submitting-patches.html#developer-s-ce

Re: [PATCH net v2] selftests: netfilter: ipvs.sh: Explicity disable rp_filter on interface tunl0

2025-07-26 Thread Simon Horman
ill include people involved in the commit cited in the Fixes tag. I've CCed Hangbin, to follow that pattern. The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman > > diff --git a/tools/testing/selftests/net/netfilter/ipvs.sh > b/tools/testing/selftests/net/

Re: [PATCH net-next] selftests: net: Skip test if IPv6 is not configured

2025-07-24 Thread Simon Horman
ile does not exist, the script will skip the test with an > appropriate message suggesting to verify if `CONFIG_IPV6` is enabled. > > This prevents the test to misbehave if IPv6 is not configured. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net 2/2] selftests: rtnetlink: add macsec and vlan nesting test

2025-07-22 Thread Simon Horman
On Mon, Jul 21, 2025 at 09:54:23AM -0700, Stanislav Fomichev wrote: > Add reproducer for [0] with a dummy device. > > 0: > https://lore.kernel.org/netdev/2aff4342b0f5b1539c02ffd8df4c7e58dd9746e7.ca...@nvidia.com/ > Signed-off-by: Stanislav Fomichev Reviewed-by: Simon Horman T

Re: [PATCH net 1/2] macsec: set IFF_UNICAST_FLT priv flag

2025-07-22 Thread Simon Horman
hout patch 1/2 applied. Where fails means the kernel panics along the lines of the stack trace in the commit message. Reviewed-by: Simon Horman Tested-by: Simon Horman ...

Re: [PATCH v13] vhost: Reintroduces support of kthread API and adds mode selection

2025-07-16 Thread Simon Horman
On Tue, Jul 15, 2025 at 08:43:45PM +0200, Markus Elfring wrote: > > This patch reintroduces kthread mode for vhost workers and provides > > configuration to select between kthread and task worker. > … > > Is there a need to reconsider the relevance once more for the presented > cover letter? > >

Re: [PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-04 Thread Simon Horman
On Fri, Jul 04, 2025 at 03:32:50PM +0200, Maxime Chevallier wrote: > On Fri, 4 Jul 2025 14:20:19 +0100 > Simon Horman wrote: > > > On Wed, Jul 02, 2025 at 10:28:05AM +0200, Maxime Chevallier wrote: > > > Now that netdevsim supports PHY device simulation, we can start wri

Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

2025-07-04 Thread Simon Horman
On Fri, Jul 04, 2025 at 07:10:37PM +0300, Ido Schimmel wrote: > On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote: > > ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation > > phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to > > net_{err,warn}_

Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

2025-07-04 Thread Simon Horman
On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote: > ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation > phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to > net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited. > > Suggest

Re: [PATCH net-next v2 7/7] selftests: net: Add IPv6 support to netconsole basic tests

2025-07-04 Thread Simon Horman
> > This test would avoid the regression fixed by commit f59902070269 ("net: > netpoll: Initialize UDP checksum field before checksumming") > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next v2 6/7] netpoll: move Ethernet setup to push_eth() helper

2025-07-04 Thread Simon Horman
gt; Signed-off-by: Breno Leitao I note that Jakub's review of v1 has been addressed here. Reviewed-by: Simon Horman

Re: [PATCH net-next v2 4/7] netpoll: factor out IPv4 header setup into push_ipv4() helper

2025-07-04 Thread Simon Horman
gt; by isolating IP version-specific logic. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next v2 5/7] netpoll: factor out UDP header setup into push_udp() helper

2025-07-04 Thread Simon Horman
rn established in previous refactorings. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next v2 3/7] netpoll: factor out IPv6 header setup into push_ipv6() helper

2025-07-04 Thread Simon Horman
y: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next v2 2/7] netpoll: factor out UDP checksum calculation into helper

2025-07-04 Thread Simon Horman
> No functional change intended. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next v2 1/7] netpoll: Improve code clarity with explicit struct size calculations

2025-07-04 Thread Simon Horman
of(*ip6h)` with `sizeof(struct ipv6hdr)` > 3. Replaces `sizeof(*iph)` with `sizeof(struct iphdr)` > > This will make it easy to move code in the upcoming patches. > > No functional changes are introduced by this patch. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman

Re: [PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-04 Thread Simon Horman
On Wed, Jul 02, 2025 at 10:28:05AM +0200, Maxime Chevallier wrote: > Now that netdevsim supports PHY device simulation, we can start writing > some tests to cover a little bit all PHY-related ethtool commands. > > So far we only test the basic use of "ethtool --show-phys", with : > - A simple com

Re: [PATCH net-next 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-04 Thread Simon Horman
On Wed, Jul 02, 2025 at 10:28:03AM +0200, Maxime Chevallier wrote: > With the introduction of phy_link_topology, we have the ability to keep > track of PHY devices that sit behind a net_device. While we still can > only attach one single PHY to a netdev, we can look at all these PHYs > through netl

Re: [PATCH net-next 2/2] selftests: seg6: fix instaces typo in comments

2025-06-30 Thread Simon Horman
nks, With this patch in place I see that codespell only flags false-positives for tools/testing/selftests/net/srv6_* Reviewed-by: Simon Horman

Re: [PATCH net-next v1 2/2] selftests: pp-bench: remove page_pool_put_page wrapper

2025-06-30 Thread Simon Horman
On Fri, Jun 27, 2025 at 08:04:52PM +, Mina Almasry wrote: > Minor cleanup: remove the pointless looking _ wrapper around > page_pool_put_page, and just do the call directly. > > Signed-off-by: Mina Almasry Reviewed-by: Simon Horman

Re: [PATCH net-next v1 1/2] selftests: pp-bench: remove unneeded linux/version.h

2025-06-30 Thread Simon Horman
lore.kernel.org/oe-kbuild-all/202506271434.gk0epc9h-...@intel.com/ > Signed-off-by: Mina Almasry Reviewed-by: Simon Horman

Re: [PATCH] selftests: net: fix resource leak in napi_id_helper.c

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 09:03:07PM +0530, Malaya Kumar Rout wrote: > Resolve minor resource leaks reported by cppcheck in napi_id_helper.c > > cppcheck output before this patch: > tools/testing/selftests/drivers/net/napi_id_helper.c:37:3: error: Resource > leak: server [resourceLeak] > tools/test

Re: [PATCH net-next v2 4/4] selftests: net: add netpoll basic functionality test

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 04:39:49AM -0700, Breno Leitao wrote: > Add a basic selftest for the netpoll polling mechanism, specifically > targeting the netpoll poll() side. > > The test creates a scenario where network transmission is running at > maximum speed, and netpoll needs to poll the NIC. Thi

Re: [PATCH net-next v2 0/4] selftest: net: Add selftest for netpoll

2025-06-26 Thread Simon Horman
On Wed, Jun 25, 2025 at 02:46:04PM -0700, Jakub Kicinski wrote: > On Wed, 25 Jun 2025 19:43:46 +0100 Simon Horman wrote: > > # # Exception| Traceback (most recent call last): > > # # Exception| File > > "/home/virtme/testing-17/tools/testing/selftests/net/lib/py/k

Re: [PATCH net-next v2 0/4] selftest: net: Add selftest for netpoll

2025-06-25 Thread Simon Horman
+ Stan On Wed, Jun 25, 2025 at 04:39:45AM -0700, Breno Leitao wrote: > I am submitting a new selftest for the netpoll subsystem specifically > targeting the case where the RX is polling in the TX path, which is > a case that we don't have any test in the tree today. This is done when > netpoll_pol

Re: [PATCH net-next, v2] selftest: add selftest for anycast notifications

2025-06-19 Thread Simon Horman
;" run_tests > > Cc: Maciej Żenczykowski > Cc: Lorenzo Colitti > Signed-off-by: Yuyang Huang > --- > > Changelog since v1: > - Remote unrelated clean up code. Thanks for the update. Reviewed-by: Simon Horman

Re: [PATCH net-next] selftest: add selftest for anycast notifications

2025-06-18 Thread Simon Horman
On Wed, Jun 18, 2025 at 07:40:25PM +0900, Yuyang Huang wrote: > This commit adds a new kernel selftest to verify RTNLGRP_IPV6_ACADDR > notifications. The test works by adding/removing a dummy interface, > enabling packet forwarding, and then confirming that user space can > correctly receive anycas

Re: Re: [PATCH] vhost: Fix typos in comments and clarity on alignof usage

2025-06-18 Thread Simon Horman
On Wed, Jun 18, 2025 at 01:31:09AM +0530, ALOK TIWARI wrote: > > > Thanks Simon, > > On 6/18/2025 12:07 AM, Simon Horman wrote: > > On Sun, Jun 15, 2025 at 10:39:11AM -0700, Alok Tiwari wrote: > > > This patch fixes multiple typos and improves commen

Re: [PATCH] vhost: Fix typos in comments and clarity on alignof usage

2025-06-17 Thread Simon Horman
On Sun, Jun 15, 2025 at 10:39:11AM -0700, Alok Tiwari wrote: > This patch fixes multiple typos and improves comment clarity across > vhost.c. > - Correct spelling errors: "thead" -> "thread", "RUNNUNG" -> "RUNNING" > and "available". > - Improve comment by replacing informal comment ("Supersize m

Re: [PATCH v2 2/2] vhost: vringh: Remove unused functions

2025-06-17 Thread Simon Horman
t; commit f87d0fbb5798 ("vringh: host-side implementation of virtio rings.") > but have remained unused. > > Remove them and the two helper functions they used. > > Signed-off-by: Dr. David Alan Gilbert Thanks for the update. Reviewed-by: Simon Horman

Re: [PATCH v2] selftests: nettest: Fix typo in log and error messages for clarity

2025-06-16 Thread Simon Horman
nges improve readability and aid in debugging test output. > > Signed-off-by: Alok Tiwari > --- > v1 ->v2 > remove extra space Reviewed-by: Simon Horman

Re: [PATCH 2/2] vhost: vringh: Remove unused functions

2025-06-16 Thread Simon Horman
On Sat, Jun 14, 2025 at 12:07:31AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The functions: > vringh_abandon_kern() > vringh_abandon_user() > vringh_iov_pull_kern() and > vringh_iov_push_kern() > were all added in 2013 by > commit f87d0fbb5798 ("vringh: host-sid

Re: [PATCH 1/2] vhost: vringh: Remove unused iotlb functions

2025-06-16 Thread Simon Horman
9ad9c49cfe97 ("vringh: IOTLB support") > but have remained unused. > > Remove them. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Simon Horman

Re: [PATCH RESEND v10 1/3] vhost: Add a new modparam to allow userspace select kthread

2025-06-03 Thread Simon Horman
On Sat, May 31, 2025 at 05:57:26PM +0800, Cindy Lu wrote: > The vhost now uses vhost_task and workers as a child of the owner thread. > While this aligns with containerization principles, it confuses some > legacy userspace applications, therefore, we are reintroducing kthread > API support. > > A

Re: [PATCH net] selftests: net: build net/lib dependency in all target

2025-05-29 Thread Simon Horman
On Thu, May 29, 2025 at 06:04:17PM +0700, Bui Quang Minh wrote: > On 5/29/25 17:32, Simon Horman wrote: > > On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote: > > > Currently, we only build net/lib dependency in install target. This > > > commit moves tha

Re: [PATCH net] selftests: net: build net/lib dependency in all target

2025-05-29 Thread Simon Horman
On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote: > Currently, we only build net/lib dependency in install target. This > commit moves that to all target so that net/lib is included in in-tree > build and run_tests. Hi, The above describes what is being done. I think it would be goo

Re: [PATCH net-next] selftest: Add selftest for multicast address notifications

2025-05-28 Thread Simon Horman
On Tue, May 27, 2025 at 06:18:55PM +0900, Yuyang Huang wrote: > This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR > and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and > removing a dummy interface and then confirming that the system > correctly receives join and r

Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes

2025-05-23 Thread Simon Horman
tional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan > --- > Changes in v2: > - Resending to full recipient list as requested by Shuah Khan. No code > changes since v1. Thanks, I agree these are all good improvements. Reviewed-by: Simon Horman

Re: [PATCH] selftests: nci: Fix "Electrnoics" to "Electronics"

2025-05-20 Thread Simon Horman
On Fri, May 16, 2025 at 06:59:37PM -0700, Sumanth Gavini wrote: > Fix misspelling reported by codespell > > Signed-off-by: Sumanth Gavini Thanks, With this change this file appears to be codespell-clean. Reviewed-by: Simon Horman

Re: [PATCH] selftests: drv-net: Fix "envirnoments" to "environments"

2025-05-19 Thread Simon Horman
On Fri, May 16, 2025 at 03:51:48PM -0700, Sumanth Gavini wrote: > Fix misspelling reported by codespell > > Signed-off-by: Sumanth Gavini Thanks, With this change this file appears to be codespell-clean. Reviewed-by: Simon Horman ...

Re: [PATCH net v1] selftests: iou-zcrx: Clean up build warnings for error format

2025-05-02 Thread Simon Horman
On Fri, May 02, 2025 at 12:22:20PM +0800, Haiyue Wang wrote: > Clean up two build warnings: > > [1]: > iou-zcrx.c: In function ‘process_recvzc’: > iou-zcrx.c:263:37: warning: too many arguments for > format [-Wformat-extra-args] > 263 | error(1, 0, "payload mismatch at ", i); >

Re: [PATCH v1] selftests: iou-zcrx: Get the page size at runtime

2025-04-24 Thread Simon Horman
On Sat, Apr 19, 2025 at 10:10:15PM +0800, Haiyue Wang wrote: > Use the API `sysconf()` to query page size at runtime, instead of using > hard code number 4096. > > And use `posix_memalign` to allocate the page size aligned momory. > > Signed-off-by: Haiyue Wang Reviewed-by: Simon Horman

Re: [PATCH net 2/2] selftests: mptcp: validate MPJoin HMacFailure counters

2025-04-08 Thread Simon Horman
ed only > in case of corruption, or a wrong implementation, which should not be > the case in these selftests. > > Reviewed-by: Geliang Tang > Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman

Re: [PATCH net 1/2] mptcp: only inc MPJoinAckHMacFailure for HMAC failures

2025-04-08 Thread Simon Horman
") > Cc: sta...@vger.kernel.org > Reviewed-by: Geliang Tang > Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman

Re: [PATCH v2] vsock/virtio: Remove queued_replies pushback logic

2025-04-04 Thread Simon Horman
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote: > Ever since the introduction of the virtio vsock driver, it included > pushback logic that blocks it from taking any new RX packets until the > TX queue backlog becomes shallower than the virtqueue size. > > This logic works fine whe

Re: [PATCH net-next v1 2/2] selftest: net: update proc_net_pktgen (add more imix_weights test cases)

2025-03-20 Thread Simon Horman
On Mon, Mar 17, 2025 at 10:04:01AM +0100, Peter Seiderer wrote: > Add more imix_weights test cases (for incomplete input). > > Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

Re: [PATCH net-next v1 1/2] net: pktgen: add strict buffer parsing index check

2025-03-20 Thread Simon Horman
the buffer index i after every get_user/i++ step and returning > with error code immediately avoids the current indirect (but correct) > error handling. > > Reported-by: Dan Carpenter > Closes: > https://lore.kernel.org/netdev/36cf3ee2-38b1-47e5-a42a-363efeb0ace3@stanley.mountain/ >

Re: [PATCHv4 net 2/2] selftests: bonding: fix incorrect mac address

2025-03-11 Thread Simon Horman
t; Acked-by: Jay Vosburgh > Reviewed-by: Nikolay Aleksandrov > Signed-off-by: Hangbin Liu Reviewed-by: Simon Horman

Re: [PATCHv4 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages

2025-03-11 Thread Simon Horman
s to slave > device") > Acked-by: Jay Vosburgh > Reviewed-by: Nikolay Aleksandrov > Signed-off-by: Hangbin Liu > --- > drivers/net/bonding/bond_options.c | 55 +----- > 1 file changed, 47 insertions(+), 8 deletions(-) Reviewed-by: Simon Horman

Re: [PATCHv5 net 1/3] bonding: fix calling sleeping function in spin lock and some race conditions

2025-03-08 Thread Simon Horman
On Fri, Mar 07, 2025 at 03:19:01AM +, Hangbin Liu wrote: ... > @@ -616,9 +615,22 @@ static void bond_ipsec_del_sa_all(struct bonding *bond) > return; > > mutex_lock(&bond->ipsec_lock); > - list_for_each_entry(ipsec, &bond->ipsec_list, list) { > - if (!ips

Re: [PATCH net-next v7 1/8] net: pktgen: fix mix of int/long

2025-02-27 Thread Simon Horman
just function signatures > > of hex32_arg(), count_trail_chars(), num_arg() and strn_len() accordingly. > > > > Signed-off-by: Peter Seiderer > > Actual missing the rev-by Simon Horman given for the v5 version of the > patch set (see [1]) and indicated in the chang

Re: [PATCH net-next v6 8/8] selftest: net: add proc_net_pktgen

2025-02-25 Thread Simon Horman
On Fri, Feb 21, 2025 at 10:52:46PM +0100, Peter Seiderer wrote: > Add some test for /proc/net/pktgen/... interface. > > - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config > > Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

Re: [PATCH net-next v6 1/8] net: pktgen: fix mix of int/long

2025-02-25 Thread Simon Horman
cordingly. > > Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-25 Thread Simon Horman
On Tue, Feb 25, 2025 at 12:28:24PM +0100, Peter Hilber wrote: > On Mon, Feb 24, 2025 at 05:56:18PM +0000, Simon Horman wrote: > > On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: > > > > ... > > > > > +/** > > > + * vior

Re: [PATCH v5 1/4] virtio_rtc: Add module and driver core

2025-02-24 Thread Simon Horman
On Wed, Feb 19, 2025 at 08:32:56PM +0100, Peter Hilber wrote: ... > +/** > + * VIORTC_MSG() - extract message from message handle > + * @hdl: message handle > + * > + * Return: struct viortc_msg > + */ > +#define VIORTC_MSG(hdl) ((hdl).msg) > + > +/** > + * VIORTC_MSG_INIT() - initialize message

  1   2   3   4   5   6   7   8   9   10   >