On Fri, May 02, 2025 at 12:22:20PM +0800, Haiyue Wang wrote:
> Clean up two build warnings:
>
> [1]:
> iou-zcrx.c: In function ‘process_recvzc’:
> iou-zcrx.c:263:37: warning: too many arguments for
> format [-Wformat-extra-args]
> 263 | error(1, 0, "payload mismatch at ", i);
>
On Sat, Apr 19, 2025 at 10:10:15PM +0800, Haiyue Wang wrote:
> Use the API `sysconf()` to query page size at runtime, instead of using
> hard code number 4096.
>
> And use `posix_memalign` to allocate the page size aligned momory.
>
> Signed-off-by: Haiyue Wang
Reviewed-by: Simon Horman
ed only
> in case of corruption, or a wrong implementation, which should not be
> the case in these selftests.
>
> Reviewed-by: Geliang Tang
> Signed-off-by: Matthieu Baerts (NGI0)
Reviewed-by: Simon Horman
")
> Cc: sta...@vger.kernel.org
> Reviewed-by: Geliang Tang
> Signed-off-by: Matthieu Baerts (NGI0)
Reviewed-by: Simon Horman
On Tue, Apr 01, 2025 at 08:13:49PM +, Alexander Graf wrote:
> Ever since the introduction of the virtio vsock driver, it included
> pushback logic that blocks it from taking any new RX packets until the
> TX queue backlog becomes shallower than the virtqueue size.
>
> This logic works fine whe
On Mon, Mar 17, 2025 at 10:04:01AM +0100, Peter Seiderer wrote:
> Add more imix_weights test cases (for incomplete input).
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
the buffer index i after every get_user/i++ step and returning
> with error code immediately avoids the current indirect (but correct)
> error handling.
>
> Reported-by: Dan Carpenter
> Closes:
> https://lore.kernel.org/netdev/36cf3ee2-38b1-47e5-a42a-363efeb0ace3@stanley.mountain/
>
t; Acked-by: Jay Vosburgh
> Reviewed-by: Nikolay Aleksandrov
> Signed-off-by: Hangbin Liu
Reviewed-by: Simon Horman
s to slave
> device")
> Acked-by: Jay Vosburgh
> Reviewed-by: Nikolay Aleksandrov
> Signed-off-by: Hangbin Liu
> ---
> drivers/net/bonding/bond_options.c | 55 +-----
> 1 file changed, 47 insertions(+), 8 deletions(-)
Reviewed-by: Simon Horman
On Fri, Mar 07, 2025 at 03:19:01AM +, Hangbin Liu wrote:
...
> @@ -616,9 +615,22 @@ static void bond_ipsec_del_sa_all(struct bonding *bond)
> return;
>
> mutex_lock(&bond->ipsec_lock);
> - list_for_each_entry(ipsec, &bond->ipsec_list, list) {
> - if (!ips
just function signatures
> > of hex32_arg(), count_trail_chars(), num_arg() and strn_len() accordingly.
> >
> > Signed-off-by: Peter Seiderer
>
> Actual missing the rev-by Simon Horman given for the v5 version of the
> patch set (see [1]) and indicated in the chang
On Fri, Feb 21, 2025 at 10:52:46PM +0100, Peter Seiderer wrote:
> Add some test for /proc/net/pktgen/... interface.
>
> - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
cordingly.
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Tue, Feb 25, 2025 at 12:28:24PM +0100, Peter Hilber wrote:
> On Mon, Feb 24, 2025 at 05:56:18PM +0000, Simon Horman wrote:
> > On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote:
> >
> > ...
> >
> > > +/**
> > > + * vior
On Wed, Feb 19, 2025 at 08:32:56PM +0100, Peter Hilber wrote:
...
> +/**
> + * VIORTC_MSG() - extract message from message handle
> + * @hdl: message handle
> + *
> + * Return: struct viortc_msg
> + */
> +#define VIORTC_MSG(hdl) ((hdl).msg)
> +
> +/**
> + * VIORTC_MSG_INIT() - initialize message
On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote:
...
> +/**
> + * viortc_ptp_gettimex64() - PTP clock gettimex64 op
> + *
Hi Peter,
Tooling recognises this as a kernel doc, and complains
that there is no documentation present for the function's
parameters: ptp, ts, and sts.
Flagge
On Mon, Feb 17, 2025 at 09:47:40AM -0800, Jakub Kicinski wrote:
> On Sun, 16 Feb 2025 09:17:39 +0000 Simon Horman wrote:
> > On Fri, Feb 14, 2025 at 08:11:45PM -0800, Jakub Kicinski wrote:
> > > On Thu, 13 Feb 2025 12:00:25 +0100 Peter Seiderer wrote:
> > > > Use d
On Thu, Feb 13, 2025 at 12:19:19PM +0100, Peter Seiderer wrote:
> Remove all superfluous index ('i += len') assignements (value not used
> afterwards).
>
> Signed-off-by: Peter Seiderer
> ---
> Changes v4 -> v5
> - new patch (suggested by Simon Horma
$ echo "mpls
> 0f00,0f01,0f02,0f03,0f04,0f05,0f06,0f07,0f08,0f09,0f0a,0f0b,0f0c,0f0d,0f0e,0f0f"
> > /proc/net/pktgen/lo\@0
> -bash: echo: write error: Argument list too long
>
> Signed-off-by: Peter Seiderer
> ---
> Changes v4 -> v5
> - s
cordingly.
>
> Signed-off-by: Peter Seiderer
> ---
> Changes v4 -> v5
> - split up patchset into part i/ii (suggested by Simon Horman)
> - instead of align to most common pattern (int) adjust all usages to
> size_t for i and max and ssize_t for len and adjust funct
= 999" > /proc/net/pktgen/lo\@0
> $ echo "min_pkt_size = 999" > /proc/net/pktgen/lo\@0
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Fri, Feb 14, 2025 at 08:11:45PM -0800, Jakub Kicinski wrote:
> On Thu, 13 Feb 2025 12:00:25 +0100 Peter Seiderer wrote:
> > Use defines for the various dec/hex number parsing digits lengths
> > (hex32_arg/num_arg calls).
>
> I don't understand the value of this patch, TBH.
>
> Example:
>
> +#
On Fri, Feb 07, 2025 at 06:38:41PM -0500, Tamir Duberstein wrote:
> Convert this very simple smoke test to a KUnit test.
Hi Tamir,
I think some text explaining why this change is being made is
warranted here.
>
> Signed-off-by: Tamir Duberstein
> ---
> I tested this using:
>
> $ tools/testing
On Tue, Feb 11, 2025 at 10:29:59AM +0100, Peter Seiderer wrote:
> Hello Simon,
>
> On Thu, 6 Feb 2025 13:25:38 +0000, Simon Horman wrote:
>
> > On Wed, Feb 05, 2025 at 02:11:45PM +0100, Peter Seiderer wrote:
> > > Align some variable declarations (in get_imix
On Wed, Feb 05, 2025 at 02:11:50PM +0100, Peter Seiderer wrote:
> In hex32_arg() and num_arg() error out in case no characters are available
> (maxlen = 0).
>
> Signed-off-by: Peter Seiderer
Hi Peter,
This patch and the following could benefit from:
* A more succinct subject
* An explanation o
actored out 'net: pktgen: num_arg error out in case no valid character
> is parsed' (suggested by Paolo Abeni)
>
> Changes v2 -> v3:
> - no changes
>
> Changes v1 -> v2:
> - additional fix get_imix_entries() and get_labels()
Reviewed-by: Simon Horman
> ---
$ echo "min_pkt_size 123" > /proc/net/pktgen/lo\@0 && grep
> min_pkt_size /proc/net/pktgen/lo\@0
> Params: count 1000 min_pkt_size: 123 max_pkt_size: 0
> Result: OK: min_pkt_size=123
>
> So fix the out-of-bounds access (and some minor findings) and add a simple
> p
On Wed, Feb 05, 2025 at 02:11:45PM +0100, Peter Seiderer wrote:
> Align some variable declarations (in get_imix_entries and get_labels) to
> the most common pattern (int instead of ssize_t/long) and adjust function
> return value accordingly.
>
> Signed-off-by: Peter Seiderer
Hi Peter,
These co
On Wed, Feb 05, 2025 at 02:11:44PM +0100, Peter Seiderer wrote:
> Use defines for the various dec/hex number parsing digits lengths
> (hex32_arg/num_arg calls).
>
> Signed-off-by: Peter Seiderer
> ---
> Changes v3 -> v4
> - new patch (suggested by Simon Horman)
Reviewed-by: Simon Horman
On Wed, Feb 05, 2025 at 02:11:46PM +0100, Peter Seiderer wrote:
> Remove extra tmp variable in pktgen_if_write (re-use len instead).
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Wed, Feb 05, 2025 at 02:11:47PM +0100, Peter Seiderer wrote:
> Remove some superfluous variable initializing before hex32_arg call (as the
> same init is done here already).
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Wed, Feb 05, 2025 at 02:11:48PM +0100, Peter Seiderer wrote:
> Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries
> (instead of up to MAX_MPLS_LABELS - 1).
>
> Fixes:
"Fixes: " has a special meaning, it is recognised as a tag by tooling, and
implies a bug fix. Please consid
$ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0
> $ echo "mpls invalid" > /proc/net/pktgen/lo\@0
> $ grep mpls /proc/net/pktgen/lo\@0
> Result: OK: mpls=
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Mon, Feb 03, 2025 at 06:01:58PM +0100, Peter Seiderer wrote:
> Honour the user given buffer size for the strn_len() calls (otherwise
> strn_len() will access memory outside of the user given buffer).
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
ot;reset" > /proc/net/pktgen/pgctrl
> -bash: echo: write error: Invalid argument
>
> - with patch applied
>
> $ echo -n "reset" > /proc/net/pktgen/pgctrl
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
$ grep "Result:" /proc/net/pktgen/lo\@0
> Result: No such parameter "atep"
>
> - with patch applied
>
> $ echo "ratep 0" > /proc/net/pktgen/lo\@0
> -bash: echo: write error: Invalid argument
> $ grep "Result:" /proc/net/pktgen/lo\@0
> Result: Idle
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
; $ grep "Result:" /proc/net/pktgen/lo\@0
> Result: No such parameter "ate"
>
> - with patch applied
>
> $ echo "rate 0" > /proc/net/pktgen/lo\@0
> -bash: echo: write error: Invalid argument
> $ grep "Result:" /proc/net/pktgen/lo\@0
> Result: Idle
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
mpls: 0123
> Result: OK: mpls=0123
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
; -bash: echo: write error: Unknown error 524
>
> Signed-off-by: Peter Seiderer
Reviewed-by: Simon Horman
On Mon, Feb 03, 2025 at 06:01:59PM +0100, Peter Seiderer wrote:
> Honour the user given buffer size for the hex32_arg(), num_arg(),
> strn_len(), get_imix_entries() and get_labels() calls (otherwise they will
> access memory outside of the user given buffer).
>
> In hex32_arg(), num_arg(), strn_le
On Mon, Feb 03, 2025 at 03:00:37AM -0800, Breno Leitao wrote:
> Hello Simon,
>
> On Mon, Feb 03, 2025 at 10:48:55AM +0000, Simon Horman wrote:
> > On Fri, Jan 31, 2025 at 04:39:38AM -0800, Breno Leitao wrote:
>
> > > +# Validate the message, which has two messages glue
42-43-44-45-46-47-48-49-50-51-52-53-54-55-56-57-58-59-60-
Hi Breno,
I appreciate there is a value in providing the literal data.
But as the data is based mostly of arithmetic sequences
perhaps it would be nicer to express this in a more succinct way.
Regardless, this patch looks good to me.
Reviewed-by: Simon Horman
...
angYuli
This looks good to me.
Reviewed-by: Simon Horman
And I see you also posted an patch to remove the only other in-tree
references from Documentation/translations/zh_CN/dev-tools/ubsan.rst [1].
Thanks.
[1]
https://lore.kernel.org/all/6f05157e5e157493+20250123043258.149643-1-wangy...@uniontech.com/
On Wed, Jan 22, 2025 at 06:16:35PM +, Simon Horman wrote:
> On Wed, Jan 22, 2025 at 03:41:02PM +0100, Peter Seiderer wrote:
> > While taking a look at '[PATCH net] pktgen: Avoid out-of-range in
> > get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid ou
On Wed, Jan 22, 2025 at 03:41:02PM +0100, Peter Seiderer wrote:
> While taking a look at '[PATCH net] pktgen: Avoid out-of-range in
> get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds access
> in get_imix_entries' ([2], [3]) and doing some tests and code review I
> detected th
On Tue, Jan 14, 2025 at 03:43:29PM +0800, liuye wrote:
> Fix the following warning.
I think it is a bit more than a warning, I'd phrase this more like,
even as it repeats the subject. Also, it would be nice to cite
the tool that generates the warning.
Address Null pointer dereference in rtatt
On Mon, Dec 09, 2024 at 09:53:31AM +0100, Antonio Quartulli wrote:
> The ovpn-cli tool can be compiled and used as selftest for the ovpn
> kernel module.
>
> [NOTE: it depends on libmedtls for decoding base64-encoded keys]
>
> ovpn-cli implements the netlink and RTNL APIs and can thus be integrat
On Mon, Dec 09, 2024 at 09:53:17AM +0100, Antonio Quartulli wrote:
> Packets received over the socket are forwarded to the user device.
>
> Implementation is UDP only. TCP will be added by a later patch.
>
> Note: no decryption/decapsulation exists yet, packets are forwarded as
> they arrive with
any change in the code, other than the mechanical
> separation.
>
> Signed-off-by: Breno Leitao
Tested-by: Simon Horman
Reviewed-by: Simon Horman
reate several userdata entries.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
>
> Replace silent ignore mechanism with WARN_ON_ONCE() to highlight
> potential misuse during development and debugging.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
ou need to add netcons_overflow.sh to
tools/testing/selftests/drivers/net/Makefile
Other than that, this looks good to me.
Tested-by: Simon Horman
Reviewed-by: Simon Horman
...
ently not
> * tested here.
> *
Thanks Zhu Jun,
FTR, I'm not sure that I understand the grammar in the comment.
But the spelling correction looks good to me and codespell
doesn't seem to flag any other spelling errors in this file.
So this change looks good to me.
Reviewed-by: Simon Horman
On Tue, Dec 03, 2024 at 08:35:53AM -0800, Joe Damato wrote:
> On Tue, Dec 03, 2024 at 08:26:11AM -0800, Joe Damato wrote:
> > On Mon, Dec 02, 2024 at 09:14:58PM -0800, Stanislav Fomichev wrote:
> > > On 12/03, Joe Damato wrote:
> > > > Fix various integer type conversions by using strtoull and a te
ireGuard secure network tunnel")
> Signed-off-by: Hangbin Liu
> ---
> v2: load the mode directly in case nf_conntrack is build in (Simon Horman)
Thanks for the update.
Reviewed-by: Simon Horman
the netconsole selftest to check for the existence of
> the /sys/bus/netdevsim/new_device file before running the test. If the
> file is not found, the test is skipped with an explanation that the
> CONFIG_NETDEVSIM kernel config option may not be enabled.
>
> Signed-off-by: Bre
On Thu, Nov 07, 2024 at 02:44:18AM +, Hangbin Liu wrote:
> Some distros may not load nf_conntrack by default, which will cause
> subsequent nf_conntrack settings to fail. Let's load this module if it's
> not loaded by default.
>
> Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
>
On Wed, Oct 23, 2024 at 04:13:36PM +0200, Matthieu Baerts wrote:
> Hi Simon,
>
> Thank you for the reviews!
>
> On 23/10/2024 14:21, Simon Horman wrote:
> > On Mon, Oct 21, 2024 at 12:25:27PM +0200, Matthieu Baerts (NGI0) wrote:
> >> mptcp_get_available_schedule
d another test to make sure getsockopt returns the right nkeys
> value when the input nkeys is smaller than the number of matching keys
> - Removed the TODO that this patch addresses
> v1: https://lore.kernel.org/netdev/20241014213313.15100-1-leocst...@gmail.com/
>
> Thanks to the reviewers for their time and feedback!
Thanks for the updates.
Reviewed-by: Simon Horman
would be more appropriate to route this via net-next
(without a fixes tag) rather than via net. But either way this looks good
to me.
Reviewed-by: Simon Horman
...
ed.c. Adding the missing lock/unlock avoids the
> warning.
>
> Fixes: 1730b2b2c5a5 ("mptcp: add sched in mptcp_sock")
> Cc: sta...@vger.kernel.org
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/523
> Reviewed-by: Geliang Tang
> Signed-off-by: Matthieu Baerts (NGI0)
Reviewed-by: Simon Horman
ore assumptions. For the moment, we are not
> interested by the output, only to avoid crashes and warnings.
>
> Signed-off-by: Matthieu Baerts (NGI0)
I am assuming that we are ok with expanding test coverage via net,
which FWIIW, does seem reasonable to me.
Reviewed-by: Simon Horman
...
.
>
> Signed-off-by: Karan Sanghavi
Thanks,
This addresses all the spelling errors in these files that
I see flagged by codespell.
Reviewed-by: Simon Horman
On Thu, Oct 17, 2024 at 03:52:51PM +0800, Liu Jing wrote:
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: Liu Jing
> Signed-off-by: Liu Jing
Thanks,
This is correct. However, it was fixed recently in the same way
by the following commit authored by one of your colleagues, Z
On Thu, Oct 17, 2024 at 11:14:36AM -0700, Anjali Kulkarni wrote:
> Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows
> a thread's non-zero exit status to be returned to proc_filter.
>
> The threads.c program creates 2 child threads. 1st thread handles signal
> SIGSEGV, an
On Thu, Oct 17, 2024 at 11:14:33AM -0700, Anjali Kulkarni wrote:
> Recently we committed a fix to allow processes to receive notifications for
> non-zero exits via the process connector module. Commit is a4c9a56e6a2c.
>
> However, for threads, when it does a pthread_exit(&exit_status) call, the
>
On Tue, Oct 15, 2024 at 10:51:52PM -0700, Leo Stone wrote:
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
>
> Sample output:
>
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filt
_LIST=y. Make sure CIs take advantage
> of CONFIG_PROVE_RCU_LIST=y, recent fixes in networking
> indicate that it does catch bugs.
>
> Signed-off-by: Jakub Kicinski
I exercised this in conjunction with tools/testing/selftests/net/config
and the resulting .config is as described before and after.
Reviewed-by: Simon Horman
On Tue, Oct 15, 2024 at 05:00:06PM +, Karan Sanghavi wrote:
> This patch corrects typographical errors in the "name" fields of
> the JSON objects with IDs "4319" and "4341" in the tc-testing
> selftests.
>
> - "diffferent" is corrected to "different".
> - "muliple" is corrected to "multiple".
On Fri, Oct 11, 2024 at 05:45:31PM -0700, Anjali Kulkarni wrote:
> Kunit tests to test hash table add, delete, duplicate add and delete.
> Add following configs and compile kernel code:
>
> CONFIG_CONNECTOR=y
> CONFIG_PROC_EVENTS=y
> CONFIG_NET=y
> CONFIG_KUNIT=m/y
> CONFIG_CN_HASH_KUNIT_TEST=m/y
On Fri, Oct 11, 2024 at 05:45:30PM -0700, Anjali Kulkarni wrote:
> Add a new type PROC_CN_MCAST_NOTIFY to proc connector API, which allows a
> thread to notify the kernel that it has exited abnormally. Thread can also
> send the exit status code it wants returned in the notification with it.
> Exit
On Fri, Sep 27, 2024 at 12:00:50PM +0800, zhangjiao2 wrote:
> From: zhang jiao
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao
Thanks, this looks good to me.
Reviewed-by: Simon Horman
dd bridge MDB test")
> Signed-off-by: Jamie Bainbridge
> ---
> v2: Avoid false check failures as seen by Jakub Kicinski.
> ---
Reviewed-by: Simon Horman
On Fri, Sep 13, 2024 at 10:39:20AM +0100, Tiago Lam wrote:
> This follows the same rationale provided for the ipv4 counterpart, where
> it now runs a reverse socket lookup when source addresses and/or ports
> are changed, on sendmsg, to check whether egress traffic should be
> allowed to go through
On Thu, Sep 12, 2024 at 10:17:13PM +0200, Alexis Lothoré wrote:
> Hi Simon,
>
> On 9/11/24 16:18, Simon Horman wrote:
>
> [...]
>
> >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c
> >> b/tools/testing/selftests/bpf/prog_tests/xdp_
On Tue, Sep 10, 2024 at 08:10:35PM +0200, Alexis Lothoré (eBPF Foundation)
wrote:
> test_xdp_features.sh is a shell script allowing to test that xdp features
> advertised by an interface are indeed delivered. The test works by starting
> two instance of the same program, both attaching specific xd
ess ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Update commit message.
Thanks for the update.
I checked and I was not able to find any other instances in this file.
Reviewed-by: Simon Horman
On Tue, Sep 03, 2024 at 05:51:11PM +0800, Liu Jing wrote:
> in the do_setcpu, this function does not need to have a return value,
> which is meaningless
>
> Signed-off-by: Liu Jing
Thanks,
I also see that the caller does not check the return value.
Reviewed-by: Simon Horman
On Tue, Sep 03, 2024 at 03:45:19PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni
As mentioned at [1] I think it would be nice if the patch description
was a bit more descriptive.
[1] https://lore.kernel.org/all/20240903152125.ga
On Wed, Aug 21, 2024 at 10:50:47PM +0100, David Woodhouse wrote:
...
> diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c
...
> +#define VMCLOCK_FIELD_PRESENT(_c, _f) \
> + (_c)->size >= (offsetof(struct vmclock_abi, _f) + \
> +si
On Sat, Jul 06, 2024 at 04:14:39PM +0100, David Woodhouse wrote:
> From: David Woodhouse
>
> The vmclock "device" provides a shared memory region with precision clock
> information. By using shared memory, it is safe across Live Migration.
>
> Like the KVM PTP clock, this can convert TSC-based c
me for nf-next, thanks!
>
> Acked-by: Julian Anastasov
Likewise, looks good to me.
Acked-by: Simon Horman
...
ter
Hi Dan, all,
Strictly this is doing two things. But I agree that the "ok" variable in
virtnet_get_hw_stats() was very confusing, and I'm not sure how long it
would have taken me to grasp the fix without that change being here too.
Reviewed-by: Simon Horman
On Thu, Apr 11, 2024 at 06:01:54PM +0800, xu.xi...@zte.com.cn wrote:
> From: hepeilin
nit: it's nicer if this From line matches one of the Signed-off-by lines
From: Peilin He
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when i
On Tue, Mar 26, 2024 at 08:15:56PM +0100, Johannes Berg wrote:
> From: Johannes Berg
>
> The way __print_symbolic() works is limited and inefficient
> in multiple ways:
> - you can only use it with a static list of symbols, but
>e.g. the SKB dropreasons are now a dynamic list
>
> - it buil
On Thu, Mar 14, 2024 at 12:00:27PM -0400, Steven Rostedt wrote:
> On Thu, 14 Mar 2024 15:39:28 +0100
> Paolo Abeni wrote:
>
> > On Wed, 2024-03-13 at 09:34 -0400, Steven Rostedt wrote:
...
> > > Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF
> > > mailbox")
> >
> > chec
On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote:
> Hi Simon,
>
> Thanks for your reply.
>
> On 2024/1/17 17:29, Simon Horman wrote:
> > On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
> > > Use the new KMEM_CACHE() macro instead of dir
probably be targeted at 'nf-next' rather than 'net'.
If it is a fix, then I would suggest targeting it at 'nf'
and providing a Fixes tag.
The above notwithstanding, this looks good to me.
Acked-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 +--
er (linuxtesting.org).
>
> Fixes: 8d8e20e2d7bb ("ipvs: Decrement ttl")
> Signed-off-by: Fedor Pchelkin
Acked-by: Simon Horman
max() is inclusive. So a -1 has been added when needed.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by: Simon Horman
On Tue, Dec 26, 2023 at 04:20:03PM -0800, Chris Lew wrote:
>
>
> On 12/23/2023 5:56 AM, Simon Horman wrote:
> > [Dropped bjorn.anders...@kernel.org, as the correct address seems
> > to be anders...@kernel.org, which is already in the CC list.
> > kernel.org
del() doesn't have any other error return value.
>
> Signed-off-by: Sarannya Sasikumar
Thanks,
I have a suggestion below. But that notwithstanding this change
looks good to me.
Reviewed-by: Simon Horman
> ---
> net/qrtr/ns.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
wonder if it would make things clearer to the reader (me?)
if the return type of service_announce_del was updated void. Because
as things stand -ENODEV may be returned, which implies something might
handle that, even though it doe not.
The above notwithstanding, this change looks good to me.
Reviewed-by: Simon Horman
...
On Wed, Dec 20, 2023 at 01:45:02PM -0800, Mina Almasry wrote:
> Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref
> is always a struct page underneath, but the abstraction allows efforts
> to add support for skb frags not backed by pages.
>
> There is unfortunately 1 instance wher
section protected by a check
> for CONFIG_IPV6.
>
> Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
Tested-by: Simon Horman # build-tested
etree/bindings/reserved-memory/framebuffer.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/memory-region.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml
>
Reviewed-by: Simon Glass
On Thu, Sep 07, 2023 at 12:56:47PM -0700, Sonia Sharma wrote:
> From: Sonia Sharma
>
> The switch statement in netvsc_send_completion() is incorrectly validating
> the length of incoming network packets by falling through to the next case.
> Avoid the fallthrough. Instead break after a case match
On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> [-Wunused-function].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng
wise it would only match the f1
> plane.
Oh okay, I thought f0 was one of the primary planes, but it's not.
Thanks for the explanation.
For the user-space visible change:
Acked-by: Simon Ser
> It should have been an OVERLAY from the beginning. The documentation
> stipulates that there should be an unique PRIMARY plane per CRTC.
Thanks for the quick patch! One comment below…
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Cc: # 5.8+
> Signed-off-by: Paul Cercueil
>
1 - 100 of 1811 matches
Mail list logo
