rved_guest_counters = 0;
> + cpu_pmu->hpmn = pmcr_n;
> + cpu_pmu->partitioned = false;
> + }
>
> /* Add the CPU cycles counter */
> set_bit(ARMV8_PMU_CYCLE_IDX, cpu_pmu->cntr_mask);
> @@ -1516,3 +1553,5 @@ void arch_perf_update_userpage(struct perf_event *event,
> userpg->cap_user_time_zero = 1;
> userpg->cap_user_time_short = 1;
> }
> +
> +module_param(reserved_guest_counters, byte, 0);
Module params are generally discouraged. Since this driver can't be a
module, this is a boot time only option. There's little reason this
can't be a sysfs setting. There's some complexity in changing this
when counters are in use (just reject the change) and when we have
asymmetric PMUs. Alternatively, it could be a sysctl like user access.
Rob
f-by: Krzysztof Kozlowski
> ---
> .../devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm)
I've applied it, but Bjorn should have. If there's been any discussion
and more than 2 weeks pass, you should resend the patch with tags added.
A discussion means "expect another version" to maintainers.
Rob
On Fri, 03 Jan 2025 12:11:59 +0100, Luca Weiss wrote:
> Add the compatible for an 256Kb EEPROM from Puya.
>
> Signed-off-by: Luca Weiss
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring (Arm)
On Fri, 03 Jan 2025 12:11:58 +0100, Luca Weiss wrote:
> Add the vendor prefix for a manufacturer of EEPROM chips among others.
>
> Signed-off-by: Luca Weiss
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring (Arm)
On Fri, 03 Jan 2025 12:11:57 +0100, Luca Weiss wrote:
> Add the compatible for another 128Kb EEPROM from Giantec.
>
> Signed-off-by: Luca Weiss
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm)
eproc/qcom,sm8150-pas.yaml | 7 ++
> 2 files changed, 7 insertions(+), 96 deletions(-)
>
Acked-by: Rob Herring (Arm)
On Thu, 14 Nov 2024 23:07:18 +0100, Jakob Hauser wrote:
> From: Stephan Gerhold
>
> Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the
> Samsung Galaxy S4 Mini Value Edition. By default the panel displays
> everything horizontally flipped, so add "flip-horizontal" to the panel
On Mon, 04 Nov 2024 17:37:02 +0100, Duje Mihanović wrote:
> Hello,
>
> This series adds initial support for the Marvell PXA1908 SoC and
> "samsung,coreprimevelte", a smartphone using the SoC.
>
> USB works and the phone can boot a rootfs from an SD card, but there are
> some warnings in the dme
vas Kandagatla
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 48 +--
> 1 file changed, 34 insertions(+), 14 deletions(-)
>
Acked-by: Rob Herring (Arm)
> Alternatively, if you think grouping these devices (i.e: those represented by
> the -dsp compatibles
> from fsl,dsp and the one represented by the compatible introduced here) under
> the same binding
> is alright we can just branch off from fsl,dsp and fsl,imx-rproc and create a
> new binding for
> these devices. I'm expecting this to be relatively clean as they have the
> same programming
> model.
If it's just add a compatible and nothing else somewhere, I'd do that.
If it's more than that, then I'd make a new binding doc.
Rob
On Tue, 01 Oct 2024 16:37:30 +0200, Duje Mihanović wrote:
> Hello,
>
> This series adds initial support for the Marvell PXA1908 SoC and
> "samsung,coreprimevelte", a smartphone using the SoC.
>
> USB works and the phone can boot a rootfs from an SD card, but there are
> some warnings in the dme
lit this into two separate bindings? For example, with
> > the
> > current binding microchip,ihc-chan-disabled-mask is allowed for the SBI
> > interface, but doesn't look like it belongs there.
>
> I dunno. Part of me says that because this is two compatibles for the
>
s/of/Kconfig b/drivers/of/Kconfig
> index 5142e7d7fef8..53a227ca3a3c 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -2,7 +2,7 @@
> config DTC
> bool
>
> -config GENERIC_BUILTIN_DTB
> +config BUILTIN_DTB
> bool
I'm confused. We can't have the same config option twice, can we?
Rob
On Thu, Sep 05, 2024 at 08:47:40AM +0900, Masahiro Yamada wrote:
> Some architectures embed boot DTBs in vmlinux. A potential issue for
> these architectures is a race condition during parallel builds because
> Kbuild descends into arch/*/boot/dts/ twice.
>
> One build thread is initiated by the '
dtb.init.rodata
> under the arch/ directory, and .init.rodata section otherwise. This will
> be refactored later.
>
> Signed-off-by: Masahiro Yamada
> ---
>
> drivers/of/unittest.c | 2 +-
> scripts/Makefile.dtbs | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring (Arm)
+++
> scripts/Makefile.lib | 115 -
> 5 files changed, 153 insertions(+), 135 deletions(-)
> create mode 100644 scripts/Makefile.dtbs
Reviewed-by: Rob Herring (Arm)
/r/20240619-dt-kselftest-parent-disabled-v1-1-b8f7a8778...@collabora.com
> ---
> tools/testing/selftests/dt/test_unprobed_devices.sh | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Applied. Sorry for missing this.
Rob
6 | #include
| ^~
compilation terminated.
make[3]: *** [scripts/Makefile.lib:434:
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb] Error 1
make[2]: *** [scripts/Makefile.build:490: arch/arm64/boot/dts/qcom] Error 2
make[2]: Target 'arch/arm64/boot/dts/qcom/qcs8300-ride.dtb' not remade because
of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1390:
qcom/qcs8300-ride.dtb] Error 2
make: *** [Makefile:224: __sub-make] Error 2
make: Target 'qcom/qcs8300-ride.dtb' not remade because of errors.
On Wed, Jul 31, 2024 at 2:14 PM Rob Herring (Arm) wrote:
>
> Use of_property_present() and of_property_read_bool() to test
> property presence and read boolean properties rather than
> of_(find|get)_property(). This is part of a larger effort to remove
> callers of of_find_propert
On Thu, 22 Aug 2024 18:09:47 +0100, Abdellatif El Khlifi wrote:
> Add devicetree binding schema for the External Systems remote processors
>
> The External Systems remote processors are provided on the Corstone-1000
> IoT Reference Design Platform via the SSE-710 subsystem.
>
> For more details
On Sun, 04 Aug 2024 06:59:06 +, Lin, Meng-Bo wrote:
> The dts and dtsi add support for msm8916 variant of Samsung Galaxy J3
> SM-J320YZ smartphone released in 2016.
>
> Add a device tree for SM-J320YZ with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - US
data pointers
which is a problem for dynamically allocated nodes which may be freed.
Signed-off-by: Rob Herring (Arm)
---
drivers/nvdimm/of_pmem.c | 2 +-
drivers/nvmem/layouts.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm
allocated nodes which may be freed.
Signed-off-by: Rob Herring (Arm)
---
drivers/remoteproc/imx_dsp_rproc.c | 2 +-
drivers/remoteproc/imx_rproc.c | 2 +-
drivers/remoteproc/xlnx_r5_remoteproc.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc
On Tue, 30 Jul 2024 12:25:08 +0200, Duje Mihanović wrote:
> Hello,
>
> This series adds initial support for the Marvell PXA1908 SoC and
> "samsung,coreprimevelte", a smartphone using the SoC.
>
> USB works and the phone can boot a rootfs from an SD card, but there are
> some warnings in the dme
tree/bindings/soc/qcom/qcom,smd.yaml | 2 +-
> 5 files changed, 38 insertions(+), 46 deletions(-)
>
Reviewed-by: Rob Herring (Arm)
On Thu, 25 Jul 2024 08:42:09 +0700, Dang Huynh wrote:
> This patch series expand F(x)tec Pro1X (QX1050) device tree to support
> various components of the device.
>
> Most notably:
> + SD Card slot
> + Touchscreen
> + MDSS, DRM display panel
> + WLAN (ATH10K)
> + Hall sensor and camera button
>
;)
> Signed-off-by: Adam Skladowski
> ---
> .../devicetree/bindings/interconnect/qcom,msm8953.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm)
8939.yaml | 6 --
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Rob Herring (Arm)
m,msm8937.h | 93 +++
> 2 files changed, 99 insertions(+), 2 deletions(-)
> create mode 100644 include/dt-bindings/interconnect/qcom,msm8937.h
>
Reviewed-by: Rob Herring (Arm)
On Tue, Jul 09, 2024 at 12:22:48PM +0200, Adam Skladowski wrote:
> Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices.
That is obvious. What would be useful is detailing how 8937 is similar
to the existing devices.
>
> Signed-off-by: Adam Skladowski
> ---
> .../bindings/in
m,msm8976.h | 97 +++
> 2 files changed, 107 insertions(+), 5 deletions(-)
> create mode 100644 include/dt-bindings/interconnect/qcom,msm8976.h
Reviewed-by: Rob Herring (Arm)
On Sun, 30 Jun 2024 13:29:13 +, Raymond Hackley wrote:
> Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the
> other Samsung devices based on MSM8226 with only a few minor differences.
>
> The device trees contain initial support with:
> - GPIO keys
> - Regulator haptic
On Thu, 27 Jun 2024 19:30:30 +, Raymond Hackley wrote:
> Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the
> other Samsung devices based on MSM8226 with only a few minor differences.
>
> The device trees contain initial support with:
> - GPIO keys
> - Regulator haptic
On Sun, 23 Jun 2024 14:26:29 +0500, Nikita Travkin wrote:
> This series introduces two msm8916-based LG devices:
>
> - LG Leon LTE (c50)
> - LG LG K10 (m216)
>
> The devices only have basic support for now.
>
> Signed-off-by: Nikita Travkin
> ---
> Anton Bambura (1):
> arm64: dts: qcom:
On Thu, 20 Jun 2024 17:31:40 +0530, Komal Bajaj wrote:
> From: Melody Olvera
>
> Document the compatible for the component used to boot the MPSS on the
> QDU1000 and QRU1000 SoCs.
>
> The QDU1000 and QRU1000 mpss boot process now requires the specification
> of an RMB register space to complet
gt;
> .../bindings/remoteproc/fsl,imx-rproc.yaml| 15 +++
> 1 file changed, 15 insertions(+)
>
Reviewed-by: Rob Herring (Arm)
e [PATCH v5 4/7] remoteproc: core introduce
> rproc_set_rsc_table_on_start function
> as new "st,proc-id" is associated to "st,stm32mp1-m4-tee" compatible
> - update commit message
> - remove Reviewed-by: Rob Herring as patch is updated
> ---
> .../bindings/remoteproc/st,stm32-rproc.yaml | 58 ---
> 1 file changed, 50 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring (Arm)
On Mon, 03 Jun 2024 02:28:55 -0400, Alexandre Messier wrote:
> Add an initial device tree to support the HTC One (M8) smartphone,
> aka "htc,m8".
>
> Signed-off-by: Alexandre Messier
> ---
> Alexandre Messier (2):
> dt-bindings: arm: qcom: add HTC One (M8)
> ARM: dts: qcom: Add init
On Tue, May 21, 2024 at 02:24:54PM +0200, Arnaud Pouliquen wrote:
> Add the "st,proc-id" property allowing to identify the remote processor.
> This ID is used to define an unique ID, common between Linux, U-boot and
> OP-TEE to identify a coprocessor.
> This ID will be used in request to OP-TEE rem
On Fri, 10 May 2024 14:27:07 +0200, Luca Weiss wrote:
> Validated on Fairphone 5 (QCM6490) smartphone by using DisplayPort over
> USB-C audio, connected to a TV, with a basic UCM to enable
> 'DISPLAY_PORT_RX Audio Mixer MultiMedia1':
> https://gitlab.com/postmarketOS/pmaports/-/tree/master/device
/remoteproc/qcom,smd-edge.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm)
/qcom/qcom,smp2p.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm)
On Wed, Apr 24, 2024 at 07:21:51PM +0200, Luca Weiss wrote:
> The qcom,ipc-N properties are essentially providing a reference to a
> mailbox, so allow using the mboxes property to do the same in a more
> structured way.
Can we mark qcom,ipc-N as deprecated then?
> Since multiple SMSM hosts are s
On Wed, 24 Apr 2024 20:42:27 +0200, Duje Mihanović wrote:
> Hello,
>
> This series adds initial support for the Marvell PXA1908 SoC and
> "samsung,coreprimevelte", a smartphone using the SoC.
>
> USB works and the phone can boot a rootfs from an SD card, but there are
> some warnings in the dme
On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote:
> From: Hari Nagalla
>
> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> The remote processor's life cycle management and IPC mechanisms are
> similar across the R5F and M4F cores from remote processor driver
> point o
ray actually is)
range for dimensions are global. So if there's not correct dimensions
for a property, the tools aren't going to decode it properly.
Rob
On Sun, 07 Apr 2024 11:05:10 +0200, Stanislav Jakubek wrote:
> Document the Motorola Moto G (2013), which is a smartphone based
> on the Qualcomm MSM8226 SoC.
>
> Acked-by: Krzysztof Kozlowski
> Signed-off-by: Stanislav Jakubek
> ---
> Changes in V3:
> - no changes
>
> Changes in V2:
> -
On Tue, 02 Apr 2024 22:55:36 +0200, Duje Mihanović wrote:
> Hello,
>
> This series adds initial support for the Marvell PXA1908 SoC and
> "samsung,coreprimevelte", a smartphone using the SoC.
>
> USB works and the phone can boot a rootfs from an SD card, but there are
> some warnings in the dme
e changed, 1 deletion(-)
>
Acked-by: Rob Herring
On Sun, 24 Mar 2024 15:03:59 +0100, Stanislav Jakubek wrote:
> Document the Motorola Moto G (2013), which is a smartphone based
> on the Qualcomm MSM8226 SoC.
>
> Signed-off-by: Stanislav Jakubek
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
On Thu, 14 Mar 2024 20:00:13 +0100, Luca Weiss wrote:
> Add the dts for "hlte" which is a phablet from 2013.
>
> Signed-off-by: Luca Weiss
> ---
> Changes in v2:
> - Correct property order (Konrad)
> - Pick up tags
> - Link to v1:
> https://lore.kernel.org/r/20240310-samsung-hlte-v1-0-e9b55bf9
ng memblock.
>
> Signed-off-by: Oreoluwa Babatunde
> ---
> arch/sh/kernel/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring
On Sun, 10 Mar 2024 15:13:35 +0100, Luca Weiss wrote:
> Add the dts for "hlte" which is a phablet from 2013.
>
> Signed-off-by: Luca Weiss
> ---
> Adam Honse (1):
> ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3
>
> Luca Weiss (1):
> dt-bindings: arm: qcom: Add Samsung Galaxy N
On Fri, Mar 01, 2024 at 04:42:25PM +, abdellatif.elkhl...@arm.com wrote:
> From: Abdellatif El Khlifi
>
> introduce remoteproc support for Arm remote processors
>
> The supported remote processors are those that come with a reset
> control register and a reset status register. The driver all
e changed, 1 deletion(-)
>
Acked-by: Rob Herring
ough, so
> drop the "unstable" remark and expect usual ABI rules.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> .../devicetree/bindings/remoteproc/ti,davinci-rproc.txt| 3 ---
> 1 file changed, 3 deletions(-)
>
Acked-by: Rob Herring
e/bindings/clock/ti/interface.txt| 2 --
> Documentation/devicetree/bindings/clock/ti/mux.txt | 2 --
> 12 files changed, 24 deletions(-)
>
Acked-by: Rob Herring
e/bindings/clock/keystone-pll.txt | 2 --
> 2 files changed, 4 deletions(-)
>
Acked-by: Rob Herring
On Fri, 23 Feb 2024 22:28:42 +0100, Pavel Machek wrote:
> Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
> but I did best I could.
>
> Signed-off-by: Pavel Machek
>
> ---
>
> v2: implement review feedback
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_bindi
one conditional branch, as the
> property is already part of the condition test.
> ---
> .../bindings/remoteproc/st,stm32-rproc.yaml | 51 ++++---
> 1 file changed, 43 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring
On Sun, Feb 11, 2024 at 10:35:54AM +0100, Karel Balej wrote:
> From: Karel Balej
>
> Marvell 88PM88X PMICs provide onkey functionality -- add the bindings.
>
> Signed-off-by: Karel Balej
> ---
>
> Notes:
> RFC v2:
> - Add wakeup-source property and reference onkey schema from MFD.
>
On Sun, Feb 11, 2024 at 10:35:51AM +0100, Karel Balej wrote:
> From: Karel Balej
>
> Marvell 88PM886 is a PMIC with several subdevices such as onkey,
> regulators or battery and charger. It comes in at least two revisions,
> A0 and A1 -- only A1 is described here at the moment.
>
> Signed-off-by
On Tue, Feb 13, 2024 at 02:37:49PM -0600, Tanmay Shah wrote:
> Hello,
>
> Thanks for reviews please find my comments below.
>
> On 2/13/24 1:20 PM, Rob Herring wrote:
> > On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote:
> > > From: Radhey Shyam Pandey
>
On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote:
> From: Radhey Shyam Pandey
>
> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
> UltraScale+ platform. It will help in defining TCM in device-tree
> and make it's access platform agnostic and data-driven.
>
> Tightly-co
On Mon, 05 Feb 2024 10:51:38 +0100, Luca Weiss wrote:
> Add the PBS (Programmable Boot Sequencer) to the list of devices.
>
> Signed-off-by: Luca Weiss
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4
> 1 file changed, 4 insertions(+)
>
My bot found errors running
On Fri, Feb 02, 2024 at 11:55:34AM -0600, Hari Nagalla wrote:
> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> The remote processor's life cycle management and IPC mechanisms are
> similar across the R5F and M4F cores from remote processor driver
> point of view. However, ther
On Fri, 02 Feb 2024 11:55:34 -0600, Hari Nagalla wrote:
> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> The remote processor's life cycle management and IPC mechanisms are
> similar across the R5F and M4F cores from remote processor driver
> point of view. However, there ar
v4:
> * Reword commit description to mention how this IC differs from the
> already supported.
>
> .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring
On Thu, Jan 18, 2024 at 11:04:31AM +0100, Arnaud Pouliquen wrote:
> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration
> where the Cortex-M4 firmware is loaded by the Trusted execution Environment
> (TEE).
> For instance, this compatible is used in both the Linux and OP-TEE
>
quot;.
>
> [1]
> https://elixir.bootlin.com/linux/v6.7.1/source/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml#L54
>
> [2]
> https://elixir.bootlin.com/linux/v6.7.1/source/Documentation/devicetree/bindings/net/qcom,ipa.yaml#L129
> (that's a bit different)
>
> [3] https://lore.kernel.org/linux-devicetree/20240124103623.GJ4906@thinkpad/
>
> @Rob,
> Any general guidance for this and Qualcomm?
I think we have cases using compatible already as well. Either way is
fine with me.
Rob
On Mon, Jan 15, 2024 at 02:52:47PM +0100, Arnaud Pouliquen wrote:
> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration
> where the Cortex-M4 firmware is loaded by the Trusted execution Environment
> (TEE).
> This compatible is used in both the Linux and OP-TEE device-tree.
>
gt; interrupt-controller;
> #interrupt-cells = <1>;
> +
> +onkey {
> + compatible = "marvell,88pm88x-onkey";
> +};
Why do you need this? You have no properties for it. The parent driver
can instantiate child drivers. You don't need a DT node for that.
Rob
On Sun, Dec 17, 2023 at 02:16:59PM +0100, Karel Balej wrote:
> From: Karel Balej
>
> Marvell 88PM880 and 88PM886 are two similar PMICs with mostly matching
> register mapping and subdevices such as onkey, regulators or battery and
> charger. Both seem to come in two revisions which seem to be han
On Sun, 17 Dec 2023 14:17:01 +0100, Karel Balej wrote:
> From: Karel Balej
>
> Marvell 88PM88X PMICs provide onkey functionality. Document it.
>
> Signed-off-by: Karel Balej
> ---
> .../bindings/input/marvell,88pm88x-onkey.yaml | 30 +++
> .../bindings/mfd/marvell,88pm88x.yam
On Sun, 17 Dec 2023 14:16:59 +0100, Karel Balej wrote:
> From: Karel Balej
>
> Marvell 88PM880 and 88PM886 are two similar PMICs with mostly matching
> register mapping and subdevices such as onkey, regulators or battery and
> charger. Both seem to come in two revisions which seem to be handled
On Thu, Dec 14, 2023 at 9:45 AM Alexandru Elisei
wrote:
>
> Hi,
>
> On Wed, Dec 13, 2023 at 02:30:42PM -0600, Rob Herring wrote:
> > On Wed, Dec 13, 2023 at 11:44 AM Alexandru Elisei
> > wrote:
> > >
> > > On Wed, Dec 13, 2023 at 11:22:17AM -0600, Rob H
On Wed, Dec 13, 2023 at 11:44 AM Alexandru Elisei
wrote:
>
> On Wed, Dec 13, 2023 at 11:22:17AM -0600, Rob Herring wrote:
> > On Wed, Dec 13, 2023 at 8:51 AM Alexandru Elisei
> > wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Dec 13, 2023 at 08
On Wed, Dec 13, 2023 at 8:51 AM Alexandru Elisei
wrote:
>
> Hi,
>
> On Wed, Dec 13, 2023 at 08:06:44AM -0600, Rob Herring wrote:
> > On Wed, Dec 13, 2023 at 7:05 AM Alexandru Elisei
> > wrote:
> > >
> > > Hi Rob,
> > >
> > > On Tue, Dec
On Wed, Dec 13, 2023 at 7:05 AM Alexandru Elisei
wrote:
>
> Hi Rob,
>
> On Tue, Dec 12, 2023 at 12:44:06PM -0600, Rob Herring wrote:
> > On Tue, Dec 12, 2023 at 10:38 AM Alexandru Elisei
> > wrote:
> > >
> > > Hi Rob,
> > >
> > > Th
On Tue, Dec 12, 2023 at 10:38 AM Alexandru Elisei
wrote:
>
> Hi Rob,
>
> Thank you so much for the feedback, I'm not very familiar with device tree,
> and any comments are very useful.
>
> On Mon, Dec 11, 2023 at 11:29:40AM -0600, Rob Herring wrote:
> > On Sun, No
e->end));
> + return -EINVAL;
> + }
> +
> + ret = tag_storage_of_flat_read_u32(node, "block-size",
> &block_size_bytes);
> + if (ret || block_size_bytes == 0) {
> + pr_err("Invalid or missing 'block-size' property");
> + return -EINVAL;
> + }
> + region->block_size = get_block_size_pages(block_size_bytes);
> + if (range_len(tag_range) % region->block_size != 0) {
> + pr_err("Tag storage region size 0x%llx is not a multiple of
> block size %u",
> + PFN_PHYS(range_len(tag_range)), region->block_size);
> + return -EINVAL;
> + }
> +
> + ret = tag_storage_of_flat_read_u32(mem_node, "numa-node-id", &nid);
I was going to say we already have a way to associate memory nodes
other nodes using "numa-node-id", so the "memory" phandle property is
somewhat redundant. Maybe the tag node should have a numa-node-id.
With that, it looks like you don't even need to access the /memory
node. Avoiding that would be good for 2 reasons. It avoids parsing
memory nodes twice and it's not the kernel's job to validate the DT.
Really, if you want memory info, you should use memblock to get it
because all the special cases of memory layout are handled. For
example you can have memory nodes with multiple 'reg' entries or
multiple memory nodes or both, and then some of those could be
contiguous.
Rob
On Fri, 24 Nov 2023 10:21:21 +0100, Krzysztof Kozlowski wrote:
> Use only one and exactly one space around '=' in DTS example.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
>
> Merging idea: Rob's DT.
> Should apply cleanly on Rob's for-next.
> ---
> .../devicetree/bindings/auxdisplay/hit,h
his in the data-lanes description.
>
> Signed-off-by: Luca Weiss
> ---
> Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml | 18
> ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring
he USB-C
> Codec |-- AUX+ --| |-- SBU2 ---> connected
> |-- AUX- --| |
> __| |_|
>
> (thanks to Neil Armstrong for this ASCII art)
>
> Signed-off-by: Luca Weiss
> ---
> .../devicetree/bindings/usb/fcs,fsa4480.yaml | 29
> +-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring
On Fri, 13 Oct 2023 15:08:49 -0500, Rob Herring wrote:
> The common reserved-memory bindings have recently been copied from the
> kernel tree into dtschema. The preference is to host common, stable
> bindings in dtschema. As reserved-memory is documented in the DT Spec,
> it meets
On Sat, 21 Oct 2023 09:16:19 +0200, David Wronek wrote:
> Add a compatible for the Qualcomm Kryo 465 found in SM7125.
>
> Signed-off-by: David Wronek
> ---
> Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
{ compatible = "qcom,kryo465"; };
> +&CPU4 { compatible = "qcom,kryo465"; };
> +&CPU5 { compatible = "qcom,kryo465"; };
> +&CPU6 { compatible = "qcom,kryo465"; };
> +&CPU7 { compatible = "qcom,kryo465"; };
This compatible is not documented. Please add it.
Rob
On Mon, Oct 16, 2023 at 04:32:55PM +0200, Neil Armstrong wrote:
> On 16/10/2023 16:22, Rob Herring wrote:
> > On Fri, Oct 13, 2023 at 01:38:05PM +0200, Luca Weiss wrote:
> > > Allow specifying data-lanes to reverse the SBU muxing orientation where
> > > neces
ion:
> + Specifies how the AUX+/- lines are connected to SBU1/2.
Doesn't this depend on the connector orientation? Or it is both that and
the lines can be swapped on the PCB?
Seems like an abuse of data-lanes which already has a definition which
is not about swapping + and - differential lanes.
Rob
-memory
schemas we depend on, so bump the minimum version to that. Otherwise,
references to these schemas will generate errors.
Signed-off-by: Rob Herring
---
Documentation/devicetree/bindings/Makefile| 2 +-
.../remoteproc/renesas,rcar-rproc.yaml| 2 +-
.../bindings/reserved-memory
Use preferred device_get_match_data() instead of of_match_device() to
get the driver match data. With this, adjust the includes to explicitly
include the correct headers.
Signed-off-by: Rob Herring
---
drivers/remoteproc/st_remoteproc.c | 14 --
1 file changed, 4 insertions(+), 10
it is not used, it
> > should be dropped, not changed...
>
> Okay, I will drop the label instead of updating it in v2.
Or just drop the patch and skip the trivial changes. If you want to fix
unused labels, fix it for the whole subsystem (mfd) or treewide.
Rob
On Thu, Sep 28, 2023 at 2:31 PM Mathieu Poirier
wrote:
>
> Hi Rob,
>
> On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote:
> > Just as unevaluatedProperties or additionalProperties are required at
> > the top level of schemas, they should (and will) also be req
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Signed-off-by: Rob Herring
---
Documentation/devicetree/bindings
es.
> +additionalItems: true
> +
> + sram:
> +$ref: /schemas/types.yaml#/definitions/phandle-array
> +minItems: 1
> +maxItems: 4
> +items:
> + maxItems: 4
You are saying there are 1-4 entries and each entry is 4 cells. What's
in the 4 cells?
>From the description and example, looks like you only have 1 cell (a
phandle) so maxItems should be 1.
Your example should fail, but I'm not sure why it doesn't.
Rob
On Wed, 13 Sep 2023 06:16:41 -0500, Hari Nagalla wrote:
> K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> The remote processor's life cycle management and IPC mechanisms are
> similar across the R5F and M4F cores from remote processor driver
> point of view. However, there ar
s a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring
---
drivers/nvdimm/of_pme
On Mon, Apr 19, 2021 at 9:03 PM Leonardo Bras wrote:
>
> On Mon, 2021-04-19 at 20:39 -0500, Rob Herring wrote:
> > On Mon, Apr 19, 2021 at 7:35 PM Leonardo Bras wrote:
> > >
> > > On Mon, 2021-04-19 at 10:44 -0500, Rob Herring wrote:
> > > > On
On Tue, Apr 20, 2021 at 11:10 AM Ard Biesheuvel wrote:
>
> On Tue, 20 Apr 2021 at 17:54, Rob Herring wrote:
> >
> > On Tue, Apr 20, 2021 at 10:12 AM Alexandre TORGUE
> > wrote:
> > >
> > >
> > >
> > > On 4/20/21 4:45 PM, Rob Herr
1 - 100 of 7772 matches
Mail list logo
