Re: Re: [PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-07 Thread zhenwei pi
On 4/8/25 09:43, Geliang Tang wrote: Hi zhenwei, On Mon, 2025-04-07 at 16:51 +0800, zhenwei pi wrote: mptcp_connect.c is a startup tutorial of MPTCP programming, however there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for getaddrinfo MPTCP support. Signed-off-by: zhenwei

[PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-07 Thread zhenwei pi
mptcp_connect.c is a startup tutorial of MPTCP programming, however there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for getaddrinfo MPTCP support. Signed-off-by: zhenwei pi Signed-off-by: zhenwei pi --- tools/testing/selftests/net/mptcp/mptcp_connect.c | 12 1

Re: Re: [PATCH v3 2/4] virtio_balloon: introduce oom-kill invocations

2024-04-23 Thread zhenwei pi
On 4/23/24 17:13, Michael S. Tsirkin wrote: On Tue, Apr 23, 2024 at 11:41:07AM +0800, zhenwei pi wrote: [snip] #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ Looks like a useful extension. Bu

[PATCH v3 4/4] virtio_balloon: introduce memory scan/reclaim info

2024-04-22 Thread zhenwei pi
claim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 + include/uapi/linux/virtio_balloon.h | 12 ++-- 2 files c

[PATCH v3 3/4] virtio_balloon: introduce memory allocation stall counter

2024-04-22 Thread zhenwei pi
Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 8 include/uapi

[PATCH v3 2/4] virtio_balloon: introduce oom-kill invocations

2024-04-22 Thread zhenwei pi
e can also grep for magic words in guest kernel log from host side. Rather than this unstable way, virtio balloon reports OOM-KILL invocations instead. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 1 + include/uapi/linux/virtio_balloon.h | 6

[PATCH v3 1/4] virtio_balloon: separate vm events into a function

2024-04-22 Thread zhenwei pi
All the VM events related statistics have dependence on 'CONFIG_VM_EVENT_COUNTERS', separate these events into a function to make code clean. Then we can remove 'CONFIG_VM_EVENT_COUNTERS' from 'update_balloon_stats'. Signed-off-by: zhenwei pi --- driver

[PATCH v3 0/4] Improve memory statistics for virtio balloon

2024-04-22 Thread zhenwei pi
RS' RFC version: Link: https://lore.kernel.org/lkml/20240415084113.1203428-1-pizhen...@bytedance.com/T/#m1898963b3c27a989b1123db475135c3ca687ca84 zhenwei pi (4): virtio_balloon: separate vm events into a function virtio_balloon: introduce oom-kill invocations virtio_balloon: introduce m

Re: Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function

2024-04-22 Thread zhenwei pi
On 4/22/24 15:47, David Hildenbrand wrote: On 22.04.24 09:42, zhenwei pi wrote: All the VM events related statistics have dependence on 'CONFIG_VM_EVENT_COUNTERS', once any stack variable is required by any VM events in future, we would have codes like:   #ifdef CONFIG_VM_EVEN

[PATCH v2 4/4] virtio_balloon: introduce memory scan/reclaim info

2024-04-22 Thread zhenwei pi
claim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 + include/uapi/linux/virtio_balloon.h | 12 ++-- 2 files c

[PATCH v2 3/4] virtio_balloon: introduce memory allocation stall counter

2024-04-22 Thread zhenwei pi
Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 8 include/uapi/linux/virtio_balloon.h | 6

[PATCH v2 2/4] virtio_balloon: introduce oom-kill invocations

2024-04-22 Thread zhenwei pi
e can also grep for magic words in guest kernel log from host side. Rather than this unstable way, virtio balloon reports OOM-KILL invocations instead. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 1 + include/uapi/linux/virtio_balloon.h | 6

[PATCH v2 1/4] virtio_balloon: separate vm events into a function

2024-04-22 Thread zhenwei pi
foo = events[XXX] + events[YYY]; update_stat(vb, idx++, VIRTIO_BALLOON_S_XXX, foo); #endif Separate vm events into a single function, also remove 'CONFIG_VM_EVENT_COUNTERS' from 'update_balloon_stats'. Signed-off-by: zhenwei pi --- driver

[PATCH v2 0/4] Improve memory statistics for virtio balloon

2024-04-22 Thread zhenwei pi
e stall events. RFC -> v1: - several text changes: oom-kill -> oom-kills, SCAN_ASYNC -> ASYN_SCAN. - move vm events codes into '#ifdef CONFIG_VM_EVENT_COUNTERS' RFC version: Link: https://lore.kernel.org/lkml/20240415084113.1203428-1-pizhen...@bytedance.com/T/#m1898963b3c

[PATCH 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-17 Thread zhenwei pi
claim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 + include/uapi/linux/virtio_balloon.h | 12 ++-- 2 files changed, 19 insertions(+), 2 deletion

[PATCH 2/3] virtio_balloon: introduce memory allocation stall counter

2024-04-17 Thread zhenwei pi
Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 20 +++- include/uapi/linux

[PATCH 1/3] virtio_balloon: introduce oom-kill invocations

2024-04-17 Thread zhenwei pi
e can also grep for magic words in guest kernel log from host side. Rather than this unstable way, virtio balloon reports OOM-KILL invocations instead. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 1 + include/uapi/linux/virtio_balloon.h | 6 -- 2 files changed, 5 insert

[PATCH 0/3] Improve memory statistics for virtio balloon

2024-04-17 Thread zhenwei pi
3ca687ca84 zhenwei pi (3): virtio_balloon: introduce oom-kill invocations virtio_balloon: introduce memory allocation stall counter virtio_balloon: introduce memory scan/reclaim info drivers/virtio/virtio_balloon.c | 30 - include/uapi/linux/vi

Re: Re: [RFC 0/3] Improve memory statistics for virtio balloon

2024-04-15 Thread zhenwei pi
On 4/15/24 23:01, David Hildenbrand wrote: On 15.04.24 10:41, zhenwei pi wrote: Hi, When the guest runs under critial memory pressure, the guest becomss too slow, even sshd turns D state(uninterruptible) on memory allocation. We can't login this VM to do any work on trouble shooting.

[RFC 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-15 Thread zhenwei pi
claim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 + include/uapi/linux/virtio_balloon.h | 12 ++-- 2 files changed, 19 insertions(+), 2 deletion

[RFC 2/3] virtio_balloon: introduce memory allocation stall counter

2024-04-15 Thread zhenwei pi
Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 19 ++- include/uapi/linux

[RFC 1/3] virtio_balloon: introduce oom-kill invocations

2024-04-15 Thread zhenwei pi
e can also grep for magic words in guest kernel log from host side. Rather than this unstable way, virtio balloon reports OOM-KILL invocations instead. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 2 ++ include/uapi/linux/virtio_balloon.h | 6 -- 2 files changed, 6

[RFC 0/3] Improve memory statistics for virtio balloon

2024-04-15 Thread zhenwei pi
emory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. zhenwei pi (3): virtio_balloon: introduce oom-kill invocations virtio_balloon: introduce memory allocation stall counter virtio_balloon: introduce memory scan/reclaim info drivers/vi

[PATCH] platform/chrome: cros_usbpd_notify: Listen to EC_HOST_EVENT_USB_MUX host event

2021-04-13 Thread Pi-Hsun Shih
]: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/heads/chromeos-2016.05/src/ec/google/chromeec/acpi/ec.asl#382 Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_usbpd_notify.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] misc: pvpanic: sysfs_emit uses should have a newline

2021-02-03 Thread zhenwei pi
On 2/3/21 10:57 PM, Greg Kroah-Hartman wrote: On Mon, Feb 01, 2021 at 09:56:57AM +0800, zhenwei pi wrote: On 1/30/21 3:08 AM, Joe Perches wrote: Add newline terminations to the sysfs_emit uses added by -next commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue") Sig

Re: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a newline

2021-01-31 Thread zhenwei pi
char *buf) { - return sysfs_emit(buf, "%x", events); + return sysfs_emit(buf, "%x\n", events); } static ssize_t events_store(struct device *dev, struct device_attribute *attr, Hi, Greg is the maintainer of this driver. -- zhenwei pi

Re: Re: PING: [PATCH v5 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-20 Thread zhenwei pi
On 1/21/21 1:53 AM, Greg KH wrote: X-Gm-Spam: 0 X-Gm-Phishy: 0 On Mon, Jan 18, 2021 at 09:42:57AM +0800, zhenwei pi wrote: Hi, Greg What's the next step I should take? I need some reviews by the people who will be doing the qemu portion of this, or someone else, please. thanks, gre

PING: [PATCH v5 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-17 Thread zhenwei pi
Hi, Greg What's the next step I should take? On 1/10/21 7:53 PM, zhenwei pi wrote: v4 -> v5: Use sysfs_emit to export attribute value. Only allow subset of capability to set on events. Add more detailed infomation in document. v3 -> v4: Use event sysfs attribute instead of modul

Re: [PATCH v8 2/2] soc: mediatek: add mt6779 devapc driver

2021-01-14 Thread Pi-Hsun Shih
Hi Neal, Please see inline comments below. On Thu, Oct 15, 2020 at 11:21 AM Neal Liu wrote: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor

Re: [PATCH v2 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2021-01-10 Thread Pi-Hsun Shih
gentle ping on these two patches for EC_REBOOT_COLD_AP_OFF. On Mon, Dec 21, 2020 at 12:12 PM Pi-Hsun Shih wrote: > > Add cold-ap-off to ChromeOS EC sysfs reboot file option, corresponds to > the EC_REBOOT_COLD_AP_OFF flag, that will reset EC and keep AP off. > > Signed-off-b

[PATCH v5 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-10 Thread zhenwei pi
e, check the event is supported or not. zhenwei pi (2): misc: pvpanic: introduce device capability misc: pvpanic: introduce module parameter 'events' .../ABI/testing/sysfs-bus-pci-devices-pvpanic | 14 + drivers/misc/pvpanic.c| 58 +-

[PATCH v5 1/2] misc: pvpanic: introduce device capability

2021-01-10 Thread zhenwei pi
sending event to host side, check capability firstly. Suggested by Greg KH, use sysfs to expose capability to user space, also add new sysfs attribute in document. Signed-off-by: zhenwei pi --- .../ABI/testing/sysfs-bus-pci-devices-pvpanic | 12 +++ drivers/misc/pvpanic.c

[PATCH v5 2/2] misc: pvpanic: introduce events device attribue

2021-01-10 Thread zhenwei pi
Suggested by Paolo & Greg, add 'events' device attribute that can be used to limit which capabilities the driver uses. Finally, the pvpanic guest driver works by the limitation of both device capability and user setting. Signed-off-by: zhenwei pi --- .../ABI/testing/sysfs-b

[PATCH v4 1/2] misc: pvpanic: introduce device capability

2021-01-09 Thread zhenwei pi
sending event to host side, check capability firstly. Suggested by Greg KH, use sysfs to expose capability to user space, also add new sysfs attribute in document. Signed-off-by: zhenwei pi --- .../ABI/testing/sysfs-bus-pci-devices-pvpanic | 7 drivers/misc/pvpanic.c

[PATCH v4 2/2] misc: pvpanic: introduce events device attribue

2021-01-09 Thread zhenwei pi
Suggested by Paolo & Greg, add 'events' device attribute that can be used to limit which capabilities the driver uses. Finally, the pvpanic guest driver works by the limitation of both device capability and user setting. Signed-off-by: zhenwei pi --- .../ABI/testing/sysfs-b

[PATCH v4 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-09 Thread zhenwei pi
2: Remove device info log, use module parameter to expose capability. v1: The guest sides determines pvpanic capability by RDPT, before kicking host side, check the event is supported or not. zhenwei pi (2): misc: pvpanic: introduce device capability misc: pvpanic: introduce module paramete

Re: [External] Re: [PATCH v3 2/2] misc: pvpanic: introduce module parameter 'events'

2021-01-09 Thread zhenwei pi
he system at one time? Because if this ever becomes not true, the module parameter is a mess... thanks, greg k-h What about adding _two_ device attribute: capability (0444): detect from device which the hypervisor really supports. events (0644): root user could enable/disable feature(s) from guest side. -- zhenwei pi

[PATCH v3 1/2] misc: pvpanic: introduce device capability

2021-01-08 Thread zhenwei pi
sending event to host side, check capability firstly. Suggested by Greg KH, use sysfs to expose capability to user space. Signed-off-by: zhenwei pi --- .../ABI/testing/sysfs-bus-pci-devices-pvpanic | 7 drivers/misc/pvpanic.c| 41 --- 2 files changed

[PATCH v3 0/2] misc: pvpanic: introduce capability & module parameter

2021-01-08 Thread zhenwei pi
before kicking host side, check the event is supported or not. zhenwei pi (2): misc: pvpanic: introduce device capability misc: pvpanic: introduce module parameter 'events' drivers/misc/pvpanic.c | 45 -- 1 file changed, 39 insertions(+), 6 deletions(-) -- 2.25.1

[PATCH v3 2/2] misc: pvpanic: introduce module parameter 'events'

2021-01-08 Thread zhenwei pi
Suggested by Paolo, add a module parameter that can be used to limit which capabilities the driver uses. Finally, the pvpanic guest driver works by the limitation of both device capability and user setting. Signed-off-by: zhenwei pi --- drivers/misc/pvpanic.c | 6 +- 1 file changed, 5

[PATCH v2] misc: pvpanic: introduce device capability

2021-01-08 Thread zhenwei pi
sending event to host side, check capability firstly. Suggested by Paolo, export capability of pvpanic device by read-only module parameter. Signed-off-by: zhenwei pi --- drivers/misc/pvpanic.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/misc

[PATCH v2 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2020-12-20 Thread Pi-Hsun Shih
Add cold-ap-off to ChromeOS EC sysfs reboot file option, corresponds to the EC_REBOOT_COLD_AP_OFF flag, that will reset EC and keep AP off. Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.

2020-12-20 Thread Pi-Hsun Shih
Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP. Signed-off-by: Pi-Hsun Shih --- include/linux/platform_data/cros_ec_commands.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_comma

[PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2020-12-17 Thread Pi-Hsun Shih
Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c index f521a5c65091..8210fb10e839 100644 --- a/drivers/platform/chrome

[PATCH 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.

2020-12-17 Thread Pi-Hsun Shih
Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP. Signed-off-by: Pi-Hsun Shih --- The corresponding changes in ChromeOS EC firmware is at crrev.com/c/2428361 --- include/linux/platform_data/cros_ec_commands.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/

[PATCH v2] nvmet: fix mismatched serial

2020-12-12 Thread zhenwei pi
27; to 'attr_serial' on target side, and run 'nvme id-ctrl /dev/nvme0' on initiator side, then we can get the same SN string. Signed-off-by: zhenwei pi Reported-by: kernel test robot --- drivers/nvme/target/configfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH] nvmet: fix mismatched serial

2020-12-10 Thread zhenwei pi
side, then we can get the same SN string. Signed-off-by: zhenwei pi --- drivers/nvme/target/configfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index 37e1d7784e17..e7808a86ccef 100644 --- a/drivers/n

Re: [PATCH] drm/bridge: anx7625: Add anx7625 port switching.

2020-11-12 Thread Pi-Hsun Shih
Hi Prashant, Please see inline reply as below. On Thu, Nov 12, 2020 at 4:59 PM Prashant Malani wrote: > > Hi Pi-Hsun, > > I haven't gone through the code, but did have a high-level comment > (kindly see inline) > > On Thu, Nov 12, 2020 at 02:40:40PM +0800, Pi-Hsun Shi

[PATCH] drm/bridge: anx7625: Add anx7625 port switching.

2020-11-11 Thread Pi-Hsun Shih
the two ports currently has DP enabled. Signed-off-by: Pi-Hsun Shih This is an attempt to use typec framework with how we're using anx7625 on Chrome OS asurada board. An example of the dts for the two ports case can be fou

[PATCH] regulator: core: don't disable regulator if is_enabled return error.

2020-11-05 Thread Pi-Hsun Shih
In regulator_late_cleanup when is_enabled failed, don't try to disable the regulator since it would likely to fail too and causing confusing error messages. Signed-off-by: Pi-Hsun Shih --- This is encountered while using drivers/regulator/cros-ec-regulator.c. Since the driver control

Re: [External] Re: [PATCH 1/2] nvmet: introduce transport layer keep-alive

2020-10-28 Thread zhenwei pi
On 10/28/20 3:15 PM, Sagi Grimberg wrote: On 10/27/20 5:15 AM, zhenwei pi wrote: In the zero KATO scenario, if initiator crashes without transport layer disconnection, target side would never reclaim resources. A target could start transport layer keep-alive to detect dead connection for the

[PATCH 2/2] nvmet-tcp: add keep-alive

2020-10-27 Thread zhenwei pi
Add tcp keep-alive to detect dead connections for zero KATO case. Signed-off-by: zhenwei pi --- drivers/nvme/target/tcp.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index dc1f0f647189..58800e914e61 100644

[PATCH 1/2] nvmet: introduce transport layer keep-alive

2020-10-27 Thread zhenwei pi
In the zero KATO scenario, if initiator crashes without transport layer disconnection, target side would never reclaim resources. A target could start transport layer keep-alive to detect dead connection for the admin queue. Signed-off-by: zhenwei pi --- drivers/nvme/target/admin-cmd.c | 2

[PATCH v3] nvme-rdma: handle nvme completion data length

2020-10-25 Thread zhenwei pi
connections on transport layer is not standard, currently still treat it as illegal. Thanks to Chao Leng & Sagi for suggestions. Signed-off-by: zhenwei pi --- drivers/nvme/host/rdma.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c i

[PATCH v2] nvme-rdma: handle nvme completion data length

2020-10-23 Thread zhenwei pi
received from target, and the host side continues to process without length checking, then the previous CQE is processed twice. Handle data length, ignore zero bytes message, and try to recovery for corrupted CQE case. Thanks to Chao Leng for suggestions. Signed-off-by: zhenwei pi --- drivers/nvme

Re: [External] Re: [PATCH] nvme-rdma: handle nvme completion data length

2020-10-22 Thread zhenwei pi
On 10/22/20 5:55 PM, Chao Leng wrote: On 2020/10/22 16:38, zhenwei pi wrote: Hit a kernel warning: refcount_t: underflow; use-after-free. WARNING: CPU: 0 PID: 0 at lib/refcount.c:28 RIP: 0010:refcount_warn_saturate+0xd9/0xe0 Call Trace:     nvme_rdma_recv_done+0xf3/0x280 [nvme_rdma

[PATCH] nvme-rdma: handle nvme completion data length

2020-10-22 Thread zhenwei pi
received from target, and the host side continues to process without length checking, then the previous CQE is processed twice. Handle data length, ignore zero bytes message, and try to recovery for corrupted CQE case. Signed-off-by: zhenwei pi --- drivers/nvme/host/rdma.c | 11 +++ 1 file

PING: [PATCH] block: add io_error stat for block device

2020-10-21 Thread zhenwei pi
Hi, Jens What do you think about this, adding io error stat for block devices is reasonable? On 9/10/20 10:20 AM, zhenwei pi wrote: Currently if hitting block req error, block layer only prints error log with a rate limitation. Then agent has to parse kernel log to record what happens. In

[PATCH v4] remoteproc/mediatek: Add support for mt8192 SCP

2020-10-14 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v3: * Remove unnecessary barrier and readl in mt8192_scp_before_load, which also fixes build failure on linux-next because of COMPILE_TEST trying to compile this on other platforms. Change

[PATCH v3] nvmet: fix uninitialized work for zero kato

2020-10-14 Thread zhenwei pi
0d3b6a8d213a), ka_work still has a chance to run (called by nvmet_start_ctrl). Fixes: 0d3b6a8d213a ("nvmet: Disable keep-alive timer when kato is cleared to 0h") Signed-off-by: zhenwei pi --- drivers/nvme/target/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH v2] nvmet: fix uninitialized work for zero kato

2020-10-14 Thread zhenwei pi
0d3b6a8d213a), ka_work still has a chance to run (called by nvmet_start_ctrl). Fixes: Don't run keep alive work with zero kato. Signed-off-by: zhenwei pi --- drivers/nvme/target/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/t

[PATCH] nvmet: fix uninitialized work for zero kato

2020-10-12 Thread zhenwei pi
in 0d3b6a8d213a), ka_work still has a chance to run (called by nvmet_start_ctrl to detect dead host). Initilize ka_work during allocating ctrl, and set a reasonable kato before scheduling ka_work. Signed-off-by: zhenwei pi --- drivers/nvme/target/core.c | 16 +++- 1 file changed, 11

PING: [PATCH] block: add io_error stat for block device

2020-09-24 Thread zhenwei pi
Hi, Jens How do you think about error stat of a block device? On 9/10/20 10:20 AM, zhenwei pi wrote: Currently if hitting block req error, block layer only prints error log with a rate limitation. Then agent has to parse kernel log to record what happens. In this patch, add read/write/discard

Re: [PATCH v3] drm/bridge: add it6505 driver

2020-09-22 Thread Pi-Hsun Shih
On Fri, Sep 4, 2020 at 10:17 AM allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes

[PATCH v3] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-21 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v2: * Inline scp_reset_assert / scp_reset_deassert. Change since v1: * Remove unused register definitions. --- drivers/remoteproc/mtk_common.h | 32 + drivers/remoteproc/mtk_scp.c

[PATCH v2] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-17 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v1: * Remove unused register definitions. --- drivers/remoteproc/mtk_common.h | 32 + drivers/remoteproc/mtk_scp.c | 207 ++- drivers/remoteproc

[PATCH] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-16 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih --- drivers/remoteproc/mtk_common.h | 34 + drivers/remoteproc/mtk_scp.c | 207 ++- drivers/remoteproc/mtk_scp_ipi.c | 5 +- 3 files changed, 213 insertions(+), 33 deletions(-) diff --git a/drivers

Re: [PATCH v2] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
On Wed, Sep 9, 2020 at 4:58 PM Matthias Brugger wrote: > > > > On 09/09/2020 10:14, Pi-Hsun Shih wrote: > > Add scp node to mt8183-kukui > > > > Fixes: 0d5e41709f76 ("arm64: dts: mt8183: add scp node") > > Signed-off-by: Pi-Hsun Shih > &

[PATCH] block: add io_error stat for block device

2020-09-09 Thread zhenwei pi
Currently if hitting block req error, block layer only prints error log with a rate limitation. Then agent has to parse kernel log to record what happens. In this patch, add read/write/discard/flush stat counter to record io errors. Signed-off-by: zhenwei pi --- block/blk-core.c | 14

Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node

2020-09-09 Thread Pi-Hsun Shih
On Wed, Sep 9, 2020 at 3:37 PM Jon Hunter wrote: > > > On 02/09/2020 17:23, Krzysztof Kozlowski wrote: > > On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju > > wrote: > >> > >> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger > >> wrote: > >

[PATCH v2] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
Add scp node to mt8183-kukui Fixes: 0d5e41709f76 ("arm64: dts: mt8183: add scp node") Signed-off-by: Pi-Hsun Shih --- Change since v1: * Add Fixes tag. --- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/

[PATCH] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
Add scp node to mt8183-kukui Signed-off-by: Pi-Hsun Shih --- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index f0a070535b34

[PATCH] regulator: cros-ec-regulator: Fix double free of desc->name.

2020-07-28 Thread Pi-Hsun Shih
The desc->name field is allocated with devm_kstrdup, but is also kfreed on the error path, causing it to be double freed. Remove the kfree on the error path. Fixes: 8d9f8d57e023 ("regulator: Add driver for cros-ec-regulator") Signed-off-by: Pi-Hsun Shih --- drivers/regulator/cros-e

[PATCH] platform/chrome: cros_ec: Fix host command for regulator control.

2020-07-24 Thread Pi-Hsun Shih
d for regulator control.") Signed-off-by: Pi-Hsun Shih --- The original numbers were chosen before the 0x012B is used in ChromeOS EC codebase. Since the original kernel patch got accepted before the corresponding commit in ChromeOS EC codebase got merged, the host command number was used by other co

[PATCH] scripts/decode_stacktrace: Strip basepath from all paths.

2020-07-20 Thread Pi-Hsun Shih
ot;scripts/decode_stacktrace: match basepath using shell prefix operator, not regex") Signed-off-by: Pi-Hsun Shih Co-developed-by: Shik Chen Signed-off-by: Shik Chen --- scripts/decode_stacktrace.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/decode_stacktra

Re: [PATCH] regulator: cros-ec: Constify cros_ec_regulator_voltage_ops

2020-07-13 Thread Pi-Hsun Shih
Acked-by: Pi-Hsun Shih On Sat, Jul 11, 2020 at 7:44 PM Rikard Falkeborn wrote: > > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/regulator/cros-ec-regulator.c | 2 +-

Re: [PATCH 12/21] iommu/mediatek: Add iova reserved function

2020-07-13 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote: > > For multiple iommu_domains, we need to reserve some iova regions, so we > will add mtk_iommu_iova_region structure. It includes the base address > and size of the range. > This is a preparing patch for supporting multi-domain. > > Signed-off-by: A

Re: [PATCH 11/21] iommu/mediatek: Add power-domain operation

2020-07-13 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote: > > In the previous SoC, the M4U HW is in the EMI power domain which is > always on. the latest M4U is in the display power domain which may be > turned on/off, thus we have to add pm_runtime interface for it. > > we should enable its power before M4U

Re: [PATCH 01/21] dt-binding: memory: mediatek: Add a common larb-port header file

2020-07-12 Thread Pi-Hsun Shih
On Mon, Jul 13, 2020 at 2:06 AM Matthias Brugger wrote: > > > > On 11/07/2020 08:48, Yong Wu wrote: > > Put all the macros about smi larb/port togethers, this is a preparing > > patch for extending LARB_NR and adding new dom-id support. > > > > Signed-off-by: Yong Wu > > --- > > include/dt-bind

Re: [PATCH 04/21] dt-binding: mediatek: Add binding for mt8192 IOMMU and SMI

2020-07-12 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:50 PM Yong Wu wrote: > > This patch adds decriptions for mt8192 IOMMU and SMI. > > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation > table format. The M4U-SMI HW diagram is as below: > > EMI >

[PATCH] fs/proc: add short desc for /proc/softirqs

2020-07-01 Thread zhenwei pi
/1079 Add short desc for /proc/softirqs in this patch, then /proc/softirqs gets more human-readable. Signed-off-by: zhenwei pi --- fs/proc/softirqs.c| 2 +- include/linux/interrupt.h | 5 +++-- kernel/softirq.c | 12 3 files changed, 16 insertions(+), 3 deletion

[PATCH v6 3/3] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih Reviewed-by: Prashant Malani Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * Move

[PATCH v6 0/3] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
fig. * Add Kconfig description about compiling as module. Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (3): dt-bindings: regulat

[PATCH v6 1/3] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * No change Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes

[PATCH v6 2/3] platform/chrome: cros_ec: Add command for regulator control.

2020-06-11 Thread Pi-Hsun Shih
Add host commands for voltage regulator control through ChromeOS EC. Signed-off-by: Pi-Hsun Shih Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * Extract into a separate patch. --- drivers/platform/chrome/cros_ec_trace.c | 5 ++ .../linux/platform_data/cros_ec_commands.h

[PATCH v5 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes

[PATCH v5 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes from v3: * Fix dt bindings file name. * Add full example. Changes

[PATCH v5 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../regulator/google,cros-ec-regu

[PATCH v4 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v3: * Fix dt bindings file name. * Add full example. Changes from v2: * No change Changes from v1: * Change compatible string to google,regulator-cros

[PATCH v4 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v3: * Remove check around CONFIG_OF. * Add new host commands to cros_ec_trace. * Use

[PATCH v4 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
ckpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../regulator/google,cros-ec-regulator.yaml | 51 drivers/platform/chrome/cros_ec_trace.c | 5 + drivers

Re: [PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Thanks for the review, would address most of them in v4. An inline reply as below: On Thu, Jun 11, 2020 at 12:47 AM Enric Balletbo i Serra wrote: > > Hi Pi-Hsun, > > Thank you for your patch. > > On 10/6/20 11:07,

[PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v2: * Add 'depends on OF' to Kconfig. * Add Kconfig description about co

[PATCH v3 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v2: * No change Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt

[PATCH v3 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-10 Thread Pi-Hsun Shih
: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver f

[PATCH v2 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. Signed-off-by: Pi-Hsun Shih

[PATCH v2 2/2] regulator: Add driver for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
code styles. Signed-off-by: Pi-Hsun Shih --- This patch contains function cros_ec_cmd that is copied from the series: https://lore.kernel.org/patchwork/project/lkml/list/?series=428457. I can't find the first patch in that v2 series, so the function is modified from v1 of that series accordi

[PATCH v2 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-10 Thread Pi-Hsun Shih
binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../bindings/regulator/cros-ec-regulator.yaml | 43 +++ drivers/regulator/Kconfig

Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Thanks for the review, some inline reply: On Tue, Jun 9, 2020 at 7:19 PM Mark Brown wrote: > > On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote: > > > +static int cros_ec_regulator_set_state(struct regulator_dev *dev, bool > > enable) > > +{ > > +

[PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- This patch contains function cros_ec_cmd that is copied from the series: https://lore.kernel.org

  1   2   3   4   >