Thanks for the review, would address most of them in v4. An inline reply as below:
On Thu, Jun 11, 2020 at 12:47 AM Enric Balletbo i Serra <enric.balle...@collabora.com> wrote: > > Hi Pi-Hsun, > > Thank you for your patch. > > On 10/6/20 11:07, Pi-Hsun Shih wrote: > > +/*****************************************************************************/ > > +/* Voltage regulator controls */ > > + > > +/* > > + * Get basic info of voltage regulator for given index. > > + * > > + * Returns the regulator name and supported voltage list in mV. > > + */ > > +#define EC_CMD_REGULATOR_GET_INFO 0x012B > > This introduces a new EC command, while you are here, please also add the > command in drivers/platform/chrome/cros_ec_trace.c, so we can trace properly > the > command. Also can you point me to the commit that introduces this command in > the > EC firmware? The commit that introduces this in EC firmware is at https://crrev.com/c/2100327
