Re: [PATCH v2] mfd: rtsx: fix PM suspend for 5227 & 5249

2014-10-22 Thread Micky Ching
Hi Lee, I am wondering if you have accepted this patch? Best Regards. micky. On 10/11/2014 09:07 AM, Micky Ching wrote: On 10/10/2014 06:21 PM, Lee Jones wrote: On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching Fix rts5227&5249 failed send buffer cmd after sus

Re: [PATCH v2] mfd: rtsx: fix PM suspend for 5227 & 5249

2014-10-10 Thread Micky Ching
On 10/10/2014 06:21 PM, Lee Jones wrote: On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching Fix rts5227&5249 failed send buffer cmd after suspend, PM_CTRL3 should reset before send any buffer cmd after suspend. Otherwise, buffer cmd will failed, this will lead re

Re: [PATCH v2] mfd: rtsx: fix PM suspend for 5227 & 5249

2014-10-10 Thread Micky Ching
On 10/10/2014 05:24 PM, Lee Jones wrote: On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching Fix rts5227&5249 failed send buffer cmd after suspend, PM_CTRL3 should reset before send any buffer cmd after suspend. Otherwise, buffer cmd will failed, this will lead re

Re: [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249

2014-09-18 Thread micky
On 09/19/2014 08:21 AM, Lee Jones wrote: On Thu, 18 Sep 2014, micky wrote: On 09/18/2014 12:53 PM, Lee Jones wrote: On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching Fix rts5227&5249 failed send buffer cmd after suspend, PM_CTRL3 should reset before send any bu

Re: [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249

2014-09-17 Thread micky
On 09/18/2014 12:53 PM, Lee Jones wrote: On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote: From: Micky Ching Fix rts5227&5249 failed send buffer cmd after suspend, PM_CTRL3 should reset before send any buffer cmd after suspend. Otherwise, buffer cmd will failed, this will lead re

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread micky
will lead UHSI card failed to enter UHSI mode. It is hard to control the UEFI driver leaving state, so we power off the card power during probe. Signed-off-by: Roger Tseng Signed-off-by: Micky Ching --- drivers/mmc/host/rtsx_pci_sdmmc.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion

Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227

2014-09-12 Thread micky
uot; but I don't know if it makes a difference here? Hi Dan, these function never return positive value, but other part of the driver code use (err < 0), I use (err < 0) here for consistency. (err) and (err < 0) is same at least for these function called here. Best Regards. mic

Re: [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*phspecifiertodump memory

2014-08-03 Thread micky
On 08/02/2014 01:55 AM, Fabio Falzoi wrote: On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote: Documentation/printk-formats.txt Raw buffer as a hex string: %*ph00 01 02 ... 3f %*phC 00:01:02: ... :3f %*phD 00-01-02- ... -3f %*phN 000102 ... 3f

Re: [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-07 Thread micky
On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread micky
len), false) +#ifdef DEBUG +#define rtsx_hex_dump(buf, len)\ + print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len) #else -#define RTSX_DUMP(buf, buf_len) +#define rtsx_hex_dump(buf, len)\ + do {;}while(0) Hi, here exist

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-07-02 Thread micky
On 06/18/2014 04:00 PM, Lee Jones wrote: On Mon, 16 Jun 2014, Ulf Hansson wrote: On 16 June 2014 14:20, Lee Jones wrote: From: Micky Ching rtsx driver using a single function for transfer data, dma map/unmap are placed in one fix function. We need map/unmap dma in different place(for mmc

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-23 Thread micky
Hi Uffe, do you accepted this patch? if accepted, I will submit again with jones ack. Best Regards. micky. On 06/19/2014 09:57 AM, micky wrote: On 06/18/2014 07:03 PM, Ulf Hansson wrote: On 18 June 2014 12:08, micky wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 07:03 PM, Ulf Hansson wrote: On 18 June 2014 12:08, micky wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-17 Thread micky
On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread micky
gards. micky. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr; struct mmc_host *mmc; struct mmc_request *mrq

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-16 Thread micky
during handle request. So I use workq, we just queue a work and return in ops->request(), The mmc core can continue without blocking at ops->request(). Best Regards. micky. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings"

2014-05-08 Thread micky
e best we can do, until Chris shows up again. Kind regards Ulf Hansson From: Micky Ching This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08. The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d , but the previous patch was discard. So we have to delete the patch. Signed

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req"

2014-05-07 Thread micky
Hi Lee Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req" if need for 3.15 fix. Best Regards. micky. On 04/29/2014 03:36 PM, Ulf Hansson wrote: On 29 April 2014 03:54, wrote: >From: Micky Ching > >

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove smatch warnings"

2014-05-07 Thread micky
Hi Lee It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. Best Regards. micky. On 04/29/2014 03:30 PM, Ulf Hansson wrote: On 29 April 2014 03:54, wrote: >From: Micky Ching > >This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d0

Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

2014-04-29 Thread micky
Hi Lee, On 04/29/2014 04:02 PM, Lee Jones wrote: From: Micky Ching The commit have some problem, using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix these problem, and better to use a new method. So just remove it. The commit depends on the previous patch. And

Re: [PATCH] staging: rts5208: fix static checker warnings

2014-04-29 Thread micky
Hi Dan, I have send this patch to fix the static checker warning, but not applied yet. Best Regards. micky. On 04/02/2014 05:58 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching The patch fa590c222fba: "staging: rts5208: add support for rts5208 and rts5288" from Nov 12, 2

Re: [PATCH v2 2/2] mmc: rtsx: modify error handle and remove smatchwarnings

2014-04-28 Thread micky
Hi Chris and Ulf, This patch is denpend on commit c42deffd5b53c9e583d83c7964854ede2f12410d. , and we discard the previous commit. we want discard this patch also(it it now in linux-next), need I send another patch to revert or it will be discard automatically? Best Regards. micky. On 03/27

Re: [PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

2014-04-28 Thread micky
Hi Chris and Ulf, This patch should be applied to 3.15(rc), 3.14, 3.13. without this patch the MMC card can not identified. Best Regards. micky. On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req"

2014-04-28 Thread micky
Hi Chris and Ulf, Since the original commit is merged into kernel 3.15-rc, we want this patch apply to the 3.15-rc to avoid cause serious problem. Is there any thing I need do? Best Regards. micky. On 04/28/2014 03:36 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching This reverts

Re: rtsx_pci_sdmmc lockdep splat

2014-04-21 Thread micky
Hi Borislav Thank you for test the patch. It seems we can't use tasklet here due to mutex_lock. And the spinlock may removed, I'm prepare to resend a different patch later. Best Regards. micky On 04/20/2014 08:20 PM, Borislav Petkov wrote: Hi, On Wed, Apr 16, 2014 at 09:50:15AM +0

Re: Locking issues in "mmc: rtsx: add support for pre_req and post_req"

2014-04-21 Thread micky
Hi Peter, I'm considering not using spinlock to get it work and will resend the patch later. Thank you. Best Regards. micky On 04/19/2014 07:13 AM, Peter Wu wrote: So, I reverted c42deffd5b53c9e583d83c7964854ede2f12410d ("mmc: rtsx: add support for pre_req and post_req") on t

Re: rtsx_pci_sdmmc lockdep splat

2014-04-15 Thread micky
Hi Borislav, On 04/16/2014 01:49 AM, Borislav Petkov wrote: Hi all, I'm seeing the following when I insert an sd card. Kernel is 3.15-rc1+. Thanks. The patch below may fix this problem. From: Micky Ching To avoid dead lock, we need make sure host->lock is always acquire before p

Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle

2014-03-25 Thread micky
Hi Ulf, On 03/25/2014 06:44 PM, Ulf Hansson wrote: On 25 March 2014 10:47, wrote: From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover

Re: [PATCH v2 0/3] mmc: rtsx: fix bug and support nonblocking request

2014-02-20 Thread micky
Hi Chris, Could you please give me some idea about this patch-set? I send this patch-set many times, but didn't get any reply. Best Regards. micky On 02/17/2014 04:45 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching First we fix the card poweroff bug: the card power is not shu

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2014-01-10 Thread micky
Hi, On 01/10/2014 03:26 PM, Francis Moreau wrote: I still can see any traces of this fix in Linus' tree. Shouldn't this get merged before 3.13 is out ? Thanks Good, I think it is good to merge. Thanks. Best Regards. micky. -- To unsubscribe from this list: send the line "un

Re: [PATCH v3 0/2] fix sd power bug and modify phase-searching method

2013-12-22 Thread micky
Hi, Is there anything wrong with this patch? It seems a long time, but I didn't got any reply. On 12/03/2013 10:34 AM, micky_ch...@realsil.com.cn wrote: From: Micky Ching If the driver removed while sd card still in the slot, the card power will not power down correctly, if we inser

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-19 Thread micky
Hi Francis, We are trying to get the environment same with yours, so it may take some to solve this problem. maybe next month. Best Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-17 Thread micky
10/2013 02:56 AM, micky wrote: Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can you help us test this patch, we disable irq while suspend here. This patch doesn't seem to help, it still oops: [ 29.843910] [ cut here ] [

Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-17 Thread micky
On 12/17/2013 03:28 PM, Dan Carpenter wrote: On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h index 947e79b..26b52ec 100644 --- a/drivers/mfd/rtsx_pcr.h +++ b/drivers/mfd/rtsx_pcr.h @@ -63,4 +63,12 @@ static

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

2013-12-09 Thread micky
Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can you help us test this patch, we disable irq while suspend here. From 6b2bd6d85780bfd8d4fe5289aee1b09dd655d2d4 Mon Sep 17 00:00:00 2001 From: Micky Ching Date: Thu, 5 Dec 2013 16:44:19 +0800 Subject: [

Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings

2013-12-03 Thread micky
.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized] drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized] Signed-of

Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings

2013-12-03 Thread micky
On 12/03/2013 06:40 PM, Lee Jones wrote: By the way, I'm going to apply this patch now. So, in next patch-set, I will not include this patch. -- Best Regards Micky. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH v2 2/3] mfd: rtsx: add card reader rtl8402

2013-12-03 Thread micky
On 12/03/2013 06:45 PM, Lee Jones wrote: From: Micky Ching Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to rtl8411.c Signed-off-by: Lee Jones I have never signed this patch off. These tags actually 'mean' something. Please don't apply them willy-nil

Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings

2013-12-03 Thread micky
.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized] drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings': drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized] Signed-of

Re: [PATCH 2/2] mmc: rtsx: modify phase searching method for tunning

2013-11-20 Thread micky
quot; anything it only returns zero on success? "phase_point" might be helpful but I don't know what a phase_point is. Add a comment about that maybe. Yes, thank you for your suggestion, the function name is really not good. I want use test_phase_bit(u32 phase_map, unsigned int bit),

Re: [PATCH 1/4] mfd: rtsx: Generify call-back operations in orderto reduce code duplication

2013-11-14 Thread micky
the if-else not work correctly. -- Best Regards Micky. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/4] mfd: rtsx: Generify the switch voltage routine

2013-11-14 Thread micky
_sel_1v8); if (err < 0) return err; - val = (BPP_ASIC_1V8 << BPP_TUNED18_SHIFT_8411) | BPP_PAD_1V8; + val = (BPP_ASIC_1V8 << shift) | BPP_PAD_1V8; } else { return -EINVAL; } -- Best Regar

Re: [PATCH] mfd: rtsx: add card reader rtl8402

2013-11-13 Thread micky
patch, so if you can send me your Signed-off-by: for that one, I will add that and make you the author. Sorry, I haven't received the patch-set you send, can you please resend the patch to me? -- Best Regards Micky. -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH] mfd: rtsx: add card reader rtl8402

2013-11-12 Thread micky
mewhat big change , and I will add it in a later time. So, I wanna to send the merged patch first, is that ok? On 11/08/2013 05:56 PM, Lee Jones wrote: On Fri, 01 Nov 2013, micky_ch...@realsil.com.cn wrote: From: Micky Ching Add card reader rtl8042, rtl8402 is much like rtl8411, so just

Re: [PATCH] memstick: rtsx: fix ms card data transfer bug

2013-11-05 Thread micky
card, ms card use normal read/write mode for DMA data transfer. What are the user-visible effects of this bug? Please always include this information when fixing bugs so that others can decide whether they (or their customers) need the patch. . -- Best Regards Micky. -- To unsubscribe from this

Re: [PATCH] mmc: rtsx: change phase searching method

2013-10-29 Thread micky
Hi Chris: Have you accepted this patch, I'm waiting a long time for your reply. Best Reagards. micky On 09/02/2013 05:16 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching The new phase searching method is more concise, and makes the code easier to understand. Signed-off-by:

Re: [PATCH] mmc: rtsx: change phase searching method

2013-10-16 Thread micky
Hi Chris: have you accepted this patch ? micky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/