On Tue, 20 Apr 2021, Tom Rix wrote:
On 4/20/21 10:27 AM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Gracefully ignore misconfigured port entries encountered in
incorrect FPGA images.
Signed-off-by: Matthew Gerlach
---
drivers/fpga/dfl-pci.c | 16 +++-
1
From: Matthew Gerlach
Gracefully ignore misconfigured port entries encountered in
incorrect FPGA images.
Signed-off-by: Matthew Gerlach
---
drivers/fpga/dfl-pci.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl
From: Matthew Gerlach
This patch adds a Device Feature List (DFL) bus driver for the
Altera SPI Master controller. The SPI master is connected to an
Intel SPI Slave to Avalon Bridge inside an Intel MAX10
BMC Chip.
Signed-off-by: Matthew Gerlach
---
v3: Instantiate SPI device instead of
From: Matthew Gerlach
This patch set adds Device Feature List (DFL) bus support for
the Altera SPI Master controller.
Patch 1 separates spi-altera.c into spi-altera-core.c and
spi-altera-platform.c.
Patch 2 adds spi-altera-dfl.c.
Matthew Gerlach (2):
spi: altera: separate core code from
From: Matthew Gerlach
In preparation of adding support for a new bus type,
separate the core spi-altera code from the platform
driver code.
Signed-off-by: Matthew Gerlach
---
drivers/spi/Kconfig | 9 +-
drivers/spi/Makefile | 3 +-
drivers/spi/spi-altera-core.c
On Wed, 14 Apr 2021, Mark Brown wrote:
On Tue, Apr 13, 2021 at 03:58:34PM -0700, matthew.gerl...@linux.intel.com wrote:
+++ b/drivers/spi/spi-altera-dfl.c
@@ -0,0 +1,222 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * DFL bus driver for Altera SPI Master
+ *
Please make the entire comment
From: Matthew Gerlach
This patch adds a Device Feature List (DFL) bus driver for the
Altera SPI Master controller. The SPI master is connected to an
Intel SPI Slave to Avalon Master Bridge inside an Intel MAX10
BMC Chip.
Signed-off-by: Matthew Gerlach
---
v2: moved drivers/fpga/dfl-spi
From: Matthew Gerlach
Like the Intel N3000 card, the Intel D5005 has a MAX10 based
BMC. This commit adds support for the D5005 sensors that are
monitored by the MAX10 BMC.
Signed-off-by: Matthew Gerlach
Signed-off-by: Russ Weight
Acked-by: Lee Jones
---
v2: change variable name from
From: Matthew Gerlach
This patch set adds support for the Board Management Controller (BMC)
of an Intel D5005 card. The BMC support requires a Device Feature
List (DFL) bus driver for the Altera SPI Master controller and hwmon
support for the sensors monitored by the BMC.
Patch 1 adds a dfl
On Fri, 9 Apr 2021, Wu, Hao wrote:
On Fri, Apr 09, 2021 at 12:02:47PM +0800, Wu, Hao wrote:
+
+static void dfl_spi_altera_remove(struct dfl_device *dfl_dev)
+{
+struct dfl_altera_spi *aspi = dev_get_drvdata(&dfl_dev->dev);
+
+platform_device_unregister(aspi->altr_spi);
+}
+
+#define FME_FEAT
Hi Yilun,
On Tue, 6 Apr 2021, Xu Yilun wrote:
On Mon, Apr 05, 2021 at 04:53:01PM -0700, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Like the Intel N3000 card, the Intel D5005 has a MAX10 based
BMC. This commit adds support for the D5005 sensors that are
monitored by the
Hi Moritz,
On Mon, 5 Apr 2021, Moritz Fischer wrote:
Hi Matthew,
On Mon, Apr 05, 2021 at 04:53:00PM -0700, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
This patch adds DFL bus driver for the Altera SPI Master
controller. The SPI master is connected to an Intel SPI Slave
: Matthew Gerlach
---
drivers/fpga/dfl-pci.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
index 04e47e2..b44523e 100644
--- a/drivers/fpga/dfl-pci.c
+++ b/drivers/fpga/dfl-pci.c
@@ -69,14 +69,16 @@ static void
From: Matthew Gerlach
Like the Intel N3000 card, the Intel D5005 has a MAX10 based
BMC. This commit adds support for the D5005 sensors that are
monitored by the MAX10 BMC.
Signed-off-by: Matthew Gerlach
Signed-off-by: Russ Weight
---
drivers/hwmon/intel-m10-bmc-hwmon.c | 122
From: Matthew Gerlach
This patch set adds basic support for the Intel D5005 card to the
dfl driver framework.
Patch 1 adds the PCIe device id of the D5005 to the dfl-pci id table.
Patch 2 adds a dfl driver for the Altera SPI Master which is connected
to the board's BMC.
Patch 3 adds
From: Matthew Gerlach
This patch adds DFL bus driver for the Altera SPI Master
controller. The SPI master is connected to an Intel SPI Slave to
Avalon Master Bridge, inside an Intel MAX10 BMC Chip.
Signed-off-by: Matthew Gerlach
---
drivers/fpga/Kconfig | 9 ++
drivers/fpga
From: Russ Weight
This patch adds the approved PCI Express Device IDs for the
PF and VF for the card for D5005 PAC cards.
Signed-off-by: Russ Weight
Signed-off-by: Matthew Gerlach
---
drivers/fpga/dfl-pci.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git
Reviewed-by: Matthew Gerlach
On Thu, 4 Feb 2021, Russ Weight wrote:
Port enable is not complete until ACK = 0. Change
__afu_port_enable() to guarantee that the enable process
is complete by polling for ACK == 0.
Reviewed-by: Tom Rix
Signed-off-by: Russ Weight
---
v4:
- Added a dev_warn
ing
I also confirmed with HW engineers. The original specification was
not precise. The code should have been doing this all along.
Matthew Gerlach
hasn't been an issue for the current PAC products, as proven by our testing.
However, with OFS we cannot anticipate what the timing will be
On Wed, 20 Jan 2021, Pan Bian wrote:
Release master that have been previously allocated if the number of
chipselect is invalid.
Fixes: 8e04187c1bc7 ("spi: altera: add SPI core parameters support via platform
data.")
Signed-off-by: Pan Bian
Acked-by: Matthew Gerlach
---
drive
quote ends without a blank line; unexpected unindent.
Rectify ReST formatting in ./Documentation/fpga/dfl.rst.
Signed-off-by: Lukas Bulwahn
Acked-by: Moritz Fischer
Acked-by: Matthew Gerlach
---
applies cleanly on next-20210111
Moritz, Matthew, please ack.
Greg, please pick this doc fixup to
From: Matthew Gerlach
A PCIe vendor specific extended capability is introduced by Intel to
specify the start of a number of DFLs.
Signed-off-by: Matthew Gerlach
---
v4: Clarify PCI vs. PCIe in documentation
Various cleanup suggested by hao...@intel.com
Document and enforce specifying a
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor specific pci
capability, move the code for the default method of finding the first
dfl at offset 0 of Bar 0 to its own function.
Signed-off-by: Matthew Gerlach
Acked-by: Wu Hao
---
v4: add comment
squash local
From: Matthew Gerlach
The start of a Device Feature List (DFL) is currently assumed to be at
Bar0/Offset 0 on the PCIe bus by drivers/fpga/dfl-pci.c. This patchset
adds support for the start one or more DFLs to be specified in a
Vendor-Specific Capability (VSEC) structure in PCIe config space
On Wed, 2 Dec 2020, Wu, Hao wrote:
+ }
+
+ offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK;
+ if (offset >= len) {
+ dev_err(&pcidev->dev, "%s bad
offset %u >= %pa\n",
+ __func__, offset, &len);
+
vendor specific capability
Maybe we can change the title a little bit, what about
fpga: dfl-pci: locate DFLs by PCIe vendor specific capability
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs
On Sat, 28 Nov 2020, Wu, Hao wrote:
Subject: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability
Maybe we can change the title a little bit, what about
fpga: dfl-pci: locate DFLs by PCIe vendor specific capability
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR
On Sat, 28 Nov 2020, Wu, Hao wrote:
Subject: [PATCH v3 1/2] fpga: dfl: refactor cci_enumerate_feature_devs()
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor
specific pcie capability, move code that assumes
Bar0/offset0 as start of DFL to its own function.
as
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor
specific pcie capability, move code that assumes
Bar0/offset0 as start of DFL to its own function.
Signed-off-by: Matthew Gerlach
---
v3: no change
v2: remove spurious blank lines
rename find_dfl_in_bar0 to
From: Matthew Gerlach
The start of a Device Feature List (DFL) is currently assumed to be at
Bar0/Offset 0 on the PCIe bus by drivers/fpga/dfl-pci.c. This patchset
adds support for the start one or more DFLs to be specified in a
Vendor-Specific Capability (VSEC) structure in PCIe config space
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by: Matthew Gerlach
---
v3: Add text and ascii art to documentation.
Ensure not to exceed PCIe config space in loop.
v2
On Sat, 21 Nov 2020, Moritz Fischer wrote:
Hi Matthew,
On Wed, Nov 18, 2020 at 11:01:51AM -0800, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs
From: Matthew Gerlach
The start of a Device Feature List (DFL) is currently assumed to be at
Bar0/Offset 0 on the PCIe bus by drivers/fpga/dfl-pci.c. This patchset
adds support for the start one or more DFLs to be specified in a
Vendor-Specific Capability (VSEC) structure in PCIe config space
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor
specific pcie capability, move code that assumes
Bar0/offset0 as start of DFL to its own function.
Signed-off-by: Matthew Gerlach
---
v2: remove spurious blank lines
rename find_dfl_in_bar0 to find_dfls_by_default
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by: Matthew Gerlach
---
v2: Update documentation for clarity.
Clean up macro names.
Use GENMASK.
Removed spurious
On Wed, 18 Nov 2020, Wu, Hao wrote:
On Tue, 17 Nov 2020, Wu, Hao wrote:
[...]
Open discussion
===
diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
index b1b157b41942..5418e8bf2496 100644
--- a/drivers/fpga/dfl-pci.c
+++ b/drivers/fpga/dfl-pci.c
@@ -27,6 +27,13 @@
On Tue, 17 Nov 2020, Tom Rix wrote:
On 11/16/20 5:25 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by: Matthew Gerlach
On Tue, 17 Nov 2020, Wu, Hao wrote:
Subject: [PATCH 2/2] fpga: dfl: look for vendor specific capability
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by: Matthew Gerlach
On Tue, 17 Nov 2020, Xu Yilun wrote:
On Mon, Nov 16, 2020 at 05:25:52PM -0800, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by
On Tue, 17 Nov 2020, Wu, Hao wrote:
Subject: [PATCH 1/2] fpga: dfl: refactor cci_enumerate_feature_devs()
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor
specific pcie capability, move code that assumes
Bar0/offset0 as start of DFL to its own function.
Signed
From: Matthew Gerlach
A DFL may not begin at offset 0 of BAR 0. A PCIe vendor
specific capability can be used to specify the start of a
number of DFLs.
Signed-off-by: Matthew Gerlach
---
Documentation/fpga/dfl.rst | 10 +
drivers/fpga/dfl-pci.c | 88
From: Matthew Gerlach
The start of a Device Feature List (DFL) is currently assumed to be at
Bar0/Offset 0 on the PCIe bus by drivers/fpga/dfl-pci.c. This patchset
adds support for the start of one or more DFLs to be specified in a
Vendor-Specific Capability (VSEC) structure in PCIe config
From: Matthew Gerlach
In preparation of looking for dfls based on a vendor
specific pcie capability, move code that assumes
Bar0/offset0 as start of DFL to its own function.
Signed-off-by: Matthew Gerlach
---
drivers/fpga/dfl-pci.c | 86 --
1 file
This looks like a a good change to me.
Tested-by: Matthew Gerlach
On Thu, 7 May 2020, Gustavo A. R. Silva wrote:
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones
Hi Yilun,
You raise some very interesting questions. Please see
my comments below.
Matthew
On Tue, 28 Apr 2020, Xu Yilun wrote:
Hi,
I wonder if an updating of FPGA Flash (but cannot reload) could be
implemented as fpga-mgr?
I have the pcie based FPGA card. The bitstream for FPGA static regi
On Wed, 24 Oct 2018, Moritz Fischer wrote:
Hi Anatolij, Andreas,
On Tue, Oct 23, 2018 at 06:46:47PM +, Andreas Puhm wrote:
Hi Anatolij,
The CvP docs says that on some FPGAs (e.g. Arria 10) the assertion of CVP
status can take up to 500ms. However it is not clear whether this delay
mig
On Mon, 12 Mar 2018, Wu Hao wrote:
Hi Hao,
Please see my two comments inline.
Thanks,
Matthew Gerlach
On Sun, Mar 11, 2018 at 01:09:31PM -0700, matthew.gerl...@linux.intel.com wrote:
On Mon, 5 Mar 2018, Alan Tull wrote:
Hi Hao,
I do think we should consider different hw
consider new hardware implementations as well.
Full disclosure, I am particularly interested in porting to a new hw
implementation for partial reconfiguration.
Please see some comments below.
Matthew Gerlach
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote:
Hi Hao,
We are going to want to be able use
On Thu, 25 Jan 2018, Alan Tull wrote:
Hi Alan,
I seem to remember issue coming up a couple of times.
I think this comment will be very helpful.
Matthew Gerlach
Add a comment to the header of fpga_region_program_fpga()
regarding locking of the bridges.
Signed-off-by: Alan Tull
---
drivers
From: Matthew Gerlach
This patch adds support for a spi-nor, platform driver for the
Altera ASMI Parallel II IP Core. The intended use case is to be able
to update the flash used to load a FPGA at power up with mtd-utils.
Signed-off-by: Matthew Gerlach
---
v2:
minor checkpatch fixing by
From: Matthew Gerlach
Device Tree bindings for Altera ASMI Parallel II IP Core
connected to a flash chip.
Signed-off-by: Matthew Gerlach
Acked-by: Rob Herring
---
v2:
Made substitutions suggested by Rob Herring.
Emphasize driver expects controller is connected to spi-nor flash.
v3
From: Matthew Gerlach
This patch set adds a spi-nor flash driver for the Altera ASMI Parallel II
IP Core. This driver was created based on feedback from Marek Vasut,
Cyrill Pitchen, and Michal Suchanek regarding Version 2 of the Altera
Quadspi Controller: https://lkml.org/lkml/2017/6/26/518
Hi Cyrille,
Thanks for the feedback. See my comments in line below.
Matthew Gerlach
On Tue, 10 Oct 2017, Cyrille Pitchen wrote:
Hi Matthew
NAK for this patch
Le 20/09/2017 à 20:28, matthew.gerl...@linux.intel.com a écrit :
From: Matthew Gerlach
This patch is a work around for some
On Wed, 11 Oct 2017, Marek Vasut wrote:
On 10/11/2017 07:00 PM, matthew.gerl...@linux.intel.com wrote:
On Tue, 10 Oct 2017, Marek Vasut wrote:
On 09/20/2017 08:28 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
This patch adds support for a spi-nor, platform driver
On Tue, 10 Oct 2017, Marek Vasut wrote:
On 09/20/2017 08:28 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
This patch adds support for a spi-nor, platform driver for the
Altera ASMI Parallel II IP Core. The intended use case is to be able
to update the flash used to load
Hi Everyone,
Thanks to Rob Herring for Acking the device tree bindings part of the
patch. Does anyone have any feedback for the rest of the patch set?
Thanks,
Matthew Gerlach
On Wed, 20 Sep 2017, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
This patch set adds a spi
4.9 and
4.12 kernels, but I suspect similar behavior.
Matthew Gerlach
On Wed, 27 Sep 2017, Vignesh R wrote:
Hi Matthew,
On Tuesday 26 September 2017 05:19 AM, Marek Vasut wrote:
[...]
Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for
QSPI on SoCFPGA or if
_*() calls.
Not of the top of my head, sorry. +CC Matthew, he should know.
I am not an expert at the clock framework nor the power management, but I
did ask around a bit. No one I asked was planning to change the clk_*()
calls to pm_*() call, but the feedback was that it would be a good idea
From: Matthew Gerlach
This patch set adds a spi-nor flash driver for the Altera ASMI Parallel II
IP Core. This driver was created based on feedback from Marek Vasut,
Cyrill Pitchen, and Michal Suchanek regarding Version 2 of the Altera
Quadspi Controller: https://lkml.org/lkml/2017/6/26/518
From: Matthew Gerlach
This patch adds support for a spi-nor, platform driver for the
Altera ASMI Parallel II IP Core. The intended use case is to be able
to update the flash used to load a FPGA at power up with mtd-utils.
Signed-off-by: Matthew Gerlach
---
v2:
minor checkpatch fixing by
From: Matthew Gerlach
This patch is a work around for some non-standard behavior
of EPCQ flash parts:
https://www.altera.com/documentation/wtw1396921531042.html#wtw1396921651224
These flash parts are generally used to configure Intel/Altera FPGAs
on power up. These parts report a JEDEC id of
From: Matthew Gerlach
Device Tree bindings for Altera ASMI Parallel II IP Core
connected to a flash chip.
Signed-off-by: Matthew Gerlach
---
v2:
Made substitutions suggested by Rob Herring.
Emphasize driver expects controller is connected to spi-nor flash.
---
Documentation/devicetree
On Thu, 14 Sep 2017, Alan Tull wrote:
On Wed, Sep 13, 2017 at 6:38 PM, wrote:
Hi Matthew,
Hi Alan,
Two minor nits below.
Matthew Gerlach
On Wed, 13 Sep 2017, Alan Tull wrote:
Add two functions for getting the FPGA bridge from the device
rather than device tree node. This is to
Hi Alan,
s/mixxed/mixed/
On Wed, 13 Sep 2017, Alan Tull wrote:
The fpga menuconfig has gotten messy. The bridges and managers are
mixxed together.
* Separate the bridges and things dependent on CONFIG_FPGA_BRIDGE
from the managers.
* Group the managers by vendor in order that they were add
Hi Alan,
Just a couple of minor nits.
Matthew Gerlach
On Wed, 13 Sep 2017, Alan Tull wrote:
Create of-fpga-region.c and ove the following functions without
s/ove/move/
modification from fpga-region.c.
* of_fpga_region_find
* of_fpga_region_get_mgr
* of_fpga_region_get_bridges
Hi Alan,
Two minor nits below.
Matthew Gerlach
On Wed, 13 Sep 2017, Alan Tull wrote:
Add two functions for getting the FPGA bridge from the device
rather than device tree node. This is to enable writing code
that will support using FPGA bridges without device tree.
Rename one old function
Hi Cyrille,
I think I figured out the confusion with regards to dummy cycles. See my
comment in line.
Matthew Gerlach
On Tue, 15 Aug 2017, Cyrille Pitchen wrote:
Le 15/08/2017 à 19:20, matthew.gerl...@linux.intel.com a écrit :
Hi Cyrille,
Thanks for the great feedback. See my
Hi Cyrille,
Thanks for the great feedback. See my comments inline.
Matthew Gerlach
On Fri, 11 Aug 2017, Cyrille Pitchen wrote:
Hi Matthew,
Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a écrit :
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS
Hi Rob,
Thanks for the feedback. Please see my comments in line.
Matthew Gerlach
On Thu, 10 Aug 2017, Rob Herring wrote:
On Sun, Aug 06, 2017 at 11:24:02AM -0700, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Device Tree bindinds for Altera ASMI Parallel II IP Core.
s
From: Matthew Gerlach
Add a newline to the end of drivers/spi-nor/Makefile to get rid the message,
"No newline at end of file", produced by git. This fix will allow subsequent
changes to the file to be able to produce clean patches.
Signed-off-by: Matthew Gerlach
---
drivers/m
On Sun, 6 Aug 2017, Marek Vasut wrote:
Hi Marek,
Thanks for the feedback. Please see comments inline.
Matthew Gerlach
On 08/06/2017 08:24 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Thanks for the descriptive commit message. Could you explain what this
patch is
From: Matthew Gerlach
This patch set adds a spi-nor flash driver for the Altera ASMI Parallel II
IP Core. This driver was created based on feedback from Marek Vasut,
Cyrill Pitchen, and Michal Suchanek regarding Version 2 of the Altera
Quadspi Controller: https://lkml.org/lkml/2017/6/26/518
From: Matthew Gerlach
Add FPGA Management Entity Feature to support Atera
ASMI Parallel 2 IP core. This feature allows
the flash used to configure the FPGA at power up
to be updated over PCIe using mtd-utils.
Signed-off-by: Matthew Gerlach
---
drivers/fpga/intel/feature-dev.h | 6
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS | 7 +
drivers/mtd/spi-nor/Kconfig | 6 +
drivers/mtd/spi-nor/Makefile| 3 +-
drivers/mtd/spi-nor/altera-asmip2.c | 474
include/linux/mtd
From: Matthew Gerlach
Device Tree bindinds for Altera ASMI Parallel II IP Core.
Signed-off-by: Matthew Gerlach
---
.../devicetree/bindings/mtd/altera-asmip2.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mtd/altera
On Tue, 4 Jul 2017, Cyrille Pitchen wrote:
Hi Cyrille,
Thanks for all the great feedback. Clearly, I've got some work to do.
Please see my comments inline.
Matthew Gerlach
Hi Matthew,
Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
From: Matthew Gerlach
Signe
2017, Marek Vasut wrote:
Hi Marek,
Thanks for the feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Device Tree bindings for Version 2 of the Altera Quadspi Controller
that can be optionally paired with a
2 patch set does not have my changes in it, but adding discussion in
the cover letter is great idea!
Many thanks,
Matthew Gerlach
This technique of separating core driver code from platform/device tree
code has been reviewed and accepted for the Altera Partial
Reconfiguration IP, Altera Fr
...@linux.intel.com wrote:
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks for the feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Device Tree bindings for Version 2 of the Altera Quadspi
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 05:15 PM, matthew.gerl...@linux.intel.com wrote:
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Just wrap it into the Altera QSPI driver , no need for
t for version 2 of the Altera Quadspi
controller.
This technique of separating core driver code from platform/device tree
code has been reviewed and accepted for the Altera Partial Reconfiguration
IP, Altera Freeze Bridge, and the fpga region.
Matthew Gerlach
--
Best regards,
Marek Vasut
. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Device Tree bindings for Version 2 of the Altera Quadspi Controller
that can be optionally paired with a windowed bridge.
Signed-off-by: Matthew Gerlach
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 04:32 PM, matthew.gerl...@linux.intel.com wrote:
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks for the feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Just wrap it into the Altera QSPI driver , no need for separate platform
driver IMO.
Hi Marek,
I answered this question when you asked why the header file was
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks again for the valuable feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks for the feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Device Tree bindings for Version 2 of the Altera Quadspi Controller
that can be
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS | 7 +
drivers/mtd/spi-nor/Kconfig | 5 +
drivers/mtd/spi-nor/Makefile | 4 +-
drivers/mtd/spi-nor/altera-quadspi.c | 676 +++
include/linux/mtd
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS | 1 +
drivers/mtd/spi-nor/Kconfig | 5 +
drivers/mtd/spi-nor/Makefile | 1 +
drivers/mtd/spi-nor/altera-quadspi-platform.c | 137
From: Matthew Gerlach
Hi Everyone,
This patch set adds support for Version 2 of the Altera
Quadspi Controller. Version 1 of the Altera Quadspi
Controller only supported 1 byte of flash id instead of
the 3 bytes required for a JEDEC ID. As such the driver
for Version 1 was rejected. Please
From: Matthew Gerlach
Device Tree bindings for Version 2 of the Altera Quadspi Controller
that can be optionally paired with a windowed bridge.
Signed-off-by: Matthew Gerlach
---
.../devicetree/bindings/mtd/altera-quadspi-v2.txt | 37 ++
1 file changed, 37 insertions
rface or something else? Do you
use the sof or an rbf file?
Thanks,
Matthew Gerlach
Changes in v3:
- removed V-series from description (since the driver works
also with Arria-10). Also renamed functions, config option
and driver file name. Changed module description in Kconfig
- dr
On Wed, 12 Apr 2017, kbuild test robot wrote:
Hi Tobias,
Hi Tobias,
This is very interesting issue brought up by your patch that turns
on COMPILE_TEST in drivers/fpga/Kconfig. See my comment below.
Matthew Gerlach
[auto build test WARNING on linus/master]
[also build test WARNING on
From: Matthew Gerlach
The value in the version register of the altera freeze bridge
controller changed from the beta value of 2 to the
value of 0xad03 in the official release of the IP.
This patch supports the old and new version numbers, and the
driver's probe function will fail if ne
On Wed, 5 Apr 2017, Moritz Fischer wrote:
Hi Matthew,
Hi Moritz,
On Wed, Apr 5, 2017 at 12:05 PM, wrote:
From: Matthew Gerlach
The value in the version register of the altera freeze bridge
controller changed from the beta value of 2 to the
value of 0xad03 in the official
From: Matthew Gerlach
The value in the version register of the altera freeze bridge
controller changed from the beta value of 2 to the
value of 0xad03 in the official release of the IP.
This patch supports the old and new version numbers
without printing an warning.
Signed-off-by: Matthew
On Mon, 3 Apr 2017, Alan Tull wrote:
On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao wrote:
From: Kang Luwei
Partial Reconfiguration (PR) is the most important function for FME. It
allows reconfiguration for given Port/Accelerated Function Unit (AFU).
This patch adds support for PR sub feature. I
On Fri, 31 Mar 2017, Wu Hao wrote:
On Fri, Mar 31, 2017 at 08:09:09AM +0200, Greg KH wrote:
On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote:
During FPGA device (e.g PCI-based) discovery, platform devices are
registered for different FPGA function units. But the device node path
isn't
On Thu, 30 Mar 2017, Wu Hao wrote:
Hi Wu Hao,
Great documentation. I'm looking forward to diving into the rest of the
patches. Please see my comments inline.
Matthew Gerlach
Add a document for Intel FPGA driver overview.
Signed-off-by: Enno Luebbers
Signed-off-by: Xiao Guan
On Tue, 21 Mar 2017, Anatolij Gustschin wrote:
Hi Matthew,
Hi Anatolij,
On Fri, 10 Mar 2017 11:40:25 -0800
matthew.gerl...@linux.intel.com matthew.gerl...@linux.intel.com wrote:
...
+int alt_pr_unregister(struct device *dev)
+{
+ dev_dbg(dev, "%s\n", __func__);
+
+ fpga_mgr_u
From: Matthew Gerlach
Adding the core functions necessary for a fpga-mgr driver
for the Altera Partial IP component. It is intended for
these functions to be used by the various bus implementations
like the platform bus or the PCIe bus.
Signed-off-by: Matthew Gerlach
---
v6:
Suggestions
1 - 100 of 138 matches
Mail list logo