Re: [PATCH v1] selftests: iou-zcrx: Get the page size at runtime

2025-04-24 Thread Jens Axboe
On 4/24/25 5:29 PM, Jakub Kicinski wrote: > On Thu, 24 Apr 2025 17:09:28 -0600 Jens Axboe wrote: >> On Sat, 19 Apr 2025 22:10:15 +0800, Haiyue Wang wrote: >>> Use the API `sysconf()` to query page size at runtime, instead of using >>> hard code number 4096. >>

Re: [PATCH v1] selftests: iou-zcrx: Get the page size at runtime

2025-04-24 Thread Jens Axboe
Get the page size at runtime commit: 6f4cc653bf408ad0cc203c6ab3088b11f5da11df Best regards, -- Jens Axboe

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-04-04 Thread Jens Axboe
in the normal completion stream. -- Jens Axboe

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-22 Thread Jens Axboe
d to be pretty insular and reinvent things. Yep... >> It seems like Jens suggested that plumbing this through for splice >> was a possibility, but sounds like you disagree. > > Yes, very strongly. And that is very much not what I suggested, fwiw. >> As mentioned above and

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-21 Thread Jens Axboe
On 3/21/25 10:36 AM, Joe Damato wrote: > On Fri, Mar 21, 2025 at 05:14:59AM -0600, Jens Axboe wrote: >> On 3/20/25 11:56 PM, Christoph Hellwig wrote: >>>> I don't know the entire historical context, but I presume sendmsg >>>> did that because there was no o

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-21 Thread Jens Axboe
On 3/21/25 2:30 PM, Joe Damato wrote: > On Fri, Mar 21, 2025 at 09:36:34AM -0700, Joe Damato wrote: >> On Fri, Mar 21, 2025 at 05:14:59AM -0600, Jens Axboe wrote: >>> On 3/20/25 11:56 PM, Christoph Hellwig wrote: >>>>> I don't know the entire historical co

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-21 Thread Jens Axboe
and stick with the splice changes only, if you are (at a high > level) OK with the idea of adding a flag for this to splice. > > In the meantime, I'll take a few more reads through the iouring code > to see if I can work out how sendfile2 might be built on top of that > instead of splice in the kernel. Heh I don't know how you jumped to that conclusion based on my feedback, and seems like it's solidified through other replies. No I'm not saying that the approach makes sense for the kernel, it makes some vague amount of sense only on the premise of "oh but this is easy for applications as they already know how to use sendfile(2)". -- Jens Axboe

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
On 3/19/25 11:45 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: >> On 3/19/25 11:04 AM, Joe Damato wrote: >>> On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: >>>> On 3/19/25 9:32 AM, Joe Damato wrote: >>>>

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
On 3/19/25 11:04 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: >> On 3/19/25 9:32 AM, Joe Damato wrote: >>> On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: >>>> On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Dama

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
ing way to do accomplish this, with free-to-reuse notifications". If the answer is "because splice", then it would seem saner to plumb up those bits only. Would be much simpler too... -- Jens Axboe

[PATCH 0/2] Add FT8716 support

2025-03-13 Thread Jens Reidel
This series adds support for the FocalTech FT8716 touchscreen to the edt-ft5x06 driver. It was tested on the BQ Aquaris X (bq-bardock) and BQ Aquaris X Pro (bq-bardockpro). Jens Reidel (2): dt-bindings: input: touchscreen: edt-ft5x06: Document FT8716 support Input: edt-ft5x06 - add support

[PATCH 2/2] Input: edt-ft5x06 - add support for FocalTech FT8716

2025-03-13 Thread Jens Reidel
This driver is compatible with the FocalTech FT8716 touchscreen, which supports up to 10 concurrent touch points. Add a compatible for it. Signed-off-by: Jens Reidel --- drivers/input/touchscreen/edt-ft5x06.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/touchscreen

[PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Document FT8716 support

2025-03-13 Thread Jens Reidel
Document FocalTech FT8716 support by adding the compatible. Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml| 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation

[PATCH v4 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-03-09 Thread Jens Reidel
read buffer. They were taken from the driver published by Goodix, which does a few more things that don't appear to be necessary for the touchscreen to work properly. Reviewed-by: Neil Armstrong Tested-by: Luca Weiss Signed-off-by: Jens Reidel --- drivers/input/touchscreen/goodix_ber

[PATCH v4 0/2] Add Goodix Berlin-A series support

2025-03-08 Thread Jens Reidel
rnel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: li...@mainlining.org Cc: ~postmarketos/upstream...@lists.sr.ht Signed-off-by: Jens Reidel Jens Reidel (2): dt-bindings: input: goodix,gt9916: Document gt9897 compatible Input: goodix_

[PATCH v4 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-03-08 Thread Jens Reidel
Document the Goodix GT9897 which is a Berlin-A series touchscreen controller IC by Goodix. Acked-by: Rob Herring (Arm) Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v3 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-03-07 Thread Jens Reidel
Document the Goodix GT9897 which is a Berlin-A series touchscreen controller IC by Goodix. Acked-by: Rob Herring (Arm) Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v3 0/2] Add Goodix Berlin-A series support

2025-03-07 Thread Jens Reidel
eiss Cc: linux-in...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: li...@mainlining.org Cc: ~postmarketos/upstream...@lists.sr.ht Signed-off-by: Jens Reidel Jens Reidel (2): dt-bindings: input: goodix,gt9916: Document gt

[PATCH v3 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-03-07 Thread Jens Reidel
read buffer. They were taken from the driver published by Goodix, which does a few more things that don't appear to be necessary for the touchscreen to work properly. Tested-by: Luca Weiss Signed-off-by: Jens Reidel --- drivers/input/touchscreen/goodix_berlin.h | 16 ++- .../

[PATCH v2 0/2] Add Goodix Berlin-A series support

2025-02-13 Thread Jens Reidel
f Kozlowski To: Conor Dooley To: Bastien Nocera To: Hans de Goede To: Neil Armstrong Cc: Luca Weiss Cc: linux-in...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: li...@mainlining.org Cc: ~postmarketos/upstream...@lists.sr.ht Sign

[PATCH v2 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-13 Thread Jens Reidel
read buffer. They were taken from the driver published by Goodix, which does a few more things that don't appear to be necessary for the touchscreen to work properly. Signed-off-by: Jens Reidel Tested-by: Luca Weiss --- drivers/input/touchscreen/goodix_berlin.h | 13 ++ .../

[PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-02-13 Thread Jens Reidel
Document the Goodix GT9897 which is a Berlin-A series touchscreen controller IC by Goodix. Acked-by: Rob Herring (Arm) Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

Re: [PATCH] selftests/vDSO: fix GNU hash table entry size for s390x

2025-02-13 Thread Jens Remus
on s390x. Introduce a new dedicated "gnu_bucket" pointer which is used by the GNU hash. Fixes: e0746bde6f82 ("selftests/vDSO: support DT_GNU_HASH") Signed-off-by: Thomas Weißschuh --- tools/testing/selftests/vDSO/parse_vdso.c | 10 +- 1 file changed, 5 insertions

[PATCH 0/2] Add Goodix Berlin-A series support

2025-02-03 Thread Jens Reidel
ne-de...@vger.kernel.org Cc: li...@mainlining.org Cc: ~postmarketos/upstream...@lists.sr.ht Signed-off-by: Jens Reidel Jens Reidel (2): dt-bindings: input: goodix,gt9916: Document gt9897 compatible Input: goodix_berlin - Add support for Berlin-A series .../input/touchscreen/goodix,gt9916.yaml

[PATCH 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-03 Thread Jens Reidel
read buffer. They were taken from the driver published by Goodix, which does a few more things that don't appear to be necessary for the touchscreen to work properly. Signed-off-by: Jens Reidel --- drivers/input/touchscreen/goodix_berlin.h | 9 .../input/touchs

[PATCH 1/2] dt-bindings: input: goodix,gt9916: Document gt9897 compatible

2025-02-03 Thread Jens Reidel
Document the Goodix GT9897 which is a Berlin-A series touchscreen controller IC by Goodix. Signed-off-by: Jens Reidel --- .../devicetree/bindings/input/touchscreen/goodix,gt9916.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen

Re: [PATCH rcu 3/7] rcu: Document self-propagating callbacks

2025-01-16 Thread Jens Axboe
On 1/16/25 1:02 PM, Paul E. McKenney wrote: > This commit documents the fact that a given RCU callback function can > repost itself. Thanks for adding this! -- Jens Axboe

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Jens Axboe
On 10/2/24 10:02 AM, Mathieu Desnoyers wrote: > On 2024-10-02 17:58, Jens Axboe wrote: >> On 10/2/24 9:53 AM, Mathieu Desnoyers wrote: >>> On 2024-10-02 17:36, Mathieu Desnoyers wrote: >>>> On 2024-10-02 17:33, Matthew Wilcox wrote: >>>>> On Wed, Oct 02

Re: [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers

2024-10-02 Thread Jens Axboe
654 96-Core Processor >> CPU family: 25 >> Model:17 >> Thread(s) per core: 2 >> Core(s) per socket: 96 >> Socket(s):2 >> Stepping: 1 >> Frequency boost: enabled >>

Re: KASAN: null-ptr-deref Write in tctx_task_work_run

2024-03-17 Thread Jens Axboe
, "iou-sqp-%d", sqd->task_pid); set_task_comm(current, buf); @@ -371,7 +375,7 @@ static int io_sq_thread(void *data) atomic_or(IORING_SQ_NEED_WAKEUP, &ctx->rings->sq_flags); io_run_task_work(); mutex_unlock(&sqd->lock); - +err_out: complete(&sqd->exited); do_exit(0); } -- Jens Axboe

Re: [PATCH RERESEND 00/11] splice(file<>pipe) I/O on file as-if O_NONBLOCK

2023-12-14 Thread Jens Axboe
h behave as-expected. Should it? Seems like there's a very high risk of breaking existing use cases here. Have you at all looked into the approach of enabling splice to/from _without_ holding the pipe lock? That, to me, would seem like a much saner approach, with the caveat that I have not looked into that at all so there may indeed be reasons why this is not feasible. -- Jens Axboe

Re: [PATCH 027/141] drbd: Fix fall-through warnings for Clang

2021-04-20 Thread Jens Axboe
On 4/20/21 2:25 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? Applied, thanks. -- Jens Axboe

Re: [PATCH 032/141] floppy: Fix fall-through warnings for Clang

2021-04-20 Thread Jens Axboe
r libata adds a break, this one annotates fallthrough. But the cases are really 100% the same. Why aren't the changes consistent? Both are obviously fine, but for identical cases it seems odd that they differ. IMHO, adding a break makes more sense. Annotate the fallthrough if the two cases share work that needs to be done, as then that solution makes sense. -- Jens Axboe

Re: [PATCH 092/141] libata: Fix fall-through warnings for Clang

2021-04-20 Thread Jens Axboe
On 4/20/21 2:11 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? Applied for 5.13. -- Jens Axboe

Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema

2021-04-20 Thread Jens Wiklander
b5ac8b2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml# > +$

[PATCH] optee: use export_uuid() to copy client UUID

2021-04-20 Thread Jens Wiklander
order to avoid casting. Fixes: c5b4312bea5d ("tee: optee: Add support for session login client UUID generation") Suggested-by: Andy Shevchenko Signed-off-by: Jens Wiklander --- drivers/tee/optee/call.c | 6 -- drivers/tee/optee/optee_msg.h | 6 -- 2 files changed, 8 insert

Re: [PATCH] io_uring: check ctx->sq_data before io_sq_offload_start

2021-04-19 Thread Jens Axboe
ring-submit > [2] https://lore.kernel.org/io-uring/a08121be-f481-e9f8-b28d-3eb5d4f > a5...@gmail.com/ This should be a backport of the 5.12 fix, not a separate patch. -- Jens Axboe

Re: [syzbot] KASAN: use-after-free Read in __cpuhp_state_remove_instance

2021-04-19 Thread Jens Axboe
On 4/19/21 8:41 AM, syzbot wrote: > syzbot suspects this issue was fixed by commit: > > commit 470ec4ed8c91b4db398ad607c700e9ce88365202 > Author: Jens Axboe > Date: Fri Feb 26 17:20:34 2021 + > > io-wq: fix double put of 'wq' in error

Re: linux-next: Tree for Apr 19 (bcache)

2021-04-19 Thread Jens Axboe
s on BLK_DEV", I understand > it is acceptable that LIBNVDIMM option to disappear from "make > menuconfig" if BLK_DEV is not enabled. > > For such condition, which one is the proper way to set the dependence ? > - Change "select LIBNVDIMM" and "select DAX" to "depends on LIBNVDIMM" > and "depends on DAX" in bcache Kconfig > - Or change "depends on BLK_DEV" to "select BLK_DEV" in nvdimm Kconfig. The former. -- Jens Axboe

Re: [PATCH v1 1/1] tee: optee: Provide special parameter field for UUID values

2021-04-19 Thread Jens Wiklander
On Mon, Apr 19, 2021 at 3:40 PM Andy Shevchenko wrote: > > On Mon, Apr 19, 2021 at 4:30 PM Jens Wiklander > wrote: > > On Mon, Apr 19, 2021 at 2:01 PM Andy Shevchenko > > wrote: > > > > > > On Mon, Apr 19, 2021 at 01:35:51PM +0200, Jens Wiklander wrote:

Re: [PATCH v1 1/1] tee: optee: Provide special parameter field for UUID values

2021-04-19 Thread Jens Wiklander
On Mon, Apr 19, 2021 at 2:01 PM Andy Shevchenko wrote: > > On Mon, Apr 19, 2021 at 01:35:51PM +0200, Jens Wiklander wrote: > > On Thu, Apr 15, 2021 at 4:58 PM Andy Shevchenko > > wrote: > > Thanks for review, my answer below. > > > >

Re: [PATCH v1 1/1] tee: optee: Provide special parameter field for UUID values

2021-04-19 Thread Jens Wiklander
e cast above, but I'm not that keen on the change in this struct. This file defines the ABI towards Secure world and adding dependencies on external complex types is a larger problem than the cast above in my opinion. Cheers, Jens

Re: [PATCH] blk-mq: Fix spurious debugfs directory creation during initialization

2021-04-16 Thread Jens Axboe
in the block device > initialization sequence. > > A simple check for debugfs_dir has been added to thwart premature > debugfs directory/file creation attempts. Applied, thanks. -- Jens Axboe

Re: [PATCH] floppy: remove redundant assignment to variable st

2021-04-16 Thread Jens Axboe
On 4/16/21 6:29 AM, Denis Efremov wrote: > Jens, could you please take this one? I thought to send it to you with other > cleanup patches in a merge request, but you already applied rest of the > patches. If you prefer to take it as merge request, it's ok I'll send it > ba

Re: [RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request

2021-04-16 Thread Jens Axboe
ush_plug_list and > has lots of indirect callers.) Applied, with the bfq bits hand edited to apply for 5.13. -- Jens Axboe

Re: [PATCH 1/2] blk-mq: bypass IO scheduler's limit_depth for passthrough request

2021-04-16 Thread Jens Axboe
3 0.38813 39952 D R 24 [dmraid] > 8,024 0.4435624 C R [0] > > This patch introduce a new wrapper to make code not that ugly. Applied, thanks. -- Jens Axboe

Re: [PATCH 0/5] Another small set of cleanups for floppy driver

2021-04-16 Thread Jens Axboe
On 4/16/21 2:34 AM, Denis Efremov wrote: > Just a couple of patches to make checkpatch.pl a bit more happy. > All these patches preserve original semantics of the code and only > memset(), memcpy() patches change binary code. Applied, thanks. -- Jens Axboe

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-14 Thread Jens Wiklander
Hi Jiro, On Mon, Apr 12, 2021 at 12:20 PM Rijo Thomas wrote: > > > > On 12/04/21 1:06 pm, Jens Wiklander wrote: > > On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas > > wrote: > >> > >> Same Trusted Application (TA) can be loaded in multiple TEE context

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-14 Thread Jens Axboe
On 4/13/21 5:14 PM, Dave Chinner wrote: > On Tue, Apr 13, 2021 at 10:13:24AM -0600, Jens Axboe wrote: >> On 4/13/21 1:51 AM, SeongJae Park wrote: >>> From: SeongJae Park >>> >>> Hello, >>> >>> >>> Very interesting work, thank you fo

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-13 Thread Jens Axboe
On 4/13/21 1:51 AM, SeongJae Park wrote: > From: SeongJae Park > > Hello, > > > Very interesting work, thank you for sharing this :) > > On Tue, 13 Apr 2021 00:56:17 -0600 Yu Zhao wrote: > >> What's new in v2 >> >> Special

Re: [PATCH V12 0/3] Charge loop device i/o to issuing cgroup

2021-04-12 Thread Jens Axboe
On 4/12/21 9:45 AM, Johannes Weiner wrote: > It looks like all feedback has been addressed and there hasn't been > any new activity on it in a while. > > As per the suggestion last time [1], Andrew, Jens, could this go > through the -mm tree to deal with the memcg conflicts

Re: mmotm 2021-04-11-20-47 uploaded (fs/io_uring.c)

2021-04-12 Thread Jens Axboe
- io_resubmit_prep(req)) - fail = false; -#endif - if (fail) { + if (!(res == -EAGAIN && io_rw_should_reissue(req) && + io_resubmit_prep(req))) { req_set_fail_links(req); req->flags |= REQ_F_DONT_REISSUE; } -- Jens Axboe

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-12 Thread Jens Wiklander
ee/amdtee_private.h | 13 > drivers/tee/amdtee/call.c | 94 ++--- > drivers/tee/amdtee/core.c | 15 +++-- > 3 files changed, 106 insertions(+), 16 deletions(-) Looks good to me. Please address Dan's comment. Cheers, Jens

Re: linux-next: Signed-off-by missing for commit in the block tree

2021-04-11 Thread Jens Axboe
On 4/11/21 8:26 PM, Sowjanya Komatineni wrote: > > On 4/11/21 7:14 PM, Jens Axboe wrote: >> On 4/11/21 4:34 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Commit >>> >>>6fa6517fe62e ("ata: ahci_tegra: call tegra_powergate_power_of

Re: linux-next: Signed-off-by missing for commit in the block tree

2021-04-11 Thread Jens Axboe
re OK with me adding your Signed-off-by to that patch. -- Jens Axboe

Re: [PATCH] gdrom: fix compilation error

2021-04-11 Thread Jens Axboe
undeclared >> (first use in this function) >> 586 | __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio), >> | ^~ > > How about adding a Fixes: tag? Indeed, that's definitely missing. I've added it and applied it. -- Jens Axboe

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Jens Axboe
position to > keep the code format. > > ./drivers/ata/pata_ixp4xx_cf.c:168:5-8: > WARNING: Unsigned expression compared with zero: irq > 0 Applied, thanks. -- Jens Axboe

Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

2021-04-09 Thread Jens Axboe
On 4/8/21 2:55 PM, Sowjanya Komatineni wrote: > This patch adds check to call legacy power domain API > tegra_powergate_power_off() only when PM domain is not present. Applied, and added a Fixes line. -- Jens Axboe

Re: [PATCH] block: Fix sys_ioprio_set(.which=IOPRIO_WHO_PGRP) task iteration

2021-04-08 Thread Jens Axboe
On 4/8/21 3:46 AM, Peter Zijlstra wrote: > > do_each_pid_thread() { } while_each_pid_thread() is a double loop and > thus break doesn't work as expected. Also, it should be used under > tasklist_lock because otherwise we can race against change_pid() for > PGID/SID. Applie

Re: [PATCH] io-wq: Fix io_wq_worker_affinity()

2021-04-08 Thread Jens Axboe
that it can be observed running outside > of its allowed mask for potentially significant time. > > Use the proper API instead. Applied, thanks Peter. -- Jens Axboe

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > ... > >>>> All errors (new o

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
e attached .config to linux build tree >> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefi

Re: [PATCH v4 0/3] Add AHCI support for Tegra186

2021-04-07 Thread Jens Axboe
On 4/6/21 7:25 PM, Sowjanya Komatineni wrote: > Re-sending dt-binding and ahci_tegra driver patches as v4 as device > tree patches from v3 are merged but not the AHCI Tegra driver. > > Missed to add Jens Axboe to mailing list in v3. Adding for v4. > > This series adds support

Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

2021-04-07 Thread Jens Axboe
On 4/7/21 7:47 AM, Andy Shevchenko wrote: > There is no need to have kernel.h included, I do not see any > direct users of it in ata.h. Drop unneeded inclusion of kernel.h. Applied, thanks. -- Jens Axboe

Re: [PATCH] task_work: add helper for more targeted task_work canceling

2021-04-07 Thread Jens Axboe
On 4/6/21 11:47 AM, Oleg Nesterov wrote: > On 04/04, Jens Axboe wrote: >> >> +struct callback_head *task_work_cancel_match(struct task_struct *task, >> +bool (*match)(struct callback_head *, void *data), void *data); > ^^^

Re: [syzbot] WARNING in mntput_no_expire (2)

2021-04-06 Thread Jens Axboe
e, you could handle those in path_init() (or delay grabbing rcu_read_lock() > in there, spreading it in a bunch of branches), but duplicated cleanup logics > for a bunch of failure exits is asking for trouble. Thanks for taking care of this Al, fwiw I'm (mostly) out on vacation. -- Jens Axboe

Re: [PATCH -next] drbd: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Jens Axboe
On 4/6/21 6:09 AM, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). Applied, thanks. -- Jens Axboe

Re: [PATCH 0/3] ata: Module parameter clean-ups for pata_legacy and pata_platform

2021-04-06 Thread Jens Axboe
PATA adapter at the usual primary I/O location. They have also been > verified (mainly for the correctness of MODULE_PARM_DESC use) with an > x86/PC build (for pata_legacy) and a MIPS/SWARM build (for pata_platform). Applied, thanks. -- Jens Axboe

Re: [PATCH v5 1/2] ata: ahci_brcm: Fix use of BCM7216 reset controller

2021-04-06 Thread Jens Axboe
ci_brcm: Support BCM7216 reset controller name") >> Signed-off-by: Jim Quinlan >> Acked-by: Florian Fainelli >> --- >> drivers/ata/ahci_brcm.c | 46 ++++- >> 1 file changed, 23 insertions(+), 23 deletions(-) > > Hi Jens, &g

Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()

2021-04-06 Thread Jens Axboe
On 3/5/21 2:10 AM, Piyush Mehta wrote: > Updated code with already prepared dev_err_probe(). It reduces code size > and simplifies EPROBE_DEFER handling. Applied, thanks. -- Jens Axboe

Re: [PATCH 00/11] Rid W=1 warnings from Block

2021-04-06 Thread Jens Axboe
On 3/12/21 3:55 AM, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Applied 2-11, 1 is already in the my tree. -- Jens Axboe

Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

2021-04-06 Thread Jens Wiklander
Hi Heiko, [+Arnd] On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery wrote: > > Hi Jens, > > Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander > : > > > > On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote: > > > If build kernel witho

[PATCH] task_work: add helper for more targeted task_work canceling

2021-04-04 Thread Jens Axboe
of purely the callback function used. task_work_cancel() can be trivially implemented on top of that, hence do so. Signed-off-by: Jens Axboe --- I've got a patch on top of this that uses task_work_cancel_match(), but sending this one out separately. There should be no functional chang

Re: [PATCH] block: don't ignore REQ_NOWAIT for direct IO

2021-04-02 Thread Jens Axboe
h the cracks, and I didn't notice until I went and directly tested some of this... iomap suffers from the same issue, fwiw. -- Jens Axboe

Re: [syzbot] WARNING in mntput_no_expire (2)

2021-04-01 Thread Jens Axboe
entry_SYSCALL_64_after_hwframe+0x44/0xae >> RIP: 0033:0x446af9 >> Code: Unable to access opcode bytes at RIP 0x446acf. >> RSP: 002b:005dfe48 EFLAGS: 0246 ORIG_RAX: 00e7 >> RAX: ffda RBX: 004ce450 RCX: 00446af9 >> RDX: 000

Re: [GIT PULL] OP-TEE tracepoints fix for v5.13

2021-04-01 Thread Jens Wiklander
On Thu, Apr 1, 2021 at 12:23 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > On Tue, 30 Mar 2021 10:22:08 +0200, Jens Wiklander wrote: > > The previous pull request for OP-TEE tracepoints introduced a build > > error when building whithout O=..., apparently many re

Re: [PATCH 1/1] tee: optee: do not check memref size on return from Secure World

2021-04-01 Thread Jens Wiklander
k in optee_from_msg_param() is incorrect and > > needs to be removed. This fixes a number of failed test cases in the > > GlobalPlatform TEE Initial Configuratiom Test Suite v2_0_0_0-2017_06_09 > > when OP-TEE is compiled without dynamic shared memory support > > (CFG

Re: [block] 4c95131e3c: kernel_BUG_at_block/bio.c

2021-03-31 Thread Jens Axboe
.c:713) > [ 47.862381] do_syscall_64 (kbuild/src/consumer/arch/x86/entry/common.c:46) > [ 47.862443] entry_SYSCALL_64_after_hwframe > (kbuild/src/consumer/arch/x86/entry/entry_64.S:112) > [ 47.862526] RIP: 0033:0x7f5c66692a37 > [ 47.862586] Code: ff ff eb b6 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 > 48 8d 05 c9 7c 0d 00 49 89 ca 8b 00 85 c0 75 10 b8 12 00 00 00 0f 05 <48> 3d > 00 f0 ff ff 77 59 c3 41 55 49 89 cd 41 54 49 89 d4 55 48 89 Thanks for the report, I've fixed this up in the current branch and pushed a new one out. -- Jens Axboe

Re: [PATCH v1] ata: ahci: Disable SXS for Hisilicon Kunpeng920

2021-03-31 Thread Jens Axboe
On 3/15/21 5:29 AM, luojiaxing wrote: > > On 2021/3/12 22:27, Jens Axboe wrote: >> Is this controller arm exclusive? > > > Yes, our SoC is base on ARM64 only. Applied, thanks. -- Jens Axboe

Re: Build breakage in next-20210330 due to optee_trace.h

2021-03-30 Thread Jens Wiklander
ce.h" > ^ > 1 error generated. > > The config is attached. I am building using clang. > > $ clang --version > clang version 11.1.0 > Target: x86_64-pc-linux-gnu > Thread model: posix > InstalledDir: /usr/bin Thanks for reporting, this should hopefully be taken care of by https://lkml.org/lkml/2021/3/25/2 Cheers, Jens

Re: [PATCH] sata_mv: add IRQ checks

2021-03-30 Thread Jens Axboe
error codes, > and override the IRQ0 with -EINVAL (as we don't want the polling mode). Applied, thanks. -- Jens Axboe

Re: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

2021-03-30 Thread Jens Axboe
On 3/18/21 2:51 AM, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is set 2 out of 2 sets required. Applied, thanks. -- Jens Axboe

[GIT PULL] OP-TEE memref size check for v5.13

2021-03-30 Thread Jens Wiklander
hanks, Jens The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.linaro.org/people/jens.wiklander/linux-tee.git/ tags/optee-memref-size-for-v5.13 for you to fetch changes

Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

2021-03-30 Thread Jens Wiklander
> Tested with and without "O=dir", both can build successfully. > > Reported-by: Guenter Roeck > Suggested-by: Steven Rostedt > Signed-off-by: Jisheng Zhang I've picked up this. Thanks, Jens

[GIT PULL] OP-TEE tracepoints fix for v5.13

2021-03-30 Thread Jens Wiklander
Hello arm-soc maintainers, The previous pull request for OP-TEE tracepoints introduced a build error when building whithout O=..., apparently many regression builds uses that option. Please pull this small fix for the build error. Thanks, Jens The following changes since commit

Re: [syzbot] KASAN: use-after-free Read in create_worker_cb

2021-03-29 Thread Jens Axboe
b fb fb fb fb fb fb fb fb >> 88801bf15080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ^ > 88801bf15100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > 88801bf15180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > == #syz test: git://git.kernel.dk/linux-block for-5.13/io_uring -- Jens Axboe

Re: [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock

2021-03-29 Thread Jens Axboe
On 3/29/21 3:53 AM, Shixin Liu wrote: > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). Applied both, thanks. -- Jens Axboe

Re: [syzbot] WARNING: still has locks held in io_sq_thread

2021-03-29 Thread Jens Axboe
xt4/ext4.h:3383 [inline] > __ext4_new_inode+0x384f/0x5570 fs/ext4/ialloc.c:1188 > ext4_symlink+0x489/0xd50 fs/ext4/namei.c:3347 > vfs_symlink fs/namei.c:4176 [inline] > vfs_symlink+0x10f/0x270 fs/namei.c:4161 > do_symlinkat+0x27a/0x300 fs/namei.c:4206 > do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xae Same one that keeps happening, it's not related. -- Jens Axboe

Re: [syzbot] WARNING: still has locks held in io_sq_thread

2021-03-29 Thread Jens Axboe
/x/repro.c?x=150764bed0 #syz test: git://git.kernel.dk/linux-block io_uring-5.12 -- Jens Axboe

Re: [PATCH 2/7] io_uring: handle signals for IO threads like a normal thread

2021-03-27 Thread Jens Axboe
On 3/27/21 11:40 AM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 3/26/21 4:38 PM, Jens Axboe wrote: >>> OK good point, and follows the same logic even if it won't make a >>> difference in my case. I'll make the change. >> >> Made the

Re: [PATCH 0/6] Allow signals for IO threads

2021-03-27 Thread Jens Axboe
On 3/26/21 7:46 PM, Stefan Metzmacher wrote: > > Hi Jens, > >> root@ub1704-166:~# LANG=C gdb --pid 1320 >> GNU gdb (Ubuntu 9.2-0ubuntu1~20.04) 9.2 >> Copyright (C) 2020 Free Software Foundation, Inc. >> License GPLv3+: GNU GPL version 3 or later <http://gnu.or

Re: [PATCH] livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure

2021-03-26 Thread Jens Axboe
quot;) added a generic infrastructure to achieve the same. > Replace our bespoke solution with the generic one. > > Signed-off-by: Miroslav Benes Looks good to me. Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH] io_uring: remove unsued assignment to pointer io

2021-03-26 Thread Jens Axboe
On 3/26/21 1:52 PM, Colin King wrote: > From: Colin Ian King > > There is an assignment to io that is never read after the assignment, > the assignment is redundant and can be removed. Thanks, applied. -- Jens Axboe

Re: [PATCH 2/7] io_uring: handle signals for IO threads like a normal thread

2021-03-26 Thread Jens Axboe
On 3/26/21 4:38 PM, Jens Axboe wrote: > On 3/26/21 4:35 PM, Eric W. Biederman wrote: >> Jens Axboe writes: >> >>> On 3/26/21 4:23 PM, Eric W. Biederman wrote: >>>> Jens Axboe writes: >>>> >>>>> On 3/26/21 2:29 PM, Eric W. Biederman

Re: [PATCH 2/7] io_uring: handle signals for IO threads like a normal thread

2021-03-26 Thread Jens Axboe
On 3/26/21 4:35 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 3/26/21 4:23 PM, Eric W. Biederman wrote: >>> Jens Axboe writes: >>> >>>> On 3/26/21 2:29 PM, Eric W. Biederman wrote: >>>>> Jens Axboe writes: >>>&g

Re: [PATCH 1/1] scripts/spelling.txt: add entries for recent discoveries

2021-03-26 Thread Jens Axboe
this one was actually re-added, which does make sense. So don't think that one should be added to the list. -- Jens Axboe

Re: [PATCH 2/7] io_uring: handle signals for IO threads like a normal thread

2021-03-26 Thread Jens Axboe
On 3/26/21 4:23 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 3/26/21 2:29 PM, Eric W. Biederman wrote: >>> Jens Axboe writes: >>> >>>> We go through various hoops to disallow signals for the IO threads, but >>>> there's rea

Re: [PATCH 2/7] io_uring: handle signals for IO threads like a normal thread

2021-03-26 Thread Jens Axboe
On 3/26/21 2:29 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> We go through various hoops to disallow signals for the IO threads, but >> there's really no reason why we cannot just allow them. The IO threads >> never return to userspace like a normal threa

Re: [PATCH 1/7] kernel: don't call do_exit() for PF_IO_WORKER threads

2021-03-26 Thread Jens Axboe
On 3/26/21 2:43 PM, Eric W. Biederman wrote: > Jens Axboe writes: > >> Right now we're never calling get_signal() from PF_IO_WORKER threads, but >> in preparation for doing so, don't handle a fatal signal for them. The >> workers have state they need to clean

Re: [PATCH 2/8] kernel: unmask SIGSTOP for IO threads

2021-03-26 Thread Jens Axboe
On 3/26/21 12:01 PM, Stefan Metzmacher wrote: > Am 26.03.21 um 16:29 schrieb Jens Axboe: >> On 3/26/21 9:23 AM, Stefan Metzmacher wrote: >>> Am 26.03.21 um 16:01 schrieb Jens Axboe: >>>> On 3/26/21 7:48 AM, Oleg Nesterov wrote: >>>>> Jens, sorry, I

  1   2   3   4   5   6   7   8   9   10   >