On 2020-06-30 11:10, Lee Jones wrote:
On Tue, 30 Jun 2020, haver wrote:
On 2020-06-29 16:04, Lee Jones wrote:
> 'fatal_err' is taken as an argument to a static function which is only
> invoked once. During this invocation 'fatal_err' is not set. There
> doesn&#x
On 2020-06-30 09:42, Lee Jones wrote:
On Tue, 30 Jun 2020, haver wrote:
On 2020-06-29 16:04, Lee Jones wrote:
> Variable 'rc' hasn't been checked since the driver's inception
> in 2013. If it hasn't caused any issues since then, it's unlikely
> to in
On 2020-06-29 16:04, Lee Jones wrote:
'fatal_err' is taken as an argument to a static function which is only
invoked once. During this invocation 'fatal_err' is not set. There
doesn't appear to be a good reason to keep it around.
Also fixes the following W=1 kernel build warning:
drivers/mis
On 2020-06-29 16:04, Lee Jones wrote:
Including; demoting file header from kerneldoc to standard comment/
header, adding a variety of missing function argument documentation,
repairing formatting (kerneldoc does not like blank lines) and the
demotion of a kerneldoc header which shows no interest
On 2020-06-29 16:04, Lee Jones wrote:
Including; add missing documentation for function arguments,
re-ordering
of #defines i.e. not placed between kerneldoc headers and the functions
they are documenting, demotion of file header/comment from kerneldoc
format and removal of documentation for non-
On 2020-06-29 16:04, Lee Jones wrote:
From missing documentation for function arguments, to promotion
obvious kerneldoc headers and incorrectly named arguments.
Fixes the following W=1 warnings:
drivers/misc/genwqe/card_base.c:175: warning: Function parameter or
member 'cd' not described in 'g
On 2020-06-29 16:04, Lee Jones wrote:
Variable 'rc' hasn't been checked since the driver's inception
in 2013. If it hasn't caused any issues since then, it's unlikely
to in the future. Let's take it out for now.
Fixes the following W=1 kernel build warning(s):
drivers/misc/genwqe/card_base.c
On 2020-06-11 00:47, Rikard Falkeborn wrote:
genwqe_err_handler is never modified, so it can be made const to allow
the compiler to put it in read-only memory.
Before:
textdata bss dec hex filename
2017461042464 287427046 drivers/misc/genwqe/card_base.o
After:
Hi Christian,
On 2018-12-12 14:45, Christian Borntraeger wrote:
Calling the test program genwqe_cksum with the default buffer size of
2MB triggers the following kernel warning on s390:
WARNING: CPU: 30 PID: 9311 at mm/page_alloc.c:3189
__alloc_pages_nodemask+0x45c/0xbe0
CPU: 30 PID: 9311 Comm:
On 2018-09-20 07:04, zhong jiang wrote:
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c
b/drivers/misc/gen
On 2018-09-20 07:07, zhong jiang wrote:
module.h has duplicated include. hence just remove
redundant include file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card
On 2018-09-20 04:29, zhong jiang wrote:
The function should return -EFAULT when copy_from_user fails. Even
though the caller does not distinguish them. but we should keep
backward
compatibility.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 13 +++--
1 file change
On 2018-01-08 14:24, SF Markus Elfring wrote:
@@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd,
struct
dma_mapping *m, void *uaddr,
sizeof(struct page *) +
sizeof(dma_addr_t),
GFP_KERNEL);
if (!m->page_list) {
- dev_err(&pci_dev
Hi Dan,
On 2018-01-08 14:23, Dan Carpenter wrote:
On Mon, Jan 08, 2018 at 01:45:02PM +0100, haver wrote:
Hi Markus,
On 2018-01-08 10:41, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 8 Jan 2018 09:37:23 +0100
>
> Omit an extra message for a memory allocation fai
Hi Pravin,
On 2017-12-06 17:54, Pravin Shedge wrote:
These duplicate includes have been found with scripts/checkincludes.pl
but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card
Hi Guilherme,
On 2017-12-14 15:34, Guilherme G. Piccoli wrote:
This patchset is composed by 3 small clean-ups to genwqe
driver. It aims to improve code clarity, by removing unused
stuff and make the code follow some conventions.
It was built and tested against v4.15-rc3, and aims merge
in v4.16
Hi Markus,
On 2018-01-08 10:43, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 8 Jan 2018 10:21:25 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the
following.
Comparison to N
Hi Markus,
On 2018-01-08 10:42, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 8 Jan 2018 09:57:10 +0100
Add a missing character in two words of these descriptions.
Signed-off-by: Markus Elfring
---
drivers/misc/genwqe/card_utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
Hi Markus,
On 2018-01-08 10:41, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 8 Jan 2018 09:37:23 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/mis
On 2017-08-12 07:44, Julia Lawall wrote:
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const.
Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Juli
Hi Gabriel and Guilherme,
On 2017-05-18 22:03, Gabriel Krisman Bertazi wrote:
"Guilherme G. Piccoli" writes:
Gabriel won't maintain this driver anymore. So, I'll maintain it
with Frank.
Thanks Gabriel for all your work on genwqe.
Let me join Guilherme in thanking you for all the contributi
22 matches
Mail list logo
