Hi Lee,
Thanks for your review!
There is one things need your confirm.
Please help to see it below.
On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add pmic mfd driver to support hisilicon hi665x.
[..]
>
>> +static const struct mfd_cell hi655x_pmic_devs[] = {
Hi,
On 2016/1/20 6:40, David Rientjes wrote:
> On Tue, 19 Jan 2016, Chen Feng wrote:
>
>> When a process fork a child process, we should not allow the
>> child process use the binder which opened by parent process.
>>
>> But if the binder-object creater is a thread of one process who exit,
>> the
On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add pmic mfd driver to support hisilicon hi665x.
>
> PMIC MFD
>
ok.
>> Signed-off-by: Chen Feng
>> Signed-off-by: Fei Wang
>> Signed-off-by: Xinwei Kong
>> ---
>> drivers/mfd/Kconfig | 10 +++
>
On 2016/1/25 20:53, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add document for mfd driver hi655x pmic driver
>>
>> Signed-off-by: Chen Feng
>> Signed-off-by: Fei Wang
>> Signed-off-by: Xinwei Kong
>> ---
>> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 28
>> +
Mark,
On 2016/1/20 21:08, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:32:04PM +0800, Chen Feng wrote:
>
>> index 82d2488..6de9881 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>
>> +regulators {
>> +
On 2016/1/20 19:46, Mark Brown wrote:
> On Wed, Jan 20, 2016 at 11:51:27AM +0800, chenfeng wrote:
>
>> I will change it like this:
>> bindings: regulator: hi655x: Document for hi655x regulator driver
>
> As we discussed previously I'd expected something more like
On 2016/1/5 23:47, Mark Brown wrote:
> On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote:
>> Add Document for hi655x pmic regulator driver
>
> As indicated in the driver review this seems to be a bit of an unusual
> binding that I think needs reworking, also it needs a bit more detail -
On 2016/1/5 23:44, Mark Brown wrote:
> On Mon, Jan 04, 2016 at 08:27:51PM +0800, Chen Feng wrote:
>
>> +/*LDO 2 & LDO 14*/
>
> Please use the normal kernel coding style for comments, I'm surprised
> checkpatch didn't warn you about this.
>
ok,thanks!
>> +static const unsigned int ldo2_voltages
On 2015/12/23 8:46, Mark Brown wrote:
> On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to
On 2015/12/21 11:01, chenfeng wrote:
> Mark,
>
> On 2015/12/19 1:58, Mark Brown wrote:
>> On Thu, Dec 17, 2015 at 11:27:27AM +0800, chenfeng wrote:
>>
>>> +- regulator-vset-regs: Voltage set register offset.
>>> +- regulator-vset-mask: voltage set con
Mark,
On 2015/12/19 1:58, Mark Brown wrote:
> On Thu, Dec 17, 2015 at 11:27:27AM +0800, chenfeng wrote:
>
>> +- regulator-vset-regs: Voltage set register offset.
>> +- regulator-vset-mask: voltage set control mask.
>> +- regulator-n-vol: The num of support voltage
Mark,
+- regulator-vset-regs: Voltage set register offset.
+- regulator-vset-mask: voltage set control mask.
+- regulator-n-vol: The num of support voltages.
+- regulator-vset-table: The table of support voltages.
> Why is this in the binding? This is a binding for a specific device,
> there
Mark,
Thanks very much for your review.
On 2015/12/17 3:16, Mark Brown wrote:
> On Tue, Dec 15, 2015 at 08:54:15PM +0800, Chen Feng wrote:
>
>> +config REGULATOR_HI655X
>> +tristate "Hisilicon HI655X PMIC regulators support"
>> +depends on ARCH_HISI
>> +depends on MFD_HI655X_PMIC && O
On 2015/11/27 20:02, Joerg Roedel wrote:
> On Fri, Nov 20, 2015 at 10:25:08AM +0800, Chen Feng wrote:
>> +config HI6220_IOMMU
>> +bool "Hi6220 IOMMU Support"
>> +depends on ARM64
>> +select IOMMU_API
>> +select IOMMU_IOVA
>> +help
>> + Enable IOMMU Driver for hi6220 SoC.
On 2015/11/27 19:49, Joerg Roedel wrote:
> On Fri, Nov 20, 2015 at 10:25:06AM +0800, Chen Feng wrote:
>> eg:
>> struct iommu_domain *domain = iommu_domain_alloc(bus);
>> iommu_attach_device(domain, dev);
>> struct iova_domain *iovad = (struct iova_domain *)m_dev->archdata.iommu;
>> struct iova *
Zabel,
On 2015/11/19 1:27, Philipp Zabel wrote:
> Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng:
>> Add reset driver for hi6220-hikey board,this driver supply deassert
>> of IP on hi6220 SoC.
>>
>> Signed-off-by: Chen Feng
> [...]
>> diff --git a/drivers/reset/hisilicon/Kconfig
>> b/
On 2015/11/19 1:27, Philipp Zabel wrote:
> Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng:
>> Add DT bindings documentation for hi6220 SoC reset controller.
>>
>> Signed-off-by: Chen Feng
>> ---
>> .../bindings/reset/hisilicon,hi6220-reset.txt | 34 +++
>> include/dt-bin
Hi,
On 2015/10/30 0:14, Philipp Zabel wrote:
> Am Donnerstag, den 29.10.2015, 20:55 +0800 schrieb Chen Feng:
>> reset: add driver for hi6220 reset controller
>
> Same comment as for patch 1, this should probably be the subject,
> the commit message body was better in V4.
>
>> Signed-off-by: Chen
Thanks.
On 2015/10/28 19:42, Philipp Zabel wrote:
> Am Dienstag, den 27.10.2015, 17:51 +0800 schrieb Chen Feng:
>> reset: add driver for hi6220 reset controller
>>
>> Signed-off-by: Chen Feng
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>
Hi Robin,
On 2015/10/20 23:02, Robin Murphy wrote:
> On 20/10/15 09:45, Chen Feng wrote:
>> iommu/hisilicon: Add hi6220-SoC smmu driver
>
>> +
>> +static int hi6220_smmu_attach_dev(struct iommu_domain *domain,
>> + struct device *dev)
>> +{
>> +dev->archdata.iommu = &iova_al
On 2015/10/20 23:02, Robin Murphy wrote:
> On 20/10/15 09:45, Chen Feng wrote:
>> iommu/hisilicon: Add hi6220-SoC smmu driver
>
> A brief description of the smmu and what capabilities it provides wouldn't go
> amiss here.
>
ok
>> Signed-off-by: Chen Feng
>> Signed-off-by: Yu Dongbin
>> ---
>
Mark, thanks very much.
On 2015/10/20 18:34, Mark Rutland wrote:
> On Tue, Oct 20, 2015 at 04:45:22PM +0800, Chen Feng wrote:
>> docs: iommu: Documentation for smmu in hi6220 SoC.
>>
>> Signed-off-by: Chen Feng
>> Signed-off-by: Yu Dongbin
>> ---
>> .../bindings/iommu/hisi,hi6220-iommu.txt
Thanks for review.
On 2015/10/20 17:00, Arnd Bergmann wrote:
> On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
>> +
>> + smmu@f421 {
>
> I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
Accept.
>
>> + compatible = "hisilicon,hi62
On 2015/10/14 20:18, Joerg Roedel wrote:
> On Thu, Oct 08, 2015 at 03:45:47PM +0800, Chen Feng wrote:
>> +static int hi6220_smmu_attach_dev(struct iommu_domain *domain,
>> + struct device *dev)
>> +{
>> +struct hi6220_domain *m_domain = to_hi6220_domain(domain);
>
On 2015/10/10 23:00, Dan Carpenter wrote:
> On Sat, Oct 10, 2015 at 02:48:22PM +0800, Chen Feng wrote:
>> +static int hi6220_ion_probe(struct platform_device *pdev)
>> +{
>> +int i;
>> +int err = 0;
>> +static struct ion_platform_heap *p_heap;
>> +
>> +idev = ion_device_create(NUL
On 2015/10/9 16:58, Dan Carpenter wrote:
> On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote:
>>> +out:
>>
>> Labels named "out" are bug prone because handling everything is harder
>> than using named labels and unwinding one step at a time. The bug here
>> is that we don't call ion_
Hi all,
In IOMMU architecture , how to make two different peripherals share the same
page table ?
In other words , is there a mechanism or structure to make two peripherals get
completely different address.
eg:
peri-A、peri-B and peri-C share the same iova address 0-1G for some performance
re
Hi all,
The sparse memory section size, SECTION_SIZE_BITS, currently is 1GB for arm64
by default. However, it might generate wasted memmap memory space for those
memory sections less than 1GB. e.g.
for 512MB memory section, still 14MB(sizeof(struct page) * PAGES_PER_SECTION)
memmap needs to be r
Philipp,
On 2015/9/18 23:23, Philipp Zabel wrote:
> Am Donnerstag, den 17.09.2015, 20:00 +0800 schrieb Chen Feng:
>> Add reset controller for hi6220 hikey-board.
>>
>> Signed-off-by: Chen Feng
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++
>> 1 file changed, 7 insertions(+)
>>
On 2015/9/11 16:41, Arnd Bergmann wrote:
> On Friday 11 September 2015 16:18:38 Chen Feng wrote:
>> +static int __init hi6220_reset_init(void)
>> +{
>> +int ret;
>> +struct device_node *np;
>> +struct hi6220_reset_data *data;
>> +
>> +data = kzalloc(sizeof(*data), GFP_KERNEL);
>>
On 2015/9/12 14:06, xuyiping wrote:
>
>
> On 2015/9/11 16:18, Chen Feng wrote:
>> Add reset driver for hi6220-hikey board,this driver supply deassert
>> of IP. on hi6220 SoC.
>>
>> Signed-off-by: Chen Feng
>> ---
>> drivers/reset/Kconfig | 1 +
>> drivers/reset/Makefile
Zabel,
Thanks for review.
On 2015/9/10 17:40, Philipp Zabel wrote:
> Am Donnerstag, den 10.09.2015, 14:11 +0800 schrieb Chen Feng:
>> Add reset driver for hi6220-hikey board,this driver supply deassert
>> of IP. on hi6220 SoC.
>>
>> Signed-off-by: Chen Feng
>> ---
>> drivers/reset/Kconfig
There is an alignment issue with ldmia in A32 user-space with A64
Kernel. Since the famous taobao apk use this instruction, so we want to
emulate this to make it work well.
I make a simple test case to reproduce this issue.
---
33 matches
Mail list logo
