RE: [PATCH] sched: don't output cpu sched info by default

2016-04-25 Thread Zhang, Yanmin
- From: Zhang, Yanmin Sent: Tuesday, April 26, 2016 9:04 AM To: Afzal Mohammed; Zhang, LongX Cc: mi...@redhat.com; pet...@infradead.org; linux-kernel@vger.kernel.org Subject: RE: [PATCH] sched: don't output cpu sched info by default Thanks for the pointer. We didn't notice that. That

RE: [PATCH] sched: don't output cpu sched info by default

2016-04-25 Thread Zhang, Yanmin
ernel@vger.kernel.org; Zhang, Yanmin Subject: Re: [PATCH] sched: don't output cpu sched info by default Hi, On Mon, Apr 25, 2016 at 01:04:41PM +0800, Zhang Long wrote: > Android userspace debug prcoess might dump system info by sysrq. > One info is of cpu sched. Usually, one thread has one l

Re: [PATCH] trace: correct start_index in find_next

2016-01-06 Thread Zhang, Yanmin
On 2016/1/7 11:50, Steven Rostedt wrote: > On Thu, 07 Jan 2016 10:56:56 +0800 > "Zhang, Yanmin" wrote: > >> How is this patch? It fixes a kernel panic. >> > Linus already pulled it. It's also marked for stable. See commit: > f36d1be2930ede0a1947686e1126f

Re: [PATCH] trace: correct start_index in find_next

2016-01-06 Thread Zhang, Yanmin
On 2015/12/31 13:11, Qiu, PeiyangX wrote: > From: Qiu Peiyang > > When we do cat /sys/kernel/debug/tracing/printk_formats, we hit kernel > panic at t_show. > > general protection fault: [#1] PREEMPT SMP > CPU: 0 PID: 2957 Comm: sh Tainted: G W O 3.14.55-x86_64-01062-gd4acdc7 #2 > RIP: 0010:

Re: [PATCH 2/2] module: deal with the failure of complete_formation

2016-01-05 Thread Zhang, Yanmin
On 2016/1/6 9:29, Steven Rostedt wrote: > On Wed, 06 Jan 2016 09:14:42 +0800 > "Zhang, Yanmin" wrote: > > >> It's a good idea although ftrace_module_init_fail might be complicated. > How so? I posted the patch. All it does is to call > ftrace_release_mod()

Re: [PATCH 2/2] module: deal with the failure of complete_formation

2016-01-05 Thread Zhang, Yanmin
The patch fixes it by tuning the operation sequence in >> complete_formation. After complete_formation checks >> verify_export_symbols, call ftrace_module_init to init >> ftrace records. >> >> Signed-off-by: Qiu Peiyang >> Signed-off-by: Zhang Yanmin >> --- >> kern

Re: [PATCH] ftrace: fix race between ftrace and insmod

2015-12-16 Thread Zhang, Yanmin
On 2015/12/16 22:28, Steven Rostedt wrote: > On Wed, 16 Dec 2015 18:28:35 +0800 > "Zhang, Yanmin" wrote: > >>> + /* >>> +* If the tracing is enabled, go ahead and enable the record. >>> +* >>> +* The reason not to enable the

Re: [PATCH] ftrace: fix race between ftrace and insmod

2015-12-16 Thread Zhang, Yanmin
On 2015/12/16 1:37, Steven Rostedt wrote: > On Tue, 15 Dec 2015 11:26:41 +0800 > "Zhang, Yanmin" wrote: > >>> This seems very hackish, although I can't think of a better way at the >>> moment. But I would like not to add more code into module.c if &g

Re: [PATCH] ftrace: fix race between ftrace and insmod

2015-12-15 Thread Zhang, Yanmin
On 2015/12/16 1:37, Steven Rostedt wrote: > On Tue, 15 Dec 2015 11:26:41 +0800 > "Zhang, Yanmin" wrote: > >>> This seems very hackish, although I can't think of a better way at the >>> moment. But I would like not to add more code into module.c if &g

Re: [PATCH] ftrace: fix race between ftrace and insmod

2015-12-14 Thread Zhang, Yanmin
On 2015/12/15 9:05, Zhang, Yanmin wrote: > On 2015/12/14 23:51, Steven Rostedt wrote: >> On Mon, 14 Dec 2015 11:16:18 +0800 >> "Qiu, PeiyangX" wrote: >> >>> We hit ftrace_bug report when booting Android on a 64bit ATOM SOC chip. >>&

Re: [PATCH] ftrace: fix race between ftrace and insmod

2015-12-14 Thread Zhang, Yanmin
an't fully resolve the issue. >> >> THis patch holds ftrace_mutex across ftrace_module_init and >> complete_formation. >> >> Signed-off-by: Qiu Peiyang >> Signed-off-by: Zhang Yanmin > First, this patch has major whitespace damage. All tabs are now spaces!

Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online

2015-07-02 Thread Zhang, Yanmin
On 2015/7/2 15:02, Xiao, Jin wrote: > Hi Joerg, > > On 7/2/2015 2:52 PM, Joerg Roedel wrote: >> Hi Jin, >> >> On Thu, Jul 02, 2015 at 12:24:34PM +0800, xiao jin wrote: >>> [ 106.107851] BUG: unable to handle kernel NULL pointer dereference at >>> 0040 >>> [ 106.116702] IP: >>> [ 106

Re: [PATCH] slub/slab: fix kmemleak didn't work on some case

2015-06-10 Thread Zhang, Yanmin
On 2015/6/9 23:03, Catalin Marinas wrote: > On Tue, Jun 09, 2015 at 09:10:45AM +0100, Zhang, Yanmin wrote: >> On 2015/6/8 18:13, Catalin Marinas wrote: >>> As I replied already, I don't think this is that bad, or at least not >>> worse than what kmemleak already d

Re: [PATCH] slub/slab: fix kmemleak didn't work on some case

2015-06-09 Thread Zhang, Yanmin
On 2015/6/8 18:13, Catalin Marinas wrote: > On Mon, Jun 08, 2015 at 10:38:13AM +0100, Christoph Lameter wrote: >> On Mon, 8 Jun 2015, Liu, XinwuX wrote: >> >>> when kernel uses kmalloc to allocate memory, slub/slab will find >>> a suitable kmem_cache. Ususally the cache's object size is often >>> g

Re: [PATCH V3 0/3] cdc-acm: fix incorrect runtime wakeup in acm_tty_write

2015-05-26 Thread Zhang, Yanmin
On 2015/5/27 12:13, Zhang, Yanmin wrote: > Resend as V1/V2 have email format issue. Sorry for bothering. Greg, We have to abandon this patchset. Zhuang Jin Can, a USB expert, reviewed the patches. He says acm_tty_write already considers it carefully. acm_tty_write puts the urb to a dela

[PATCH V3 1/3] usb: add function usb_autopm_get_interface_upgrade

2015-05-26 Thread Zhang, Yanmin
From: Zhang Yanmin Some usb driver has a specific requirement. Their critical functions might be called under both atomic environment and non-atomic environment. If it's under atomic environment, the driver can wake up the device by calling pm_runtime_get_sync directly. If it's

[PATCH V3 3/3] n_gsm: wake up ldisc tty before using it

2015-05-26 Thread Zhang, Yanmin
From: Zhang Yanmin Wake up ldisc device before calling its driver to access the device. Signed-off-by: Zhang Yanmin --- drivers/tty/n_gsm.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c

[PATCH V3 2/3] cdc-acm: call usb_autopm_get_interface_upgrade in acm_tty_write

2015-05-26 Thread Zhang, Yanmin
From: Zhang Yanmin acm device might be used as ldisc device by n_gsm driver. gsmtty_write and other gsm functions calls acm_tty_write indirectly while they holds spinlocks. Meanwhile, application might access ACM tty device directly. Here we choose to call usb_autopm_get_interface_upgrade

[PATCH V3 0/3] cdc-acm: fix incorrect runtime wakeup in acm_tty_write

2015-05-26 Thread Zhang, Yanmin
Resend as V1/V2 have email format issue. Sorry for bothering. I use Thunderbird. It has no a button to enable LKML email simply. :) V3: Change email config to resend. Add a space in comment. --- There is a scenario about cdc-acm utilization.Application opens n_gsm tty and cdc-acm tty.

Re: [PATCH V2 3/3] n_gsm: wake up ldisc tty before using it

2015-05-26 Thread Zhang, Yanmin
On 2015/5/27 11:02, Greg KH wrote: > On Wed, May 27, 2015 at 10:50:01AM +0800, Zhang, Yanmin wrote: >> Wake up ldisc device before calling its driver to access the device. >> >> Signed-off-by: Zhang Yanmin >> >> --- >> >> drivers/tty/n_gsm.c | 40 +

[PATCH V2 3/3] n_gsm: wake up ldisc tty before using it

2015-05-26 Thread Zhang, Yanmin
Wake up ldisc device before calling its driver to access the device. Signed-off-by: Zhang Yanmin --- drivers/tty/n_gsm.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 2c34c32

[PATCH V2 2/3] cdc-acm: call usb_autopm_get_interface_upgrade in acm_tty_write

2015-05-26 Thread Zhang, Yanmin
usb_autopm_get_interface_async to make sure above 2 scenarios can work well. Signed-off-by: Zhang Yanmin --- drivers/usb/class/cdc-acm.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 5c8f581..6ad85a3 100644

[PATCH V2 1/3] usb: add function usb_autopm_get_interface_upgrade

2015-05-26 Thread Zhang, Yanmin
nment, the function's caller need wake up the device before the function accesses the device. The patch adds usb_autopm_get_interface_upgrade, a new function to support above capability. Signed-off-by: Zhang Yanmin --- drivers/usb/core/driver.c | 54 +

[PATCH V2 0/3] cdc-acm: fix incorrect runtime wakeup in acm_tty_write

2015-05-26 Thread Zhang, Yanmin
Resend as V1 has email format issue. Sorry for bothering. --- There is a scenario about cdc-acm utilization.Application opens n_gsm tty and cdc-acm tty. cdc-acm tty connects to xhci device. The application configures cdc-adm tty to n_gsm tty as ldisc tty. n_gsm=>cdc-acm=>xhci driver acm_tty

Re: [PATCH 1/3] usb: add function usb_autopm_get_interface_upgrade

2015-05-26 Thread Zhang, Yanmin
On 2015/5/26 22:12, Greg Kroah-Hartman wrote: On Tue, May 26, 2015 at 10:19:57AM +0800, Zhang, Yanmin wrote: Some usb driver has a specific requirement. Their critical functions might be called under both atomic environment and non-atomic environment. If it's under atomic environment

[PATCH 3/3] n_gsm: wake up ldisc tty before using it

2015-05-25 Thread Zhang, Yanmin
Wake up ldisc device before calling its driver to access the device. Signed-off-by: Zhang Yanmin --- drivers/tty/n_gsm.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 2c34c32

[PATCH 2/3] cdc-acm: call usb_autopm_get_interface_upgrade in, acm_tty_write

2015-05-25 Thread Zhang, Yanmin
usb_autopm_get_interface_async to make sure above 2 scenarios can work well. Signed-off-by: Zhang Yanmin --- --- drivers/usb/class/cdc-acm.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 5c8f581..6ad85a3

[PATCH 1/3] usb: add function usb_autopm_get_interface_upgrade

2015-05-25 Thread Zhang, Yanmin
nment, the function's caller need wake up the device before the function accesses the device. The patch adds usb_autopm_get_interface_upgrade, a new function to support above capability. Signed-off-by: Zhang Yanmin --- drivers/usb/cor

[PATCH 0/3] cdc-acm: fix incorrect runtime wakeup in acm_tty_write

2015-05-25 Thread Zhang, Yanmin
There is a scenario about cdc-acm utilization.Application opens n_gsm tty and cdc-acm tty. cdc-acm tty connects to xhci device. The application configures cdc-adm tty to n_gsm tty as ldisc tty. n_gsm=>cdc-acm=>xhci driver acm_tty_write can be called from n_gsm driver by ldisc connection,

Re: [PATCH] debugfs: keep the old valid mode value when no explicity specify it

2014-08-28 Thread Zhang, Yanmin
On 2014/8/28 23:10, Greg KH wrote: On Thu, Aug 28, 2014 at 06:09:09PM +0800, Chen LinX wrote: From: "Chen, LinX" When mount debugfs with no mode specifed after it's mounted, the mount point mode will change to default mode(0700) even the mount operation was fail, this will cause some issues l

Re: [PATCH] export the function kmap_flush_unused.

2014-08-12 Thread Zhang, Yanmin
On 2014/8/11 19:54, Peter Zijlstra wrote: On Mon, Aug 11, 2014 at 01:26:45AM +, Sha, Ruibin wrote: Hi Chintan, Thank you very much for your timely and kindly response and comments. Here is more detail about our Scenario: We have a big driver on Android product. The driver allocates lo

Re: [PATCH] export the function kmap_flush_unused.

2014-08-10 Thread Zhang, Yanmin
...@codeaurora.org] Sent: Friday, August 8, 2014 9:40 PM To: Sha, Ruibin Cc: linux-kernel@vger.kernel.org; linux...@kvack.org; m...@csn.ul.ie; a.p.zijls...@chello.nl; mgor...@suse.de; mi...@redhat.com; Zhang, Yanmin; He, Bo Subject: Re: [PATCH] export the function kmap_flush_unused. On 08/08/2014 02

Re: [dm-devel] [PATCH] md/dm-ioctl.c: optimize memory allocation in copy_params

2014-07-23 Thread Zhang, Yanmin
On 2014/7/24 1:14, Mikulas Patocka wrote: On Wed, 23 Jul 2014, Alasdair G Kergon wrote: On Wed, Jul 23, 2014 at 08:16:58AM -0400, Mikulas Patocka wrote: So, it means that you do not use device mapper at all. So, why are you trying to change memory allocation in device mapper? So the *test*

Re: [dm-devel] [PATCH] md/dm-ioctl.c: optimize memory allocation in copy_params

2014-07-22 Thread Zhang, Yanmin
On 2014/7/22 10:04, Alasdair G Kergon wrote: On Tue, Jul 22, 2014 at 02:23:52AM +0100, Alasdair G Kergon wrote: Unanswered. Let's ask the same question in a different way: A quick search for 'vold' returns: https://android.googlesource.com/platform/system/vold/ and the code there request

Re: [dm-devel] [PATCH] md/dm-ioctl.c: optimize memory allocation in copy_params

2014-07-22 Thread Zhang, Yanmin
On 2014/7/22 9:23, Alasdair G Kergon wrote: On 2014/7/9 6:39, Mikulas Patocka wrote: Which ioctl with more than 16kB arguments do you use? Unanswered. Let's ask the same question in a different way: Please supply the output of these three commands on the real-world system on which you believe

Re: [dm-devel] [PATCH] md/dm-ioctl.c: optimize memory allocation in copy_params

2014-07-21 Thread Zhang, Yanmin
On 2014/7/9 22:53, Mikulas Patocka wrote: On Wed, 9 Jul 2014, Zhang, Yanmin wrote: On 2014/7/9 6:39, Mikulas Patocka wrote: Hi Mikulas, Thanks for your kind comments. I don't really know what is the purpose of this patch. In existing device mapper code, if kmalloc fails, the alloc

Re: [PATCH] perf: Don't enable the perf_event without in PERF_ATTACH_CONTEXT status

2014-07-15 Thread Zhang, Yanmin
On 2014/7/14 21:27, Peter Zijlstra wrote: On Thu, Jul 03, 2014 at 11:36:38AM +0800, Chen LinX wrote: From: "Chen LinX" when do cpu hotplug test and run below perf test together, pmu may access freed perf_event while true; do perf record -a -g -f sleep 10 rm perf.* done the scenario is that

Re: [dm-devel] [PATCH] md/dm-ioctl.c: optimize memory allocation in copy_params

2014-07-08 Thread Zhang, Yanmin
On 2014/7/9 6:39, Mikulas Patocka wrote: Hi Mikulas, Thanks for your kind comments. I don't really know what is the purpose of this patch. In existing device mapper code, if kmalloc fails, the allocation is retried with __vmalloc. So there is no need to avoid kmalloc aritifically. kmalloc

Re: Should Pstore(ramoops) records customized information?

2014-06-30 Thread Zhang, Yanmin
On 2014/6/27 20:06, Liu hua wrote: 于 2014/6/26 8:57, Zhang, Yanmin 写道: On 2014/6/25 21:08, Liu hua wrote: 于 2014/6/25 8:41, Zhang, Yanmin 写道: On 2014/6/20 18:47, Liu hua wrote: On 2014/6/20 7:42, Luck, Tony wrote: BTW, I note that "extern struct pstore_info *psinfo" locates in

Re: Should Pstore(ramoops) records customized information?

2014-06-25 Thread Zhang, Yanmin
On 2014/6/25 21:08, Liu hua wrote: 于 2014/6/25 8:41, Zhang, Yanmin 写道: On 2014/6/20 18:47, Liu hua wrote: On 2014/6/20 7:42, Luck, Tony wrote: BTW, I note that "extern struct pstore_info *psinfo" locates in fs/pstore/internal.h. So users out of directory "fs/pstore/" ca

Re: Should Pstore(ramoops) records customized information?

2014-06-24 Thread Zhang, Yanmin
On 2014/6/20 18:47, Liu hua wrote: On 2014/6/20 7:42, Luck, Tony wrote: BTW, I note that "extern struct pstore_info *psinfo" locates in fs/pstore/internal.h. So users out of directory "fs/pstore/" can not use pstore to record messages. We do not want other kernel users to use pstore, right?

Re: [PATCH] perf: fix kernel panic when parsing user space CS saved in pt_regs

2014-06-05 Thread Zhang, Yanmin
On 2014/6/5 17:15, Peter Zijlstra wrote: On Thu, Jun 05, 2014 at 04:00:24PM +0800, Zhang, Yanmin wrote: On 2014/6/5 15:55, Peter Zijlstra wrote: Why does pstore cause corruption? I thought that stuff was supposed to be 'good' ? pstore is good if the board is reset by WarmReset

Re: [PATCH] perf: fix kernel panic when parsing user space CS saved in pt_regs

2014-06-05 Thread Zhang, Yanmin
On 2014/6/5 15:55, Peter Zijlstra wrote: On Thu, Jun 05, 2014 at 03:33:21PM +0800, Liu ShuoX wrote: On Thu 5.Jun'14 at 9:19:19 +0200, Peter Zijlstra wrote: On Thu, Jun 05, 2014 at 10:36:10AM +0800, Liu ShuoX wrote: From: Zhang Yanmin We hit a kernel panic when running perf to collect

RE: linux-next: build failure after merge of the ia64 tree

2014-03-30 Thread Zhang, Yanmin
Sorry. We would fix it ASAP. Yanmin -Original Message- From: Stephen Rothwell [mailto:s...@canb.auug.org.au] Sent: Monday, March 31, 2014 8:08 AM To: Luck, Tony Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Liu, ShuoX; Zhang, Yanmin Subject: linux-next: build failure

Re: [PATCH] pstore: skip zero size persistent ram buffer in traverse

2014-03-02 Thread Zhang, Yanmin
On 2014/2/28 14:38, shuox@intel.com wrote: From: Liu ShuoX In ramoops_pstore_read, a valid prz pointer with zero size buffer will break traverse of all persistent ram buffers. The latter buffer might be lost. Andrew, Would you like to merge it to your testing tree? pstore is a very impor

Re: [PATCH] pstore: reset ftrace_read_cnt at ramoops_pstore_open

2014-03-02 Thread Zhang, Yanmin
On 2014/2/28 14:37, shuox@intel.com wrote: From: Liu ShuoX ftrace_read_cnt need to be reset in open to support mutli times getting the records. Andrew, Would you like to merge it to your testing tree? pstore is a very important feature for debugging hard issues on Android mobiles. Yanmi

RE: [PATCH] klist: del waiter from klist_remove_waiters before wakeup waitting process

2013-05-07 Thread Zhang, Yanmin
Andrew, Would you like to merge the patch to your MM tree? Yanmin >-Original Message- >From: Peter Zijlstra [mailto:pet...@infradead.org] >Sent: Friday, May 03, 2013 6:42 PM >To: Wang, Biao >Cc: a...@linux-foundation.org; linux-kernel@vger.kernel.org; >mi...@redhat.

RE: [PATCH] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-26 Thread Zhang, Yanmin
>-Original Message- >From: Thomas Gleixner [mailto:t...@linutronix.de] >Sent: Friday, October 26, 2012 5:55 PM >To: He, Bo >Cc: linux-kernel@vger.kernel.org; Peter Zijlstra; Ingo Molnar; >yanmin_zh...@linux.intel.com; Zhang, Yanmin >Subject: Re: [PATCH] hrtimer:__r

RE: Why hold device_lock when calling callback in pci_walk_bus?

2012-09-28 Thread Zhang, Yanmin
To: bhelg...@google.com Cc: Greg Kroah-Hartman; Zhang, Yanmin; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; r...@sisk.pl Subject: Why hold device_lock when calling callback in pci_walk_bus? Hi, All, If my understanding were correct, device_lock is used to provide mutual exclusion betw

Re: tbench regression in 2.6.25-rc1

2008-02-20 Thread Zhang, Yanmin
ssion. Thank Eric, Valdis, and David! Signed-off-by: Zhang Yanmin <[EMAIL PROTECTED]> Acked-by: Eric Dumazet <[EMAIL PROTECTED]> --- --- linux-2.6.25-rc1/include/net/dst.h 2008-02-21 14:33:43.0 +0800 +++ linux-2.6.25-rc1_work/include/net/dst.h 2008-02-22 12:52:19.0

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:40 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: > >> On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > >> > >>> I also think __r

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Wed, 2008-02-20 at 10:08 +0800, Zhang, Yanmin wrote: > On Wed, 2008-02-20 at 08:36 +0800, Zhang, Yanmin wrote: > > On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > > > Ingo Molnar wrote: > > > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > &g

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Wed, 2008-02-20 at 08:36 +0800, Zhang, Yanmin wrote: > On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > > Ingo Molnar wrote: > > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > > >>> Yes, this can happen. Are you saying it is not safe

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > Ingo Molnar wrote: > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > >>> Yes, this can happen. Are you saying it is not safe to be in the > >>> lockless path when an IRQ triggers? > >> Hmm. The barrier() in slab_free() looks fishy. The co

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:35 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: > >> On Mon, 18 Feb 2008 16:12:38 +0800 > >> "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > >> > &g

Re: NULL pointer in kmem_cache_alloc with 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 08:42 -0800, Christoph Lameter wrote: > On Fri, 15 Feb 2008, Zhang, Yanmin wrote: > > > On my 16-core tigerton, kernel panic when I ran hackbench process testing. > > See > > below log. > > > > > Kernel panic at line 1637 in file mm

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: > On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > > > I also think __refcnt is the key. I did a new testing by adding 2 unsigned > > long > > pading before lastuse, so the 3 members

Re: NULL pointer in kmem_cache_alloc with 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 08:52 -0800, Arjan van de Ven wrote: > On Mon, 18 Feb 2008 04:59:18 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Fri, 15 Feb 2008 14:47:01 +0800 "Zhang, Yanmin" > > <[EMAIL PROTECTED]> wrote: > > >

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: > On Mon, 18 Feb 2008 16:12:38 +0800 > "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > > > On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: > > > From: Eric Dumazet <[EMAIL PROTECTED]&g

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
long pading before lastuse, so the 3 members are moved to next cache line. The performance is recovered. How about below patch? Almost all performance is recovered with the new patch. Signed-off-by: Zhang Yanmin <[EMAIL PROTECTED]> --- --- linux-2.6.25-rc1/include/net/dst.h 2008-02-21

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-17 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 10:52 +0530, Balbir Singh wrote: > Zhang, Yanmin wrote: > > On Mon, 2008-02-18 at 10:26 +0530, Balbir Singh wrote: > >> Zhang, Yanmin wrote: > >>>>> Did you have > >>>>> CONFIG_FAIR_USER_SCHED enabled in both case

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-17 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 10:26 +0530, Balbir Singh wrote: > Zhang, Yanmin wrote: > >> > >>> Did you have > >>> CONFIG_FAIR_USER_SCHED enabled in both cases? > >> Yes. > >> > >> CONFIG_FAIR_GROUP_SCHED=y > >> CONFIG_FAIR_USER_SC

Re: tbench regression in 2.6.25-rc1

2008-02-17 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 15:21 +0100, Eric Dumazet wrote: > Zhang, Yanmin a écrit : > > On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: > > > >> Zhang, Yanmin a �crit : > >> > >>> Comparing with kernel 2.6.24, tbench result has regression wi

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-15 Thread Zhang, Yanmin
On Thu, 2008-02-14 at 15:41 +0800, Zhang, Yanmin wrote: > On Wed, 2008-02-13 at 17:37 +0530, Srivatsa Vaddagiri wrote: > > On Wed, Feb 13, 2008 at 03:15:16PM +0530, Balbir Singh wrote: > > > Zhang, Yanmin wrote: > > > > volanoMark has 45% regression with kerne

NULL pointer in kmem_cache_alloc with 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
On my 16-core tigerton, kernel panic when I ran hackbench process testing. See below log. Commandline to start hackbench: #./hackbench 150 process 2000 Kernel config options: CONFIG_PREEMPT_NONE=y # CONFIG_PREEMPT_VOLUNTARY is not set # CONFIG_PREEMPT is not set Kernel panic at line 1637 in fil

Re: tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > Comparing with kernel 2.6.24, tbench result has regression with > > 2.6.25-rc1. > > > > 1) On 2 quad-core processor stoakley: 4%. > > 2) On 4 quad-core processor tigerton: more

tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit b4ce92775c2e7ff9cf79cca4e0a19

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-13 Thread Zhang, Yanmin
On Wed, 2008-02-13 at 17:37 +0530, Srivatsa Vaddagiri wrote: > On Wed, Feb 13, 2008 at 03:15:16PM +0530, Balbir Singh wrote: > > Zhang, Yanmin wrote: > > > volanoMark has 45% regression with kernel 2.6.25-rc1 on my both 8-core > > > stoakley and 16-core Tigerton. &g

2.6.25-rc1: volanoMark 45% regression

2008-02-13 Thread Zhang, Yanmin
volanoMark has 45% regression with kernel 2.6.25-rc1 on my both 8-core stoakley and 16-core Tigerton. I used bisect to locate below patch. commit 58e2d4ca581167c2a079f4ee02be2f0bc52e8729 Author: Srivatsa Vaddagiri <[EMAIL PROTECTED]> Date: Fri Jan 25 21:08:00 2008 +0100 sched: group schedu

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-15 Thread Zhang, Yanmin
On Wed, 2008-01-16 at 08:34 +0800, Zhang, Yanmin wrote: > On Mon, 2008-01-14 at 21:53 +1100, Herbert Xu wrote: > > On Mon, Jan 14, 2008 at 08:44:40AM +, Ilpo Jrvinen wrote: > > > > > > > > I tried to use bisect to locate the bad patch between 2.6.22 and > &

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-15 Thread Zhang, Yanmin
On Mon, 2008-01-14 at 21:53 +1100, Herbert Xu wrote: > On Mon, Jan 14, 2008 at 08:44:40AM +, Ilpo J�rvinen wrote: > > > > > > I tried to use bisect to locate the bad patch between 2.6.22 and > > > > 2.6.23-rc1, > > > > but the bisected kernel wasn't stable and went crazy. > > > > TCP work bet

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-14 Thread Zhang, Yanmin
On Mon, 2008-01-14 at 11:21 +0200, Ilpo J�rvinen wrote: > On Mon, 14 Jan 2008, Ilpo J�rvinen wrote: > > > On Fri, 11 Jan 2008, Zhang, Yanmin wrote: > > > > > On Wed, 2008-01-09 at 17:35 +0800, Zhang, Yanmin wrote: > > > > > > > > As a matter

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-13 Thread Zhang, Yanmin
On Fri, 2008-01-11 at 09:56 -0800, Rick Jones wrote: > >>The test command is: > >>#sudo taskset -c 7 ./netserver > >>#sudo taskset -c 0 ./netperf -t TCP_RR -l 60 -H 127.0.0.1 -i 50,3 -I 99,5 > >>-- -r 1,1 > > A couple of comments/questions on the command lines: Thanks for your kind comments. >

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-11 Thread Zhang, Yanmin
On Wed, 2008-01-09 at 17:35 +0800, Zhang, Yanmin wrote: > The regression is: > 1)stoakley with 2 qual-core processors: 11%; > 2)Tulsa with 4 dual-core(+hyperThread) processors:13%; I have new update on this issue and also cc to netdev maillist. Thank David Miller for pointing me t

Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-09 Thread Zhang, Yanmin
The regression is: 1)stoakley with 2 qual-core processors: 11%; 2)Tulsa with 4 dual-core(+hyperThread) processors:13%; The test command is: #sudo taskset -c 7 ./netserver #sudo taskset -c 0 ./netperf -t TCP_RR -l 60 -H 127.0.0.1 -i 50,3 -I 99,5 -- -r 1,1 As a matter of fact, 2.6.23 has about 6%

Re: Improve hackbench

2008-01-06 Thread Zhang, Yanmin
On Fri, 2008-01-04 at 07:44 -0500, Lee Revell wrote: > On Jan 4, 2008 3:10 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > http://redhat.com/~mingo/cfs-scheduler/tools/hackbench.c > > > > Why not lose the #ifdef and just use PTHREAD_STACK_MIN? That's a good idea. Thanks, -yanmin --- --- hackbe

Re: Improve hackbench

2008-01-06 Thread Zhang, Yanmin
On Fri, 2008-01-04 at 13:51 +0200, T�r�k Edwin wrote: > Ingo Molnar wrote: > > * Zhang, Yanmin <[EMAIL PROTECTED]> wrote: > > > > > >> hackbench is to test Linux scheduler. The original program is at > >> http://devresources.linux-foundation.org/cra

Improve hackbench

2008-01-03 Thread Zhang, Yanmin
hackbench is to test Linux scheduler. The original program is at http://devresources.linux-foundation.org/craiger/hackbench/src/hackbench.c Based on this multi-process version, a nice person created a multi-thread version. Pls. see http://www.bullopensource.org/posix/pi-futex/hackbench_pth.c When

volanoMark 24% regression in 2.6.24-rc6: why a simple patch makes it

2007-12-24 Thread Zhang, Yanmin
With kernel 2.6.24-rc6, volanoMark has much regression. 1) On 8-core stoakley: 17%; 2) On 16-core tigerton: 24%. I bisected it down to patch fbdcf18df73758b2e187ab94678b30cd5f6ff9f9. It is to fix the bad cpu number in /proc/cpuinfo. As a matter of fact, this issue is already fixed by other 2 patc

Re: Linux 2.6.24-rc6

2007-12-20 Thread Zhang, Yanmin
On Thu, 2007-12-20 at 17:41 -0800, Linus Torvalds wrote: > The most noticeable part here (both to users and in the diffstat) should > be the libata-acpi fixes by Tejun Heo, which should hopefully take care of > all of the regressions that were caused by teaching SATA about doing the > proper ACP

Re: Reducing the bdi proporion calculation period to speed up disk write

2007-12-13 Thread Zhang, Yanmin
On Tue, 2007-12-11 at 11:11 +0100, Peter Zijlstra wrote: > On Tue, 2007-12-11 at 14:25 +0800, zhejiang wrote: > > The patch 04fbfdc14e5f48463820d6b9807daa5e9c92c51f implemented bdi per > > device dirty threshold. It works well. > > However, the period for proportion calculation may be too large. >

Re: sched_yield: delete sysctl_sched_compat_yield

2007-12-03 Thread Zhang, Yanmin
On Mon, 2007-12-03 at 11:05 +0100, Ingo Molnar wrote: > * Zhang, Yanmin <[EMAIL PROTECTED]> wrote: > > > Although no source codes of volanoMark, I suspect it calls > > Thread.sched. volanoMark is a kind of chatroom benchmark. When a > > client sends out a message

Re: sched_yield: delete sysctl_sched_compat_yield

2007-12-03 Thread Zhang, Yanmin
On Mon, 2007-12-03 at 09:45 +0100, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > On Friday 30 November 2007 21:08, Ingo Molnar wrote: > > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > Haven't we been asking JVMs to use futexes or posix locking for years > > > > and years

Re: sched_yield: delete sysctl_sched_compat_yield

2007-12-03 Thread Zhang, Yanmin
On Mon, 2007-12-03 at 20:17 +1100, Nick Piggin wrote: > On Monday 03 December 2007 19:45, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > On Friday 30 November 2007 21:08, Ingo Molnar wrote: > > > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > > Haven't we been asking JVMs

Re: sched_yield: delete sysctl_sched_compat_yield

2007-12-03 Thread Zhang, Yanmin
On Fri, 2007-11-30 at 11:08 +0100, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Haven't we been asking JVMs to use futexes or posix locking for years > > and years now? [...] > > i'm curious, with what JVM was it tested and where's the source so i can > fix their locking

Re: sched_yield: delete sysctl_sched_compat_yield

2007-11-29 Thread Zhang, Yanmin
On Fri, 2007-11-30 at 14:29 +1100, Nick Piggin wrote: > On Friday 30 November 2007 14:15, Zhang, Yanmin wrote: > > On Fri, 2007-11-30 at 13:46 +1100, Nick Piggin wrote: > > > On Wednesday 28 November 2007 09:57, Arjan van de Ven wrote: > > > > > sounds

Re: sched_yield: delete sysctl_sched_compat_yield

2007-11-29 Thread Zhang, Yanmin
On Fri, 2007-11-30 at 13:46 +1100, Nick Piggin wrote: > On Wednesday 28 November 2007 09:57, Arjan van de Ven wrote: > > On Tue, 27 Nov 2007 17:33:05 +0800 > > > > "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > > > If echo "1">/proc/sys

sched_yield: delete sysctl_sched_compat_yield

2007-11-27 Thread Zhang, Yanmin
If echo "1">/proc/sys/kernel/sched_compat_yield before starting volanoMark testing, the result is very good with kernel 2.6.24-rc3 on my 16-core tigerton. 1) If /proc/sys/kernel/sched_compat_yield=1, comparing with 2.6.22, 2.6.24-rc3 has more than 70% improvement; 2) If /proc/sys/kernel/sched_comp

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-13 Thread Zhang, Yanmin
On Tue, 2007-11-13 at 10:19 +0800, Zhang, Yanmin wrote: > On Mon, 2007-11-12 at 17:48 +0100, Peter Zijlstra wrote: > > On Mon, 2007-11-12 at 17:05 +0200, Benny Halevy wrote: > > > On Nov. 12, 2007, 15:26 +0200, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > S

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Zhang, Yanmin
On Mon, 2007-11-12 at 17:48 +0100, Peter Zijlstra wrote: > On Mon, 2007-11-12 at 17:05 +0200, Benny Halevy wrote: > > On Nov. 12, 2007, 15:26 +0200, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > Single socket, dual core opteron, 2GB memory > > > Single SATA disk, ext3 > > > > > > x86_64 kernel a

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Zhang, Yanmin
On Mon, 2007-11-12 at 04:58 -0800, Martin Knoblauch wrote: > - Original Message > > From: "Zhang, Yanmin" <[EMAIL PROTECTED]> > > To: Martin Knoblauch <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED]; LKML > > Sent: Monday, November 12,

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Zhang, Yanmin
On Mon, 2007-11-12 at 12:25 -0500, Mark Lord wrote: > Peter Zijlstra wrote: > .. > > While I see that the write speed as reported under .24 ~70MB/s is much > > lower than the one reported under .23 ~200MB/s, I find it very hard to > > believe my poor single SATA disk could actually do the 200MB/s f

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Zhang, Yanmin
On Mon, 2007-11-12 at 10:45 +0100, Peter Zijlstra wrote: > On Mon, 2007-11-12 at 10:14 +0800, Zhang, Yanmin wrote: > > > > Subject: mm: speed up writeback ramp-up on clean systems > > > > I tested kernel 2.6.23, 2,6,24-rc2, 2.6.24-rc2_peter(2.6.24-rc2+this patch). >

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-11 Thread Zhang, Yanmin
On Fri, 2007-11-09 at 10:54 +0100, Peter Zijlstra wrote: > On Fri, 2007-11-09 at 17:47 +0800, Zhang, Yanmin wrote: > > Comparing with 2.6.23, iozone sequential write/rewrite (512M) has 50% > > regression > > in kernel 2.6.24-rc1. 2.6.24-rc2 has the same regression. >

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-11 Thread Zhang, Yanmin
On Fri, 2007-11-09 at 04:36 -0800, Martin Knoblauch wrote: > - Original Message > > From: "Zhang, Yanmin" <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > Cc: LKML > > Sent: Friday, November 9, 2007 10:47:52 AM > > Subject:

iozone write 50% regression in kernel 2.6.24-rc1

2007-11-09 Thread Zhang, Yanmin
Comparing with 2.6.23, iozone sequential write/rewrite (512M) has 50% regression in kernel 2.6.24-rc1. 2.6.24-rc2 has the same regression. My machine has 8 processor cores and 8GB memory. By bisect, I located patch http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04

Re: aim7 -30% regression in 2.6.24-rc1

2007-11-06 Thread Zhang, Yanmin
On Mon, 2007-11-05 at 10:37 +0100, Cyrus Massoumi wrote: > Zhang, Yanmin wrote: > > On Thu, 2007-11-01 at 11:02 +0100, Cyrus Massoumi wrote: > >> Zhang, Yanmin wrote: > >>> On Wed, 2007-10-31 at 17:57 +0800, Zhang, Yanmin wrote: > >>>> On Tue, 2

Re: aim7 -30% regression in 2.6.24-rc1

2007-11-04 Thread Zhang, Yanmin
On Thu, 2007-11-01 at 11:02 +0100, Cyrus Massoumi wrote: > Zhang, Yanmin wrote: > > On Wed, 2007-10-31 at 17:57 +0800, Zhang, Yanmin wrote: > >> On Tue, 2007-10-30 at 16:36 +0800, Zhang, Yanmin wrote: > >>> On Tue, 2007-10-30 at 08:26 +0100, Ingo Molnar wrote:

Re: aim7 -30% regression in 2.6.24-rc1

2007-11-01 Thread Zhang, Yanmin
On Wed, 2007-10-31 at 17:57 +0800, Zhang, Yanmin wrote: > On Tue, 2007-10-30 at 16:36 +0800, Zhang, Yanmin wrote: > > On Tue, 2007-10-30 at 08:26 +0100, Ingo Molnar wrote: > > > * Zhang, Yanmin <[EMAIL PROTECTED]> wrote: > > > >

Re: aim7 -30% regression in 2.6.24-rc1

2007-10-31 Thread Zhang, Yanmin
On Tue, 2007-10-30 at 16:36 +0800, Zhang, Yanmin wrote: > On Tue, 2007-10-30 at 08:26 +0100, Ingo Molnar wrote: > > * Zhang, Yanmin <[EMAIL PROTECTED]> wrote: > > > > > sub-bisecting captured patch > > > 38ad464d410dadceda1563f36bdb0be7fe4c8938(s

  1   2   >