Re: [PATCH net] net: account for current skb length when deciding about UFO

2017-06-19 Thread Vlad Yasevich
f further fragments) for skb == NULL. > > Fixes: e89e9cf539a2 ("[IPv4/IPv6]: UFO Scatter-gather approach") > Fixes: e4c5e13aa45c ("ipv6: Should use consistent conditional judgement for > ip6 fragment between __ip6_append_data and ip6_finish_output") > Signed-off-by:

Re: [PATCH 5/5] sctp: Adjust one function call together with a variable assignment

2017-05-22 Thread Vlad Yasevich
n_dev = __in_dev_get_rcu(dev); > + if (!in_dev) { > rcu_read_unlock(); > return; > } > Acked-by: Vlad Yasevich -vlad

Re: [PATCH 4/5] sctp: Improve a size determination in sctp_inetaddr_event()

2017-05-22 Thread Vlad Yasevich
tp_sockaddr_entry), GFP_ATOMIC); > + addr = kmalloc(sizeof(*addr), GFP_ATOMIC); > if (addr) { > addr->a.v4.sin_family = AF_INET; > addr->a.v4.sin_port = 0; > Acked-by: Vlad Yasevich -vlad

Re: [PATCH 3/5] sctp: Fix a typo in a comment line in sctp_init()

2017-05-22 Thread Vlad Yasevich
tialize the SCTP port hash table. > - * Note that order is initalized to start at the max sized > + * Note that order is initialized to start at the max sized >* table we want to support. If we can't get that many pages > * reduce the order and try again >*/ > Acked-by: Vlad Yasevich

Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()

2017-05-22 Thread Vlad Yasevich
.5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); > status = -ENOMEM; >

Re: [PATCH 1/5] sctp: Use kmalloc_array() in sctp_init()

2017-05-22 Thread Vlad Yasevich
convention. > > Signed-off-by: Markus Elfring Acked-by: Vlad Yasevich -vlad > --- > net/sctp/protocol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 989a900383b5..2b1a6215bd2f 10064

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

2015-12-09 Thread Vlad Yasevich
to avoid > future mistakes. > > Reported-by: Dmitry Vyukov > Signed-off-by: Eric Dumazet Acked-by: Vlad Yasevich This is sufficient for accept() processing, but looks like peeloff is missing a bunch of ipv6 support. I'll see if I can cook something up to fix that part. -vlad > -

Re: use-after-free in sctp_do_sm

2015-12-04 Thread Vlad Yasevich
On 12/04/2015 07:55 AM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 04, 2015 at 11:40:02AM +0100, Dmitry Vyukov wrote: >> On Thu, Dec 3, 2015 at 9:51 PM, Joe Perches wrote: >>> (adding lkml as this is likely better discussed there) >>> >>> On Thu, 2015-12-03 at 15:42 -0500, Jason Baron wrote: >>>

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-28 Thread Vlad Yasevich
On 08/27/2015 10:42 PM, Jason Wang wrote: > > > On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote: >> On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote: >>> >>> On 08/26/2015 12:32 AM, Vlad Yasevich wrote: >>>> On 08/25/2015 07:30 AM, J

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 07:30 AM, Jason Wang wrote: > > > On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: >> On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after commit 6acf54f1cf0a6747bac9fea26f

Re: [PATCH] sctp: Add counters for out data chunk discards

2015-07-06 Thread Vlad Yasevich
On 07/06/2015 01:37 PM, Vitaly Andrianov wrote: > This commit adds a MIB entry for out data chunk discards. > Number of outgoing SCTP DATA chunks for a SCTP association for which no > problems were encountered to prevent their transmission but were discarded. > Data chunks are discarded due to ungr

Re: kernel >= 4.0: crashes when using traceroute6 with isatap

2015-05-12 Thread Vlad Yasevich
On 05/12/2015 04:36 PM, Eric Dumazet wrote: > On Tue, 2015-05-12 at 16:18 -0400, Vlad Yasevich wrote: >> On 05/06/2015 06:11 PM, Wolfgang Walter wrote: >>> Am Mittwoch, 6. Mai 2015, 11:15:18 schrieben Sie: >>>> (Cc'ing netdev.) >>>> >>>

Re: kernel >= 4.0: crashes when using traceroute6 with isatap

2015-05-12 Thread Vlad Yasevich
On 05/06/2015 06:11 PM, Wolfgang Walter wrote: > Am Mittwoch, 6. Mai 2015, 11:15:18 schrieben Sie: >> (Cc'ing netdev.) >> >> On Sat, May 2, 2015 at 5:29 AM, Wolfgang Walter wrote: >>> Am Samstag, 2. Mai 2015, 02:16:36 schrieb Wolfgang Walter: Hello, kernel 4.0 (and 4.0.1) crashes im

Re: kernel >= 4.0: crashes when using traceroute6 with isatap

2015-05-12 Thread Vlad Yasevich
On 05/06/2015 06:42 PM, Eric Dumazet wrote: > On Thu, 2015-05-07 at 00:04 +0200, Wolfgang Walter wrote: >> Am Mittwoch, 6. Mai 2015, 12:10:00 schrieb Eric Dumazet: >>> On Wed, 2015-05-06 at 11:15 -0700, Cong Wang wrote: (Cc'ing netdev.) On Sat, May 2, 2015 at 5:29 AM, Wolfgang Walter

Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-02-17 Thread Vlad Yasevich
t;>>>> We did bisect, and the below looks the culprit; >>>>> >>>>> 32dce968dd987adfb0c00946d78dad9154f64759 is the first bad commit >>>>> commit 32dce968dd987adfb0c00946d78dad9154f64759 >>>>> Author: Vlad Yasevich >>>>&g

Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-02-13 Thread Vlad Yasevich
the same error >>>>>>> message in >>>>> host too. >>>>>>> ixgbe :2d:00.0: partial checksum but l4 proto=3a! >>>>>>> >>>>>>> Do you have any idea about that? >>>>>> >>>>>>

Re: Fwd: Question on SCTP ABORT chunk is generated when the association_max_retrans is reached

2015-01-23 Thread Vlad Yasevich
On 01/23/2015 12:10 PM, Daniel Borkmann wrote: > On 01/23/2015 05:05 PM, Vlad Yasevich wrote: >> On 01/23/2015 06:50 AM, Daniel Borkmann wrote: >>> On 01/23/2015 11:25 AM, Sun Paul wrote: >>> ... >>>> I would like to check the behave in LKSCTP. >>>

Re: Fwd: Question on SCTP ABORT chunk is generated when the association_max_retrans is reached

2015-01-23 Thread Vlad Yasevich
On 01/23/2015 05:25 AM, Sun Paul wrote: > Hi > > I would like to check the behave in LKSCTP. > > we are running DIAMETER message over SCTP, and we have set the > parameter "net.sctp.association_max_retrans = 4" in the LinuxOS. > > We noticed that when remote peer have retry to send the same requ

Re: Fwd: Question on SCTP ABORT chunk is generated when the association_max_retrans is reached

2015-01-23 Thread Vlad Yasevich
On 01/23/2015 06:50 AM, Daniel Borkmann wrote: > Hi, > > On 01/23/2015 11:25 AM, Sun Paul wrote: > ... >> I would like to check the behave in LKSCTP. >> >> we are running DIAMETER message over SCTP, and we have set the >> parameter "net.sctp.association_max_retrans = 4" in the LinuxOS. >> >> We no

Re: [PATCH 3.2 105/131] net: Correctly set segment mac_len in skb_segment().

2014-09-11 Thread Vlad Yasevich
On 09/11/2014 08:32 AM, Ben Hutchings wrote: > 3.2.63-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Vlad Yasevich > > [ Upstream commit fcdfe3a7fa4cb74391d42b6a26dc07c20dab1d82 ] > > When performing segment

Re: RTNL: assertion failed at net/ipv6/addrconf.c (1699)

2014-09-02 Thread Vlad Yasevich
On 09/02/2014 02:15 PM, Cong Wang wrote: > On Tue, Sep 2, 2014 at 11:11 AM, Eric Dumazet wrote: >> On Tue, 2014-09-02 at 11:04 -0700, Cong Wang wrote: >>> On Tue, Sep 2, 2014 at 10:58 AM, Hannes Frederic Sowa >> I definitely don't have a problem cleaning this up in net-next. I wanted a m

Re: RTNL: assertion failed at net/ipv6/addrconf.c (1699)

2014-08-29 Thread Vlad Yasevich
On 08/29/2014 11:26 AM, Tommi Rantala wrote: > Hi, > > Was fuzzing Linus v3.17-rc2-89-g59753a8 with Trinity as the root user > in qemu, when I hit the following assertion failures. > > Tommi > > > [init] Started watchdog process, PID is 4841 > [main] Main thread is alive. > [ 77.229699] sctp:

Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

2014-08-20 Thread Vlad Yasevich
ported-by: Deepak Khandelwal > Suggested-by: Vlad Yasevich > Suggested-by: Michael Tuexen > Suggested-by: Daniel Borkmann > Signed-off-by: Zhu Yanjun Acked-by: Vlad Yasevich Thanks -vlad > --- > net/sctp/associola.c | 1 + > 1 file changed, 1 insertion(+) > > d

3.16-rc1 kernel BUG triggered at mutex.c:586

2014-06-16 Thread Vlad Yasevich
Trying to boot 3.16.0-rc1+ (the + is a small vlan related patch) on a tests system triggers the following BUG: Jun 16 13:54:50 scratch kernel: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:586 Jun 16 13:54:50 scratch kernel: in_atomic(): 1, irqs_disabled(): 1, pid: 0

Re: [PATCH v2] sctp: Fix sk_ack_backlog wrap-around problem

2014-06-12 Thread Vlad Yasevich
7;s list. > > Fix-suggested-by: Neil Horman > Signed-off-by: Xufeng Zhang Acked-by: Vlad Yasevich Thanks -vlad > --- > Change for v2: > Drop the redundant test for temp suggested by Vlad Yasevich. > > net/sctp/associola.c |2 +- > 1 files changed, 1 insertio

Re: [PATCH] sctp: Fix sk_ack_backlog wrap-around problem

2014-06-11 Thread Vlad Yasevich
On 06/11/2014 08:55 AM, Vlad Yasevich wrote: > On 06/10/2014 10:37 PM, Xufeng Zhang wrote: >> Consider the scenario: >> For a TCP-style socket, while processing the COOKIE_ECHO chunk in >> sctp_sf_do_5_1D_ce(), after it has passed a series of sanity check, >> a new asso

Re: [PATCH] sctp: Fix sk_ack_backlog wrap-around problem

2014-06-11 Thread Vlad Yasevich
On 06/10/2014 10:37 PM, Xufeng Zhang wrote: > Consider the scenario: > For a TCP-style socket, while processing the COOKIE_ECHO chunk in > sctp_sf_do_5_1D_ce(), after it has passed a series of sanity check, > a new association would be created in sctp_unpack_cookie(), but afterwards, > some process

Re: [PULL 2/2] vhost: replace rcu with mutex

2014-06-03 Thread Vlad Yasevich
On 06/03/2014 08:48 AM, Paolo Bonzini wrote: > Il 02/06/2014 23:58, Eric Dumazet ha scritto: >> This looks dubious >> >> What about using kfree_rcu() instead ? > > It would lead to unbound allocation from userspace. > >> translate_desc() still uses rcu_read_lock(), its not clear if the mutex >> i

Re: [PATCH net] bridge: notify user space after fdb update

2014-05-28 Thread Vlad Yasevich
On 05/27/2014 06:45 PM, Jon Maxwell wrote: > There has been a number incidents recently where customers running KVM have > reported that VM hosts on different Hypervisors are unreachable. Based on > pcap traces we found that the bridge was broadcasting the ARP request out > onto the network. Howeve

Re: skbuff truesize incorrect.

2014-05-22 Thread Vlad Yasevich
On 05/22/2014 03:07 PM, Jim Baxter wrote: > Hi, I was hoping you can help me with some questions. > > I have been investigating a network issue with bursts of network traffic > over USB CDC-NCM, the issue is that the kernel is dropping packets > because sk_rcvqueues_full() returns true due to skb2

Re: Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-05-20 Thread Vlad Yasevich
On 05/20/2014 12:55 AM, valdis.kletni...@vt.edu wrote: > On Mon, 19 May 2014 23:49:22 +0930, David Newall said: > >> How does a packet get fragmented in this case? Does it only happen when >> bridging to a device with smaller MTU? That scenario sounds quite >> un-bridge-like. It also sounds lik

Re: linux-next: build failure after merge of the net tree

2014-05-20 Thread Vlad Yasevich
On 05/19/2014 08:59 PM, Stephen Rothwell wrote: > Hi all, > > After merging the net tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > > In file included from arch/powerpc/net/bpf_jit_comp.c:16:0: > include/linux/if_vlan.h: In function 'vlan_get_encap_level': > incl

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Vlad Yasevich
On 05/19/2014 01:24 PM, Michael Spang wrote: > Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY > will result in an incorrect checksum if the packet is sent off the box. > > Cc: sta...@vger.kernel.org > Signed-off-by: Michael Spang > --- > drivers/net/macvlan.c | 4 +++- > 1 file

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Vlad Yasevich
On 04/30/2014 06:59 PM, Luis R. Rodriguez wrote: > On Wed, Apr 30, 2014 at 04:04:34PM -0400, Vlad Yasevich wrote: >> On 04/22/2014 03:43 PM, Luis R. Rodriguez wrote: >>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c >>> index 54d207d..dcd9378 100644 >>>

Re: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes

2014-04-30 Thread Vlad Yasevich
On 04/22/2014 03:43 PM, Luis R. Rodriguez wrote: > On Tue, Mar 18, 2014 at 02:22:43PM -0700, Luis R. Rodriguez wrote: >> On Tue, Mar 18, 2014 at 01:46:49PM -0700, Cong Wang wrote: >>> On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez wrote: On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-04-30 Thread Vlad Yasevich
On 04/22/2014 03:41 PM, Luis R. Rodriguez wrote: > On Wed, Mar 19, 2014 at 7:05 PM, Luis R. Rodriguez wrote: >> On Tue, Mar 18, 2014 at 08:10:56PM -0700, Stephen Hemminger wrote: >>> On Wed, 12 Mar 2014 20:15:25 -0700 >>> "Luis R. Rodriguez" wrote: >>> As it is now if you add create a bridge

Re: [PATCH V2] sctp: reset flowi4_oif parameter on route lookup

2014-04-25 Thread Vlad Yasevich
-s -I > You'll detect that all the flow are routed to eth0.2(10.0.1.254). > > Signed-off-by: Xufeng Zhang > Signed-off-by: Julian Anastasov Acked-by: Vlad Yasevich -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: macvtap performance regression (bisected) between 3.13 and 3.14-rc1

2014-03-03 Thread Vlad Yasevich
On 03/03/2014 04:13 AM, Christian Borntraeger wrote: > On 02/03/14 02:21, Vlad Yasevich wrote: >> On 03/01/2014 02:27 PM, Vlad Yasevich wrote: >>> On 03/01/2014 06:15 AM, Christian Borntraeger wrote: >>>> On 28/02/14 23:14, Vlad Yasevich wrote: >>>>>

Re: macvtap performance regression (bisected) between 3.13 and 3.14-rc1

2014-03-01 Thread Vlad Yasevich
On 03/01/2014 02:27 PM, Vlad Yasevich wrote: > On 03/01/2014 06:15 AM, Christian Borntraeger wrote: >> On 28/02/14 23:14, Vlad Yasevich wrote: >>> On 02/27/2014 03:52 PM, Christian Borntraeger wrote: >>>> Vlad, >>>> >>>> commit 6acf54f1cf0a6747

Re: macvtap performance regression (bisected) between 3.13 and 3.14-rc1

2014-03-01 Thread Vlad Yasevich
On 03/01/2014 06:15 AM, Christian Borntraeger wrote: > On 28/02/14 23:14, Vlad Yasevich wrote: >> On 02/27/2014 03:52 PM, Christian Borntraeger wrote: >>> Vlad, >>> >>> commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 >>> macvtap: Add support of pac

Re: macvtap performance regression (bisected) between 3.13 and 3.14-rc1

2014-02-28 Thread Vlad Yasevich
On 02/27/2014 03:52 PM, Christian Borntraeger wrote: > Vlad, > > commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 > macvtap: Add support of packet capture on macvtap device. > > causes a performance regression for iperf traffic between two KVM guests > on my s390 system. Both guests are connec

Re: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread Vlad Yasevich
On 02/18/2014 10:39 AM, David Laight wrote: >>> + >>> + /* Update the heartbeat timer immediately. */ >>> + if (!mod_timer(&trans->hb_timer, >>> + sctp_transport_timeout(trans))) >>> +

Re: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread Vlad Yasevich
On 02/18/2014 12:56 AM, Xufeng Zhang wrote: > For an established association, if user has updated the HB.interval > parameter by setsockopt(), this new heartbeat interval will not > take effect until: > - the expiry of the heartbeat timer and new hearbeat is sent. > - DATA chunk has been sent a

Re: [PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap

2014-01-10 Thread Vlad Yasevich
On 01/10/2014 02:06 AM, Jason Wang wrote: > On 01/10/2014 05:39 AM, Stephen Hemminger wrote: >> On Thu, 09 Jan 2014 16:55:07 +0800 >> Jason Wang wrote: >> >>> What if use do want a qdisc and want to change the its queue length for >>> tun/macvlan? And the the name tx_queue_length is misleading. Fo

Re: [patch net-next v3] ipv6: log autoconfiguration failures

2013-12-13 Thread Vlad Yasevich
On 12/13/2013 10:45 AM, Denys Vlasenko wrote: > If ipv6 auto-configuration does not work, currently it's hard > to track what's going on. This change adds log messages > (at debug level) on every code path where ipv6 autoconf fails. > > v3: changed pr_debug's to pr_warn's. > > Signed-off-by: Deny

Re: [patch net-next v2] ipv6: log autoconfiguration failures

2013-12-12 Thread Vlad Yasevich
On 12/12/2013 12:22 PM, David Miller wrote: > From: Denys Vlasenko > Date: Thu, 12 Dec 2013 12:17:42 +0100 > >> I can easily imagine their frustration. Kernel _knows_ why >> it didn't work, and it's not expected to normally pappen, >> why didn't it tell anything about it? > > Packets are dropped

Re: [PATCH net V3 2/2] macvtap: signal truncated packets

2013-12-11 Thread Vlad Yasevich
hecking work. > > Cc: Vlad Yasevich > Cc: Zhi Yong Wu > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang Acked-by: Vlad Yasevich -vlad > --- > Changes from V2: > - use total as the bytes of packet returned > Changes from V1: > - increase total unconditionally > - d

Re: [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun_recvmsg()

2013-12-10 Thread Vlad Yasevich
On 12/09/2013 08:36 PM, David Miller wrote: > From: Zhi Yong Wu > Date: Sat, 7 Dec 2013 04:55:00 +0800 > >> From: Zhi Yong Wu >> >> By checking related codes, it is impossible that ret > len or total_len, >> so we should remove some useless codes in both above functions. >> >> Signed-off-by: Zh

Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Vlad Yasevich
er than iov length in tun_put_user(). This patch fixes this >> by always return the length of packet plus possible vlan header. Caller can >> detect the truncated packet by comparing the return value and the size of iov >> length. >> >> Reported-by: Vlad Yasevich >>

Re: [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg()

2013-12-06 Thread Vlad Yasevich
On 12/06/2013 03:54 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > By checking related codes, it is impossible that ret > len or total_len, > so we should remove some useless coeds in both above functions. Looks like commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 Author: Jason Wang Date: Thu

Re: [PATCH v2 2/2] tun: update file current position

2013-12-06 Thread Vlad Yasevich
On 12/06/2013 12:45 PM, David Miller wrote: > From: Zhi Yong Wu > Date: Fri, 6 Dec 2013 17:08:50 +0800 > >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu > > Also applied and queued up for -stable, thanks. > > I noticed in these two cases that that min_t() adjustment of 'ret' > seems st

Re: Supporting 4 way connections in LKSCTP

2013-12-04 Thread Vlad Yasevich
On 12/04/2013 11:25 AM, Michael Tuexen wrote: > On Dec 4, 2013, at 5:12 PM, Vlad Yasevich wrote: > >> On 12/04/2013 11:01 AM, Michael Tuexen wrote: >>> On Dec 4, 2013, at 4:41 PM, Vlad Yasevich wrote: >>> >>>> On 12/04/2013 09:50 AM, David Laight wrot

Re: Supporting 4 way connections in LKSCTP

2013-12-04 Thread Vlad Yasevich
On 12/04/2013 12:57 PM, Sun Paul wrote: > As I know, the A to C and A to D case must have a router in between to form > SCTP multihome topology. Not necessary. I've produced proper multihoming topologies with just VLANs and different subnet assignment. You can even remove VLANs if you correctly

Re: Supporting 4 way connections in LKSCTP

2013-12-04 Thread Vlad Yasevich
On 12/04/2013 11:01 AM, Michael Tuexen wrote: > On Dec 4, 2013, at 4:41 PM, Vlad Yasevich wrote: > >> On 12/04/2013 09:50 AM, David Laight wrote: >>>>> In normal operation, IP-A sends INIT to IP-X, IP-X returns INIT_ACK to >>>>> IP-A. IP-A then sends HB

Re: Supporting 4 way connections in LKSCTP

2013-12-04 Thread Vlad Yasevich
On 12/04/2013 09:50 AM, David Laight wrote: >>> In normal operation, IP-A sends INIT to IP-X, IP-X returns INIT_ACK to >>> IP-A. IP-A then sends HB to IP-X, IP-X then returns HB_ACK to IP-A. In >>> the meantime, IP-B sends HB to IP-Y and IPY returns HB_ACK. >>> >>> In case of the path between IP-A

Re: Supporting 4 way connections in LKSCTP

2013-12-04 Thread Vlad Yasevich
the same address that HB were sent to. This is because HB contains a nonce and that nonce is used to locate the correct transport that this HB-ACK belongs to. So, yes, the above communication is a valid SCTP exchange. -vlad > > On Tue, Dec 3, 2013 at 11:22 PM, Vlad Yasevich wrote: >

Re: Supporting 4 way connections in LKSCTP

2013-12-03 Thread Vlad Yasevich
On 12/03/2013 08:11 AM, Sun Paul wrote: > But how about the HB and HB_ACK? Still valid? As long as the source address is part of the association, then yes it is perfectly valid. -vlad > On Dec 3, 2013 8:32 PM, "Vlad Yasevich" wrote: > >> On 12/02/2013 09:19 PM, Sun P

Re: Supporting 4 way connections in LKSCTP

2013-12-03 Thread Vlad Yasevich
st of the INIT-ACK chunk, yes. There is the code in __sctp_rcv_lookup_harder() that looks for other adddresses in the INIT and INIT-ACK chunks. -vlad > > > On Tue, Dec 3, 2013 at 10:03 AM, Vlad Yasevich wrote: >> On 12/02/2013 08:39 PM, Sun Paul wrote: >>> Another question

Re: Supporting 4 way connections in LKSCTP

2013-12-02 Thread Vlad Yasevich
.1.1.254 dev eth2 >> cache mtu 1500 advmss 1460 hoplimit 64 >> >> [root@localhost ~]# ip route get 12.1.1.1 from 110.1.1.1 >> 12.1.1.1 from 110.1.1.1 via 110.1.1.254 dev eth1 >> cache mtu 1500 advmss 1460 hoplimit 64 >> >> so, if this is not b

Re: Supporting 4 way connections in LKSCTP

2013-12-02 Thread Vlad Yasevich
e ip route get 11.1.1.1 return? That's the address that will be used to talk to 11.1.1.1 by default. -vlad > > On Tue, Dec 3, 2013 at 12:42 AM, Vlad Yasevich wrote: >> On 12/02/2013 10:45 AM, Karl Heiss wrote: >>> On Mon, Dec 2, 2013 at 9:38 AM, Vlad Yasevich wrote: >

Re: Supporting 4 way connections in LKSCTP

2013-12-02 Thread Vlad Yasevich
On 12/02/2013 10:45 AM, Karl Heiss wrote: > On Mon, Dec 2, 2013 at 9:38 AM, Vlad Yasevich wrote: >> On 11/27/2013 11:03 PM, Sun Paul wrote: >>> How LKSCTP select which source address to use for the INIT_ACK or >>> HB_ACK? below is the testing result where a router i

Re: Supporting 4 way connections in LKSCTP

2013-12-02 Thread Vlad Yasevich
l >> >>> - PS >>> >>> On Wed, Nov 27, 2013 at 7:09 AM, Sun Paul wrote: >>>> Hi Vlad >>>> >>>> Thank for your reply. If it is based on the destination IP to find the >>>> best route, why the problem didn't happen o

Re: bridge not getting ip since 3.11.5 and 3.4.66

2013-11-26 Thread Vlad Yasevich
On 11/26/2013 08:27 AM, Mark Trompell wrote: > Answering my own mail again and even top posting, sorry, but makes > more sense to me in that case). > I reverted bridge related patches from 3.11.5 and it boils down to > commit 0e308361d7ca0bf8b23fd472b90aae0fb10a1c32 > Author: Herbert Xu > Date:

Re: Supporting 4 way connections in LKSCTP

2013-11-26 Thread Vlad Yasevich
On 11/25/2013 08:03 PM, Sun Paul wrote: > Hi > > we have a problem on using LKSCTP to form a 4 ways multi-homing network. > > Configuration > - Node-A has 2 IP addresses in different subnets, known as IP-A (eth1), > IP-B (eth2) > - Node-B has 2 IP addresses in different subnets, known as IP-X (et

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Vlad Yasevich
on't notice the dropping packet in macvtap tx path. > > Cc: Michael S. Tsirkin > Cc: Vlad Yasevich Acked-by: Vlad Yasevich -vlad > Cc: Eric Dumazet > Signed-off-by: Jason Wang > --- > drivers/net/macvtap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [V2 PATCH] sctp: Restore 'resent' bit to avoid retransmitted chunks for RTT measurements

2013-11-25 Thread Vlad Yasevich
quot;sctp: remove > 'resent' bit from the chunk") which inappropriately removed the > 'resent' bit completely, instead of doing this, we should set > the resent bit only for the retransmitted DATA chunks. > > Signed-off-by: Xufeng Zhang Acked-b

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-23 Thread Vlad Yasevich
On 11/23/2013 06:14 AM, Chang wrote: > Hi, > Could you please why a **reneged** newly acked TSN doesn't qualify the > highest_new_tsn? What's the wrongs of doing that? > > I've been thinking a few scenarios, but I couldn't figure out what's > wrong with that. > The spec is a bit conflicting on t

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 02:24 PM, Chang wrote: > > On 11/22/2013 03:27 PM, Vlad Yasevich wrote: >> On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: >>> tsn_gap_acked is an important state flag in chunk, which indicates if >>> the >>> chunk has been acked in ga

Re: [PATCH] net: sctp: set chunk->tsn_gap_acked at the end of cycle

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 02:49 AM, Chang Xiangzhong wrote: > tsn_gap_acked is an important state flag in chunk, which indicates if the > chunk has been acked in gap reports before. Actually, this bit indicates simply that the chunk has been acked. It doesn't state whether it's been acked in a gap report or

Re: [PATCH] sctp: Restore 'resent' bit to avoid retransmitted chunks for RTT measurements

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 03:30 AM, Xufeng Zhang wrote: > From: Signed-off-by: Xufeng Zhang > > Currently retransmitted DATA chunks could also be used for > RTT measurements since there are no flag to identify whether > the transmitted DATA chunk is a new one or a retransmitted one. > This problem is introdu

Re: [PATCH] net: sctp: recover a tranport when an ack comes

2013-11-15 Thread Vlad Yasevich
On 11/15/2013 05:04 PM, Chang wrote: > > On 11/15/2013 03:34 AM, Vlad Yasevich wrote: >> I don't think this is right. The spec states: >> 8. ACKs for retransmissions do not transition a PF destination back >>to Active state, since a sender cannot disambigu

Re: [PATCH] net: sctp: recover a tranport when an ack comes

2013-11-15 Thread Vlad Yasevich
ax.Retrans in the standard is 5"? Path.Max.Retrans is set to 5 (at least on my system...) -vlad Thanks! On 11/15/2013 03:56 PM, Neil Horman wrote: On Fri, Nov 15, 2013 at 09:00:58AM -0500, Vlad Yasevich wrote: On 11/15/2013 07:30 AM, Neil Horman wrote: On Thu, Nov 14, 2013 at 09:34:55PM -0500, Vlad Yas

Re: [PATCH] net: sctp: recover a tranport when an ack comes

2013-11-15 Thread Vlad Yasevich
On 11/15/2013 07:30 AM, Neil Horman wrote: On Thu, Nov 14, 2013 at 09:34:55PM -0500, Vlad Yasevich wrote: On 11/14/2013 03:40 PM, Chang Xiangzhong wrote: Expected Behavior: When hearing an ack from a tranport/path, set its state to normal/on if it's in abnormal(__partial_failure__ or ina

Re: [PATCH] net: sctp: recover a tranport when an ack comes

2013-11-14 Thread Vlad Yasevich
On 11/14/2013 03:40 PM, Chang Xiangzhong wrote: Expected Behavior: When hearing an ack from a tranport/path, set its state to normal/on if it's in abnormal(__partial_failure__ or inactive) state. state machine of tranport->state Whenever a T3_RTX timer expires, then transport->error_count++. Whe

Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers

2013-11-13 Thread Vlad Yasevich
On 11/13/2013 03:48 PM, Chang wrote: On 11/13/2013 08:10 PM, Daniel Borkmann wrote: On 11/13/2013 08:06 PM, Chang wrote: On 11/13/2013 09:44 AM, Daniel Borkmann wrote: On 11/13/2013 03:54 AM, Chang wrote: On 11/13/2013 03:37 AM, Vlad Yasevich wrote: On 11/12/2013 08:34 PM, Chang Xiangzhong

Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers

2013-11-13 Thread Vlad Yasevich
On 11/12/2013 09:54 PM, Chang wrote: On 11/13/2013 03:37 AM, Vlad Yasevich wrote: On 11/12/2013 08:34 PM, Chang Xiangzhong wrote: Look for the __two__ most recently used path/transport and set to active_path and retran_path respectively Signed-off-by: changxiangzh...@gmail.com --- net/sctp

Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers

2013-11-12 Thread Vlad Yasevich
On 11/12/2013 08:34 PM, Chang Xiangzhong wrote: Look for the __two__ most recently used path/transport and set to active_path and retran_path respectively Signed-off-by: changxiangzh...@gmail.com --- net/sctp/associola.c |4 1 file changed, 4 insertions(+) diff --git a/net/sctp/asso

Re: [PATCH] Revert "bridge: only expire the mdb entry when query is received"

2013-10-22 Thread Vlad Yasevich
On 10/21/2013 06:45 PM, David Miller wrote: From: Linus Lüssing Date: Sun, 20 Oct 2013 00:58:57 +0200 While this commit was a good attempt to fix issues occuring when no multicast querier is present, this commit still has two more issues: 1) There are cases where mdb entries do not expire eve

Re: net: sctp: possible dereference after freeing

2013-10-19 Thread Vlad Yasevich
On Oct 19, 2013, at 7:49 AM, Geyslan Gregório Bem wrote: > 2013/10/19 Geyslan Gregório Bem : >> Hi maintainers, >> >> I would like to know if these are catches: >> >> /net/sctp/endpointola.c (281) >> static void sctp_endpoint_destroy(struct sctp_endpoint *ep) >> { >>struct sock *sk; >> ..

Re: linux-next: manual merge of the net-next tree

2013-10-18 Thread Vlad Yasevich
On 10/18/2013 08:58 AM, Mark Brown wrote: Today's linux-next merge of the next-next tree got a conflict in include/net/dst.h between e87b3998d (net: dst: provide accessor function to dst->xfrm) in the net tree and a4023dd01 (dst.h: Remove extern from function prototypes) in net-next. I've fixed

Re: [PATCH V2] For for each TSN t being newly acked (Not only cumulatively, but also SELECTIVELY) cacc_saw_newack should be set to 1.

2013-10-15 Thread Vlad Yasevich
On 10/15/2013 02:13 PM, Chang Xiangzhong wrote: Signed-off-by: Xiangzhong Chang Your proposed solution is very nice, but it does 2 things in one patch. 1) It fixes the bug 2) It refactors the code to improve the flow. While (2) is very nice, it needs a much more careful review. Can you plea

Re: [PATCH] For for each TSN t being newly acked (Not only cumulatively, but also SELECTIVELY) cacc_saw_newack should be set to 1.

2013-10-15 Thread Vlad Yasevich
On 10/15/2013 01:39 PM, Chang wrote: On 10/15/2013 07:25 PM, Vlad Yasevich wrote: On 10/15/2013 12:59 PM, Chang Xiangzhong wrote: Signed-off-by: Xiangzhong Chang --- net/sctp/outqueue.c | 142 --- 1 file changed, 68 insertions(+), 74

Re: [PATCH] For for each TSN t being newly acked (Not only cumulatively, but also SELECTIVELY) cacc_saw_newack should be set to 1.

2013-10-15 Thread Vlad Yasevich
On 10/15/2013 12:59 PM, Chang Xiangzhong wrote: Signed-off-by: Xiangzhong Chang --- net/sctp/outqueue.c | 142 --- 1 file changed, 68 insertions(+), 74 deletions(-) diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index 94df758..f10d848

Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue

2013-10-15 Thread Vlad Yasevich
On 10/15/2013 10:27 AM, Chang wrote: On 10/15/2013 04:11 PM, Vlad Yasevich wrote: On 10/14/2013 09:33 AM, Chang Xiangzhong wrote: For for each TSN t being newly acked (Not only cumulatively, but also SELECTIVELY) cacc_saw_newack should be set to 1. Signed-off-by: Xiangzhong Chang --- net

Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue

2013-10-15 Thread Vlad Yasevich
On 10/14/2013 09:33 AM, Chang Xiangzhong wrote: For for each TSN t being newly acked (Not only cumulatively, but also SELECTIVELY) cacc_saw_newack should be set to 1. Signed-off-by: Xiangzhong Chang --- net/sctp/outqueue.c | 42 +- 1 file changed, 21

Re: [PATCH 12/12] sctp: Remove extern from function prototypes

2013-09-23 Thread Vlad Yasevich
is as unnecessary as using auto to declare automatic/local variables in a block. Signed-off-by: Joe Perches looks simple enough. Acked-by: Vlad Yasevich -vlad --- include/net/sctp/sctp.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sct

Re: [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header

2013-08-13 Thread Vlad Yasevich
On 08/13/2013 06:54 PM, David Miller wrote: From: Vlad Yasevich Date: Mon, 12 Aug 2013 15:57:29 -0400 On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote: Fix the iproute2 command `bridge vlan show`, after switching from rtgenmsg to ifinfomsg. Signed-off-by: Asbjoern Sloth Toennesen

Re: [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header

2013-08-12 Thread Vlad Yasevich
On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote: Fix the iproute2 command `bridge vlan show`, after switching from rtgenmsg to ifinfomsg. Signed-off-by: Asbjoern Sloth Toennesen Thanks.. I've still been using an older iproute version and didn't see this. Reviewe

Re: [PATCH 12/13] sctp: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-02 Thread Vlad Yasevich
f-by: Yann Droneaud Acked-by: Vlad Yasevich -vlad --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 66fcdcf..caa5919 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -4320,7 +4320,7 @@

Re: sctp: hang in sctp_remaddr_seq_show

2013-03-18 Thread Vlad Yasevich
On 03/18/2013 04:32 PM, Neil Horman wrote: On Mon, Mar 18, 2013 at 11:31:06AM -0400, Vlad Yasevich wrote: On 03/18/2013 11:25 AM, Eric Dumazet wrote: On Mon, 2013-03-18 at 07:04 -0400, Neil Horman wrote: I'm not sure why the process would never get back to the schedule, but looking a

Re: sctp: hang in sctp_remaddr_seq_show

2013-03-18 Thread Vlad Yasevich
On 03/18/2013 11:25 AM, Eric Dumazet wrote: On Mon, 2013-03-18 at 07:04 -0400, Neil Horman wrote: I'm not sure why the process would never get back to the schedule, but looking at the sctp_remaddr_seq_show function, I think that we should convert this sequence: sctp_local_bh_disable();

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-13 Thread Vlad Yasevich
entry(chunk, &transport->transmitted, transmitted_list) { if (key == chunk->subh.data_hdr->tsn) { Acked-by: Vlad Yasevich -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-12 Thread Vlad Yasevich
On 03/12/2013 11:44 AM, Neil Horman wrote: On Tue, Mar 12, 2013 at 08:11:34AM -0400, Vlad Yasevich wrote: On 03/11/2013 09:31 AM, Neil Horman wrote: On Mon, Mar 11, 2013 at 10:14:50AM +0800, Xufeng Zhang wrote: On 3/8/13, Neil Horman wrote: On Fri, Mar 08, 2013 at 03:39:37PM +0800, Xufeng

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-12 Thread Vlad Yasevich
On 03/11/2013 09:31 AM, Neil Horman wrote: On Mon, Mar 11, 2013 at 10:14:50AM +0800, Xufeng Zhang wrote: On 3/8/13, Neil Horman wrote: On Fri, Mar 08, 2013 at 03:39:37PM +0800, Xufeng Zhang wrote: sctp_assoc_lookup_tsn() function searchs which transport a certain TSN was sent on, if not found

Re: [PATCH 4/4] sctp: fix association hangs due to partial delivery errors

2013-02-21 Thread Vlad Yasevich
On 02/21/2013 11:45 AM, Roberts, Lee A. wrote: From: Lee A. Roberts Resolve SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association reassembly and/or lobby (ordering) queues. Close examination of reas

Re: [PATCH 3/4] sctp: fix association hangs due to errors when reneging events from the ordering queue

2013-02-21 Thread Vlad Yasevich
: Vlad Yasevich -vlad --- net/sctp/ulpqueue.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff -uprN -X linux-3.8-vanilla/Documentation/dontdiff linux-3.8-SCTP+2/net/sctp/ulpqueue.c linux-3.8-SCTP+3/net/sctp/ulpqueue.c --- linux-3.8-SCTP+2/net/sctp

Re: [PATCH 2/4] sctp: fix association hangs due to reneging packets below the cumulative TSN ACK point

2013-02-21 Thread Vlad Yasevich
reassembly queue shows missing packets. In sctp_ulpq_renege_list(), do not renege packets below the cumulative TSN ACK point. Patch applies to linux-3.8 kernel. Signed-off-by: Lee A. Roberts Acked-by: Vlad Yasevich -vlad --- net/sctp/ulpqueue.c |9 +++-- 1 file changed, 7

Re: [PATCH 1/4] sctp: fix association hangs due to off-by-one errors in sctp_tsnmap_grow()

2013-02-21 Thread Vlad Yasevich
On 02/21/2013 11:44 AM, Roberts, Lee A. wrote: From: Lee A. Roberts Resolve SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association lobby (ordering) queue. Close examination of reassembly/ordering que

Re: [PATCH 3/3] sctp: fix association hangs due to reassembly/ordering logic

2013-02-20 Thread Vlad Yasevich
On 02/20/2013 02:24 PM, Roberts, Lee A. wrote: Vlad, -Original Message- From: Vlad Yasevich [mailto:vyasev...@gmail.com] Sent: Wednesday, February 20, 2013 11:06 AM To: Roberts, Lee A. Cc: linux-s...@vger.kernel.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org Subject: Re

Re: [PATCH 3/3] sctp: fix association hangs due to reassembly/ordering logic

2013-02-20 Thread Vlad Yasevich
Hi Lee On 02/20/2013 10:56 AM, Roberts, Lee A. wrote: From: Lee A. Roberts Resolve SCTP association hangs observed during SCTP stress testing. Observable symptoms include communications hangs with data being held in the association reassembly and/or lobby (ordering) queues. Close examination

  1   2   >