gt; + int idx;
lets move it to top of the function please
> +static inline u64 perfmon_pmu_read_counter(struct perf_event *event)
> +{
> + struct hw_perf_event *hwc = &event->hw;
> + struct idxd_device *idxd;
> + int cntr = hwc->idx;
> + u64 cntrdata;
> +
> + idxd = event_to_idxd(event);
> +
> + cntrdata = ioread64(CNTRDATA_REG(idxd, cntr));
> +
> + return cntrdata;
return ioread64() ?
--
~Vinod
On 07-04-21, 21:25, YueHaibing wrote:
> commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.
Applied, thanks
--
~Vinod
tatus
> pointer sometimes as there is a later assignment to *status where
> status is first null checked. Fix the issue by null checking status
> before making the assignment.
Applied, thanks
--
~Vinod
nged, 109 insertions(+), 53 deletions(-)
Thanks
--
~Vinod
signature.asc
Description: PGP signature
phy: ti: j721e-wiz: Add missing include linux/slab.h
Vinod Koul (1):
phy: Revert "phy: ti: j721e-wiz: add missing of_node_put"
Yang Yingliang (1):
phy: phy-twl4030-usb: Fix possible use-after-free in twl4030_usb_remove()
drivers/phy/ti/phy-j721e-wiz.c | 2 +-
driver
dual
licensed, so it kind of followed that..
> If there is no specific reason for this contribution to be dual
> licensed, please make it GPL-2.0 only.
This module, I would say NO. Unless someone from Intel disagree..
Pierre/Bard..?
If all agree I dont see a reason why this cant be updated to GPL only.
Thanks
--
~Vinod
On 01-04-21, 19:50, Hao Fang wrote:
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to the official website.
Applied, thanks
--
~Vinod
On 01-04-21, 17:53, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/dma/qcom/hidma.c:94:20: warning: unused function 'to_hidma_desc'
> [-Wunused-function].
Applied, thanks
--
~Vinod
On 23-03-21, 16:19, Dan Carpenter wrote:
> Add a missing put_device(&pdev->dev) if the call to
> dma_async_device_register(dma); fails.
Applied, thanks
--
~Vinod
t;terminated);
> sdmac->desc = NULL;
> schedule_work(&sdmac->terminate_worker);
> }
> @@ -2075,6 +2077,7 @@ static int sdma_probe(struct platform_device *pdev)
>
> sdmac->channel = i;
> sdmac->vc.desc_free = sdma_desc_free;
> + INIT_LIST_HEAD(&sdmac->terminated);
> INIT_WORK(&sdmac->terminate_worker,
> sdma_channel_terminate_work);
> /*
> --
> 2.7.4
--
~Vinod
runtime
> PM counter on error.
Applied, thanks
--
~Vinod
is forget to set chan->local to NULL when
> chan->local was freed in __dma_async_device_channel_register(). My
> patch sets chan->local to NULL when the callee failed to avoid double free.
Applied after fixing subsystem name, thanks
--
~Vinod
On 24-03-21, 16:17, Andy Shevchenko wrote:
> Some architectures do not provide devm_*() APIs. Hence make the driver
> dependent on HAVE_IOMEM.
Applied, thanks
--
~Vinod
free’? [-Werror=implicit-function-declaration]
> 697 | kfree(parent_names);
> | ^
> | vfre
Applied, thanks
--
~Vinod
finished, which would result in a use-after-free.
>
> Fix by calling cancel_delayed_work_sync(), which ensures that
> the work is properly cancelled, no longer running, and unable
> to re-schedule itself.
Applied, thanks
--
~Vinod
ion interfaces
phy: Add Sparx5 ethernet serdes PHY driver
phy: Sparx5 Eth SerDes: Use direct register operations
Swapnil Jakhade (2):
phy: cadence-torrent: Update PCIe + QSGMII config for correct PLL1 clock
phy: cadence-torrent: Update PCIe + USB config for correct PLL1 clock
tly in qcom_swrm_transport_params
Vinod Koul (2):
soundwire: add override addr ops
soundwire: qcom: use signed variable for error return
.../devicetree/bindings/soundwire/qcom,sdw.txt | 20 +
drivers/soundwire/Makefile | 2 +-
drivers/soundwire
On 29-03-21, 16:13, Steen Hegelund wrote:
> Use direct register operations instead of a table of register
> information to lower the stack usage.
Applied, thanks
--
~Vinod
On 01-04-21, 20:02, Hao Fang wrote:
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to the official website.
Applied, thanks
--
~Vinod
p110-utmi.o: in function
> `mvebu_cp110_utmi_phy_probe':
> phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to
> `of_usb_get_dr_mode_by_phy'
Applied, thanks
--
~Vinod
r dereference" error.
Applied, thanks
--
~Vinod
On 01-04-21, 10:15, Srinivas Kandagatla wrote:
> Looks like return from reg_write is set but not checked.
> Fix this by adding error return path.
Applied, thanks
--
~Vinod
On 01-04-21, 10:00, Srinivas Kandagatla wrote:
> If we write registers very fast we can endup in a situation where some
> of the writes will be dropped without any notice.
>
> So wait for the fifo space to be available before reading/writing the
> soundwire registers.
Applied, thanks
--
~Vinod
g has been recently done with din/dout_port_mask.
Applied, thanks
--
~Vinod
On 01-04-21, 12:15, Robert Foss wrote:
> RNG (Random Number Generator) in SM8350 features PRNG EE (Execution
> Environment), hence add devicetree support for it.
Reviewed-by: Vinod Koul
--
~Vinod
Add interconnect nodes and add them for modem and cdsp nodes
Signed-off-by: Vinod Koul
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 79
1 file changed, 79 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi
b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index
dev_err(dev, fmt, __VA_ARGS__); \
> + else\
> + dev_dbg(dev, fmt, __VA_ARGS__); \
> + } while (0)
I see a variant in sof code and now here, why not add in a
dev_dbg_or_err() and use everywhere?
Thanks
--
~Vinod
++
> include/linux/soundwire/sdw.h | 2 ++
> sound/soc/codecs/wsa881x.c | 7 +
> 4 files changed, 43 insertions(+), 6 deletions(-)
>
> --
> 2.21.0
--
~Vinod
nter dereference" error.
This fails to apply for me
--
~Vinod
to fix the memory leak.
Applied, thanks
--
~Vinod
rn 0;
maybe the comment should say, check for space in write fifo?
> +
> + do {
> + usleep_range(500, 510);
> + swrm->reg_read(swrm, SWRM_CMD_FIFO_STATUS, &value);
> + fifo_outstanding_cmd = FIELD_GET(SWRM_WR_CMD_FIFO_CNT_MASK,
> value);
> + if (fifo_outstanding_cmd < swrm->wr_fifo_depth)
> + break;
> + } while (fifo_retry_count--);
> +
> + if (fifo_outstanding_cmd == swrm->wr_fifo_depth) {
> + dev_err_ratelimited(swrm->dev, "%s err write overflow\n",
> __func__);
> + return -ENOMEM;
EIO or better error code here too
--
~Vinod
On 31-03-21, 18:16, Dmitry Baryshkov wrote:
> Changes since v5:
> - Rebase on top of phy-next
> - Rework 'move DP functions to callbacks' patch to leave most of the
>code in place, using function prototypes.
Applied 1 thru 5, thanks
Bjorn you can pick the dts bits.
--
~Vinod
/soundwire/qcom.c: qcom_swrm_irq_handler() warn: impossible
condition '(devnum < 0) => (0-255 < 0)'
Reported-by: kernel test robot
Signed-off-by: Vinod Koul
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c
On 31-03-21, 09:41, Pierre-Louis Bossart wrote:
>
>
> On 3/31/21 2:21 AM, Vinod Koul wrote:
> > We get warning for using a unsigned variable being compared to less than
> > zero. The comparison is correct as it checks for errors from previous
> > call to qcom_swrm_ge
On 31-03-21, 18:44, Kishon Vijay Abraham I wrote:
> Configure 'p_standard_mode' only for DP/QSGMII as for other modes
> it's not used as per the programming sequence. Add "continue" in the
> else to prevent random value from being written to p_standard_mode.
Applied, thanks
--
~Vinod
>
> -MODULE_DESCRIPTION("Hisilicon k3 DMA Driver");
> +MODULE_DESCRIPTION("HiSilicon k3 DMA Driver");
> MODULE_ALIAS("platform:k3dma");
> MODULE_LICENSE("GPL v2");
> --
> 2.8.1
--
~Vinod
On 31-03-21, 17:10, Pratyush Yadav wrote:
> On 31/03/21 03:03PM, Vinod Koul wrote:
> > On 30-03-21, 23:03, Pratyush Yadav wrote:
> > > Hi,
> > >
> > > This series adds support for CSI2 capture on J721E. It includes some
> > > fixes to the Cadence C
On 19-03-21, 10:34, Seiya Wang wrote:
> This commit fixes the warning messages of make dt_binding_check from
> newly added mediatek,mt8195-ufsphy in mediatek,ufs-phy.yaml
Applied, thanks
--
~Vinod
On 24-03-21, 17:48, Manish Narani wrote:
> The current driver is not handling the clock enable/disable operations
> properly. The clocks need to be handled correctly by enabling or
> disabling at appropriate places. This patch adds code to handle the
> same.
Applied, thanks
--
~Vinod
On 25-03-21, 19:05, Mauro Carvalho Chehab wrote:
> The phy USB3 driver for Hisilicon 970 (hi3670) is ready
> for mainstream. Mode it from staging into the main driver's
> phy/ directory.
Overall lgtm, some nits below. With those fixed:
Acked-By: Vinod Koul
> +static int
a/drivers/phy/hisilicon/phy-hix5hd2-sata.c
> +++ b/drivers/phy/hisilicon/phy-hix5hd2-sata.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2014 Linaro Ltd.
> - * Copyright (c) 2014 Hisilicon Limited.
> + * Copyright (c) 2014 HiSilicon Limited.
> */
>
> #include
> --
> 2.8.1
--
~Vinod
tree
>
> The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15:
>
> Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)
This should be based on phy-next. This fails to apply for me. Can you
please rebase and acks and resend
Thanks
--
~Vinod
On 31-03-21, 10:19, Geert Uytterhoeven wrote:
> The Microchip Sparx5 SerDes PHY is present only Microchip Sparx5 SoCs.
> Hence add a dependency on ARCH_SPARX5, to prevent asking the user about
> this driver when configuring a kernel without support for Sparx5 SoCs.
Applied, thanks
--
~Vinod
part
> would be sent later.
Applied, thanks
--
~Vinod
can be found @ [5]
> v5 of the patch series can be found @ [6]
> v6 of the patch series can be found @ [7]
Applied, thanks. I was able to resolve the conflict on patch 4, please
check it was fine
--
~Vinod
reate mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> create mode 100644 drivers/media/platform/ti-vpe/ti-csi2rx.c
>
> --
> 2.30.0
--
~Vinod
: impossible
condition '(devnum < 0) => (0-255 < 0)'
Reported-by: kernel test robot
Signed-off-by: Vinod Koul
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index b08ecb9b418c..55ed13
n
> top of this.
Applied, thanks
--
~Vinod
].
>However the existing method to model clocks from device tree is not
>removed to support upstreamed device tree.
> *) Included a patch to fix modifying static data by instance specific
>initializations.
> *) Added a fix to delete "clk_div_sel" clk provider during cleanup
Applied, thanks
--
~Vinod
eliminates kernel configuration dependency from the boot
> loader.
Applied 1-3, thanks
--
~Vinod
!
Droped the series now
--
~Vinod
soundwire
>
> So this patchset add various improvements to the existing driver
> to address above issues.
>
> Tested it on SM8250 MTP with 2x WSA881x speakers, HeadPhones on
> WCD938x via lpass-rx-macro and Analog MICs via lpass-tx-macro.
> Also tested on DragonBoard DB845c with 2xWSA881x speakers.
Applied, thanks
--
~Vinod
luding a timeout), or if the devices throw a
> COMMAND_FAILED response.
Applied, thanks
--
~Vinod
On 15-03-21, 16:56, Srinivas Kandagatla wrote:
> WSA881x SoundWire device ports are statically assigned to master ports
> at design time. So add bindings required to specify these mappings!
Mark, are you okay for 4, 5 to go thru sdw tree with your ack? The
patches lgtm
--
~Vinod
break;
> + case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> + case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> + dev_err_ratelimited(swrm->dev, "%s: SWR new
> slave attached\n",
> + __func__);
This should be debug
--
~Vinod
else {
> ret = SDW_CMD_OK;
> }
Maybe add a comment here that we dont get status so write is assumed to
be OK
--
~Vinod
MAINTAINERS entry for ICC is missing the tree details, so add it
Signed-off-by: Vinod Koul
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6de606aeb9b1..e3f37d0b6de9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9290,6 +9290,7 @@ INTERCONNECT
On 25-03-21, 15:00, Thierry Reding wrote:
> On Thu, Mar 25, 2021 at 11:45:16AM +0530, Vinod Koul wrote:
> > On 24-03-21, 14:32, Thierry Reding wrote:
> > > Also adding Vinod for visibility and in case Kishon's too busy.
> >
> > Yes please CC me on all things ph
gt;
> [1]
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#in-line-member-documentation-comments
It 'may be' but I would like all headers of a subsystem to display one
style. As I said linux/phy/phy.h use a style which we should use
everywhere.
Thanks
--
~Vinod
On 19-03-21, 04:36, menglong8.d...@gmail.com wrote:
> From: Zhang Yunkai
>
> 'HSUSB_CTRL_DPSEHV_CLAMP' in 'val' is duplicated.
Applied, thanks
--
~Vinod
On 21-03-21, 02:10, Bhaskar Chowdhury wrote:
>
> s/subsytem/subsystem/
Applied, thanks
--
~Vinod
On 17-03-21, 16:31, Sandeep Maheswaram wrote:
> Add the compatible string for sc7280 SoC from Qualcomm
Applied, thanks
--
~Vinod
On 16-03-21, 17:22, Chunfeng Yun wrote:
> The phy may be named as pcie-phy when the T-PHY only supports
> PCIe mode, it's also the similar case for SATA, named as
> sata-phy.
Applied, thanks
--
~Vinod
make dependence clear.
Applied, thanks
--
~Vinod
On 16-03-21, 17:22, Chunfeng Yun wrote:
> mt7623-mipi-tx is compatible to mt2701-mipi-tx, and use
> "mediatek,mt2701-mipi-tx" instead on MT7623, so modify
> the compatible items to make dependence clear.
Applied, thanks
--
~Vinod
branches with the correct
> > > > dependencies and send out pull requests for the three subsystems if
> > > > that's preferrable.
> > >
> > > I have no objection for the usb patches to go through your tree as they
> > > are hardware-specifi
On 12-03-21, 11:28, Bjorn Andersson wrote:
> On Thu 11 Mar 23:12 CST 2021, Vinod Koul wrote:
>
> Adding Jassi as recipient. Please let Vinod know if you want him to
> resend this patch to you. (I send a patch for MAINTAINERS yesterday)
Jassi, should I resend or you can pick from lore
On 23-03-21, 12:29, Pierre-Louis Bossart wrote:
> Thanks Greg and Vinod for the reviews
>
> > > > -static int intel_master_probe(struct platform_device *pdev)
> > > > +static int intel_link_probe(struct auxiliary_device *auxdev, const
> >
+
> + mutex_lock(&bus->bus_lock);
> + list_add_tail(&slave->node, &bus->slaves);
> + mutex_unlock(&bus->bus_lock);
> +
> sdw_slave_debugfs_init(slave);
>
> return ret;
> --
> 2.17.1
--
~Vinod
On 23-03-21, 08:58, Bard Liao wrote:
> We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
> adding new ones...
Applied, thanks
--
~Vinod
em *registers;
> void __iomem *shim;
> @@ -48,7 +46,15 @@ struct sdw_intel {
> #endif
> };
>
> -int intel_master_startup(struct platform_device *pdev);
> -int intel_master_process_wakeen_event(struct platform_device *pdev);
> +int intel_link_startup(struct auxiliary_device *auxdev);
> +int intel_link_process_wakeen_event(struct auxiliary_device *auxdev);
> +
> +struct sdw_intel_link_dev {
> + struct auxiliary_device auxdev;
> + struct sdw_intel_link_res link_res;
> +};
I was hoping that with auxdev we can get rid of this init layer, can
that still be done?
The auxdev is created by Intel controller, so it sets up resources. I am
not really happy that we need to continue having this layer.. can we add
something is auxdev core to handle these situations.
What I would like to see the end result is that sdw driver for Intel
controller here is a simple auxdev device and no additional custom setup
layer required... which implies that this handling should be moved into
auxdev or Intel code setting up auxdev...
--
~Vinod
On 22-03-21, 11:04, Robert Foss wrote:
> Add tsens bindings for sm8350.
Reviewed-by: Vinod Koul
--
~Vinod
On 22-03-21, 11:04, Robert Foss wrote:
> sm8350 has 29 thermal sensors split across two tsens controllers. Add
> the thermal zones to expose them and wireup the cpus to throttle their
> frequencies on crossing passive temperature thresholds.
Reviewed-by: Vinod Koul
--
~Vinod
rated on the
> bus but not in device list. So reset this correctly to fix this issue!
Applied, thanks
--
~Vinod
lso be
> board-dependent and hence dealing with a Master quirk is simpler.
I think this is fine approach to deal with quirks... Controllers can set
the quirk as required. I have fixed up blank line in patch 1 and applied
--
~Vinod
parity errors but will leave
> + * the detection on should real parity errors happen.
> + */
> +#define SDW_MASTER_QUIRKS_CLEAR_INITIAL_PARITY BIT(1)
> +
> int sdw_master_read_prop(struct sdw_bus *bus);
> int sdw_slave_read_prop(struct sdw_slave *slave);
>
> --
> 2.17.1
--
~Vinod
On 02-03-21, 15:51, Bard Liao wrote:
> Platform firmware may have incorrect _ADR values causing the driver
> probes to fail. Adding the override_ops allows people to override the
> addr values.
Applied, thanks
--
~Vinod
a_pool_create() and in debugfs.
Why do you need that, why not use device name which is unique..?
> Also, I have implemented all of the comments for this patch except
> this. if this is fine, will send the next version for review.
Am not sure I remember all the comments I gave, it has been _quite_ a
while since the feedback was provided. In order to have effective review
it would be great to revert back on a reasonable timeline and discuss...
Thanks
--
~Vinod
On 20-03-21, 17:16, Caleb Connolly wrote:
> Hi Vinod,
>
> On 16/03/2021 6:15 am, Vinod Koul wrote:
> > On 10-03-21, 16:31, Caleb Connolly wrote:
> >> Hook up the SMMU for doing DMA over i2c. Some peripherals like
> >> touchscreens easily exceed 32-bytes
On 11-03-21, 16:33, Bjorn Andersson wrote:
> The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others
> needs
> platform-, and perhaps even board-, specific firmware. Add support for
> providing this in devicetree.
Reviewed-by: Vinod Koul
--
~Vinod
Signed-off-by: Vinod Koul
---
drivers/interconnect/qcom/Kconfig | 9 +
drivers/interconnect/qcom/Makefile | 2 +
drivers/interconnect/qcom/sm8350.c | 633 +
drivers/interconnect/qcom/sm8350.h | 168
4 files changed, 812 insertions(+)
create mode 100644
The Qualcomm SM8350 platform has several bus fabrics that could be
controlled and tuned dynamically according to the bandwidth demand.
Signed-off-by: Vinod Koul
---
.../bindings/interconnect/qcom,rpmh.yaml | 10 +
.../dt-bindings/interconnect/qcom,sm8350.h| 172 ++
2
This adds support for interconnect support for SM8350 SoC
Changes since v2:
- Plug gaps in indexes
- fix typo in commit log for patch2 and kconfig depends (for real this time)
Changes since v1:
- Fix comments by Georgi, split the header
- Fix the macro for qns_llcc
Vinod Koul (2):
dt
On 18-03-21, 09:08, Georgi Djakov wrote:
> Hi Vinod,
>
> On 3/2/21 15:43, Vinod Koul wrote:
> > Add driver for the Qualcomm interconnect buses found in SM8i350 based
>
> Still SM8i350? Have you checked my comments on v1?
Oops missed to fix the commit
Hello Georgi,
On 18-03-21, 09:08, Georgi Djakov wrote:
> Hi Vinod,
> > +#define MASTER_GEM_NOC_CNOC1
>
> Maybe start from zero?
Yeah not sure how that got missed
> > +#define MASTER_CAMNOC_HF 0
> > +#define MASTER_CAMNOC_ICP
arameters
> should cover all potential users.
>
> Cc: Kishon Vijay Abraham I
> Cc: Vinod Koul
> Cc: NXP Linux Team
> Reviewed-by: Robert Foss
> Signed-off-by: Liu Ying
> ---
> v3->v4:
> * Add Robert's R-b tag.
>
> v2->v3:
> * No change.
);
> + if (IS_ERR(priv->grf)) {
> + dev_err(dev, "Can't find GRF syscon\n");
> + return PTR_ERR(priv->grf);
> + }
> +
> + priv->phy_base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->phy_base))
> + return PTR_ERR(priv->phy_base);
> +
> + priv->pclk = devm_clk_get(dev, "pclk");
> + if (IS_ERR(priv->pclk)) {
> + dev_err(dev, "failed to get pclk\n");
> + return PTR_ERR(priv->pclk);
> + }
> +
> + priv->rst = devm_reset_control_get(dev, "apb");
> + if (IS_ERR(priv->rst)) {
> + dev_err(dev, "failed to get system reset control\n");
> + return PTR_ERR(priv->rst);
> + }
> +
> + phy = devm_phy_create(dev, NULL, &rockchip_inno_csidphy_ops);
> + if (IS_ERR(phy)) {
> + dev_err(dev, "failed to create phy\n");
> + return PTR_ERR(phy);
> + }
> +
> + phy_set_drvdata(phy, priv);
> +
> + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> + if (IS_ERR(phy_provider)) {
> + dev_err(dev, "failed to register phy provider\n");
> + return PTR_ERR(phy_provider);
> + }
> +
> + pm_runtime_enable(dev);
> +
> + return 0;
> +}
> +
> +static int rockchip_inno_csidphy_remove(struct platform_device *pdev)
> +{
> + struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev);
> +
> + pm_runtime_disable(priv->dev);
> +
> + return 0;
> +}
> +
> +static struct platform_driver rockchip_inno_csidphy_driver = {
> + .driver = {
> + .name = "rockchip-inno-csidphy",
> + .of_match_table = rockchip_inno_csidphy_match_id,
double indent here?
> + },
> + .probe = rockchip_inno_csidphy_probe,
> + .remove = rockchip_inno_csidphy_remove,
> +};
> +
> +module_platform_driver(rockchip_inno_csidphy_driver);
> +MODULE_AUTHOR("Heiko Stuebner ");
> +MODULE_DESCRIPTION("Rockchip MIPI Innosilicon CSI-DPHY driver");
> +MODULE_LICENSE("Dual BSD/GPL");
That is not what the SPDX tag for file says?
--
~Vinod
i.yaml | 2 +-
> .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +-
...
> .../bindings/phy/ti,phy-j721e-wiz.yaml | 2 +-
Acked-By: Vinod Koul
--
~Vinod
; The Sparx5 serdes support several interface modes with several speeds and also
> allows the client to change the mode and the speed according to changing in
> the
> environment such as changing cables from DAC to fiber.
Applied patch 1 thru 3... thanks
--
~Vinod
On 16-03-21, 19:14, Seiya Wang wrote:
> This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> Platform.
Applied, thanks
--
~Vinod
On 16-03-21, 19:14, Seiya Wang wrote:
> This commit adds dt-binding documentation of T-Phy for Mediatek MT8195 SoC
> Platform.
Applied, thanks
--
~Vinod
This should be after the --- line below
>
> Signed-off-by: Kuogee Hsieh
No need of blank line here
>
> Reviewed-by: Stephen Boyd
I took the liberty of fixing these two, applying the fixes tag and
applied..
--
~Vinod
On 10-03-21, 16:57, Kishon Vijay Abraham I wrote:
> Patch series adds device tree bindings to support SERDES in AM64
> platform.
>
> This is split from [1] since this binding is also required for AM64
> USB DT patches to be merged.
>
> Vinod,
>
> Once the 1st patch o
Hello Martin,
On 16-03-21, 21:21, Martin K. Petersen wrote:
>
> Vinod,
>
> >> Document "qcom,sm8250-ufshc" and "qcom,sm8350-ufshc" compatible string.
> >> Use of "qcom,sm8250-ufshc" is already present upstream, so add misiing
> >>
loading/unloading driver
> - memory space definition for the data area and for the linked list space
> - scatter-gather address calculation on 32 bits platforms
> - minor comment and variable reordering
Applied, thanks
--
~Vinod
On 10-03-21, 16:31, Caleb Connolly wrote:
> Tested on the OnePlus 7 Pro (including DMA).
Lgtm:
Reviewed-by: Vinod Koul
But missing enabling nodes in board dts ..?
>
> Signed-off-by: Caleb Connolly
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 521 ++
ranges;
> @@ -617,6 +619,7 @@ qupv3_id_2: geniqup@cc {
> clock-names = "m-ahb", "s-ahb";
> clocks = <&gcc GCC_QUPV3_WRAP_2_M_AHB_CLK>,
> <&gcc GCC_QUPV3_WRAP_2_S_AHB_CLK>;
> + iommus = <&apps_smmu 0x7a3 0x0>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> --
> 2.29.2
>
--
~Vinod
Hello Steen,
On 15-03-21, 16:04, Steen Hegelund wrote:
> Hi Kishon, Vinod, Andrew, Jacub, and David,
>
> I just wanted to know if you think that the Generic PHY subsystem might
> not be the right place for this Ethernet SerDes PHY driver after all.
>
> Originally I chose
from example (noticed by dt_binding_check)
> > 4. Specify license
> >
> > Signed-off-by: Rafał Miłecki
> > ---
> > I think this should go through linux-phy tree. Kishon, Vinod, can you
> > take this patch?
> >
> > This patch generates a false positive c
On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().
Applied, thanks
--
~Vinod
1 - 100 of 2204 matches
Mail list logo
