Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
On 08/11/2015 08:13 AM, sdliy...@gmail.com wrote: From: Yong Li When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li Acked-by: Varka Bhadram --- drivers/net/ieee802154/cc2520.c | 1

Re: [PATCHv1 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
; git format-patch --subject-prefix="PATCH v2 bluetooth-next" -1 git send-email 0001- -- Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-26 Thread Varka Bhadram
/pwm-crc.c | 143 ++ 3 files changed, 151 insertions(+) create mode 100644 drivers/pwm/pwm-crc.c Reviewed-by: Varka Bhadram -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Varka Bhadram
Borneo To: Alan Ott To: Alexander Aring To: Varka Bhadram To: linux-w...@vger.kernel.org To: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ieee802154/cc2520.c | 1 - drivers/net/ieee802154/mrf24j40.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net

Re: [v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver

2015-06-22 Thread Varka Bhadram
+ .driver = { + .name = "crystal_cove_pwm", + }, +}; + +builtin_platform_driver(crystalcove_pwm_driver); -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM

2015-06-22 Thread Varka Bhadram
Kumar --- Here you add this change history so that after applying this will not be the part of your commit description. This comment is applicable for all of your patches. -- Best regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Plea

Re: [PATCH] usb: image: mdc800: fixed various style issues

2015-04-24 Thread Varka Bhadram
return -EIO; > } > - mdc800->state=READY; > - break; > + } > + mdc800->state = READY; > +

Re: [PATCH v7 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-04-24 Thread Varka Bhadram
| 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-ktd2692.c| 435 > + > 5 files changed, 493 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds

Re: [PATCH v4 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-03-24 Thread Varka Bhadram
flash timeout ranges from 0 to 1835000us and + default is 1049000us. + +Example: + +flash-led { + compatible = "kinetic,ktd2692"; + ctrl-gpio = <&gpc0 1 0>; + aux-gpio = <&gpc0 2 0>; + flash-timeout-us = &

Re: [PATCH v4 3/3] leds: Add ktd2692 flash LED driver

2015-03-24 Thread Varka Bhadram
.name = "leds-ktd2692", + .of_match_table = ktd2692_match, + }, + .probe = ktd2692_probe, + .remove = ktd2692_remove, +}; + +module_platform_driver(ktd2692_driver); + +MODULE_AUTHOR("Ingi Kim "); +MODULE_DESCRIPTION("Kinetic KTD2692 LED driver"); +MODULE_LICENSE("GPL v2"); -- Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram
ata: DT Node found\n"); ov2659_get_pdata: DT Node *not* found...? -- Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-20 Thread Varka Bhadram
err(&client->dev, "wrong device for driver\n"); + goto err_free_irq; + } + dev_info(&client->dev, + "accelerometer driver loaded. device id %x\n", byte); + + return 0; + + err_free_irq: + if (mma->irq) +

Re: [PATCH 3/3] leds: Add ktd2692 flash LED driver

2015-02-26 Thread Varka Bhadram
&led->cdev); > + if (ret) { > + dev_err(dev, "couldn't register LED %s\n", led->cdev.name); > + return ret; > + } > + > + ret = ktd2692_brightness_set_gpio(led); > + if (ret) { > + led_classdev_unregister(&led->cdev); > + return ret; > + } > + > + ktd2692_expresswire_re

Re: [PATCH 2/2] drivers: isdn: icn: icn.h Clean up trivial checkpatch errors.

2015-02-07 Thread Varka Bhadram
Hi, On Saturday 07 February 2015 09:26 PM, Bas Peters wrote: Missed Signed-off-by line... --- drivers/isdn/icn/icn.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH 1/2] drivers: isdn: icn: icn.c: clean up all checkpatch errors

2015-02-07 Thread Varka Bhadram
++ 1 file changed, 31 insertions(+), 21 deletions(-) -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
On Thursday 29 January 2015 08:56 PM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Originally-by: Lanqing Liu Signed-off

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Varka Bhadram
up->mapbase = res->start; + up->membase = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(up->membase)) + return PTR_ERR(up->membase); + -- Thanks, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Varka Bhadram
ed-off-by: Javier Martinez Canillas > --- > > Changes since v3: > - Rename MYNAME to DRV_NAME > - Use devm_request_region() instead of request_region. >Suggested by Varka Bhadram. > - Remove release_region from cleanup handle logic by using devres API. >Sugge

Re: [PATCH] gpio: mmp: add GPIO driver for Marvell MMP series

2015-01-27 Thread Varka Bhadram
} > + ret = clk_prepare_enable(clk); > + if (ret) { > + dev_err(dev, "Fail to enable gpio clock, error %d.\n", ret); > + return ret; > + } > + > + domain = irq_domain_add_linear(np, mmp_chip->ngpio, > +

Re: [PATCH bluetooth-next] ieee802154: cc2520: Fix space before , coding style issue

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:25 PM, Mohammad Jamal wrote: This patch removes the warnings (space before , ) shown by checkpatch.pl Thanks for the patch. Acked-by: Varka Bhadram Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |4 ++-- 1 file changed, 2

Re: [PATCH bluetooth-next] ieee802154: cc2520: Replace shift operations by BIT macro

2015-01-26 Thread Varka Bhadram
Hi Jamal, On Friday 23 January 2015 07:28 PM, Mohammad Jamal wrote: This patch replaces the shifting operations by BIT macro Thanks for the patch. Acked-by: Varka Bhadram Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 +++--- 1 file changed, 3 insertions

Re: [PATCH] net: ieee802154: cc2520: fix coding style issue

2015-01-23 Thread Varka Bhadram
5 > Please work on bluetooth-next[1] tree and also include 'bluetooth-next' tag for the patch. [1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/ -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Varka Bhadram
if (ret) > goto err_hw_init; > > - > gpio_set_value(pdata->vreg, HIGH); > usleep_range(100, 150); > > -- > 1.7.9.5 > -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Varka Bhadram
ne if you use devres API.. > +failed_memmap: > + return err; > +} > + > +static int cros_ec_lpc_remove(struct platform_device *pdev) > +{ > + struct cros_ec_device *ec_dev; > + > + ec_dev = platform_get_drvdata(pdev); > + cros_ec_remove(ec_de

Re: [PATCH v6 5/7] power: Add support for DA9150 Charger

2015-01-21 Thread Varka Bhadram
g; + int ret; + + charger = devm_kzalloc(dev, sizeof(struct da9150_charger), GFP_KERNEL); + if (charger == NULL) + return -ENOMEM; sizeof(struct da9150_charger) can be replaced with sizeof(*charger)... *!* operator can be used in comparison with NULL... (...) -- Than

Re: [PATCH v6 3/7] iio: Add support for DA9150 GPADC

2015-01-21 Thread Varka Bhadram
tly use *dev* instead of *&pdev->dev* -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram
ilink", > + .owner = THIS_MODULE, No need to update this field. It will be updated by driver core. > + .of_match_table = of_match_ptr(btwilink_of_match), > }, > }; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line &

Re: [PATCHv5 3/9] devfreq: event: Add exynos-ppmu devfreq-event driver

2014-12-22 Thread Varka Bhadram
+ .owner = THIS_MODULE, remove owner field. It will be populate by driver core. > + .of_match_table = exynos_ppmu_id_match, > + }, > +}; > +module_platform_driver(exynos_ppmu_driver); > + > +MODULE_DESCRIPTION("Exynos PPMU(Platform Performance Monitoring Unit) > driver"); > +MODULE_AUTHOR("Chanwoo Choi "); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:exynos-ppmu"); > -- > 1.8.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe

2014-12-22 Thread Varka Bhadram
Thanks for the patch. Acked-by: Varka Bhadram On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram wrote: > > Thanks for the patch. > > Acked-by: Varka Bhadram > > On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang wrote: >> >> Since commit ab78029ecc34 (drivers/pinc

Re: [PATCH v5 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-12-13 Thread Varka Bhadram
return ret; +} + +static u32 cy_i2c_func(struct i2c_adapter *adapter) +{ + return I2C_FUNC_I2C; +} + +static const struct i2c_algorithm i2c_cyusbs23x_algorithm = { + .master_xfer= cy_i2c_xfer, + .functionality = cy_i2c_func, +}; + +static int cyusbs23x_i2c_probe(struct platfo

Re: [PATCH v5 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-12-13 Thread Varka Bhadram
/ + cy_gpio->gpio.label = dev_name(&pdev->dev); + cy_gpio->gpio.dev = &pdev->dev; + cy_gpio->gpio.owner = THIS_MODULE; + cy_gpio->gpio.base = -1; + cy_gpio->gpio.ngpio = CYUSBS234_GPIO_NUM; + cy_gpio->gpio.can_sleep = true; + cy_gpio->gp

Re: [PATCH 2/4] i2c: iproc: Add Broadcom iProc I2C Driver

2014-12-09 Thread Varka Bhadram
ev = platform_get_drvdata(pdev); + + i2c_del_adapter(&dev->adapter); + bcm_iproc_i2c_disable(dev); + + return 0; +} + +static const struct of_device_id bcm_iproc_i2c_of_match[] = { + {.compatible = "brcm,iproc-i2c",}, + {}, +}; +MODULE_DEVICE_TABLE(of, bcm_iproc_i2c_of_match); + +static struct platform_driver bcm_iproc_i2c_driver = { + .driver = { + .name = "bcm-iproc-i2c", + .owner = THIS_MODULE, No need to update this field. Its updated by module_platform_driver(). + .of_match_table = bcm_iproc_i2c_of_match, + }, + .probe = bcm_iproc_i2c_probe, + .remove = bcm_iproc_i2c_remove, +}; +module_platform_driver(bcm_iproc_i2c_driver); + +MODULE_AUTHOR("Ray Jui "); +MODULE_DESCRIPTION("Broadcom iProc I2C Driver"); +MODULE_LICENSE("GPL v2"); -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/4] i2c: iProc: define Broadcom iProc I2C binding

2014-12-09 Thread Varka Bhadram
ith single line statement, like: compatible: Must be "brcm,iproc-i2c" reg:Define the base and range of the I/O address space that contain the iProc I2C controller registers -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send t

Re: [PATCH] mtd: remove .owner field for driver using module_platform_driver

2014-11-11 Thread Varka Bhadram
/remove_owner -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-10-27 Thread Varka Bhadram
struct sky81452_bl_platform_data *pdata; + int ret; + + if (!np) { + dev_err(dev, "backlight node not found"); Missed terminating new line all over the driver for debug error messages.. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-20 Thread Varka Bhadram
On 10/21/2014 11:46 AM, Ankit Jindal wrote: On 21 October 2014 11:34, Varka Bhadram wrote: On 10/21/2014 11:26 AM, Ankit Jindal wrote: The Applied Micro X-Gene SOC has on-chip QMTM (Queue manager and Traffic manager) which is hardware based Queue or Ring manager. This QMTM device can be used

Re: [PATCH v3 4/6] uio: Add X-Gene QMTM UIO driver

2014-10-20 Thread Varka Bhadram
); + info->version = DRV_VERSION; + + info->priv = qmtm_dev; + + /* enable the clock */ + clk_prepare_enable(qmtm_dev->qmtm_clk); + + /* get the qmtm out of reset */ + ret = qmtm_reset(qmtm_dev); + if (ret < 0) { + dev_err(&p

Re: [PATCH v6 1/2] mtd: nand: add sunxi NAND flash controller support

2014-10-20 Thread Varka Bhadram
fc_remove, +}; +module_platform_driver(sunxi_nfc_driver); + +MODULE_LICENSE("GPL v2"); +MODULE_AUTHOR("Boris BREZILLON"); +MODULE_DESCRIPTION("Allwinner NAND Flash Controller driver"); +MODULE_ALIAS("platform:sunxi_nand"); -- Regards, Varka Bhadram. -- To unsu

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
spin_lock_init(&pd->idle_lock); + spin_lock_init(&pd->pmu_lock); + spin_lock_init(&pd->dev_lock); + + pm_genpd_init(&pd->base, NULL, false); + + return of_genpd_add_provider_simple(pdev->dev.of_node, &pd->base); +} + -- Thanks and Regards, V

Re: [PATCHv3 3/3] gpio: sch: Enable IRQ support for Quark X1000

2014-10-15 Thread Varka Bhadram
gpio); + +err_sch_intr_chip: + if (gpiochip_remove(&sch->chip)) gpiochip_remove() return 'void' [0]. + dev_err(&pdev->dev, + "%s gpiochip_remove() failed\n", __func__); + +err_sch_gpio: + release_region(res->start, resource_size(res)); +

Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM

2014-10-04 Thread Varka Bhadram
"Bosch M_CAN devices" + depends on HAS_IOMEM ---help--- Say Y here if you want to support for Bosch M_CAN controller. -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH v2 4/6] drivers: uio: Add X-Gene QMTM UIO driver

2014-09-29 Thread Varka Bhadram
leanup(pdev, qmtm_dev); + return 0; +} + +static struct of_device_id qmtm_match[] = { + {.compatible = "apm,xgene-qmtm",}, + {}, +}; + +MODULE_DEVICE_TABLE(of, qmtm_match); + +static struct platform_driver qmtm_driver = { + .driver = { + .name = DRV_NAME, + .owner = THIS_MODULE, Its not required. It will be updated by *module_platform_driver()* + .of_match_table = qmtm_match, + }, + .probe = qmtm_probe, + .remove = qmtm_remove, +}; + +module_platform_driver(qmtm_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
On 09/29/2014 04:43 PM, Anders Berg wrote: On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram wrote: On 09/29/2014 03:02 PM, Anders Berg wrote: Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The driver implements 10-bit addressing and SMBus transfer modes via emulation

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
. Yes it will [1]. Thanks for the clarification. [1]:http://lxr.free-electrons.com/source/lib/devres.c#L117 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

2014-09-29 Thread Varka Bhadram
rent = &pdev->dev; + idev->adapter.dev.of_node = pdev->dev.of_node; + + platform_set_drvdata(pdev, idev); + + ret = i2c_add_adapter(&idev->adapter); + if (ret) { + dev_err(&pdev->dev, "failed to add adapter\n"); +

Re: [PATCH v5] spi: spi-imx: add DMA support

2014-09-09 Thread Varka Bhadram
h = DMA_SLAVE_BUSWIDTH_1_BYTE; + slave_config.dst_maxburst = spi_imx_get_fifosize(spi_imx) / 2; + ret = dmaengine_slave_config(master->dma_tx, &slave_config); + if (ret) { + dev_err(dev, "error in TX dma configuration."); + Missed ter

[PATCH net-next] ethernet: ti: remove unwanted THIS_MODULE macro

2014-09-07 Thread Varka Bhadram
It removes the owner field updation of driver structure. It will be automatically updated by module_platform_driver() Signed-off-by: Varka Bhadram --- drivers/net/ethernet/ti/cpmac.c|1 - drivers/net/ethernet/ti/cpsw-phy-sel.c |1 - drivers/net/ethernet/ti/cpsw.c |1

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram wrote: + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
cific name)... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 1/7] mfd: Add support for DA9150 combined charger & fuel-gauge device

2014-08-28 Thread Varka Bhadram
shutdown, + .id_table = da9150_i2c_id, +}; + +module_i2c_driver(da9150_driver); + +MODULE_DESCRIPTION("I2C Driver for DA9150"); +MODULE_AUTHOR("Adam Thomson -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Varka Bhadram
orm_driver() Thanks. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs

2014-08-08 Thread Varka Bhadram
+1,19 @@ +* Mediatek Universal Asynchronous Receiver/Transmitter (UART) + Missing Required Properties:? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include +#include +#include +#include +#include +#include +#include +#include +#include "8250.h" + Better if we have i

Re: [PATCH v2 1/2] dma: Add Xilinx Central DMA DT Binding Documentation

2014-08-05 Thread Varka Bhadram
for all the properties... Required properties: - compatible: Should be "xlnx,axi-cdma-1.00.a" - #dma-cells: Should be <1>, see "dmas" property below - reg : Should contain cdma registers location and length. . -- Regards, Varka Bhadram. -- To unsubscribe

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
0_pm_ops, + .of_match_table = mtk8250_of_match, + }, + .probe = mtk8250_probe, + .remove = mtk8250_remove, +}; +module_platform_driver(mtk8250_platform_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the lin

Re: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-08-05 Thread Varka Bhadram
imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); return result; } @@ -432,6 +584,160 @@ static irqreturn_t i2c_imx_isr(int irq, void *dev_id) return IRQ_NONE; } +static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, + stru

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:37 PM, Nicolin Chen wrote: Hi Varka, On Tue, Aug 05, 2014 at 04:29:50PM +0530, Varka Bhadram wrote: diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt index 0f4e238..77864f4 100644 --- a/Documentation

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
their own bit clocks and frame sync clocks separately. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
c.c create mode 100644 sound/soc/fsl/fsl_asrc.h create mode 100644 sound/soc/fsl/fsl_asrc_dma.c check patch warnings on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
On 07/25/2014 01:27 PM, Nicolin Chen wrote: Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: On 07/25/2014 12:49 PM, Nicolin Chen wrote: (...) +static const struct platform_device_id fsl_asrc_devtype[] = { + { + .name

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
dev, "failed to init regmap\n"); + return PTR_ERR(asrc_priv->regmap); + } + + irq = platform_get_irq(pdev, 0); + if (irq < 0) { + dev_err(&pdev->dev, "no irq for node %s\n", np->full_name); + return irq; + } + +

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Varka Bhadram
Hi Nicolin, On 07/25/2014 11:24 AM, Nicolin Chen wrote: Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: (...) + +static const struct platform_device_id fsl_asrc_devtype

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Varka Bhadram
sl_asrc_resume) +}; + move device ids to here... +static struct platform_driver fsl_asrc_driver = { + .probe = fsl_asrc_probe, + .driver = { + .name = "fsl-asrc", + .of_match_table = fsl_asrc_ids, + .pm = &fsl_asrc_pm, + }, +}; +module_platform_driver(fsl_asrc_driver); Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: Hi, On 07/23/2014 06:32 PM, Varka Bhadram wrote: On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: On Keystone SOCs, DSP cores can send interrupts to ARM host using the IRQ controller IP. It provides 28 IRQ signals to

Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver

2014-07-23 Thread Varka Bhadram
ret = regmap_read(bank->devctrl_regs, bank->devctrl_offset, &val); + if (ret < 0) + dev_dbg(bank->dev, "gpio read failed ret(%d)\n", ret); If this read fails what will happen...? we will get the debug message and return (val >> bit) & 1, But

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
, + .owner = THIS_MODULE, No need to update it. Its done by module_platform_driver().. + .of_match_table = of_match_ptr(keystone_irq_dt_ids), This driver is always populate through the dts file. So no need to use of_match_ptr -- -Varka Bhadram -- To unsubscr

Re: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Varka Bhadram
-- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-22 Thread Varka Bhadram
tch only moves functions. If we are moving the code also its good to do cleanup. Run checkpatch.pl on this... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v4 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver

2014-07-22 Thread Varka Bhadram
nds. The third cell encodes the PWM flags (the only supported flag is PWM_POLARITY_INVERTED) -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [PATCH v4 02/11] mfd: add documentation for atmel-hlcdc DT bindings

2014-07-22 Thread Varka Bhadram
the HLCDC device registers. - clock-names : the name of the 3 clocks requested by the HLCDC device. Should contain "periph_clk", "sys_clk" and "slow_clk". - clocks : should contain the 3 clocks requested by the HLCDC device. .. -- Regar

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

2014-07-22 Thread Varka Bhadram
t;data->start_conv(info, ADC_S3C2410_MUX_TS); + + timeout = wait_for_completion_timeout + (&info->completion, EXYNOS_ADC_TIMEOUT); Should be properly aligned: wait_for_completion_timeout(&info->completion, EXYNOS_

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-07-22 Thread Varka Bhadram
lnx,usb2-device-4.00.a", }, + { /* end of list */ }, +}; +MODULE_DEVICE_TABLE(of, usb_of_match); + +static struct platform_driver xudc_driver = { + .driver = { + .name = driver_name, + .owner = THIS_MODULE, We can drop the owner field update... It updated automa

Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Varka Bhadram
if (err < 0) { + gpiod_dbg(desc, "%s: chip request fail, %d\n", + __func__, err); Dto.. (...) -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH v10 1/8] phy: add a driver for the Berlin SATA PHY

2014-07-18 Thread Varka Bhadram
filed automatically update with module_platform_driver(). see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
On 07/18/2014 03:43 PM, Neil Armstrong wrote: Le 18/07/2014 12:10, Varka Bhadram a écrit : On 07/18/2014 03:22 PM, Neil Armstrong wrote: A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM context. Signed-off-by: Neil Armstrong

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Varka Bhadram
the carrier offline for 10 seconds +* to notify ifplugd daemon network change +*/ This should be networking comment style.. /* bla bla.. * bla */ -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
macb *bp); + void(*mog_init_tx_rings)(struct macb *bp); int (*mog_rx)(struct macb *bp, int budget); }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] net: macb: Handle errors in RX path

2014-07-18 Thread Varka Bhadram
this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
On 07/18/2014 11:35 AM, Ethan Zhao wrote: On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram wrote: On 07/18/2014 09:13 AM, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get diff

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
chance of default case, then it will be always in switch case ...? + } + data[index] = (netxen_nic_gstrings_stats[index].sizeof_stat == sizeof(u64)) ? *(u64 *) p : *(u32 *) p; -- Regards, Varka Bhadram. -- To uns

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 10:13 AM, Jason Wang wrote: On 07/17/2014 11:27 AM, Varka Bhadram wrote: On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done between a kvm guest and an external host. Two hosts were connected through 40gb mlx4 cards. With

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Varka Bhadram
mode 100644 drivers/hwmon/pwm-fan.c This version addressed all of my comments.. Thanks :-) Reviewed-by: Varka Bhadram -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-16 Thread Varka Bhadram
ne_gpio_probe, + .remove = keystone_gpio_remove, + .driver = { + .name = "keystone-dsp-gpio", + .owner = THIS_MODULE, We can drop owner field... :-) .It will update by module_platform_driver -- Regards, Varka Bhadram. -- To u

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 03:17 PM, Antoine Ténart wrote: On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = "marvell,berlin

Re: [PATCH v3 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Varka Bhadram
-5v-supply : Defines the SATA 5V power regulator +- target-12v-supply : Defines the SATA 12V power regulator Same -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
.name = "phy-berlin-usb", + .owner = THIS_MODULE, No need to update owner field. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
AY_SIZE(vi->rq[i].sg)); ewma_init(&vi->rq[i].mrg_avg_pkt_len, 1, RECEIVE_AVG_WEIGHT); @@ -1880,8 +2062,10 @@ static int virtnet_freeze(struct virtio_device *vdev) if (netif_running(vi->dev)) { virtnet_napi_disable_all(vi); - for (i = 0;

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
ike this... Required properties: - compatible: should be "pwm-fan" - pwms : The PWM that is used to control the PWM fan -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
_driver pwm_fan_driver = { + .probe = pwm_fan_probe, + .remove = pwm_fan_remove, + .driver = { + .name = "pwm-fan", + .pm = &pwm_fan_pm, + .of_match_table = of_match_ptr(of_pwm_fan_match), This driver will always populat

Re: [RFC v5 1/2] backlight: add new tps611xx backlight driver

2014-07-15 Thread Varka Bhadram
5_ID]}, + {} +}; + +static struct platform_driver tps611xx_backlight_driver = { + .driver = { + .name = TPS611XX_NAME, + .owner = THIS_MODULE, No need to update .owner see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards,

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Varka Bhadram
= <&menetphy>; + mdio { + compatible = "apm,xgene-mdio"; + #address-cells = <1>; + #size-cells = <0>; + menetphy: menetphy@3 { + compatible = "ethernet-

Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread Varka Bhadram
;name"; + reg = <0x40031000 0x1000>; + ... +}; + +Scenario 4 : CPU in BE mode & device in LE mode. +dev: dev@40031000 { + compatible = "name"; + reg = <0x40031000 0x1000>; + ... + little-endian; +}

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
On 07/14/2014 04:19 PM, David Laight wrote: From: Varka Bhadram On 07/14/2014 02:32 PM, Jongsung Kim wrote: This patch enables the ethtool utility to control the WOL function of the PHY connected to the GEM/MACB. (if supported) ... +static int macb_set_wol(struct net_device *netdev, struct

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
macb_set_wol, .get_link = ethtool_op_get_link, .get_ts_info= ethtool_op_get_ts_info, }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH net-next v2 3/6] ethernet: amd: dynamic debug fixes

2014-07-14 Thread Varka Bhadram
On 07/14/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-07-14 at 11:55 +0530, varkabhad...@gmail.com wrote: From: Varka Bhadram [] diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c [] @@ -501,8 +501,7 @@ static int amd8111e_restart(struct net_device

Re: [PATCH 2/2 V3] PCI: implement VFs assignment reference counter

2014-07-11 Thread Varka Bhadram
um VFs driver supports */ + atomic_t VFs_assigned_cnt; /* counter of VFs assigned to VM */ struct pci_dev *dev;/* lowest numbered PF */ struct pci_dev *self; /* this PF */ struct mutex lock; /* lock for VF bus */ -- Regards, Varka Bhadram. -- To uns

Re: [PATCH net-next 0/8] cleanup for AMD811E ethernet driver

2014-07-11 Thread Varka Bhadram
Hi David, On 07/11/2014 01:05 PM, varkabhad...@gmail.com wrote: From: Varka Bhadram This series cleanup for AMD811E ethernet driver Varka Bhadram (8): ethernet: amd: move amd111e_remove_one after probe ethernet: amd: use devm_ioremap() ethernet: amd: dynamic debug fixes ethernet

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Varka Bhadram
vif) ??? if (dev == NULL) { pr_warn("Could not allocate netdev for %s\n", name); return ERR_PTR(-ENOMEM); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

  1   2   >