On 09/02/2014 04:08 PM, Jean-Francois Moine wrote:
On Tue, 02 Sep 2014 15:51:41 +0530
Varka Bhadram <varkabhad...@gmail.com> wrote:

+       switch (((np == bitclkmaster) << 4) | (np == framemaster)) {
+       case 0x11:
+               return SND_SOC_DAIFMT_CBS_CFS;
+       case 0x10:
+               return SND_SOC_DAIFMT_CBS_CFM;
+       case 0x01:
+               return SND_SOC_DAIFMT_CBM_CFS;
+       default:
+               return SND_SOC_DAIFMT_CBM_CFM;
+       }
+
+       /* Shouldn't be here */
+       return -EINVAL;
+}
It will be nice if we declare the switch case numbers as macros (specific 
name)...
I don't see which macros: the values are just 2 booleans.

I am talking about 0x11, 0x10, 0x01 values.. We can give any understandable
names to those...?


--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to