RE: [PATCH] [v3] blk-mq-tag: make blk_mq_tag_busy() return void

2020-12-15 Thread Tianxianting
Hi jens Could I get your commits? thanks -Original Message- From: tianxianting (RD) Sent: Thursday, December 10, 2020 2:05 PM To: ax...@kernel.dk Cc: ming@redhat.com; linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) Subject: [PATCH] [v3] blk-mq-tag

RE: [PATCH] [v2] tty: Protect disc_data in n_tty_close and n_tty_flush_buffer

2020-12-14 Thread Tianxianting
Hi Greg KH Could we get your comments for the updates? Thanks -Original Message- From: gaoyan (RD) Sent: Friday, December 11, 2020 2:09 PM To: Greg KH Cc: jirisl...@kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) Subject: 答复: [PATCH] [v2] tty: Protect disc_data in

RE: [PATCH] [v2] blk-mq-tag: make blk_mq_tag_busy() return void

2020-12-09 Thread Tianxianting
Yes, Sorry, In V2. I missed it, so I sent v3 :) -Original Message- From: Chaitanya Kulkarni [mailto:chaitanya.kulka...@wdc.com] Sent: Thursday, December 10, 2020 2:21 PM To: tianxianting (RD) ; ax...@kernel.dk Cc: ming@redhat.com; linux-bl...@vger.kernel.org; linux-kernel

RE: [PATCH] blk-mq-tag: make blk_mq_tag_busy() return void

2020-12-09 Thread Tianxianting
le(hctx); + if (hctx->flags & BLK_MQ_F_TAG_QUEUE_SHARED) + __blk_mq_tag_idle(hctx); } -Original Message- From: Ming Lei [mailto:ming@redhat.com] Sent: Thursday, December 10, 2020 12:01 PM To: tianxianting (RD) Cc: ax...@kernel.dk; linux-bl...@vger.kernel.org

RE: [PATCH] sched/rt: Print curr when RT throttling activated

2020-12-08 Thread Tianxianting
dt [mailto:rost...@goodmis.org] Sent: Thursday, December 03, 2020 10:40 PM To: tianxianting (RD) Cc: mi...@redhat.com; pet...@infradead.org; juri.le...@redhat.com; vincent.guit...@linaro.org; dietmar.eggem...@arm.com; bseg...@google.com; mgor...@suse.de; linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched

RE: [PATCH] ext4: remove the null check of bio_vec page

2020-12-03 Thread Tianxianting
Thanks Ted :) -Original Message- From: Theodore Y. Ts'o [mailto:ty...@mit.edu] Sent: Thursday, December 03, 2020 10:11 PM To: Jan Kara Cc: tianxianting (RD) ; adilger.ker...@dilger.ca; linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove the

RE: [PATCH] ext4: remove the null check of bio_vec page

2020-12-03 Thread Tianxianting
Thanks Jan Hi Ted Tso, Could I get your opinion of this patch? thanks -Original Message- From: Jan Kara [mailto:j...@suse.cz] Sent: Saturday, October 24, 2020 12:57 AM To: tianxianting (RD) Cc: Jan Kara ; ty...@mit.edu; adilger.ker...@dilger.ca; linux-e...@vger.kernel.org; linux

RE: [PATCH] mm: bio_alloc never fails when set GFP_NOIO, GFP_KERNEL

2020-10-23 Thread Tianxianting
Hi Andrew Could I get your comments for this patch? Thanks in advance. -Original Message- From: tianxianting (RD) Sent: Wednesday, October 21, 2020 11:11 AM To: a...@linux-foundation.org Cc: linux...@kvack.org; linux-kernel@vger.kernel.org; tianxianting (RD) Subject: [PATCH] mm

RE: [PATCH] ext4: remove the null check of bio_vec page

2020-10-23 Thread Tianxianting
Thanks Jan Can be the patch applied? -Original Message- From: Jan Kara [mailto:j...@suse.cz] Sent: Wednesday, October 21, 2020 6:25 PM To: tianxianting (RD) Cc: ty...@mit.edu; adilger.ker...@dilger.ca; j...@suse.cz; linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re

RE: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ

2020-10-22 Thread Tianxianting
Yes, thanks I see, If we add this patch, we need to get all cpu arch that support nested interrupts. -Original Message- From: Finn Thain [mailto:fth...@telegraphics.com.au] Sent: Thursday, October 22, 2020 11:29 AM To: tianxianting (RD) Cc: kashyap.de...@broadcom.com; sumit.sax

RE: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ

2020-10-21 Thread Tianxianting
Thanks, Do you mean Megasas raid can be used in m68k arch? -Original Message- From: Finn Thain [mailto:fth...@telegraphics.com.au] Sent: Thursday, October 22, 2020 10:25 AM To: tianxianting (RD) Cc: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; shivasharan.srikanteshw

RE: [PATCH] blk-mq: remove the calling of local_memory_node()

2020-10-19 Thread Tianxianting
Thanks Michal, Hi, raghavendra, Jens Could you help comment this issue? Thanks in advance. -Original Message- From: Michal Hocko [mailto:mho...@suse.com] Sent: Monday, October 19, 2020 7:40 PM To: tianxianting (RD) Cc: ax...@kernel.dk; raghavendra...@linux.vnet.ibm.com; linux-bl

RE: [PATCH] mm: Make allocator take care of memoryless numa node

2020-10-19 Thread Tianxianting
Thanks Michal, Yes, it is the commit bffed457160ab. Sorry I forgot to paste it in my previous reply. -Original Message- From: Michal Hocko [mailto:mho...@suse.com] Sent: Monday, October 19, 2020 3:07 PM To: tianxianting (RD) Cc: c...@linux.com; penb...@kernel.org; rient...@google.com

RE: [PATCH] mm: Make allocator take care of memoryless numa node

2020-10-18 Thread Tianxianting
Thanks for the comments I found in current code, there are two places to call local_memory_node(node) before calling kzalloc_node(), I think we can remove them? -Original Message- From: Michal Hocko [mailto:mho...@suse.com] Sent: Monday, October 12, 2020 11:06 PM To: tianxianting (RD

RE: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()

2020-10-16 Thread Tianxianting
Thanks for the explain. I got it. -Original Message- From: Michal Hocko [mailto:mho...@suse.com] Sent: Friday, October 16, 2020 9:45 PM To: tianxianting (RD) Cc: a...@linux-foundation.org; linux...@kvack.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: avoid a

RE: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()

2020-10-16 Thread Tianxianting
Hocko [mailto:mho...@suse.com] Sent: Friday, October 16, 2020 9:02 PM To: tianxianting (RD) Cc: a...@linux-foundation.org; linux...@kvack.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab() On Fri 16-10-20 12:48:23, Tianxianting wrote

RE: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()

2020-10-16 Thread Tianxianting
this time, it won't cause other thread getting starvation, so we don't need to call cond_resched() in this case. Is it right? -Original Message- From: Michal Hocko [mailto:mho...@suse.com] Sent: Friday, October 16, 2020 8:08 PM To: tianxianting (RD) Cc: a...@linux-foundation.org;

RE: [PATCH] IB/hfi1: Avoid allocing memory on memoryless numa node

2020-10-12 Thread Tianxianting
Hi Dennis Thanks for the comments If it depends on x86_64, I think this issue doesn't exist. Sorry to disturb you. -Original Message- From: Dennis Dalessandro [mailto:dennis.dalessan...@cornelisnetworks.com] Sent: Monday, October 12, 2020 8:37 PM To: tianxianting (RD) ; mike.mar

RE: [PATCH] bpf: Avoid allocing memory on memoryless numa node

2020-10-11 Thread Tianxianting
Thanks Alexei for your suggestion, I will try to do it. -Original Message- From: Alexei Starovoitov [mailto:alexei.starovoi...@gmail.com] Sent: Monday, October 12, 2020 9:21 AM To: tianxianting (RD) Cc: Alexei Starovoitov ; Daniel Borkmann ; David S. Miller ; Jakub Kicinski ; Jesper

RE: [PATCH] net: Avoid allocing memory on memoryless numa node

2020-10-11 Thread Tianxianting
Hi Jakub, Thanks for your suggestion, Let me try it :-) -Original Message- From: Jakub Kicinski [mailto:k...@kernel.org] Sent: Monday, October 12, 2020 3:18 AM To: tianxianting (RD) Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] net

RE: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()

2020-10-08 Thread Tianxianting
Sorry Randy, I used my cellphone to send the previous mail, it is html. -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Thursday, October 08, 2020 12:50 AM To: tianxianting (RD) ; v...@zeniv.linux.org.uk Cc: linux-fsde...@vger.kernel.org; linux-kernel

RE: [PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-28 Thread Tianxianting
Thank you Bart Van Hi Jens, Whether this version patch is ok for you? Looking forward to your further comments :) -Original Message- From: Bart Van Assche [mailto:bvanass...@acm.org] Sent: Saturday, September 26, 2020 12:07 PM To: tianxianting (RD) ; ax...@kernel.dk Cc: linux-bl

RE: [PATCH] [v2] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-25 Thread Tianxianting
, September 26, 2020 3:26 AM To: tianxianting (RD) Cc: linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps() On 9/17/20 2:13 AM, Xianting Tian wrote: > We found it takes more time of blk_mq_alloc_rq_maps()

RE: [PATCH] [v2] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-25 Thread Tianxianting
Hi Jens Could I get your comments for the issue? Whether it is a problem? Maybe my understanding is superficial, highly appreciated if you can comment a bit. -Original Message- From: tianxianting (RD) Sent: Thursday, September 17, 2020 4:13 PM To: ax...@kernel.dk Cc: linux-bl

RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Tianxianting
Thank you Keith, Christoph, So I don't need to send v3 patch? -Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Tuesday, September 22, 2020 10:59 PM To: Keith Busch Cc: tianxianting (RD) ; ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradea

RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

2020-09-22 Thread Tianxianting
Finally, it applied:) Thanks again for all your kindly guides to me. -Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Tuesday, September 22, 2020 11:41 PM To: tianxianting (RD) Cc: Christoph Hellwig ; Keith Busch ; ax...@fb.com; s...@grimberg.me; linux-n

RE: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Tianxianting
I get it now, thanks Keith:) -Original Message- From: Keith Busch [mailto:kbu...@kernel.org] Sent: Monday, September 21, 2020 11:59 PM To: tianxianting (RD) Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH

RE: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Tianxianting
, 2020 11:08 PM To: tianxianting (RD) Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null On Mon, Sep 21, 2020 at 10:10:52AM +0800, Xianting Tian w

撤回: [PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-20 Thread Tianxianting
tianxianting (RD) 将撤回邮件“[PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()”。

RE: [PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-20 Thread Tianxianting
spare several minutes to review below new patch? thanks https://lkml.org/lkml/2020/9/20/400 -Original Message- From: tianxianting (RD) Sent: Saturday, September 19, 2020 11:15 AM To: 'Keith Busch' Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradead.org; li

RE: [PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-20 Thread Tianxianting
solved in this patch I submitted. Is it right? Thanks a lot. -Original Message----- From: tianxianting (RD) Sent: Saturday, September 19, 2020 11:15 AM To: 'Keith Busch' Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org

RE: [PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-18 Thread Tianxianting
Hi Keith, Thanks a lot for your comments, I will try to figure out a safe fix for this issue, then for you review:) -Original Message- From: Keith Busch [mailto:kbu...@kernel.org] Sent: Saturday, September 19, 2020 3:21 AM To: tianxianting (RD) Cc: ax...@fb.com; h...@lst.de; s

RE: [PATCH] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-18 Thread Tianxianting
I am very sorry, Please ignore this patch, the code need to rewrite. -Original Message- From: tianxianting (RD) Sent: Friday, September 18, 2020 3:45 PM To: kbu...@kernel.org; ax...@fb.com; h...@lst.de; s...@grimberg.me Cc: linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org

RE: [PATCH] tracing: use __this_cpu_read() in trace_buffered_event_enable()

2020-09-17 Thread Tianxianting
Hi Steven, Thanks for your reply:) -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Friday, September 18, 2020 8:31 AM To: tianxianting (RD) Cc: mi...@redhat.com; linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: use __this_cpu_read() in

RE: [PATCH] ipmi: add retry in try_get_dev_id()

2020-09-16 Thread Tianxianting
Thanks you Corey for your kindly guides to me for these three patches :) -Original Message- From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard Sent: Wednesday, September 16, 2020 10:01 PM To: tianxianting (RD) Cc: a...@arndb.de; gre...@linuxfoundation.org

RE: [PATCH] [v2] ipmi: retry to get device id when error

2020-09-16 Thread Tianxianting
Hi Corey, Would you please review this patch: add the same retry in try_get_dev_id() https://lkml.org/lkml/2020/9/16/244 Thanks a lot. -Original Message- From: tianxianting (RD) Sent: Tuesday, September 15, 2020 11:20 PM To: 'miny...@acm.org' Cc: a...@arn

RE: [PATCH] [v2] ipmi: retry to get device id when error

2020-09-15 Thread Tianxianting
I get it now, thank you Corey :) I will send the patch for you review tomorrow. -Original Message- From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard Sent: Tuesday, September 15, 2020 10:53 PM To: tianxianting (RD) Cc: a...@arndb.de; gre...@linuxfoundation.org

RE: [PATCH] [v2] ipmi: retry to get device id when error

2020-09-15 Thread Tianxianting
ry? Thanks a lot. -Original Message- From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard Sent: Monday, September 14, 2020 11:40 PM To: tianxianting (RD) Cc: a...@arndb.de; gre...@linuxfoundation.org; openipmi-develo...@lists.sourceforge.net; linux-kernel@vger.ke

RE: [PATCH] ipmi: retry to get device id when error

2020-09-14 Thread Tianxianting
Of Corey Minyard Sent: Monday, September 14, 2020 1:26 AM To: tianxianting (RD) Cc: a...@arndb.de; gre...@linuxfoundation.org; openipmi-develo...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: retry to get device id when error On Sun, Sep 13, 2020 at 02:10:01PM

RE: [PATCH] ipmi: retry to get device id when error

2020-09-13 Thread Tianxianting
500ms interval? Thanks in advance if you can feedback again. -Original Message- From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard Sent: Sunday, September 13, 2020 8:40 PM To: tianxianting (RD) Cc: a...@arndb.de; gre...@linuxfoundation.org; openipmi-develo...@lists.

RE: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()

2020-09-10 Thread Tianxianting
Hi viro, Could I get your feedback? This patch fixed the build warning, I think it can be applied, thanks :) -Original Message- From: tianxianting (RD) Sent: Saturday, September 05, 2020 3:15 PM To: v...@zeniv.linux.org.uk Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org

RE: [PATCH] block: remove redundant empty check of mq_list

2020-09-10 Thread Tianxianting
dk] Sent: Wednesday, September 09, 2020 10:21 PM To: tianxianting (RD) ; a...@kernel.org; dan...@iogearbox.net; ka...@fb.com; songliubrav...@fb.com; y...@fb.com; andr...@fb.com; john.fastab...@gmail.com; kpsi...@chromium.org Cc: linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; net...@vger.kern

RE: [PATCH] blkcg: add plugging support for punt bio

2020-09-08 Thread Tianxianting
Thanks TJ and your previous guide to me. I will summarize and resubmit the patch. -Original Message- From: Tejun Heo [mailto:hte...@gmail.com] On Behalf Of Tejun Heo Sent: Wednesday, September 09, 2020 2:03 AM To: tianxianting (RD) Cc: ax...@kernel.dk; cgro...@vger.kernel.org; linux-bl

RE: [PATCH] clocksource: Return negative error code in h8300_8timer_init()

2020-09-02 Thread Tianxianting
if (!irq) { pr_err("failed to get irq for clockevent\n"); goto unmap_reg; } -Original Message- From: Markus Elfring [mailto:markus.elfr...@web.de] Sent: Tuesday, September 01, 2020 10:46 PM To: tianxianting (RD) ; uclinux-h8-d

RE: [PATCH] [v3] blk-mq: use BLK_MQ_NO_TAG for no tag

2020-09-01 Thread Tianxianting
Hi Jens Could I get the feedback from you whether this patch can be applied? Thanks a lot. -Original Message- From: tianxianting (RD) Sent: Thursday, August 27, 2020 2:34 PM To: ax...@kernel.dk Cc: linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) Subject

RE: [PATCH] [v2] nvme-pci: check req to prevent crash in nvme_handle_cqe()

2020-09-01 Thread Tianxianting
Hi, Could I get the feedback for the patch, whether it can be applied or need some improvement? It really can prevent a crash we met. Thanks:) -Original Message- From: tianxianting (RD) Sent: Monday, August 31, 2020 6:56 PM To: kbu...@kernel.org; ax...@fb.com; h...@lst.de; s

RE: [PATCH] nvme-pci: check req to prevent crash in nvme_handle_cqe()

2020-08-31 Thread Tianxianting
I am very sorry, I used the wrong patch file :( I send it again. Please review, thanks. -Original Message- From: kernel test robot [mailto:l...@intel.com] Sent: Monday, August 31, 2020 5:41 PM To: tianxianting (RD) ; kbu...@kernel.org; ax...@fb.com; h...@lst.de; s...@grimberg.me Cc

RE: [PATCH] aio: make aio wait path to account iowait time

2020-08-28 Thread Tianxianting
Thanks peterz, jan So, enable aio iowait time accounting is a bad idea:( I gained a lot from you, thanks -Original Message- From: pet...@infradead.org [mailto:pet...@infradead.org] Sent: Friday, August 28, 2020 6:52 PM To: Jan Kara Cc: tianxianting (RD) ; v...@zeniv.linux.org.uk; b

RE: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag

2020-08-26 Thread Tianxianting
26, 2020 12:29 PM To: tianxianting (RD) Cc: ax...@kernel.dk; linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag On Wed, Aug 26, 2020 at 10:06:51AM +0800, Xianting Tian wrote: > Replace various magic -1 constants for tags wi

RE: [PATCH] blk-mq: use BLK_MQ_NO_TAG for no tag

2020-08-24 Thread Tianxianting
TAG = -1U, BLK_MQ_TAG_MIN = 1, BLK_MQ_TAG_MAX = BLK_MQ_NO_TAG - 1, }; Will you accept above moving of BLK_MQ_NO_TAG to 'include/linux/blk-mq.h'? Thanks -Original Message- From: Jens Axboe [mailto:ax...@kernel.dk] Sent: Monday, August 24, 2020 4:58 AM

答复: [PATCH] timers: use set_current_state macro

2020-05-14 Thread Tianxianting
Please review this one, thanks. https://lkml.org/lkml/2020/5/14/796 -邮件原件- 发件人: tianxianting (RD) 发送时间: 2020年5月14日 9:46 收件人: 'Thomas Gleixner' ; john.stu...@linaro.org; sb...@kernel.org 抄送: linux-kernel@vger.kernel.org 主题: 答复: [PATCH] timers: use set_current_state macro Hi Tho

答复: [PATCH] timers: use set_current_state macro

2020-05-13 Thread Tianxianting
eral patches before, and patches were accepted. -邮件原件- 发件人: Thomas Gleixner [mailto:t...@linutronix.de] 发送时间: 2020年5月14日 5:22 收件人: tianxianting (RD) ; john.stu...@linaro.org; sb...@kernel.org 抄送: linux-kernel@vger.kernel.org; tianxianting (RD) 主题: Re: [PATCH] timers: use set_current_state m