Thank you Keith, Christoph, So I don't need to send v3 patch? -----Original Message----- From: Christoph Hellwig [mailto:[email protected]] Sent: Tuesday, September 22, 2020 10:59 PM To: Keith Busch <[email protected]> Cc: tianxianting (RD) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null
On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote: > The commit subject is a too long. We should really try to keep these > to > 50 characters or less. > > nvme-pci: fix NULL req in completion handler > > Otherwise, looks fine. > > Reviewed-by: Keith Busch <[email protected]> Yes. I was about to apply it with a similar edit, but I'll take yours happily.
