Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-16 Thread Tan Xiaojun
On 2019/10/17 9:51, Tan Xiaojun wrote: > On 2019/10/16 18:12, James Clark wrote: >> Hi Xiaojun, >> >>>> >>>> What do you mean when the user specifies "event:pp", if the SPE is >>>> available, configure and record the spe data directly

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-16 Thread Tan Xiaojun
On 2019/10/16 18:12, James Clark wrote: > Hi Xiaojun, > >>> >>> What do you mean when the user specifies "event:pp", if the SPE is >>> available, configure and record the spe data directly via the perf event >>> open syscall? >>> (perf.data itself is the same as using -e arm_spe_0//xxx?) >> >> I

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-09 Thread Tan Xiaojun
On 2019/10/9 19:09, Tan Xiaojun wrote: > On 2019/10/9 17:48, James Clark wrote: >> Hi Xiaojun, >> >>> By the way, you mentioned before that you want the spe event to be in the >>> form of "event:pp" like pebs. Is that the whole framework should be

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-09 Thread Tan Xiaojun
On 2019/10/9 17:48, James Clark wrote: > Hi Xiaojun, > >> By the way, you mentioned before that you want the spe event to be in the >> form of "event:pp" like pebs. Is that the whole framework should be made >> similar to pebs? Or is it just a modification to the command format? > > We're curr

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-08 Thread Tan Xiaojun
t, so "-c -F, etc." is only for instructions rather than events, so it may be misunderstood by users. So I haven't figured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-08 Thread Tan Xiaojun
haven't figured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >>> Hi, >>> >>> First thanks for posting this! >>> >>> I ran this on our DAWN p

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-10-07 Thread Tan Xiaojun
haven't figured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >>> Hi, >>> >>> First thanks for posting this! >>> >>> I ran this on our DAWN p

Re: [RFC PATCH 3/3] perf report: add --spe options for arm-spe

2019-08-21 Thread Tan Xiaojun
perf record -e branch-misses:pp > > And then perf could use the modifier to configure SPE so that it only records > branch > misses? The benefits of this would be keeping the user interface for precise > tracing > similar between platforms. > Good suggestion. And I need to s

[tip:perf/core] perf record: Support aarch64 random socket_id assignment

2019-08-15 Thread tip-bot for Tan Xiaojun
Commit-ID: 0a4d8fb229dd78f9e0752817339e19e903b37a60 Gitweb: https://git.kernel.org/tip/0a4d8fb229dd78f9e0752817339e19e903b37a60 Author: Tan Xiaojun AuthorDate: Fri, 2 Aug 2019 11:48:57 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 14 Aug 2019 11:00:00 -0300 perf record

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-08-08 Thread Tan Xiaojun
h 8.33% 8.33% dd libc-2.28.so [.] __GI___printf_fp_l 8.33% 8.33% dd libc-2.28.so [.] _dl_addr 8.33% 8.33% dd libc-2.28.so [.] _int_malloc 8.33% 8.33% dd libc-2.28.so [.] _nl_intern_locale_data > >

[RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

2019-08-02 Thread Tan Xiaojun
After that, more analysis and processing of the raw data of spe will be done. Signed-off-by: Tan Xiaojun --- tools/perf/builtin-report.c| 5 + tools/perf/util/arm-spe-decoder/Build | 2 +- tools/perf/util/arm-spe-decoder/arm

[RFC PATCH 0/3] perf tools: Add support for "report" for some spe events

2019-08-02 Thread Tan Xiaojun
is to improve the "perf report" support for spe, and further process the data. Currently, support for the three events of llc-miss, tlb-miss, and branch-miss is added. More details in [2/3]. Tan Xiaojun (3): perf tools: Move arm-spe-pkt-decoder.h/c to the new dir perf tools: Add

[RFC PATCH 3/3] perf report: add --spe options for arm-spe

2019-08-02 Thread Tan Xiaojun
The previous patch added support in "perf report" for some arm-spe events(llc-miss, tlb-miss, branch-miss). This patch adds their help instructions. Signed-off-by: Tan Xiaojun --- tools/perf/Documentation/perf-report.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/

[RFC PATCH 1/3] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir

2019-08-02 Thread Tan Xiaojun
Create a new arm-spe-decoder directory for subsequent extensions and move arm-spe-pkt-decoder.h/c to this directory. No code changes. Signed-off-by: Tan Xiaojun --- tools/perf/util/Build | 2 +- tools/perf/util/arm-spe-decoder/Build | 1 + .../util

[PATCH] perf record: Support aarch64 random socket_id assignment

2019-08-01 Thread Tan Xiaojun
st: 96-127 # # captured on: Thu Aug 1 22:58:38 2019 # header version : 1 ... # CPU 0: Core ID 0, Socket ID 36 # CPU 1: Core ID 1, Socket ID 36 ... # CPU 126: Core ID 126, Socket ID 8442 # CPU 127: Core ID 127, Socket ID 8442 ... Signed-off-by: Tan Xiaojun --- tools/perf/uti

Re: [PATCH v2] aio: add check for timeout to aviod invalid value

2019-03-06 Thread Tan Xiaojun
Any comments? Anything is fine to me. Thanks. Xiaojun. On 2019/2/25 18:09, Tan Xiaojun wrote: > Syzkaller reported a UBSAN bug below, which was mainly caused by a large > negative number passed to the timeout of the io_getevents syste

[PATCH v2] aio: add check for timeout to aviod invalid value

2019-02-25 Thread Tan Xiaojun
iously discussed at: https://lore.kernel.org/lkml/cact4y+bbxvylq6ltokrktnlthqlhcw-bmp3aqp3mjdavr9f...@mail.gmail.com/ Signed-off-by: Tan Xiaojun Reviewed-by: Jeff Moyer --- fs/aio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index f4d..3a39673 1006

Re: [PATCH] aio: add check for timeout to aviod invalid value

2019-02-25 Thread Tan Xiaojun
I made a mistake. I will fix it and send v2. Thanks. Xiaojun. On 2019/2/25 17:42, Tan Xiaojun wrote: > Syzkaller reported a UBSAN bug below, which was mainly caused by a large > negative number passed to the timeout of the io_getevents syste

[PATCH] aio: add check for timeout to aviod invalid value

2019-02-25 Thread Tan Xiaojun
as previously discussed at: https://lore.kernel.org/lkml/cact4y+bbxvylq6ltokrktnlthqlhcw-bmp3aqp3mjdavr9f...@mail.gmail.com/ Signed-off-by: Tan Xiaojun Reviewed-by: Jeff Moyer --- fs/aio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index f4

Re: [RFC PATCH] aio: add check for timeout to aviod invalid value

2019-02-24 Thread Tan Xiaojun
On 2019/2/19 4:33, Jeff Moyer wrote: > Tan Xiaojun writes: > >> (When I was testing with syzkaller, I found a lot of ubsan problems. Here >> is one of them. I am not sure if it needs to be fixed and how it will be >> fixed. So I sent this patch to ask your opinion.) &g

[RFC PATCH] aio: add check for timeout to aviod invalid value

2019-02-16 Thread Tan Xiaojun
out described in "man io_getevents" does not say whether it can be negative or not, but as a waiting time, a negative number has no meaning. So I add check to avoid this case. Signed-off-by: Tan Xiaojun --- fs/aio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[PATCH net-next] net: hns3: add common validation in hclge_dcb

2018-11-19 Thread Tan Xiaojun
ndexed by tc num, so this patch changes them to use different index. Signed-off-by: Yunsheng Lin Signed-off-by: Tan Xiaojun --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 70 +++--- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 14 + .../net/ethernet/hisilico

[Question] A UBSAN problem in stable-4.4

2018-11-08 Thread Tan Xiaojun
Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second p

[Question] A UBSAN problem in stable-4.4

2018-11-06 Thread Tan Xiaojun
Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second p

[PATCH] net: hns3: fix length overflow when CONFIG_ARM64_64K_PAGES

2018-04-04 Thread Tan Xiaojun
When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE is 65536(64K). But the type of length is u16, it will overflow. So change it to u32. Signed-off-by: Tan Xiaojun --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

2017-12-25 Thread Tan Xiaojun
On 2017/12/25 16:18, Christian König wrote: > Series is Reviewed-by: Christian König . > > I'm going to pick that up for 4.16. > > Thanks for the cleanup, > Christian. > Thank you very much. Xiaojun. > Am 25.12.2017 um 04:43 schrieb Tan Xiaojun: >> I fou

[PATCH v2 07/12] drm/qxl: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index

[PATCH v2 08/12] drm/radeon: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon

[PATCH v2 01/12] drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn

2017-12-24 Thread Tan Xiaojun
m_pfn() as wrapper. Signed-off-by: Michal Srb Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index c8ebb75..292d157 100644 --- a/drivers/g

[PATCH v2 09/12] drm/virtio: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio

[PATCH v2 12/12] drm/ttm: remove ttm_bo_default_io_mem_pfn

2017-12-24 Thread Tan Xiaojun
No one will use this function except ttm_bo_io_mem_pfn() now, so move the calculation of ttm_bo_default_io_mem_pfn() into ttm_bo_io_mem_pfn() and do some cleanup. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 11 ++- include/drm/ttm/ttm_bo_api.h| 11 --- 2

[PATCH v2 11/12] staging: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo

[PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

2017-12-24 Thread Tan Xiaojun
ttm_bo_default_io_mem_pfn() and do some cleanup. Tan Xiaojun (12): drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm

[PATCH v2 04/12] drm/cirrus: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus

[PATCH v2 05/12] drm/mgag200: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200

[PATCH v2 03/12] drm/bochs: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c

[PATCH v2 06/12] drm/nouveau: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau

[PATCH v2 10/12] drm/vmwgfx: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c b/drivers/gpu/drm/vmwgfx

[PATCH v2 02/12] drm/ast: remove the default io_mem_pfn set

2017-12-24 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c index

Re: [PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

2017-12-24 Thread Tan Xiaojun
On 2017/12/24 17:27, Christian König wrote: > Am 24.12.2017 um 07:14 schrieb Tan Xiaojun: >> From: Michal Srb >> >> The io_mem_pfn field was added in commit >> ea642c3216cb2a60d1c0e760ae47ee85c9c16447 >> and is called unconditionally. However, not all d

[PATCH 11/12] staging: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo

[PATCH 03/12] drm/bochs: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c

[PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

2017-12-23 Thread Tan Xiaojun
From: Michal Srb The io_mem_pfn field was added in commit ea642c3216cb2a60d1c0e760ae47ee85c9c16447 and is called unconditionally. However, not all drivers were updated to set it. Use the ttm_bo_default_io_mem_pfn function if a driver did not set its own. Signed-off-by: Michal Srb --- drivers

[PATCH 10/12] drm/vmwgfx: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c b/drivers/gpu/drm/vmwgfx

[PATCH 12/12] drm/ttm: unexport ttm_bo_default_io_mem_pfn and make it static

2017-12-23 Thread Tan Xiaojun
No one will use this function except in ttm_bo_vm.c now. So unexport it and make it static. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 23 +++ include/drm/ttm/ttm_bo_api.h| 11 --- 2 files changed, 15 insertions(+), 19 deletions(-) diff

[PATCH 08/12] drm/radeon: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon

[PATCH 06/12] drm/nouveau: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau

[PATCH 07/12] drm/qxl: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index

[PATCH 00/12] drm: add check if io_mem_pfn is NULL and cleanup

2017-12-23 Thread Tan Xiaojun
is NULL Tan Xiaojun (11): drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm/nouveau: remove the default io_mem_pfn set drm/qxl: remove the default

[PATCH 05/12] drm/mgag200: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200

[PATCH 09/12] drm/virtio: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio

[PATCH 04/12] drm/cirrus: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus

[PATCH 02/12] drm/ast: remove the default io_mem_pfn set

2017-12-23 Thread Tan Xiaojun
The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c index

Re: [Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

2017-11-29 Thread Tan Xiaojun
On 2017/11/29 16:02, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:57:51PM +0800, Tan Xiaojun wrote: >> Hi, all, >> >> I test in a Arm64 fpga board (Hisilicon D06 fpga) with >> kernel-stable-4.14.2, then I get a panic log attached in the end. >> >>

[Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

2017-11-28 Thread Tan Xiaojun
Hi, all, I test in a Arm64 fpga board (Hisilicon D06 fpga) with kernel-stable-4.14.2, then I get a panic log attached in the end. I found this problem try to be fixed before by the patch "tty: Fix ldisc crash on reopened tty", and it was reverted shortly thereafter becau

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

2017-11-19 Thread Tan Xiaojun
On 2017/11/17 19:13, Sudeep Holla wrote: > On Fri, Nov 17, 2017 at 10:13:39AM +0800, Tan Xiaojun wrote: >> On 2017/11/16 23:23, Sudeep Holla wrote: >>> >>> I assume L3 is outer non-architected system cache. >>> >> >> Yes. >> > > Good. &g

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

2017-11-16 Thread Tan Xiaojun
On 2017/11/17 10:13, Tan Xiaojun wrote: > On 2017/11/16 23:23, Sudeep Holla wrote: >> >> >> On 16/11/17 12:58, Tan Xiaojun wrote: >>> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >>> overrides for cache properties"), we can se

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

2017-11-16 Thread Tan Xiaojun
On 2017/11/16 23:23, Sudeep Holla wrote: > > > On 16/11/17 12:58, Tan Xiaojun wrote: >> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >> overrides for cache properties"), we can set the correct cacheinfo >> via DT. But the cache type can&#x

[PATCH] drivers: base: cacheinfo: support DT overrides for cache type

2017-11-16 Thread Tan Xiaojun
cpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such file or directory So I think maybe we can set correct cache type via DT too. Signed-off-by: Tan Xiaojun --- drivers/base/cacheinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/cacheinfo.c

Re: [bug report & help] arm64: ltp testcase "migrate_pages01" failed

2017-10-17 Thread Tan Xiaojun
On 2017/10/17 17:23, Will Deacon wrote: > On Tue, Oct 17, 2017 at 10:58:53AM +0800, Tan Xiaojun wrote: >> I'm not sure if this is the problem on arm64 numa. What do you think ? >> By the way, this testcase can be successful in any case on x86. > > To be honest, this is

Re: [bug report & help] arm64: ltp testcase "migrate_pages01" failed

2017-10-16 Thread Tan Xiaojun
Hi all, I'm not sure if this is the problem on arm64 numa. What do you think ? By the way, this testcase can be successful in any case on x86. Thanks. Xiaojun. On 2017/10/16 19:42, Tan Xiaojun wrote: > Hi all, > > I test ltp in Hisilicon D05 board and get a failed result abou

[bug report & help] arm64: ltp testcase "migrate_pages01" failed

2017-10-16 Thread Tan Xiaojun
Hi all, I test ltp in Hisilicon D05 board and get a failed result about the testcase "migrate_pages01". In fact, The sub testcase "test_invalid_nodes" failed. The testcase is to find a invalid numa node and migrate memory pages to this node via syscall of "migrate_pages". The expected result o

Re: [PATCH 0/2] arm64: fix crash when reading /proc/kcore

2017-06-12 Thread Tan Xiaojun
el (2): > fs/proc: kcore: use kcore_list type to check for vmalloc/module > address > arm64: mm: select CONFIG_ARCH_PROC_KCORE_TEXT > > arch/arm64/Kconfig | 3 +++ > fs/proc/kcore.c| 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > Reported-by: Tan Xiaojun Tes

Re: [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check

2017-03-13 Thread Tan Xiaojun
On 2017/3/14 2:35, Vince Weaver wrote: > On Sat, 25 Feb 2017, Peter Zijlstra wrote: > >> On Sat, Feb 25, 2017 at 04:10:37PM +0800, Tan Xiaojun wrote: >> >>> 2)If it is, where we will fix it more appropriate, perf_fuzzer(not set >>> 0 or 100) or kernel(limit

[PATCH -stable 4.1 4/4] perf/core: Fix the perf_cpu_time_max_percent check

2017-03-05 Thread Tan Xiaojun
Use "proc_dointvec_minmax" instead of "proc_dointvec" to check the input value from user-space. If not, we can set a big value and some vars will overflow like "sysctl_perf_event_sample_rate" which will cause a lot of unexpected problems. Signed-off-by: Tan Xiaojun

[PATCH -stable 4.1 0/4] perf/core: Fix dynamic interrupt throttle

2017-03-05 Thread Tan Xiaojun
to documentation Tan Xiaojun (1): perf/core: Fix the perf_cpu_time_max_percent check kernel/events/core.c | 97 1 file changed, 60 insertions(+), 37 deletions(-) -- 1.9.1

[PATCH -stable 4.1 2/4] perf/core: Fix implicitly enable dynamic interrupt throttle

2017-03-05 Thread Tan Xiaojun
nce Weaver Cc: a...@kernel.org Link: http://lkml.kernel.org/r/1462260366-3160-1-git-send-email-kan.li...@intel.com Signed-off-by: Ingo Molnar Signed-off-by: Tan Xiaojun --- kernel/events/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kernel/events/core.c b/kernel/events/co

[PATCH -stable 4.1 3/4] perf/core: Make sysctl_perf_cpu_time_max_percent conform to documentation

2017-03-05 Thread Tan Xiaojun
Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Fixes: 91a612eea9a3 ("perf/core: Fix dynamic interrupt throttle") Signed-off-by: Ingo Molnar Signed-off-by: Tan Xiaojun --- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ker

[PATCH -stable 4.1 1/4] perf/core: Fix dynamic interrupt throttle

2017-03-05 Thread Tan Xiaojun
Melo Cc: Borislav Petkov Cc: Brian Gerst Cc: David Ahern Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Olsa Cc: Linus Torvalds Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Signed-off-by: Ingo Molnar Signed-off-by: Tan Xiaojun

Re: [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check

2017-02-26 Thread Tan Xiaojun
On 2017/2/25 17:51, Peter Zijlstra wrote: > On Sat, Feb 25, 2017 at 04:10:37PM +0800, Tan Xiaojun wrote: > >> Recently I was using perf_fuzzer for testing in Hisilicon >> D03/D05(arm64, linux-4.10-rc1). >> >> As we know perf_fuzzer will write a random value to pro

Re: [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check

2017-02-25 Thread Tan Xiaojun
#0x180 unsigned int vec_nr; int prev_count; h += softirq_bit - 1; - On 2017/2/24 17:15, tip-bot for Tan Xiaojun wrote: > Commit-ID: 1572e45a924f254d9570093abde46430c3172e3d > Gitweb: http://git.ke

[tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check

2017-02-24 Thread tip-bot for Tan Xiaojun
Commit-ID: 1572e45a924f254d9570093abde46430c3172e3d Gitweb: http://git.kernel.org/tip/1572e45a924f254d9570093abde46430c3172e3d Author: Tan Xiaojun AuthorDate: Thu, 23 Feb 2017 14:04:39 +0800 Committer: Ingo Molnar CommitDate: Fri, 24 Feb 2017 08:56:33 +0100 perf/core: Fix the

[PATCH] perf/core: Fix to check perf_cpu_time_max_percent

2017-02-22 Thread Tan Xiaojun
03b9aca00 x8 : 002e [ 185.540400] x7 : 0032 x6 : 000dc56c2000 [ 185.545707] x5 : 0020 x4 : 0ccd [ 185.551010] x3 : 803ff7196000 x2 : 08ed3300 [ 185.556313] x1 : 08ed3300 x0 : 0400 [ 185.561619] ********

Re: [PATCH v2 2/2] arm64: cacheinfo: add support to override cache levels via device tree

2017-01-13 Thread Tan Xiaojun
levels using device tree > to take such external non-architected caches into account. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Sudeep Holla Tested-by: Tan Xiaojun > --- > arch/arm64/kernel/cacheinfo.c | 13 - > 1 f

Re: [PATCH v2 1/2] of: base: add support to find the level of the last cache

2017-01-13 Thread Tan Xiaojun
: Rob Herring > Cc: Mark Rutland > Signed-off-by: Sudeep Holla Tested-by: Tan Xiaojun > --- > drivers/of/base.c | 27 +++ > include/linux/of.h | 1 + > 2 files changed, 28 insertions(+) > > v1->v2: > - Moved to using "cache-level&qu

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

2016-11-07 Thread Tan Xiaojun
On 2016/11/7 21:26, Arnd Bergmann wrote: > On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: >> From: Tan Xiaojun >> >> The Hisilicon Djtag is an independent component which connects >> with some other components in the SoC by Debug Bus.

Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver

2016-07-24 Thread Tan Xiaojun
On 2016/7/22 21:27, Arnd Bergmann wrote: > On Friday, July 22, 2016 11:56:49 AM CEST Mark Rutland wrote: >> Hi, >> >> I understand that some SoC/socket level PMU is accessed via these >> registers. It doesn't make sense to review either in isolation. Please >> put together a unified series, with bo

Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver

2016-07-24 Thread Tan Xiaojun
> > On it's own, it's *very* difficult to understand how this fits into the > SoC, and how it is to be used. > > Thanks, > Mark. > OK. Thank you for your suggestion. I need to think about it again. Thanks, Xiaojun. > On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan

Re: [RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver

2016-07-24 Thread Tan Xiaojun
On 2016/7/23 4:37, Paul Gortmaker wrote: > On Fri, Jul 22, 2016 at 4:48 AM, Tan Xiaojun wrote: >> The Hisilicon Djtag is an independent module which connects with some modules >> in the SoC by Debug Bus. This module can be configured to access the >> registers >> of

[RFC PATCH v1 2/2] drivers: soc: Add support for Hisilicon Djtag driver

2016-07-22 Thread Tan Xiaojun
The Hisilicon Djtag is an independent module which connects with some modules in the SoC by Debug Bus. This module can be configured to access the registers of connecting modules (like L3 cache) during real time debugging. This patch add the driver of Hisilicon Djtag. Signed-off-by: Tan Xiaojun

[RFC PATCH v1 0/2] Add Hisilicon Djtag driver

2016-07-22 Thread Tan Xiaojun
Tan Xiaojun (2): Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings drivers: soc: Add support for Hisilicon Djtag driver .../bindings/arm/hisilicon/hisilicon.txt | 98 + drivers/soc/Kconfig|1 + drivers/soc

[RFC PATCH v1 1/2] Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts bindings

2016-07-22 Thread Tan Xiaojun
First, add Hisilicon HiP05/06/07 CPU and ALGSUB system controller dts bindings. Then, add Hisilicon Djtag dts binding. Signed-off-by: Tan Xiaojun --- .../bindings/arm/hisilicon/hisilicon.txt | 98 1 file changed, 98 insertions(+) diff --git a/Documentation

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-28 Thread Tan Xiaojun
On 2016/6/28 12:57, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: >> Hi everyone, >> >> I'm sorry to bother you. But I was confused. >> >> The IP ID check (flush_id) in inet_gro_receive is only used by >> tcp

IP ID check (flush_id) in inet_gro_receive is necessary or not?

2016-06-27 Thread Tan Xiaojun
Hi everyone, I'm sorry to bother you. But I was confused. The IP ID check (flush_id) in inet_gro_receive is only used by tcp_gro_receive, and in tcp_gro_receive we have tcphdr check to ensure the order of skbs, like below: flush |= (__force int)(th->ack_seq ^ th

[PATCH for-next] EDAC: fix misuse of PAGES_TO_MiB macros

2015-10-20 Thread Tan Xiaojun
The PAGES_TO_MiB macros is only used for unit conversion. Signed-off-by: Tan Xiaojun --- drivers/edac/edac_mc.c | 2 +- drivers/edac/ghes_edac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c index 943ed8c..77ecd6a 100644

Re: [PATCH] debugfs: update commits of debugfs_remove

2015-10-13 Thread Tan Xiaojun
Please ignore this patch, I make a spelling mistake. On 2015/10/14 10:53, Tan Xiaojun wrote: > This function debugfs_remove can't remove a directory if it is not > empty. The commits make misunderstood and cause misuse easily, so > update it. > > Signed-off-by: Tan Xiaojun

[PATCH] debugfs: update commits of debugfs_remove

2015-10-13 Thread Tan Xiaojun
This function debugfs_remove can't remove a directory if it is not empty. The commits make misunderstood and cause misuse easily, so update it. Signed-off-by: Tan Xiaojun --- fs/debugfs/inode.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/debugfs/inode.c

[PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive instead of debugfs_remove

2015-10-13 Thread Tan Xiaojun
_mc module (like i3000_edac or others in drivers/edac/) 3)rmmod this module 4)we can also see files under /sys/kernel/debug/edac/ like "fake_inject" Reported-by: Yun Wu (Abel) Signed-off-by: Tan Xiaojun --- drivers/edac/debugfs.c | 2 +- drivers/edac/edac_mc_sysfs.c | 2 +- 2

Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

2015-10-13 Thread Tan Xiaojun
On 2015/10/13 15:41, Borislav Petkov wrote: > On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote: >> debugfs_remove is used to remove a file or an empty directory from >> the debugfs filesystem, but mci->debugfs is not empty. > > How exactly do you trigger thi

[PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

2015-10-12 Thread Tan Xiaojun
debugfs_remove is used to remove a file or an empty directory from the debugfs filesystem, but mci->debugfs is not empty. This is not easily discovered, because debugfs_remove return nothing when failed. Reported-by: Yun Wu (Abel) Signed-off-by: Tan Xiaojun --- drivers/edac/edac_mc_sysf

[PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit

2015-09-23 Thread Tan Xiaojun
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will overflow and size_bytes will be a big wrong number. Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below during system boot: * cma: Failed to reserve 17592186042368 MiB * Signed-off-by: Tan Xiao

Re: [PATCH] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit

2015-09-13 Thread Tan Xiaojun
Hi, please review and give some suggestions. Any suggestion by anyone is fine to me. Thanks Xiaojun On 2015/9/7 12:21, Tan Xiaojun wrote: > In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will > overflow and size_bytes will be a big wrong number. > > Set CONFIG_

[PATCH] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit

2015-09-06 Thread Tan Xiaojun
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will overflow and size_bytes will be a big wrong number. Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below during system boot: * cma: Failed to reserve 17592186042368 MiB * Signed-off-by: Tan Xiao

[PATCH] workqueue: Remove unused __cancel_delayed_work

2014-02-14 Thread Tan Xiaojun
We use safer cancel_delayed_work() instead of __cancel_delayed_work, and no one will use __cancel_delayed_work. So remove it. Signed-off-by: Tan Xiaojun --- include/linux/workqueue.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/include/linux/workqueue.h b/include/linux