On Thu, 16 Jan 2025 07:25:08 +0100,
John Stultz wrote:
>
> Betty reported hitting the following warning:
>
> [8.709131][ T221] WARNING: CPU: 2 PID: 221 at kernel/workqueue.c:4182
> ...
> [8.713282][ T221] Call trace:
> [8.713365][ T221] __flush_work+0x8d0/0x914
> [8.713468][
othing to be done for 'all'.
> make[4]: Leaving directory 'tools/testing/selftests/alsa'
>
> Cc: Mark Brown
> Cc: Jaroslav Kysela
> Cc: Takashi Iwai
> Cc: Shuah Khan
> Signed-off-by: Li Zhijian
Applied now. Thanks.
Takashi
alsa/utimer-test
>
> Cc: Mark Brown
> Cc: Jaroslav Kysela
> Cc: Takashi Iwai
> Cc: Shuah Khan
> Signed-off-by: Li Zhijian
Thanks, applied now.
Takashi
On Fri, 16 Feb 2024 14:48:10 +0100,
Michael S. Tsirkin wrote:
>
> On Fri, Feb 16, 2024 at 02:42:37PM +0100, Takashi Iwai wrote:
> > On Fri, 16 Feb 2024 12:27:48 +0100,
> > Michael S. Tsirkin wrote:
> > >
> > > On Fri, Feb 16, 2024 at 11:06:43AM +0100, Aiswar
On Fri, 16 Feb 2024 12:27:48 +0100,
Michael S. Tsirkin wrote:
>
> On Fri, Feb 16, 2024 at 11:06:43AM +0100, Aiswarya Cyriac wrote:
> > This commit fixes the following warning when building virtio_snd driver.
> >
> > "
> > *** CID 1583619: Uninitialized variables (UNINIT)
> > sound/virtio/virtio
On Wed, 14 Feb 2024 14:07:40 +0100,
Aiswarya Cyriac wrote:
>
>
> On Wed, 14 Feb 2024 12:30:19 +0100,
> Michael S. Tsirkin wrote:
> >>
> >> On Wed, Feb 14, 2024 at 09:08:26AM +, Aiswarya Cyriac wrote:
> >> > Hi Michael,
> >> >
> >> > Thank you for reviewing. I have updated my response inline
>
On Wed, 14 Feb 2024 12:30:19 +0100,
Michael S. Tsirkin wrote:
>
> On Wed, Feb 14, 2024 at 09:08:26AM +, Aiswarya Cyriac wrote:
> > Hi Michael,
> >
> > Thank you for reviewing. I have updated my response inline
> >
> > On Tue, Feb 13, 2024 at 09:51:30AM +0100, Aiswarya Cyriac wrote:
> > >> Fi
On Tue, 13 Feb 2024 10:07:35 +0100,
Michael S. Tsirkin wrote:
>
> On Tue, Feb 13, 2024 at 10:02:24AM +0100, Takashi Iwai wrote:
> > On Tue, 13 Feb 2024 09:51:30 +0100,
> > Aiswarya Cyriac wrote:
> > >
> > > Fix the following warning when building virtio_snd
On Tue, 13 Feb 2024 09:51:30 +0100,
Aiswarya Cyriac wrote:
>
> Fix the following warning when building virtio_snd driver.
>
> "
> *** CID 1583619: Uninitialized variables (UNINIT)
> sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op()
> 288
> 289 break;
> 290 }
> 291
> 292
On Mon, 15 Jan 2024 14:36:53 +0100,
Aiswarya Cyriac wrote:
>
> From: Anton Yakovlev
>
> Changes in v2
> - Fix reporting of incorrect number of items for ENUMERATED controls
>
> Implementation of support for audio controls in accordance with the
> extension of the virtio sound device specificati
On Fri, 08 Sep 2023 10:10:40 +0200,
Ding Xiang wrote:
>
> These variables are never referenced in the code, just remove them.
>
> Signed-off-by: Ding Xiang
Thanks, applied.
Takashi
On Fri, 16 Apr 2021 20:30:05 +0200,
Daniel Vetter wrote:
>
> On Fri, Apr 16, 2021 at 2:53 PM Takashi Iwai wrote:
> >
> > Currently the DRM fbcon helper for console blank,
> > drm_fb_helper_blank(), simply calls drm_fb_helper_dpms() and always
> > returns zero, sup
On Tue, 20 Apr 2021 15:47:19 +0200,
Colin King wrote:
>
> From: Colin Ian King
>
> Currently when the call to usb_urb_ep_type_check fails (returning -EINVAL)
> the error return path returns -ENOMEM via the exit label "error". Other
> uses of the same error exit label set the err variable to -ENO
On Tue, 20 Apr 2021 13:55:29 +0200,
Kai-Heng Feng wrote:
>
> On HP EliteBook 845 G8, the audio LEDs can be enabled by
> ALC285_FIXUP_HP_MUTE_LED. So use it accordingly.
>
> In addition to that, the mic captures lots of noises, so also limits the
> mic boost. The quality of capture audio becomes c
On Mon, 19 Apr 2021 05:04:11 +0200,
Luke D Jones wrote:
>
> The GA503 has almost exactly the same default setup as the GA401
> model with the same issues. The GA401 quirks solve all the issues
> so we will use the full quirk chain.
>
> Signed-off-by: Luke D Jones
Thanks, applied now.
Takashi
144-1-ti...@suse.de/
BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1095700
Signed-off-by: Takashi Iwai
---
Here I whip a dead horse again, revisiting the long-standing issue
stated in the previous patch set in 2017:
https://lore.kernel.org/dri-devel/20170726205636.19144-1-ti...@suse.de/
I tho
On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
>
> Kernel test robot throws below warning ->
>
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
>
> Fixed the inconsistent indenting.
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang
On Fri, 16 Apr 2021 11:59:58 +0200,
Yang Li wrote:
>
> Kernel test robot throws below warning ->
>
> smatch warnings:
> sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
> inconsistent indenting
> sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
> inconsistent indenti
On Thu, 08 Apr 2021 14:54:29 +0200,
Chen Huang wrote:
>
> module_virtio_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Chen Huang
Thanks, applied now.
Takashi
On Thu, 08 Apr 2021 18:56:06 +0200,
Ville Syrjälä wrote:
>
> On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote:
> > On Thu, 08 Apr 2021 09:51:18 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 07 Apr 2021 23:28:48 +0200,
> > > Ville Syrj
On Thu, 08 Apr 2021 09:51:18 +0200,
Takashi Iwai wrote:
>
> On Wed, 07 Apr 2021 23:28:48 +0200,
> Ville Syrjälä wrote:
> >
> > Oh, could you ask the bug reporter to attach an acpidump to the
> > bug? Might be good to have that stuff on record somewhere if/when
&g
Srinivas Kandagatla (2):
ASoC: codecs: lpass-tx-macro: set npl clock rate correctly
ASoC: codecs: lpass-rx-macro: set npl clock rate correctly
Takashi Iwai (2):
ALSA: hda/conexant: Apply quirk for another HP ZBook G5 model
ALSA: hda/realtek: Fix speaker amp setup on Acer Aspire
On Wed, 07 Apr 2021 23:28:48 +0200,
Ville Syrjälä wrote:
>
> On Wed, Apr 07, 2021 at 06:56:15PM +0200, Takashi Iwai wrote:
> > On Wed, 07 Apr 2021 18:34:46 +0200,
> > Ville Syrjälä wrote:
> > >
> > > On Fri, Apr 02, 2021 at
On Wed, 07 Apr 2021 18:34:46 +0200,
Ville Syrjälä wrote:
>
> On Fri, Apr 02, 2021 at 10:23:17AM +0200, Takashi Iwai wrote:
> > intel_dsm_platform_mux_info() tries to parse the ACPI package data
> > from _DSM for the debug information, but it assumes the fixed format
> &g
reported recently.
Add the checks of the contents in the returned values and skip the
values for invalid cases.
v1->v2: Check the info contents before dereferencing, too
BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/disp
On Fri, 02 Apr 2021 09:47:49 +0200,
Takashi Iwai wrote:
>
> intel_dsm_platform_mux_info() tries to parse the ACPI package data
> from _DSM for the debug information, but it assumes the fixed format
> without checking what values are stored in the elements actually.
> When an unex
reported recently.
Add the checks of the contents in the returned values and skip the
values for invalid cases.
BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/display/intel_acpi.c | 12
1 file changed, 12 insertions
alc_update_headset_mode() in hp_automute_hook
Ikjoon Jang (1):
ALSA: usb-audio: Apply sample rate quirk to Logitech Connect
Jeremy Szu (1):
ALSA: hda/realtek: fix mute/micmute LEDs for HP 640 G8
Takashi Iwai (2):
ALSA: hda: Re-add dropped snd_poewr_change_state() calls
ALSA: hda: Add
On Tue, 30 Mar 2021 13:44:27 +0200,
Jeremy Szu wrote:
>
> The HP EliteBook 640 G8 Notebook PC is using ALC236 codec which is
> using 0x02 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu
Thanks, applied now.
Takashi
On Tue, 30 Mar 2021 04:31:55 +0200,
wrote:
>
> Hi Takashi,
>
> Thanks a lot for your review!
>
> > On Mon, 29 Mar 2021 05:36:47 +0200,
> > root wrote:
> > >
> > > [1.1.1 ]
> > >
> > > From: Jia Zhou
> > >
> > > modification in commit 2a3f7221acdd ("ALSA: core: Fix card races between
> > > reg
On Mon, 29 Mar 2021 05:36:47 +0200,
root wrote:
>
> [1.1.1 ]
>
> From: Jia Zhou
>
> modification in commit 2a3f7221acdd ("ALSA: core: Fix card races between
> register and disconnect") resulting in this problem.
>
> Signed-off-by: Jia Zhou
> Signed-off-by: Yi Wang
The code change looks goo
On Mon, 29 Mar 2021 08:23:52 +0200,
Ikjoon Jang wrote:
>
> On Wed, Mar 24, 2021 at 8:49 PM Takashi Iwai wrote:
> >
> > On Wed, 24 Mar 2021 13:03:14 +0100,
> > Ikjoon Jang wrote:
> > >
> > > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund
> > >
On Fri, 26 Mar 2021 07:42:11 +0100,
Bhaskar Chowdhury wrote:
>
>
> s/unconditonally/unconditionally/
> s/succesful/successful/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> Changes from V3:
> Yet another try to make it work
Applied now. Thanks.
Takashi
an be device specific, however I think this generic approach may
> benefit more than one device.
>
> Now the resume callback checks connector, and a new callback,
> reset_resume, to also restore switches and volumes.
>
> Suggested-by: Takashi Iwai
> Signed-off-by: Kai-Heng F
On Thu, 25 Mar 2021 17:59:12 +0100,
Kai-Heng Feng wrote:
>
> This is preparation for next patch, no functional change intended.
>
> Signed-off-by: Kai-Heng Feng
Applied now. Thanks.
Takashi
> ---
> v3:
> - No change.
> v2:
> - Only return early when ret < 0.
>
> sound/usb/mixer.c | 34 +
On Thu, 25 Mar 2021 09:36:41 +0100,
Muhammad Usama Anjum wrote:
>
> The returned value by create_autodetect_quirk isn't being used other
> than in the success check on next line. Remove the return value
> assignement. Check for error values instead of success check.
>
> Signed-off-by: Muhammad Us
On Thu, 25 Mar 2021 15:24:42 +0100,
Kai-Heng Feng wrote:
>
> On Thu, Mar 25, 2021 at 9:55 PM Kai-Heng Feng
> wrote:
> >
> > On Thu, Mar 25, 2021 at 9:41 PM Takashi Iwai wrote:
> > >
> > > On Thu, 25 Mar 2021 13:12:48 +0100,
> > > Kai-Heng Fen
On Thu, 25 Mar 2021 13:12:48 +0100,
Kai-Heng Feng wrote:
>
> Rear Mic on Lenovo P620 cannot record after S3, despite that there's no
> error and the other two functions of the USB audio, Line In and Line
> Out, work just fine.
>
> The mic starts to work again after running userspace app like "als
On Thu, 25 Mar 2021 10:56:39 +0100,
Bhaskar Chowdhury wrote:
>
> On 10:37 Thu 25 Mar 2021, Takashi Iwai wrote:
> >On Thu, 25 Mar 2021 10:06:09 +0100,
> >Bhaskar Chowdhury wrote:
> >>
> >> s/unconditonally/unconditionally/
> >> s/succesful/successfu
On Thu, 25 Mar 2021 10:06:09 +0100,
Bhaskar Chowdhury wrote:
>
> s/unconditonally/unconditionally/
> s/succesful/successful/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> Changes from V2:
> Takashi pointed out that the patch was not applicable due to some unwanted
> stuff get into it. Resendin
On Thu, 25 Mar 2021 02:36:31 +0100,
Bhaskar Chowdhury wrote:
>
>
> s/unconditonally/unconditionally/
> s/succesful/successful/
>
> Signed-off-by: Bhaskar Chowdhury
The patch isn't cleanly applicable, some space was put at the
beginning of the line incorrectly. Possibly a MUA problem?
Could yo
On Wed, 24 Mar 2021 18:14:08 +0100,
Kai-Heng Feng wrote:
>
> Rear Mic on Lenovo P620 cannot record after S3, despite that there's no
> error and the other two functions of the USB audio, Line In and Line
> Out, work just fine.
>
> The mic starts to work again after running userspace app like "als
On Wed, 24 Mar 2021 13:03:14 +0100,
Ikjoon Jang wrote:
>
> On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund
> wrote:
>
> On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote:
> > Logitech ConferenceCam Connect is a compound USB device with UVC and
> > UAC. Not 100% reproducible but som
On Mon, 22 Mar 2021 11:31:10 +0100,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> Building with 'make W=1' shows some warnings about empty function-style
> macros:
>
> sound/core/pcm_memory.c: In function 'preallocate_pages':
> sound/core/pcm_memory.c:236:49: error: suggest braces around emp
On Sun, 21 Mar 2021 09:59:48 +0100,
Fengfei Xi wrote:
>
> Remove unnecessary blank when calling kmalloc_array().
>
> Signed-off-by: Fengfei Xi
Thanks for the patch.
We apply this kind of trivial coding-style fix only if it'd improve
the readability significantly or when it's a preliminary work
On Sun, 21 Mar 2021 16:38:37 +0100,
Tong Zhang wrote:
>
> This series fixes issues in hdsp and hdspm. The drivers in question want
> to disable a device that is not enabled on error path.
>
> v2: add fix to rme9652
> v3: change checks to pci_is_enabled()
>
> Tong Zhang (3):
> ALSA: hdsp: don't
On Sat, 20 Mar 2021 23:23:33 +0100,
Tong Zhang wrote:
>
> This series fixes issues in hdsp and hdspm. The drivers in question want
> to disable a device that is not enabled on error path.
>
> v2: add fix to rme9652
>
> Tong Zhang (3):
> ALSA: hdsp: don't disable if not enabled
> ALSA: hdspm:
On Fri, 19 Mar 2021 02:38:54 +0100,
huangjianghui wrote:
>
> Signed-off-by: huangjianghui
Thanks, applied.
Takashi
Linus,
please pull sound fixes for v5.12-rc4 from:
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
tags/sound-5.12-rc4
The topmost commit is 50b1affc891cbc103a2334ce909a026e25f4c84d
sound fixes for 5.12-rc4
Majo
On Thu, 18 Mar 2021 14:20:08 +0100,
Colin King wrote:
>
> From: Colin Ian King
>
> The shifting of the u8 integer device by 24 bits to the left will
> be promoted to a 32 bit signed int and then sign-extended to a
> 64 bit unsigned long. In the event that the top bit of device is
> set then all
On Thu, 18 Mar 2021 11:50:37 +0100,
Johannes Berg wrote:
>
> Hi,
>
> > OK, I took a deeper look again, and actually there are two issues in
> > systemd-rfkill code:
> >
> > * It expects 8 bytes returned from read while it reads a struct
> > rfkill_event record. If the code is rebuilt with the
On Thu, 18 Mar 2021 10:36:19 +0100,
Johannes Berg wrote:
>
> Hi Takashi,
>
> Oh yay :-(
>
> > we've received a bug report about rfkill change that was introduced in
> > 5.11. While the systemd-rfkill expects the same size of both read and
> > write, the kernel rfkill write cuts off to the old 8
On Tue, 16 Mar 2021 13:43:17 +0100,
hjh wrote:
>
> Signed-off-by: hjh
The Signed-off-by line needs the real name.
See Documentation/process/submitting-patches.rst for details.
thanks,
Takashi
On Wed, 17 Mar 2021 21:39:32 +0100,
Aditya Srivastava wrote:
>
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> There are files in sound/pci/ctxfi which follow this syntax in their file
> headers, i.e. start with '/**' like comments, which causes
On Wed, 17 Mar 2021 21:21:44 +0100,
Aditya Srivastava wrote:
>
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> There are files in sound/pci/asihpi which follow this syntax in their file
> headers, i.e. start with '/**' like comments, which causes
Hi,
we've received a bug report about rfkill change that was introduced in
5.11. While the systemd-rfkill expects the same size of both read and
write, the kernel rfkill write cuts off to the old 8 bytes while read
gives 9 bytes, hence it leads the error:
https://github.com/systemd/systemd/issu
On Tue, 16 Mar 2021 10:42:35 +0100,
Jeremy Szu wrote:
>
> The HP EliteBook 850 G8 Notebook PC is using ALC285 codec which is
> using 0x04 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu
Applied now.
But at the next t
On Tue, 16 Mar 2021 08:46:24 +0100,
Jeremy Szu wrote:
>
> The HP EliteBook 840 G8 Notebook PC is using ALC236 codec which is
> using 0x02 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu
Thanks, applied.
Takashi
On Mon, 15 Mar 2021 20:07:12 +0100,
Vitaly Rodionov wrote:
>
> This series of patches will address comments by Pierre-Louis Bossart,
> cleans up patch_cirrus.c source, reducing checkpatch.pl warnings from 19 to 0,
> fixing an issue reported by Canonical: BugLink:
> https://bugs.launchpad.net/bugs
On Tue, 16 Mar 2021 07:54:50 +0100,
Jeremy Szu wrote:
>
> * The HP EliteBook 840 G8 Notebook PC is using ALC285 codec which is
>using 0x04 to control mute LED and 0x01 to control micmute LED.
>Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu
Thanks, applied.
Tak
On Mon, 15 Mar 2021 16:37:32 +0100,
Vitaly Rodionov wrote:
>
> >> @@ -1881,13 +1896,15 @@ static void cs8409_jack_unsol_event(struct
> >> hda_codec *codec, unsigned int res)
> >>reg_hs_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1124, 1);
> >>reg_ts_status = cs8409_i2c_read(codec,
On Sat, 13 Mar 2021 12:34:10 +0100,
Vitaly Rodionov wrote:
> @@ -1357,6 +1362,22 @@ static const struct hda_verb
> cs8409_cs42l42_init_verbs[] = {
> { 0x47, AC_VERB_SET_PROC_COEF, 0x0080 }, /* I2C mode */
> { 0x47, AC_VERB_SET_COEF_INDEX, 0x005b }, /* Set I2C bus speed */
>
On Sat, 13 Mar 2021 12:34:07 +0100,
Vitaly Rodionov wrote:
>
> @@ -1508,7 +1508,7 @@ static void cs8409_enable_i2c_clock(struct hda_codec
> *codec, unsigned int flag)
> static int cs8409_i2c_wait_complete(struct hda_codec *codec)
> {
> int repeat = 5;
> - unsigned int retval = 0;
> +
On Sat, 13 Mar 2021 12:34:06 +0100,
Vitaly Rodionov wrote:
>
> This series of patches will address comments by Pierre-Louis Bossart,
> cleans up patch_cirrus.c source, reducing checkpatch.pl warnings from 19 to 0,
> fixing an issue reported by Canonical: BugLink:
> https://bugs.launchpad.net/bugs
{
> ^
>
> The last two branches do the same thing and can be collapsed together.
>
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
thanks,
Takashi
_one_line = 1;
> ^
>
> Likely copy/paste.
>
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
thanks,
Takashi
_one_line = 1;
> ^
>
> Likely copy/paste.
>
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Takashi Iwai
thanks,
Takashi
> ---
> sound/soc/codecs/cx2072x.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/so
On Fri, 12 Mar 2021 10:36:25 +0100,
Xu Wang wrote:
>
> Remove extra brackets.
>
> Signed-off-by: Xu Wang
Thanks for the patch. But this kind of change alone makes little
benefit, as it doesn't improve the readability significantly.
So I'd take such a change only if it's really needed, e.g. if
):
ALSA: hda/ca0132: Add Sound BlasterX AE-5 Plus support
Takashi Iwai (7):
ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar
ALSA: usb-audio: Apply the control quirk to Plantronics headsets
ALSA: hda/conexant: Add quirk for mute LED control on H
On Thu, 11 Mar 2021 15:22:22 +0100,
Andy Shevchenko wrote:
>
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai wrote:
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries for better mai
On Thu, 11 Mar 2021 15:02:16 +0100,
Andy Shevchenko wrote:
>
> On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai wrote:
> >
> > On Thu, 11 Mar 2021 14:27:41 +0100,
> > Andy Shevchenko wrote:
> > >
> > > Sort alphanumerically the SND_PCI_QUIRK() entries f
On Thu, 11 Mar 2021 14:27:41 +0100,
Andy Shevchenko wrote:
>
> Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> No functional change implied.
I'd love to apply this kind of cleanups (and I do sometimes
partially), but practically seen, this may make the stable backporti
On Thu, 11 Mar 2021 14:27:48 +0100,
Andy Shevchenko wrote:
>
> Sort alphanumerically the HDA_CODEC_ENTRY() entries for better maintenance.
> No functional change implied.
>
> Note, that HDA_CODEC_REV_ENTRY() goes after HDA_CODEC_ENTRY() as per
> default value in the latter macro.
This breaks the
devices on Intel devices.
>
> To fix this problem, this patch exports the existing dmi_available
> variable and tests it in the ASoC core.
>
> Fixes: c014170408bc ("ASoC: soc-core: Prevent warning if no DMI table is
> present")
> Signed-off-by: Pierre-Louis Bossart
On Wed, 10 Mar 2021 17:18:14 +0100,
Mark Brown wrote:
>
> On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote:
> > On 3/10/21 7:35 AM, Mark Brown wrote:
>
> > > Just change it to a system level check for ACPI, checking for OF would
> > > leave problems for board files or any othe
On Tue, 09 Mar 2021 12:32:18 +0100,
syzbot wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:4641b323 Add linux-next specific files for 20210305
> git tree: linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=103252ead0
> kernel config:
On Tue, 09 Mar 2021 02:58:33 +0100,
Stephen Rothwell wrote:
>
> Hi all,
>
> Today's linux-next merge of the vhost tree got conflicts in:
>
> sound/virtio/virtio_card.c
> sound/virtio/virtio_card.h
> sound/virtio/virtio_ctl_msg.c
> sound/virtio/virtio_pcm.c
> sound/virtio/virtio_pcm.h
>
On Mon, 08 Mar 2021 23:30:57 +0100,
Pavel Skripkin wrote:
>
> The problem was in wrong "if" placement. chip->quirk_type is freed
> in snd_card_free_when_closed(), but inside if statement it's accesed.
>
> Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in
> setup_disable_
On Mon, 08 Mar 2021 23:30:36 +0100,
Pavel Skripkin wrote:
>
> syzbot reported null pointer dereference in usb_audio_probe.
> The problem was in case, when quirk == NULL. It's not an
> error condition, so quirk must be checked before dereferencing.
>
> Call Trace:
> usb_probe_interface+0x315/0x7f
On Mon, 08 Mar 2021 19:48:35 +0100,
Simeon Simeonoff wrote:
>
>
> The new AE-5 Plus model has a different Subsystem ID compared to the
> non-plus model. Adding the new id to the list of quirks.
>
> Signed-off-by: Simeon Simeonoff
Thanks, applied now.
Takashi
On Sat, 06 Mar 2021 12:19:30 +0100,
Vitaly Rodionov wrote:
>
> Dell's laptops Inspiron 3500, Inspiron 3501, Inspiron 3505 are using
> Cirrus Logic CS8409 HDA bridge with CS42L42 companion codec.
>
> The CS8409 is a multichannel HD audio routing controller.
> CS8409 includes support for four chann
On Thu, 04 Mar 2021 20:02:37 +0100,
Vitaly Rodionov wrote:
>
> Dell's laptops Inspiron 3500, Inspiron 3501, Inspiron 3505 are using
> Cirrus Logic CS8409 HDA bridge with CS42L42 companion codec.
>
> The CS8409 is a multichannel HD audio routing controller.
> CS8409 includes support for four chann
On Wed, 03 Mar 2021 19:29:59 +0100,
Vitaly Rodionov wrote:
>
> +static int cs8409_cs42l42_volume_get(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
> + hda_nid_t nid = get_
On Wed, 03 Mar 2021 19:29:58 +0100,
Vitaly Rodionov wrote:
> @@ -1243,6 +1258,8 @@ static int patch_cs4213(struct hda_codec *codec)
> #define CIR_I2C_QWRITE 0x005D
> #define CIR_I2C_QREAD0x005E
>
> +static struct mutex cs8409_i2c_mux;
Any reason that this must be the global mutex
On Wed, 03 Mar 2021 19:29:57 +0100,
Vitaly Rodionov wrote:
>
> +static const struct hda_verb cs8409_cs42l42_init_verbs[] = {
> + { 0x01, AC_VERB_SET_POWER_STATE, 0x },/* AFG: D0 */
I guess this power state change is superfluous. The AFG node is
already powered up when the codec probe
ASoC: SOF: Intel: SoundWire: simplify Kconfig
ALSA: hda: move Intel SoundWire ACPI scan to dedicated module
ALSA: hda: intel-sdw-acpi: add missing include files
Takashi Iwai (4):
ALSA: usb-audio: Don't abort even if the clock rate differs
ALSA: usb-audio: Drop bogus dB
On Thu, 04 Mar 2021 05:34:16 +0100,
Kai-Heng Feng wrote:
>
> Rear audio on Lenovo ThinkStation P620 stops working after commit
> 1965c4364bdd ("ALSA: usb-audio: Disable autosuspend for Lenovo
> ThinkStation P620"):
> [6.013526] usbcore: registered new interface driver snd-usb-audio
> [6.02
On Wed, 03 Mar 2021 19:14:39 +0100,
John Ernberg wrote:
>
> The microphone in the Plantronics C320-M headset will randomly
> fail to initialize properly, at least when using Microsoft Teams.
> Introducing a 20ms delay on the control messages appears to
> resolve the issue.
>
> Link: https://gitla
On Tue, 02 Mar 2021 19:04:14 +0100,
Werner Sembach wrote:
>
> ALSA: hda/realtek: Add quirk for Intel NUC 10
I guess you added a subject line twice here. This line can be dropped.
> This adds a new SND_PCI_QUIRK(...) and applies it to the Intel NUC 10
> devices. This fixes the issue of the devic
On Tue, 02 Mar 2021 17:25:22 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device h
On Tue, 02 Mar 2021 13:49:13 +0100,
Mark Brown wrote:
>
> On Tue, Mar 02, 2021 at 09:27:12AM +, Jon Hunter wrote:
> > Many systems do not provide a DMI table and on these systems a warning,
> > such as the following, is printed on boot ...
> >
> > WARNING KERN tegra-audio-graph-card sound: A
On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device h
On Tue, 02 Mar 2021 04:40:53 +0100,
dingsen...@163.com wrote:
>
> From: dingsenjie
>
> vaules -> values
>
> Signed-off-by: dingsenjie
Thanks, applied.
Takashi
On Tue, 02 Mar 2021 09:09:33 +0100,
Anton Yakovlev wrote:
>
> On 02.03.2021 07:48, Takashi Iwai wrote:
> > On Tue, 02 Mar 2021 07:29:20 +0100,
> > Anton Yakovlev wrote:
> >>
> >> On 28.02.2021 13:05, Takashi Iwai wrote:
> >>> On Sat, 27 Feb
On Tue, 02 Mar 2021 07:29:20 +0100,
Anton Yakovlev wrote:
>
> On 28.02.2021 13:05, Takashi Iwai wrote:
> > On Sat, 27 Feb 2021 09:59:56 +0100,
> > Anton Yakovlev wrote:
> >>
>
> [snip]
>
> >> --- a/sound/virtio/virtio_pcm.c
> >> +++ b/sou
On Mon, 01 Mar 2021 16:24:00 +0100,
Anton Yakovlev wrote:
>
> On 01.03.2021 15:56, Takashi Iwai wrote:
> > On Mon, 01 Mar 2021 15:47:46 +0100,
> > Anton Yakovlev wrote:
> >>
> >> On 01.03.2021 14:32, Takashi Iwai wrote:
> >>> On Mon, 01 Mar
On Mon, 01 Mar 2021 15:47:46 +0100,
Anton Yakovlev wrote:
>
> On 01.03.2021 14:32, Takashi Iwai wrote:
> > On Mon, 01 Mar 2021 10:25:05 +0100,
> > Anton Yakovlev wrote:
> >>
> >> On 28.02.2021 12:27, Takashi Iwai wrote:
> >>> On Sat, 27 Feb
On Mon, 01 Mar 2021 11:03:04 +0100,
Anton Yakovlev wrote:
>
> On 28.02.2021 13:05, Takashi Iwai wrote:
> > On Sat, 27 Feb 2021 09:59:56 +0100,
> > Anton Yakovlev wrote:
> >>
> >> All running PCM substreams are stopped on device suspend and restarted
> >&
On Mon, 01 Mar 2021 10:29:24 +0100,
Anton Yakovlev wrote:
>
> On 28.02.2021 12:32, Takashi Iwai wrote:
> > On Sat, 27 Feb 2021 09:59:53 +0100,
> > Anton Yakovlev wrote:
> >>
>
>
> [snip]
>
>
> >> +static snd_pcm_uframes_t
> >&
On Mon, 01 Mar 2021 10:25:05 +0100,
Anton Yakovlev wrote:
>
> On 28.02.2021 12:27, Takashi Iwai wrote:
> > On Sat, 27 Feb 2021 09:59:52 +0100,
> > Anton Yakovlev wrote:
> >> +/**
> >> + * virtsnd_pcm_event() - Handle the PCM device event notification
1 - 100 of 2320 matches
Mail list logo
