On Tuesday, 8 December 2020 08:48:56 CET Enrico Weigelt, metux IT consult wrote:
> > Is there some explanation besides an opinion? Some kind goal which you want
> > to
> > achieve with it maybe?
>
> Just a cleanup. I've been under the impression that this version is just
> an relic from oot time
On Friday, 27 November 2020 19:54:30 CET ron minnich wrote:
> Thanks, Sven, for your patience, I will indeed try to test this next week.
Any test results?
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
Is there some explanation besides an opinion? Some kind goal which you want to
achieve with it maybe?
A
On Friday, 27 November 2020 18:16:54 CET ron minnich wrote:
> What none of the people involved in the original patch knew was that
> there would be other ':' in use. Sorry!
>
> But you are right, my idea is a complete non-starter, don't know what
> I was thinking.
I am still not sure because I st
On Friday, 27 November 2020 17:32:02 CET ron minnich wrote:
> I'm a bit worried about how tricky this starts to get. I'm inclined to
> go back to an earlier implementation which used a character that had
> not yet been used (iirc I used [] around the PCI ID in a very early
> version). What if we us
vice. The first
caller of net_dev_xmit could therefore never make sure that enough headroom
was allocated for the rest of the transmit path.
Cc: Annika Wickert
Signed-off-by: Sven Eckelmann
---
drivers/net/vxlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxlan.c b/dr
While vxlan doesn't need any extra tailroom, the lowerdev might need it. In
that case, copy it over to reduce the chance for additional (re)allocations
in the transmit path.
Signed-off-by: Sven Eckelmann
---
drivers/net/vxlan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/driver
d if I see it correctly, this is also affecting the kernel (4.14) for
the OpenWrt 18.06.x + 19.07.x branch because it can also be found in
there as part of the v4.14.200 release.
Another workaround is to replace the first "(" with a NULL too. See the
attached patch for the one which I used
On Sunday, 20 September 2020 21:59:19 CEST Stephen Rothwell wrote:
> Hi all,
Yes, I've accidentally swapped the IDs while adding them to the various patches.
The correct ones should have been:
* 097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash
indexing")
Fixes: 07568d0369
On Friday, 18 September 2020 05:03:19 CEST Xiyu Yang wrote:
> batadv_neigh_node_create() is used to create a neigh node object, whose
> fields will be initialized with the specific object. When a new
> reference of the specific object is created during the initialization,
> its refcount should be i
On Tuesday, 7 July 2020 17:30:14 CEST syzbot wrote:
> general protection fault, probably for non-canonical address
> 0xdc0e: [#1] PREEMPT SMP KASAN
> KASAN: null-ptr-deref in range [0x0070-0x0077]
> CPU: 1 PID: 9126 Comm: kworker/u4:9 Not tainted 5.8.0-rc3-
John Deere <24601dee...@gmail.com>
[s...@narfation.org: adjust commit message]
Signed-off-by: Sven Eckelmann
---
v5:
* add additional tested devices
* restructure commit message
v4:
* updated signed-off-by
v3:
* Rebased on TOT and added Tested-by
Everything expect QCA9984 hw1.0 firmware 10.4
On Tuesday, 21 May 2019 21:04:31 CEST Jonathan Corbet wrote:
> It was just a sigh because there was a little mess that I needed to clean
> up — one that I had failed to clean up correctly on my first attempt.
> That's all. Apologies for giving you any other sort of impression, that
> was not intend
On Tuesday, 21 May 2019 20:46:03 CEST Jonathan Corbet wrote:
> On Tue, 21 May 2019 20:23:48 +0200
> Sven Eckelmann wrote:
>
> > >
> >
> > It is ok, I will never send you any patch again.
>
> I'm hoping that's meant to be a joke...? This is cert
On Tuesday, 21 May 2019 17:31:07 CEST Jonathan Corbet wrote:
>
It is ok, I will never send you any patch again.
> We want those tags to be right. I'm going to fix this and force-push,
> hopefully nobody will get too made at me...
Kind regards,
Sven
signature.asc
Description: This is
On Monday, 20 May 2019 23:54:23 CEST Jonathan Corbet wrote:
[...]
> Argh, sorry, I should have caught that. Fixed, thanks.
Thanks for trying. Unfortunately it was changed to the wrong value. The actual
commit I wanted to reference in both places of the commit message was:
8ea8814fcdcb ("LIC
On Monday, 20 May 2019 23:44:35 CEST Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 9eaa65e8aad5 ("scripts/spdxcheck.py: Add dual license subdirectory")
>
> Fixes tag
>
> Fixes: 99871f2f9a4d ("scripts/spdxcheck.py: Fix path to deprecated
> licenses")
[...]
Sorry, my fault. I actually
L-2.0 OR Apache-2.0 */' is not supported
in LICENSES/...
#1: FILE: drivers/staging/android/ashmem.h:1:
+/* SPDX-License-Identifier: GPL-2.0 OR Apache-2.0 */
Cc: Jonathan Corbet
Cc: Christoph Hellwig
Fixes: 99871f2f9a4d ("scripts/spdxcheck.py: Fix path to deprecated licenses")
quot;, line 298, in
__getitem__
return self.join(item)
File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 244, in
join
raise KeyError(msg % file)
KeyError: "Blob or Tree named 'other' not found"
Cc: Jonathan Corbet
Cc: Christoph
On Sunday, 20 January 2019 19.39.55 CET Joe Perches wrote:
> Well, maybe checkpatch should remove the comment trailer.
> ---
> Miscellanea:
In case you are waiting for me (haven't seen it popping up in linux-next):
yes, this patch solves the problem for me.
Tested-by: Sven Ecke
On Wednesday, 16 January 2019 11.26.53 CET Thomas Gleixner wrote:
> The SuperH boot code files use a magic format for the SPDX identifier
> comment:
>
> LIST "SPDX-License-Identifier: "
>
> The trailing quotation mark is not stripped before the token parser is
> invoked and causes the scan
On Sunday, 30 December 2018 11.41.03 CET syzbot wrote:
[...]
> HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=122a373f40
> kernel config: https://syzkaller.appspot.com/x/.config
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 69c0d85bceb3..e0007f242823 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -109,7 +109,10 @@ static int __init batadv_init(void)
> ba
On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote:
[...]
> -static int batadv_interface_tx(struct sk_buff *skb,
> +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb,
> struct net_device *soft_iface)
> {
> struct ethhdr *ethhdr;
>
CHECK
Hi,
On Mittwoch, 18. April 2018 12:45:20 CEST Sricharan R wrote:
> Right, will add the above change to soc.dtsi in V6. Does that sound ok for
> you ?
I have submitted a patch for this now [1] because I need this for OpenWrt
(sooner rather than later). And I am not sure whether it is good to ha
On Mittwoch, 18. April 2018 08:59:46 CEST Sven Eckelmann wrote:
[...]
> I would not know how to disable QSEE on these boards and thus would assume
> that it should be part of this dtsi.
Just did some reviews of the reserved-memory regions in other QCA devices and
it looks like this tz an
On Freitag, 23. März 2018 15:48:48 CEST Sricharan R wrote:
> Add the common parts for the dk04 boards.
>
> Reviewed-by: Abhishek Sahu
> Signed-off-by: Sricharan R
> ---
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 115
> ++
> arch/arm/boot/dts/qcom-ipq4019.dtsi
On Freitag, 23. März 2018 15:48:51 CEST Sricharan R wrote:
> Add the common data for all dk07 based boards.
>
> Reviewed-by: Abhishek Sahu
> Signed-off-by: Sricharan R
> ---
> arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 69
> +++
> 1 file changed, 69 insertions(+)
>
On Freitag, 23. März 2018 23:53:50 CET Colin King wrote:
> From: Colin Ian King
>
> In the case where hard_iface is NULL, the error path may pass a null
> pointer to batadv_hardif_put causing a null pointer dereference error.
> Avoid this by only calling the function if hard_iface not null.
>
>
On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote:
> On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote:
> > It's somewhat common and in general a defect for c90 keywords to
> > not start on a tabstop.
> >
> > Add a test for this condition an
On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote:
> It's somewhat common and in general a defect for c90 keywords to
> not start on a tabstop.
>
> Add a test for this condition and warn when it occurs.
This seems to create some new false positives:
WARNING: Statements should star
ETH_P_BATMAN ethernet
packets.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS | 1 +
net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8
net/batman-adv/bat_iv_ogm.c | 2 +-
net/batman-adv/bat_
The headers used by packet.h should also be included by it directly. main.h
is currently dealing with it in batman-adv, but this will no longer work
when this header is moved to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/main.h | 2 --
net/batman-adv/packet.h | 2
The BIT(x) macro is no longer available for uapi headers because it is
defined outside of it (linux/bitops.h). The use of it must therefore be
avoided and replaced by an appropriate other representation.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 23 +++
1
the same neighbor to different cores.
Signed-off-by: Sven Eckelmann
---
net/core/flow_dissector.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 15ce30063765..fa0a4879fb9d 100644
--- a
The uapi headers use the __u8/__u16/... version of the fixed width types
instead of u8/u16/... The use of the latter must be avoided before
packet.h is copied to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 214
ast packet header definition from flow_dissector.c
* moved the batman-adv packet.h/uapi headers around to provide the correct
definitions to flow_dissector.c
Kind regards,
Sven
Sven Eckelmann (5):
batman-adv: Let packet.h include its headers directly
batman-adv: Remove usage of
On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote:
[]
> Thanks for making these changes. The flow dissection looks good to me.
>
> One possible issue is that this exposes kernel fixed width types u8/u16/..
> to userspace. For posix compatibility reasons, uapi headers use the
>
The BIT(x) macro is no longer available for uapi headers because it is
defined outside of it (linux/bitops.h). The use of it must therefore be
avoided and replaced by an appropriate other representation.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 23 +++
1
the same neighbor to different cores.
Signed-off-by: Sven Eckelmann
---
net/core/flow_dissector.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 15ce30063765..fa0a4879fb9d 100644
--- a
ETH_P_BATMAN ethernet
packets.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS | 1 +
net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8
net/batman-adv/bat_iv_ogm.c | 2 +-
net/batman-adv/bat_
The headers used by packet.h should also be included by it directly. main.h
is currently dealing with it in batman-adv, but this will no longer work
when this header is moved to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/main.h | 2 --
net/batman-adv/packet.h | 2
.org/patch/17162/
Sven Eckelmann (4):
batman-adv: Let packet.h include its headers directly
batman-adv: Remove usage of BIT(x) in packet.h
batman-adv: Convert packet.h to uapi header
flow_dissector: Parse batman-adv unicast headers
MAINTAINERS
On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote:
> > No, this is also bad because batman_adv.h is MIT license and packet.h is
> > GPL-2. So what other name would you suggest for packet.h?
> > batman_adv_packet.h?
>
> Sure, that sounds great. Thanks.
Really? Isn't include/uapi/l
On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote:
> On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote:
> [...]
> > >> > ---
> > >> > MAINTAINERS| 2 +-
> > >> > inc
On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote:
[...]
> >> > ---
> >> > MAINTAINERS| 2 +-
> >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++---
> >>
> >> This and the previous patch changes uapi. That might break userspace
On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote:
> Perhaps it can even be behind a static key depending on whether any
> devices are active, adjusted in batadv_hardif_(en|dis)able_interface.
I don't like that because we don't need batman-adv loaded to simply forward
(bridge) tra
On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote:
> On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann
> wrote:
> > This file contains the relevant information to let userspace communicate
> > with batman-adv over generic netlink. The relevant genl enums for the
On Dienstag, 5. Dezember 2017 09:19:45 CET Tom Herbert wrote:
[...]
> Switch statements with cases having many LOC is hard to read and
> __skb_flow_dissect is aleady quite convoluted to begin with.
>
> I suggest putting this in a static function similar to how MPLS and
> GRE are handled.
Thanks f
file which will contain the packet format definitions.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS| 2 +-
include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++---
net/batman-adv/bat_algo.c | 2 +-
net/batman-adv/bat_iv_og
The BIT(x) macro is no longer available for uapi headers because it is
defined outside of it (linux/bitops.h). The use of it must therefore be
avoided and replaced by an appropriate other representation.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 23 +++
1
ETH_P_BATMAN ethernet
packets.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS| 1 +
net/batman-adv/packet.h => include/uapi/linux/batadv.h | 9 +
net/batman-adv/bat_iv_ogm.c| 2 +-
net/batman-adv/bat_
the same neighbor to different cores.
Signed-off-by: Sven Eckelmann
---
net/core/flow_dissector.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 15ce30063765..784cc07fc58e 100644
--- a/net/core
The headers used by packet.h should also be included by it directly. main.h
is currently dealing with it in batman-adv, but this will no longer work
when this header is moved to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/main.h | 2 --
net/batman-adv/packet.h | 2
The batman-adv netlink functionality is actually not pure netlink but is
using NETLINK_GENERIC and related API. The code should therefore also use
this "genl" instead of "nl" to make this more clear.
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 14
ket.h/uapi headers around to provide the correct
definitions to flow_dissector.c
Kind regards,
Sven
[1] https://patchwork.open-mesh.org/patch/17162/
[2]
https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next
Sven Eckelmann (6):
batman-adv: Change nl references to genl
b
On Montag, 25. April 2016 21:39:50 CEST Antonio Quartulli wrote:
> On Mon, Apr 25, 2016 at 03:25:22PM +0200, Denys Vlasenko wrote:
> > This function compiles to 473 bytes of machine code.
> > 21 callsites.
> >
> > text data bss dec hex filename
> > 95903266 20860288 35991552
On Montag, 26. Juni 2017 11:26:44 CEST Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistakes in batadv_dbg debug messages and
> also in a comment and ensure comment line is not wider than 80
> characters
>
> "ourselve" -> "ourselves"
> "surpressed" -> "suppressed"
> "trou
On Mittwoch, 14. Juni 2017 02:33:52 CEST Joe Perches wrote:
> It's misleading and unnecessary.
>
> Signed-off-by: Joe Perches
> ---
> net/batman-adv/distributed-arp-table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch was applied and is currently queued up as
454ea1866ef45
On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote:
> An output mac address is 17 bytes
[...]
> but in net/batman-adv/distributed-arp-table.c
[...]
> %14pM is odd as this should not emit the last byte of the
> mac address. So given the example above, it would output
> 00:11:22:33:44
[...]
ems.
> --
>
> From: Sven Eckelmann
>
> commit 248e23b50e2da0753f3b5faa068939cbe9f8a75a upstream.
>
> The function batadv_frag_skb_buffer was supposed not to consume the skbuff
> on errors. This was followed in the helper function
> batadv_frag_insert_packet whe
On Samstag, 6. Mai 2017 18:12:46 CEST SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 6 May 2017 18:03:45 +0200
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Replace a seq_puts() call by seq_putc() in two functions
On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote:
[...]
> Btw. the code you are modifying will most likely be dropped. Your patch will
> get rejected because of this. But thanks for submitting the api conversion
> patch (even when it will be rejected).
The patch was now
On Freitag, 31. März 2017 22:33:34 CEST Philippe Reynes wrote:
> > Do you know if anyone already prepared the get_link_ksettings support for
> > kernels older than 4.6 for backports.git?
>
> Sorry, I don't know this repo. Do you have an url please ?
> But I suppose that nobody works on such backpo
On Donnerstag, 30. März 2017 23:01:27 CEST Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> I've only compiled this change. If someone may test it,
> it would be very nice.
>
> Signed-off-by: Philippe Reynes
6 ("checkpatch: notice unbalanced else braces in a patch")
Signed-off-by: Sven Eckelmann
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ad5ea5c545b2..baa3c7be04ad 100755
--- a/scripts/
On Mittwoch, 15. Februar 2017 22:41:40 CET Ben Hutchings wrote:
> 3.16.40-rc1 review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Linus Lüssing
>
> commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
Same objections as Linus had for the 3.2 p
On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote:
> 4.8-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Linus Lüssing
>
> commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
>
> As long as there is still a ref
On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote:
[...]
> You're going to
> need more than just this revert though, since batman-adv calls
> ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless
> batadv_hardif_min_mtu() always returns something 1500 or less.
It does only r
e MTU range checking in misc drivers")
Signed-off-by: Sven Eckelmann
---
Original patch + my comment: https://patchwork.ozlabs.org/patch/684722/
I just got informed about this patch when it was already applied in net-next.
So I can only ask for an revet of the batman-adv parts
net/batma
On Donnerstag, 20. Oktober 2016 13:55:22 CEST Jarod Wilson wrote:
[...]
> batman-adv:
> - set max_mtu
> - remove batadv_interface_change_mtu
> - initialization is a little async, not 100% certain that max_mtu is set
> in the optimal place, don't have hardware to test with
batman-adv is creating
On Dienstag, 2. August 2016 20:15:13 CEST Baole Ni wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 5f2974b..25759b9 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -1313,7 +1313,7 @@ static struct kparam_string batadv_param_string_ra = {
>
is supposed to fix this issue.
>
> Fixes: 6d5808d4ae1b ("batman-adv: Add missing hardif_free_ref in
> forw_packet_free") Signed-off-by: Linus Lüssing
> [s...@narfation.org: fix conflicts with current version]
> Signed-off-by: Sven Eckelmann
> Signed-off-by: Marek Lindne
Hi,
looks like the patch is broken (at least it does something different than the
non-stable patch does).
On Monday 13 June 2016 19:36:37 Ben Hutchings wrote:
> 3.16.36-rc1 review patch. If anyone has any objections, please let me know.
[...]
> --- a/net/batman-adv/send.c
> +++ b/net/batman-adv
152746082 91ab862 vmlinux
>
> Signed-off-by: Denys Vlasenko
> CC: Marek Lindner
> CC: Simon Wunderlich
> CC: Antonio Quartulli
> CC: Sven Eckelmann
> CC: b.a.t.m@lists.open-mesh.org
> CC: linux-kernel@vger.kernel.org
> ---
> net/batman-adv/originator.c | 29
The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in
order to get working sound output on the docking stations headphone jack.
Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock
on kernel 4.4.6.
Signed-off-by: Sven Eckelmann
Tested-by: Simon Wunderlich
On Monday 11 April 2016 16:05:49 Takashi Iwai wrote:
> On Mon, 11 Apr 2016 11:21:38 +0200,
> Sven Eckelmann wrote:
> >
> > The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in
> > order to get working sound output on the docking stations headphone jack.
The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in
order to get working sound output on the docking stations headphone jack.
Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock
on kernel 4.4.6.
Signed-off-by: Sven Eckelmann
Tested-by: Simon Wunderlich
The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in
order to get working sound output on the docking stations headphone jack.
Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock
on kernel 4.4.6.
Signed-off-by: Sven Eckelmann
Tested-by: Simon Wunderlich
On Saturday 03 November 2012 12:58:45 Shan Wei wrote:
> Sven Eckelmann said, at 2012/11/3 1:55:
> > On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
> >> From: Shan Wei
> >>
> >> As Christoph Lameter said:
> >>> In addition, f
On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
> From: Shan Wei
>
> As Christoph Lameter said:
> > In addition, following usage of per_cpu_ptr can be replaced by
> > this_cpu_read.
> >
> > cpu=get_cpu()
> >
> > *per_cpu_ptr(p,cpu)
> >
> >
> > put_cpu()
>
> Right.
>
> Sign
83 matches
Mail list logo
