[PATCH v2] udf: augment UDF permissions on new inodes

2019-08-27 Thread Steven J. Magnani
ise indicate that it should be read-write. Fix this by having UDF delete permissions track Linux write permissions. Also grant UDF change attribute permission to the owner when creating a new inode. Reported by: Ty Young Signed-off-by: Steven J. Magnani --- Changes since rev 1: UDF delete permissi

[PATCH] udf: augment owner permissions on new inodes

2019-08-19 Thread Steven J. Magnani
ise indicate that it should be read-write. Fix this by granting UDF delete and change attribute permissions to the owner when creating a new inode. Reported by: Ty Young Signed-off-by: Steven J. Magnani --- --- a/fs/udf/udf_i.h2019-08-14 07:24:05.029508342 -0500 +++ b/fs/udf/udf_i.h2019-08-1

[PATCH v2] udf: reduce leakage of blocks related to named streams

2019-08-14 Thread Steven J. Magnani
ons that would limit leakage of all inode blocks on deletion. This restricts the patch to preservation of stream data during inode modification. Signed-off-by: Steven J. Magnani --- a/fs/udf/udf_i.h2019-07-26 11:35:28.257563879 -0500 +++ b/fs/udf/udf_i.h2019-08-06 14:35:55.579654263 -0

[PATCH] udf: reduce leakage of blocks related to named streams

2019-08-07 Thread Steven J. Magnani
;in ICB" stream data For this case, this partial solution reduces the number of blocks leaked during file deletion to just one (the EFE containing the stream data). Signed-off-by: Steven J. Magnani --- a/fs/udf/udf_i.h2019-07-26 11:35:28.257563879 -0500 +++ b/fs/udf/udf_i.h2019-

[PATCH v2 2/2] udf: support 2048-byte spacing of VRS descriptors on 4K media

2019-07-11 Thread Steven J. Magnani
mandated for media with smaller blocks. This nonconformity currently prevents Linux from recognizing the filesystem as UDF. Modify the driver to tolerate a misformatted VRS on 4K media. Signed-off-by: Steven J. Magnani --- a/fs/udf/super.c2019-07-10 20:55:33.334359446 -0500 +++ b/fs/udf

[PATCH v2 1/2] udf: refactor VRS descriptor identification

2019-07-11 Thread Steven J. Magnani
Extract code that parses a Volume Recognition Sequence descriptor (component), in preparation for calling it twice against different locations in a block. Change from v1: Fix regression in debug logging of "open disc" condition Signed-off-by: Steven J. Magnani --- a/fs/udf/super.c

[PATCH 2/2] udf: support 2048-byte spacing of VRS descriptors on 4K media

2019-07-11 Thread Steven J. Magnani
mandated for media with smaller blocks. This nonconformity currently prevents Linux from recognizing the filesystem as UDF. Modify the driver to tolerate a misformatted VRS on 4K media. Signed-off-by: Steven J. Magnani --- a/fs/udf/super.c2019-07-10 20:55:33.334359446 -0500 +++ b/fs/udf

[PATCH 1/2] udf: refactor VRS descriptor identification

2019-07-11 Thread Steven J. Magnani
Extract code that parses a Volume Recognition Sequence descriptor (component), in preparation for calling it twice against different locations in a block. Signed-off-by: Steven J. Magnani --- a/fs/udf/super.c2019-07-10 18:57:41.192852154 -0500 +++ b/fs/udf/super.c2019-07-10 20:47

[PATCH v2] udf: Fix incorrect final NOT_ALLOCATED (hole) extent length

2019-06-30 Thread Steven J. Magnani
en updated when the file's information length was increased. Change since v1: Simplified udf_do_extend_file() API, partially by factoring out its handling of the "extending within the last file block" corner case. Fixes: 2c948b3f86e5 ("udf: Avoid IO in udf_clear_inode")

[PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF

2017-02-27 Thread Steven J. Magnani
-sized blocks. Signed-off-by: Steven J. Magnani --- --- a/drivers/scsi/sd.c 2017-02-24 20:29:44.510036363 -0600 +++ b/drivers/scsi/sd.c 2017-02-27 08:19:37.864786958 -0600 @@ -2066,7 +2066,7 @@ static int read_capacity_16(struct scsi_ int the_result; int retries = 3,

[PATCH] udf: Don't corrupt unalloc spacetable when writing it

2015-07-07 Thread Steven J. Magnani
loc space handling in udf_update_inode") addressed one such field, but several others are required. Signed-off-by: Steven J. Magnani --- diff -uprN a/fs/udf/inode.c b/fs/udf/inode.c --- a/fs/udf/inode.c2015-07-06 13:42:08.861499890 -0500 +++ b/fs/udf/inode.c2015-07-06 13:42:18.1534

[PATCH] qla2xxx: Re-sync module parameter descriptions with the code

2014-02-04 Thread Steven J. Magnani
Fix module parameter descriptions mentioning default values that no longer match the code. Signed-off-by: Steven J. Magnani --- diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c --- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c2014-02-02 18:42

[PATCH] qla2xxx: eliminate dead code in qla24xx_process_bidir_cmd

2014-01-30 Thread Steven J. Magnani
require the response to have the same length as the request, all code related to the faulty test can be removed. If this is not the case, the test should be moved much earlier in the function since it does not depend on any resource acquitision. Signed-off-by: Steven J. Magnani --- --- linux-3.13

Re: [PATCH RESEND^2] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-29 Thread Steven J. Magnani
On Fri, 2013-04-26 at 10:30 -0700, James Bottomley wrote: On Fri, 2013-04-26 at 11:39 -0500, Steven J. Magnani wrote: > > Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered > > set_media_not_present() in a way that prevents the sd driver from > > remembering th

[PATCH RESEND^2] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-26 Thread Steven J. Magnani
esent" whether the device has declared itself "removable" or not. Signed-off-by: Steven J. Magnani --- --- a/drivers/scsi/sd.c 2013-04-12 14:16:12.252531097 -0500 +++ b/drivers/scsi/sd.c 2013-04-12 14:21:55.197216521 -0500 @@ -1298,10 +1298,8 @@ out: static void set_

Re: [PATCH] mmc: debugfs: Add debugfs ability to read CID and CSD

2013-04-12 Thread Steven J. Magnani
; csd". Ahh. Thanks for the tip; I hadn't thought to look there since I found the ext_csd under debugfs. ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling,

Re: 3.6.0 kernel - ext4 corruption, or?

2012-10-24 Thread Steven J. Magnani
Oct 28 2011 /etc/posfix.old/master.cf > > # ls -ld /etc/postfix.old > ls: cannot access /etc/postfix.old: No such file or directory This is not the same directory (posTfix). ------------ Steven J. Magnani &qu

Re: usbview 2.0 release

2012-10-22 Thread Steven J. Magnani
; found ... > The OS i am using is ubuntu-11.10 amd64. I can't speak for Ubuntu, but on Fedora installing gtk3-devel eliminated the message you describe. ------------ Steven J. Magnani "I claim this network for M

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-10 Thread Steven J. Magnani
rename/drop_caches I guess there is a hole. ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include -- To unsubscribe from

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-07 Thread Steven J. Magnani
orking their way towards mainline. I recognize that not everyone can take advantage of client-side features, but options (2) and (3) make life worse for those who can. ------------ Steven J. Magnani "I claim this network f

Re: [PATCH 0/4] fat: fix ESTALE errors

2012-08-21 Thread Steven J. Magnani
client will cry ESTALE despite the server's best efforts. ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] fat: Refactor shortname parsing

2012-08-03 Thread Steven J. Magnani
; > return (c >= 'A' && c <= 'Z') ? tolower(c) : c; But now it's less efficient because tolower() does an unnecessary lookup to see if it's supposed to change the value. _tolower() wouldn't have that issue, but it's marked "Do

Re: Alternative to vfork(2) with overcommit off

2012-07-30 Thread Steven J. Magnani
Not everyone can afford a Lexus. ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] Documentation: update mount option in filesystem/vfat.txt

2012-07-30 Thread Steven J. Magnani
by: Steven J. Magnani -------- Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include -- To unsubscribe from this list: send

Re: mount -o loop with truncated dosdisk.img uses 100% cpu and can't be killed

2012-07-12 Thread Steven J. Magnani
signed long > long)blkdev_max_block(I_BDEV(bdev->bd_inode))); > + dump_stack(); > + return NULL; > + } > > for (;;) { > struct buffer_head * bh; > _ This fixes the hang, but I'm not sure dump_stack() is

Re: mount -o loop with truncated dosdisk.img uses 100% cpu and can't be killed

2012-07-12 Thread Steven J. Magnani
loopback driver than the FAT filesystem... ------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls

2012-07-11 Thread Steven J. Magnani
ount with 'lookupcache=none'. It's not an exhaustive test by any means, just a data point for you. Thanks! Lightly-tested-by: Steve Magnani ------------ Steven J. Magnani "I claim this network

[PATCH 2/2] fat (exportfs): fix dentry reconnection

2012-07-10 Thread Steven J. Magnani
ported via NFS are not saddled with maintenance of an index they will never use. Finally, simplify NFS file handle generation and lookups. An ext2-congruent implementation is adequate for FAT needs. Signed-off-by: Steven J. Magnani --- diff -uprN a/fs/fat/dir.c b/fs/fat/dir.c --- a/fs/fat/dir.c

[PATCH 1/2] fat (exportfs): move NFS support code

2012-07-10 Thread Steven J. Magnani
Move NFS-related code into its own C file. No functional changes. Signed-off-by: Steven J. Magnani --- diff -uprN a/fs/fat/fat.h b/fs/fat/fat.h --- a/fs/fat/fat.h 2012-07-09 08:33:25.206615179 -0500 +++ b/fs/fat/fat.h 2012-07-10 09:10:14.064615822 -0500 @@ -341,6 +341,20 @@ extern int

[PATCH v2 0/2] fat (exportfs): fix dentry reconnection

2012-07-10 Thread Steven J. Magnani
Under memory pressure, the system may evict dentries from cache. When the FAT driver receives a NFS request involving an evicted dentry, it is unable to reconnect it to the filesystem root. This causes the request to fail, often with ENOENT. This is partially due to ineffectiveness of the current

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Tue, 2012-07-10 at 06:34 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > >> Ah, i_ino. I was talking about i_pos. Well, so, what happens if the > >> child was renamed to other parent on NFS server machine (not via nfs > >> client)?

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Tue, 2012-07-10 at 04:10 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > >> > >> > Interesting idea. I think this, and reformulating the FAT NFS file > >> > >> > handle to include the parent's i_ino, will gr

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Mon, 2012-07-09 at 12:09 -0500, Steven J. Magnani wrote: > On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote: > > On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote: > > > If the inode is not on cache anymore, is there the possibility that > > > sel

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote: > On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote: > > "Steven J. Magnani" writes: > > > > > On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote: > > >> "Steven J.

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > > On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote: > >> "Steven J. Magnani" writes: > >> > >> >> We need the key, possible

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > >> We need the key, possible key is - if it is only directory, FAT may be > >> able to use i_start as additional search key. > > > > Interesting idea. I

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-09 Thread Steven J. Magnani
On Sun, 2012-07-08 at 02:00 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > >> You mean the unhashed inode is created by ->get_parent()? If so, the > >> root cause sounds like ->get_parent() itself. If not, I'm not > >> under

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-07 Thread Steven J. Magnani
On Sat, 2012-07-07 at 15:03 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > > On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote: > >> "Steven J. Magnani" writes: > >> > >> > On Wed, 2012-07-04 at 20:07 +0900,

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-06 Thread Steven J. Magnani
On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" writes: > > > On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote: > >> Please don't add new lock_super() usage if it is not necessary. Almost > >> all of lock_

Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

2012-07-06 Thread Steven J. Magnani
On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote: > Please don't add new lock_super() usage if it is not necessary. Almost > all of lock_super() just replaced lock_kernel() usage. It rather should > be removed in future. Probably, this should use inode->i_mutex instead. > > BTW, the above