I changed the comment to
+ /*
+* See commit 2f94a3125b87. Increment the refcount when we
+* get a lease for root, release it if lease break occurs
+*/
and added Aurelien's Reviewed-by. Let me know if you see any
additional problems.
Merged into cifs-2.6.git for-next
(strangely ... this patch was sent to my spam folder in gmail so
didn't notice it until today, and by accident).
On Wed, Apr 7, 2021 at 9:03 AM wrote:
>
> From: "jack1.li_cp"
>
> secuirty -> security
>
> Signed-off-by: jack1.li_cp
> ---
> fs/cifs/cifsacl.c |
merged into cifs-2.6.git for-next
On Fri, Mar 26, 2021 at 12:02 PM Gustavo A. R. Silva
wrote:
>
>
>
> On 3/26/21 10:54, Aurélien Aptel wrote:
> > "Gustavo A. R. Silva" writes:
> >> There is a regular need in the kernel to provide a way to declare having
> >> a dynamically sized set of trailing e
merged into cifs-2.6.git for-next
On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong
wrote:
>
> Fix the following gcc warning:
>
> fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
> f
merged into cifs-2.6.git for-next
On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing wrote:
>
> struct cifs_writedata is declared twice.
> One is declared at 209th line.
> And struct cifs_writedata is defined blew.
> The declaration hear is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
Please pull the following changes since commit
e49d033bddf5b565044e2abe4241353959bc9120:
Linux 5.12-rc6 (2021-04-04 14:15:36 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc6-smb3
for you to fetch changes up to 0fc9322ab5e1fe6910c9673e1a7f
fixed - (a tmp branch was accidentally pushed)
On Thu, Apr 8, 2021 at 7:07 AM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> e67fcb31fb0e ("stuff")
>
> is missing a Signed-off-by from its author and comitter.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
evname for cifs mounts. However, when mounting
a share which has a whitespace in the name, that exact share name is also
displayed in mountinfo. Make sure that all whitespace is escaped.
Signed-off-by: Maciek Borzecki
CC: # 5.11+
Reviewed-by: Shyam Prasad N
Signed-off-by: Steve French
---
fs/cifs/cifsf
merged into cifs-2.6.git for-next
On Thu, Apr 1, 2021 at 2:52 AM Wan Jiabing wrote:
>
> struct cifs_readdata is declared twice. One is declared
> at 208th line.
> And struct cifs_readdata is defined blew.
> The declaration here is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
POSIX
Shyam Prasad N (2):
cifs: Adjust key sizes and key generation routines for AES256 encryption
cifs: Fix chmod with modefromsid when an older ACE already exists.
Steve French (1):
smb3: fix cached file size problems in duplicate extents (reflink)
Vincent Whitchurch (1
merged into cifs-2.6.git for-next
On Fri, Mar 19, 2021 at 9:06 AM Tom Talpey via samba-technical
wrote:
>
> LGTM feel free to add
>
> Reviewed-By: Tom Talpey
>
> On 3/19/2021 9:57 AM, Vincent Whitchurch wrote:
> > Make SMB2 not print out an error when an oplock break is received for an
> > unkno
):
cifs: update new ACE pointer after populate_new_aces.
Steve French (1):
cifs: fix allocation size on newly created files
Vincent Whitchurch (1):
cifs: Fix preauth hash corruption
fs/cifs/cifs_swn.c | 2 +-
fs/cifs/cifsacl.c| 9 ++---
fs/cifs/fs_context.c | 6
):
cifs: update new ACE pointer after populate_new_aces.
Steve French (1):
cifs: fix allocation size on newly created files
Vincent Whitchurch (1):
cifs: Fix preauth hash corruption
fs/cifs/cifs_swn.c | 2 +-
fs/cifs/cifsacl.c| 9 ++---
fs/cifs/fs_context.c | 6
merged into cifs-2.6.git for-next
On Thu, Mar 18, 2021 at 7:50 PM wrote:
>
> From: Liu xuzhi
>
> A typo is found out by codespell tool in 251th lines of cifs_swn.c:
>
> $ codespell ./fs/cifs/
> ./cifs_swn.c:251: funciton ==> function
>
> Fix a typo found by codespell.
>
> Signed-off-by: Liu xuz
Namjae updated/restructured the initial list of patches to be easier
to follow (and also fixed the missing Acked-by and Signed-off-by tags)
- and I have updated the branch. Let us know if you see other cleanup
that would make this (initial merge) process easier. I am continuing
to run testing on
Please pull the following changes since commit
a38fd8748464831584a19438cbb3082b5a2dab15:
Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc2-smb3
for you to fetch changes up to 04ad69c342fc4de5bd23be9ef15e
On Sun, Feb 28, 2021 at 1:36 AM Amir Goldstein wrote:
>
> On Sun, Feb 28, 2021 at 1:08 AM Steve French wrote:
> >
> > On Fri, Feb 26, 2021 at 11:43 PM Amir Goldstein wrote:
> > >
> > > On Sat, Feb 27, 2021 at 12:19 AM Alejandro Colomar (man-pages)
> >
On Fri, Feb 26, 2021 at 11:43 PM Amir Goldstein wrote:
>
> On Sat, Feb 27, 2021 at 12:19 AM Alejandro Colomar (man-pages)
> wrote:
> >
> > Hello Amir, Luis,
> >
> > On 2/24/21 5:10 PM, Amir Goldstein wrote:
> > > On Wed, Feb 24, 2021 at 4:22 PM Luis Henriques wrote:
> > >>
> > >> Update man-page
Has anyone seen this? I was running some xfstests today on current
mainline (ran same tests yesterday and multiple times last week on
5.11 and did not see this) and hit this multiple times
[ 287.702292] [ cut here ]
[ 287.702296] WARNING: CPU: 5 PID: 8223 at
drivers/gpu/
by conn_id.
cifs: Fix cifsacl ACE mask for group and others.
cifs: Retain old ACEs when converting between mode bits and ACL.
cifs: Change SIDs in ACEs while transferring file ownership.
cifs: If a corrupted DACL is returned by the server, bail out.
Steve French (11):
gt; >
> > Hi Colin,
> >
> > Thanks for reporting this. I'll submit a fix.
> >
> > Regards,
> > Shyam
> >
> > -Original Message-
> > From: Colin Ian King
> > Sent: Wednesday, February 24, 2021 6:14 PM
> > To: Shyam Pra
On Tue, Feb 23, 2021 at 2:28 PM Matthew Wilcox wrote:
>
> On Mon, Feb 15, 2021 at 11:22:20PM -0600, Steve French wrote:
> > On Mon, Feb 15, 2021 at 8:10 PM Matthew Wilcox wrote:
> > > The switch from readpages to readahead does help in a couple of corner
> > > ca
On Thu, Feb 18, 2021 at 4:03 AM Amir Goldstein wrote:
>
> On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig wrote:
> >
> > Looks good:
> >
> > Reviewed-by: Christoph Hellwig
> >
> > This whole idea of cross-device copie has always been a horrible idea,
> > and I've been arguing against it since
On Tue, Feb 16, 2021 at 1:40 PM Amir Goldstein wrote:
>
> On Tue, Feb 16, 2021 at 9:31 PM Steve French wrote:
> >
> > On Tue, Feb 16, 2021 at 1:29 PM Anna Schumaker
> > wrote:
> > >
> > > On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote:
> >
On Tue, Feb 16, 2021 at 1:29 PM Anna Schumaker
wrote:
>
> On Tue, Feb 16, 2021 at 2:22 PM Amir Goldstein wrote:
> >
> > On Tue, Feb 16, 2021 at 8:54 PM Luis Henriques wrote:
> > >
> > > Amir Goldstein writes:
> > >
> > > > On Tue, Feb 16, 2021 at 6:41 PM Luis Henriques
> > > > wrote:
> > > >>
On Mon, Feb 15, 2021 at 8:10 PM Matthew Wilcox wrote:
>
> On Mon, Feb 15, 2021 at 06:40:27PM -0600, Steve French wrote:
> > It could be good if netfs simplifies the problem experienced by
> > network filesystems on Linux with readahead on large sequential reads
> > - wh
On Mon, Feb 15, 2021 at 8:10 PM Matthew Wilcox wrote:
>
> On Mon, Feb 15, 2021 at 06:40:27PM -0600, Steve French wrote:
> > It could be good if netfs simplifies the problem experienced by
> > network filesystems on Linux with readahead on large sequential reads
> > - wh
Jeff,
What are the performance differences you are seeing (positive or
negative) with ceph and netfs, especially with simple examples like
file copy or grep of large files?
It could be good if netfs simplifies the problem experienced by
network filesystems on Linux with readahead on large sequenti
On Mon, Feb 15, 2021 at 10:11 AM Trond Myklebust
wrote:
>
> On Mon, 2021-02-15 at 15:43 +, Luis Henriques wrote:
> > Nicolas Boichat reported an issue when trying to use the
> > copy_file_range
> > syscall on a tracefs file. It failed silently because the file
> > content is
> > generated on-
text.c | 20 +---
fs/cifs/fs_context.h | 1 +
4 files changed, 28 insertions(+), 4 deletions(-)
On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French wrote:
> >
> > git://git.samba.org/sfrench/cifs-2.6.git t
Metze/Bjorn,
Linus is right - samba.org is down for me (I also verified with JRA).
Any ETA on when it gets back up?
On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French wrote:
> >
> > git://git.samba.org/sfrench/cifs-2.6
Please pull the following changes since commit
92bf22614b21a2706f4993b278017e437f7785b3:
Linux 5.11-rc7 (2021-02-07 13:57:38 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
for you to fetch changes up to a738c93fb1c17e386a09304b517b
Please pull the following changes since commit
1048ba83fb1c00cd24172e23e8263972f6b5d9ac:
Linux 5.11-rc6 (2021-01-31 13:50:09 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc6-smb3
for you to fetch changes up to 21b200d091826a83aafc95d84713
fixed
On Wed, Feb 3, 2021 at 4:59 AM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> 37595a5c8a51 ("smb3: fix crediting for compounding when only one request in
> flight")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
merged into cifs-2.6.git for-next
On Mon, Feb 1, 2021 at 8:38 PM Gustavo A. R. Silva
wrote:
>
> While addressing some warnings generated by -Warray-bounds, I found this
> bug that was introduced back in 2017:
>
> CC [M] fs/cifs/smb2pdu.o
> fs/cifs/smb2pdu.c: In function ‘SMB2_negotiate’:
> fs/
Harvey (1):
cifs: ignore auto and noauto options if given
Ronnie Sahlberg (1):
cifs: fix dfs domain referrals
Steve French (2):
cifs: fix mounts to subdirectories of target
cifs: returning mount parm processing errors correctly
fs/cifs/cifs_dfs_ref.c | 12
fs
For the last month my logs have been flooded many times a second with:
"nouveau :01:00.0: [drm] *ERROR* crtc 50: Can't calculate
constants, dotclock = 0!"
(see line 641 of drm_vblank.c) which is distracting for debugging all
other kernel problems (since dmesg entries on this system are 99+%
t
Please pull the following changes since commit
19c329f6808995b142b3966301f217c831e7cf31:
Linux 5.11-rc4 (2021-01-17 16:37:05 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc4-smb3
for you to fetch changes up to 214a5ea081e77346e4963dd6d20c
On Sun, Jan 17, 2021 at 6:02 PM Al Viro wrote:
>
> On Sun, Jan 17, 2021 at 03:58:23PM -0600, Steve French wrote:
> > Jiapeng,
> > Aurelien is correct, you should respin this patch and correct for
> > where it breaks the sizeof calculation. For example your change:
>
Jiapeng,
Aurelien is correct, you should respin this patch and correct for
where it breaks the sizeof calculation. For example your change:
struct smb2_lock_rsp {
@@ -1434,7 +1434,7 @@ struct smb2_query_directory_req {
__le16 FileNameOffset;
__le16 FileNameLength;
__le32 O
)
Author: Jiapeng Zhong
Date: Thu Jan 14 18:02:23 2021 +0800
fs/cifs: Simplify bool comparison.
Fix the follow warnings:
./fs/cifs/connect.c: WARNING: Comparison of 0/1 to bool variable
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Zhong
Signed-off-by: Steve Frenc
merged into cifs-2.6.git for-next
On Thu, Jan 14, 2021 at 3:11 AM Jiapeng Zhong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./fs/cifs/connect.c:3386:2-21: WARNING: Assignment of 0/1 to
> bool variable.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Zhong
> ---
> fs/cifs/connec
This patch seems reasonable at first glance, but I was a little
concerned that we don't see many users yet of fsleep. Has there been
pushback on converting "yield" situations from using msleep to fsleep?
On Thu, Dec 10, 2020 at 3:09 AM Yejune Deng wrote:
>
> See Documentation/timers/timers-howto
merged into cifs-2.6.git for-next and added cc:stable
On Tue, Jan 5, 2021 at 5:08 PM Nathan Chancellor
wrote:
>
> On Tue, Jan 05, 2021 at 12:21:26PM -0800, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > clang static analysis reports this problem
> >
> > dfs_cache.c:591:2: warning: Argument to
merged into cifs-2.6.git for-next
On Wed, Dec 30, 2020 at 12:37 AM YANG LI wrote:
>
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use "flexible array members"[1] for these
> cas
Please pull the following changes since commit
e13300bdaa68f5487000e66baed1ff69bcb510bf:
Merge tag '5.11-rc-smb3' of git://git.samba.org/sfrench/cifs-2.6
(2020-12-17 17:41:37 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3-part2
for
desc\n",
> --
> 2.18.4
>
--
Thanks,
Steve
From d42d0c0334ef918310b11818c1805624c0ee9440 Mon Sep 17 00:00:00 2001
From: Boris Protopopov
Date: Fri, 18 Dec 2020 11:30:12 -0600
Subject: [PATCH 1/2] SMB3: Add support for getting and setting SACLs
Add SYSTE
I have now amended the patches to have the correct author and repushed
On Thu, Dec 17, 2020 at 11:57 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commits
>
> ee04fe87f4d0 ("cifs: Re-indent cifs_swn_reconnect()")
> 2c6dd2f9742d ("cifs: Unlock on errors in cifs_swn_reconnect()")
> fb2356b3739b
andling detected by static checker
Shyam Prasad N (3):
cifs: Fix unix perm bits to cifsacl conversion for "other" bits.
cifs: Enable sticky bit with cifsacl mount option.
cifs: Tracepoints and logs for tracing credit changes.
Steve French (16):
SMB3: avoid
On Wed, Dec 16, 2020 at 4:08 AM Stephen Rothwell wrote:
>
> Hi Steven,
>
> On Wed, 16 Dec 2020 02:21:26 + Steven French
> wrote:
> >
> > I applied your patch to the tip of my tree (cifs-2.6.git for-next) -
> > hopefully that makes it easier when I sent the PR in a day or two for
> > cifs/smb
fixed
On Mon, Dec 14, 2020 at 1:32 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commits
>
> 425f40482491 ("cifs: fix uninitialized variable in
> smb3_fs_context_parse_param")
> 8cc9a66ea70e ("cifs: update mnt_cifs_flags during reconfigure")
>
> are missing a Signed-off-by from their committer.
fixed and repushed to cifs-2.6.git for-next
On Sun, Dec 13, 2020 at 4:14 AM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> 3aa4e616197b ("cifs: Register generic netlink family")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
fixed and repushed to cifs-2.6.git for-next
On Thu, Dec 10, 2020 at 4:45 AM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> 7e9c48d305d5 ("cifs: remove the devname argument to
> cifs_compose_mount_options")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwe
Fixed - thx
On Wed, Dec 9, 2020 at 3:23 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commits
>
> d24e661920cb ("cifs: Enable sticky bit with cifsacl mount option.")
> 4bcfb51f82f0 ("cifs: Fix unix perm bits to cifsacl conversion for "other"
> bits.")
>
> are missing a Signed-off-by from their
Merged into cifs-2.6.git for-next
Let me know if you see any other cleanup/misc cifs.ko patches that may
have gotten missed ...
On Fri, Nov 20, 2020 at 12:25 PM Gustavo A. R. Silva
wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding
Please pull the following changes since commit
509a15421674b9e1a3e1916939d0d0efd3e578da:
Merge tag '5.10-rc6-smb3-fixes' of
git://git.samba.org/sfrench/cifs-2.6 (2020-12-01 15:43:53 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.10-rc6-smb3-fix
Please pull the following changes since commit
b65054597872ce3aefbc6a666385eabdf9e288da:
Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.10-rc6-smb3-fixes
for you to fetch changes up to 212253367dc7b49ed3fc19
Please pull the following changes since commit
09162bc32c880a791c6c0668ce0745cf7958f576:
Linux 5.10-rc4 (2020-11-15 16:44:31 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.10-rc5-smb3-fixes
for you to fetch changes up to 1254100030b3377e8302f9
I typically build cifs.ko for testing using the latest Ubuntu mainline
build - but building a module in the 5.10-rc1 kernel - while booted to
the 5.10-rc1 ubuntu mainlinekerel - e.g. "make C=1 -C
/usr/src/linux-headers-`uname -r` M=`pwd` modules
CF=-D__CHECK_ENDIAN__"
which has worked for years - n
you can add my reviewed-by if you would like
On Thu, Oct 22, 2020 at 1:48 AM Kent Overstreet
wrote:
>
> This is just open coding add_to_page_cache(), and the next patch will
> delete add_to_page_cache_locked().
>
> Signed-off-by: Kent Overstreet
> ---
> fs/cifs/file.c | 20
Other than the unnecessary split line which Christoph pointed out, looks fine.
You can add my Reviewed--by: Steve French
On Tue, Oct 20, 2020 at 5:10 AM Christoph Hellwig wrote:
>
> > + rc = add_to_page_cache(page, mapping,
> > +page->ind
added Aurelien's Reviewed-by and merged into cifs-2.6.git for-next
On Tue, Oct 20, 2020 at 9:22 AM Colin King wrote:
>
> From: Colin Ian King
>
> Don't populate const array smb3_create_tag_posix on the stack but
> instead make it static. Makes the object code smaller by 50 bytes.
>
> Before:
>
fixed
On Tue, Sep 29, 2020 at 5:31 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> 87505cefd88d ("Convert trailing spaces and periods in path components")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
Please pull the following changes since commit
f4d51dffc6c01a9e94650d95ce0104964f8ae822:
Linux 5.9-rc4 (2020-09-06 17:11:40 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc4-smb3-fix
for you to fetch changes up to 01ec372cef1e5afa4ab843bbaf
Please pull the following changes since commit
d012a7190fc1fd72ed48911e77ca97ba4521bccd:
Linux 5.9-rc2 (2020-08-23 14:08:43 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc2-smb-fix
for you to fetch changes up to e183785f2529b4135f00a0330a3
uilders/2/builds/381
Dan Carpenter (1):
cifs: Fix an error pointer dereference in cifs_mount()
Miaohe Lin (1):
cifs: Convert to use the fallthrough macro
Steve French (1):
SMB3: Fix mkdir when idsfromsid configured on mount
fs/cifs/connect.c | 1 +
fs/cifs/smb2in
merged into cifs-2.6.git for-next
(but note that most places in fs directory other than cifs and btrfs
have not been updated), and I noticed another 8 places in fs/cifs that
you didn't change in your patch (ie change from the older way of
indicating fallthrough /* Fallthrough */ as a comment to
On Mon, Aug 10, 2020 at 10:48 AM David Howells wrote:
>
> Steve French wrote:
>
> > cifs.ko also can set rsize quite small (even 1K for example, although
> > that will be more than 10x slower than the default 4MB so hopefully no
> > one is crazy enough to do t
cifs.ko also can set rsize quite small (even 1K for example, although
that will be more than 10x slower than the default 4MB so hopefully no
one is crazy enough to do that). I can't imagine an SMB3 server
negotiating an rsize or wsize smaller than 64K in today's world (and
typical is 1MB to 8MB)
Is this conversion from "/* Fallthrough */" to the preferred (?)
"fallthrough;" documented anywhere?
All I see is a few fs changesets like:
commit c730ae0c6bb3125ccb776fb2ab6abbdff500c02c
Author: Marcos Paulo de Souza
Date: Tue Jun 16 15:54:29 2020 -0300
btrfs: convert comments to fallt
Dan,
I just fixed the Author tag in this patch to match your email address
but seems like the author email address gets mangled when sent through
some mailing lists. Any ideas how to avoid this.
On Thu, Aug 6, 2020 at 1:45 AM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> 2676d210d2f4 ("ci
__{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect()
Steve French (1):
smb3: warn on confusing error scenario with sec=krb5
Wei Yongjun (1):
cifs: remove unused variable 'server'
fs/cifs/cifsacl.h | 4 +-
fs/cifs/cifsglob.h | 2 +-
fs/cifs/cifsproto.h | 9 +
merged into cifs-2.6.git for-next
On Fri, Jul 31, 2020 at 12:15 PM Colin King wrote:
>
> From: Colin Ian King
>
> Currently if the call dfs_cache_get_tgt_share fails we cannot
> fully guarantee that share and prefix are set to NULL and the
> next iteration of the loop can end up potentially doub
merged into cifs-2.6.git for-next
and for-next also updated with 5.8-rc7
On Sat, Jul 25, 2020 at 3:53 AM Qinglang Miao wrote:
>
> Convert cpu_to_be32(be32_to_cpu(E1) + E2) to use be32_add_cpu().
>
> Signed-off-by: Qinglang Miao
> ---
> fs/cifs/connect.c | 3 +--
> fs/cifs/sess.c| 3 +--
>
Merged into cifs-2.6.git for-next
On Sun, Jul 19, 2020 at 7:14 PM Randy Dunlap wrote:
>
> Drop repeated words in multiple comments.
> (be, use, the, See)
>
> Signed-off-by: Randy Dunlap
> Cc: Steve French
> Cc: linux-c...@vger.kernel.org
> Cc: samba-techni...@lists.sa
This has been fixed in 5.8-rc5. Chrome now works again (failed on
rc1, rc2 and rc4, worked on 5.7 and before as well)
On Sat, Jul 4, 2020 at 3:29 PM Steve French wrote:
>
> I noticed that chrome crashes immediately on startup on my desktop
> booting to 5.8-rc2 or later kernels (
merged into cifs-2.6.git for-next
thx
On Tue, Jul 14, 2020 at 6:14 AM Yi Wang wrote:
>
> From: Liao Pingfang
>
> Remove the superfuous break, as there is a 'return' before it.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> ---
> fs/cifs/sess.c | 1 -
> 1 file changed, 1 deletion
test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/367
Ronnie Sahlberg (1):
cifs: fix reference leak for tlink
Steve French (3):
smb3: fix access denied on change notify request to
I noticed that chrome crashes immediately on startup on my desktop
booting to 5.8-rc2 or later kernels (whether I build the kernel or
using the prebuilt weekly Ubuntu mainline kernel downloads). Works
fine with default kernels or 5.7 or 5.7.7 stable kernel etc. - just
breaks if I boot 5.8-rc2 or
Please pull the following changes since commit
9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68:
Linux 5.8-rc3 (2020-06-28 15:00:24 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc3-smb3-fixes
for you to fetch changes up to 19e888678bac8c82206eb915
Please pull the following changes since commit
48778464bb7d346b47157d21ffde2af6b2d39110:
Linux 5.8-rc2 (2020-06-21 15:45:29 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc2-smb3-fixes
for you to fetch changes up to bf1028a41eaf0ce39518cbdd
fixed
cifs-2.6.git for-next updated
thx
On Tue, Jun 23, 2020 at 5:31 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commits
>
> 52e2b5b30cee ("cifs/smb3: Fix data inconsistent when punch hole")
> 76f77967b39e ("cifs/smb3: Fix data inconsistent when zero file range")
>
> are missing a Signed-off
Added the two reviewed-bys and merged into cifs-2.6.git for-next
On Tue, Jun 16, 2020 at 6:17 AM Aurélien Aptel via samba-technical
wrote:
>
> Reviewed-by: Aurelien Aptel
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Sof
added cc:stable and merged into cifs-2.6.git for-next
On Sat, Jun 13, 2020 at 7:36 AM Xiyu Yang wrote:
>
> open_shroot() invokes kref_get(), which increases the refcount of the
> "tcon->crfid" object. When open_shroot() returns not zero, it means the
> open operation failed and close_shroot() wil
redit charge in smb2 ioctl
Steve French (10):
smb3: extend fscache mount volume coherency check
smb3: fix typo in mount options displayed in /proc/mounts
SMB311: Add support for query info using posix extensions (level 100)
smb311: Add support for SMB311 query info
tentatively merged into cifs-2.6.git for-next but had to clean it up
to avoid merge conflicts.
Minor followon patch (attached) to add the two remaining ones that Joe
pointed out that.
On Wed, Apr 15, 2020 at 12:46 AM Joe Perches via samba-technical
wrote:
>
> Use pr_fmt to standardize all loggin
merged into cifs-2.6.git for-next
On Wed, May 27, 2020 at 7:52 AM Colin King wrote:
>
> From: Colin Ian King
>
> The variable rc is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addr
Ronnie mentioned that he will take a look ...
On Tue, May 19, 2020 at 1:57 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> fs/cifs/smb2inode.c: In function 'smb2_compound_op':
> fs/cifs/smb2inode.c:
merged into cifs-2.6.git for-next
On Tue, May 5, 2020 at 8:49 AM Geert Uytterhoeven
wrote:
>
> As per POSIX, the correct spelling is EACCES:
>
> include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied
> */
>
> Fixes: b8f7442bc46e48fb ("CIFS: refactor cifs_get_inode_info()")
tentatively pushed to cifs-2.6.git for-next pending more testing of
the flock patch it modified.
On Fri, Oct 18, 2019 at 1:07 AM YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/cifs/file.c: In function 'cifs_flock':
> fs/cifs/file.c:1704:8: warning:
> variable 'netfid
Merged into cifs-2.6.git for-next and cc: stable for 5.3
On Mon, Oct 14, 2019 at 4:43 PM Pavel Shilovsky via samba-technical
wrote:
>
> пн, 14 окт. 2019 г. в 00:18, Chuhong Yuan :
> >
> > cifs_setattr_nounix has two paths which miss free operations
> > for xid and fullpath.
> > Use goto cifs_seta
I noticed that the commit below regressed cifs/smb3 xfstest 258 on
5.4-rc1 and later.
"Testing for negative seconds since epoch"
"Timestamp wrapped"
Did xfstest 258 get updated to account for the new behavior with this patch?
commit cb7a69e605908c34aad47644afeb26a765ade8d7
Author: Deepa Din
Your questions are interesting and rarely asked.
On Fri, Oct 4, 2019 at 11:57 AM Al Viro wrote:
>
> On Fri, Oct 04, 2019 at 05:02:20PM +0100, Al Viro wrote:
>
> > * (possibly) cifs hitting the same on eviction by memory pressure
> > alone
> > (no locked inodes anywhere in sight). Possibly
avoid the distraction of 300+
warning messages every time I build just this one module. Is there a
workaround?
On Thu, Oct 3, 2019 at 11:51 PM Masahiro Yamada
wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 1:28 PM Steve French wrote:
> >
> > On Thu, Oct 3, 2019 at 10:41
On Thu, Oct 3, 2019 at 10:41 PM Masahiro Yamada
wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 1:07 AM Steve French wrote:
> >
> > On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
> > wrote:
> > >
> > > Hi Steve,
> > >
merged into cifs-2.6.git for-next
On Tue, Oct 1, 2019 at 2:34 AM Austin Kim wrote:
>
> After 'Initial git repository build' commit,
> 'mapping_table_ERRHRD' variable has not been used.
>
> So 'mapping_table_ERRHRD' const variable could be removed
> to mute below warning message:
>
>fs/cifs/ne
On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 12:15 AM Steve French wrote:
> >
> > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich
> > wrote:
> > >
> > > Hi Steve!
> > >
> >
On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich wrote:
>
> Hi Steve!
>
> On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> >And running the build differently, from the root of the git tree
> >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
ocal: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2
On Wed, Oct 2, 2019 at 6:45 PM Steve French wrote:
>
> Following the instructions in Documentation/namespaces to autogenerate
> the namespace changes to avoid the multiple build warnings in 5.4-rc1
>
Following the instructions in Documentation/namespaces to autogenerate
the namespace changes to avoid the multiple build warnings in 5.4-rc1
for my module ... I am not able to get nsdeps to work. For example
in my module directory (fs/cifs) trying to build with nsdeps:
make -C /usr/src/lin
1 - 100 of 524 matches
Mail list logo
