angYuli
This looks good to me.
Reviewed-by: Simon Horman
And I see you also posted an patch to remove the only other in-tree
references from Documentation/translations/zh_CN/dev-tools/ubsan.rst [1].
Thanks.
[1]
https://lore.kernel.org/all/6f05157e5e157493+20250123043258.149643-1-wangy...@uniontech.com/
On Wed, Jan 22, 2025 at 06:16:35PM +, Simon Horman wrote:
> On Wed, Jan 22, 2025 at 03:41:02PM +0100, Peter Seiderer wrote:
> > While taking a look at '[PATCH net] pktgen: Avoid out-of-range in
> > get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid ou
On Wed, Jan 22, 2025 at 03:41:02PM +0100, Peter Seiderer wrote:
> While taking a look at '[PATCH net] pktgen: Avoid out-of-range in
> get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds access
> in get_imix_entries' ([2], [3]) and doing some tests and code review I
> detected th
On Tue, Jan 14, 2025 at 03:43:29PM +0800, liuye wrote:
> Fix the following warning.
I think it is a bit more than a warning, I'd phrase this more like,
even as it repeats the subject. Also, it would be nice to cite
the tool that generates the warning.
Address Null pointer dereference in rtatt
On Mon, Dec 09, 2024 at 09:53:31AM +0100, Antonio Quartulli wrote:
> The ovpn-cli tool can be compiled and used as selftest for the ovpn
> kernel module.
>
> [NOTE: it depends on libmedtls for decoding base64-encoded keys]
>
> ovpn-cli implements the netlink and RTNL APIs and can thus be integrat
On Mon, Dec 09, 2024 at 09:53:17AM +0100, Antonio Quartulli wrote:
> Packets received over the socket are forwarded to the user device.
>
> Implementation is UDP only. TCP will be added by a later patch.
>
> Note: no decryption/decapsulation exists yet, packets are forwarded as
> they arrive with
any change in the code, other than the mechanical
> separation.
>
> Signed-off-by: Breno Leitao
Tested-by: Simon Horman
Reviewed-by: Simon Horman
reate several userdata entries.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
>
> Replace silent ignore mechanism with WARN_ON_ONCE() to highlight
> potential misuse during development and debugging.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
ou need to add netcons_overflow.sh to
tools/testing/selftests/drivers/net/Makefile
Other than that, this looks good to me.
Tested-by: Simon Horman
Reviewed-by: Simon Horman
...
ently not
> * tested here.
> *
Thanks Zhu Jun,
FTR, I'm not sure that I understand the grammar in the comment.
But the spelling correction looks good to me and codespell
doesn't seem to flag any other spelling errors in this file.
So this change looks good to me.
Reviewed-by: Simon Horman
On Tue, Dec 03, 2024 at 08:35:53AM -0800, Joe Damato wrote:
> On Tue, Dec 03, 2024 at 08:26:11AM -0800, Joe Damato wrote:
> > On Mon, Dec 02, 2024 at 09:14:58PM -0800, Stanislav Fomichev wrote:
> > > On 12/03, Joe Damato wrote:
> > > > Fix various integer type conversions by using strtoull and a te
ireGuard secure network tunnel")
> Signed-off-by: Hangbin Liu
> ---
> v2: load the mode directly in case nf_conntrack is build in (Simon Horman)
Thanks for the update.
Reviewed-by: Simon Horman
the netconsole selftest to check for the existence of
> the /sys/bus/netdevsim/new_device file before running the test. If the
> file is not found, the test is skipped with an explanation that the
> CONFIG_NETDEVSIM kernel config option may not be enabled.
>
> Signed-off-by: Bre
On Thu, Nov 07, 2024 at 02:44:18AM +, Hangbin Liu wrote:
> Some distros may not load nf_conntrack by default, which will cause
> subsequent nf_conntrack settings to fail. Let's load this module if it's
> not loaded by default.
>
> Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
>
On Wed, Oct 23, 2024 at 04:13:36PM +0200, Matthieu Baerts wrote:
> Hi Simon,
>
> Thank you for the reviews!
>
> On 23/10/2024 14:21, Simon Horman wrote:
> > On Mon, Oct 21, 2024 at 12:25:27PM +0200, Matthieu Baerts (NGI0) wrote:
> >> mptcp_get_available_schedule
d another test to make sure getsockopt returns the right nkeys
> value when the input nkeys is smaller than the number of matching keys
> - Removed the TODO that this patch addresses
> v1: https://lore.kernel.org/netdev/20241014213313.15100-1-leocst...@gmail.com/
>
> Thanks to the reviewers for their time and feedback!
Thanks for the updates.
Reviewed-by: Simon Horman
would be more appropriate to route this via net-next
(without a fixes tag) rather than via net. But either way this looks good
to me.
Reviewed-by: Simon Horman
...
ed.c. Adding the missing lock/unlock avoids the
> warning.
>
> Fixes: 1730b2b2c5a5 ("mptcp: add sched in mptcp_sock")
> Cc: sta...@vger.kernel.org
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/523
> Reviewed-by: Geliang Tang
> Signed-off-by: Matthieu Baerts (NGI0)
Reviewed-by: Simon Horman
ore assumptions. For the moment, we are not
> interested by the output, only to avoid crashes and warnings.
>
> Signed-off-by: Matthieu Baerts (NGI0)
I am assuming that we are ok with expanding test coverage via net,
which FWIIW, does seem reasonable to me.
Reviewed-by: Simon Horman
...
.
>
> Signed-off-by: Karan Sanghavi
Thanks,
This addresses all the spelling errors in these files that
I see flagged by codespell.
Reviewed-by: Simon Horman
On Thu, Oct 17, 2024 at 03:52:51PM +0800, Liu Jing wrote:
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: Liu Jing
> Signed-off-by: Liu Jing
Thanks,
This is correct. However, it was fixed recently in the same way
by the following commit authored by one of your colleagues, Z
On Thu, Oct 17, 2024 at 11:14:36AM -0700, Anjali Kulkarni wrote:
> Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows
> a thread's non-zero exit status to be returned to proc_filter.
>
> The threads.c program creates 2 child threads. 1st thread handles signal
> SIGSEGV, an
On Thu, Oct 17, 2024 at 11:14:33AM -0700, Anjali Kulkarni wrote:
> Recently we committed a fix to allow processes to receive notifications for
> non-zero exits via the process connector module. Commit is a4c9a56e6a2c.
>
> However, for threads, when it does a pthread_exit(&exit_status) call, the
>
On Tue, Oct 15, 2024 at 10:51:52PM -0700, Leo Stone wrote:
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
>
> Sample output:
>
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filt
_LIST=y. Make sure CIs take advantage
> of CONFIG_PROVE_RCU_LIST=y, recent fixes in networking
> indicate that it does catch bugs.
>
> Signed-off-by: Jakub Kicinski
I exercised this in conjunction with tools/testing/selftests/net/config
and the resulting .config is as described before and after.
Reviewed-by: Simon Horman
On Tue, Oct 15, 2024 at 05:00:06PM +, Karan Sanghavi wrote:
> This patch corrects typographical errors in the "name" fields of
> the JSON objects with IDs "4319" and "4341" in the tc-testing
> selftests.
>
> - "diffferent" is corrected to "different".
> - "muliple" is corrected to "multiple".
On Fri, Oct 11, 2024 at 05:45:31PM -0700, Anjali Kulkarni wrote:
> Kunit tests to test hash table add, delete, duplicate add and delete.
> Add following configs and compile kernel code:
>
> CONFIG_CONNECTOR=y
> CONFIG_PROC_EVENTS=y
> CONFIG_NET=y
> CONFIG_KUNIT=m/y
> CONFIG_CN_HASH_KUNIT_TEST=m/y
On Fri, Oct 11, 2024 at 05:45:30PM -0700, Anjali Kulkarni wrote:
> Add a new type PROC_CN_MCAST_NOTIFY to proc connector API, which allows a
> thread to notify the kernel that it has exited abnormally. Thread can also
> send the exit status code it wants returned in the notification with it.
> Exit
On Fri, Sep 27, 2024 at 12:00:50PM +0800, zhangjiao2 wrote:
> From: zhang jiao
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao
Thanks, this looks good to me.
Reviewed-by: Simon Horman
dd bridge MDB test")
> Signed-off-by: Jamie Bainbridge
> ---
> v2: Avoid false check failures as seen by Jakub Kicinski.
> ---
Reviewed-by: Simon Horman
On Fri, Sep 13, 2024 at 10:39:20AM +0100, Tiago Lam wrote:
> This follows the same rationale provided for the ipv4 counterpart, where
> it now runs a reverse socket lookup when source addresses and/or ports
> are changed, on sendmsg, to check whether egress traffic should be
> allowed to go through
On Thu, Sep 12, 2024 at 10:17:13PM +0200, Alexis Lothoré wrote:
> Hi Simon,
>
> On 9/11/24 16:18, Simon Horman wrote:
>
> [...]
>
> >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c
> >> b/tools/testing/selftests/bpf/prog_tests/xdp_
On Tue, Sep 10, 2024 at 08:10:35PM +0200, Alexis Lothoré (eBPF Foundation)
wrote:
> test_xdp_features.sh is a shell script allowing to test that xdp features
> advertised by an interface are indeed delivered. The test works by starting
> two instance of the same program, both attaching specific xd
ess ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Update commit message.
Thanks for the update.
I checked and I was not able to find any other instances in this file.
Reviewed-by: Simon Horman
On Tue, Sep 03, 2024 at 05:51:11PM +0800, Liu Jing wrote:
> in the do_setcpu, this function does not need to have a return value,
> which is meaningless
>
> Signed-off-by: Liu Jing
Thanks,
I also see that the caller does not check the return value.
Reviewed-by: Simon Horman
On Tue, Sep 03, 2024 at 03:45:19PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni
As mentioned at [1] I think it would be nice if the patch description
was a bit more descriptive.
[1] https://lore.kernel.org/all/20240903152125.ga
On Wed, Aug 21, 2024 at 10:50:47PM +0100, David Woodhouse wrote:
...
> diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c
...
> +#define VMCLOCK_FIELD_PRESENT(_c, _f) \
> + (_c)->size >= (offsetof(struct vmclock_abi, _f) + \
> +si
On Sat, Jul 06, 2024 at 04:14:39PM +0100, David Woodhouse wrote:
> From: David Woodhouse
>
> The vmclock "device" provides a shared memory region with precision clock
> information. By using shared memory, it is safe across Live Migration.
>
> Like the KVM PTP clock, this can convert TSC-based c
me for nf-next, thanks!
>
> Acked-by: Julian Anastasov
Likewise, looks good to me.
Acked-by: Simon Horman
...
ter
Hi Dan, all,
Strictly this is doing two things. But I agree that the "ok" variable in
virtnet_get_hw_stats() was very confusing, and I'm not sure how long it
would have taken me to grasp the fix without that change being here too.
Reviewed-by: Simon Horman
On Thu, Apr 11, 2024 at 06:01:54PM +0800, xu.xi...@zte.com.cn wrote:
> From: hepeilin
nit: it's nicer if this From line matches one of the Signed-off-by lines
From: Peilin He
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when i
On Tue, Mar 26, 2024 at 08:15:56PM +0100, Johannes Berg wrote:
> From: Johannes Berg
>
> The way __print_symbolic() works is limited and inefficient
> in multiple ways:
> - you can only use it with a static list of symbols, but
>e.g. the SKB dropreasons are now a dynamic list
>
> - it buil
On Thu, Mar 14, 2024 at 12:00:27PM -0400, Steven Rostedt wrote:
> On Thu, 14 Mar 2024 15:39:28 +0100
> Paolo Abeni wrote:
>
> > On Wed, 2024-03-13 at 09:34 -0400, Steven Rostedt wrote:
...
> > > Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF
> > > mailbox")
> >
> > chec
On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote:
> Hi Simon,
>
> Thanks for your reply.
>
> On 2024/1/17 17:29, Simon Horman wrote:
> > On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
> > > Use the new KMEM_CACHE() macro instead of dir
probably be targeted at 'nf-next' rather than 'net'.
If it is a fix, then I would suggest targeting it at 'nf'
and providing a Fixes tag.
The above notwithstanding, this looks good to me.
Acked-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 +--
er (linuxtesting.org).
>
> Fixes: 8d8e20e2d7bb ("ipvs: Decrement ttl")
> Signed-off-by: Fedor Pchelkin
Acked-by: Simon Horman
max() is inclusive. So a -1 has been added when needed.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by: Simon Horman
On Tue, Dec 26, 2023 at 04:20:03PM -0800, Chris Lew wrote:
>
>
> On 12/23/2023 5:56 AM, Simon Horman wrote:
> > [Dropped bjorn.anders...@kernel.org, as the correct address seems
> > to be anders...@kernel.org, which is already in the CC list.
> > kernel.org
del() doesn't have any other error return value.
>
> Signed-off-by: Sarannya Sasikumar
Thanks,
I have a suggestion below. But that notwithstanding this change
looks good to me.
Reviewed-by: Simon Horman
> ---
> net/qrtr/ns.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
wonder if it would make things clearer to the reader (me?)
if the return type of service_announce_del was updated void. Because
as things stand -ENODEV may be returned, which implies something might
handle that, even though it doe not.
The above notwithstanding, this change looks good to me.
Reviewed-by: Simon Horman
...
On Wed, Dec 20, 2023 at 01:45:02PM -0800, Mina Almasry wrote:
> Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref
> is always a struct page underneath, but the abstraction allows efforts
> to add support for skb frags not backed by pages.
>
> There is unfortunately 1 instance wher
section protected by a check
> for CONFIG_IPV6.
>
> Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
Tested-by: Simon Horman # build-tested
On Thu, Sep 07, 2023 at 12:56:47PM -0700, Sonia Sharma wrote:
> From: Sonia Sharma
>
> The switch statement in netvsc_send_completion() is incorrectly validating
> the length of incoming network packets by falling through to the next case.
> Avoid the fallthrough. Instead break after a case match
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insert
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insert
On Thu, Mar 25, 2021 at 02:35:55PM +0800, Wan Jiabing wrote:
> struct sk_buff has been declared. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
Thanks, nice catch.
Reviewed-by: Simon Horman
inux/issues/115
> Signed-off-by: Gustavo A. R. Silva
Thanks Gustavo,
this looks good to me.
Acked-by: Simon Horman
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net
w if its intentionally that
the following was left alone in
ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo()
snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu"
If the above was not intentional then perhaps you could respin with that
updated and resubmit when net-next re-opens. Feel free to add:
Reviewed-by: Simon Horman
ochip/Kconfig | 1 +
> drivers/net/ethernet/netronome/Kconfig | 1 +
> drivers/net/ethernet/nxp/Kconfig| 1 +
> drivers/net/ethernet/rocker/Kconfig | 1 +
> 10 files changed, 10 insertions(+)
Hi Arnd,
I'm slightly curious to know how you configured the kernel to build
the Netronome NFP driver but not CRC32 but nonetheless I have no
objection to this change.
For the Netronome portion:
Acked-by: Simon Horman
ion
> of macro 'fallthrough'
> 299 | fallthrough;
> | ^~~
>
> Reported-by: kernel test robot
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Simon Horman
Thanks, this does indeed seem to be the case.
Reviewed-by: Simon Horman
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote:
> From: ylg
>
> adjust the debug order of src and dst when tcp state changes
>
> Signed-off-by: ylg
Hi,
This sounds reasonable to me but please provide your real name
in the Signed-off-by name, which should be consistent with the
On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
>
> Signed-off-by: YueHaibing
Thanks, this look good to me.
Acked-by: Simon Horman
Pablo, please con
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> fallthrough to a separate case/default label break; isn't very readable.
>
> Convert pseudo-keyword fallthrough; statements to a simple break; when
> the next label is case or default and the only statement in the next
> label block is
Hi Wang,
On Wed, Sep 09, 2020 at 08:19:21PM +0800, Wang Qing wrote:
> Change the comment typo: "direcly" -> "directly".
>
> Signed-off-by: Wang Qing
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
git log tells me that the
Hi Wang,
On Wed, Sep 09, 2020 at 08:12:44PM +0800, Wang Qing wrote:
> Change the comment typo: "direcly" -> "directly".
>
> Signed-off-by: Wang Qing
git log tells me that the correct prefix for this patch
is "netfilter: conntrack:" rather than "net/netfilter:"
Probably this patch is targeted
On Tue, Sep 08, 2020 at 10:04:08AM +1200, Paul Davey wrote:
> Insert the full 16 bit VIF ID into ipmr Netlink cache reports.
>
> The VIF_ID attribute has 32 bits of space so can store the full VIF ID
> extracted from the high and low byte fields in the igmpmsg.
>
> Signed-off-by: Paul Davey
> --
ned-off-by: Romain Perier
> Signed-off-by: Allen Pais
Reviewed-by: Simon Horman
But:
This series should be targeted at net-next, and thus have net-next in its
subject
[PATCH net-next x/y] ...
And it should be posted when net-next is open: it is currently closed.
http://v
Anastasov
Pablo, could you consider this for nf-next or should we repost when
net-next re-opens?
Reviewed-by: Simon Horman
or each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Simon Horman
| 3 ++-
> 25 files changed, 60 insertions(+), 50 deletions(-)
Netronome portion:
Reviewed-by: Simon Horman
On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote:
> From: xidongwang
>
> The stack object “zone_limit” has 3 members. In function
> ovs_ct_limit_get_default_limit(), the member "count" is
> not initialized and sent out via “nla_put_nohdr”.
Hi Xidong,
thanks for your patch.
It appear
;
> Change the #ifdef to an equivalent IS_ENABLED().
>
> Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device()
> call-backs")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Simon Horman
> ---
> drivers/iommu/ipmmu-vmsa.c | 7 ++-
> 1 file chan
gt; Signed-off-by: Mauro Carvalho Chehab
Acked-by: Simon Horman
On Wed, Oct 23, 2019 at 06:58:16PM +0200, Matteo Croce wrote:
> On Wed, Oct 23, 2019 at 12:01 PM Simon Horman
> wrote:
> >
> > On Mon, Oct 21, 2019 at 10:09:48PM +0200, Matteo Croce wrote:
> > > The bonding uses the L4 ports to balance flows between slaves.
> > &g
On Wed, Oct 23, 2019 at 12:53:37PM +0200, Matteo Croce wrote:
> On Wed, Oct 23, 2019 at 12:00 PM Simon Horman
> wrote:
> > On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote:
> > > + switch (ih->type) {
> > > + case ICMP_ECHO:
> > > +
On Wed, Oct 23, 2019 at 06:36:13PM +0800, Jason Wang wrote:
>
> On 2019/10/23 下午6:13, Simon Horman wrote:
> > On Tue, Oct 22, 2019 at 09:32:36AM +0800, Jason Wang wrote:
> > > On 2019/10/22 上午12:31, Simon Horman wrote:
> > > > On Mon, Oct 21, 2019 at 05:5
On Tue, Oct 22, 2019 at 09:32:36AM +0800, Jason Wang wrote:
>
> On 2019/10/22 上午12:31, Simon Horman wrote:
> > On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote:
> > > On 10/16/2019 5:53 PM, Simon Horman wrote:
> > > > Hi Zhu,
>
On Mon, Oct 21, 2019 at 10:09:48PM +0200, Matteo Croce wrote:
> The bonding uses the L4 ports to balance flows between slaves.
> As the ICMP protocol has no ports, those packets are sent all to the
> same device:
>
> # tcpdump -qltnni veth0 ip |sed 's/^/0: /' &
> # tcpdump -qltnni veth1 ip
On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote:
> The ICMP flow dissector currently parses only the Type and Code fields.
> Some ICMP packets (echo, timestamp) have a 16 bit Identifier field which
> is used to correlate packets.
> Add such field in flow_dissector_key_icmp and replace
only for ICMP packets.
>
> Signed-off-by: Matteo Croce
Reviewed-by: Simon Horman
> ---
> net/core/flow_dissector.c | 34 +-
> 1 file changed, 25 insertions(+), 9 deletions(-)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dis
On Mon, Oct 21, 2019 at 10:09:45PM +0200, Matteo Croce wrote:
> Documents two piece of code which can't be understood at a glance.
>
> Signed-off-by: Matteo Croce
Reviewed-by: Simon Horman
> ---
> include/net/flow_dissector.h | 1 +
> net/core/flow_dissector.c
On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote:
>
> On 10/16/2019 5:53 PM, Simon Horman wrote:
> > Hi Zhu,
> >
> > thanks for your patch.
> >
> > On Wed, Oct 16, 2019 at 09:10:40AM +0800, Zhu Lingshan wrote:
...
> > > +static void i
On Wed, Oct 16, 2019 at 08:42:48PM +0200, Marcel Holtmann wrote:
> Hi Simon,
>
> >> It looks like in hci_init4_req() the request is being
> >> initialised from cpu-endian data but the packet is specified
> >> to be little-endian. This causes an warning from sparse due
> >> to __le16 to u16 convers
On Thu, Oct 17, 2019 at 08:57:26AM +0200, Geert Uytterhoeven wrote:
> Hi Shimoda-san, Simon,
>
> On Thu, Oct 17, 2019 at 4:18 AM Yoshihiro Shimoda
> wrote:
> > > From: Simon Horman, Sent: Wednesday, October 16, 2019 9:27 PM
> >
> > > > diff --git a/driver
ument 3 (different base types)
> drivers/usb/renesas_usbhs/common.c:175:39:expected unsigned short
> [usertype] data
>
> Note. I belive this to be correct, and should be a no-op on arm.
>
> Signed-off-by: Ben Dooks
> ---
> Cc: Greg Kroah-Hartman
> Cc: Yoshihiro Shimoda
On Wed, Oct 16, 2019 at 12:39:43PM +0100, Ben Dooks (Codethink) wrote:
> It looks like in hci_init4_req() the request is being
> initialised from cpu-endian data but the packet is specified
> to be little-endian. This causes an warning from sparse due
> to __le16 to u16 conversion.
>
> Fix this by
At the end of the v5.3 upstream development cycle I stepped down
from my role at Renesas.
Pass maintainership of the R-Car PCIE to Marek and Shimoda-san.
Signed-off-by: Simon Horman
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Hi Zhu,
thanks for your patch.
On Wed, Oct 16, 2019 at 09:03:18AM +0800, Zhu Lingshan wrote:
> This commit introduced IFC VF operations for vdpa, which complys to
> vhost_mdev interfaces, handles IFC VF initialization,
> configuration and removal.
>
> Signed-off-by: Zhu Lingshan
> ---
> driver
Hi Zhu,
thanks for your patch.
On Wed, Oct 16, 2019 at 09:10:40AM +0800, Zhu Lingshan wrote:
> This commit introduced ifcvf_base layer, which handles IFC VF NIC
> hardware operations and configurations.
>
> Signed-off-by: Zhu Lingshan
> ---
> drivers/vhost/ifcvf/ifcvf_base.c | 390
> +
On Tue, Oct 15, 2019 at 10:20:46PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing
Reviewed-by: Simon Horman
> ---
> drivers/net/can/ifi_canfd/ifi_canfd.c | 4 +---
&g
On Tue, Oct 15, 2019 at 06:37:54AM +, Jeroen Hofstee wrote:
> Hi,
>
> On 10/15/19 7:57 AM, Simon Horman wrote:
> > On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote:
> >> From: kbuild test robot
> >>
> >> drivers/net/can/m_can/m
On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote:
> From: kbuild test robot
>
> drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function
> 'is_protocol_err' with return type bool
>
> Return statements in functions returning bool should use
> true/false inste
add an entry to the CREDITS file to honor his
> work.
>
> Signed-off-by: Geert Uytterhoeven
Acked-by: Simon Horman
> ---
> CREDITS | 4
> MAINTAINERS | 4
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CREDITS b/CREDITS
> in
On Thu, Oct 10, 2019 at 10:50:52PM +0800, Haishuang Yan wrote:
> This series patch include test cases for ipvs.
>
> The test topology is who as below:
> +--+
> | | |
> | n
Haishuang Yan
> ---
> v5: use cmp to compare two file contents suggested by Simon Horman
> v4: use #!/bin/bash -p suggested by Duncan Roe
> v3: use bash style
> v2: optimize test script
> ---
> tools/testing/selftests/netfilter/Makefile | 2 +-
On Sat, Oct 05, 2019 at 10:37:43PM +0800, Haishuang Yan wrote:
> Test virutal server via directing routing for IPv4.
>
> Tested:
>
> # selftests: netfilter: ipvs.sh
> # Testing DR mode...
> # ipvs.sh: PASS
> ok 6 selftests: netfilter: ipvs.sh
>
> Signed-off-by: Haishuang Yan
> ---
> v4: use #!/
On Sat, Oct 05, 2019 at 07:54:15PM +0800, Kai-Heng Feng wrote:
>
>
> > On Oct 5, 2019, at 19:46, Simon Horman wrote:
> >
> > On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote:
> >> r8152 may fail to establish network connection after resume from s
On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote:
> r8152 may fail to establish network connection after resume from system
> suspend.
>
> If the USB port connects to r8152 lost its power during system suspend,
> the MAC address was written before is lost. The reason is that The MAC
>
1 - 100 of 1032 matches
Mail list logo
