Re: [PATCH] gpio: gpio-it87: remove unused code

2021-04-06 Thread Simon Guinot
On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng

Re: [PATCH leds v2 00/50] Start moving parsing of `linux,default-trigger` to LED core (a cleanup of LED drivers)

2020-09-26 Thread Simon Guinot
t; leds: ns2: reorder headers alphabetically > leds: ns2: use struct led_init_data when registering > leds: parse linux,default-trigger DT property in LED core Hi Marek, For all the patches applying to the leds-ns2 driver: Reviewed-by: Simon Guinot Tested-by: Simon Guinot Thanks for it. The driver is looking way better. Simon signature.asc Description: PGP signature

Re: [PATCH leds v2 00/50] Start moving parsing of `linux,default-trigger` to LED core (a cleanup of LED drivers)

2020-09-22 Thread Simon Guinot
On Fri, Sep 18, 2020 at 12:32:48AM +0200, Marek Behún wrote: > Hi, > > this series is also available at [1]. > > This is v2, you can read cover letter of v1 at [2] (togehter with > explanation of why I did this). ... > leds: ns2: use devres LED registering function > leds: ns2: alloc simple

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Simon Guinot
On Mon, Sep 21, 2020 at 03:02:08PM +0200, Marek Behun wrote: > On Mon, 21 Sep 2020 14:53:43 +0200 > Simon Guinot wrote: > > > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > > > On Fri, 18 Sep 2020 15:02:06 +0200 > > > Simon Guinot wrote: > &g

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-21 Thread Simon Guinot
On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote: > On Fri, 18 Sep 2020 15:02:06 +0200 > Simon Guinot wrote: > > > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote: > > > > Hi Marek, > > > > > By using struct led_init_dat

Re: [PATCH leds v1 10/10] leds: ns2: refactor and use struct led_init_data

2020-09-18 Thread Simon Guinot
e should be the > way forward anyway. > > Also build this driver if COMPILE_TEST is enabled. > > Signed-off-by: Marek Behún > Cc: Simon Guinot > Cc: Simon Guinot > Cc: Vincent Donnefort > Cc: Thomas Petazzoni > Cc: Linus Wallei

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-22 Thread Simon Guinot
On Fri, Nov 18, 2016 at 12:20:07PM +0100, Simon Guinot wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > > > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote: > > > >

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-18 Thread Simon Guinot
On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote: > > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > > > Hi Amir, >

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-15 Thread Simon Guinot
On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote: > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > > This driver enables Thunderbolt Networking on non-Apple platforms > > > running Lin

[PATCH] kernel/resource.c: ensure parent is not freed in __request_region()

2016-02-24 Thread Simon Guinot
es the issue by resetting the parent pointer to the root parent resource when sleeping is needed. Signed-off-by: Simon Guinot Cc: sta...@vger.kernel.org --- kernel/resource.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c ind

Re: [PATCH] kernel/resource.c: fix muxed resource handling in __request_region()

2016-02-23 Thread Simon Guinot
On Mon, Feb 22, 2016 at 12:46:09PM -0800, Jesse Barnes wrote: > On 02/22/2016 05:49 AM, Alan Cox wrote: > >> we have some good alternatives in the form of bus and platform > >> drivers that > >> can manage the appropriate serialization and keep things from > >> stomping > >> on one another. > > >

Re: [PATCH V2 1/1] gpio-f7188x: Add F81866 GPIO supports

2016-01-23 Thread Simon Guinot
On Fri, Jan 22, 2016 at 05:45:20PM +0800, Peter Hung wrote: > Hi Simon, > > Simon Guinot 於 2016/1/22 下午 04:58 寫道: > >On Fri, Jan 22, 2016 at 03:23:33PM +0800, Peter Hung wrote: > >Acked-by: Simon Guinot > > > >Thanks, > > > > Should I resend patc

Re: [PATCH V2 1/1] gpio-f7188x: Add F81866 GPIO supports

2016-01-22 Thread Simon Guinot
d: 0xb0 > GPIO5x based: 0xa0 > GPIO6x based: 0x90 > GPIO7x based: 0x80 > GPIO8x based: 0x88 <-- not 0x70. > > Signed-off-by: Peter Hung > --- > drivers/gpio/Kconfig | 4 ++-- > drivers/gpio/gpio-f7188x.c | 27 ++++--- >

Re: [PATCH v2 net 4/6] net: mvneta: fix error path for building skb

2015-11-26 Thread Simon Guinot
191 ("net: mvneta: fix refilling for Rx DMA buffers") > --- > drivers/net/ethernet/marvell/mvneta.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Acked-by: Simon Guinot Thanks, Simon > diff --git a/drivers/net/ethernet/marvell/mvneta.c > b/drive

Re: [PATCH 06/13] net: mvneta: enable mixed egress processing using HR timer

2015-11-26 Thread Simon Guinot
ith small > latency. > > Along with existing tx_done processing by coalescing interrupts this > commit enables triggering HR timer each time the packets are sent. > Time threshold can also be configured, using ethtool. > > Signed-off-by: Marcin Wojtas > Signed-off-by: S

Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

2015-10-27 Thread Simon Guinot
On Tue, Oct 27, 2015 at 04:23:43PM +0200, Mika Westerberg wrote: > On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: > > > +menu "ISA GPIO drivers" > > > + > > > +config GPIO_104_IDIO_16 > > > + tristate "ACCES 104-IDIO-16 GPIO support" > > > + depends on X86 > > > +

Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

2015-10-27 Thread Simon Guinot
On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: > On Mon, Oct 19, 2015 at 6:59 PM, William Breathitt Gray > wrote: > > > The ACCES 104-IDIO-16 family of PC/104 utility boards feature 16 > > optically isolated inputs and 16 optically isolated FET solid state > > outputs. This driver

Re: [PATCH] leds: leds-netxbig.c: Use devm_led_classdev_register

2015-10-21 Thread Simon Guinot
On Wed, Oct 21, 2015 at 09:01:00AM +0200, Jacek Anaszewski wrote: > Hi Fida, > > On 10/20/2015 10:06 PM, Fida Mohammad wrote: > >Use resource managed function devm_led_classdev_register to make > >error path simpler. Consequently, removed a goto call and > >remove function made simpler. > > > >Sig

[PATCH] kernel/resource.c: fix muxed resource handling in __request_region()

2015-09-09 Thread Simon Guinot
ource pointer in the case we have to wait for a muxed region right after. Reported-by: Vincent Pelletier Signed-off-by: Simon Guinot Tested-by: Vincent Donnefort --- kernel/resource.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c

Re: [1/4] gpio: gpio-f7188x: Use mutex for access serialisation.

2015-09-09 Thread Simon Guinot
On Thu, Sep 03, 2015 at 08:05:40PM +0200, Vincent Pelletier wrote: > Hi, > > On Fri, 21 Aug 2015 22:48:24 +0200, Vincent Pelletier > wrote: > > On Fri, 21 Aug 2015 19:52:16 +0200, Simon Guinot > > wrote: > > > Please, could you describe a setup (a

Re: [PATCH/RFC v3 0/7] Remove work queues from LED class drivers

2015-07-14 Thread Simon Guinot
|8 ++-- > drivers/media/v4l2-core/v4l2-flash-led-class.c |8 ++-- > include/linux/leds.h | 36 +++- > 16 files changed, 124 insertions(+), 225 deletions(-) Hi Jacek, I have successfully tested this patch set with both the leds-ns2 a

Re: [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename

2015-06-25 Thread Simon Guinot
On Thu, Jun 25, 2015 at 11:30:06PM +0800, Herbert Xu wrote: > On Thu, Jun 25, 2015 at 10:37:50AM +0200, Simon Guinot wrote: > > This patch fixes the following build error: > > > > drivers/crypto/mv_cesa.c: In function 'mv_cesa_get_sram': > > drivers/c

[PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename

2015-06-25 Thread Simon Guinot
eger without a cast scripts/Makefile.build:258: recipe for target 'drivers/crypto/mv_cesa.o' failed Signed-off-by: Simon Guinot --- drivers/crypto/mv_cesa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index 5bc

Re: linux-next: Tree for Mar 11 (arm:multi_v5_defconfig build failure)

2015-03-11 Thread Simon Guinot
On Wed, Mar 11, 2015 at 08:55:48AM -0700, Guenter Roeck wrote: > On Wed, Mar 11, 2015 at 04:35:58PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20150310: > > > > New tree: drm-exynos > > > > The sound-asoc tree still had its build failure so I used the version from > > next-

Re: [PATCH 00/27] ARM: mvebu: armada-*: Relicense the device tree under GPLv2+/X11

2014-12-23 Thread Simon Guinot
On Mon, Dec 22, 2014 at 10:14:32PM +0100, Arnd Bergmann wrote: > On Monday 22 December 2014 12:29:33 Simon Guinot wrote: > > On Sun, Dec 21, 2014 at 06:50:00PM -0500, Jason Cooper wrote: > > > On Fri, Dec 19, 2014 at 07:16:16PM +0100, Simon Guinot wrote: > > > > &

Re: [PATCH 00/27] ARM: mvebu: armada-*: Relicense the device tree under GPLv2+/X11

2014-12-22 Thread Simon Guinot
On Sun, Dec 21, 2014 at 06:50:00PM -0500, Jason Cooper wrote: > On Fri, Dec 19, 2014 at 07:16:16PM +0100, Simon Guinot wrote: > > On Fri, Dec 19, 2014 at 12:43:00PM -0500, Jason Cooper wrote: > > > On Fri, Dec 19, 2014 at 06:11:56PM +0100, Gregory CLEMENT wrote: > > > &

Re: [PATCH 0/2] md: fix fix deadlock while suspending RAID array

2014-03-18 Thread Simon Guinot
On Tue, Mar 11, 2014 at 08:12:08PM +0100, Simon Guinot wrote: > Hi, > > This patch series fixes a deadlock which have been observed while > updating a RAID array level, using the mdadm --grow command. A full > description of the issue (hopefully understandable enough) is provided

[PATCH 0/2] md: fix fix deadlock while suspending RAID array

2014-03-11 Thread Simon Guinot
correct and/or if there is an another way (maybe more handy) to solve this deadlock issue. Thanks, Simon Simon Guinot (2): md: move up mddev locking functions md: fix deadlock while suspending RAID array drivers/md/md.c | 154 ++-- 1 file

[PATCH 2/2] md: fix deadlock while suspending RAID array

2014-03-11 Thread Simon Guinot
uring there is no pending active I/Os before suspending effectively a RAID array. Signed-off-by: Simon Guinot Tested-by: Rémi Rérolle --- drivers/md/md.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index fb4296adae80..ea3

[PATCH 1/2] md: move up mddev locking functions

2014-03-11 Thread Simon Guinot
This patch slightly moves up the mddev locking functions. This allows to use them from mddev_suspend(). Signed-off-by: Simon Guinot --- drivers/md/md.c | 135 1 file changed, 67 insertions(+), 68 deletions(-) diff --git a/drivers/md/md.c

[PATCH 1/2] rtc: rtc-ds1307: fix sysfs wakealarm attribute creation

2014-02-15 Thread Simon Guinot
In order to allow the creation of the sysfs attribute wakealarm, this patch moves the device_set_wakeup_capable() call above the RTC device registration. Signed-off-by: Simon Guinot --- drivers/rtc/rtc-ds1307.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc

[PATCH 2/2] rtc: rtc-ds1307: add alarm support for mcp7941x chips

2014-02-15 Thread Simon Guinot
This patch adds alarm support for the Microchip RTC devices MCP794xx. Note that two programmable alarms are provided by the chip but only one is used by the driver. Signed-off-by: Simon Guinot --- drivers/rtc/rtc-ds1307.c | 183 ++- 1 file changed

[PATCH 0/2] Add alarm suport for the Microchip RTC devices MCP794xx

2014-02-15 Thread Simon Guinot
Hello, This patch series adds alarm support for the Microchip RTC devices MCP794xx. A such compatible RTC (MCP7940NT) is embedded on the Seagate boards n090x01 (based on the Armada-370 SoC). Regards, Simon Simon Guinot (2): rtc: rtc-ds1307: fix sysfs wakealarm attribute creation rtc: rtc

Re: [Patch] Read CONFIG_RD_ variables for initramfs compression

2013-12-11 Thread Simon Guinot
On Thu, Oct 31, 2013 at 12:35:05PM +0530, P J P wrote: > Hello Andrew, > > +-- On Wed, 30 Oct 2013, Andrew Morton wrote --+ > | Isn't there some convenient way of testing for the presence of an > | executable in $PATH? > | > | The shell-builtin `which' seems to dtrt: > > True. Please see an

Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

2013-08-29 Thread Simon Guinot
On Thu, Aug 29, 2013 at 05:25:51PM +0100, Matthew Garrett wrote: > On Thu, Aug 29, 2013 at 09:08:30AM -0700, Guenter Roeck wrote: > > On Thu, Aug 29, 2013 at 04:37:38PM +0100, Matthew Garrett wrote: > > > On Thu, Aug 29, 2013 at 06:41:41AM -0700, Guenter Roeck wrote: > > > The majority of board ven

[PATCH v4] gpio: add GPIO support for F71882FG and F71889F

2013-08-29 Thread Simon Guinot
ports, a keyboard controller, an hardware monitoring controller and some GPIO pins. Note that this super-I/Os are embedded on some Atom-based LaCie NASes. The GPIOs are used to control the LEDs and the hard drive power. Signed-off-by: Simon Guinot --- Linus, Here is a v4 for the driver gpio

Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

2013-08-26 Thread Simon Guinot
On Thu, Aug 01, 2013 at 08:52:32AM -0700, Guenter Roeck wrote: > On 08/01/2013 06:46 AM, Simon Guinot wrote: > >On Mon, Jul 29, 2013 at 05:59:08PM +0200, Linus Walleij wrote: > >>On Mon, Jul 22, 2013 at 11:50 AM, Simon Guinot > >> wrote: > >> > >>>Th

Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

2013-08-01 Thread Simon Guinot
On Mon, Jul 29, 2013 at 05:59:08PM +0200, Linus Walleij wrote: > On Mon, Jul 22, 2013 at 11:50 AM, Simon Guinot > wrote: > > > This patch adds support for the GPIOs found on the Fintek super-I/O > > chips F71882FG and F71889F. > > > > A super-I/O is a lega

[PATCH v3] gpio: add GPIO support for F71882FG and F71889F

2013-07-22 Thread Simon Guinot
ports, a keyboard controller, an hardware monitoring controller and some GPIO pins. Note that this super-I/Os are embedded on some Atom-based LaCie NASes. The GPIOs are used to control the LEDs and the hard drive power. Signed-off-by: Simon Guinot --- Changes since v2: - Remove useless NULL

[PATCH v2] gpio: add GPIO support for F71882FG and F71889F

2013-07-17 Thread Simon Guinot
ports, a keyboard controller, an hardware monitoring controller and some GPIO pins. Note that this super-I/Os are embedded on some Atom-based LaCie NASes. The GPIOs are used to control the LEDs and the hard drive power. Signed-off-by: Simon Guinot --- Linus, I am waiting for your feedback about

Re: [PATCH] gpio: add GPIO support for F71882FG and F71889F

2013-07-01 Thread Simon Guinot
On Sun, Jun 30, 2013 at 01:35:00AM +0200, Linus Walleij wrote: Hi Linus, > On Wed, Jun 26, 2013 at 1:56 PM, Simon Guinot > wrote: > > > This patch adds support for the GPIOs found on the Fintek Super-I/O > > chips F71882FG and F71889F. > > > > Signed-off-by:

[PATCH] gpio: add GPIO support for F71882FG and F71889F

2013-06-26 Thread Simon Guinot
This patch adds support for the GPIOs found on the Fintek Super-I/O chips F71882FG and F71889F. Signed-off-by: Simon Guinot --- drivers/gpio/Kconfig | 10 + drivers/gpio/Makefile |1 + drivers/gpio/gpio-f7188x.c | 437 3 files

Re: linux-next: manual merge of the arm-soc tree with the driver-core tree

2012-11-29 Thread Simon Guinot
On Thu, Nov 29, 2012 at 04:03:09PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the arm-soc tree got a conflict in > drivers/leds/leds-ns2.c between commit 98ea1ea20cb7 ("leds: remove use of > __devinit") from the driver-core tree and commit 72052fcc1026 ("leds: > leds-