Re: [PATCH 4/4] remoteproc: qcom: q6v5-pil: Add PDC restart for modem on SDM845 SoCs

2018-07-31 Thread Sibi S
Hi Philipp, Thanks for the review! On 07/31/2018 02:24 PM, Philipp Zabel wrote: On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: In the presence of a PDC block working with subsystem RSC, assert/deassert PDC restart in modem start/stop path. Signed-off-by: Sibi Sankar --- .../bindings/

Re: [PATCH 3/4] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line

2018-07-31 Thread Sibi S
Hi Philipp, Thanks for the review! On 07/31/2018 02:27 PM, Philipp Zabel wrote: On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: Explicitly get mss_restart to facilitate adding PDC restart line for modem on SDM845 SoCs Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_pil.c |

Re: [PATCH 2/4] reset: qcom: PDC (Power Domain Controller) reset controller

2018-07-31 Thread Sibi S
Hi Philipp, Thanks for the review! On 07/31/2018 02:21 PM, Philipp Zabel wrote: On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: Add reset controller for SDM845 SoC to control reset signals provided by PDC for Modem, Compute, Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS Signed-of

Re: [PATCH 1/4] dt-bindings: reset: Add PDC reset binding for SDM845 SoCs

2018-07-31 Thread Sibi S
Hi Philipp, Thanks for the review! On 07/31/2018 02:12 PM, Philipp Zabel wrote: Hi Sibi, On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: Add SDM845 PDC (Power Domain Controller) reset controller binding Signed-off-by: Sibi Sankar --- .../bindings/reset/qcom,pdc-reset.txt | 52

Re: [PATCH v5 1/8] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

2018-06-27 Thread Sibi S
Hi Bjorn, Thanks for the review will address the comments in the next respin. On 06/23/2018 06:14 AM, Bjorn Andersson wrote: On Mon 21 May 10:27 PDT 2018, Sibi Sankar wrote: Add SDM845 AOSS (always on subsystem) reset controller binding I think it would be better if you made the binding rep

Re: [RFC PATCH 2/5] remoteproc: q6v5: Extract common resource handling

2018-06-01 Thread Sibi S
Hi Sricharan, On 06/01/2018 11:46 AM, Sricharan R wrote: Hi Bjorn, Thanks for this much needed consolidation. On 5/23/2018 10:50 AM, Bjorn Andersson wrote: Shared between all Hexagon V5 based remoteprocs is the handling of the 5 interrupts and the SMP2P stop request, so break this out into

Re: [PATCH v5 5/8] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845

2018-05-29 Thread Sibi S
Hi Rob, Will send it out again. On 05/22/2018 09:26 PM, Rob Herring wrote: On Mon, May 21, 2018 at 10:57:11PM +0530, Sibi Sankar wrote: Add new compatible string for Qualcomm SDM845 SoCs Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 + 1 file

Re: [PATCH v2] remoteproc: Introduce prepare/unprepare ops for rproc coredump

2018-05-29 Thread Sibi S
Hi Bjorn, Thanks for the review. On 05/29/2018 10:35 AM, Bjorn Andersson wrote: On Mon 21 May 11:45 PDT 2018, Sibi Sankar wrote: In some occasions the remoteproc device might need to prepare some hardware before the coredump can be performed and cleanup the state afterwards. Q6V5 modem requi

Re: [PATCH v5 3/8] remoteproc: Move proxy unvote to handover irq handler

2018-05-21 Thread Sibi S
Hi Bjorn, Thanks for the review. On 05/22/2018 10:05 AM, Bjorn Andersson wrote: On Mon 21 May 10:27 PDT 2018, Sibi Sankar wrote: Introduce interrupt handler for smp2p ready interrupt to handle start completion. Move the proxy votes for clocks and regulators to the handover interrupt context.

Re: [PATCH v4 5/5] remoteproc: qcom: Always assert and deassert reset signals in SDM845

2018-05-21 Thread Sibi S
Hi Bjorn, Thanks for the review. Will make all the required changes in v5. On 05/19/2018 03:17 AM, Bjorn Andersson wrote: On Wed 25 Apr 08:08 PDT 2018, Sibi Sankar wrote: SDM845 brings a new reset signal ALT_RESET which is a part of the MSS subsystem hence requires some of the active clks to b

Re: [PATCH v4 4/5] remoteproc: qcom: Add support for mss remoteproc on SDM845

2018-05-21 Thread Sibi S
Hi Bjorn, Thanks for the review. On 05/19/2018 03:01 AM, Bjorn Andersson wrote: On Wed 25 Apr 08:08 PDT 2018, Sibi Sankar wrote: From SDM845, the Q6SS reset sequence on software side has been simplified with the introduction of boot FSM which assists in bringing the Q6 out of reset Add GLINK

Re: [PATCH] remoteproc: Proxy unvote clk/regs in handover context

2018-05-21 Thread Sibi S
Hi Bjorn, Thanks for the review. Will make all the suggested changes. On 05/19/2018 01:28 AM, Bjorn Andersson wrote: On Wed 25 Apr 07:50 PDT 2018, Sibi Sankar wrote: Introduce interrupt handler for smp2p ready interrupt and handle start completion. Remove the proxy votes for clocks and regulat

Re: [PATCH v4 2/5] reset: qcom: AOSS (always on subsystem) reset controller

2018-04-27 Thread Sibi S
Hi Philipp, Thanks for the review. On 04/27/2018 04:11 PM, Philipp Zabel wrote: On Wed, 2018-04-25 at 20:38 +0530, Sibi Sankar wrote: Add reset controller driver for Qualcomm SDM845 SoC to control reset signals provided by AOSS for Modem, Venus ADSP, GPU, Camera, Wireless, Display subsystem S

Re: [PATCH v4 1/5] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

2018-04-27 Thread Sibi S
Hi Philipp, Thanks for the review On 04/27/2018 03:54 PM, Philipp Zabel wrote: Hi Sibi, On Wed, 2018-04-25 at 20:38 +0530, Sibi Sankar wrote: Add SDM845 AOSS (always on subsystem) reset controller binding Signed-off-by: Sibi Sankar --- .../bindings/reset/qcom,aoss-reset.txt| 52 ++

Re: [PATCH] arm64: dts: qcom: Add SDM845 SMEM nodes

2018-04-26 Thread Sibi S
Hi Bjorn, Thanks for the review On 04/26/2018 03:36 AM, Bjorn Andersson wrote: On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote: diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 9be763da0664..bea985045759 100644 --- a/arch/arm64/boot/dts/qcom/sdm84

Re: [PATCH v3 2/7] reset: qcom: AOSS (always on subsystem) reset controller

2018-03-22 Thread Sibi S
Hi Bjorn, Thanks for the review. On 03/19/2018 04:15 AM, Bjorn Andersson wrote: On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 7fc7769..d06bd1d 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -81,6 +81,16 @@ config

Re: [PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845

2018-03-22 Thread Sibi S
Hi Bjorn, Thanks for the review On 03/19/2018 04:16 AM, Bjorn Andersson wrote: On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c [..] +struct q6v5_reset_ops { + int (*reset_start)(struct q6v5 *qproc

Re: [PATCH v3 1/7] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

2018-03-20 Thread Sibi S
Hi Bjorn, Thanks for the review. On 03/19/2018 04:14 AM, Bjorn Andersson wrote: On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote: +- reg: + Usage: required + Value type: + Definition: must specify the base address and size of the register + space. + + Double

[PATCH v3 2/7] reset: qcom: AOSS (always on subsystem) reset controller

2018-03-14 Thread Sibi S
Add reset controller driver for Qualcomm SDM845 SoC to control reset signals provided by AOSS for Modem, Venus ADSP, GPU, Camera, Wireless, Display subsystem Signed-off-by: Sibi S --- drivers/reset/Kconfig | 10 +++ drivers/reset/Makefile | 1 + drivers/reset/reset-qcom

[PATCH v3 3/7] dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs

2018-03-14 Thread Sibi S
Include SDM845 APCS binding to the list of possible bindings Signed-off-by: Sibi S --- Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation

[PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845

2018-03-14 Thread Sibi S
functions to handle SoC specific reset sequences Signed-off-by: Sibi S --- drivers/remoteproc/qcom_q6v5_pil.c | 100 ++--- 1 file changed, 94 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 92bf125

[PATCH v3 6/7] remoteproc: qcom: Add support for mss remoteproc on SDM845

2018-03-14 Thread Sibi S
>From SDM845, the Q6SS reset sequence on software side has been simplified with the introduction of boot FSM which assists in bringing the Q6 out of reset Add GLINK subdevice to allow definition of GLINK edge as a child of modem-pil Signed-off-by: Sibi S --- drivers/remoteproc/qcom_q6v5_pi

[PATCH v3 5/7] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845

2018-03-14 Thread Sibi S
Add new compatible string for Qualcomm SDM845 SoCs Signed-off-by: Sibi S --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc

[PATCH v3 4/7] mailbox: Add support for Qualcomm SDM845 SoCs

2018-03-14 Thread Sibi S
Add the corresponding APCS offset for SDM845 SoC Signed-off-by: Sibi S --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 57bde0d..62d704d 100644 --- a/drivers

[PATCH v3 1/7] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

2018-03-14 Thread Sibi S
Add SDM845 AOSS (always on subsystem) reset controller binding Signed-off-by: Sibi S --- .../devicetree/bindings/reset/qcom,aoss-reset.txt | 54 ++ include/dt-bindings/reset/qcom,sdm845-aoss.h | 17 +++ 2 files changed, 71 insertions(+) create mode 100644

[PATCH v3 0/7] Add support for remoteproc modem-pil on SDM845 SoCs

2018-03-14 Thread Sibi S
review suggestions and reworked re-ordering of the active clk and reset sequence in qcom_q6v5_pil Sibi S (7): dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs reset: qcom: AOSS (always on subsystem) reset controller dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs

Re: [PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

2018-03-12 Thread Sibi S
Hi Trilok, Thanks for the review. I will include it in the v3 patch series. On 03/10/2018 02:59 AM, Trilok Soni wrote: Sibi, One cosmetic comment below. On 3/9/2018 6:55 AM, Sibi S wrote: + +This binding describes a reset-controller found on AOSS (Always on SubSysem) +for Qualcomm SDM845

Re: [PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

2018-03-09 Thread Sibi S
Hi Rob, Thanks for the review, will add the changes in v3 of the patch series On 03/08/2018 03:05 AM, Rob Herring wrote: On Mon, Mar 05, 2018 at 03:23:28PM +0530, sibis wrote: Add reset controller driver for Qualcomm SDM845 SoC to control reset signals provided by AOSS for Modem, Venus ADSP, GP

Re: [PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

2018-03-04 Thread Sibi S
Hi Philipp, Thanks for the review. I will post out the v2 of the patch series. On 03/02/2018 04:00 PM, Philipp Zabel wrote: Hi sibis, thank you for the patch. I have a few questions and comments below. On Fri, 2018-03-02 at 14:53 +0530, sibis wrote: Add reset controller driver for Qualcomm S