Hi Bjorn,
Thanks for the review
On 04/26/2018 03:36 AM, Bjorn Andersson wrote:
On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote:
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 9be763da0664..bea985045759 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -21,6 +21,27 @@
reg = <0 0x80000000 0 0>;
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ memory@85fc0000 {
+ reg = <0 0x85fc0000 0 0x40000>;
The region 0x85fe0000 + 0x20000 seems to be command db, which should be
described on its own. So please reduce the size to 0x20000.
+ no-map;
+ };
+
+ smem_mem: smem-mem@86000000 {
smem_mem: memory@86000000 ?
Should I update kernel docs as well to say all nodes should
have memory has default name? Just followed what was done in
msm8916 and msm8996.
+ reg = <0x0 0x86000000 0x0 0x200000>;
+ no-map;
+ };
+
+ memory@86000000 {
memory@86200000
+ reg = <0 0x86200000 0 0x2d00000>;
+ no-map;
+ };
+ };
+
The rest looks good.
Regards,
Bjorn
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
