RE: [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-11-03 Thread Shubhrajyoti Datta
Hi Stephen, Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:52 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@driverdev.osuosl.org;

RE: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-09-23 Thread Shubhrajyoti Datta
Hi , Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:48 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@driverdev.osuosl.org; robh...

[PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-08-28 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v6: remove unnecessary typecast remove unnecessary locks use polled timeout drivers/clk/clk-xlnx

[PATCH v6 3/8] clk: clock-wizard: Fix kernel-doc warning

2020-08-28 Thread Shubhrajyoti Datta
Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v6 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

2020-08-28 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta --- v6

[PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-08-28 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[PATCH v6 7/8] clk: clock-wizard: Update the fixed factor divisors

2020-08-28 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v6 1/8] dt-bindings: add documentation of xilinx clocking wizard

2020-08-28 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock

[PATCH v6 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-08-28 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v6 8/8] staging: clocking-wizard: Delete the driver from the staging

2020-08-28 Thread Shubhrajyoti Datta
Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta Acked-by: Greg Kroah-Hartman --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v6 0/8] clk: clk-wizard: clock-wizard: Driver updates

2020-08-28 Thread Shubhrajyoti Datta
staging as suggested v4: Reorder the patches. Merge the CLK_IS_BASIC patch. Add the yaml form of binding document v5: Fix a mismerge v6: Fix the yaml warning use poll timedout [1] https://spinics.net/lists/linux-driver-devel/msg117326.html Shubhrajyoti Datta (8): dt-bindings: add documentation of

Re: [PATCH V2 3/3] MAINTAINERS: add fragment for xilinx GPIO drivers

2020-07-24 Thread Shubhrajyoti Datta
On Thu, Jul 23, 2020 at 7:37 PM Srinivas Neeli wrote: > > Added entry for xilinx GPIO drivers. > > Signed-off-by: Srinivas Neeli > --- Acked-by: : Shubhrajyoti Datta

[PATCH v5 5/8] clk: clock-wizard: Add support for fractional support

2020-06-26 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 190 +--- 1 file changed, 178

[PATCH v5 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

2020-06-26 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta

[PATCH v5 7/8] clk: clock-wizard: Update the fixed factor divisors

2020-06-26 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v5 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-06-26 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v5 3/8] clk: clock-wizard: Fix kernel-doc warning

2020-06-26 Thread Shubhrajyoti Datta
Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v5 8/8] staging: clocking-wizard: Delete the driver from the staging

2020-06-26 Thread Shubhrajyoti Datta
Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta Acked-by: Greg Kroah-Hartman --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v5 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-06-26 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[PATCH v4 0/8] clk: clockwizard: Driver updates

2020-06-26 Thread Shubhrajyoti Datta
form of binding document v5: Fix a mismerge Shubhrajyoti Datta (8): dt-bindings: add documentation of xilinx clocking wizard clk: clock-wizard: Add the clockwizard to clk directory clk: clock-wizard: Fix kernel-doc warning clk: clock-wizard: Add support for dynamic reconfiguration clk

[PATCH v5 1/8] dt-bindings: add documentation of xilinx clocking wizard

2020-06-26 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v4: change to yaml format .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 5/8] clk: clock-wizard: Add support for fractional support

2020-06-26 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 192 +--- 1 file changed, 179

[PATCH v4 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

2020-06-26 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta

[PATCH v4 3/8] clk: clock-wizard: Fix kernel-doc warning

2020-06-26 Thread Shubhrajyoti Datta
Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v4 1/8] dt-bindings: add documentation of xilinx clocking wizard

2020-06-26 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v4: Move to yaml format .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock

[PATCH v4 7/8] clk: clock-wizard: Update the fixed factor divisors

2020-06-26 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v4 0/8] clk: clockwizard: Driver updates

2020-06-26 Thread Shubhrajyoti Datta
form of binding document Shubhrajyoti Datta (8): dt-bindings: add documentation of xilinx clocking wizard clk: clock-wizard: Add the clockwizard to clk directory clk: clock-wizard: Fix kernel-doc warning clk: clock-wizard: Add support for dynamic reconfiguration clk: clock-wizard: Add

[PATCH v4 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-06-26 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v4 8/8] staging: clocking-wizard: Delete the driver from the staging

2020-06-26 Thread Shubhrajyoti Datta
Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig| 10 - drivers/staging

[PATCH v4 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-06-26 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++ 1 file changed, 24 insertions(+) create mode

[RFC PATCHv2 3/3] Documentation: short descriptions for Flexnoc Performance Monitor driver

2019-09-25 Thread Shubhrajyoti Datta
Add short documentation for FlexNoc Performance Monitor driver. Signed-off-by: Shubhrajyoti Datta --- v2: patch added Documentation/misc-devices/xilinx_flex.txt | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/misc-devices/xilinx_flex.txt

[RFC PATCHv2 2/3] misc: xilinx_flex: Add support for the flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add support for the FlexNoc Performance Monitor. Adds support for various port setting and monitoring the packets transactions. It supports LPD and FPD monitoring counters for read and write transaction requests and responses. Signed-off-by: Shubhrajyoti Datta --- v2: Add a mutex to prevent race

[RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add support for the FlexNoc Performance Monitor. Adds support for various port setting and monitoring the packets transactions. It supports LPD and FPD monitoring counters for read and write transaction requests and responses. Signed-off-by: Shubhrajyoti Datta --- drivers/misc/Kconfig

[RFC PATCH 1/2] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++ 1 file changed, 24 insertions(+) create mode

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-16 Thread Shubhrajyoti Datta
ep_hardirqs_off+0xb5/0x100 > ? mark_held_locks+0x1a/0x90 > ? do_syscall_64+0x14/0x2a0 > do_syscall_64+0x72/0x2a0 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > This patch fix this by moving uart_unregister_driver > to ulite_remove. > Reviewed-by: Shubhrajyoti Dat

Re: Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

2019-02-17 Thread Shubhrajyoti Datta
On Mon, Feb 18, 2019 at 12:48 PM sxau...@163.com wrote: > > Hi , Shubhrajyoti > > >Hi , > >On Sat, Feb 16, 2019 at 1:21 PM sxau...@163.com wrote: > >> > >> >Hi Sxauwsk, > >> > > >> >On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote:

Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

2019-02-17 Thread Shubhrajyoti Datta
Hi , On Sat, Feb 16, 2019 at 1:21 PM sxau...@163.com wrote: > > >Hi Sxauwsk, > > > >On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote: > >> > >> When the adapter receive error interrupts, such as NACK, arbitration lost, > >> cdns_i2c_master_xfer return to the caller directly instead of resuming > >>

Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

2019-02-15 Thread Shubhrajyoti Datta
Hi Sxauwsk, On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote: > > When the adapter receive error interrupts, such as NACK, arbitration lost, > cdns_i2c_master_xfer return to the caller directly instead of resuming > the adapter which resulted in the adapter being out of control. > > So when driver d

Re: [PATCH] gpio: zynq: properly support runtime PM for GPIO used as interrupts

2019-02-11 Thread Shubhrajyoti Datta
rly > incremented/decremented. Since we override the default hooks, we keep > the existing behavior by making sure they call gpiochip_reqres_irq() / > gpiochip_relres_irq() respectively. > > Signed-off-by: Thomas Petazzoni > --- Reviewed-by: Shubhrajyoti Datta >

Re: [PATCH 2/8] gpio: zynq: Wakeup gpio controller when it is used as IRQ controller

2019-01-20 Thread Shubhrajyoti Datta
On Fri, Jan 11, 2019 at 8:26 PM Linus Walleij wrote: > > On Fri, Jan 11, 2019 at 1:54 PM Thomas Petazzoni > wrote: > > On Fri, 11 Jan 2019 10:54:20 +0100, Linus Walleij wrote: > > > > > My stance is that the driver is responsible of enabling and managing > > > runtime PM for its hardware block(s)

Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

2018-09-06 Thread Shubhrajyoti Datta
Hi, On Tue, Sep 4, 2018 at 9:41 PM Wolfram Sang wrote: > > On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.da...@gmail.com wrote: > > From: Shubhrajyoti Datta > > > > Disable interrupts while configuring the transfer and enable them back. > > > > We ha

Re: [PATCH v3 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

2018-01-29 Thread Shubhrajyoti Datta
Hi, Thanks for the patch. A few questions below. On Thu, Jan 25, 2018 at 4:51 AM, Jolly Shah wrote: > This patch is adding communication layer with firmware. > Firmware driver provides an interface to firmware APIs. > Interface APIs can be used by any driver to communicate to > PMUFW(Platform M

[PATCHv2] tty: xilinx_uartps: move to arch_initcall for earlier console

2017-09-19 Thread Shubhrajyoti Datta
move to arch_initcall to get the console up really early, it is quite helpful for spotting early boot problems. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b

Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

2017-09-06 Thread Shubhrajyoti Datta
... >> >> I *guess* it is to get the console up really early, simply becaus it is >> quite helpful for spotting early boot problems. > > > ok. It means no concern about the move to arch_initcall. > Shubhrajyoti: Please send v2 with changelog. Will do thanks for the review. > > Thanks, > Michal

[PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

2017-08-23 Thread Shubhrajyoti Datta
Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index ff1b115..a239343 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b

Re: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

2016-12-16 Thread Shubhrajyoti Datta
On Sat, Dec 17, 2016 at 3:24 AM, Alexey Khoroshilov wrote: > Dear Shubhrajyoti, > > Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") > it is not clear why clk_prepare_enable(i2c->clk) is required in > xiic_i2c_remove()? 834 ret = clk_p

Re: Re: Reset implementation for Zynq

2016-11-08 Thread Shubhrajyoti Datta
Hi Iztok, On Tue, Nov 8, 2016 at 3:10 PM, wrote: > Hi Shubhrajyoti, > > By lockup state, I mean an undefined/unhandled state of the HW logic state > machine, > or something similar in the software driver. > Based on symptoms I assume it is a HW lockup. > In practice as

Re: Reset implementation for Zynq

2016-11-07 Thread Shubhrajyoti Datta
On Fri, Oct 21, 2016 at 10:34 PM, Moritz Fischer wrote: > Iztok, > > On Fri, Oct 21, 2016 at 03:08:47AM -0700, iztok.je...@redpitaya.com wrote: >> Hi Moritz, >> >> I was looking at your reset implementation for Zynq: >> https://github.com/Xilinx/linux-xlnx/blob/629041605b93343ad2e8971ceaac3edcef0b

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

2016-09-21 Thread Shubhrajyoti Datta
On Tue, Sep 20, 2016 at 2:02 PM, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs Is there any such pins for zynqmp? > > Signed-off-by: Nava kishore Manne > --- > drivers/gpio/gpio-z

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

2016-06-03 Thread Shubhrajyoti Datta
On Tue, May 31, 2016 at 10:45 AM, Nava kishore Manne wrote: > Hi Shubhrajyoti, > > > Thanks for the review... > >> > /** >> > + * xudc_write64 - write 64bit value to device registers >> > + * @ep: pointer to the usb device endpoint st

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

2016-05-30 Thread Shubhrajyoti Datta
On Mon, May 30, 2016 at 10:16 PM, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > --- > Changes for v4: > -Used boolen property insted of addrwith property in the DT > as suggested

Re: [PATCH v9 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-05-29 Thread Shubhrajyoti Datta
> + */ > +static void zynqmp_dma_update_desc_to_ctrlr(struct zynqmp_dma_chan *chan, > + struct zynqmp_dma_desc_sw *desc) > +{ > + dma_addr_t addr; > + > + addr = desc->src_p; > + writel(addr, chan->regs + ZYNQMP_DMA_SRC_START_LSB); > + wri

[PATCH] spi: zynqmp: disable clocks in error paths

2016-05-04 Thread Shubhrajyoti Datta
The if pclk enable fails the refclk is not disabled. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-zynqmp-gqspi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index aab9b49

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

2016-04-20 Thread Shubhrajyoti Datta
On Wed, Apr 20, 2016 at 5:13 PM, Kedareswara rao Appana wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana Reviewed-by: Shubhrajyoti Datta

Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma

2016-04-20 Thread Shubhrajyoti Datta
On Wed, Apr 20, 2016 at 12:49 PM, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [PATCH] spi: cadence: mark pm functions __maybe_unused

2016-04-17 Thread Shubhrajyoti Datta
anks for the patch. Feel free to add my ack. Acked-by: Shubhrajyoti Datta > > Signed-off-by: Arnd Bergmann > Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") > ---

[PATCH] spi: cadence: Fix some checkpatch warnings

2016-04-06 Thread Shubhrajyoti Datta
, + struct spi_transfer *transfer) CHECK: Please use a blank line after function/struct/union/enum declarations +} +static int cdns_prepare_message(struct spi_master *master, Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |6 -- 1 files changed, 4

[PATCH 6/7] spi: cadence: Remove the clock enable and disable from suspend and resume

2016-04-05 Thread Shubhrajyoti Datta
Now that the clocks are enabled and disabled per transaction , remove the clock enable and disable from resume and suspend hooks. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 4/7] spi: cadance: Fix the Documentation

2016-04-05 Thread Shubhrajyoti Datta
#x27; description in 'cdns_spi_chipselect' Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 2915b25..8a6fee9 100644 --- a/drivers/spi/spi-c

[PATCH 1/7] spi: cadence: Fix a check patch warning

2016-04-05 Thread Shubhrajyoti Datta
CHECK: Comparison to NULL could be written "!master" + if (master == NULL) Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 121a41

[PATCH 3/7] spi: cadence: Fix probe error handling

2016-04-05 Thread Shubhrajyoti Datta
The clock disabling is missed out in some error cases at probe. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 97a3bf6..2915b25

[PATCH 5/7] spi: cadence: Runtime pm adaptation

2016-04-05 Thread Shubhrajyoti Datta
Currently the clocks are enabled at probe and disabled at remove. This patch moves the clock enable to the start of transaction and disables at the end. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 70 +++- 1 files changed, 68

[PATCH 7/7] spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume

2016-04-05 Thread Shubhrajyoti Datta
Return the error code for cdns_spi_suspend and cdns_spi_resume. Also fixes a comment where which claims that the error code is returned. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi

[PATCH 2/7] spi: cadence: Remove _MASK and _OFFSET suffix

2016-04-05 Thread Shubhrajyoti Datta
Remove the _MASK and _OFFSET from the macros. It improves readability, removes some checkpatch error for exceeding 80 chars and also prevents some linebreaks. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 161 + 1 files changed

[PATCH] gpio: zynq: Fix the error path

2016-04-04 Thread Shubhrajyoti Datta
pm_runtime_disable is called only in remove it is missed out in the error path. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/gpio/gpio-zynq.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

2015-12-03 Thread Shubhrajyoti Datta
so we don't have >> to >> read it all the time to modify it. > > Makes sense. I have made an attempt at it can you check if you get any performance improvemets on your setup. http://www.spinics.net/lists/linux-spi/msg05963.html Thanks, Shubhrajyoti -- To unsubscribe

Re: [PATCH v2] i2c: cadence: Move to sensible power management

2015-11-23 Thread Shubhrajyoti Datta
On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann wrote: > On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote: >> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta >> wrote: >> > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann >> &

Re: [PATCH v2] i2c: cadence: Move to sensible power management

2015-11-21 Thread Shubhrajyoti Datta
On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta wrote: > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann > wrote: >> Hi Shubhrajyoti, >> >> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >>> Currently the clocks are enabled at probe

Re: [PATCH v2] i2c: cadence: Move to sensible power management

2015-10-29 Thread Shubhrajyoti Datta
On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann wrote: > Hi Shubhrajyoti, > > > On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >> Currently the clocks are enabled at probe and disabled at remove. >> Which keeps the clocks enabled even if no transaction is

[PATCHv2] i2c: cadence: Enable power management

2015-10-28 Thread Shubhrajyoti Datta
ned-off-by: Shubhrajyoti Datta --- changes since v1: update the cc list. drivers/i2c/busses/i2c-cadence.c | 74 -- 1 files changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index f522

Re: [PATCHv2] i2c: cadence: Enable power management

2015-10-28 Thread Shubhrajyoti Datta
On Wed, Oct 28, 2015 at 11:34 AM, Shubhrajyoti Datta wrote: > Currently the clocks are enabled at probe and disabled at remove. > This patch enables the clocks at the start of transfer and disables > after it. > > Also adapts to runtime pm. > Remove xi2c->suspended and

[PATCH v2] i2c: cadence: Move to sensible power management

2015-10-28 Thread Shubhrajyoti Datta
ead. converts dev pm to const to silence a checkpatch warning. Signed-off-by: Shubhrajyoti Datta --- changes since v2 update the cc list drivers/i2c/busses/i2c-cadence.c | 73 -- 1 files changed, 46 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/bus

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

2015-10-12 Thread Shubhrajyoti Datta
On Thu, Oct 8, 2015 at 8:40 PM, Jean-Francois Dagenais wrote: > >> On Jun 4, 2013, at 1:32 PM, Mark Brown wrote: >> >> Applied but this is a bit sad, having to defer the refill to process >> context means that we're adding extra latency which takes us further >> away from being able to saturate t

Re: [[PATCH v2] 2/2] Altera Modular ADC driver support

2015-09-04 Thread Shubhrajyoti Datta
> +static int alt_modular_adc_probe(struct platform_device *pdev) > +{ > + struct altera_adc *adc; > + struct device_node *np = pdev->dev.of_node; > + struct iio_dev *indio_dev; > + struct resource *mem; > + int ret; > + > + if (!np) > + return -ENO

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-06 Thread Shubhrajyoti Datta
On Tue, Aug 4, 2015 at 1:35 PM, Lars-Peter Clausen wrote: > > Well there is no need to use a threaded IRQ. The interrupt handler is quite > small and doesn't take too much time and doesn't have any delays or sleeps > in it either. > > Ok thanks for the explanation. -- To unsubscribe from this list

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-05 Thread Shubhrajyoti Datta
hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath wrote: > From: Yi Zhang > > Enable i2c module/unit before transmission and disable when it > finishes. > > why? > It's because the i2c bus may be disturbed if the slave device, > typically a touch, powers on. Why should that be an issue? Is

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

2015-08-03 Thread Shubhrajyoti Datta
On Fri, Jul 24, 2015 at 6:08 PM, Lars-Peter Clausen wrote: > Hi, > > Sorry, but I don't think this patch has been sufficiently tested against a > mainline kernel. The driver wont even probe the way it is right now. > > On 07/21/2015 01:14 AM, Xander Huff wrote: >> >> The driver currently registers

Re: [PATCH v2] ARM64: zynqmp: Add eeprom memories on i2c bus

2015-07-29 Thread Shubhrajyoti Datta
On Wed, Jul 29, 2015 at 7:49 PM, Michal Simek wrote: > Add i2c eeprom memories on i2c bus. > Thanks for the patch. Feel free to add Reviewed-by: Shubhrajyoti Datta > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Change eeprom max freq from 100k to 400k > >

Re: [PATCH 7/7] ARM64: zynqmp: Add eeprom memories on i2c bus

2015-07-27 Thread Shubhrajyoti Datta
Hi, On Mon, Jul 27, 2015 at 3:18 PM, Michal Simek wrote: > Add i2c eeprom memories on i2c bus. > > Signed-off-by: Michal Simek > --- > > arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep1

Re: [PATCH] mtd: spi-nor: Only set Micron quad-read mode when controller in 4-lane TX mode

2015-06-30 Thread Shubhrajyoti Datta
On Tue, Jun 30, 2015 at 4:47 PM, Mike Looijmans wrote: > Micron QUAD mode expects command, address and data on 4 lanes instead of just > one for command (extended SPI mode). This requires the controller to be in a > special mode, so check first if the controller could be in that mode. If a > contr

Re: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support

2015-06-15 Thread Shubhrajyoti Datta
On Mon, Jun 15, 2015 at 8:06 PM, Punnaiah Choudary Kalluri wrote: > Added the basic driver for zynqmp dma engine used in Zynq > UltraScale+ MPSoC. The initial release of this driver supports > only memory to memory transfers. > > Signed-off-by: Punnaiah Choudary Kalluri > --- > +/** > + * zynqm

Re: [LINUX RFC V2 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller

2015-06-06 Thread Shubhrajyoti Datta
hi, Some minor comments. On Fri, Jun 5, 2015 at 6:37 PM, Ranjit Waghmode wrote: > This patch adds support for GQSPI controller driver used by > Zynq Ultrascale+ MPSoC > > Signed-off-by: Ranjit Waghmode > --- > Here is the v2 series. > + */ > +static void zynqmp_qspi_chipselect(struct spi_devi

Re: [PATCH 1/3] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

2015-05-21 Thread Shubhrajyoti Datta
Hi Moritz, Overall looks good some nitpicks below. On Fri, May 22, 2015 at 5:07 AM, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is single channel per core and allow

Re: [PATCH 02/12] net: axienet: Handle 0 packet receive gracefully

2015-05-05 Thread Shubhrajyoti Datta
On Tue, May 5, 2015 at 2:55 PM, Michal Simek wrote: > From: Peter Crosthwaite > > The AXI-DMA rx-delay interrupt can sometimes be triggered > when there are 0 outstanding packets received. This is due > to the fact that the receive function will greedily consume > as many packets as possible on i

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Shubhrajyoti Datta
On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan wrote: > If timeout error occurs in the i2c transfer then it was dumping warning > of call stack. > > Remove the warning dump as there is may be possibility that some slave > devices are busy and not responding the i2c communication. > > Signed-off-

Re: [PATCH V3 2/3] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2013-01-20 Thread Shubhrajyoti Datta
On 1/17/13, Amit Daniel Kachhap wrote: > Below fixes are done to support falling threshold interrupt, > * Falling interrupt status macro corrected according to exynos5 data sheet. > * The get trend function modified to calculate trip temperature correctly. > * The clearing of interrupt status in t

Re: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

2012-11-26 Thread Shubhrajyoti Datta
On Thu, Nov 22, 2012 at 10:13 AM, Tushar Behera wrote: > It is not required to free devm_ allocated data. Since kref_put > needs a valid release function, da9052_wdt_release_resources() > is not deleted. > > Fixes following warning. > drivers/watchdog/da9052_wdt.c:59:1-6: WARNING: invalid free of

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

2012-11-22 Thread Shubhrajyoti Datta
On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera wrote: > This patchset cleans up the probe function of i2c-s3c2410 driver. > These have been tested on Exynos4210 based Origen board. > > Tushar Behera (7): > i2c: s3c2410: Remove unnecessary label err_noclk > i2c: s3c2410: Convert to use devm_cl

[PATCH] spi: omap2-mcspi: Fix the redifine warning

2012-11-18 Thread Shubhrajyoti D
Fix the below warning drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier one drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here So delete the u8 tx as it is assigned and not used(resigned afterwards). Signed-off-by: Shubhrajyoti D --- drive

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait f

[PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti D
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Reported-and-tested-by: Sørensen, Stefan Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 39

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait f

[PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti D
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Reported-and-tested-by: Sørensen, Stefan Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 39

Re: [PATCH] i2c: omap: adopt pinctrl support

2012-10-17 Thread Shubhrajyoti Datta
c.15: Driver omap_i2c requests probe deferral > [0.484466] Advanced Linux Sound Architecture Driver Initialized. > > [4.746917] omap_i2c i2c.15: bus 4 rev2.4.0 at 100 kHz > [4.755279] gpiochip_find_base: found new base at 477 > [4.761169] gpiochip_add: registered GPIOs 477 to 500 on d

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-11 Thread Shubhrajyoti Datta
On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones wrote: > From: Jonas Aaberg Some change logs would have helped. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Acked-by: Lee Jones > Signed-off-by: Jonas Aaberg > Signed-off-by: Philippe Langlais > Reviewed-by: Bengt Jonsson > --- > d

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Shubhrajyoti Datta
On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires wrote: > Hi, > > thanks also for the review. Two in the same day! I was about to send a > ping on that patch ;-) > > On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta > wrote: >> On Fri, Sep 14, 2012 at 7:11 PM, b

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-02 Thread Shubhrajyoti Datta
On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires wrote: > From: Benjamin Tissoires > > Microsoft published the protocol specification of HID over i2c: > http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx > > This patch introduces an implementation of this protocol. > > This

Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-10-01 Thread Shubhrajyoti
On Monday 01 October 2012 04:31 PM, Sourav Poddar wrote: > +smsc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct smsc *smsc = dev_get_drvdata(pdev->dev.parent); > + struct input_dev *input; > + struct smsc_keypad *kp; > + int ret = 0, err

Re: [PATCH v4 5/5] MFD: ti_tscadc: add suspend/resume functionality

2012-09-25 Thread Shubhrajyoti
On Wednesday 26 September 2012 10:50 AM, Patil, Rachna wrote: > This patch adds support for suspend/resume of > TSC/ADC MFDevice. this should be merged with the patch adding support else we may end up in a case where patch a does the runtime calls and the call back handlers added later. > > Signed

  1   2   3   >