Re: [PATCH V2 1/3] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-10-21 Thread Sheetal Tigadoli
Hi Jakub, Thanks for your comments. On Fri, Oct 18, 2019 at 12:46 AM Jakub Kicinski wrote: > > On Thu, 17 Oct 2019 17:31:20 +0530, Sheetal Tigadoli wrote: > > From: Vikas Gupta > > > > This driver registers on TEE bus to interact with OP-TEE based > > BN

[PATCH V2 3/3] bnxt_en: Add support to collect crash dump via ethtool

2019-10-17 Thread Sheetal Tigadoli
ash dump Command to collect the dump after setting the flag: $ ethtool -w eth0 data Filename Cc: Michael Chan Signed-off-by: Vasundhara Volam Signed-off-by: Sheetal Tigadoli --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++ drivers/net/ethernet/broadcom/bnxt

[PATCH V2 2/3] bnxt_en: Add support to invoke OP-TEE API to reset firmware

2019-10-17 Thread Sheetal Tigadoli
From: Vasundhara Volam In error recovery process when firmware indicates that it is completely down, initiate a firmware reset by calling OP-TEE API. Cc: Michael Chan Signed-off-by: Vasundhara Volam Signed-off-by: Sheetal Tigadoli --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13

[PATCH V2 1/3] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-10-17 Thread Sheetal Tigadoli
From: Vikas Gupta This driver registers on TEE bus to interact with OP-TEE based BNXT firmware management modules Signed-off-by: Vikas Gupta Signed-off-by: Sheetal Tigadoli --- drivers/firmware/broadcom/Kconfig | 8 + drivers/firmware/broadcom/Makefile| 1

[PATCH V2 0/3] Add OP-TEE based bnxt f/w manager

2019-10-17 Thread Sheetal Tigadoli
This patch series adds support for TEE based BNXT firmware management module and the driver changes to invoke OP-TEE APIs to fastboot firmware and to collect crash dump. Changes from v1: - address review comemnt from scott, - update error msg and introduce HANDLE_ERROR Macro - address review

[PATCH] devlink: add devlink notification for recovery

2019-09-18 Thread Sheetal Tigadoli
From: Vikas Gupta Add a devlink notification for reporter recovery Signed-off-by: Vikas Gupta Signed-off-by: Sheetal Tigadoli --- net/core/devlink.c | 25 + 1 file changed, 25 insertions(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index e48680e..42909fb

Re: [PATCH] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-09-11 Thread Sheetal Tigadoli
Hi Scott, Thanks for reviewing and your comments On Tue, Sep 10, 2019 at 9:34 PM Scott Branden wrote: > > Hi Sheetal, > > Some comments inline. > > On 2019-09-10 8:17 a.m., Sheetal Tigadoli wrote: > > From: Vikas Gupta > > > > This driver registers on T

Re: [PATCH] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-09-11 Thread Sheetal Tigadoli
Thanks for the review and comments. On Tue, Sep 10, 2019 at 10:46 PM Greg Kroah-Hartman wrote: > > On Tue, Sep 10, 2019 at 08:47:04PM +0530, Sheetal Tigadoli wrote: > > From: Vikas Gupta > > > > This driver registers on TEE bus to interact with OP-TEE based > > BN

[PATCH] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-09-10 Thread Sheetal Tigadoli
From: Vikas Gupta This driver registers on TEE bus to interact with OP-TEE based BNXT firmware management modules Signed-off-by: Vikas Gupta Signed-off-by: Sheetal Tigadoli --- drivers/firmware/broadcom/Kconfig | 8 + drivers/firmware/broadcom/Makefile| 1

[PATCH V2 0/4] Add support for PWM Configure and stablize for PWM kona

2019-01-16 Thread Sheetal Tigadoli
comments Praveen Kumar B (3): dt-bindings: pwm: kona: Add new compatible for new version pwm-cygnus drivers: pwm: pwm-bcm-kona: Add cygnus-pwm support ARM: dts: cygnus: Change pwm compatible to new version Sheetal Tigadoli (1): drivers: pwm: pwm-bcm-kona: Switch to using atomic PWM Framework

[PATCH V2 3/4] drivers: pwm: pwm-bcm-kona: Add cygnus-pwm support

2019-01-16 Thread Sheetal Tigadoli
From: Praveen Kumar B Add support for new version of pwm-cygnus. Add support to make PWM changes configured and stable. Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- drivers/pwm/pwm-bcm-kona.c | 95

[PATCH V2 1/4] dt-bindings: pwm: kona: Add new compatible for new version pwm-cygnus

2019-01-16 Thread Sheetal Tigadoli
From: Praveen Kumar B Add new compatible string for new version pwm-cygnus Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V2 2/4] drivers: pwm: pwm-bcm-kona: Switch to using atomic PWM Framework

2019-01-16 Thread Sheetal Tigadoli
Switch to using atomic PWM Framework on broadcom PWM kona driver Signed-off-by: Sheetal Tigadoli --- drivers/pwm/pwm-bcm-kona.c | 201 +++-- 1 file changed, 83 insertions(+), 118 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm

[PATCH V2 4/4] ARM: dts: cygnus: Change pwm compatible to new version

2019-01-16 Thread Sheetal Tigadoli
From: Praveen Kumar B Change pwm compatible to new version pwm-cygnus Add new compatible to check pwm configure status Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- arch/arm/boot/dts/bcm-cygnus.dtsi | 2 +- 1 file changed

[PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers

2019-01-16 Thread Sheetal Tigadoli
update macros to remove braces around numbers Signed-off-by: Sheetal Tigadoli --- drivers/pwm/pwm-bcm-kona.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 09a95ae..81da91d 100644 --- a/drivers

[PATCH 3/3] ARM: dts: cygnus: Change pwm compatible to new version

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Change pwm compatible to new version of pwm-kona Add new compatible to check pwm configure status Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- arch/arm/boot/dts/bcm-cygnus.dtsi | 2 +- 1 file

[PATCH 2/3] drivers: pwm: pwm-bcm-kona: Add pwm-kona-v2 support

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Add support for new version of pwm-kona. Add support to make PWM changes configured and stable. Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- drivers/pwm/pwm-bcm-kona.c | 128

[PATCH 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Add new compatible string for new version of pwm-kona Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/3] Add support for PWM Configure and stablize for PWM kona

2019-01-10 Thread Sheetal Tigadoli
Hi, This patchset contain support to make PWM changes configure and stablize Following are brief changes done a. Add support for version2 compatible string b. Change PWM config and stablize delay in PWM Kona Praveen Kumar B (3): dt-bindings: pwm: kona: Add

[PATCH INTERNAL V3 2/3] drivers: pwm: pwm-bcm-kona: Add pwm-kona-v2 support

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Add support for new version of pwm-kona. Add support to make PWM changes configured and stable. Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- drivers/pwm/pwm-bcm-kona.c | 128

[PATCH INTERNAL V3 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Add new compatible string for new version of pwm-kona Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- Documentation/devicetree/bindings/pwm/brcm,kona-pwm.txt | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH INTERNAL V3 3/3] ARM: dts: cygnus: Change pwm compatible to new version

2019-01-10 Thread Sheetal Tigadoli
From: Praveen Kumar B Change pwm compatible to new version of pwm-kona Add new compatible to check pwm configure status Signed-off-by: Praveen Kumar B Reviewed-by: Ray Jui Reviewed-by: Scott Branden Signed-off-by: Sheetal Tigadoli --- arch/arm/boot/dts/bcm-cygnus.dtsi | 2 +- 1 file

[PATCH INTERNAL V3 0/3] Add support for PWM Configure and stablize for PWM kona

2019-01-10 Thread Sheetal Tigadoli
Hi, This patchset contain support to make PWM changes configure and stablize Following are brief changes done a. Add support for version2 compatible string b. Change PWM config and stablize delay in PWM Kona Praveen Kumar B (3): dt-bindings: pwm: kona: Add

[PATCH 4/5] drivers: mmc: card: Fixed ERROR that open brace should be on the previous line

2015-02-01 Thread Sheetal Tigadoli
The Patch fixes the below coding style error found using checkpatch.pl script drivers/mmc/card/block.c:2362: ERROR: that open brace { should be on the previous line Signed-off-by: Sheetal Tigadoli --- drivers/mmc/card/block.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH 3/5] drivers: mmc: card: Fixes WARNING braces are not necessary for single statement

2015-02-01 Thread Sheetal Tigadoli
Patch fixes following coding style warnings. drivers/mmc/card/block.c:1734: WARNING: braces {} are not necessary for single statement blocks drivers/mmc/card/block.c:2019: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Sheetal

[PATCH 5/5] drivers: mmc: card: Fixed warning line over 80 characters in file block

2015-02-01 Thread Sheetal Tigadoli
/card/block.c:1209: WARNING: line over 80 characters drivers/mmc/card/block.c:2226: WARNING: line over 80 characters Signed-off-by: Sheetal Tigadoli --- drivers/mmc/card/block.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/card

[PATCH 2/5] drivers: mmc: card: Fixes Missing blank line after variable initialization, coding style warning

2015-02-01 Thread Sheetal Tigadoli
clarations drivers/mmc/card/block.c:620: WARNING: Missing a blank line after declarations drivers/mmc/card/block.c:1720: WARNING: Missing a blank line after declarations Signed-off-by: Sheetal Tigadoli --- drivers/mmc/card/block.c |3 +++ 1 file changed, 3 insertions(+) di

[PATCH 1/5] drivers: mmc: card: Fix replaces simple_strtoul func call with kstrtoul

2015-02-01 Thread Sheetal Tigadoli
This patch fixes following coding style warning in file block.c drivers/mmc/card/block.c:279: WARNING: simple_strtoul is obsolete, use kstrtoul instead Signed-off-by: Sheetal Tigadoli --- drivers/mmc/card/block.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 0/5] drivers; mmc: card:

2015-02-01 Thread Sheetal Tigadoli
The patches, fix some coding style err/warnings from file block.c ./scripts/checkpatch.pl --file --terse drivers/mmc/card/block.c drivers/mmc/card/block.c:45: WARNING: Use #include instead of drivers/mmc/card/block.c:102: WARNING: line over 80 characters drivers/mmc/card/block.c:186: WARNING:

[PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c

2015-01-31 Thread Sheetal Tigadoli
/block.c:2362: ERROR: that open brace { should be on the previous line total: 1 errors, 18 warnings, 2587 lines checked Signed-off-by: Sheetal Tigadoli --- drivers/mmc/card/block.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/mmc

[PATCH] staging: comedi: Fixes Coding Style Warning in file das08.h

2014-05-08 Thread Sheetal Tigadoli
: Sheetal Tigadoli --- drivers/staging/comedi/drivers/das08.h |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das08.h b/drivers/staging/comedi/drivers/das08.h index 46a314c..18cc170 100644 --- a/drivers/staging/comedi/drivers/das08.h +++ b

[PATCH] Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h

2014-05-06 Thread Sheetal Tigadoli
This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' & 'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h This patch is sent to complete one of Eudyptula Challenges Signed-off-by: Sheetal Tigado

[PATCH] Fixes Coding Style Warnings

2014-05-02 Thread Sheetal Tigadoli
Patch to fix Some Coding style warnings. Sending it to complete one of Eudyptula Challenges. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please re

[PATCH] Fixes Coding Style Warnings

2014-05-02 Thread Sheetal Tigadoli
From: Sheetal T Signed-off-by: Sheetal T --- drivers/staging/comedi/drivers/das08.h | 56 +--- 1 file changed, 30 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/das08.h b/drivers/staging/comedi/drivers/das08.h index 2a30d76..cc730ff 10