Re: [PATCH net-next v3 6/8] net: phy: mscc: timestamping and PHC support

2020-06-21 Thread Quentin Schulz
Hi Antoine, On 2020-06-19 14:22, Antoine Tenart wrote: [...] @@ -999,9 +1553,35 @@ int vsc8584_ptp_probe(struct phy_device *phydev) if (!vsc8531->ptp) return -ENOMEM; + mutex_init(&vsc8531->phc_lock); mutex_init(&vsc8531->ts_lock); + /* Retrieve the

Re: [PATCH net-next v3 5/8] net: phy: mscc: 1588 block initialization

2020-06-21 Thread Quentin Schulz
Hi Antoine, Feels weird to review my own patches a year later having written them, almost nostalgic :) The review is mostly nitpicks. On 2020-06-19 14:22, Antoine Tenart wrote: [...] @@ -373,6 +374,21 @@ struct vsc8531_private { unsigned long ingr_flows; unsigned long egr_flows

Re: [PATCH net-next v3 4/8] net: phy: mscc: take into account the 1588 block in MACsec init

2020-06-21 Thread Quentin Schulz
Hi Antoine, On 2020-06-19 14:22, Antoine Tenart wrote: This patch takes in account the use of the 1588 block in the MACsec initialization, as a conditional configuration has to be done (when the 1588 block is used). Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_macsec.c | 4 +++-

Re: [GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-14 Thread Quentin Schulz
Hi Josh, On Fri, Dec 14, 2018 at 07:57:37AM -0500, Josh Boyer wrote: > On Thu, Dec 6, 2018 at 5:34 AM Quentin Schulz > wrote: > > > > Hi all, > > > > Both VSC8574 and VSC8584 Ethernet PHYs require a firmware patch to be > > applied before making use of them

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-10 Thread Quentin Schulz
Hi Lee, On Mon, Dec 10, 2018 at 06:27:18AM +, Lee Jones wrote: > On Sat, 08 Dec 2018, Quentin Schulz wrote: > > > Hi Lee, > > > > On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > > > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > >

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-08 Thread Quentin Schulz
Hi Lee, On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > > On Fri, Dec 7, 2018 at 8:40 AM Lee Jones wrote: > > > > > My OCD-dar is going crazy. > > > > > > Why haven't you used the same alignment as is already there? > > > > > > If i

[GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-06 Thread Quentin Schulz
4 Ethernet PHYs (2018-12-06 11:02:51 +0100) -------- Quentin Schulz (1): microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs LICENCE.microchip| 40 +

Re: [PATCH v6 4/6] power: supply: core: Add some helpers to use the battery OCV capacity table

2018-11-01 Thread Quentin Schulz
Hi Baolin, On Thu, Nov 01, 2018 at 03:22:18PM +0800, Baolin Wang wrote: > Hi Quentin, > > On 29 October 2018 at 22:48, Quentin Schulz > wrote: [...] > > > >> + return len; > >> + } else if (len > POWER_SUPPLY_OCV_TEMP_MAX) { > >

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-29 Thread Quentin Schulz
Hi Jonathan, On Sun, Oct 28, 2018 at 03:40:11PM +, Jonathan Cameron wrote: > On Wed, 24 Oct 2018 08:56:33 -0500 > Rob Herring wrote: > > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > > The AXP803 ADC is compatible with AXP813 ADC, but add > > > specific compatible for it. >

Re: [PATCH v3 6/7] mfd: axp20x: Add AC power supply cell for AXP813

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:07PM +0300, Oskari Lemmela wrote: > As axp20x-ac-power-supply now supports AXP813, add a cell for it. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 4/7] arm64: dts: allwinner: a64: sopine: enable power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:05PM +0300, Oskari Lemmela wrote: > Sopine baseboard have ACIN and battery connectors. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 3/7] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:04PM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:02PM +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 2/7] ARM: dts: axp81x: add AC power supply subnode

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:03PM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
c: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-09 Thread Quentin Schulz
select/restore_page > functions") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-09 Thread Quentin Schulz
Hi Gustavo, On Tue, Oct 09, 2018 at 09:39:53PM +0200, Gustavo A. R. Silva wrote: > In case memory resources for *fw* were successfully allocated, > release them before return. > > Addresses-Coverity-ID: 1473968 ("Resource leak") > Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY"

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Quentin Schulz
Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: > Hi, > > On 27.09.2018 10:14, Maxime Ripard wrote: > > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > > > On 26-09-18 16:44, Frieder Schrempf wrote: > > > > Hi, > > > > > > > > On Fri, Feb 09, 2018 a

Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug

2018-10-09 Thread Quentin Schulz
size of SERDES_MAX > in the for loop. > > Quentin Schulz pointed out that SERDES_MAX is a valid value to > index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1 > in include/dt-bindings/phy/phy-ocelot-serdes.h. > > Then I changed the condition in the for loop f

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-10-09 Thread Quentin Schulz
for loop from > i <= SERDES_MAX to i < SERDES_MAX. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1

2018-10-09 Thread Quentin Schulz
ecause the size of > array ctrl->phys is SERDES_MAX. > > Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1. > > Notice that this is the first part of the solution to > the out-of-bounds bug mentioned above. Although this > change is not dependent on any

Re: [PATCH] phy: ocelot-serdes: fix out-of-bounds read

2018-10-08 Thread Quentin Schulz
Hi Gustavo, On Mon, Oct 08, 2018 at 08:06:49PM +0200, Gustavo A. R. Silva wrote: > Currently, there is an out-of-bounds read on array ctrl->phys, > once variable i reaches the maximum array size of SERDES_MAX > in the for loop. > > Fix this by changing the condition in the for loop from > i <= SE

[PATCH net-next v3 3/6] net: phy: mscc: Add EEE init sequence

2018-10-08 Thread Quentin Schulz
EEE in order to improve performance. Reviewed-by: Florian Fainelli Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy

[PATCH net-next v3 2/6] net: phy: mscc: add ethtool statistics counters

2018-10-08 Thread Quentin Schulz
iewed-by: Andrew Lunn Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 119 + 1 file changed, 119 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 52198be46c68..47fbab489287 100644

Re: [PATCH v2 6/6] power: supply: add AC power supply driver for AXP813

2018-10-08 Thread Quentin Schulz
power_supply_property psp, > + const union power_supply_propval *val) > +{ Argh, missed this one in the first version. Since you're introducing it with the AXP813 and it isn't used with the AXP20X, I'd name it axp813_ac_power_set_property. I'll let Maxime or Chen-Yu confirm though. With the modification in the header from the previous patch in this patch, Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH v2 5/6] mfd: axp20x: add support AXP803 AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:35AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. > Adding needed cells for AC and battery power supplies. > > AXP813 AC power supply cell added. > > Signed-off-by: Oskari Lemmela > --- > drivers/mfd/axp20x.c | 22 +

Re: [PATCH v2 3/6] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:33AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > > Signed-off-by: Oskari Lemmela > --- > arch/arm64/boot/dts/allwinner/axp803.dtsi | 31 +++ > 1 file chan

Re: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > > Signed-off-by: Oskari Lemmela > --- > arch/arm/boot/dts/axp81x.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/a

Re: [PATCH v2 0/6] AXP8x3 AC and battery power supply support

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:30AM +0300, Oskari Lemmela wrote: > AXP813 AC power supply support with input current and > voltage limiting support. > > AXP803 AC and battery power supply support. > Great to see a new developer taking interest in those PMICs :) I received the v2 patc

Re: [PATCH 4/4] power: supply: add AXP803/AXP813 AC and battery power supply support

2018-10-05 Thread Quentin Schulz
Hi Oskari, On Thu, Oct 04, 2018 at 10:34:10PM +0300, Oskari Lemmela wrote: > AXP803 PMIC is register compatible with AXP813. > > Added support for AXP803/AXP813 AC power supply. > AXP8x3 is capable to limit input current and minimum input voltage. > Both of these register values are writeable. >

Re: [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote: > > > struct vsc8531_private { > > int rate_magic; > > u16 supp_led_modes; > > @@ -181,6 +354,7 @@ struct vsc8531_private { > > struct vsc85xx_hw_stat *hw_stats; > > u64 *stats; > > int nstats; > > + bo

Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:02:21PM +0200, Andrew Lunn wrote: > On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > >

[PATCH net-next 4/5] net: phy: mscc: shorten `x != 0` condition to `x`

2018-09-14 Thread Quentin Schulz
`if (x != 0)` is basically a more verbose version of `if (x)` so let's use the latter so it's consistent throughout the whole driver. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) di

[PATCH net-next 5/5] net: phy: mscc: remove unneeded temporary variable

2018-09-14 Thread Quentin Schulz
Here, the rc variable is either used only for the condition right after the assignment or right before being used as the return value of the function it's being used in. So let's remove this unneeded temporary variable whenever possible. Signed-off-by: Quentin Schulz --- drivers/net/

[PATCH net-next v3 04/11] net: mscc: ocelot: move the HSIO header to include/soc

2018-09-14 Thread Quentin Schulz
Since HSIO address space can be used by different drivers (PLL, SerDes muxing, temperature sensor), let's move it somewhere it can be included by all drivers. Acked-by: Alexandre Belloni Signed-off-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 1 +- drivers/net/eth

Re: [PATCH net-next v2 1/7] net: phy: mscc: factorize code for LEDs mode

2018-09-04 Thread Quentin Schulz
Hi David, On Tue, Sep 04, 2018 at 10:48:27AM -0700, David Miller wrote: > From: Quentin Schulz > Date: Mon, 3 Sep 2018 10:48:47 +0200 > > > LEDs modes are set the same way, except they are offset by 4 times the > > index of the LED. > > > > Let's factori

[PATCH v2 10/11] phy: add driver for Microsemi Ocelot SerDes muxing

2018-09-03 Thread Quentin Schulz
The Microsemi Ocelot can mux SerDes lanes (aka macros) to different switch ports or even make it act as a PCIe interface. This adds support for the muxing of the SerDes. Signed-off-by: Quentin Schulz --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1

[PATCH v2 00/11] mscc: ocelot: add support for SerDes muxing configuration

2018-09-03 Thread Quentin Schulz
driver, - use a dev_dbg for the deferring of the probe in the SerDes driver, - use constants in the Device Tree to select the SerDes macro in use with a port, - adapt the SerDes driver to use those constants, - add a header file in include/dt-bindings for the constants, - fix space/tab i

[PATCH net-next v2 05/11] net: mscc: ocelot: simplify register access for PLL5 configuration

2018-09-03 Thread Quentin Schulz
ff-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 73 drivers/net/ethernet/mscc/ocelot_regs.c | 92 +++-- include/soc/mscc/ocelot_hsio.h | 74 3 files changed, 83 insertions(+), 156 deletions(-) diff --git a/driver

Re: [PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-08-06 Thread Quentin Schulz
Hi Linus, On Mon, Aug 06, 2018 at 01:06:23PM +0200, Linus Walleij wrote: > Hi Quentin, sorry for delays! > No worries :) > On Wed, Jul 25, 2018 at 2:27 PM Quentin Schulz > wrote: > > > This GPIO controller can serve as an interrupt controller as well on the > > G

[PATCH 1/2] MIPS: mscc: ocelot: add interrupt controller properties to GPIO controller

2018-07-25 Thread Quentin Schulz
The GPIO controller also serves as an interrupt controller for events on the GPIO it handles. An interrupt occurs whenever a GPIO line has changed. Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/boot/dts

[PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-07-25 Thread Quentin Schulz
only after the line gets hold in its default state, this is what's done with the fasteoi functions. Only IRQ_TYPE_EDGE_BOTH and IRQ_TYPE_LEVEL_HIGH are supported for now. Signed-off-by: Quentin Schulz --- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/pinctrl-ocelot.c

[PATCH] MIPS: mscc: ocelot: add MIIM1 bus

2018-07-25 Thread Quentin Schulz
ff-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi index 7096915f26e0..d7f0e3551500 100644 --- a/arch/mips/boot/dts/mscc/ocelot.dtsi +++ b/arch

[PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

2018-07-25 Thread Quentin Schulz
The length of memory address space for MIIM0 is from 0x7107009c to 0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in hexadecimal and not 0x36. Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot") Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/o

[PATCH v5 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v5 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
chard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c

[PATCH v5 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

[PATCH v4 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
: - fix a few typos, v2: - use volume flags instead of arguments on the kernel command line as suggested by Richard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/kapi.c

[PATCH v4 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
e UBI volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18

[PATCH v4 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

Re: [PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-07-01 Thread Quentin Schulz
> > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz: > > > > Now that we have the logic for skipping CRC check for static UBI volumes > > > > in the core, let's expose it to users. > > > > > > > > This makes use of a

[PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-06-28 Thread Quentin Schulz
e UBI volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3

[PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-06-28 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6

[PATCH v3 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-06-28 Thread Quentin Schulz
suggested by Richard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c

[PATCH v2 2/2] ubi: expose the volume CRC check skip flag

2018-06-27 Thread Quentin Schulz
e UBI volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3 files changed, 21 insertions(

[PATCH v2 0/2] add possibility to skip CRC check for static UBI volumes

2018-06-27 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Patches for mtd-utils will be available as well. Thanks, Quentin v2: - use volume flags instead of arguments on the kernel command line as suggested by Richard, Quentin

[PATCH v2 1/2] ubi: provide a way to skip CRC checks

2018-06-27 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-06-11 Thread Quentin Schulz
Hi Richard, On Fri, Apr 20, 2018 at 11:37:07AM +0200, Richard Weinberger wrote: > Quentin, > > Am Freitag, 20. April 2018, 10:52:41 CEST schrieb Quentin Schulz: > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume.

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-23 Thread Quentin Schulz
Hi Boris, On Fri, Apr 20, 2018 at 07:19:24PM +0200, Boris Brezillon wrote: > On Fri, 20 Apr 2018 10:52:41 +0200 > Quentin Schulz wrote: > > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume. > > That&#x

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-20 Thread Quentin Schulz
Hi Richard, On Fri, Apr 20, 2018 at 11:37:07AM +0200, Richard Weinberger wrote: > Quentin, > > Am Freitag, 20. April 2018, 10:52:41 CEST schrieb Quentin Schulz: > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume.

[PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-20 Thread Quentin Schulz
. I gained 3.2s on boot time of a SPEAr600-based board for a ~20MB UBI volume used as rootfs. Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/kapi.c | 70 +++- drivers/mtd/ubi/ubi.h | 6 - drivers/mtd/ubi/vtbl.c | 24 ++- 3 files c

[PATCH 1/2] ubi: move constants for ubi vol parsing from kernel param to ubi.h

2018-04-20 Thread Quentin Schulz
onstants to ubi.h so that they can be used to parse other parameters impacting UBI volumes. Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/block.c | 33 + drivers/mtd/ubi/ubi.h | 15 +++ 2 files changed, 24 insertions(+), 24 deletions(-) diff --g

Re: [PATCH v2 00/10] Add support for SAMA5D2 touchscreen

2018-04-10 Thread Quentin Schulz
Hi Jonathan and Eugen, On Fri, Mar 30, 2018 at 02:02:12PM +0100, Jonathan Cameron wrote: > On Tue, 27 Mar 2018 15:32:33 +0300 > Eugen Hristev wrote: > > > Hello, > > > > This patch series is a rework of my previous series named: > > [PATCH 00/14] iio: triggers: add consumer support > > > > In

[PATCH 2/2] clk: spear: fix WDT clock definition on SPEAr600

2018-04-06 Thread Quentin Schulz
There is no SPEAr600 device named "wdt". Instead, the description of the WDT (watchdog) was recently added to the Device Tree, and the device name is "fc88.wdt", so we should associate the WDT fixed rate clock to this device name. Signed-off-by: Quentin Schulz --

[PATCH 1/2] ARM: SPEAr600: add DT description of the watchdog

2018-04-06 Thread Quentin Schulz
The SPEAr600 has a built-in watchdog which already has a DT binding described in Documentation/devicetree/bindings/watchdog/sp805-wdt.txt. Let's add the description of the watchdog device in the SPEAr600 Device Tree. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/spear600.dts

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-03-23 Thread Quentin Schulz
Hi Uffe, On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote: > [...] > > >> > I'd like to know if any progress has been made on that problem (I may > >> > have missed patches). > >> > Had you had the time to look at the issue? > >> > >> I have looked at the issue, but not manage to cook

Re: [PATCH v5 3/6] power: supply: axp20x_battery: use data struct for variant specific code

2018-03-09 Thread Quentin Schulz
Hi Sebastian, On Fri, Mar 09, 2018 at 05:08:25PM +0100, Sebastian Reichel wrote: > Hi Quentin, > > On Wed, Feb 28, 2018 at 11:35:58AM +0100, Quentin Schulz wrote: > > We used to use IDs to select a function or a feature depending on the > > variant. It's easier to m

Re: [PATCH 4.14 000/110] 4.14.25-stable review

2018-03-09 Thread Quentin Schulz
Hi Kevin, On Thu, Mar 08, 2018 at 04:05:01PM -0800, Kevin Hilman wrote: > kernelci.org bot writes: > > > stable-rc/linux-4.14.y boot: 148 boots: 4 failed, 133 passed with 7 > > offline, 3 untried/unknown, 1 conflict (v4.14.24-111-g66060ac1dfa0) > > > > Full Boot Summary: > > https://kernelci.o

[PATCH 3/3] ARM: dts: sun8i: a83t: add stable OPP tables and CPUfreq

2018-02-28 Thread Quentin Schulz
on a per-board basis though. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a83t.dtsi | 118 +++- 1 file changed, 118 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 016d22f..05d5dd7 100644 --- a/arc

[PATCH 0/3] add CPUs OPPs to sun8i a83t

2018-02-28 Thread Quentin Schulz
shuts down). It seems[1] impossible to reach those frequencies with none or passive cooling, so better leave them out by default. It's still possible to add those OPPs on a per-board basis though. [1] http://linux-sunxi.org/User:Tkaiser#First_steps_with_Banana_Pi_M3 Thanks, Quentin Quentin

[PATCH 1/3] ARM: dts: sun8i: a83t: add cpu0 and cpu100 labels

2018-02-28 Thread Quentin Schulz
The Allwinner A83T is a SoC with two clusters of 4 A7, each cluster having its own regulator and clock. The regulators are board-specific, thus we need labels for cpu0 and cpu100 so that we can use references to these nodes from the board header file. Signed-off-by: Quentin Schulz --- arch/arm

[PATCH 2/3] ARM: dts: sun8i: a711: set regulator for each cluster of CPUs

2018-02-28 Thread Quentin Schulz
The Allwinner A83T is a SoC with two clusters of 4 A7 which have a different clock and regulator. Set the CPU regulator. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs

[PATCH v5 3/6] power: supply: axp20x_battery: use data struct for variant specific code

2018-02-28 Thread Quentin Schulz
use it. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 100 +-- 1 file changed, 66 insertions(+), 34 deletions(-) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 7

[PATCH v5 1/6] mfd: axp20x: make AXP209/22x cells probe their ADC via DT

2018-02-28 Thread Quentin Schulz
This makes AXP209 and AXP22x ADCs probe first via DT and then by fallback via platform. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b

[PATCH v5 0/6] add support for AXP813 ADC and battery power supply

2018-02-28 Thread Quentin Schulz
data structure instead of ID for variant specific code in battery driver, - add DT binding for ADC driver, - make mfd probe the ADC driver via DT as well so that its IIO channels can be consumed by other drivers via DT mapping, Thanks, Quentin Quentin Schulz (6): mfd: axp20x: make AXP20

[PATCH v5 6/6] mfd: axp20x: add battery power supply cell for AXP813

2018-02-28 Thread Quentin Schulz
As axp20x-battery-power-supply now supports AXP813, add a cell for it. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Reviewed-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index e5516aa

[PATCH v5 2/6] mfd: axp20x: probe axp20x_adc driver for AXP813

2018-02-28 Thread Quentin Schulz
This makes the axp20x_adc driver probe with platform device id "axp813-adc". Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b/d

[PATCH v5 4/6] dt-bindings: power: supply: axp20x: add AXP813 battery DT binding

2018-02-28 Thread Quentin Schulz
The AXP813 can have a battery as power supply, so let's add it to the list of compatibles. Signed-off-by: Quentin Schulz Reviewed-by: Rob Herring Acked-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 8 +++ 1 file changed, 4 insertions(

[PATCH v5 5/6] power: supply: axp20x_battery: add support for AXP813

2018-02-28 Thread Quentin Schulz
the PMIC is valid. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 42 - 1 file changed, 42 insertions(+) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 04a0d91

[PATCH v4 00/13] add support for AXP813 ADC and battery power supply

2018-02-19 Thread Quentin Schulz
f ID for variant specific code in battery driver, - add DT binding for ADC driver, - make mfd probe the ADC driver via DT as well so that its IIO channels can be consumed by other drivers via DT mapping, Thanks, Quentin Quentin Schulz (13): ARM: dtsi: axp209: add node for ADC ARM: dtsi: a

[PATCH v4 04/13] ARM: dtsi: axp81x: add node for ADC

2018-02-19 Thread Quentin Schulz
This adds a DT node for the ADC of the PMIC so that there can be consumers of its IIO channels declaring their consumptions via DT. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp81x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v4 07/13] dt-bindings: power: supply: axp20x: add AXP813 battery DT binding

2018-02-19 Thread Quentin Schulz
The AXP813 can have a battery as power supply, so let's add it to the list of compatibles. Signed-off-by: Quentin Schulz Reviewed-by: Rob Herring Acked-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 8 +++ 1 file changed, 4 insertions(

[PATCH v4 08/13] power: supply: axp20x_battery: add support for AXP813

2018-02-19 Thread Quentin Schulz
the PMIC is valid. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 42 - 1 file changed, 42 insertions(+) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 099e785

[PATCH v4 01/13] ARM: dtsi: axp209: add node for ADC

2018-02-19 Thread Quentin Schulz
This adds a DT node for the ADC of the PMIC so that there can be consumers of its IIO channels declaring their consumptions via DT. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp209.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v4 09/13] mfd: axp20x: add battery power supply cell for AXP813

2018-02-19 Thread Quentin Schulz
As axp20x-battery-power-supply now supports AXP813, add a cell for it. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Reviewed-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index e5516aa

[PATCH v4 10/13] ARM: dtsi: axp81x: add battery power supply subnode

2018-02-19 Thread Quentin Schulz
supply subnode for AXP81X PMIC. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp81x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi index 6b5e7bc..1b05c7f 100644 --- a/arch/arm/boot/dts

[PATCH v4 11/13] ARM: dtsi: sun8i: a711: enable battery power supply subnode

2018-02-19 Thread Quentin Schulz
The TBS A711 has an AXP813 PMIC and a soldered battery, thus, we enable the battery power supply subnode in its Device Tree. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot

[PATCH v4 13/13] iio: adc: axp20x_adc: remove !! in favor of ternary condition

2018-02-19 Thread Quentin Schulz
!!'s behaviour isn't that obvious and sparse complained about it, so let's replace it with a ternary condition. Signed-off-by: Quentin Schulz --- drivers/iio/adc/axp20x_adc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/axp20x_adc.

[PATCH v4 02/13] ARM: dtsi: axp22x: add node for ADC

2018-02-19 Thread Quentin Schulz
This adds a DT node for the ADC of the PMIC so that there can be consumers of its IIO channels declaring their consumptions via DT. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp22x.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v4 06/13] power: supply: axp20x_battery: use data struct for variant specific code

2018-02-19 Thread Quentin Schulz
use it. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 100 +-- 1 file changed, 66 insertions(+), 34 deletions(-) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 7

[PATCH v4 12/13] ARM: dtsi: axp81x: remove IP name from DT node name

2018-02-19 Thread Quentin Schulz
The DT node should be named after its functionality and not after the IP it's defining. Signed-off-by: Quentin Schulz Acked-by: Chen-Yu Tsai --- arch/arm/boot/dts/axp81x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boo

[PATCH v4 05/13] mfd: axp20x: probe axp20x_adc driver for AXP813

2018-02-19 Thread Quentin Schulz
This makes the axp20x_adc driver probe with platform device id "axp813-adc". Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b/d

[PATCH v4 03/13] mfd: axp20x: make AXP209/22x cells probe their ADC via DT

2018-02-19 Thread Quentin Schulz
This makes AXP209 and AXP22x ADCs probe first via DT and then by fallback via platform. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-02-09 Thread Quentin Schulz
Hi Ulf, On Thu, Feb 08, 2018 at 10:31:39PM +0100, Ulf Hansson wrote: > On 8 February 2018 at 15:59, Quentin Schulz > wrote: > > Hi Ulf, > > > > On Wed, Aug 30, 2017 at 03:43:49PM +0200, Ulf Hansson wrote: > >> On 30 August 2017 at 14:44, Hans de Goede wrote: &

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-02-08 Thread Quentin Schulz
Hi Ulf, On Wed, Aug 30, 2017 at 03:43:49PM +0200, Ulf Hansson wrote: > On 30 August 2017 at 14:44, Hans de Goede wrote: > > Hi, > > > > > > On 21-07-17 16:35, Quentin Schulz wrote: > >> > >> From: Hans de Goede > >> > >> Some sd

Re: [PATCH v2 09/16] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2018-01-31 Thread Quentin Schulz
Hi Philipp, On Mon, Jan 29, 2018 at 12:29:12AM +0100, Philipp Rossak wrote: > This patch adds support for the H3 ths sensor. > > The H3 supports interrupts. The interrupt is configured to update the > the sensor values every second. The calibration data is writen at the > begin of the init proces

Re: [PATCH v2 08/16] iio: adc: sun4i-gpadc-iio: rework: add interrupt support

2018-01-31 Thread Quentin Schulz
Hi Philipp, On Mon, Jan 29, 2018 at 12:29:11AM +0100, Philipp Rossak wrote: > This patch rewors the driver to support interrupts for the thermal part > of the sensor. > > This is only available for the newer sensor (currently H3 and A83T). > The interrupt will be trigerd on data available and tri

Re: [PATCH v2 06/16] iio: adc: sun4i-gpadc-iio: rework: support multiple sensors

2018-01-31 Thread Quentin Schulz
Hi Philipp, On Mon, Jan 29, 2018 at 12:29:09AM +0100, Philipp Rossak wrote: > For adding newer sensor some basic rework of the code is necessary. > > This patch reworks the driver to be able to handle more than one > thermal sensor. Newer SoC like the A80 have 4 thermal sensors. > Because of this

Re: [PATCH v2 04/16] iio: adc: sun4i-gpadc-iio: rework: sampling start/end code readout reg

2018-01-31 Thread Quentin Schulz
6 +65,9 @@ struct gpadc_data { > unsigned inttp_adc_select; > unsigned int(*adc_chan_select)(unsigned int chan); > unsigned intadc_chan_mask; > + unsigned inttemp_data; Does not really have anything to do with sample_start/end. I would have made a different commit for it. Otherwise, Reviewed-by: Quentin Schulz Quentin signature.asc Description: PGP signature

Re: [PATCH v2 01/16] dt-bindings: update the Allwinner GPADC device tree binding for H3 & A83T

2018-01-31 Thread Quentin Schulz
Hi Philipp, On Mon, Jan 29, 2018 at 12:29:04AM +0100, Philipp Rossak wrote: > Allwinner H3 features a thermal sensor like the one in A33, but has its > register re-arranged, the clock divider moved to CCU (originally the > clock divider is in ADC) and added a pair of bus clock and reset. > > Allw

  1   2   3   4   5   6   7   >