Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-19 Thread Beleswar Prasad Padhi
Hi Mathieu, On 19/05/25 20:07, Mathieu Poirier wrote: > On Sat, May 17, 2025 at 06:53:29PM +0530, Beleswar Prasad Padhi wrote: >> On 5/16/2025 9:15 PM, Mathieu Poirier wrote: >>> On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: >>>> The r

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-17 Thread Beleswar Prasad Padhi
On 5/16/2025 9:15 PM, Mathieu Poirier wrote: On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: The rproc_detach() function invokes __rproc_detach() before rproc_unprepare_device(). The __rproc_detach() function sets the rproc->state to "RPROC_DETACHED". However, the TI K3 M4 dri

Re: [PATCH v11 00/35] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers

2025-05-11 Thread Beleswar Prasad Padhi
Hi Mathieu, On 09/05/25 22:39, Mathieu Poirier wrote: > On Fri, Apr 25, 2025 at 04:11:00PM +0530, Beleswar Padhi wrote: >> This series refactors a lot of functions & callbacks from >> ti_k3_dsp_remoteproc.c, ti_k3_r5_remoteproc.c and ti_k3_m4_remoteproc.c >> drivers. This is a consolidated and fin

Re: [PATCH v11 12/35] remoteproc: k3: Refactor mailbox rx_callback functions into common driver

2025-05-08 Thread Beleswar Prasad Padhi
Hi Mathieu, On 08/05/25 21:16, Mathieu Poirier wrote: > On Fri, Apr 25, 2025 at 04:11:12PM +0530, Beleswar Padhi wrote: >> The mailbox .rx_callback implementations in TI K3 R5, DSP and M4 >> remoteproc drivers handle inbound mailbox messages in the same way. >> Introduce a common driver 'ti_k3_com

Re: [PATCH v10 00/33] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers

2025-04-23 Thread Beleswar Prasad Padhi
Hi Judith, On 24/04/25 02:36, Judith Mendez wrote: > Hi Beleswar, > > On 4/17/25 1:19 PM, Beleswar Padhi wrote: >> This series refactors a lot of functions & callbacks from >> ti_k3_dsp_remoteproc.c, ti_k3_r5_remoteproc.c and ti_k3_m4_remoteproc.c >> drivers. This is a consolidated and final serie

Re: [PATCH v10 15/33] remoteproc: k3: Refactor rproc_reset() implementation into common driver

2025-04-23 Thread Beleswar Prasad Padhi
On 22/04/25 19:51, Andrew Davis wrote: > On 4/22/25 12:53 AM, Beleswar Prasad Padhi wrote: >> Hi Andrew, >> >> On 21/04/25 20:12, Andrew Davis wrote: >>> On 4/17/25 1:19 PM, Beleswar Padhi wrote: >>>> The rproc_reset() implementations in TI K3 DSP and

Re: [PATCH v10 13/33] remoteproc: k3: Refactor .kick rproc ops into common driver

2025-04-21 Thread Beleswar Prasad Padhi
On 21/04/25 20:28, Andrew Davis wrote: > On 4/17/25 1:19 PM, Beleswar Padhi wrote: >> The .kick rproc ops implementations in TI K3 R5, DSP and M4 remoteproc >> drivers sends a mailbox message to the remote processor in the same >> way. Refactor the implementations into a common function >> 'k3_rp

Re: [PATCH v10 15/33] remoteproc: k3: Refactor rproc_reset() implementation into common driver

2025-04-21 Thread Beleswar Prasad Padhi
Hi Andrew, On 21/04/25 20:12, Andrew Davis wrote: > On 4/17/25 1:19 PM, Beleswar Padhi wrote: >> The rproc_reset() implementations in TI K3 DSP and M4 remoteproc drivers >> assert reset in the same way. Refactor the above function into the >> ti_k3_common.c driver as k3_rproc_reset() and use it th

Re: [PATCH v9 08/26] remoteproc: k3-r5: Refactor sequential core power up/down operations

2025-04-08 Thread Beleswar Prasad Padhi
Hi Andrew, On 07/04/25 19:15, Andrew Davis wrote: On 3/17/25 7:06 AM, Beleswar Padhi wrote: The existing implementation of the waiting mechanism in "k3_r5_cluster_rproc_init()" waits for the "released_from_reset" flag to be set as part of the firmware boot process in "k3_r5_rproc_start()". The

Re: [PATCH v9 05/26] remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info

2025-04-08 Thread Beleswar Prasad Padhi
Hi Andrew, On 07/04/25 19:13, Andrew Davis wrote: On 3/17/25 7:06 AM, Beleswar Padhi wrote: The ti_k3_m4_remoteproc.c driver previously hardcoded device memory region addresses and names. Change this to use the k3_rproc_mem_data structure to store memory information. This aligns with DSP and R5

Re: [PATCH v9 02/26] remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4

2025-04-08 Thread Beleswar Prasad Padhi
On 07/04/25 19:03, Andrew Davis wrote: On 3/17/25 7:05 AM, Beleswar Padhi wrote: Currently, struct members such as mem, num_mems, reset, tsp, ti_sci and ti_sci_id are part of the k3_r5_core structure. To align the rproc->priv data structure of the R5 remote processor with that of the DSP and M

Re: [PATCH v9 01/26] remoteproc: k3-r5: Re-order internal memory initialization function

2025-04-08 Thread Beleswar Prasad Padhi
On 07/04/25 18:59, Andrew Davis wrote: On 3/17/25 7:05 AM, Beleswar Padhi wrote: The core's internal memory data structure will be refactored to be part of the k3_r5_rproc structure in a future commit. As a result, internal memory initialization will need to be performed inside k3_r5_cluster_r

Re: [PATCH v9 00/26] Refactor TI K3 R5, DSP and M4 Remoteproc Drivers

2025-04-07 Thread Beleswar Prasad Padhi
On 17/03/25 17:35, Beleswar Padhi wrote: This series refactors a lot of functions & callbacks from ti_k3_dsp_remoteproc.c, ti_k3_r5_remoteproc.c and ti_k3_m4_remoteproc.c drivers. This is a consolidated and final series as part of the refactoring of K3 remoteproc drivers. Below is the breakdown

Re: [PATCH 2/2] remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4

2025-02-26 Thread Beleswar Prasad Padhi
Hi Andrew, On 26/02/25 20:14, Andrew Davis wrote: On 2/19/25 3:10 AM, Beleswar Padhi wrote: Currently, struct members such as mem, num_mems, reset, tsp, ti_sci and ti_sci_id are part of the k3_r5_core structure. To align the rproc->priv data structure of the R5 remote processor with that of the

Re: [PATCH 1/3] remoteproc: k3-r5: Fix checks in k3_r5_rproc_{mbox_callback/kick}

2025-01-22 Thread Beleswar Prasad Padhi
On 22/01/25 00:17, Andrew Davis wrote: On 12/24/24 3:14 AM, Beleswar Padhi wrote: Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()" and "k3_r5_rproc_kick()" callbacks to exit if the remote core's state

Re: [PATCH v8 00/20] Refactor TI K3 DSP and M4 Drivers

2025-01-10 Thread Beleswar Prasad Padhi
Hi Andrew, On 08/01/25 20:33, Andrew Davis wrote: On 1/3/25 4:12 AM, Beleswar Padhi wrote: This series refactors a lot of functions & callbacks from ti_k3_dsp_remoteproc.c and ti_k3_m4_remoteproc.c drivers. This is the third and final series as part of the refactoring of K3 remoteproc drivers.

Re: [PATCH v8 01/20] remoteproc: k3-m4: Prevent Mailbox level IPC with detached core

2025-01-08 Thread Beleswar Prasad Padhi
On 03/01/25 15:42, Beleswar Padhi wrote: Inter-Processor Communication is facilitated through mailbox payloads, which typically contains the index of the triggered virtqueue having the actual data to be consumed, but the payload can also be used for trivial communication, like sending an echo m

Re: [PATCH 1/3] remoteproc: k3-r5: Fix checks in k3_r5_rproc_{mbox_callback/kick}

2025-01-03 Thread Beleswar Prasad Padhi
On 03/01/25 16:18, Kumar, Udit wrote: On 12/24/2024 2:44 PM, Beleswar Padhi wrote: Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()" and "k3_r5_rproc_kick()" callbacks to exit if the remote core's sta

Re: [PATCH v8 00/20] Refactor TI K3 DSP and M4 Drivers

2025-01-03 Thread Beleswar Prasad Padhi
Missed few changelog. Adding below. On 03/01/25 15:42, Beleswar Padhi wrote: This series refactors a lot of functions & callbacks from ti_k3_dsp_remoteproc.c and ti_k3_m4_remoteproc.c drivers. This is the third and final series as part of the refactoring of K3 remoteproc drivers. The patches for

Re: [PATCH 1/3] remoteproc: k3-r5: Fix checks in k3_r5_rproc_{mbox_callback/kick}

2024-12-29 Thread Beleswar Prasad Padhi
Hi Hari, On 27/12/24 20:08, Hari Nagalla wrote: On 12/24/24 03:14, Beleswar Padhi wrote:   /** @@ -194,8 +196,11 @@ static void k3_r5_rproc_mbox_callback(struct mbox_client *client, void *data)   const char *name = kproc->rproc->name;   u32 msg = omap_mbox_message(data);   -    /* Do

Re: [PATCH v2 0/5] Use Device Lifecycle managed functions in TI R5 Remoteproc driver

2024-12-19 Thread Beleswar Prasad Padhi
On 12/19/2024 8:22 PM, Andrew Davis wrote: On 12/19/24 5:05 AM, Beleswar Padhi wrote: This series uses various devm_ helpers to simplify device removal path in ti_k3_r5_remoteproc driver. This is the first series in the TI K3 Remoteproc refactoring as long planned since [0]. Testing Done: 1.

Re: [PATCH 4/5] remoteproc: k3-r5: Use devm_ioremap_wc() helper

2024-12-18 Thread Beleswar Prasad Padhi
On 17/12/24 21:33, Andrew Davis wrote: On 12/4/24 5:11 AM, Beleswar Padhi wrote: Use a device lifecycle managed ioremap helper function. This helps prevent mistakes like unmapping out of order in cleanup functions and forgetting to unmap on all error paths. Signed-off-by: Beleswar Padhi ---

Re: [PATCH 3/5] remoteproc: k3-r5: Add devm action to release tsp

2024-12-18 Thread Beleswar Prasad Padhi
Hi Andrew, On 17/12/24 21:30, Andrew Davis wrote: On 12/4/24 5:11 AM, Beleswar Padhi wrote: Use a device lifecycle managed action to release tsp ti_sci_proc handle. This helps prevent mistakes like releasing out of order in cleanup functions and forgetting to release on error paths. Signed-off

[PATCH net-next v4 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-11-14 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v4 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-11-14 Thread Mohan Prasad J
Prasad J --- .../testing/selftests/drivers/net/hw/Makefile | 1 + .../drivers/net/hw/nic_performance.py | 137 ++ .../selftests/drivers/net/lib/py/load.py | 20 ++- 3 files changed, 157 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/drivers/net

[PATCH net-next v4 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-11-14 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests

[PATCH net-next v4 0/3] selftests: Add selftest for link layer and performance testing

2024-11-14 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v4: - Type hints are added for

[PATCH net-next v3 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Signed-off-by: Mohan Prasad J --- .../testing/selftests/drivers/net/hw/Makefile

[PATCH net-next v3 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests

[PATCH net-next v3 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-10-16 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v3 0/3] selftests: Add selftest for link layer and performance testing

2024-10-16 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v3: - LinkConfig class is included in

Re: [PATCH 1/1] remoteproc: Use iommu_paging_domain_alloc()

2024-09-22 Thread Beleswar Prasad Padhi
On 29-08-2024 11:47, Beleswar Prasad Padhi wrote: Hi All, On 22/08/24 21:47, Mathieu Poirier wrote: Hi Baolu, Sorry for the late reply, this slipped through the cracks. On Mon, Aug 12, 2024 at 03:28:11PM +0800, Lu Baolu wrote: > An iommu domain is allocated in rproc_enable_iommu() and

Re: [RFC PATCH] remoteproc: k3-r5: Fix check performed in k3_r5_rproc_{mbox_callback/kick}

2024-09-17 Thread Beleswar Prasad Padhi
Hi Mathieu, On 17/09/24 14:07, Mathieu Poirier wrote: On Mon, 16 Sept 2024 at 23:20, Kumar, Udit wrote: On 9/16/2024 8:50 PM, Mathieu Poirier wrote: On Mon, 16 Sept 2024 at 02:31, Siddharth Vadapalli wrote: Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine

[PATCH net-next v2 3/3] selftests: nic_basic_tests: Add selftest case for throughput check

2024-09-17 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_basic_tests.py

[PATCH net-next v2 2/3] selftests: nic_basic_tests: Add selftest case for speed and duplex state checks

2024-09-17 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_basic_tests.py

[PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

2024-09-17 Thread Mohan Prasad J
Add selftest file to test basic features of a NIC driver. Tests for link modes, auto-negotiation are placed. Selftest makes use of ksft modules and ethtool. Add selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests/drivers/net/hw/Makefile | 1 + .../drivers

[PATCH net-next v2 0/3] nic_basic_tests: Add selftest for doing basic tests of NIC driver

2024-09-17 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v2: - Changed the hardcoded

Re: [PATCH] remoteproc: k3-r5: Decouple firmware booting from probe routine

2024-09-08 Thread Beleswar Prasad Padhi
On 07/09/24 15:41, Kumar, Udit wrote: On 9/6/2024 3:10 PM, Beleswar Padhi wrote: The current implementation of the waiting mechanism in probe() waits for the 'released_from_reset' flag to be set which is done in k3_r5_rproc_prepare() as part of rproc_fw_boot(). This causes unexpected failures

Re: [PATCH] remoteproc: k3-r5: Decouple firmware booting from probe routine

2024-09-06 Thread Beleswar Prasad Padhi
Hi Mathieu, On 06-09-2024 22:17, Mathieu Poirier wrote: On Fri, Sep 06, 2024 at 03:10:45PM +0530, Beleswar Padhi wrote: The current implementation of the waiting mechanism in probe() waits for the 'released_from_reset' flag to be set which is done in k3_r5_rproc_prepare() as part of rproc_fw_bo

Re: [PATCH v2] remoteproc: k3-r5: Delay notification of wakeup event

2024-09-04 Thread Beleswar Prasad Padhi
On 03-09-2024 20:02, Mathieu Poirier wrote: On Tue, 3 Sept 2024 at 04:15, Beleswar Prasad Padhi wrote: Hi Mathieu, On 20-08-2024 16:20, Beleswar Padhi wrote: From: Udit Kumar Few times, core1 was scheduled to boot first before core0, which leads to error: 'k3_r5_rproc_start: ca

[PATCH net-next 3/3] selftests: lan743x: Add testcase to check throughput of lan743x

2024-09-03 Thread Mohan Prasad J
Add testcase to check TCP throughput of lan743x network driver. Test uses iperf3 to do performance testing of the driver. TCP data at different speeds is sent, received and verified. Signed-off-by: Mohan Prasad J --- .../net/hw/microchip/lan743x/lan743x.py | 33 +++ 1 file

[PATCH net-next 2/3] selftests: lan743x: Add testcase to check speed and duplex state of lan743x

2024-09-03 Thread Mohan Prasad J
Add testcase for checking speed and duplex states for lan743x network driver. Testcase comprises of varying the network speed and duplex state to 10/100/1000Mbps and half/full via ethtool. Signed-off-by: Mohan Prasad J --- .../net/hw/microchip/lan743x/lan743x.py | 33

[PATCH net-next 1/3] selftests: lan743x: Add testfile for lan743x network driver

2024-09-03 Thread Mohan Prasad J
list. Signed-off-by: Mohan Prasad J --- MAINTAINERS | 2 + tools/testing/selftests/Makefile | 2 +- .../drivers/net/hw/microchip/lan743x/Makefile | 7 +++ .../net/hw/microchip/lan743x/lan743x.py | 51 +++ .../hw/microchip

[PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

2024-09-03 Thread Mohan Prasad J
This series of patches are for testing the lan743x network driver. Testing comprises autonegotiation, speed, duplex and throughput checks. Tools such as ethtool, iperf3 are used in the testing process. Performance test is done for TCP streams at different speeds. Signed-off-by: Mohan Prasad J

Re: [PATCH v2] remoteproc: k3-r5: Delay notification of wakeup event

2024-09-03 Thread Beleswar Prasad Padhi
Hi Mathieu, On 20-08-2024 16:20, Beleswar Padhi wrote: From: Udit Kumar Few times, core1 was scheduled to boot first before core0, which leads to error: 'k3_r5_rproc_start: can not start core 1 before core 0'. This was happening due to some scheduling between prepare and start callback. The

Re: [PATCH 1/1] remoteproc: Use iommu_paging_domain_alloc()

2024-08-28 Thread Beleswar Prasad Padhi
Hi All, On 22/08/24 21:47, Mathieu Poirier wrote: Hi Baolu, Sorry for the late reply, this slipped through the cracks. On Mon, Aug 12, 2024 at 03:28:11PM +0800, Lu Baolu wrote: > An iommu domain is allocated in rproc_enable_iommu() and is attached to > rproc->dev.parent in the same function. >

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Beleswar Prasad Padhi
On 22-08-2024 10:57, Jan Kiszka wrote: On 22.08.24 07:22, Beleswar Prasad Padhi wrote: On 21-08-2024 23:40, Jan Kiszka wrote: On 21.08.24 07:30, Beleswar Prasad Padhi wrote: On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-21 Thread Beleswar Prasad Padhi
On 21-08-2024 23:40, Jan Kiszka wrote: On 21.08.24 07:30, Beleswar Prasad Padhi wrote: On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule and internal Using device lifecycle managed functions to register the rproc

Re: [PATCH] remoteproc: k3-r5: Fix error handling when power-up failed

2024-08-20 Thread Beleswar Prasad Padhi
On 19-08-2024 20:54, Jan Kiszka wrote: From: Jan Kiszka By simply bailing out, the driver was violating its rule and internal Using device lifecycle managed functions to register the rproc (devm_rproc_add()), bailing out with an error code will work. assumptions that either both or no

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 20:29, Beleswar Prasad Padhi wrote: On 20-08-2024 19:50, Jan Kiszka wrote: On 20.08.24 11:48, Beleswar Prasad Padhi wrote: On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 19:50, Jan Kiszka wrote: On 20.08.24 11:48, Beleswar Prasad Padhi wrote: On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed first. When core 0 should then be stopped before its removal, it will

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed first. When core 0 should then be stopped before its removal, it will find core1->rproc as NULL already and crashes. Happens on rmmod e.g. Did you check this

Re: [PATCH v4 2/3] remoteproc: k3-r5: Acquire mailbox handle during probe routine

2024-08-16 Thread Beleswar Prasad Padhi
Hi Mathieu, On 14-08-2024 21:22, Mathieu Poirier wrote: Hi Beleswar, On Thu, Aug 08, 2024 at 01: 11: 26PM +0530, Beleswar Padhi wrote: > Acquire the mailbox handle during device probe and do not release handle > in stop/detach routine or error paths. This removes the redundant > requests for

Re: [PATCH v3 3/3] remoteproc: k3-dsp: Acquire mailbox handle during probe routine

2024-08-07 Thread Beleswar Prasad Padhi
On 07/08/24 19:21, Andrew Davis wrote: On 8/7/24 1:22 AM, Beleswar Padhi wrote: Acquire the mailbox handle during device probe and do not release handle in stop/detach routine or error paths. This removes the redundant requests for mbox handle later during rproc start/attach. This also allows

Re: [PATCH v3 1/3] remoteproc: k3-r5: Use devm_rproc_alloc() helper

2024-08-07 Thread Beleswar Prasad Padhi
Hi Andrew, On 07/08/24 19:07, Andrew Davis wrote: On 8/7/24 1:22 AM, Beleswar Padhi wrote: Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Beleswar Padhi ---

Re: [PATCH v2 2/3] remoteproc: k3-r5: Acquire mailbox handle during probe

2024-06-21 Thread Beleswar Prasad Padhi
Hi Andrew, On 04/06/24 22:40, Andrew Davis wrote: On 6/4/24 12:17 AM, Beleswar Padhi wrote: Acquire the mailbox handle during device probe and do not release handle in stop/detach routine or error paths. This removes the redundant requests for mbox handle later during rproc start/attach. This a

Re: [PATCH v2 2/3] remoteproc: k3-r5: Acquire mailbox handle during probe

2024-06-05 Thread Beleswar Prasad Padhi
Hi Andrew, On 04/06/24 22:40, Andrew Davis wrote: On 6/4/24 12:17 AM, Beleswar Padhi wrote: Acquire the mailbox handle during device probe and do not release handle in stop/detach routine or error paths. This removes the redundant requests for mbox handle later during rproc start/attach. This a

Re: [PATCH 2/3] remoteproc: k3-r5: Acquire mailbox handle during probe

2024-06-03 Thread Beleswar Prasad Padhi
Hi Andrew, On 30/05/24 19:46, Andrew Davis wrote: On 5/30/24 4:07 AM, Beleswar Padhi wrote: Acquire the mailbox handle during device probe and do not release handle in stop/detach routine or error paths. This removes the redundant requests for mbox handle later during rproc start/attach. This a

Re: [EXTERNAL] Re: [PATCH v2 1/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2024-04-29 Thread Beleswar Prasad Padhi
Hello, On 26/04/24 22:39, Mathieu Poirier wrote: Good day, On Wed, Apr 24, 2024 at 06: 35: 03PM +0530, Beleswar Padhi wrote: > From: Apurva Nandan > > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON ZjQcmQRYFpfptBannerStart This message w

[PATCH] ftrace: fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry

2024-03-22 Thread Prasad Pandit
From: Prasad Pandit Fix FTRACE_RECORD_RECURSION_SIZE entry, replace tab with a space character. It helps Kconfig parsers to read file without error. Fixes: 773c16705058 ("ftrace: Add recording of functions that caused recursion") Signed-off-by: Prasad Pandit --- kernel/trace/Kconfig

RE: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-19 Thread Shyam Prasad
I think so; Paulo can confirm. -Original Message- From: Salvatore Bonaccorso On Behalf Of Salvatore Bonaccorso Sent: Monday, April 19, 2021 6:52 PM To: Shyam Prasad Cc: Greg Kroah-Hartman ; pc ; linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Aurelien Aptel ; Steven French

RE: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-18 Thread Shyam Prasad
: Shyam Prasad ; linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Aurelien Aptel ; Steven French ; Sasha Levin Subject: Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath. Hi Greg, On Mon, Apr 12, 2021 at 10:01:33AM +0200, G

RE: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

2021-04-09 Thread Shyam Prasad
Attached the latest version of the patch. Regards, Shyam -Original Message- From: Naresh Kamboju Sent: Friday, April 9, 2021 11:24 PM To: Shyam Prasad Cc: Linux-Next Mailing List ; open list ; samba-techni...@lists.samba.org; lkft-tri...@lists.linaro.org; Maciek Borzecki ; Wan

RE: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

2021-04-09 Thread Shyam Prasad
echni...@lists.samba.org; lkft-tri...@lists.linaro.org Cc: Maciek Borzecki ; Shyam Prasad ; Wan Jiabing ; Steven French ; pc ; Pavel Shilovskiy ; Steve French Subject: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined Large number of Linux next tag 20210408 build

Re: [PATCH] hfsplus/hfsplus_fs.h: Remove unnecessary struct declaration

2021-04-07 Thread Shyam Prasad N
Reviewed-by: Shyam Prasad N On Wed, Apr 7, 2021 at 1:28 AM Wan Jiabing wrote: > > struct hfs_btree is defined at 73rd line. > The declaration here is unnecessary. Remove it. > > Signed-off-by: Wan Jiabing > --- > fs/hfsplus/hfsplus_fs.h | 1 - > 1 file changed, 1 dele

RE: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-06 Thread Shyam Prasad
-Original Message- From: Greg Kroah-Hartman Sent: Tuesday, April 6, 2021 7:12 PM To: Salvatore Bonaccorso Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Shyam Prasad ; Aurelien Aptel ; Steven French ; Sasha Levin Subject: [EXTERNAL] Re: [PATCH 4.19 013

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-07 Thread Shyam Prasad N
Hi Vincent, The reason for rejecting the request maybe a number of things like: corrupted request, stale request (for some old session), or for a wrong handle. I don't think we should treat any of these cases as a success. Also, from the MS-SMB2 documentation: https://docs.microsoft.com/en-us/ope

Re: [EXTERNAL] re: cifs: Retain old ACEs when converting between mode bits and ACL.

2021-02-24 Thread Shyam Prasad N
error immediately. Regards, Shyam On Wed, Feb 24, 2021 at 7:16 AM Shyam Prasad wrote: > > Hi Colin, > > Thanks for reporting this. I'll submit a fix. > > Regards, > Shyam > > -Original Message- > From: Colin Ian King > Sent: Wednesday, February 24,

RE: [EXTERNAL] re: cifs: Retain old ACEs when converting between mode bits and ACL.

2021-02-24 Thread Shyam Prasad
Hi Colin, Thanks for reporting this. I'll submit a fix. Regards, Shyam -Original Message- From: Colin Ian King Sent: Wednesday, February 24, 2021 6:14 PM To: Shyam Prasad Cc: Steve French ; linux-c...@vger.kernel.org; samba-techni...@lists.samba.org; linux-kernel@vger.kerne

Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Shyam Prasad N
Minor comments inline... On Fri, Dec 18, 2020 at 2:30 AM Boris Protopopov wrote: > > Fix passing of the additional security info via version > operations. Force new open when getting SACL and avoid > reuse of files that were previously open without > sufficient privileges to access SACLs. > > Sig

Re: [PATCH] Add support for getting and setting SACLs

2020-12-02 Thread Shyam Prasad N
Hi Boris, At a high level, the changes look good to me. Will go through the changes in more detail tomorrow morning. On a related note, we may need more test coverage in this area. Can you please share your testing output against your changes? Or even better, if you can contribute some xfstests f

[PATCH v2] tracing: Add register read and write tracing support

2020-11-05 Thread Prasad Sodagudi
Add register read/write operations tracing support. ftrace events helps to trace register read and write location details of memory mapped IO registers. These trace logs helps to debug un clocked access of peripherals. Signed-off-by: Prasad Sodagudi --- arch/arm64/include/asm/io.h| 9

[PATCH 2] Register read and writes tracing

2020-11-05 Thread Prasad Sodagudi
this logging would help other silicon vendors as this is generic approach. v1 -> v2: - Removed _no_log variant - tracepoint_enabled api is used. - Added depends on ARM64 Prasad Sodagudi (1): tracing: Add register read and write tracing support arch/arm64/include/asm/io.h| 9 ++

[PATCH] tracing: Add register read and write tracing support

2020-09-27 Thread Prasad Sodagudi
Add register read/write operations tracing support. ftrace events helps trace register read and write location details of memory mapped IO registers. Also add _no_log variants the writel_relaxed/readl_relaed APIs to avoid excessive logging for certain register operations. Signed-off-by: Prasad

[PATCH] Register read and writes tracing

2020-09-27 Thread Prasad Sodagudi
provide your suggestion/comments to bring this patch upstream quality. Prasad Sodagudi (1): tracing: Add register read and write tracing support arch/arm64/include/asm/io.h| 117 ++--- include/linux/iorw.h | 20 +++ include/trace/events

[PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-23 Thread Prasad Sodagudi
Khajapasha Signed-off-by: Prasad Sodagudi --- init/Kconfig | 10 ++ kernel/printk/printk.c | 10 -- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index d6a0b31..9ce39ba 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -699,6

[PATCH 1/2] genirq/cpuhotplug: Reduce logging level for couple of prints

2020-09-23 Thread Prasad Sodagudi
-by: Prasad Sodagudi --- arch/arm64/kernel/smp.c | 2 +- kernel/irq/cpuhotplug.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 355ee9e..08da6e3 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c

[PATCH 1/2] cpu/hotplug: Add cpuhp_latency trace event

2020-09-23 Thread Prasad Sodagudi
Add ftrace event trace_cpuhp_latency to track cpu hotplug latency. It helps to track the hotplug latency impact by firmware changes and kernel cpu hotplug callbacks. Signed-off-by: Prasad Sodagudi --- include/trace/events/cpuhp.h | 29 + kernel/cpu.c

[PATCH 0/2] measure latency of cpu hotplug path

2020-09-23 Thread Prasad Sodagudi
: cpuhp_exit: cpu: 0004 state: 2 step: 2 ret: 0 sh-176 [000] 265.193494: cpuhp_latency: cpu:4 state:offline latency:57431 USEC ret: 0 Prasad Sodagudi (1): cpu/hotplug: Add cpuhp_latency trace event Syed Rameez Mustafa (1): cpu-hotplug: Always use real time scheduling

[PATCH 2/2] cpu-hotplug: Always use real time scheduling when hotplugging a CPU

2020-09-23 Thread Prasad Sodagudi
igned-off-by: Prasad Sodagudi --- kernel/cpu.c | 41 + 1 file changed, 41 insertions(+) diff --git a/kernel/cpu.c b/kernel/cpu.c index 68b3740..aea4ce2 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -32,6 +32,7 @@ #include #include #include +#in

[PATCH v3 2/2] sched: Add a check for cpu unbound deferrable timers

2020-05-02 Thread Prasad Sodagudi
Add a check to find expired unbound deferrable timers and trigger softirq for handling timers. This way a CPU can process all the expired deferrable timers whenever it is out off idle state due to an interrupt. Signed-off-by: Prasad Sodagudi --- include/linux/timer.h| 3 +++ kernel/time

[PATCH v3 0/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-05-02 Thread Prasad Sodagudi
imers really not bound to a cpu Prasad Sodagudi (1): sched: Add a check for cpu unbound deferrable timers include/linux/timer.h| 3 +++ kernel/time/tick-sched.c | 8 +- kernel/time/timer.c | 69 3 files changed, 74 insertions

[PATCH v3 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-05-02 Thread Prasad Sodagudi
ble timers are scalable, introduce a common timer base which is only for cpu unbound deferrable timers to make those are indeed cpu unbound so that can be scheduled by any of non idle cpus. This common timer fixes scalability issue of delayed work and all other cpu unbound deferrable timer using implem

[PATCH v2 0/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-04-28 Thread Prasad Sodagudi
/500541/ [2]- https://lkml.org/lkml/2020/3/16/147 Changelog: v1 -> v2: - Fixed tglx comments about warning. - Thanks Pavan for your suggestion. Joonwoo Park (1): timer: make deferrable cpu unbound timers really not bound to a cpu Prasad Sodagudi (1): sched: Add a check for cpu unbo

[PATCH v2 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-04-28 Thread Prasad Sodagudi
ble timers are scalable, introduce a common timer base which is only for cpu unbound deferrable timers to make those are indeed cpu unbound so that can be scheduled by any of non idle cpus. This common timer fixes scalability issue of delayed work and all other cpu unbound deferrable timer using implem

[PATCH v2 2/2] sched: Add a check for cpu unbound deferrable timers

2020-04-28 Thread Prasad Sodagudi
Add a check for cpu unbound deferrable timer expiry and raise softirq for handling the expired timers so that the CPU can process the cpu unbound deferrable times as early as possible when a cpu tries to enter/exit idle loop. Signed-off-by: Prasad Sodagudi --- include/linux/timer.h| 3

Time stamp value in printk records

2019-09-30 Thread Sodagudi Prasad
adding raw timer value to printk records. -Thanks, Prasad -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project

Zdravstvujte! Vas interesujut klientskie bazy dannyh?

2019-09-09 Thread 128128chumble . prasad
Zdravstvujte! Vas interesujut klientskie bazy dannyh?

Re: [PATCH] kernel/panic: Use SYSTEM_RESET2 command for warm reset

2019-05-17 Thread Sodagudi Prasad
On 2019-05-16 11:29, Aaro Koskinen wrote: Hi, On Wed, May 08, 2019 at 06:47:12PM -0700, Prasad Sodagudi wrote: Some platforms may need warm reboot support when kernel crashed for post mortem analysis instead of cold reboot. So use config CONFIG_WARM_REBOOT_ON_PANIC and SYSTEM_RESET2 psci

[PATCH] kernel/panic: Use SYSTEM_RESET2 command for warm reset

2019-05-08 Thread Prasad Sodagudi
Some platforms may need warm reboot support when kernel crashed for post mortem analysis instead of cold reboot. So use config CONFIG_WARM_REBOOT_ON_PANIC and SYSTEM_RESET2 psci command support for warm reset. Signed-off-by: Prasad Sodagudi --- kernel/panic.c| 4 lib/Kconfig.debug

Re: PSCI version 1.1 and SYSTEM_RESET2

2019-05-08 Thread Sodagudi Prasad
On 2019-05-02 02:05, Sudeep Holla wrote: On Wed, May 01, 2019 at 11:43:00AM -0700, Sodagudi Prasad wrote: On 2019-05-01 02:49, Sudeep Holla wrote: > On Tue, Apr 30, 2019 at 05:07:31PM -0700, Sodagudi Prasad wrote: > > On 2019-04-30 14:44, Sodagudi Prasad wrote: [...] > > &g

Re: PSCI version 1.1 and SYSTEM_RESET2

2019-05-01 Thread Sodagudi Prasad
On 2019-05-01 02:49, Sudeep Holla wrote: On Tue, Apr 30, 2019 at 05:07:31PM -0700, Sodagudi Prasad wrote: On 2019-04-30 14:44, Sodagudi Prasad wrote: +Sudeep > Hi Mark/Will, > > I would like to understand whether ARM linux community have plans to > support PSCI version 1.1 or not

Re: PSCI version 1.1 and SYSTEM_RESET2

2019-04-30 Thread Sodagudi Prasad
On 2019-04-30 14:44, Sodagudi Prasad wrote: +Sudeep Hi Mark/Will, I would like to understand whether ARM linux community have plans to support PSCI version 1.1 or not. PSCI_1_1 specification introduced support for SYSTEM_RESET2 command and this new command helps mobile devices to

PSCI version 1.1 and SYSTEM_RESET2

2019-04-30 Thread Sodagudi Prasad
helps to capture the snapshot of the ram contents for post-mortem analysis. -Thanks, Prasad -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project

[tip:irq/core] genirq: Prevent use-after-free and work list corruption

2019-03-24 Thread tip-bot for Prasad Sodagudi
Commit-ID: 59c39840f5abf4a71e1810a8da71aaccd6c17d26 Gitweb: https://git.kernel.org/tip/59c39840f5abf4a71e1810a8da71aaccd6c17d26 Author: Prasad Sodagudi AuthorDate: Sun, 24 Mar 2019 07:57:04 -0700 Committer: Thomas Gleixner CommitDate: Sun, 24 Mar 2019 22:13:17 +0100 genirq: Prevent

[PATCH v2] genirq: Prevent use-after-free and work list corruption

2019-03-24 Thread Prasad Sodagudi
corruption. Ensure that the work is canceled before the reference is dropped. Signed-off-by: Prasad Sodagudi --- kernel/irq/manage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 9ec34a2..1a1ac84 100644 --- a/kernel/irq

Re: [PATCH] genirq: call cancel_work_sync from irq_set_affinity_notifier

2019-03-21 Thread Sodagudi Prasad
On 2019-03-21 09:19, Thomas Gleixner wrote: Prasad, On Wed, 20 Mar 2019, Prasad Sodagudi wrote: Subject: [PATCH] genirq: call cancel_work_sync from irq_set_affinity_notifier Please do not decribe WHAT the code change is. Give a consice explanation WHY this change is done. The above is like

Re: [PATCH] perf: Change PMCR write to read-modify-write

2019-03-21 Thread Sodagudi Prasad
On 2019-03-21 06:34, Julien Thierry wrote: Hi Prasad, On 21/03/2019 02:07, Prasad Sodagudi wrote: Preserves the bitfields of PMCR_EL0(AArch64) during PMU reset. Reset routine should write a 1 to PMCR.C and PMCR.P fields only to reset the counters. Other fields should not be changed as they

[PATCH] perf: Change PMCR write to read-modify-write

2019-03-20 Thread Prasad Sodagudi
: Prasad Sodagudi --- arch/arm64/kernel/perf_event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 4addb38..0c1afdd 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64/kernel/perf_event.c

  1   2   3   4   >