Hi Mathieu, On 09/05/25 22:39, Mathieu Poirier wrote: > On Fri, Apr 25, 2025 at 04:11:00PM +0530, Beleswar Padhi wrote: >> This series refactors a lot of functions & callbacks from >> ti_k3_dsp_remoteproc.c, ti_k3_r5_remoteproc.c and ti_k3_m4_remoteproc.c >> drivers. This is a consolidated and final series as part of the >> refactoring of K3 remoteproc drivers. Below is the breakdown: >> 1. PATCHES #1-#3 fixes important bugs in R5 and DSP drivers before >> refactoring >> them into a common driver. >> 2. PATCHES #4-#10 does the pre-cleanup and aligns R5, DSP, M4 data >> structures. >> 3. PATCHES #11-#35 does the actual refactoring R5, DSP and M4 drivers into >> ti_k3_common.c driver. >> >> NOTE: >> This series supersedes below series: >> https://lore.kernel.org/all/20250219091042.263819-1-b-pa...@ti.com/ >> https://lore.kernel.org/all/20250417182001.3903905-1-b-pa...@ti.com/ >> https://lore.kernel.org/all/20250108063727.1416324-1-b-pa...@ti.com/ >> >> Testing Done: >> 1. Tested boot of R5Fs, C66x DSPs, C71x DSPs across Jacinto J7* devices in >> remoteproc mode and IPC-Only mode. >> 2. Tested boot of M4F core _only_ in _AM62xx SK_ board in Remoteproc mode and >> IPC-Only mode. >> 3. Tested Core stop and detach operations from sysfs for R5Fs, C66x DSPs, >> C71x DSPs >> 4. Tested device removal paths by executing 'modprobe -r >> ti_k3_dsp_remoteproc' >> and 'modprobe -r ti_k3_r5_remoteproc'. >> 5. Tested usecases where firmware not available at device probe time, but >> later in sysfs, able to load firmware into a remotecore and start it. [R5Fs] >> 6. Tested that each patch in this series generates no new warnings/errors. >> 7. Tested IPC on AM64x EVM Device. [Thanks to Judith]. >> >> v11: Changelog: >> 1. New patches: [v11 15/35] and [v11 18/35]. >> Broken down rproc_reset() and rproc_release() refactoring patches into more >> atomic changes. >> 2. Carried T/B on all patches from Judith. >> 3. Carried A/B on [PATCH v11 13/35] by Andrew. >> >> Link to v10: >> https://lore.kernel.org/all/20250417182001.3903905-1-b-pa...@ti.com/ >> >> v10: Changelog: >> 1. Re-ordered Bug Fixes to the start of the series, before starting >> pre-cleanup >> and finally the actual refactor. [Andrew] >> 2. Broken down commits into more atomic changes for ease of review. [Andrew]. >> 3. Updated commit messages to have uniform flow throughout the series. >> 4. Carried R/B tags in applicable patches. >> 5. Further patch specific changelog is attached with patches. >> >> Link to v9: >> https://lore.kernel.org/all/20250317120622.1746415-1-b-pa...@ti.com/ >> >> v9: Changelog: >> 1. Added R5 cleanup & refactoring along with existing DSP, M4 refactoring >> into this series. [Andrew] >> 2. Dropped Mailbox level IPC checks across R5, DSP, M4 drivers in IPC-only >> mode. [Andrew] >> >> Link to v8: >> https://lore.kernel.org/all/20250103101231.1508151-1-b-pa...@ti.com/ >> >> v8: Changelog: >> 1. Broken down refactoring into patches, each patch dealing with one function >> for ease in review. [Andrew] >> >> Links to older versions: >> v7: https://lore.kernel.org/all/20240202175538.1705-1-hnaga...@ti.com/ >> v6: https://lore.kernel.org/all/20230913111644.29889-1-hnaga...@ti.com/ >> v5: https://lore.kernel.org/all/20230808044529.25925-1-hnaga...@ti.com/ >> v4: https://lore.kernel.org/all/20230801141117.2559-1-hnaga...@ti.com/ >> v3: >> https://lore.kernel.org/all/20230302171450.1598576-1-martyn.we...@collabora.com/ >> v2: >> https://lore.kernel.org/all/20230301111323.1532479-4-martyn.we...@collabora.com/ >> v1: https://lore.kernel.org/all/20220110040650.18186-1-hnaga...@ti.com/ >> >> Thanks, >> Beleswar >> >> Beleswar Padhi (33): >> remoteproc: k3-r5: Refactor sequential core power up/down operations >> remoteproc: k3-r5: Re-order internal memory initialization functions >> remoteproc: k3-r5: Re-order k3_r5_release_tsp() function >> remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4 >> remoteproc: k3-r5: Use k3_r5_rproc_mem_data structure for memory info >> remoteproc: k3-{m4/dsp}: Add a void ptr member in rproc internal >> struct >> remoteproc: k3-m4: Add pointer to rproc struct within k3_m4_rproc >> remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info >> remoteproc: k3: Refactor shared data structures >> remoteproc: k3: Refactor mailbox rx_callback functions into common >> driver >> remoteproc: k3: Refactor .kick rproc ops into common driver >> remoteproc: k3-dsp: Correct Reset logic for devices without lresets >> remoteproc: k3-m4: Introduce central function to put rproc into reset >> remoteproc: k3: Refactor rproc_reset() implementation into common >> driver >> remoteproc: k3-dsp: Correct Reset deassert logic for devices w/o >> lresets >> remoteproc: k3-m4: Introduce central function to release rproc from >> reset >> remoteproc: k3: Refactor rproc_release() implementation into common >> driver >> remoteproc: k3-m4: Ping the mbox while acquiring the channel >> remoteproc: k3: Refactor rproc_request_mbox() implementations into >> common driver >> remoteproc: k3-dsp: Don't override rproc ops in IPC-only mode >> remoteproc: k3-dsp: Assert local reset during .prepare callback >> remoteproc: k3: Refactor .prepare rproc ops into common driver >> remoteproc: k3: Refactor .unprepare rproc ops into common driver >> remoteproc: k3: Refactor .start rproc ops into common driver >> remoteproc: k3: Refactor .stop rproc ops into common driver >> remoteproc: k3: Refactor .attach rproc ops into common driver >> remoteproc: k3: Refactor .detach rproc ops into common driver >> remoteproc: k3: Refactor .get_loaded_rsc_table ops into common driver >> remoteproc: k3: Refactor .da_to_va rproc ops into common driver >> remoteproc: k3: Refactor of_get_memories() functions into common >> driver >> remoteproc: k3: Refactor mem_release() functions into common driver >> remoteproc: k3: Refactor reserved_mem_init() functions into common >> driver >> remoteproc: k3: Refactor release_tsp() functions into common driver >> >> Siddharth Vadapalli (2): >> remoteproc: k3-r5: Drop check performed in >> k3_r5_rproc_{mbox_callback/kick} >> remoteproc: k3-dsp: Drop check performed in >> k3_dsp_rproc_{mbox_callback/kick} >> >> drivers/remoteproc/Makefile | 4 +- >> drivers/remoteproc/ti_k3_common.c | 547 +++++++++++ >> drivers/remoteproc/ti_k3_common.h | 113 +++ >> drivers/remoteproc/ti_k3_dsp_remoteproc.c | 616 +------------ >> drivers/remoteproc/ti_k3_m4_remoteproc.c | 583 +----------- >> drivers/remoteproc/ti_k3_r5_remoteproc.c | 1012 +++++++-------------- > I am done reviewing this set. The work done herein is a textbook example on > how > refactoring should be done and I commend you for it.
Thank you for the reviews and appreciation! Thanks to Andrew for constantly reviewing and pushing the series in right direction! Thanks, Beleswar > > Mathieu > >> 6 files changed, 1072 insertions(+), 1803 deletions(-) >> create mode 100644 drivers/remoteproc/ti_k3_common.c >> create mode 100644 drivers/remoteproc/ti_k3_common.h >> >> -- >> 2.34.1 >>
