Re: [PATCH net-next v4 00/17] Some pktgen fixes/improvments

2025-02-11 Thread Peter Seiderer
Hello Simon, On Thu, 6 Feb 2025 13:51:54 +, Simon Horman wrote: > On Wed, Feb 05, 2025 at 02:11:36PM +0100, Peter Seiderer wrote: > > hile taking a look at '[PATCH net] pktgen: Avoid out-of-range in > > get_imix_entries' ([1]) and '[PATCH net v2] pktgen: A

Re: [PATCH net-next v4 09/17] net: pktgen: align some variable declarations to the most common pattern

2025-02-11 Thread Peter Seiderer
Hello Simon, On Thu, 6 Feb 2025 13:25:38 +, Simon Horman wrote: > On Wed, Feb 05, 2025 at 02:11:45PM +0100, Peter Seiderer wrote: > > Align some variable declarations (in get_imix_entries and get_labels) to > > the most common pattern (int instead of ssize_t/long) and

[PATCH net-next v4 13/17] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-05 Thread Peter Seiderer
Honour the user given buffer size for the hex32_arg(), num_arg(), strn_len(), get_imix_entries() and get_labels() calls (otherwise they will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer --- Changes v3 -> v4: - replace C99 comment (suggested by Paolo Ab

[PATCH net-next v4 16/17] net: pktgen: fix mpls reset parsing

2025-02-05 Thread Peter Seiderer
/proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 Result: OK: mpls= $ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0 $ echo "mpls invalid" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 Result: OK:

[PATCH net-next v4 05/17] net: pktgen: fix 'ratep 0' error handling (return -EINVAL)

2025-02-05 Thread Peter Seiderer
applied $ echo "ratep 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3 -> v4 - add rev-by

[PATCH net-next v4 14/17] net: pktgen: hex32_arg/num_arg error out in case no characters are available

2025-02-05 Thread Peter Seiderer
In hex32_arg() and num_arg() error out in case no characters are available (maxlen = 0). Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c

[PATCH net-next v4 09/17] net: pktgen: align some variable declarations to the most common pattern

2025-02-05 Thread Peter Seiderer
Align some variable declarations (in get_imix_entries and get_labels) to the most common pattern (int instead of ssize_t/long) and adjust function return value accordingly. Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access ou

[PATCH net-next v4 08/17] net: pktgen: use defines for the various dec/hex number parsing digits lengths

2025-02-05 Thread Peter Seiderer
Use defines for the various dec/hex number parsing digits lengths (hex32_arg/num_arg calls). Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (suggested by Simon Horman) --- net/core/pktgen.c | 80 ++- 1 file changed, 44 inserti

[PATCH net-next v4 07/17] net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

2025-02-05 Thread Peter Seiderer
Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3 -> v4 - add rev-by Simon Horman Changes v2 -> v3: - no changes Changes v1

[PATCH net-next v4 11/17] net: pktgen: remove some superfluous variable initializing

2025-02-05 Thread Peter Seiderer
Remove some superfluous variable initializing before hex32_arg call (as the same init is done here already). Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()')

[PATCH net-next v4 17/17] selftest: net: add proc_net_pktgen

2025-02-05 Thread Peter Seiderer
Add some test for /proc/net/pktgen/... interface. - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config Signed-off-by: Peter Seiderer --- Changes v3 -> v4: - no changes Changes v2 -> v3: - fix typo in change description ('v1 -> v1' and tyop)

[PATCH net-next v4 15/17] net: pktgen: num_arg error out in case no valid character is parsed

2025-02-05 Thread Peter Seiderer
In num_arg() error out in case no valid character is parsed. Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c | 3 +++ 1 file changed,

[PATCH net-next v4 01/17] net: pktgen: replace ENOTSUPP with EOPNOTSUPP

2025-02-05 Thread Peter Seiderer
Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

[PATCH net-next v4 12/17] net: pktgen: fix mpls maximum labels list parsing

2025-02-05 Thread Peter Seiderer
gt; /proc/net/pktgen/lo\@0 -bash: echo: write error: Argument list too long Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c | 6

[PATCH net-next v4 10/17] net: pktgen: remove extra tmp variable (re-use len instead)

2025-02-05 Thread Peter Seiderer
Remove extra tmp variable in pktgen_if_write (re-use len instead). Signed-off-by: Peter Seiderer --- Changes v3 -> v4 - new patch (factored out of patch 'net: pktgen: fix access outside of user given buffer in pktgen_if_write()') --- net/core/pktgen.c | 9 - 1 fi

[PATCH net-next v4 06/17] net: pktgen: fix ctrl interface command parsing

2025-02-05 Thread Peter Seiderer
ith patch applied $ echo -n "reset" > /proc/net/pktgen/pgctrl Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3 -> v4 - add rev-by Simon Horman Changes v2 -> v3: - new patch --- net/core/pktgen.c | 14 -- 1 file changed, 8 insertio

[PATCH net-next v4 02/17] net: pktgen: enable 'param=value' parsing

2025-02-05 Thread Peter Seiderer
> /proc/net/pktgen/lo\@0 $ echo "min_pkt_size=999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size =999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size= 999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size = 999" > /proc/net

[PATCH net-next v4 03/17] net: pktgen: fix hex32_arg parsing for short reads

2025-02-05 Thread Peter Seiderer
Result: OK: mpls=1230 - with patch applied $ echo "mpls 123" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 mpls: 0123 Result: OK: mpls=0123 Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3

[PATCH net-next v4 04/17] net: pktgen: fix 'rate 0' error handling (return -EINVAL)

2025-02-05 Thread Peter Seiderer
applied $ echo "rate 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3 -> v4 - add rev-by

[PATCH net-next v4 00/17] Some pktgen fixes/improvments

2025-02-05 Thread Peter Seiderer
some checkpatch warnings (Missing a blank line after declarations) - shrink line length by re-naming some variables (command -> cmd, device -> dev) - add 'rate 0' testcase - add 'ratep 0' testcase [1] https://lore.kernel.org/netdev/20241006221221.3744995-1-artem.che

Re: [PATCH net-next v3 08/10] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-05 Thread Peter Seiderer
Hello Simon, On Tue, 4 Feb 2025 10:52:51 +, Simon Horman wrote: > On Mon, Feb 03, 2025 at 06:01:59PM +0100, Peter Seiderer wrote: > > Honour the user given buffer size for the hex32_arg(), num_arg(), > > strn_len(), get_imix_entries() and get_labels() calls (otherwise they

Re: [PATCH net-next v3 08/10] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-05 Thread Peter Seiderer
Hello Paolo, On Tue, 4 Feb 2025 11:40:21 +0100, Paolo Abeni wrote: > Hi, > > On 2/3/25 6:01 PM, Peter Seiderer wrote: > > @@ -806,6 +812,9 @@ static long num_arg(const char __user *user_buffer, > > unsigned long maxlen, > >

Re: [PATCH net-next v3 02/10] net: pktgen: enable 'param=value' parsing

2025-02-05 Thread Peter Seiderer
Hello Paolo, On Tue, 4 Feb 2025 11:55:57 +0100, Paolo Abeni wrote: > On 2/3/25 6:01 PM, Peter Seiderer wrote: > > Enable additional to 'parm value' the 'param=value' parsing > > It could be language bias on my side, by I find the above statement hard >

Re: [PATCH] selftests: pidfd: Fix compiling warning of pidfs_setns

2025-02-05 Thread Peter Seiderer
Hello *, On Wed, 5 Feb 2025 13:50:31 +0800, I Hsin Cheng wrote: > In the compilation of pidfs_setns_test.c , a warning as the following > will pop out. > > pidfd_setns_test.c: In function ‘current_nsset_setup’: > pidfd_setns_test.c:173:54: warning: implicit declaration of function \ > ‘ioctl’

Re: [PATCH] selftests: pidfd: Fix compiling errors and warning

2025-02-05 Thread Peter Seiderer
Hello *, On Wed, 5 Feb 2025 13:39:26 +0800, I Hsin Cheng wrote: > When compiling selftests files under tools/testing/selftests/pidfd/ , > some compiling errors and warnings will pop out as the following. > > CC pidfd_fdinfo_test > pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_t

Re: [PATCH v7 2/6] selftests/pidfd: add missing system header imcludes to pidfd tests

2025-02-05 Thread Peter Seiderer
Hello *, On Thu, 30 Jan 2025 20:40:27 +, Lorenzo Stoakes wrote: > The pidfd_fdinfo_test.c and pidfd_setns_test.c tests appear to be missing > fundamental system header imports required to execute correctly. Add these. > > Signed-off-by: Lorenzo Stoakes > --- > tools/testing/selftests/pidf

[PATCH net-next v3 07/10] net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

2025-02-03 Thread Peter Seiderer
Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no changes Changes v1 -> v2: - no changes --- net/core/pktgen.c | 7 --- 1 file chan

[PATCH net-next v3 06/10] net: pktgen: fix ctrl interface command parsing

2025-02-03 Thread Peter Seiderer
ith patch applied $ echo -n "reset" > /proc/net/pktgen/pgctrl Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - new patch --- net/core/pktgen.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c in

[PATCH net-next v3 08/10] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-03 Thread Peter Seiderer
. Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no changes Changes v1 -> v2: - additional fix get_imix_entries() and get_labels() --- net/core/pktgen.c | 211 ++ 1 file changed, 139 insertions(+), 72 deletions(-) diff --git a/net/core/pktg

[PATCH net-next v3 04/10] net: pktgen: fix 'rate 0' error handling (return -EINVAL)

2025-02-03 Thread Peter Seiderer
applied $ echo "rate 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no changes Changes v1 -> v2: - new

[PATCH net-next v3 09/10] net: pktgen: fix mpls reset parsing

2025-02-03 Thread Peter Seiderer
/proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 Result: OK: mpls= $ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0 $ echo "mpls invalid" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 Result: OK

[PATCH net-next v3 03/10] net: pktgen: fix hex32_arg parsing for short reads

2025-02-03 Thread Peter Seiderer
Result: OK: mpls=1230 - with patch applied $ echo "mpls 123" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 mpls: 0123 Result: OK: mpls=0123 Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - no changes Ch

[PATCH net-next v3 10/10] selftest: net: add proc_net_pktgen

2025-02-03 Thread Peter Seiderer
Add some test for /proc/net/pktgen/... interface. - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - fix typo in change description ('v1 -> v1' and tyop) - rename some vars to better matc

[PATCH net-next v3 05/10] net: pktgen: fix 'ratep 0' error handling (return -EINVAL)

2025-02-03 Thread Peter Seiderer
applied $ echo "ratep 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no changes Changes v1 -> v2: -

[PATCH net-next v3 00/10] Some pktgen fixes/improvments

2025-02-03 Thread Peter Seiderer
add 'rate 0' testcase - add 'ratep 0' testcase [1] https://lore.kernel.org/netdev/20241006221221.3744995-1-artem.chernys...@red-soft.ru/ [2] https://lore.kernel.org/netdev/20250109083039.14004-1-pchel...@ispras.ru/ [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi

[PATCH net-next v3 02/10] net: pktgen: enable 'param=value' parsing

2025-02-03 Thread Peter Seiderer
/pktgen/lo\@0 $ echo "min_pkt_size =999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size= 999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size = 999" > /proc/net/pktgen/lo\@0 Signed-off-by: Peter Seiderer --- Changes v2 -> v3: - no c

[PATCH net-next v3 01/10] net: pktgen: replace ENOTSUPP with EOPNOTSUPP

2025-02-03 Thread Peter Seiderer
Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer --- Changes v2 -> v

[PATCH net-next v2 6/8] net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

2025-01-22 Thread Peter Seiderer
Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - no changes --- net/core/pktgen.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) d

[PATCH net-next v2 7/8] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-01-22 Thread Peter Seiderer
. Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - additional fix get_imix_entries() and get_labels() --- net/core/pktgen.c | 213 ++ 1 file changed, 140 insertions(+), 73 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c in

[PATCH net-next v2 0/8] Some pktgen fixes/improvments

2025-01-22 Thread Peter Seiderer
mand -> cmd, device -> dev) - add 'rate 0' testcase - add 'ratep 0' testcase [1] https://lore.kernel.org/netdev/20241006221221.3744995-1-artem.chernys...@red-soft.ru/ [2] https://lore.kernel.org/netdev/20250109083039.14004-1-pchel...@ispras.ru/ [3] https://git.kernel

[PATCH net-next v2 1/8] net: pktgen: replace ENOTSUPP with EOPNOTSUPP

2025-01-22 Thread Peter Seiderer
Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer --- Changes v1 -> v

[PATCH net-next v2 8/8] selftest: net: add proc_net_pktgen

2025-01-22 Thread Peter Seiderer
Add some test for /proc/net/pktgen/... interface. - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config Signed-off-by: Peter Seiderer --- Changes v1 -> v1: - fix tyop not vs. nod (suggested by Jakub Kicinski) - fix misaligned line (suggested by Jakub Kicinsk

[PATCH net-next v2 4/8] net: pktgen: fix 'rate 0' error handling (return -EINVAL)

2025-01-22 Thread Peter Seiderer
applied $ echo "rate 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - new patch --- net/core/pktgen.c | 2 +-

[PATCH net-next v2 5/8] net: pktgen: fix 'ratep 0' error handling (return -EINVAL)

2025-01-22 Thread Peter Seiderer
applied $ echo "ratep 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - new patch --- net/core/pkt

[PATCH net-next v2 3/8] net: pktgen: fix hex32_arg parsing for short reads

2025-01-22 Thread Peter Seiderer
Result: OK: mpls=1230 - with patch applied $ echo "mpls 123" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0 mpls: 0123 Result: OK: mpls=0123 Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - new pat

[PATCH net-next v2 2/8] net: pktgen: enable 'param=value' parsing

2025-01-22 Thread Peter Seiderer
/pktgen/lo\@0 $ echo "min_pkt_size =999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size= 999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size = 999" > /proc/net/pktgen/lo\@0 Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - no chan

Re: [PATCH net-next v1 5/5] selftest: net: add proc_net_pktgen

2025-01-22 Thread Peter Seiderer
Hello Jakub, On Fri, 17 Jan 2025 13:11:54 -0800, Jakub Kicinski wrote: > On Fri, 17 Jan 2025 15:16:13 +0100 Peter Seiderer wrote: > > +FIXTURE_SETUP(proc_net_pktgen) { > > + ssize_t len; > > + > > + self->ctrl_fd = open("/proc/net/pktgen/kpktgend_0",

Re: [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c

2025-01-17 Thread Peter Seiderer
Please ignore this e-mail (re-send by mistake of [1])..., sorry for the noise... Regards, Peter [1] https://lore.kernel.org/linux-kselftest/20250115105211.390370-1-ps.rep...@gmx.net/ On Fri, 17 Jan 2025 15:14:48 +0100, Peter Seiderer wrote: > Fix compile on openSUSE Tumbleweed (gcc-14.

[PATCH net-next v1 5/5] selftest: net: add proc_net_pktgen

2025-01-17 Thread Peter Seiderer
Add some test for /proc/net/pktgen/... interface. Signed-off-by: Peter Seiderer --- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/proc_net_pktgen.c | 575 ++ 2 files changed, 576 insertions(+) create mode 100644 tools/testing/selftests/net

[PATCH net-next v1 3/5] net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

2025-01-17 Thread Peter Seiderer
Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core

[PATCH net-next v1 0/5] Some pktgen fixes/improvments

2025-01-17 Thread Peter Seiderer
..@ispras.ru/ [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76201b5979768500bca362871db66d77cb4c225e Peter Seiderer (5): net: pktgen: replace ENOTSUPP with EOPNOTSUPP net: pktgen: enable 'param=value' parsing net: pktgen: fix access outside o

[PATCH net-next v1 4/5] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-01-17 Thread Peter Seiderer
is parsed. Additional remove some superfluous variable initializing and align some variable declarations to the most common pattern. Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 196 ++ 1 file changed, 128 insertions(+), 68 deletions(-) diff

[PATCH net-next v1 2/5] net: pktgen: enable 'param=value' parsing

2025-01-17 Thread Peter Seiderer
/pktgen/lo\@0 $ echo "min_pkt_size =999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size= 999" > /proc/net/pktgen/lo\@0 $ echo "min_pkt_size = 999" > /proc/net/pktgen/lo\@0 Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 1 + 1 file

[PATCH net-next v1 1/5] net: pktgen: replace ENOTSUPP with EOPNOTSUPP

2025-01-17 Thread Peter Seiderer
Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer --- net/core/pktgen.c

[PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c

2025-01-17 Thread Peter Seiderer
| r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); | ^ Signed-off-by: Peter Seiderer --- tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing

[PATCH v1 3/3] selftests: pid_namespace: add missing sys/mount.h include in pid_max.c

2025-01-15 Thread Peter Seiderer
"/", NULL, MS_PRIVATE | MS_REC, 0); | ^~~~~ Signed-off-by: Peter Seiderer --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_names

[PATCH v1 2/3] selftests: pidfd: add missing sys/ioctl.h include in pidfd_setns_test.c

2025-01-15 Thread Peter Seiderer
| self->child_pidfd_derived_nsfds[i] = ioctl(self->pidfd, info->pidfd_ioctl, 0); | ^ Signed-off-by: Peter Seiderer --- tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c

2025-01-15 Thread Peter Seiderer
| r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); | ^ Signed-off-by: Peter Seiderer --- tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2021-01-09 Thread Peter Seiderer
Hello Zhang, On Tue, 8 Dec 2020 20:45:23 +0800, Xiaohui Zhang wrote: > From: Zhang Xiaohui > > mwifiex_config_scan() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrar

[RFC v2] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-11 Thread Peter Seiderer
ti.com/lit/an/slaa408a/slaa408a.pdf Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - call mdelay only in case the reset gpio was toggled (suggested by Mark Brown) Note: This came up after the electronic departement took a deeper look at the i2c-bus/vcc/reset pins with a logic ana

Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-11 Thread Peter Seiderer
Hello Mark, On Mon, 11 Feb 2019 15:04:25 +, Mark Brown wrote: > On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote: > > > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct > > snd_soc_component *component) > > gpio_set_val

[RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-10 Thread Peter Seiderer
ti.com/lit/an/slaa408a/slaa408a.pdf Signed-off-by: Peter Seiderer --- Note: This came up after the electronic departement took a deeper look at the i2c-bus/vcc/reset pins with a logic analyzer and the documentation because of a vcc/reset timing problem (now fixed on custom board). Not 100% sure i

[PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-15 Thread Peter Seiderer
ail: v4l2-test-buffers.cpp(707): buf.check(q, last_seq) Signed-off-by: Peter Seiderer --- Changes in v2: - fill vb2_v4l2_buffer sequence entry in imx-ic-prpencvf too (suggested by Steve Longerbeam) Changes in v3: - add changelog (suggested by Greg Kroah-Hartman, Fabio Estevam and

[PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry

2018-03-15 Thread Peter Seiderer
Supported) Video Capture: Buffer: 0 Sequence: 0 Field: Any Timestamp: 58.383658s fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY Signed-off-by: Peter Seiderer --- Changes in v4: - new patch (put first because patch is needed to advance

[PATCH v3] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Peter Seiderer
Enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count = 141 - ts: 0:00:08.330177332 Signed-off-by: Peter Seiderer --- Changes in v2: - fill vb2_v4l2_buffer sequence entry in imx

[PATCH v2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 + drivers/staging/media/imx/imx-media-csi.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c index

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
hanges on mx-media-csi.c and imx-ic-prpencvf.c at once? Regards, Peter > > Steve > > > On 03/13/2018 01:00 PM, Peter Seiderer wrote: > > Signed-off-by: Peter Seiderer > > --- > > drivers/staging/media/imx/imx-media-csi.c | 5 + > > 1 file changed, 5

[PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-media-csi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5a195f80a24d..3a6a645b9dce 100644 --- a/drivers/staging/media/imx/imx

[PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support

2016-02-22 Thread Peter Seiderer
Regulator stuff and pin configuration copied from imx6qdl-nitrogen6_max.dtsi and checked against Boundary Devices linux kernel tree ([1]). [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.14.28_1.0.0_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi Signed-off-by: Peter Seiderer

Re: [PATCH v1] cifs: use server timestamp for ntlmv2 authentication

2015-09-21 Thread Peter Seiderer
Hello Steve, On Thu, 17 Sep 2015 22:49:54 -0500, Steve French wrote: > Corrected endian error and repushed > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=patch;h=79a5296f14b26ac8644239286ffd7a62dbbc385e > Many thanks for fixing the endianissue (next time I will try out your sparse compil

[PATCH v1] cifs: use server timestamp for ntlmv2 authentication

2015-09-17 Thread Peter Seiderer
server timestamp for the ntlmv2 authentication (as Windows 7 does). Signed-off-by: Peter Seiderer --- fs/cifs/cifsencrypt.c | 53 +-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index

[PATCH v3 1/2] ARM: dts: nitrogen6x: add CAN support

2015-06-02 Thread Peter Seiderer
/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi Signed-off-by: Peter Seiderer Tested-by: Eric Nelson --- v3: - use GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH (suggested by Eric Nelson) v2: - fix imx6qdl-nitrogen6x.dtsi url - use real PAD settings (suggested by

[PATCH v3 2/2] ARM: dts: sabrelite: add CAN support

2015-06-02 Thread Peter Seiderer
Signed-off-by: Peter Seiderer Tested-by: Eric Nelson --- v1: - do the same for the sabrelite board as suggested/tested by Eric Nelson --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl

Aw: Re: [PATCH v2] ARM: dts: nitrogen6x: add CAN support

2015-05-22 Thread Peter Seiderer
Hello Philipp, > Gesendet: Freitag, 22. Mai 2015 um 13:05 Uhr > Von: "Philipp Zabel" > An: "Peter Seiderer" > Cc: linux-kernel@vger.kernel.org, "Mark Rutland" , > devicet...@vger.kernel.org, "Russell King" , "Pawel > Moll" ,

[PATCH v2] ARM: dts: nitrogen6x: add CAN support

2015-05-21 Thread Peter Seiderer
/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi Signed-off-by: Peter Seiderer --- v2: - fix imx6qdl-nitrogen6x.dtsi url - use real PAD settings (suggested by Fabio Estevam) - remove _1 suffix (suggested by Shawn Guo) --- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32

Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support

2015-05-20 Thread Peter Seiderer
Hello Shawn, > Gesendet: Donnerstag, 21. Mai 2015 um 03:33 Uhr > Von: "Shawn Guo" > An: "Peter Seiderer" > Cc: linux-kernel@vger.kernel.org, devicet...@vger.kernel.org, > linux-arm-ker...@lists.infradead.org, "Russell King" > , "Kumar G

Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support

2015-05-20 Thread Peter Seiderer
Hello Fabio, > Gesendet: Donnerstag, 21. Mai 2015 um 00:26 Uhr > Von: "Fabio Estevam" > An: "Peter Seiderer" > Cc: linux-kernel , "Mark Rutland" > , "devicet...@vger.kernel.org" > , "Russell King" , "Pawel >

[PATCH v1] ARM: dts: nitrogen6x: add CAN support

2015-05-20 Thread Peter Seiderer
-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi Signed-off-by: Peter Seiderer --- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts