[PATCH net-next v5 2/8] net: pktgen: remove extra tmp variable (re-use len instead)

[Peter Seiderer]

Remove extra tmp variable in pktgen_if_write (re-use len instead).

Signed-off-by: Peter Seiderer <ps.rep...@gmx.net>
Reviewed-by: Simon Horman <ho...@kernel.org>
---
Changes v4 -> v5
  - split up patchset into part i/ii (suggested by Simon Horman)
  - add rev-by Simon Horman

Changes v3 -> v4
  - new patch (factored out of patch 'net: pktgen: fix access outside of user
    given buffer in pktgen_if_write()')
---
 net/core/pktgen.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 36ee0422c6cc..b9d8e33abe1e 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -970,7 +970,6 @@ static ssize_t pktgen_if_write(struct file *file,
        char name[16], valstr[32];
        unsigned long value = 0;
        char *pg_result = NULL;
-       int tmp = 0;
        char buf[128];
 
        pg_result = &(pkt_dev->result[0]);
@@ -981,12 +980,12 @@ static ssize_t pktgen_if_write(struct file *file,
        }
 
        max = count;
-       tmp = count_trail_chars(user_buffer, max);
-       if (tmp < 0) {
+       len = count_trail_chars(user_buffer, max);
+       if (len < 0) {
                pr_warn("illegal format\n");
-               return tmp;
+               return len;
        }
-       i = tmp;
+       i = len;
 
        /* Read variable name */
 
-- 
2.48.1