Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-11 Thread Nico Pache
On Fri, Apr 11, 2025 at 6:39 AM Richard Fitzgerald wrote: > > On 08/04/2025 10:25 am, Richard Fitzgerald wrote: > > On 19/03/2025 11:05 pm, Nico Pache wrote: > >> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > >> depend on if the feature

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-05 Thread Nico Pache
-trusted-artifacts/trusted-artifacts/1717840829/test_ppc64le/9419724210/artifacts/run.done.01/results_0001/console.log On Thu, Mar 20, 2025 at 11:33 AM Nico Pache wrote: > > On Thu, Mar 20, 2025 at 6:21 AM Richard Fitzgerald > wrote: > > > > On 19/3/25 23:11, Nico Pache wrote:

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-24 Thread Nico Pache
On Sat, Mar 22, 2025 at 4:11 AM Richard Fitzgerald wrote: > > On 20/3/25 17:35, Nico Pache wrote: > > Sorry links got mangled > > > Thanks. I'm on vacation right now but I'll take a look through > all those when I have time. Ok thanks! no rush, enjoy your vacatio

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-24 Thread Nico Pache
On Fri, Mar 21, 2025 at 9:51 AM Mark Brown wrote: > > On Fri, Mar 21, 2025 at 09:01:35AM -0600, Nico Pache wrote: > > On Fri, Mar 21, 2025 at 8:51 AM Mark Brown wrote: > > > > That user select should only be visible if KUnit is enabled though, > > > it re

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-21 Thread Nico Pache
On Fri, Mar 21, 2025 at 8:51 AM Mark Brown wrote: > > On Fri, Mar 21, 2025 at 05:37:50AM -0600, Nico Pache wrote: > > On Thu, Mar 20, 2025 at 4:49 PM Mark Brown wrote: > > > > Simply adding it to the all_tests.config will just result in it getting > > > turne

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-21 Thread Nico Pache
On Thu, Mar 20, 2025 at 4:49 PM Mark Brown wrote: > > On Thu, Mar 20, 2025 at 04:21:16PM -0600, Nico Pache wrote: > > On Thu, Mar 20, 2025 at 1:14 PM Mark Brown wrote: > > > On Wed, Mar 19, 2025 at 05:05:39PM -0600, Nico Pache wrote: > > > > > config FW_CS_D

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-20 Thread Nico Pache
On Thu, Mar 20, 2025 at 1:14 PM Mark Brown wrote: > > On Wed, Mar 19, 2025 at 05:05:39PM -0600, Nico Pache wrote: > > FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > > depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the > > de

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-20 Thread Nico Pache
On Thu, Mar 20, 2025 at 6:21 AM Richard Fitzgerald wrote: > > On 19/3/25 23:11, Nico Pache wrote: > > On Wed, Mar 19, 2025 at 5:05 PM Nico Pache wrote: > >> > >> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > >> depend on if the

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-19 Thread Nico Pache
On Wed, Mar 19, 2025 at 5:05 PM Nico Pache wrote: > > FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the > depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. A further note

[PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-19 Thread Nico Pache
t;) Signed-off-by: Nico Pache --- drivers/firmware/cirrus/Kconfig | 3 +-- tools/testing/kunit/configs/all_tests.config | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/cirrus/Kconfig b/drivers/firmware/cirrus/Kconfig index 0a883091259a..989568ab5

Re: [PATCH 2/2] selftests/mm: Allow tests to run with no huge pages support

2025-02-17 Thread Nico Pache
with the same issue when running selftests on smaller machines or 64k kernels. This is a nice addition. Reviewed-by: Nico Pache > --- > tools/testing/selftests/mm/run_vmtests.sh | 66 > --- > 1 file changed, 42 insertions(+), 24 deletions(-) > > diff --g

Re: [PATCH 1/2] selftests/mm: Fix check for running THP tests

2025-02-17 Thread Nico Pache
e > output of the first argument into the second. Instead use the shell's -o > operator. > > Fixes: b433ffa8dbac ("selftests: mm: perform some system cleanup before using > hugepages") > Signed-off-by: Mark Brown Ah I meant to use || which i believe also works in s

Re: distro support for CONFIG_KUNIT: [PATCH 0/3] bitmap: convert self-test to KUnit

2025-02-10 Thread Nico Pache
On Mon, Feb 10, 2025 at 12:46 PM David Hildenbrand wrote: > > On 10.02.25 20:35, John Hubbard wrote: > > On 2/9/25 11:54 PM, Geert Uytterhoeven wrote: > >> On Sat, 8 Feb 2025 at 18:53, Yury Norov wrote: > >>> On Fri, Feb 07, 2025 at 03:14:01PM -0500, Tamir Duberstein wrote: > On 7/27/24 12:3

[PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-14 Thread Nico Pache
/chained messages Nico Pache (6): kunit: ASoC: topology: adhear to KUNIT formatting standard kunit: software node: adhear to KUNIT formatting standard kunit: ext4: adhear to KUNIT formatting standard kunit: lib: adhear to KUNIT formatting standard kunit: mptcp: adhear to KUNIT formatting

[PATCH v2 4/6] kunit: lib: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
NIT standard. Fixes: 6d511020e13d (lib/test_bits.c: add tests of GENMASK) Fixes: d2585f5164c2 (lib: kunit: add bitfield test conversion to KUnit) Fixes: 33d599f05299 (lib/test_linear_ranges: add a test for the 'linear_ranges') Signed-off-by: Nico Pache --- lib/Kconfig.debug | 21 +--

[PATCH v2 2/6] kunit: software node: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Change CONFIG_KUNIT_DRIVER_PE_TEST to CONFIG_DRIVER_PE_KUNIT_TEST inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: aa811e3cecec (software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST) Signed-off-by: Nico Pache --- drivers/base/test/Kconfig | 2 +- drivers/base/test

[PATCH v2 6/6] m68k: update configs to match the proper KUNIT syntax

2021-04-14 Thread Nico Pache
No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- arch/m68k/configs/amiga_defconfig| 6 +++--- arch/m68k/configs/apollo_defconfig | 6 +++--- arch/m68k/configs/atari_defconfig| 6 +++--- arch/m68k/configs/bvme6000_defconfig | 6 +++--- arch/m68k/configs

[PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of SND_SOC_TOPOLOGY_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: d52bbf747cfa (ASoC: topology: KUnit: Add KUnit tests passing various...) Signed-off-by: Nico Pache --- sound/soc/Kconfig | 2 +- sound/soc/Makefile | 4 ++-

[PATCH v2 3/6] kunit: ext4: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of CONFIG_EXT4_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: 1cbeab1b242d (ext4: add kunit test for decoding extended timestamps) Signed-off-by: Nico Pache --- fs/ext4/.kunitconfig | 2 +- fs/ext4/Kconfig | 2 +- fs/ext

[PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: a00a582203db (mptcp: move crypto test to KUNIT) Signed-off-by: Nico Pache --- net/mptcp/Kconfig | 2 +- net/mptcp/Makefile | 2 +- net/mptcp/crypto.c | 2 +- net/mpt

[PATCH 2/2] m68k: update configs to match the proper KUNIT syntax

2021-04-13 Thread Nico Pache
No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- arch/m68k/configs/amiga_defconfig| 6 +++--- arch/m68k/configs/apollo_defconfig | 6 +++--- arch/m68k/configs/atari_defconfig| 6 +++--- arch/m68k/configs/bvme6000_defconfig | 6 +++--- arch/m68k/configs

[PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Nico Pache
` - Tests should end in KUNIT_TEST, some fixes have been applied to correct issues were KUNIT_TESTS is used or KUNIT is not mentioned. No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- drivers/base/test/Kconfig | 2 +- drivers/base/test/Makefile | 2 +- fs/ext4

[PATCH v2] Remove __init from padata_do_multithreaded and padata_mt_helper.

2020-07-02 Thread Nico Pache
Allow padata_do_multithreaded function to be called after bootstrap. v2: removed __init from padata_work_alloc_mt and padata_works_free Signed-off-by: Nico Pache --- include/linux/padata.h | 2 +- kernel/padata.c| 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH] Remove __init from padata_do_multithreaded and padata_mt_helper

2020-07-01 Thread Nico Pache
Allow padata_do_multithreaded function to be called after bootstrap. Signed-off-by: Nico Pache --- include/linux/padata.h | 2 +- kernel/padata.c| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index 7302efff5