velopers for further development,instead of
increasing
stack size to 16KB or spending time on debugging stack overflow issues.
PS: We have debugged and resolved stack overflow issue but we still implemented
this sol. to avoid
debugging such issues in future also it gives us flexibility for kernel
enhancement on ARM.
Thanks & Regards,
Vaneet Narang
oints we realised 12KB stack might be sufficient
for our system. Analyzing stack using stack tracer confirmed max stack
requirement.
This is still configurable, if some system has higher stack requirement then
user can
go with 16KB but there should be option to change it.
Regards,
Vaneet Narang
0d4c: e24cb004sub fp, ip, #4
c01f0d50: e24dd094sub sp, sp, #448; 0x1C0
Thanks & Regards,
Vaneet Narang
but we did this
as we normally follow this coding convention when defining structures or stack
variables.
Thanks & Regards,
Vaneet Narang
ntinue_internal)-> 136 -> 88
> (ZSTD_compressCCtx) -> 192 -> 64
> (zstd_compress) -> 144 -> 96
Regards,
Vaneet Narang
Move logical operator to previous line to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging
Swap the terms of comparisons whenever the constant comes first to get
rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
Remove unnecessary parentheses after 'address-of' operator to get rid of
checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8
Remove braces from single if statement to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Replace NULL comparisons in the file to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b
To avoid style issues, remove multiple blank lines.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index
it had some compilatin error.
Vatsala Narang (6):
staging: rtl8723bs: core: Remove blank line.
staging: rtl8723bs: core: Replace NULL comparisons.
staging: rtl8723bs: core: Remove unnecessary parentheses.
staging: rtl8723bs: core: Remove braces from single if statement.
staging
Moved logical operator to previous line to get rid of checkpatch
warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging
Remove braces from single if statement to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Swap the terms of comparisons whenever the constant comes first to get
rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
Remove unnecessary parentheses after 'address-of' operator to get rid of
checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8
Replace NULL comparisons in the file to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b
To avoid style issues, remove multiple blank lines.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index
Remove return in void function to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core
This series fix the following warnings:
-Remove multiple blank lines.
-Remove return in void function.
-Replace NULL comparison.
-Remove unnecessary parentheses.
-Remove braces from single if statement.
-Fix variable constant comparison.
-Move logical operator to previous line.
Vatsala Narang (7
Replace bit shifting on 1 with the BIT(x) macro.
Issue found using coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Avoid NULL comparison, compare using boolean operator.
Issue found using coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_io.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
This patch updates Kconfig with paragraph that describe config symbol
fully.Issue addressed by checkpatch.
Signed-off-by: Vatsala Narang
---
drivers/staging/iio/adc/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
Return value directly without saving it in a variable and remove that
variable.
Issue suggested by Coccinelle.
Signed-off-by: Vatsala Narang
---
Changes in v2:
-Change subject line and log message
-Remove respective unused variable
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835
Modify return statement and remove the respective assignment.
Issue found by Coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835
Replace explicitely with explicitly to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
Changes in v2:
-added this patch to patchset to fix spelling mistake.
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Change suggested by coccinelle.
Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:
@@
expression c;
@@
-(1 << c)
+BIT(c)
Signed-off-by: Vatsala Narang
---
Changes in v2:
-changed log message
-added space around '&' opreator and after 'if'
-added
Remove return in void function to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index
Challenge suggested by coccinelle.
Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:
@@
expression c;
@@
-(1 << c)
+BIT(c)
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
sole
log level handling.
Which can be done using dmesg as well.
For example:
dmesg -n 7
"Run some scenario to capture all the kernel logs"
dmesg -n 1
I may end up not getting all the logs if my console flush is slow &
dmesg -n 1 got excuted before flush .
Thanks & Regards,
Vaneet Narang
#define M2_MAX_LEN 8
#define M3_MIN_LEN 3
#define M3_MAX_LEN 33
#define M4_MIN_LEN 3
#define M4_MAX_LEN 9
#define M1_MARKER 0
#define M2_MARKER 64
#define M3_MARKER 32
#define M4_MARKER 16
Similarly for LZ4 Dyn, we have used 1 bit as a marker to determine offset
length.
Thanks & Regards,
Vaneet Narang
rcptInfo.txt
Description: Binary data
if (!__kernel_text_address(regs->ARM_pc))
>+ return 1;
>+
> trace->entries[trace->nr_entries++] = regs->ARM_pc;
Any Inputs or Comments on this patch to avoid storing user space entries
during unwind.
Regards,
Vaneet Narang
rcptInfo.txt
Description: Binary data
u think empty definition of in_irqentry_text() is not requited then we
will modify & resend the
patch.
Thanks & Regards,
Vaneet Narang
neet Narang
n to both
>LZ4 and LZ4_DYN decompression speed.
Since there is no backward compatibility of our solution with original LZ4 so we
are bit confused if we should make it as separate API to avoid overhead of
dynOffset
checks every where in the code and also to avoid changing prototype of exported
functions
LZ4_decompress/LZ4_compress OR we should keep these checks to avoid redundant
code.
Kindly suggest
Thanks & Regards,
Vaneet Narang
nk its useful, we can share scalable patch to configure below two
values based on
number of stack entries dynamically.
#define STACK_ALLOC_ORDER 2
#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)
Regards,
Vaneet Narang
0
__do_softirq+0xce/0x298
irq_exit+0xa3/0xb0
We have been getting similar kind of such entries and eventually
stackdepot reaches Max Cap. So we found this interface useful in debugging
stackdepot issue so shared in community.
Regards,
Vaneet Narang
thout breaking mpi_powm().
>Further, have you checked the caller to see if they do ever violate the
>constraints?
From caller side, only issue which i can think is passing 0 in as last valid
limb of mod. Is this any
constraint ?
Regards,
Vaneet Narang
depot_index gets a stable value after some time. (Tested on ARM)
>+ trace->nr_entries--;
>+
> hash = hash_stack(trace->entries, trace->nr_entries);
> bucket = &stack_table[hash & STACK_HASH_MASK];
>
>--
>1.9.1
Regards,
Vaneet Narang
l for kernel modules but our intent is to detect
memory allocated directly by kernel modules and not getting freed.
Regards,
Vaneet Narang
l 22MB modules are not penalised but without these changes once size of
modules
gets over 14MB PLT becomes must.
Regards,
Vaneet Narang
e added by compiler in modules before every memory access.
These are the functions which will do address sanity and detect errors.
Regards,
Vaneet Narang
times useful when uImage is already sanitized and some
corruption
is done by kernel modules by doing some direct memory access then both read /
write sanity of uImage
can be avoided.
> disabling reads, right?
> Disabling both certainly does not make sense.
Regards,
Vaneet Narang
dules for
making short calls.
So CONFIG_ARM_MODULE_PLTS is not required when modules
can be accomdated within 20MB.
>way, there is no need to update these defaults for everyone.
>
>> +#else
>> +#define MODULES_START MODULES_VADDR
Thanks & Regards,
Vaneet Narang
as size of last packet received on socket.
Kindly comment on the fix shared at following link.
http://www.spinics.net/lists/kernel/msg2184815.html
Thanks & Regards,
Vaneet Narang
re this is avoided or is there any way this
gets added to error
queue.
As per my understanding rmem_alloc gets increased only if packets gets added to
receive queue
or error queue. Is it any other queue which also changes rmem_alloc?
Thanks,
Vaneet Narang
.
EP-2DAD0AFA905A4ACB804C4F82A001242F
>
>Ok, I have to ask: what on Earth is this number and what does [EDT] mean?
This is auto generated from our editor. Kindly ignore its not relevant.
Please find reply inline.
>> >On Tue, May 12, 2015 at 02:12:54PM +0100, Vaneet Narang wrot
ar these slots or we should reinstall but if you think
reinstall has to be taken care by scheduler or debugger
then at least we should clear these slots.
Regards,
Vaneet Narang
EP-2DAD0AFA905A4ACB804C4F82A001242F
>On Tue, May 12, 2015 at 02:12:54PM +0100, Vaneet Narang wrote:
>> On Tue, May 12, 2015 at 12:48:13PM +0100, Maninder Singh wrote:
>> >> On ARM, when a watchpoint is registered using
>> >> register_wide_hw_breakpoint,
>>
s issue by using KPROBES (getting the instruction
>> executed and incrementing PC
>> to next instruction).
>>
>> Signed-off-by: Vaneet Narang
>> Signed-off-by: Maninder Singh
>> Reviewed-by: Amit Arora
>> Reviewed-by: Ajeet Yadav
>> ---
>> arc
Does anyone has any suggestions on fixing 'USB HC TakeOver failed!'
problem. thanks.
syslog
--
usb.c: registered new driver usbdevfs
usb.c: registered new driver hub
PCI: Setting latency timer of device 01:04.0 to 64
usb-ohci.c: USB OHCI at membase 0xc8914000, IRQ 8
usb-ohci.c: usb-01:04.0,
. If a device is not found by BIOS can it still be used?
. Why is the USB device getting IRQ 0?
. Why is the Firewire device 8020 unknown?
Attached is output of lspci, syslog, and output of lspci -vv.
Hoping I can get some help. Please CC me any suggestions. Thanks.
lspci
00:00.0 Host
53 matches
Mail list logo
