Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-22 Thread Michael Grzeschik
Hi Manish! On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver is also used to choose between PIPE clock coming from SerDes and the Su

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-10 Thread Michael Grzeschik
Adding Tinh Nguyen to CC: On Tue, Feb 09, 2021 at 09:02:00PM +0100, Michael Grzeschik wrote: Hi Manish, On Tue, Feb 09, 2021 at 06:01:58AM +, Manish Narani wrote: Hi Michael, -Original Message- From: Michael Grzeschik Sent: Tuesday, February 9, 2021 5:26 AM To: Manish Narani

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-09 Thread Michael Grzeschik
Hi Manish, On Tue, Feb 09, 2021 at 06:01:58AM +, Manish Narani wrote: Hi Michael, -Original Message- From: Michael Grzeschik Sent: Tuesday, February 9, 2021 5:26 AM To: Manish Narani Cc: devicet...@vger.kernel.org; p.za...@pengutronix.de; ba...@kernel.org; gre

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-08 Thread Michael Grzeschik
Hi Manish! On Thu, Jan 28, 2021 at 12:36:07AM +0100, Michael Grzeschik wrote: On Fri, Jan 22, 2021 at 02:34:52PM +0100, Michael Grzeschik wrote: On Fri, Jan 22, 2021 at 01:06:22PM +, Manish Narani wrote: Hi Michael, -Original Message- From: Michael Grzeschik Sent: Friday

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-27 Thread Michael Grzeschik
On Fri, Jan 22, 2021 at 02:34:52PM +0100, Michael Grzeschik wrote: On Fri, Jan 22, 2021 at 01:06:22PM +, Manish Narani wrote: Hi Michael, -Original Message- From: Michael Grzeschik Sent: Friday, January 22, 2021 1:39 PM To: Manish Narani Cc: devicet...@vger.kernel.org; ker

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-22 Thread Michael Grzeschik
On Fri, Jan 22, 2021 at 01:06:22PM +, Manish Narani wrote: Hi Michael, -Original Message- From: Michael Grzeschik Sent: Friday, January 22, 2021 1:39 PM To: Manish Narani Cc: devicet...@vger.kernel.org; ker...@pengutronix.de; ba...@kernel.org; gre...@linuxfoundation.org; linux

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-22 Thread Michael Grzeschik
Hello! On Mon, Jan 18, 2021 at 02:42:24PM +0100, Michael Grzeschik wrote: Hi! On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-19 Thread Michael Grzeschik
On Mon, Jan 18, 2021 at 05:24:38PM +0200, Felipe Balbi wrote: Hi, Michael Grzeschik writes: On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB

Re: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-18 Thread Michael Grzeschik
Hi! On Tue, Dec 15, 2020 at 12:24:51PM +0530, Manish Narani wrote: Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver is also used to choose between PIPE clock coming from SerDes and the Suspend C

Re: linux-next: Signed-off-by missing for commit in the imx-mxs tree

2019-06-24 Thread Michael Grzeschik
ot;) > > > > is missing a Signed-off-by from its author. > > Thanks for spotting it, Stephen. > > @Michael, would you please give your SoB? Otherwise, I will have to > back out the patch. Sure! Signed-off-by: Michael Grzeschik -- Pengutronix e.K.

[PATCH 0/3] Fix for drm_mode_config_cleanup issue

2019-04-02 Thread Michael Grzeschik
fixes the possible case of use after free by adding action functions to the devres cleanup path. So it will ensure the generic cleanup code will not use the already freed memory. Michael Grzeschik (3): ipuv3-crtc: add remove action for devres data ipuv3-ldb: add init list head on bind ipuv3-ldb:

[PATCH 3/3] ipuv3-ldb: add remove action for devres data

2019-04-02 Thread Michael Grzeschik
. This leads drm_encoder_cleanup try to clean already freed memory. We fix this issue by adding the devres action ipu_ldb_remove_head which will remove its head from the objects in ipu-drm-core which then never calls its destroy function anymore. Signed-off-by: Michael Grzeschik --- drivers/gpu/drm

[PATCH v4] usbip: dynamically allocate idev by nports found in sysfs

2018-05-25 Thread Michael Grzeschik
As the amount of available ports varies by the kernels build configuration. To remove the limitation of the fixed 128 ports we allocate the amount of idevs by using the number we get from the kernel. Signed-off-by: Michael Grzeschik --- v1 -> v2: - reworked memory allocation into one calloc c

Re: [PATCH v3] usbip: dynamically allocate idev by nports found in sysfs

2018-05-24 Thread Michael Grzeschik
On Wed, May 23, 2018 at 10:44:57AM -0600, Shuah Khan wrote: > On 05/23/2018 03:22 AM, Michael Grzeschik wrote: > > As the amount of available ports varies by the kernels build > > configuration. To remove the limitation of the fixed 128 ports > > we allocate the amount of idev

Re: [PATCH v3] usbip: dynamically allocate idev by nports found in sysfs

2018-05-23 Thread Michael Grzeschik
On Wed, May 23, 2018 at 10:44:57AM -0600, Shuah Khan wrote: > On 05/23/2018 03:22 AM, Michael Grzeschik wrote: > > As the amount of available ports varies by the kernels build > > configuration. To remove the limitation of the fixed 128 ports > > we allocate the amount of idev

[PATCH v3] usbip: dynamically allocate idev by nports found in sysfs

2018-05-23 Thread Michael Grzeschik
As the amount of available ports varies by the kernels build configuration. To remove the limitation of the fixed 128 ports we allocate the amount of idevs by using the number we get from the kernel. Signed-off-by: Michael Grzeschik --- v1 -> v2: - reworked memory allocation into one calloc c

[PATCH v2] usbip: dynamically allocate idev by nports found in sysfs

2018-05-22 Thread Michael Grzeschik
As the amount of available ports varies by the kernels build configuration. To remove the limitation of the fixed 128 ports we allocate the amount of idevs by using the number we get from the kernel. Signed-off-by: Michael Grzeschik --- v1 -> v2: - reworked memory allocation into one calloc c

[PATCH] usbip: dynamically allocate idev by nports found in sysfs

2018-05-18 Thread Michael Grzeschik
As the amount of available ports varies by the kernels build configuration. To remove the limitation of the fixed 128 ports we allocate the amount of idevs by using the number we get from the kernel. Signed-off-by: Michael Grzeschik --- tools/usb/usbip/libsrc/vhci_driver.c | 11

[PATCH] gpu: ipu-csi: add rgb/bgr888 24bit support to mbus_code_to_bus_cfg

2018-05-02 Thread Michael Grzeschik
The 24bit RGB format configuration is currently missing, we add it now. Signed-off-by: Michael Grzeschik --- drivers/gpu/ipu-v3/ipu-csi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c index caa05b0702e16..1a0ee65fd4859

Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-24 Thread Michael Grzeschik
On Wed, Jan 24, 2018 at 10:03:33AM +0100, Michael Grzeschik wrote: > On Tue, Jan 23, 2018 at 10:22:54AM -0800, Guenter Roeck wrote: > > On Tue, Jan 23, 2018 at 01:18:01PM +0100, Michael Grzeschik wrote: > > > We add support for the ISL1219 chip that got an integrated tamp

Re: [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-24 Thread Michael Grzeschik
On Tue, Jan 23, 2018 at 10:22:54AM -0800, Guenter Roeck wrote: > On Tue, Jan 23, 2018 at 01:18:01PM +0100, Michael Grzeschik wrote: > > We add support for the ISL1219 chip that got an integrated tamper > > detection function. This patch implements the feature by using an hwmo

[PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection

2018-01-23 Thread Michael Grzeschik
. The devicetree documentation for the ISL1219 device tree binding is added with an short example. Signed-off-by: Michael Grzeschik Signed-off-by: Denis Osterland --- .../rtc/{intersil,isl1208.txt => isil,isl1208.txt} | 18 +- Documentation/hwmon/sysfs-interface| 7 + driv

[PATCH 2/4] rtc: isl1208: Add device tree binding documentation

2018-01-23 Thread Michael Grzeschik
From: Denis Osterland Wrote documentation for ISL1208, ISL1218 device tree binding with short examples. Signed-off-by: Denis Osterland Signed-off-by: Michael Grzeschik --- .../devicetree/bindings/rtc/intersil,isl1208.txt | 35 ++ 1 file changed, 35 insertions(+) create

[PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-01-23 Thread Michael Grzeschik
ient, ISL1208_REG_SR, 0); which clears all flags in SR. Add an additional read of SR, to have value of SR in sr again. Signed-off-by: Denis Osterland Signed-off-by: Michael Grzeschik --- drivers/rtc/rtc-isl1208.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-isl1208.c b/dri

[PATCH 0/4] rtc: isl1208: fixes, documentation and isl1219 support

2018-01-23 Thread Michael Grzeschik
via hwmon including the new intrusion[0-*]_timestamp interface. Denis Osterland (2): rtc: isl1208: Fix unintended clear of SR bits rtc: isl1208: Add device tree binding documentation Michael Grzeschik (2): rtc: isl1208: enable interrupt after context preparation rtc: isl1208: add support

[PATCH 3/4] rtc: isl1208: enable interrupt after context preparation

2018-01-23 Thread Michael Grzeschik
The interrupt handler got enabled very early. If the interrupt cause is triggering immediately before the context is fully prepared. This can lead to undefined behaviour. Therefor we move the interrupt enable code to the end of the probe function. Signed-off-by: Michael Grzeschik Signed-off-by

Re: [PATCH v2] regmap: irq: allow different device for irq chip and regmap

2017-07-05 Thread Michael Grzeschik
On Tue, Jul 04, 2017 at 11:44:49AM +0100, Mark Brown wrote: > On Fri, Jun 30, 2017 at 03:33:27PM +0200, Michael Grzeschik wrote: > > On Fri, Jun 23, 2017 at 01:00:43PM +0100, Mark Brown wrote: > > > > syscon is one potential thing here but it seems odd for the sort of >

Re: [PATCH v2] regmap: irq: allow different device for irq chip and regmap

2017-06-30 Thread Michael Grzeschik
On Fri, Jun 23, 2017 at 01:00:43PM +0100, Mark Brown wrote: > On Thu, Jun 22, 2017 at 01:03:20PM +0200, Michael Grzeschik wrote: > > > If the irq chip device is using the regmap of its parent device or > > a syscon regmap that doesn't have an associated device at all,

Re: [PATCH] arcnet: fix spelling mistake "Ackknowledge" -> "Acknowledge"

2017-06-26 Thread Michael Grzeschik
On Sun, Jun 25, 2017 at 10:15:06PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in arc_printk message > > Signed-off-by: Colin Ian King > --- > drivers/net/arcnet/capmode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

[PATCH v2] regmap: irq: add chip option mask_writeonly

2017-06-23 Thread Michael Grzeschik
Some irq controllers have writeonly/multipurpose register layouts. In those cases we read invalid data back. Here we add the option mask_writeonly as masking option. Signed-off-by: Michael Grzeschik --- v1 -> v2: - rebased on regmap/for-next - removed unneeded extra empty lines f

[PATCH v2] regmap: irq: allow different device for irq chip and regmap

2017-06-22 Thread Michael Grzeschik
egmap. Signed-off-by: Philipp Zabel Signed-off-by: Michael Grzeschik --- v1 -> v2: Added my own missing Signed-off-by. drivers/base/regmap/regmap-irq.c | 93 +--- include/linux/regmap.h | 4 ++ 2 files changed, 62 insertions(+), 35 deletions(

[PATCH] regmap: irq: add chip option mask_writeonly

2017-06-22 Thread Michael Grzeschik
Some irq controllers have writeonly/multipurpose register layouts. In those cases we read invalid data back. Here we add the option mask_writeonly as masking option. Signed-off-by: Michael Grzeschik --- drivers/base/regmap/regmap-irq.c | 43 ++-- include

[PATCH] regmap: irq: allow different device for irq chip and regmap

2017-06-22 Thread Michael Grzeschik
From: Philipp Zabel If the irq chip device is using the regmap of its parent device or a syscon regmap that doesn't have an associated device at all, allow the driver to provide its own device. That makes it possible to reference the irq controller from other devices running on the same regmap.

Re: [PATCH 2/5] arcnet: com90xx: add __init attribute

2016-04-18 Thread Michael Grzeschik
called from any other function. > > Signed-off-by: Julia Lawall > Acked-by: Michael Grzeschik > --- > drivers/net/arcnet/com90xx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/arcnet/com90xx.c b/drivers/net/arcnet/com90xx.c &

[PATCH v3] can: c_can: add xceiver enable/disable support

2016-01-21 Thread Michael Grzeschik
This patch adds support to enable and disable the xceiver in case it's switchable by the regulator framework. Signed-off-by: Michael Grzeschik --- v1 -> v2: - always returning PTR_ERR in case devm_regulator_get fails - removed inline wrapper functions with checks for xceiver == NULL

Re: [PATCH v2] can: c_can: add xceiver enable/disable support

2016-01-20 Thread Michael Grzeschik
Hi, On Wed, Jan 20, 2016 at 05:19:18PM +0100, Bjørn Mork wrote: > Michael Grzeschik writes: > > > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) > > */ > > pinctrl_pm_select_sleep_state(dev->dev.parent); > > > > + priv

[PATCH][RESEND] MAINTAINERS: add arcnet and take maintainership

2015-09-17 Thread Michael Grzeschik
Add entry for arcnet to MAINTAINERS file and add myself as the maintainer of the subsystem. Signed-off-by: Michael Grzeschik Cc: da...@davemloft.net Cc: j...@perches.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab7..0a015f7

[PATCH][RESEND] ARCNET: fix hard_header_len limit

2015-09-17 Thread Michael Grzeschik
well include short (or even no?) soft headers. For this reason only use arc_hardware instead of archdr to determine the hard_header_len for an arcnet device. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-09-16 Thread Michael Grzeschik
On Wed, Aug 05, 2015 at 05:34:51PM +0200, Michael Grzeschik wrote: > On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > > From: Michael Grzeschik > > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > > > The commit <9c7077622dd9> ("packet: make pac

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-08-05 Thread Michael Grzeschik
On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > From: Michael Grzeschik > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > The commit <9c7077622dd9> ("packet: make packet_snd fail on len smaller > > than l2 header") adds the check for minimum

[PATCH] ARCNET: fix hard_header_len limit

2015-07-30 Thread Michael Grzeschik
eof(arc_hardware). Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 10f71c73..816d0e9 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net

[PATCH] MAINTAINERS: add arcnet and take maintainership

2015-07-30 Thread Michael Grzeschik
Add entry for arcnet to MAINTAINERS file and add myself as the maintainer of the subsystem. Signed-off-by: Michael Grzeschik Cc: da...@davemloft.net Cc: j...@perches.com --- As I have a test coverage of com20020 based arcnet systems I would like to take the responsibility of maintaining the

Re: [PATCH 00/21] ARCNET: Defibrillation

2015-05-05 Thread Michael Grzeschik
Hi, and sorry for the delay. On Wed, Apr 29, 2015 at 08:49:25PM -0700, Joe Perches wrote: > On Mon, 2015-04-27 at 16:57 +0200, Michael Grzeschik wrote: > > Hi! > > > > On Fri, Apr 24, 2015 at 11:58:53PM -0400, David Miller wrote: > > > From: Marc Kleine-Budde >

Re: [PATCH 00/21] ARCNET: Defibrillation

2015-04-27 Thread Michael Grzeschik
Hi! On Fri, Apr 24, 2015 at 11:58:53PM -0400, David Miller wrote: > From: Marc Kleine-Budde > Date: Fri, 24 Apr 2015 23:14:41 +0200 > > > On 04/24/2015 08:47 PM, Joe Perches wrote: > >> On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: > >>> Hi

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-27 Thread Michael Grzeschik
On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote: > On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: > > The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK > > and ADIAGSTATUS are unnecessary indirections to the use of registers. > &g

[PATCH 19/21] ARCNET: com20020: add enable and disable device on open/close

2015-04-24 Thread Michael Grzeschik
This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

[PATCH 01/21] com20020-pci: add dev_port for udev handling

2015-04-24 Thread Michael Grzeschik
This patch sets the dev_port according to the index of the card. This can be used by udev to name the ports in userspace. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net

[PATCH 02/21] ARCNET: fix hard_header_len limit

2015-04-24 Thread Michael Grzeschik
eof(arc_hardware). Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 10f71c73..816d0e9 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net

[PATCH 04/21] ARCNET: whitespace, tab and codingstyle fixes

2015-04-24 Thread Michael Grzeschik
This patch removes trailing whitespaces in the whole the ARCNET layer. It also replaces the use of space with tabs and changes fixes the codingstyle on those lines. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arc-rawmode.c | 4 +- drivers/net/arcnet/arc-rimi.c | 2

[PATCH 10/21] ARCNET: com20020: fix ioaddr prefixes

2015-04-24 Thread Michael Grzeschik
This patch removes the use of the variable ioaddr in the macros and uses it directly in the calling functions. This improves the readability of the code and changes the macros to be used as offsets. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-isa.c | 2 +- drivers/net

[PATCH 15/21] ARCNET: capmode: remove extra function and use C99 in struct

2015-04-24 Thread Michael Grzeschik
This patch cleans the capmode protocol module. It removes the obsolete function arcnet_cap_init and uses the C99 struct definition. It also replaces printk with pr_info. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/capmode.c | 28 +++- 1 file changed, 11

[PATCH 16/21] ARCNET: capmode: move dev_free_skb to its only user

2015-04-24 Thread Michael Grzeschik
The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/arcnet

[PATCH 21/21] ARCNET: com20020-pci: add rotary index support

2015-04-24 Thread Michael Grzeschik
The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 28 include/linux

[PATCH 08/21] ARCNET: com90io: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com90io.c | 36 +--- 1 file

[PATCH 03/21] ARCNET: capmode: fix transfer length

2015-04-24 Thread Michael Grzeschik
ket lengths; 256 byte packets were being received as 257 bytes packets. prepare_tx(): - Fixed error in transmit length calcs; 257 byte packets were being transmitted as 260 byte packets. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/capmode.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 14/21] ARCNET: arc-rawmode: reorder module functions

2015-04-24 Thread Michael Grzeschik
This patch moves the module_init and module_exit patches to the end of the file. It also replaces the printk with pr_info. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arc-rawmode.c | 87 ++-- 1 file changed, 38 insertions(+), 49 deletions(-) diff

[PATCH 00/21] ARCNET: Defibrillation

2015-04-24 Thread Michael Grzeschik
unloading of the com20020 card. Cheers, Michael Michael Grzeschik (21): com20020-pci: add dev_port for udev handling ARCNET: fix hard_header_len limit ARCNET: capmode: fix transfer length ARCNET: whitespace, tab and codingstyle fixes ARCNET: remove unneeded macros ARCNET: com20020

[PATCH 09/21] ARCNET: com90xx: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com90xx.c | 35 +-- 1 file

[PATCH 17/21] ARCNET: com20020: replace magic numbers with readable macros

2015-04-24 Thread Michael Grzeschik
This patch replaces all magic numbers in the driver with proper named macros. For the case of XTOcfg and STARTIOcmd it introduces the new macros. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020.c | 21 +++-- include/linux/arcdevice.h | 1 + include/linux

[PATCH 20/21] ARCNET: com20020-pci: reformat structs to C99 format

2015-04-24 Thread Michael Grzeschik
This patch changes the macro definitions to match the C99 formating. This improves the readability. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/net/arcnet

[PATCH 13/21] ARCNET: com90xx: fix ioaddr prefixes

2015-04-24 Thread Michael Grzeschik
This patch removes the use of the variable ioaddr in the macros and uses it directly in the calling functions. This improves the readability of the code and changes the macros to be used as offsets. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com90xx.c | 52

[PATCH 18/21] ARCNET: com20020: remove obsolete BUS_ALIGN offset factor

2015-04-24 Thread Michael Grzeschik
This patch removes the obsolete macro BUS_ALIGN as the kernel option CONFIG_SA1100_CT6001 is not longer available. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020.c | 4 ++-- include/linux/com20020.h | 27 ++- 2 files changed, 12 insertions(+), 19

[PATCH 07/21] ARCNET: rimi: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arc-rimi.c | 24 +++- 1 file changed, 7

[PATCH 12/21] ARCNET: com90io: fix ioaddr prefixes

2015-04-24 Thread Michael Grzeschik
This patch removes the use of the variable ioaddr in the macros and uses it directly in the calling functions. This improves the readability of the code and changes the macros to be used as offsets. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com90io.c | 86

[PATCH 11/21] ARCNET: rimi: fix ioaddr prefixes

2015-04-24 Thread Michael Grzeschik
This patch removes the use of the variable ioaddr in the macros and uses it directly in the calling functions. This improves the readability of the code and changes the macros to be used as offsets. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arc-rimi.c | 30

[PATCH 05/21] ARCNET: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The simple macros ARCRESET, ACOMMAND, ASTATUS, AINTMASK are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 68

[PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-24 Thread Michael Grzeschik
The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and improves the readability of the code. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-isa.c | 2 +- drivers

[PATCH] com20020-pci: add support for eae single card

2015-02-13 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 945f532..96edc13 100644 --- a/drivers/net/arcnet/com20020

[PATCH v2 4/5] ARCNET: add support for multi interfaces on com20020

2014-09-29 Thread Michael Grzeschik
The com20020-pci driver is currently designed to instance one netdev with one pci device. This patch adds support to instance many cards with one pci device, depending on the device data in the private data. Signed-off-by: Michael Grzeschik --- v1 -> v2: fixed build of com20020_cs by us

[PATCH v2 3/5] ARCNET: add com20020 PCI IDs with metadata

2014-09-29 Thread Michael Grzeschik
This patch adds metadata for the com20020 to prepare for devices with multiple io address areas with multi card interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 216 -- include/linux/com20020.h | 16 +++ 2 files

[PATCH v2 2/5] ARCNET: add com20020_set_hwddr to change address

2014-09-29 Thread Michael Grzeschik
This patch adds com20020_set_hwaddr to make it possible to change the hwaddr on runtime. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index

[PATCH v2 0/5] ARCNET: add support for EAE multi interfac card

2014-09-29 Thread Michael Grzeschik
Hello, this series adds support for the PLX Bridge based multi interface pci cards and adds support to change device address on com200xx chips during runtime. This series is based on v3.17-rc7. It is fixed for build against com20020_cs. Thanks, Michael Michael Grzeschik (5): ARCNET: return

[PATCH v2 1/5] ARCNET: return IRQ_NONE if the interface isn't running

2014-09-29 Thread Michael Grzeschik
The interrupt handler needs to return IRQ_NONE in case two devices are used with the shared interrupt handler. Otherwise it could steal interrupts from the other interface. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 5/5] ARCNET: enable eae arcnet card support

2014-09-29 Thread Michael Grzeschik
This patch adds support for the EAE arcnet cards which has two Interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index

Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card

2014-09-29 Thread Michael Grzeschik
On Sun, Sep 28, 2014 at 05:01:50PM -0400, David Miller wrote: > From: David Miller > Date: Sun, 28 Sep 2014 16:44:21 -0400 (EDT) > > > From: Michael Grzeschik > > Date: Wed, 24 Sep 2014 15:41:48 +0200 > > > >> this series adds support for the PLX Bridge base

[PATCH 4/5] ARCNET: add support for multi interfaces on com20020

2014-09-24 Thread Michael Grzeschik
The com20020-pci driver is currently designed to instance one netdev with one pci device. This patch adds support to instance many cards with one pci device, depending on the device data in the private data. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 149

[PATCH 2/5] ARCNET: add com20020_set_hwddr to change address

2014-09-24 Thread Michael Grzeschik
This patch adds com20020_set_hwaddr to make it possible to change the hwaddr on runtime. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index

[PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running

2014-09-24 Thread Michael Grzeschik
The interrupt handler needs to return IRQ_NONE in case two devices are used with the shared interrupt handler. Otherwise it could steal interrupts from the other interface. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 5/5] ARCNET: enable eae arcnet card support

2014-09-24 Thread Michael Grzeschik
This patch adds support for the EAE arcnet cards which has two Interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index

[PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata

2014-09-24 Thread Michael Grzeschik
This patch adds metadata for the com20020 to prepare for devices with multiple io address areas with multi card interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 216 -- include/linux/com20020.h | 16 +++ 2 files

[PATCH 0/5] ARCNET: add support for EAE multi interfac card

2014-09-24 Thread Michael Grzeschik
Hello, this series adds support for the PLX Bridge based multi interface pci cards and adds support to change device address on com200xx chips during runtime. This series is based on v3.17-rc6. Thanks, Michael Michael Grzeschik (5): ARCNET: return IRQ_NONE if the interface isn't ru

Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card

2014-09-24 Thread Michael Grzeschik
Hi, On Wed, Sep 24, 2014 at 01:01:58PM +0200, Michael Grzeschik wrote: > This series adds support for the PLX bridge based multi interface > pci cards and adds support to change device address on com200xx chips > during runtime. > > Thanks, > Michael > > Michael G

[PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata

2014-09-24 Thread Michael Grzeschik
This patch adds metadata for the com20020 to prepare for devices with multiple io address areas with multi card interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 216 -- include/linux/com20020.h | 16 +++ 2 files

[PATCH 0/5] ARCNET: add support for EAE multi interfac card

2014-09-24 Thread Michael Grzeschik
This series adds support for the PLX bridge based multi interface pci cards and adds support to change device address on com200xx chips during runtime. Thanks, Michael Michael Grzeschik (5): ARCNET: return IRQ_NONE if the interface isn't running ARCNET: add com20020_set_hwddr to c

[PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running

2014-09-24 Thread Michael Grzeschik
The interrupt handler needs to return IRQ_NONE in case two devices are used with the shared interrupt handler. Otherwise it could steal interrupts from the other interface. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/5] ARCNET: add com20020_set_hwddr to change address

2014-09-24 Thread Michael Grzeschik
This patch adds com20020_set_hwaddr to make it possible to change the hwaddr on runtime. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index

[PATCH 4/5] ARCNET: add support for multi interfaces on com20020

2014-09-24 Thread Michael Grzeschik
The com20020-pci driver is currently designed to instance one netdev with one pci device. This patch adds support to instance many cards with one pci device, depending on the device data in the private data. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 149

[PATCH 5/5] ARCNET: enable eae arcnet card support

2014-09-24 Thread Michael Grzeschik
This patch adds support for the EAE arcnet cards which has two Interfaces. Signed-off-by: Michael Grzeschik --- drivers/net/arcnet/com20020-pci.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-22 Thread Michael Grzeschik
Hi Brian, On Mon, Jul 14, 2014 at 12:19:47PM -0700, Brian Norris wrote: > Hi Michael, > > On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > > The current approach of the read_page function is to iterate over all > > subpages and call the correct_data funct

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-14 Thread Michael Grzeschik
@David: Ping! Some comments on this patch would probably help to get it mainline. :) Regards, Michael On Sat, Jul 05, 2014 at 04:45:21PM +0200, Michael Grzeschik wrote: > Ping! > > On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > > The current approach o

Re: [PATH v2] mxc_nand: use our own read_page function

2014-07-05 Thread Michael Grzeschik
Ping! On Fri, Jun 27, 2014 at 12:38:44PM +0200, Michael Grzeschik wrote: > The current approach of the read_page function is to iterate over all > subpages and call the correct_data function. The correct_data function > currently does the same. It iterates over all subpages and c

Re: [PATCH v2 2/2] usb: chipidea: Add support for zynq usb host and device controller

2014-06-27 Thread Michael Grzeschik
Hi, On Fri, Jun 27, 2014 at 04:53:53PM +0530, Punnaiah Choudary Kalluri wrote: > Zynq soc uses Chipidea/Synopsys usb IP core(CI13612). This patch adds > necessary glue to allow the chipidea driver to work on zynq soc. > Did you see the currently discussed patches for the generic chipidea glue?

[PATH v2] mxc_nand: use our own read_page function

2014-06-27 Thread Michael Grzeschik
miscalculations. This patch changes the driver to use its own read_page function in which we call the correct_data function only once per page. With that we do the failure and correct statistics counting inside this function. Signed-off-by: Michael Grzeschik --- fixed printk to pr_debug drivers/mtd

Re: [PATCH 2/2] mxc_nand: use our own read_page function

2014-06-27 Thread Michael Grzeschik
On Thu, Jun 26, 2014 at 10:42:48PM +0200, Michael Grzeschik wrote: > The current approach of the read_page function is to iterate over all > subpages and call the correct_data function. The correct_data function > currently does the same. It iterates over all subpages and checks for >

[PATCH 1/2] mxc_nand: fix err_limit and err_mask

2014-06-26 Thread Michael Grzeschik
This patch fixes the error detection limits for the used eccsize of the 1, 4 and 8 bit eccmode. Signed-off-by: Michael Grzeschik --- drivers/mtd/nand/mxc_nand.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand

[PATCH 2/2] mxc_nand: use our own read_page function

2014-06-26 Thread Michael Grzeschik
miscalculations. This patch changes the driver to use its own read_page function in which we call the correct_data function only once per page. With that we do the failure and correct statistics counting inside this function. Signed-off-by: Michael Grzeschik --- drivers/mtd/nand/mxc_nand.c | 73

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-12-02 Thread Michael Grzeschik
On Mon, Dec 02, 2013 at 03:11:03PM +0400, Alexander Shiyan wrote: > > > > Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones : > > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > > If this driver being loaded f

Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init

2013-11-30 Thread Michael Grzeschik
On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > If this driver being loaded from devicetree, the pdata is NULL. > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > "fsl,mc13xxx-uses-touch" properties is specified. > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab:

Re: [PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Michael Grzeschik
On Fri, Nov 29, 2013 at 03:19:45PM +0800, Chris Ruehl wrote: > usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag > > * init the sts flag to 0 (missed) > * set the sts flag only if not 0 > > Signed-off-by: Chris Ruehl > --- > drivers/usb/chipidea/core.c |8 ++-- > 1 f

Re: [PATCH] mfd: syscon: add inline nop functions to compile without option

2013-11-29 Thread Michael Grzeschik
Hi, On Fri, Nov 29, 2013 at 04:15:56PM +0100, Michael Grzeschik wrote: > The syscon interface can be used in different drivers to reach registers > of other register range via phandle. The exported functions can only be > used if the syscon interface is enabled. This patch fixes this by

  1   2   >