On Thu, 2021-03-25 at 11:14 -0400, Mike Snitzer wrote:
> On Wed, Mar 24 2021 at 9:21pm -0400,
> Zhiqiang Liu wrote:
>
> >
> >
> > On 2021/3/22 22:22, Mike Snitzer wrote:
> > > On Mon, Mar 22 2021 at 4:11am -0400,
> > > Christoph Hellwig wrote:
> > >
> > > > On Sat, Mar 20, 2021 at 03:19:23P
not enabling the
> uevents at all.
>
> Signed-off-by: Daniel Wagner
Reviewed-by: Martin Wilck
On Wed, 2021-03-03 at 18:12 +0100, Daniel Wagner wrote:
> register_disk() suppress uevents for devices with the GENHD_FL_HIDDEN
> but enables uevents at the end again in order to announce disk after
> possible partitions are created.
>
> When the device is removed the uevents are still on and user
On Wed, 2021-02-10 at 22:08 +, Pearson, Robert B wrote:
> Looks perfect. Thanks.
+1
Thanks everyone.
qla2xxx: Handle incorrect entry_type entries
>
> drivers/scsi/qla2xxx/qla_gbl.h| 3 +-
> drivers/scsi/qla2xxx/qla_init.c | 10 ++
> drivers/scsi/qla2xxx/qla_inline.h | 5 +++
> drivers/scsi/qla2xxx/qla_isr.c| 74 +++
>
> drivers/scsi/qla2xxx/qla_mr.c | 9 ++---
> 5 files changed, 62 insertions(+), 39 deletions(-)
>
For the set:
Reviewed-by: Martin Wilck
On Thu, 2020-08-27 at 13:46 +0200, Daniel Wagner wrote:
> On Thu, Aug 27, 2020 at 12:17:13PM +0200, Martin Wilck wrote:
> > Should we perhaps log an error message when we detect a mismatch
> > between sp->type and entry_type?
>
> Sure can do, but does it really help? N
On Thu, 2020-08-27 at 11:58 +0200, Daniel Wagner wrote:
> It was observed on an ISP8324 16Gb HBA with fw=8.08.203 (d0d5) that
> pkt->entry_type was MBX_IOCB_TYPE/0x39 with an sp->type SRB_SCSI_CMD
> which is invalid and should not be possible.
>
> A careful code review of the crash dump didn't rev
On Thu, 2020-08-27 at 11:58 +0200, Daniel Wagner wrote:
> Reset ->done and ->free when releasing the srb. There is a hidden
> use-after-free bug in the driver which corrupts the srb memory pool
> which originates from the cleanup callbacks. By explicitly resetting
> the callbacks to NULL, we workar
-optimized paths will cause
> the
> result from nvme_round_robin_path() to be ignored for non-optimized
> paths.
>
> Fixes: 75c10e732724 ("nvme-multipath: round-robin I/O policy")
> Signed-off-by: Martin Wilck
> Signed-off-by: Hannes Reinecke
> Reviewed-by: Sagi Gri
On Wed, 2019-09-18 at 22:06 +0530, Allen Pais wrote:
> alloc_workqueue is not checked for errors and as a result,
> a potential NULL dereference could occur.
>
> Signed-off-by: Allen Pais
> ---
> drivers/scsi/qla2xxx/qla_os.c | 4
> 1 file changed, 4 insertions(+)
Hello Milan,
On Mon, 2019-09-30 at 14:35 +0530, Milan P. Gandhi wrote:
> On 9/30/19 2:12 PM, Martin Wilck wrote:
> > Wrt the enablement of the option on highly loaded systems, I'm not
> > sure
> > I understand. You need to enable SCSI logging anyway, don't you?
&
On Fri, 2019-09-27 at 13:45 -0400, Laurence Oberman wrote:
>
> Hi Martin
>
> Agreed about log extraction, but turning that on with a busy workload
> in a production environment is not practical. We cant do it with
> systems with 1000's of luns and 1000's of IOPS/sec.
> Also second resolution is g
On Mon, 2019-09-23 at 11:31 +0530, Milan P. Gandhi wrote:
> Couple of users had requested to print the SCSI command age along
> with command failure errors. This is a small change, but allows
> users to get more important information about the command that was
> failed, it would help the users
On Tue, 2019-08-06 at 00:11 +0530, Saurav Girepunje wrote:
> According to doc: "Note: Use kmemdup_nul() instead if the size
> is known exactly." So we should use kmemdup_nul() here instead of
> kstrndup().
>
> Signed-off-by: Saurav Girepunje
> ---
Reviewed-by: Martin Wilck
On Mon, 2019-04-15 at 06:48 -0700, Bart Van Assche wrote:
> On 4/14/19 10:59 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next merge of the scsi tree got a conflict in:
> >
> > drivers/scsi/sd.c
> >
> > between commit:
> >
> > c92e2f04b359 ("block: disk_events: introduce ev
On Thu, 2018-10-25 at 12:04 -0400, J. Bruce Fields wrote:
> On Wed, Oct 24, 2018 at 09:43:54AM +1100, NeilBrown wrote:
> > This took longer that I had wanted, due to various reasons - sorry.
> > And I'm now posting it in a merge window, which is not ideal. I
> > don't
> > expect it to be included
On Mon, 2018-08-20 at 16:02 -0400, J. Bruce Fields wrote:
> On Mon, Aug 20, 2018 at 01:02:21PM +0200, Martin Wilck wrote:
> > On Wed, 2018-08-08 at 14:29 -0400, J. Bruce Fields wrote:
> > > On Wed, Aug 08, 2018 at 12:47:22PM -0400, Jeff Layton wrote:
> > > > On
On Wed, 2018-08-08 at 14:29 -0400, J. Bruce Fields wrote:
> On Wed, Aug 08, 2018 at 12:47:22PM -0400, Jeff Layton wrote:
> > On Wed, 2018-08-08 at 11:51 +1000, NeilBrown wrote:
> > > If you have a many-core machine, and have many threads all
> > > wanting to
> > > briefly lock a give file (udev is
and applied version I think I caught them all).
Regards,
Martin
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
On Tue, 2018-04-17 at 17:07 -0700, Linus Torvalds wrote:
> On Tue, Apr 17, 2018 at 4:35 PM, Martin Wilck
> wrote:
> > Sparse emits errors about ilog2() in array indices because of the
> > use of
> > __ilog2_32() and __ilog2_64(),
>
> If sparse warns about it, then p
"maybe_retry" logic in scsi_decide_disposition); otherwise dm-multipath
might initiate a failover from a healthy path e.g. for REQ_FAILFAST_DEV
commands.
Introduce a new blist flag for this case.
Signed-off-by: Martin Wilck
---
drivers/scsi/scsi_devinfo.c | 1 +
drivers/scsi/scsi_err
Warn if a device (or the user) sets blist flags which are unknown
or have been removed. This should enable us to reuse freed blist
bits in later releases.
Signed-off-by: Martin Wilck
---
drivers/scsi/Makefile | 2 +-
drivers/scsi/scsi_devinfo.c | 6 ++
include/scsi/scsi_devinfo.h
EMC Symmetrix returns 'internal target error' for a variety
of conditions, most of which will be transient.
So we should always retry it, even with failfast set.
Otherwise we'd get spurious path flaps with multipath.
Signed-off-by: Martin Wilck
---
drivers/scsi/scsi_devinfo.c |
Use the just introduced const_ilog2() macro to avoid sparse
errors.
Signed-off-by: Martin Wilck
---
drivers/scsi/scsi_debugfs.c | 2 +-
drivers/scsi/scsi_sysfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_debugfs.c b/drivers/scsi/scsi_debugfs.c
Space for SCSI blist flags is gradually running out. Change the
type to __u64. And fix a checkpatch complaint about symbolic
mode flags in scsi_devinfo.c.
Make checkpatch happy by replacing simple_strtoul() with kstrtoull().
Signed-off-by: Martin Wilck
---
drivers/scsi/scsi_devinfo.c | 18
increased the length of
blist_flag_t to 64 bit, and used previously unused bits. I also added checking
for obsolete and unused bits.
For the blist_flag_t size increase, I used sparse to try and avoid regressions;
that necessitated fixing sparse's errors for the current code first.
Martin W
parentheses, but that appears
to be a false positive. I can get rid of the warning simply by inserting
whitespace, making checkpatch "see" the whole macro).
Signed-off-by: Martin Wilck
---
include/linux/log2.h | 35 ---
1 file changed, 24 insertions(+), 11
On Wed, 2018-01-24 at 11:41 -0800, Khazhismel Kumykov wrote:
> On Wed, Jan 24, 2018 at 11:09 AM, Martin Wilck
> wrote:
> > On Wed, 2018-01-24 at 10:44 -0800, Khazhismel Kumykov wrote:
> > > On Wed, Jan 24, 2018 at 2:57 AM, Martin Wilck
> > > wrote:
> > &
On Wed, 2018-01-24 at 10:44 -0800, Khazhismel Kumykov wrote:
> On Wed, Jan 24, 2018 at 2:57 AM, Martin Wilck
> wrote:
> > On Fri, 2018-01-19 at 15:07 -0800, Khazhismel Kumykov wrote:
> > > Move the last used path to the end of the list (least preferred)
> > > so
id_paths);
> -
> list_for_each_entry(pi, &s->valid_paths, list)
> if (!best || (st_compare_load(pi, best, nr_bytes) <
> 0))
> best = pi;
> @@ -292,6 +289,9 @@ static struct dm_path *st_select_path(struct
> path_selector *ps, size_t nr_bytes)
> if (!best)
> goto out;
>
> + /* Move most recently used to least preferred to evenly
> balance. */
> + list_move_tail(&best->list, &s->valid_paths);
> +
> ret = best->path;
> out:
> spin_unlock_irqrestore(&s->lock, flags);
> --
> dm-devel mailing list
> dm-de...@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
The modification of fc_lport_recv_els_req() in commit fcabb09e59a7
(merged in 4.12-rc1) caused certain requests not to be handled at all.
Fix that.
Fixes: fcabb09e59a7 "scsi: libfc: directly call ELS request handlers"
Signed-off-by: Martin Wilck
---
drivers/scsi/libfc/fc_lport.c |
On Fri, 2017-09-29 at 16:59 -0600, Keith Busch wrote:
> On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote:
> > In the NVME subsystem, we're seeing a race condition with udev
> > where
> > device_add_disk() is called (which triggers an "add" uevent)
On Sun, 2017-10-01 at 10:00 +0200, Christoph Hellwig wrote:
> While this looks okay-ish to me I really don't want people confused
> with three variants of add_disk, we really need to consolidate
> our helpers there a bit..
>
Can you give me a hint what you'd like to see?
By using device_add_disk_with_groups(), we can avoid the race
condition with udev rule processing, because no udev event will
be triggered before all attributes are available.
Signed-off-by: Martin Wilck
---
drivers/nvme/host/core.c | 12 +++-
1 file changed, 7 insertions(+), 5
f the device is incomplete, in particular, device
WWIDs may not be determined correctly.
To fix this, this patch introduces a new function
device_add_disk_with_groups(), which takes a list of attribute groups
and adds them to the device before sending out uevents.
Signed-off-by: Martin Wilck
---
On Wed, 2017-09-06 at 14:36 +0200, Martin Wilck wrote:
> The way I'd implemented the new helper memcpy_and_pad with
> __FORTIFY_INLINE caused compiler warnings for certain kernel
> configurations.
>
> This helper is only used in a single place at this time, and thus
> do
tification support for now.
Fixes: 01f33c336e2d "string.h: add memcpy_and_pad()"
Signed-off-by: Martin Wilck
Acked-by: Arnd Bergmann
---
include/linux/string.h | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/linux/string.h b/include/linux/string.h
}
> if (dest_size < dest_len)
> - fortify_panic(__func__);
> + fortify_overflow(__func__);
> if (dest_len > count) {
> memcpy(dest, src, count);
> memset(dest + count, pad, dest_len - count);
> --
> 2.13.2
tification support for now.
Fixes: 3c5fa8cd18f8 "string.h: add memcpy_and_pad()"
Signed-off-by: Martin Wilck
---
include/linux/string.h | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/linux/string.h b/include/linux/string.h
index 0bec4151b0eb9..
'm sorry. It seems that I messed the code up by trying to do it right.
I suggest to simply drop the fortification code from this function,
which is not a "common str/mem function" anyway. Please tell me if
that'd be ok for you.
I'll send a patch in a follow-up email.
Martin
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
This changes the earlier patch "nvmet: don't report 0-bytes
in serial number" to use the memcpy_and_pad() helper introduced
in a previous patch.
Signed-off-by: Martin Wilck
---
drivers/nvme/target/admin-cmd.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-
side patch which was merged in nvme-4.13 already.
* Split off bug fix (patch 1/3).
Martin Wilck (3):
nvmet_execute_identify_ctrl: don't overwrite with 0-bytes
string.h: add memcpy_and_pad()
nvmet_execute_identify_ctrl: use memcpy_and_pad()
drivers/nvme/target/admin-cmd.c | 20 +++-
This helper function is useful for the nvme subsystem, and maybe
others.
Note: the warnings reported by the kbuild test robot for this patch
are actually generated by the use of CONFIG_PROFILE_ALL_BRANCHES
together with __FORTIFY_INLINE.
Signed-off-by: Martin Wilck
---
include/linux/string.h
number
Signed-off-by: Martin Wilck
---
drivers/nvme/target/admin-cmd.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 2d7a98ab53fbf..a53bb6635b837 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/ad
Some broken targets (such as the current Linux target) pad
model or serial fields with 0-bytes rather than spaces. The
NVME spec disallows 0 bytes in "ASCII" fields.
Thus strip trailing 0-bytes, too. Also make sure that we get no
underflow for pathological input.
Signed-off-by: Ma
v2:
* 3/3: Make sure no underflow occurs (Joe Perches)
Martin Wilck (3):
string.h: add memcpy_and_pad()
nvmet: identify controller: improve standard compliance
nvme: wwid_show: strip trailing 0-bytes
drivers/nvme/host/core.c| 6 --
drivers/nvme/target/admin-
The NVME standard mandates that the SN, MN, and FR fields of
the Indentify Controller Data Structure be "ASCII strings".
That means that they may not contain 0-bytes, not even string
terminators.
Signed-off-by: Martin Wilck
---
drivers/nvme/target/admin-cmd.c | 13 ++---
1 fi
This helper function is useful for the nvme subsystem, and maybe
others.
Signed-off-by: Martin Wilck
---
include/linux/string.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/linux/string.h b/include/linux/string.h
index a467e617eeb08..0bec4151b0eb9
The NVME standard mandates that the SN, MN, and FR fields of
the Indentify Controller Data Structure be "ASCII strings".
That means that they may not contain 0-bytes, not even string
terminators.
Signed-off-by: Martin Wilck
---
drivers/nvme/target/admin-cmd.c | 13 ++---
1 fi
8-0001
Changes wrt v1:
* 1/3: new, moved helper to include/linux/string.h (Christoph Hellwig)
(you suggested kernel.h, but I think this matches string.h better)
* Dropped the last patch from the v1 series that would have changed valid
WWIDs for
HW NVME controllers.
Marti
Some broken targets (such as the current Linux target) pad
model or serial fields with 0-bytes rather than spaces. The
NVME spec disallows 0 bytes in "ASCII" fields.
Thus strip trailing 0-bytes, too.
Signed-off-by: Martin Wilck
Reviewed-by: Hannes Reinecke
Acked-by: Christo
This helper function is useful for the nvme subsystem, and maybe
others.
Signed-off-by: Martin Wilck
---
include/linux/string.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/linux/string.h b/include/linux/string.h
index a467e617eeb08..0bec4151b0eb9
On Thu, 2017-07-13 at 12:48 +0200, Johannes Thumshirn wrote:
> The NVMe target has no way to preserve controller serial
> IDs across reboots which breaks udev scripts doing
> SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n.
>
> Export the randomly generated serial number via configfs and allo
from shost->__targets list is done
> without the lock.
> spin_lock_irqsave(shost->host_lock, flags);
> }
> }
> spin_unlock_irqrestore(shost->host_lock, flags);
I believe this is fixed in SLES12-SP1 kernel 3.12.53-60.30.1, with the
following patch:
* Mon Jan 18 2016 jthumsh...@suse.de
- scsi: restart list search after unlock in scsi_remove_target
(bsc#944749, bsc#959257).
- Delete
patches.fixes/0001-SCSI-Fix-hard-lockup-in-scsi_remove_target.patch.
- commit 2490876
Regards,
Martin
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
d_kmod_load(), but there are many more aliases defined (and
used) in the kernel. Do you plan to implement special code for "char-
major-$X", "crypto-$X", "binfmt-$X" etc. later?
Regards
Martin
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Fel
From: Martin Wilck
Since b8b2c7d845d5, platform_drv_probe() is called for all platform
devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
platform_drv_probe() will return the error code from dev_pm_domain_attach().
This causes real_probe() to enter the "probe_failed"
From: Martin Wilck
Since b8b2c7d845d5, platform_drv_probe() is called for all platform
devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
platform_drv_probe() will return the error code from dev_pm_domain_attach().
This causes real_probe() to enter the "probe_failed"
From: Martin Wilck
Since b8b2c7d845d5, platform_drv_probe() is called for all platform
devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
platform_drv_probe() will return the error code from dev_pm_domain_attach().
This causes real_probe() to enter the "probe_failed"
he kdump kernel the IRR is cleared.
I'll run an overnight test with that technique tonight.
Martin
--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DE6
Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn
Germany
Tel:++49 5251 8 15113
Fax:
at time I was using "noirqdebug" because we had a FW problem that
caused a lot of misrouted IRQs. With "noirqdebug", "irqpoll" has no effect.
Bummer.
Martin
--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DE6
Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-
ur
> goal isn't to fix things properly by removing the need for
> disable_IO_APIC I don't feel like putting much effort into this
> code path.
Who is working on this? Can you give a reference to a list of things that
would need to be done to do this right?
Martin
--
Martin Wilck
PRIM
'd re-enable IRQs, IRQ 225 would be raised. The whole thing is done before
disable_IO_APIC().
Don't ask me for an explanation why I don't see the ISR bits.
The arch/x86_64/kernel/crash.c portion of the patch I am using is attached for
your reference. The rest is the same as for the ori
L.
I have no idea how my patch could cause that.
This proves that re-enabling IRQs in this situation is too dangerous :-(.
I really did hundreds of dumps in different ways (echo c>/proc/sysrq-trigger,
forcing Oops and panic(), actually hititng Alt-Sysrq) and this never happened to
me.
Martin
n a system like you describe.
Even if my patch in the form in which I submitted it is unusable,
I think the basic idea that IRQs should be masked bottom-up
(IO-APIC first, then local APIC, then CPU) is correct.
Or is there any specific reason why the current code does it vice-versa?
Martin
--
l RAID" (ZCR) controller. The system has an
on-board LSI 1068 (mptsas). If you put the ZCR in a certain PCI slot, the
1068 is hidden from the system, which sees the megaraid_sas controller
(1000:0413) instead of the 1068. The ZCR internally uses the 1068 as low-level
controller.
The success
> process will be.
That's certainly correct. I am grateful for all hints that simplify my patch.
Thanks,
Martin
--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DE6
Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn
Germany
Tel:
eaders
> of this code to work out what the code is doing and why it is doing it
> purely by reading the C statements.
OK. I thought this might make the patch itself too long, that's why I put
it into the header.
Thanks, Martin
--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP
he IO-APIC "delivery status" bit is also set.
I checked local APIC ISR and IRR bits in an earlier version of my patch
(see above). They were sometimes set, and sometimes not (unlike the IO-APIC
IRR/Delivery Status which behave always the same).
The patch was very different at that tim
lyzed and the patch developed against the
Red Hat EL5 kernel (2.6.18-8.el5). I verified that the
problem still occurs with 2.6.23-rc1, and that the patch
below fixes the problem.
Regards
Martin
PS: patch attached ain MIME format because it'd be mangled
quoted-printable by my Mail relay.
that you agree this does not belong into the subarch
code?
That's CPU/chipset specific indeed. It shouldn't really depend on the
platform these are used in. Exceptions, if any, can be handled on a case
by case basis.
Maciej
Regards
Martin
--
Martin WilckP
.
Please refer to the start of this thread.
Anyway, I understand that you agree this does not belong into the
subarch code?
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED
r hand is
inconsistent. A correct approach must take both CPU and architecture
constraints into account, and use a CPU-type-dependent variable mask in
the subarch code.
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
hat the ID of 0 need not necessarily
belong to the BSP.
Starting both local APICs and IO-APICs at 0 isa working and
aesthetically pleasing solution. We're pursuing that now.
Thanks again, Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +4
n't see that this is forbidden (the reason is that the
IO-APICs have only 4-bit APIC ID registers). Anyway we changed it now to
have both IO-APICs and CPUs start at 0.
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nix
concerned, we have had no problems with
the patch here.
Thanks, Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/pri
yhlu wrote:
why matrin need to make apic id to be greater than 0x10 when system is
only 2way?
It's a scalable system where multiple boards may be combined. Anyway, I
see nothing in the specs that says you must start counting CPUs from zero.
Regards
Martin
--
Martin
:
processor.mpc_apicver = 0x10; /* TBD: lapic version */
in arch/x86_64/kernel/mpparse.c.
I am used to get correct answers from Linux :-)
Cheers
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL
ed as indicator.
Great.
Regards, Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
-
To unsubscribe from this list
be set to 0xff).
Will hopefully be fixed in 2.6.14.
Great,
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.co
tion is clearly wrong for these latest CPU types.
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/primerg
d struct
tty_struct->tty_files, unless I'm mistaken), and that this locking
should be done with semaphores. Right?
Going through the list of all sb->s_files can be a costly operation; it
may be worthwile to have a per-sb locking mechanism for that.
Martin
--
Martin Wilck
ng spin_lock implies that we can
_prove_ the lock won't be taken in softirq context, and that we will be
able to prevent new such paths to be introduced in the future. I wonder
if that's possible for this lock.
Regards,
Martin
--
Martin WilckPhone: +49 5251 8 15
ary_handler+128}
{do_execve+393}
{system_call+126}
{sys_execve+56}
{stub_execve+106}
Code: 0f 0b 33 a2 35 80 ff ff ff ff 4a 00 31 ff e8 67 bf fe ff 31
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring
All right,
this looks like a pretty broad agreement on this issue.
Jeff, would you please apply this patch?
Regards,
Martin
Patch: fix wrong HD activity control by ahci driver
Signed-off-by: [EMAIL PROTECTED]
The ahci driver 1.0 sets the SActive bit on every transaction,
causing the LED to li
wrong behavior of the
activity LED?
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
-
To unsubscribe
driver is
wrong in setting the SActive bit. Could you please comment? Jeff, in
particular, could you please give more detail why you say this flag is
"intentionally used"?
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 525
t give too much info :|
Thanks!
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
-
To unsubscribe from this
Jan Engelhardt wrote:
I'm probably stabbing in the dark, but I've seen ipt_owner of netfilter to
talk about spin_lock_bh() wrt. files->file_lock.
That is a different lock. I am talking about the global files_lock
(include/linux/fs.h)
Regards
Martin
--
Martin Wilck
am I misssing
something obvious?
Thanks
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
-
To unsubscribe from
Linus Torvalds wrote:
In particular, I don't see why you didn't just put this in the generic
calibrate_delay() routine. You seem to have basically duplicated it, and
added the "guess from an external timer" code - and I don't see what's
non-generic about that, except for some trivial "what's the
Venkatesh Pallipadi wrote:
(0) Estimate a value for loops_per_jiffy
(1) While (loops_per_jiffy estimate is accurate enough)
(2) wait for jiffy transition (jiffy1)
(3) Note down current tsc (tsc1)
(4) loop until tsc becomes tsc1 + loops_per_jiffy
(5) check whether jiffy changed since jiffy1
anymore; perhaps it
should be officially deprecated and/or removed?
Regards
Martin
--
Martin WilckPhone: +49 5251 8 15113
Fujitsu Siemens Computers Fax: +49 5251 8 20409
Heinz-Nixdorf-Ring 1mailto:[EMAIL PROTECTED]
D-33106 Paderborn http://www.fujitsu-siemens.co
kernel code with objdump,
I am pretty certain that the changes in 2.4.6-pre6 do not fix my problem
(if they did, I would see a crash in proc_pid_delete_inode rather
than in proc_delete_inode).
The two patches are not in conflict.
Regards,
Martin
--
Martin Wilck <[EMAIL PROTECTED]>
notion somehow (start only set if data size > page size).
After all, unless you want to mangle the file position as intended by
the hack, there is no point in touching start at all in proc_read (),
ppos will be updated automatically.
Perhaps I have misunderstood something here.
Who wrote the orig
using the default
> proc_file_read() at all. At the very least you'd save a redundant
> __get_free_page/free_page pair.
That's right, but nevertheless (repeat) comparing "start" and "page" is
wrong.
Regards,
Martin
--
Martin Wilck <[EMAIL PROTECTED]>
FS
ted for it
are always between 0 and PAGE_SIZE. Therefore the patch below would
not break it, while overcoming the abovementioned problem, because
legitimate page pointers will never be < PAGE_SIZE.
Please correct me if I'm wrong.
Cheers,
Martin
--
Martin Wilck <[EMAIL PROTECTED]>
what needs
to happen for patches to enter the main branches.
Cheers,
Martin
--
Martin Wilck <[EMAIL PROTECTED]>
FSC EP PS DS1, Paderborn Tel. +49 5251 8 15113
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
l genhd.h says that's too slow (is it really slower?)
Regards,
Martin
--
Martin Wilck <[EMAIL PROTECTED]>
FSC EP PS DS1, Paderborn Tel. +49 5251 8 15113
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
exchanged.
If partitions are destroyed and created, the links in /dev/guid
(dis)appear as well (thanks to devfs magic).
The patch is against 2.4.5 + David Mosbergers IA64 patch (30/05/2001)
from the "ports" directory.
Feedback very welcome
Martin
--
Martin Wilck <[EMAIL PROTE
}
*ppos += start < page ? (long)start : n; /* Move down the file */
--
Martin Wilck <[EMAIL PROTECTED]>
FSC EP PS DS1, Paderborn Tel. +49 5251 8 15113
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
1 - 100 of 102 matches
Mail list logo
