This driver is maintained by Dell, but it was missing in MAINTAINERS.
Signed-off-by: Mario Limonciello
---
MAINTAINERS | 5 +
drivers/platform/x86/dell/alienware-wmi.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b
A team of engineers will be helping to service these drivers in
the future rather than just one person.
Signed-off-by: Mario Limonciello
---
MAINTAINERS | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6e91994b8d3b..46c8fadb59c3
The Dell drivers I'm involved with all have me as an author and/or
maintainer. In the future these will be maintained as a team effort.
Adjust the contact addresses accordingly.
Mario Limonciello (3):
MAINTAINERS: Adjust Dell drivers to email alias
MAINTAINERS: Add missing sectio
So that I can always be reached in the future if necessary, add a
personal email address.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell/alienware-wmi.c | 2 +-
drivers/platform/x86/dell/dell-smbios-base.c | 2 +-
drivers/platform/x86/dell/dell-wmi-descriptor.c
On Dell systems that don't support this interface the module is
mistakingly returning error code "0", when it should be returning
-ENODEV. Correct a logic error to guarantee the correct return code.
Cc: Divya Bharathi
Reported-by: Alexander Naumann
Signed-off-by: Ma
performs firmware upgrades to run without CAP_SYS_ADMIN,
create a new capability CAP_FIRMWARE_UPGRADE that software can run with.
For the RFC, only include NVME. Other drivers can be added if suggested.
Mario Limonciello (2):
capability: Introduce CAP_FIRMWARE_UPGRADE
nvme: Use
Software that is running with CAP_FIRMWARE_UPGRADE needs a limited
set of opcode access:
* Identify the disk
* Download firmware to the disk
* Commit the firmwware to the disk
Signed-off-by: Mario Limonciello
---
drivers/nvme/host/core.c | 28
1 file changed, 24
Split out permissions specifically for firmware upgrades from
CAP_SYS_ADMIN to a new separate capability. This will allow userspace
applications that would traditionally have needed CAP_SYS_ADMIN to perform
firmware upgrades to have a reduced permission set.
Signed-off-by: Mario Limonciello
A user without a Dell system doesn't need to pick any of these
drivers.
Users with a Dell system can enable this submenu and all drivers
behind it will be enabled.
Suggested-by: Andy Shevchenko
Signed-off-by: Mario Limonciello
---
Changes from v1->v2:
- Rename menu per Andy'
A user without a Dell system doesn't need to pick any of these
drivers.
Suggested-by: Andy Shevchenko
Signed-off-by: Mario Limonciello
---
MAINTAINERS | 22 +--
drivers/platform/x86/Kconfig | 182 +-
drivers/platfor
An upcoming Dell platform is causing a NULL pointer dereference
in dell-wmi-sysman initialization. Validate that the input from
BIOS matches correct ACPI types and abort module initialization
if it fails.
This leads to a memory leak that needs to be cleaned up properly.
Signed-off-by: Mario
-lan/patch/20200323191639.48826-1-aaron...@canonical.com/
Link: https://lkml.org/lkml/2020/12/13/15
Link: https://lkml.org/lkml/2020/12/14/708
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git
pervious to
platform firmware behavior.
Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
Reviewed-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 45 +-
1 file changed, 2 insertions(+),
If the shutdown failed, the part will be thawed and running
S0ix flows will put it into an undefined state.
Reported-by: Alexander Duyck
Reviewed-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++--
1 file changed, 7
igned-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
drivers/net/ethernet/intel/e1000e/ethtool.c | 46 +
drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++--
3 files changed, 52 insertions(+), 4 deletions(-)
diff --git a/drivers/net/eth
vice matching
- Remove module parameter and sysfs, use ethtool flag instead.
- Export s0ix flag to ethtool private flags
- Include more people and lists directly in this submission chain.
Mario Limonciello (4):
e1000e: Only run S0ix flows if shutdown succeeded
e1000e: bump up timeout to wait
pervious to
platform firmware behavior.
Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 45 +-
1 file changed, 2 insertions(+), 43 deletions(-)
diff --gi
djust from DMI matching to PCI subsystem vendor ID/device matching
- Remove module parameter and sysfs, use ethtool flag instead.
- Export s0ix flag to ethtool private flags
- Include more people and lists directly in this submission chain.
Mario Limonciello (4):
e1000e: Only run S0ix flows
If the shutdown failed, the part will be thawed and running
S0ix flows will put it into an undefined state.
Reported-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
nk:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200323191639.48826-1-aaron...@canonical.com/
Link: https://lkml.org/lkml/2020/12/13/15
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ne
igned-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
drivers/net/ethernet/intel/e1000e/ethtool.c | 40 +
drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++---
3 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/drivers/net/eth
;).
Fixes: 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case").
Signed-off-by: Vitaly Lifshits
Tested-by: Aaron Brown
Signed-off-by: Tony Nguyen
Reviewed-by: Alexander Duyck
Signed-off-by: Mario Limonciello
---
This patch was originally part of
https://marc.in
On 12/4/20 2:09 PM, Mario Limonciello wrote:
From: Vitaly Lifshits
Changed a configuration in the flows to align with
architecture requirements to achieve S0i3.2 substate.
Also fixed a typo in the previous commit 632fbd5eb5b0
("e1000e: fix S0ix flows for cable connected case").
These Tiger Lake systems are not yet released, but have been validated
on pre-release hardware.
This is being submitted separately from released hardware in case of
a regression between pre-release and release hardware so this commit
can be reverted alone.
Signed-off-by: Mario Limonciello
Adjust from DMI matching to PCI subsystem vendor ID/device matching
- Remove module parameter and sysfs, use ethtool flag instead.
- Export s0ix flag to ethtool private flags
- Include more people and lists directly in this submission chain.
Mario Limonciello (6):
e1000e: Move all S0ix relate
From: Vitaly Lifshits
Changed a configuration in the flows to align with
architecture requirements to achieve S0i3.2 substate.
Also fixed a typo in the previous commit 632fbd5eb5b0
("e1000e: fix S0ix flows for cable connected case").
Signed-off-by: Vitaly Lifshits
Tested-by: Aaron Brown
Signe
: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c
b/drivers/net/ethernet/intel/e1000e/s0ix.c
index 74043e80c32f..0dd2e2702ebb 100644
--- a/drivers/net/ethernet/intel/e1000e/s0ix.c
+++ b
Introduce a flag to indicate the device should be using the S0ix
flows and use this flag to run those functions.
Splitting the code to it's own file will make future heuristics
more self contained.
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e
This Tiger Lake system is not yet released, but has been validated
on pre-release hardware.
This is being submitted separately from released hardware in case of
a regression between pre-release and release hardware so this commit
can be reverted alone.
Signed-off-by: Mario Limonciello
s0ix entry and exit flows for ME systems")
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +---
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c
b/drivers/net
This flag can be used for debugging and development purposes
including determining if S0ix flows work properly for a system
not currently recognized by heuristics.
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 40
From: Vitaly Lifshits
Changed a configuration in the flows to align with
architecture requirements to achieve S0i3.2 substate.
Also fixed a typo in the previous commit 632fbd5eb5b0
("e1000e: fix S0ix flows for cable connected case").
Signed-off-by: Vitaly Lifshits
Tested-by: Aaron Brown
Signe
Dell's Comet Lake Latitude and Precision systems containing i219LM are
properly configured and should use the s0ix flows.
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +---
1 file changed, 29 insertions(
italy's dependency patch in the series
- Split out s0ix code into it's own file
- Adjust from DMI matching to PCI subsystem vendor ID/device matching
- Remove module parameter and sysfs, use ethtool flag instead.
- Export s0ix flag to ethtool private flags
- Include more people and
This flag can be used for debugging and development purposes
including determining if s0ix flows work properly for a system
not currently recognized by heuristics.
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/ethtool.c | 40
Introduce a flag to indicate the device should be using the s0ix
flows and use this flag to run those functions.
Splitting the code to it's own file will make future heuristics
more self containted.
Tested-by: Yijun Shen
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/e
: Mario Limonciello
---
drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c
b/drivers/net/ethernet/intel/e1000e/s0ix.c
index 74043e80c32f..0dd2e2702ebb 100644
--- a/drivers/net/ethernet/intel/e1000e/s0ix.c
+++ b
These comet lake systems are not yet released, but have been validated
on pre-release hardware.
This is being submitted separately from released hardware in case of
a regression between pre-release and release hardware so this commit
can be reverted alone.
Signed-off-by: Mario Limonciello
: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
Signed-off-by: Mario Limonciello
---
.../device_drivers/ethernet/intel/e1000e.rst | 23
drivers/net/ethernet/intel/e1000e/e1000.h | 7 ++
drivers/net/ethernet/intel/e1000e/netdev.c| 64 +-
d
he behavior on by default for Dell's CML systems.
These patches should only be carried if that patch linked above is also applied.
Mario Limonciello (3):
e1000e: allow turning s0ix flows on for systems with ME
e1000e: Add Dell's Comet Lake systems into s0ix heuristics
e1000e:
Dell's Comet Lake Latitude and Precision systems containing i219LM are
properly configured and should use the s0ix flows.
Signed-off-by: Mario Limonciello
---
drivers/net/ethernet/intel/Kconfig| 1 +
drivers/net/ethernet/intel/e1000e/param.c | 80 ++-
2
-quirks.h
- Adjust function and parameter names to Mika's preferences
- Rebase onto thunderbolt.git/bleeding-edge to move on top of retimer work
Mario Limonciello (2):
thunderbolt: Add support for separating the flush to SPI and
authenticate
thunderbolt: Add support for authenticate
Some external devices can support completing thunderbolt authentication
when they are unplugged. For this to work though, the link controller must
remain operational.
The only device known to support this right now is the Dell WD19TB, so add
a quirk for this.
Signed-off-by: Mario Limonciello
This allows userspace to have a shorter period of time that the device
is unusable and to call it at a more convenient time.
For example flushing the image may happen while the user is using the
machine and authenticating/rebooting may happen while logging out.
Signed-off-by: Mario Limonciello
complete the update when unplugged.
Export that functionality to userspace as well.
Changes from v1 to v2:
- Improve documentation
- Drop tb-quirks.h
- Adjust function and parameter names to Mika's preferences
- Rebase onto thunderbolt.git/bleeding-edge to move on top of retimer work
Some external devices can support completing thunderbolt authentication
when they are unplugged. For this to work though, the link controller must
remain operational.
The only device known to support this right now is the Dell WD19TB, so add
a quirk for this.
Signed-off-by: Mario Limonciello
This allows userspace to have a shorter period of time that the device
is unusable and to call it at a more convenient time.
For example flushing the image may happen while the user is using the
machine and authenticating/rebooting may happen while logging out.
Signed-off-by: Mario Limonciello
Some external devices can support completing thunderbolt authentication
when they are unplugged. For this to work though, the link controller must
remain operational.
The only device known to support this right now is the Dell WD19TB, so add
a quirk for this.
Signed-off-by: Mario Limonciello
This allows userspace to have a shorter period of time that the device
is unusable and to call it at a more convenient time.
For example flushing the image may happen while the user is using the
machine and authenticating/rebooting may happen while logging out.
Signed-off-by: Mario Limonciello
complete the update when unplugged.
Export that functionality to userspace as well.
This patch series is done relative thunderbolt.git/next.
Mario Limonciello (2):
thunderbolt: Add support for separating the flush to SPI and
authenticate
thunderbolt: Add support for authenticate on
mode")
Reported-by: Alex Guzman
Signed-off-by: Mario Limonciello
---
drivers/char/tpm/tpm-dev-common.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/char/tpm/tpm-dev-common.c
b/drivers/char/tpm/tpm-dev-common.c
index 87f449340202..bc9d7c7ddc01 100644
--- a/drivers/char/t
n adjusted
in d916b1be this is expected to be now resolved.
Cc: 'Paul Menzel '
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907
Signed-off-by: Mario Limonciello
---
The particular failing configuration was reported by only ever failed for Paul
Menzel, so hopefully
he can
/system combinations.
Signed-off-by: Mario Limonciello
---
drivers/nvme/host/pci.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
Changes from v1:
* Discard saved state in error scenario
* Removed unneeded goto statement in error scenario
diff --git a/drivers/nvme
/system combinations.
Signed-off-by: Mario Limonciello
---
drivers/nvme/host/pci.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 732d5b6..9b3fed4 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme
kernel.org/show_bug.cgi?id=200039
Link: https://marc.info/?l=linux-bluetooth&m=156441081612627&w=2
Link:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/750073/
CC: Bastien Nocera
CC: Christian Kellner
CC: Sukumar Ghorai
Signed-off-by: Mario Limonciello
---
drivers
fixed in the next firmware
version. As this firmware is already in the field, avoid running
nvme specific suspend to idle flow.
Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
Signe
fixed in the next firmware
version. As this firmware is already in the field, avoid running
nvme specific suspend to idle flow.
Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
Signe
fixed in the next firmware
version. As this firmware is already in the field, avoid running
nvme specific suspend to idle flow.
Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
Signe
When converting the driver two arguments were transposed leading
to rfkill not working.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
Reported-by: Pepijn de Vos
Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
Signed-off-by: Mario Limoncie
containing RTL8153-BND should
activate MAC pass through and there won't use pass through bit on efuse
like in RTL8153-AD.
Signed-off-by: Mario Limonciello
---
drivers/net/usb/r8152.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/ne
be turned
on with dynamic debugging to better root cause this problem.
Suggested-by: Mika Westerberg
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/intel-wmi-thunderbolt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel-wmi
ACPI buffers were being allocated but never freed.
Reported-by: Pinzhen Xu
Signed-off-by: Mario Limonciello
Cc: sta...@vger.kernel.org
---
drivers/platform/x86/dell-smbios-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell-smbios-wmi.c
b/drivers/platform/x86
An ACPI buffer that was allocated was not being freed after use.
Signed-off-by: Mario Limonciello
Cc: sta...@vger.kernel.org
---
drivers/platform/x86/alienware-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/alienware-wmi.c
b/drivers/platform/x86/alienware-wmi.c
Some Dell servers can use dell-smbios but they don't support the
token interface. Make it optional.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios-base.c | 35 -
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/dr
amp; SERIO_I8042 [=y]
>>
Right now it's possible to set dell laptop to compile in but this
causes dell-smbios to compile in which breaks if dcdbas is a module.
Dell laptop shouldn't select dell-smbios anymore, but depend on it.
Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve de
Sergey reported that some much older Dell systems don't support
the OEM string "Dell System" but instead supported www.dell.com
in OEM strings.
Match both of these to indicate that this driver is running on
a Dell system.
Reported-by: Sergey Kubushyn
Signed-off-by: Mario Limonci
This file is used both for setting the wakeup device without kernel
command line as well as for actually waking the system (when appropriate
swap header is in place).
To avoid confusion on incorrect logs in system log downgrade the
message to debug and make it clearer.
Signed-off-by: Mario
Currently the only way to specify a hibernate offset for a
swap file is on the kernel command line.
Add a new /sys/power/resume_offset that lets userspace
specify the offset and disk to use when initiating a hibernate
cycle.
Signed-off-by: Mario Limonciello
---
Changes from v2:
* Cast the
This file is used both for setting the wakeup device without kernel
command line as well as for actually waking the system (when appropriate
swap header is in place).
To avoid confusion on incorrect logs in system log downgrade the
message to debug and make it clearer.
Signed-off-by: Mario
Currently the only way to specify a hibernate offset for a
swap file is on the kernel command line.
Add a new /sys/power/resume_offset that lets userspace
specify the offset and disk to use when initiating a hibernate
cycle.
Signed-off-by: Mario Limonciello
---
Documentation/ABI/testing/sysfs
/power/resume and /sys/power/disk_offset parsing.
Signed-off-by: Mario Limonciello
---
Documentation/ABI/testing/sysfs-power | 43 +
Documentation/power/swsusp.txt| 10 +++-
kernel/power/hibernate.c | 88 +--
3 files changed, 125
th it.
Signed-off-by: Mario Limonciello
---
An alternative to introducing a new sysfs parameter may be to document
setting these values via /sys/power/resume. If the wrong signature is found
on the swapfile/swap partition by the kernel it does show an error
but it updates the values and they'll
plus at least
+ 6 bytes of entry */
WARNING: Block comments use a trailing */ on a separate line
+ 6 bytes of entry */
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/driver
this change the Kconfig needs to be adjusted so that
CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean
rather than modules.
CONFIG_DELL_SMBIOS is a visually selectable option again and both
CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional.
Signed-off-by: Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios
drivers together.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0
2 files changed, 1 insert
this change the Kconfig needs to be adjusted so that
CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean
rather than modules.
CONFIG_DELL_SMBIOS is a visually selectable option again and both
CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional.
Signed-off-by: Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios
drivers together.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0
2 files changed, 1 insert
plus at least
+ 6 bytes of entry */
WARNING: Block comments use a trailing */ on a separate line
+ 6 bytes of entry */
Signed-off-by: Mario Limonciello
---
changes from v1:
* Adjust comment style
drivers/platform/x86/dell-smbios.c | 8 +---
1 file changed, 5 insert
this change the Kconfig needs to be adjusted so that
CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean
rather than modules.
CONFIG_DELL_SMBIOS is a visually selectable option again and both
CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional.
Signed-off-by: Mario Limonciello
plus at least
+ 6 bytes of entry */
WARNING: Block comments use a trailing */ on a separate line
+ 6 bytes of entry */
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/driver
This is being done to faciliate a later change to link all the dell-smbios
drivers together.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0
2 files changed, 1 insert
switch")
Reported-by: Jeremy Cline
Signed-off-by: Mario Limonciello
---
Note: I also moved the code for detecting tablet into it's own
function. To keep things under 80 lines with if statements was
making the code very unreadable otherwise.
drivers/
Rohar
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-laptop.c | 188 -
1 file changed, 103 insertions(+), 85 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c
b/drivers/platform/x86/dell-laptop.c
index fc2dfc8..a7b1419 100644
--- a
There may be race conditions with multiple different functions working
on a module wide buffer causing one function to get the wrong results.
Suggested-by: Pali Rohar
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-laptop.c | 188 -
1 file
Suggested-by: Pali Rohar
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-laptop.c | 67 ++
1 file changed, 53 insertions(+), 14 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c
b/drivers/platform/x86/dell-laptop.c
index fc2dfc8
The class/select were mistakingly put into octal notation but
intended to be in decimal notation.
Suggest-by: Pali Rohar
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell
l. It
would be better for drivers to not interact with the WMI bus by GUID
string but by the struct wmi_device provided by the WMI bus during
probing.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/wmi.c | 31 ---
1 file changed, 31 deletions(-)
diff --g
It's possible for the same GUID to show up on as system twice.
This means using solely the GUID for identify the file will not
be sufficient.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pla
onsidered changing a userspace interface. If so, then
an alternative would be to append a number when a second instance of
a GUID has been discovered and keep the "old" symlink path for the first
instance stable.
Mario Limonciello (2):
platform/x86: wmi: prefix sysfs files in /sys/bu
dispatcher.
Suggested-by: Girish Prakash
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios-wmi.c | 13 +
drivers/platform/x86/dell-wmi-descriptor.c | 26 --
drivers/platform/x86/dell-wmi-descriptor.h | 1 +
3 files changed, 38 insert
dispatcher.
Suggested-by: Girish Prakash
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios-wmi.c | 14 ++
drivers/platform/x86/dell-wmi-descriptor.c | 26 --
drivers/platform/x86/dell-wmi-descriptor.h | 1 +
3 files changed, 39 insert
On machines using rfkill interface the buffer needs to have been
allocated before the initial use (memset) of it.
Reported-by: Valdis Kletnieks
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-laptop.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a
t driver.
Userspace can unbind the driver, so all methods used from driver
should still be verified to return success values otherwise deferred
probing be used.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios-wmi.c | 5 +++--
drivers/platform/x86/dell-wmi-descripto
- Move wmi_has_guid check into dell-wmi-descriptor.c instead of
dependent drivers.
Mario Limonciello (2):
platform/x86: dell-wmi-descriptor: check if memory was allocated
platform/x86: dell-*wmi*: Relay failed initial probe to dependent
drivers
drivers/platform/x86/dell-smbios-wmi.c
devm_kzalloc will return NULL pointer if no memory was allocated.
This should be checked. This problem also existed when the driver
was dell-wmi.c.
Signed-off-by: Mario Limonciello
Reviewed-by: Pali Rohár
---
drivers/platform/x86/dell-wmi-descriptor.c | 5 +
1 file changed, 5 insertions
Unbound devices may race with calling this function causing the mutex
to stay locked. This failure mode should have released the mutex too.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-smbios-wmi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a
This failure mode should have also released the mutex.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/wmi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 8c31ed4..791449a 100644
--- a/drivers
Some of the failure scenarios weren't releasing acquired mutexes.
Here are some patches that correct them.
Mario Limonciello (2):
platform/x86: wmi: release mutex on module acquistion failure
platform/x86: dell-smbios-wmi: release mutex lock on WMI call failure
drivers/platform/x86
devm_kzalloc will return NULL pointer if no memory was allocated.
This should be checked. This problem also existed when the driver
was dell-wmi.c.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/dell-wmi-descriptor.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers
catches potential NULL pointer
- Avoid potential race condition between driver init and calling
check for if validation successful
Mario Limonciello (2):
platform/x86: dell-wmi-descriptor: check if memory was allocated
platform/x86: dell-*wmi*: Relay failed initial probe to dependent
1 - 100 of 382 matches
Mail list logo
