This failure mode should have also released the mutex.

Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com>
---
 drivers/platform/x86/wmi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 8c31ed4..791449a 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -868,8 +868,10 @@ static long wmi_ioctl(struct file *filp, unsigned int cmd, 
unsigned long arg)
        /* let the driver do any filtering and do the call */
        wdriver = container_of(wblock->dev.dev.driver,
                               struct wmi_driver, driver);
-       if (!try_module_get(wdriver->driver.owner))
-               return -EBUSY;
+       if (!try_module_get(wdriver->driver.owner)) {
+               ret = -EBUSY;
+               goto out_ioctl;
+       }
        ret = wdriver->filter_callback(&wblock->dev, cmd, buf);
        module_put(wdriver->driver.owner);
        if (ret)
-- 
2.7.4

Reply via email to