On Fri, May 03, 2024 at 09:28:25AM +0300, Mike Rapoport wrote:
> On Fri, May 03, 2024 at 01:23:30AM +0100, Liviu Dudau wrote:
> > On Thu, May 02, 2024 at 04:07:05PM -0700, Luis Chamberlain wrote:
> > > On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote:
> > > &
On Thu, May 02, 2024 at 04:07:05PM -0700, Luis Chamberlain wrote:
> On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote:
> > On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote:
> > > On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote:
> >
On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote:
> On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote:
> > From: "Mike Rapoport (IBM)"
> >
> > Hi,
> >
> > The patches are also available in git:
> > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=
>
> Fixes PCI errors like:
> pci_bus :00: root bus resource [io 0x]
>
> Fixes: 0b0b0893d49b ("of/pci: Fix the conversion of IO ranges into IO
> resources")
> Signed-off-by: Ilya Lipnitskiy
> Cc: Liviu Dudau
> ---
> arch/mips/pci/pci-legacy.c
= seq_read,
> - .llseek = seq_lseek,
> - .release= single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(komeda_register);
Hi Qinglang,
Sorry for the belated response!
Acked-by: Liviu Dudau
Best regards,
Liviu
>
> #ifdef CONFIG_DEBUG_FS
> static void komeda_debugf
se.state;
> + struct vkms_crtc_state *crtc_state = output->composer_state;
> +
> + if (!conn_state)
> + return;
> +
> + vkms_set_composer(&vkmsdev->output, true);
> +
> + spin_lock_irq(&output->composer_lock);
> + crtc_state->active_writeback = conn_state->writeback_job-&
On Thu, Jun 18, 2020 at 01:50:34PM +0100, Colin Ian King wrote:
> On 18/06/2020 13:14, Liviu Dudau wrote:
> > On Thu, Jun 18, 2020 at 11:04:00AM +0100, Colin King wrote:
> >> From: Colin Ian King
> >
> > Hi Colin,
> >
> >>
> >> Shifting th
On Thu, Jun 18, 2020 at 11:04:00AM +0100, Colin King wrote:
> From: Colin Ian King
Hi Colin,
>
> Shifting the integer value 1 is evaluated using 32-bit arithmetic
> and then used in an expression that expects a long value leads to
> a potential integer overflow.
I'm afraid this explanation mak
Hi Bernard,
On Fri, May 08, 2020 at 04:47:17PM +0800, Bernard wrote:
> From: "赵军奎"
> Date: 2020-04-24 19:37:36
> To: Liviu Dudau
> Cc: Brian Starkey ,David Airlie
> ,Daniel Vetter
> ,dri-de...@lists.freedesktop.org,linux-kernel@vger.kernel.org,opensource.ker.
On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The pointer disable_done is being initialized with a value that
> is never read and is being re-assigned a little later on. The
> assignment is redundant and hence can be removed.
Not really true, isn't it? Th
Hi Wen,
On Thu, Aug 22, 2019 at 10:11:35AM +0800, Wen He wrote:
> Configure the display Quality of service (QoS) levels priority if the
> optional property node "arm,malidp-aqros-value" is defined in DTS file.
>
> QoS signaling using AQROS and AWQOS AXI interface signals, the AQROS is
> driven fr
On Thu, Aug 15, 2019 at 11:14:17AM +, Wen He wrote:
>
>
> > -Original Message-
> > From: Liviu Dudau
> > Sent: 2019年7月22日 17:33
> > To: Wen He
> > Cc: dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> > brian.star...@arm.com;
On Fri, Aug 02, 2019 at 11:52:11AM +0200, Daniel Vetter wrote:
> On Fri, Aug 2, 2019 at 11:39 AM Brian Starkey wrote:
> >
> > Hi Liviu,
> >
> > On Thu, Aug 01, 2019 at 11:42:31AM +0100, Liviu Dudau wrote:
> > > Komeda has support to generate per-frame CRC value
On Tue, Jul 23, 2019 at 07:37:42AM +, Lowry Li (Arm Technology China) wrote:
> On Mon, Jul 22, 2019 at 04:18:01PM +0000, Liviu Dudau wrote:
> > On Mon, Jul 22, 2019 at 11:15:12AM +, james qian wang (Arm Technology
> > China) wrote:
> > > On Fri, Jul 19, 2019 at
On Fri, Jul 19, 2019 at 05:59:56PM +0800, Wen He wrote:
> This patch use the optional property node "arm,malidp-arqos-value" to
> can be dynamic configure QoS signaling.
>
> Signed-off-by: Wen He
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> arch/
On Thu, Jul 18, 2019 at 03:29:48AM +, Wen He wrote:
>
>
> > -Original Message-
> > From: Liviu Dudau
> > Sent: 2019年7月17日 19:22
> > To: Wen He
> > Cc: dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> > brian.star...@arm.com;
On Wed, Jun 26, 2019 at 09:56:19AM +0200, Pavel Machek wrote:
>
> On Mon 2019-06-24 17:56:45, Greg Kroah-Hartman wrote:
> > [ Upstream commit 6a88e0c14813d00f8520d0e16cd4136c6cf8b4d4 ]
> >
> > This patch trying to fix monitor freeze issue caused by drm error
> > 'flip_done timed out' on LS1028A p
On Fri, Jun 21, 2019 at 01:54:11PM +1000, Dave Airlie wrote:
> On Thu, 20 Jun 2019 at 20:35, Liviu Dudau wrote:
> >
> > Hi DRM maintainers,
> >
> > Picking up pace on the upstreaming of Komeda driver, with quite a lot
> > of new features added this time.
Fixes: a962091227ed ("drm/komeda: Add engine clock requirement check for the
> downscaling")
> Signed-off-by: Arnd Bergmann
Acked-by: Liviu Dudau
Thanks for the patch, I will pull it into the komeda tree.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/k
On Thu, Jun 13, 2019 at 10:17:27AM +0200, Daniel Vetter wrote:
> On Wed, Jun 12, 2019 at 02:26:24AM +, james qian wang (Arm Technology
> China) wrote:
> > On Tue, Jun 11, 2019 at 02:30:38PM +0200, Daniel Vetter wrote:
> > > On Tue, Jun 11, 2019 at 11:13:45AM +, Lowry Li (Arm Technology Chi
7; as it is not
> used anywhere.
>
> Signed-off-by: Ayan Kumar halder
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/
On Thu, Jun 13, 2019 at 11:08:14AM +0200, Daniel Vetter wrote:
> On Thu, Jun 13, 2019 at 09:28:13AM +0100, Liviu Dudau wrote:
> > On Thu, Jun 13, 2019 at 10:17:27AM +0200, Daniel Vetter wrote:
> > > On Wed, Jun 12, 2019 at 02:26:24AM +, james qian wang (Arm Technology
On Sat, Jun 08, 2019 at 04:13:35PM +1000, Stephen Rothwell wrote:
> Hi Liviu,
Hi Stephen,
>
> Commits
>
> 74332e53e41d ("drm/komeda: Add image enhancement support")
> 108ddcf9238f ("drm/komeda: Add engine clock requirement check for the
> downscaling")
> e980ebbe5cee ("drm/komeda: Add wr
p.org/series/58976/
>
> Reported-by: kbuild test robot
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
> ---
> .../gpu/drm/arm/display/komeda/d71/d71_component.c| 9 +
> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 4 ++--
> drivers/gpu/drm/arm
On Wed, Apr 10, 2019 at 03:23:39PM +0530, Vidya Sagar wrote:
> On 4/10/2019 1:44 PM, Liviu Dudau wrote:
> > On Wed, Apr 10, 2019 at 11:40:40AM +0530, Vidya Sagar wrote:
> > > On 4/9/2019 6:56 PM, Bjorn Helgaas wrote:
> > > > On Tue, Apr 09, 2019 at 05:00:53PM +0530, V
On Wed, Apr 10, 2019 at 11:40:40AM +0530, Vidya Sagar wrote:
> On 4/9/2019 6:56 PM, Bjorn Helgaas wrote:
> > On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote:
> > > On 4/6/2019 12:28 AM, Bjorn Helgaas wrote:
> > > > On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote:
> > > > > O
AINTAINERS section:
>
> 1162ARM KOMEDA DRM-KMS DRIVER
> 1163M: James (Qian) Wang
> 1164M: Liviu Dudau
> 1165L: Mali DP Maintainers
> 1166S: Supported
> 1167T: git git://linux-arm.org/linux-ld.
7; to identify this characteristic.
>
> Changes since v1:-
> - Merged https://patchwork.freedesktop.org/patch/265215/ into this patch
> - As Liviu pointed out in the last patch, we can pull the checks outside
> of the 'while (*modifiers != DRM_FORMAT_MOD_INVALID)' loop
>
nction ie
> malidp_de_set_plane_afbc().
>
> Changes from v2:
> - For AFBC framebuffer, layer input size register should be set to
> framebuffer's width and height.
>
> Changes from v3:
> - Rebased on top of latest drm-misc-next
> - Some cleanups/sanity changes based
On Thu, Jan 31, 2019 at 02:57:34PM -0800, Andrew Morton wrote:
> On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau wrote:
>
> > On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > >
> > >
> > > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> >
On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
>
>
> On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > In commit
> >
> > 6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> >
> > Fixes tag
> >
> > Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> >
On Fri, Jan 18, 2019 at 11:28:11AM +1100, Stephen Rothwell wrote:
> Hi Liviu,
>
> After merging the mali-dp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c: In function
> 'komeda_parse_dt':
> drivers/gpu/drm/arm/di
On Tue, Jan 15, 2019 at 01:38:19PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 1:24 PM Liviu Dudau wrote:
> >
> > On Tue, Jan 15, 2019 at 01:05:47PM +0100, Daniel Vetter wrote:
> > > On Mon, Jan 14, 2019 at 03:28:27PM +, Ayan Halder wrote:
> > > >
On Tue, Jan 15, 2019 at 01:05:47PM +0100, Daniel Vetter wrote:
> On Mon, Jan 14, 2019 at 03:28:27PM +, Ayan Halder wrote:
> > One needs to translate the Gralloc buffer flags for AFBC (eg
> > MALI_GRALLOC_INTFMT_AFBC_BASIC) to the corresponding linux kernel drm
> > modifiers.
> > This gets pass
On Tue, Jan 15, 2019 at 01:08:36PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 10:51:02AM +0000, Liviu Dudau wrote:
> > On Tue, Jan 15, 2019 at 09:47:25PM +1100, Stephen Rothwell wrote:
> > > Hi Liviu,
> > >
> > > On Tue, 15 Jan 2019 10:1
On Tue, Jan 15, 2019 at 09:47:25PM +1100, Stephen Rothwell wrote:
> Hi Liviu,
>
> On Tue, 15 Jan 2019 10:12:19 +0000 Liviu Dudau wrote:
> >
> > That looks like the right fix, thank you for that!
>
> Thanks for your verification.
>
> > I will roll your patc
The initial series is only introducing the basic components and not
implementing IRQ handling. Remove the left over code that touches
IRQs until the proper implementation is introduced in a later series.
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 5
On Tue, Jan 15, 2019 at 10:46:19AM +1100, Stephen Rothwell wrote:
> Hi Liviu,
Hi Stephen,
>
> After merging the mali-dp tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c: In function
> 'komeda_pipeline_obj_add':
On Mon, Jan 14, 2019 at 11:09:09AM +1100, Stephen Rothwell wrote:
> Hi Liviu,
Hi Stephen,
>
> Commits
>
> 31849148cb41 ("drm/komeda: Add komeda_framebuffer")
> b347a024e10b ("drm/komeda: Add komeda_format_caps for format handling")
> 274d16527e45 ("drm/komeda: Add DT parsing")
> f209783
defined DRM format modifiers. To facilitate
> > consistency and compatibility between different AFBC producers and
> > consumers, document the expectations for usage of the AFBC DRM format
> > modifiers in a new .rst chapter.
> >
> > Signed-off-by: Brian Starkey
>
the issue with NVMe HMBs. You can add my:
Tested-by: Liviu Dudau
Now I need to go and try to figure out why the rk_gmac-dwmac driver gives this
warning:
[ 11.277363] [ cut here ]
[ 11.277800] DMA-API: rk_gmac-dwmac fe30.ethernet: device driver frees
DMA me
Hello Christoph,
As I have mentioned to you after Xmas, I think your dma-mapping series breaks
NVMe drivers that use HMB on arm64 (RK3399 NanoPC T4 board with Toshiba RC100
SSD in this case). The observed behaviour is that the modprobe of the nvme
module will hang due to a kernel crash, which I've
. Without this change I'm getting
a kernel crash due to an invalid VM area being freed.
Signed-off-by: Liviu Dudau
---
drivers/nvme/host/pci.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c33bb201
in vunmap")
Signed-off-by: Liviu Dudau
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 871e41c55e239..806047d7fda3c 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1505,7 +1505,7 @@ static void __vunmap(const
On Fri, Dec 28, 2018 at 12:56:27PM +0100, Daniel Vetter wrote:
> On Fri, Dec 28, 2018 at 12:15 PM james qian wang (Arm Technology
> China) wrote:
> >
> > On Mon, Dec 24, 2018 at 02:05:43PM +0100, Daniel Vetter wrote:
> > > On Mon, Dec 24, 2018 at 1:33 PM Liviu Dudau wr
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology
China) wrote:
> On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote:
> > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology
> > China) wrote:
> > > Add komeda_
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology
China) wrote:
> On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote:
> > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology
> > China) wrote:
> > > Add komeda_
On Fri, Dec 21, 2018 at 10:00:49AM +, james qian wang (Arm Technology
China) wrote:
> v2: Some editing changes according to Randy Dunlap's comments
>
> Signed-off-by: James (Qian) Wang
Reviewed-by: Liviu Dudau
> ---
> Documentation/gpu/drivers.rst| 1 +
> D
On Fri, Dec 21, 2018 at 10:01:06AM +, james qian wang (Arm Technology
China) wrote:
> v2: Adjusted the position of KOMEDA by alphabetical order
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> MAINTAINERS | 9 +
>
v/null
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * (C) COPYRIGHT 2018 ARM Limited. All rights reserved.
> + * Author: James.Qian.Wang
> + *
> + */
> +#include "komeda_dev.h"
> +#include "komeda_kms.h"
> +
> +static struct drm_private_state *
> +komeda_pipeline_atomic_duplicate_state(struct drm_private_obj *obj)
> +{
> + struct komeda_pipeline_state *st;
> +
> + st = kmemdup(obj->state, sizeof(*st), GFP_KERNEL);
> + if (!st)
> + return NULL;
> +
> + st->active_comps = 0;
> +
> + __drm_atomic_helper_private_obj_duplicate_state(obj, &st->obj);
> +
> + return &st->obj;
> +}
> +
> +static void
> +komeda_pipeline_atomic_destroy_state(struct drm_private_obj *obj,
> + struct drm_private_state *state)
> +{
> + kfree(priv_to_pipe_st(state));
> +}
> +
> +static const struct drm_private_state_funcs komeda_pipeline_obj_funcs = {
> + .atomic_duplicate_state = komeda_pipeline_atomic_duplicate_state,
> + .atomic_destroy_state = komeda_pipeline_atomic_destroy_state,
> +};
> +
> +static int komeda_pipeline_obj_add(struct komeda_kms_dev *kms,
> +struct komeda_pipeline *pipe)
> +{
> + struct komeda_pipeline_state *st;
> +
> + st = kzalloc(sizeof(*st), GFP_KERNEL);
> + if (!st)
> + return -ENOMEM;
> +
> + st->pipe = pipe;
> + drm_atomic_private_obj_init(&pipe->obj, &st->obj,
> + &komeda_pipeline_obj_funcs);
> +
> + return 0;
> +}
> +
> +int komeda_kms_add_private_objs(struct komeda_kms_dev *kms,
> + struct komeda_dev *mdev)
> +{
> + struct komeda_pipeline *pipe;
> + int i, err;
> +
> + for (i = 0; i < mdev->n_pipelines; i++) {
> + pipe = mdev->pipelines[i];
> +
> + err = komeda_pipeline_obj_add(kms, pipe);
> + if (err)
> + return err;
> +
> + /* Add component */
> + }
> +
> + return 0;
> +}
> +
> +void komeda_kms_cleanup_private_objs(struct komeda_dev *mdev)
> +{
> + struct komeda_pipeline *pipe;
> + struct komeda_component *c;
> + int i, id;
> +
> + for (i = 0; i < mdev->n_pipelines; i++) {
> + pipe = mdev->pipelines[i];
> + dp_for_each_set_bit(id, pipe->avail_comps) {
> + c = komeda_pipeline_get_component(pipe, id);
> +
> + drm_atomic_private_obj_fini(&c->obj);
> + }
> + drm_atomic_private_obj_fini(&pipe->obj);
> + }
> +}
> --
> 2.17.1
>
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
create_handle,
> +};
> +
> +static int
> +komeda_fb_none_afbc_size_check(struct komeda_dev *mdev, struct komeda_fb
> *kfb,
> +struct drm_file *file,
> +const struct drm_mode_fb_cmd2 *mode_cmd)
Not sure what
-strict.
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/Makefile | 1 +
> .../gpu/drm/arm/display/komeda/d71/d71_dev.c | 78
> .../gpu/drm/arm/display/komeda/komeda_dev.c |
f "pipeline" to "pipe".
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> .../gpu/drm/arm/display/komeda/komeda_dev.c | 76 +++
> .../gpu/drm/arm/display/komeda/komeda_dev.h | 3 +
> .../drm/
gt; product->identify();
> ...
> }
>
> Changes in v3:
> - Fixed style problem found by checkpatch.pl --strict.
>
> Signed-off-by: James (Qian) Wang
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> .../gpu/drm/arm/display/include/malidp_io.h | 42 +++
; + };
> +
> + dp0_pipe1: pipeline@1 {
> + clocks = <&fpgaosc2>, <&dpu_aclk>;
> + clock-names = "pxclk", "aclk";
> + reg = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
same here.
> +
> + port@0 {
> + dp0_pipe1_out: endpoint {
> + remote-endpoint = <&db_dvi1_in>;
> + };
> + };
> + };
> + };
> + ...
> +};
> --
> 2.17.1
>
With these changes:
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
struct seq_file *sf);
> +};
> +
> +/**
> + * struct komeda_pipeline
> + *
> + * Represent a complete display pipeline and hold all functional components.
> + */
> +struct komeda_pipeline {
> + /** @obj: link pipeline as private obj of drm_atomic_state */
> + struct drm_p
On Fri, Dec 14, 2018 at 02:12:23PM +, Ayan Halder wrote:
> On Tue, Dec 04, 2018 at 04:57:46PM +0000, Liviu Dudau wrote:
>
> Hi Liviu,
> > On Mon, Dec 03, 2018 at 11:32:00AM +, Ayan Halder wrote:
> > > We have added some new formats to be supported on DP500/DP550/DP
On Fri, Dec 14, 2018 at 01:45:13PM +, Ayan Halder wrote:
> On Tue, Dec 04, 2018 at 04:50:51PM +0000, Liviu Dudau wrote:
>
> Hi Liviu,
>
> Please let me know if you agree with my comments. Then I will send a
> v4 patch for this.
> > On Mon, Dec 03, 2018 at 11:31:58AM
/patch/10460063/
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_hw.c | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
> index 55d379b
Signed-off-by: Julia Lawall
Acked-by: Liviu Dudau
Are you going to send the series to the arm-soc maintainers directly or
you want us to cherry-pick this patch into the Versatile tree?
Best regards,
Liviu
>
> ---
> arch/arm/mach-vexpress/spc.c |2 +-
> 1 file changed, 1 inse
On Thu, Oct 18, 2018 at 01:14:32AM +0100, Liviu Dudau wrote:
> Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> removed the common code path that set the led_dat->gpiod pointer in
> create_gpio_led(), but only added it back for the devic
Anaszewski
Signed-off-by: Liviu Dudau
---
Hi,
I found this issue while testing linux-next-20181017, I don't know how
stable the leds for-next tree is in terms of commit IDs, if that gets
rebased then the Fixes commit ID needs updating.
Best regards,
Liviu
drivers/leds/leds-gpio
On Mon, Sep 24, 2018 at 03:40:15PM +0100, Ayan Halder wrote:
> Hi Liviu,
Hi Ayan,
>
> On Fri, Sep 21, 2018 at 03:33:53PM +0100, Liviu Dudau wrote:
> > From: Ayan Kumar Halder
> >
> > Add support for compressed framebuffers that are described using
> > the fram
On Sat, Sep 22, 2018 at 08:58:34AM +1000, Stephen Rothwell wrote:
> Hi Liviu,
Hi Stephen,
>
> Commit
>
> fd75f5726f65 ("drm/mali-dp: Implement plane alpha and pixel blend on
> malidp")
>
> is missing a Signed-off-by from its committer.
My bad, I cherry picked-it from a staging tree and did
On Fri, Jul 27, 2018 at 11:15:37AM +0100, Suzuki K Poulose wrote:
> Switch to updated coresight bindings for Juno platforms.
>
> Cc: Sudeep Holla
> Cc: Liviu Dudau
> Signed-off-by: Suzuki K Poulose
Looks good to me.
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
resource(), we can
> use devm_ioremap_resource() which has the NULL pointer check and the
> memory region requesting. devm_ioremap_resource is designed to replace
> calls to devm_request_mem_region followed by devm_ioremap, so let's use
> the same.
>
> Cc: Liviu Dudau
> Cc
e_afbc(). This will consolidate all the
> AFBC specific register configurations in a single function ie
> malidp_de_set_plane_afbc().
>
> Signed-off-by: Ayan Kumar halder
> Reviewed-by: Brian Starkey
Acked-by: Liviu Dudau
Thanks,
Liviu
> ---
> drivers/gpu/drm/arm/m
ccept the capability if the client has already set the
DRM_CLIENT_CAP_ATOMIC one.
- update the capability number to fix conflict with the aspect ratio
Reviewed-by: Eric Anholt
Re-requested-by: Sean Paul
Cc: Brian Starkey
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/drm_ioctl.c
func for writeback jobs]
Signed-off-by: Rob Clark
Signed-off-by: Liviu Dudau
---
Documentation/gpu/drm-kms.rst| 9 +
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/drm_atomic.c | 128
drivers/gpu/drm/drm_atomic_helper.c | 30 +++
drivers
overwrite
when setting out_fence fd") (change out_fence_ptr to s32 __user *,
for real this time.)
- Update documentation around WRITEBACK_OUT_FENCE_PTR
Reviewed-by: Eric Anholt
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
Signed-off-
drm: Add writeback connector type
drm: writeback: Add out-fences for writeback connectors
Liviu Dudau (1):
drm: writeback: Add client capability for exposing writeback
connectors
Documentation/gpu/drm-kms.rst| 9 +
drivers/gpu/drm/Makefile | 2
On Wed, May 23, 2018 at 11:34:32AM +0200, Maarten Lankhorst wrote:
> Op 18-05-18 om 17:17 schreef Liviu Dudau:
> > Due to the fact that writeback connectors behave in a special way
> > in DRM (they always report being disconnected) we might confuse some
> > userspace. Add a
On Mon, May 21, 2018 at 12:02:25PM -0700, Eric Anholt wrote:
> Liviu Dudau writes:
>
> > From: Brian Starkey
> >
> > Add the WRITEBACK_OUT_FENCE_PTR property to writeback connectors, to
> > enable userspace to get a fence which will signal once the writeback is
&
eous use of out_fence that is only introduced in a
subsequent patch.
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
[rebased and added atomic_commit() vfunc for writeback jobs]
Signed-off-by: Rob Clark
Signed-off-by: Liviu Dudau
---
Documentation
Paul
Cc: Brian Starkey
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/drm_ioctl.c | 7 +++
drivers/gpu/drm/drm_mode_config.c | 5 +
include/drm/drm_file.h| 7 +++
include/uapi/drm/drm.h| 9 +
4 files changed, 28 insertions(+)
diff --git a/dr
: writeback: Add out-fences for writeback connectors
Liviu Dudau (1):
drm: writeback: Add client capability for exposing writeback
connectors
Documentation/gpu/drm-kms.rst| 9 +
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/drm_atomic.c | 227
overwrite
when setting out_fence fd") (change out_fence_ptr to s32 __user *,
for real this time.)
- Update documentation around WRITEBACK_OUT_FENCE_PTR
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
Signed-off-by: Liviu Dudau
---
drivers/gpu/d
On Fri, May 18, 2018 at 09:56:20AM +0100, Brian Starkey wrote:
> Hi Liviu,
>
> On Fri, May 18, 2018 at 09:24:21AM +0100, Liviu Dudau wrote:
> > Mali DP500 behaves differently from the rest of the Mali DP IP,
> > in that it does not have a one-shot mode and keeps writing t
(and drop malidp_mw_job)
Changes since v3:
- Modifications to fit with Mali-DP commit tail changes
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/Makefile | 1 +
drivers/gpu/drm/arm/malidp_cr
missing vsync interrupt for DP550
Signed-off-by: Liviu Dudau
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/malidp_hw.c | 54 +--
drivers/gpu/drm/arm/malidp_hw.h | 17 ++
drivers/gpu/drm
n the next vblank/prefetch.
CVAL interrupt will fire durint the next prefetch phase every time
the global CVAL bit gets set, so we need a state byte to track
the memory write enabling.
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_hw.c | 77 +--
drivers/gp
From: Brian Starkey
Add a layer bit for the SE memory-write, and add it to the pixel format
matrix for DP550/DP650.
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_hw.c | 22
Annotate the pixel format matrix for DP500 with the memory-write flag
for formats that are supported by the SE memwrite engine.
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_hw.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm
l/2017-May/141799.html
Best regards,
Liviu
[1] https://lists.freedesktop.org/archives/dri-devel/2018-May/177125.html
Brian Starkey (2):
drm: mali-dp: Add RGB writeback formats for DP550/DP650
drm: mali-dp: Add writeback connector
Liviu Dudau (3):
drm: mali-dp: Add support for writebac
gned-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
[rebased and added atomic_commit() vfunc for writeback jobs]
Signed-off-by: Rob Clark
Signed-off-by: Liviu Dudau
---
Documentation/gpu/drm-kms.rst| 9 +
drivers/gpu/drm/Makefile
overwrite
when setting out_fence fd") (change out_fence_ptr to s32 __user *,
for real this time.)
- Update documentation around WRITEBACK_OUT_FENCE_PTR
Signed-off-by: Brian Starkey
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
Signed-off-by: Liviu Dudau
---
drivers/gpu/d
-devel/2018-February/167703.html
Brian Starkey (2):
drm: Add writeback connector type
drm: writeback: Add out-fences for writeback connectors
Liviu Dudau (1):
drm: writeback: Add client capability for exposing writeback
connectors
Documentation/gpu/drm-kms.rst| 9 +
drivers
Paul
Cc: Brian Starkey
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/drm_ioctl.c | 7 +++
drivers/gpu/drm/drm_mode_config.c | 5 +
include/drm/drm_file.h| 7 +++
include/uapi/drm/drm.h| 9 +
4 files changed, 28 insertions(+)
diff --git a/dr
On Fri, May 04, 2018 at 02:32:03PM +0530, Satendra Singh Thakur wrote:
> On Thu, May 03, 2018 at 11:36:39 +0100, Liviu Dudau wrote:
> > On Thu, May 03, 2018 at 11:28:37AM +0530, Satendra Singh Thakur wrote:
> > > 1.
> > > -Added a new helper drm_display_mode_crtc_to_v
->crtc_hsync_end;
> - vm.hsync_len = m->crtc_hsync_end - m->crtc_hsync_start;
> -
> + drm_display_mode_crtc_to_videomode(m, &vm);
> polarities = HDLCD_POLARITY_DATAEN | HDLCD_POLARITY_DATA;
>
> if (m->flags & DRM_MODE_FLAG_PHSYNC)
For the HD
On Wed, Apr 25, 2018 at 09:17:22AM +0200, Daniel Vetter wrote:
> On Tue, Apr 24, 2018 at 07:12:47PM +0100, Ayan Kumar Halder wrote:
> > malidp_pm_suspend_late checks if the runtime status is not suspended
> > and if so, invokes malidp_runtime_pm_suspend which disables the
> > display engine/core in
s
> patch enables MASK_IRQ_EN for SE to fix this problem.
>
> Signed-off-by: Alison Wang
Acked-by: Liviu Dudau
Thanks for catching this! I'll pull the patch into the mali-dp tree.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_hw.c |3 ++-
> 1 files chang
On Mon, Apr 23, 2018 at 03:50:49PM +0100, Ayan Kumar Halder wrote:
> Scaling engine interrupts need to be enabled/disabled as and when memwrite
> is enabled and disabled. The reason being scaling engine interrupts are
> used only by the memory writeout layer.
>
> This patch depends on:
> https://l
: Ayan Kumar Halder
With the updated commit message:
Acked-by: Liviu Dudau
> ---
>
> Changes in v2:
> - Reset the connectors' mask and the reference counts in drm_device
> before unbinding any of its components (ie connectors and
> encoders).
>
> ---
>
reset values.
>
> Reported-by: Brian Starkey
> Reported-by: Liviu Dudau
> Signed-off-by: Ayan Kumar halder
Acked-by: Liviu Dudau
Thanks for catching this in testing!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 5 -
> 1 file changed, 4 insertions(+)
abled is the wrong flag to use here, as when we get an
atomic commit that turns off the CRTC it will still be enabled until
after the commit is done. Use the crtc->state->active for test.
Reported-by: Alexandru-Cosmin Gheorghe
Signed-off-by: Liviu Dudau
---
drivers/gpu/d
ey
Reported-by: Alexandru-Cosmin Gheorghe
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_drv.c | 30 --
drivers/gpu/drm/arm/malidp_drv.h | 1 +
drivers/gpu/drm/arm/malidp_hw.c | 12 +---
3 files changed, 26 insertions(+), 17 deletions(-)
diff --gi
ending the userspace event from the IRQ handler, when we
handle the config_valid interrupt, which syncs with the time when the
hardware is active with the new parameters.
Reported-by: Alexandru-Cosmin Gheorghe
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/arm/malidp_
The drm_setclientcap() function implementing the DRM_IOCTL_SET_CLIENT_CAP
ioctl expects that any capability set by the client will have a value of 1.
Make the check early so that we don't have to test the value for each
capability.
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/drm_ioctl.
[rebased and fixed conflicts]
Signed-off-by: Mihail Atanassov
[rebased and added atomic_commit() vfunc for writeback jobs]
Signed-off-by: Rob Clark
Signed-off-by: Liviu Dudau
---
Documentation/gpu/drm-kms.rst| 9 ++
drivers/gpu/drm/Makefile | 2 +-
drivers
1 - 100 of 975 matches
Mail list logo
