> > > > +static int fsl_pwm_parse_clk_ps(struct fsl_pwm_chip *fpc)
> > > > +{
> > > > + int ret;
> > > > + struct of_phandle_args clkspec;
> > > > + struct device_node *np = fpc->chip.dev->of_node;
> > > > +
> > > > + fpc->sys_clk = devm_clk_get(fpc->chip.dev, "ftm0");
> > >
> > +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec) {
> > + struct regulator *consumer;
> > + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
> > +
> > + consumer = regulator_get_optional(codec->dev,
> > + sgtl5000->supplies[VDDD].supp
> > +"ftm0" (module clock),
> > +"ftm0_counter" (counter clock),
> > +- clocks : Must contain a clock specifier for each entry in
> > +clock-names,
> > + See clock/clock-bindings.txt for details of the property values.
>
> Note that the order is significant here, at least from the way th
>
> > +"ftm0" (module clock),
> > +"ftm0_counter" (counter clock),
> > +- clocks : Must contain a clock specifier for each entry in
> > +clock-names,
> > + See clock/clock-bindings.txt for details of the property values.
>
> Note that the order is significant here, at least from the way
> > > > +#define FTM_CNTIN_VAL 0x00
> > >
> > > Do we really need this?
> > >
> >
> > Maybe not, I think that the initial value maybe modified in the future.
> > And this can be more easy to ajust it.
>
> Why would it need to be modified?
>
Well, for the PWM function modifying it make no s
> > +#define FTM_CNTIN_VAL 0x00
>
> Do we really need this?
>
Maybe not, I think that the initial value maybe modified in the future.
And this can be more easy to ajust it.
> > + period_cycles = fsl_rate_to_cycles(fpc, period_ns);
> > + if (period_cycles > 0x) {
> > +
Hi Thierry,
Thanks for your detail comments.
> > + switch (fpc->counter_clk_select) {
> > + case VF610_CLK_FTM0:
> > + reg |= FTMSC_CLKSYS;
> > + break;
> > + case VF610_CLK_FTM0_FIX_SEL:
> > + reg |= FTMSC_CLKFIX;
> > + break;
> > + case VF610_CLK_
> Subject: Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while getting
> regulator consumers
>
> On Wed, Nov 27, 2013 at 08:13:03AM +0000, Li Xiubo wrote:
>
> Please fix your mailer to word wrap within paragraphs, it makes your mail
> much more legible.
>
Yes, I
> > +static int sgtl5000_external_vddd_used(struct snd_soc_codec *codec)
> > +{
> > + struct regulator *consumer;
> > + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec);
> > +
> > + consumer = regulator_get(codec->dev, sgtl5000-
> >supplies[VDDD].supply);
> > + if (IS_ERR(c
> > else {
> > ret = sgtl5000_replace_vddd_with_ldo(codec);
> >
> You could fix the coding style issue (braces on both branches of the if
> clause) here too.
>
>
Yes, I will.
Thanks.
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z�
Hi Thierry,
Could you help review this series of patches please ?
And could it be merged into the PWM next tree?
Thanks very much.
--
> Subject: [PATCHv6 0/4] Add Freescale FTM PWM driver.
>
> Hello Thierry,
>
> The series of patches for this version has been reviewed and acked
> already.
Hi Thierry,
The document binding patch of this patch series has been acked.
And other patches have been acked before.
Should I send a V6 patch series ?
Thanks very much.
--
> Subject: [RFCv2][PATCHv5 0/4] Add Freescale FTM PWM driver.
>
> Hello,
>
> This patch series is the Freescale FTM P
Hi Therry,
The binding patch has been acked, how about the other patches ?
If they are all okey, should I sent a another official version again ?
Thanks.
--
Xiubo
> Subject: [RFCv2][PATCHv5 0/4] Add Freescale FTM PWM driver.
>
> Hello,
>
> This patch series is the Freescale FTM PWM imple
13 matches
Mail list logo
