> Subject: Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while getting > regulator consumers > > On Wed, Nov 27, 2013 at 08:13:03AM +0000, Li Xiubo wrote: > > Please fix your mailer to word wrap within paragraphs, it makes your mail > much more legible. >
Yes, I will. > > There is one dependency patch: "regulator: core: Provide a dummy > regulator with full constraints". > > > From the dependency patch, we can see that using regulator_get_optional() > instead can resovle the problem you descripted above. > > > When or will this dependency patch be merged into the -next tree ? > > That patch is already in mainline. > Okey. > > > I'd expect to see a commit description that describes how the driver > > > currently tries to handle this, why it doesn't work and how the > > > patch fixes it. > > > The SGTL5000 requires 2 external power supplies: VDDA and VDDIO. An > > optional third external power supply VDDD may be provided externally > > You need to put your working through of this stuff in the commit message. I did it already, please see the next version. -- Best Regards, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
