Re: [PATCH] arm: fault.c: fix unhandled page fault message

2015-07-16 Thread Levente Kurusa
Hi, - Original Message - > On Wed, Jul 15, 2015 at 05:30:50PM +0200, Levente Kurusa wrote: > > Even if the signal was handled using signal(2) the message > > would be printed. Fix that by checking whether the signal > > is handled. > > Why? One of the reaso

[PATCH] arm: fault.c: fix unhandled page fault message

2015-07-15 Thread Levente Kurusa
Even if the signal was handled using signal(2) the message would be printed. Fix that by checking whether the signal is handled. Signed-off-by: Levente Kurusa --- arch/arm/mm/fault.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/fault.c b/arch/arm/mm

Re: [PATCH] lib/kstrtox.c break if overflow is detected

2015-01-21 Thread Levente Kurusa
return rv; > - if ((long long)tmp < 0) > - return -ERANGE; > - *res = tmp; > + sign = -1; > + s++; > } > + > + rv = kstrtoull(s, base, &tmp); > + if (rv < 0) > + return

Re: [PATCH] dma: xilinx: Remove .owner field for driver

2014-08-13 Thread Levente Kurusa
use the module_platform_driver API, as this is overriden in > platform_driver_register anyway." > > Signed-off-by: Michal Simek Reviewed-by: Levente Kurusa Cheers, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c

2014-07-22 Thread Levente Kurusa
u asked us for them in November. Until then, please stop trying for FIXMEs. They will not get you a commit in the kernel 99% of the time. Hope you understand, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] [media] davinci-vpfe: Fix retcode check

2014-07-08 Thread Levente Kurusa
econd argument. Did it cause a build warning for you? (Can't really check since I don't have ARM cross compilers close-by) If not, then: Reviewed-by: Levente Kurusa Thanks, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: Cleanup of Kernel Bugzilla

2014-06-29 Thread Levente Kurusa
s :-), I guess there are some maintainers who care about bugzilla, but the rest (and the majority probably) does not care. I tend to think that even if we clean up the bugzilla, it will only be a question of time until it gets to the state that it is in now. Thanks, Levente Kurusa -- To unsubs

Re: [PATCHv4]Checks for Null value in function *get_skub

2014-06-16 Thread Levente Kurusa
character after the comment. :-( Thanks, Levente Kurusa. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv4]Checks for Null value in function *get_skub

2014-06-16 Thread Levente Kurusa
ee(x); so I guess it is not really needed. Thanks, Levente Kurusa. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Levente Kurusa
7;t kfree(NULL) legal? (i.e. the if statement is useless) Thanks, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH] staging: rtl8821ae: rtl8821ae: hw.c: Cleaning up if statement that always evaluates to false

2014-06-11 Thread Levente Kurusa
t; rtl_write_byte(rtlpriv, (MSR), bt_msr); > > rtlpriv->cfg->ops->led_control(hw, ledaction); > > - if ((bt_msr & ~0xfc) == MSR_AP) > > + if ((bt_msr & MSR_AP) == MSR_AP) I changed this line from '0xfc' to '~0xfc', and looking at t

[PATCH] staging: rtl8821ae: fix pointer coding style

2014-05-10 Thread Levente Kurusa
Found by checkpatch. Signed-off-by: Levente Kurusa --- drivers/staging/rtl8821ae/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c index a562aa6..7bbaef7 100644 --- a/drivers/staging/rtl8821ae/pci.c

[PATCH] libata: clean up ZPODD when a port is detached

2014-05-06 Thread Levente Kurusa
port's devices and checks if zpodd is enabled, if so call zpodd_exit. Cc: sta...@vger.kernel.org Reviewed-by: Aaron Lu Signed-off-by: Levente Kurusa --- drivers/ata/libata-core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-c

Re: [PATCH] ahci: unregister acpi notify handler when a ZPODD is unbound

2014-05-06 Thread Levente Kurusa
Hi, On 05/06/2014 08:07 AM, Aaron Lu wrote: > On 05/06/2014 02:02 PM, Levente Kurusa wrote: >> Hi, >> >> On 05/06/2014 05:16 AM, Aaron Lu wrote: >>> On 05/01/2014 12:04 AM, Levente Kurusa wrote: >>>> When a ZPODD device is unbound via sysfs, the acp

Re: [PATCH] ahci: unregister acpi notify handler when a ZPODD is unbound

2014-05-05 Thread Levente Kurusa
Hi, On 05/06/2014 05:16 AM, Aaron Lu wrote: > On 05/01/2014 12:04 AM, Levente Kurusa wrote: >> When a ZPODD device is unbound via sysfs, the acpi notify handler >> is not removed. This causes panics as observed in Bug #74601. The > > Ah...too bad, I forgot to consider this

Re: [PATCH v2 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations

2014-05-05 Thread Levente Kurusa
t; indeed. But since the v1 was performed partially for the Eudyptula > Project and since it was a response to a modification request, > I though it was implicit. No, the tree's name is not needed. In fact, I should have checked it in linux-next, but I only checked Linus', and staging-next thinking, since you said it was applied, it was applied to staging-next. :-) > > > Could you please as well remove that empty line in the declarations? > > I'll do. > Cheers. Regards, Levente Kurusa signature.asc Description: Digital signature

Re: [PATCH v2 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations

2014-05-04 Thread Levente Kurusa
ser(info_buf, wrqu->data.pointer, sizeof(info_buf))) > + return -EFAULT; > + > + oid = info_buf[0]; > + bPromiscuousOn = info_buf[1]; > + bFilterSourceStationFrame = info_buf[2]; > > if (OID_RT_INTEL_PROMISCUOUS_MODE == oid) { > ieee->IntelPromiscuousModeInfo.bPromiscuousOn = -- Regards, Levente Kurusa signature.asc Description: Digital signature

[PATCH] ahci: unregister acpi notify handler when a ZPODD is unbound

2014-04-30 Thread Levente Kurusa
zpodd_exit to be called for all ZPODD devices on the unbound PCI device. Signed-off-by: Levente Kurusa --- Hi, I am not sure if the loop below is correct. Maybe there is a better solution to loop through all the devices which might use ZPODD? Thanks, Lev. drivers/ata/ahci.c | 21

Re: [PATCH 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations

2014-04-27 Thread Levente Kurusa
fines for those instead of hard-coding the offsets. Also the size of the info_buf array might change depending on the size of wrqu->data.pointer, right? Maybe create a new define for that as well? Let's just be safe and create new defines to prevent headaches in the future, if not for futher expansion then for the sake of legibility. Thanks, Levente Kurusa signature.asc Description: Digital signature

Re: [PATCH] Staging: octeon-usb: fixed a macro coding style issue

2014-04-25 Thread Levente Kurusa
> (0)) > +#define (CVMX_PREFETCH(address, offset) asm volatile ("pref %[type], > %[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n" > (0))) Not that way around! :-) The parantheses should be around the code block not the name

Re: [RFC] QR encoding for Oops messages

2014-04-13 Thread Levente Kurusa
Hi, 2014-04-08 19:29 GMT+02:00 Levente Kurusa : > Hi, > > On 04/08/2014 07:20 PM, Jason Cooper wrote: >> On Tue, Apr 08, 2014 at 05:42:00PM +0200, Levente Kurusa wrote: >>> On 04/07/2014 05:20 PM, Jason Cooper wrote: >>>> On Sat, Apr 05, 2014 at 11:11:02AM +

Re: [RFC] QR encoding for Oops messages

2014-04-08 Thread Levente Kurusa
Hi, On 04/08/2014 07:20 PM, Jason Cooper wrote: > On Tue, Apr 08, 2014 at 05:42:00PM +0200, Levente Kurusa wrote: >> On 04/07/2014 05:20 PM, Jason Cooper wrote: >>> On Sat, Apr 05, 2014 at 11:11:02AM +0200, Levente Kurusa wrote: >>>> Oh and another suggestion, I

Re: [RFC] QR encoding for Oops messages

2014-04-08 Thread Levente Kurusa
Hi, On 04/07/2014 05:20 PM, Jason Cooper wrote: > On Sat, Apr 05, 2014 at 11:11:02AM +0200, Levente Kurusa wrote: >> Or, we could use core_param and simply have 'oops_qr' or >> 'qr_oops'. In my humble opinion the latter sounds better. > > Ack. My origina

Re: [RFC] QR encoding for Oops messages

2014-04-05 Thread Levente Kurusa
Hi, On 04/04/2014 11:42 PM, Teodora Băluţă wrote: > On Fri, Apr 4, 2014 at 7:17 PM, Levente Kurusa wrote: >> Hi, >> >> On 04/04/2014 05:15 PM, Jason Cooper wrote: >>> On Thu, Apr 03, 2014 at 01:57:04PM -0700, David Lang wrote: >>>> On Tue, 1 Apr 2014, J

Re: [RFC] QR encoding for Oops messages

2014-04-04 Thread Levente Kurusa
ld we gain from it? Supporting those devices without a framebuffer? Do devices like that even exist anymore? In fact, even to make this you need a screen, and AFAIK most screens come with some kind of a framebuffer to drive them. -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] QR encoding for Oops messages

2014-04-04 Thread Levente Kurusa
Hi, On 04/04/2014 05:12 PM, Jason Cooper wrote: > On Thu, Apr 03, 2014 at 10:21:39PM +0200, Levente Kurusa wrote: > ... >> Oh and I had an idea of adding a new kernel parameter, something >> like 'qr_oops.*'. (Looking for a better name! :-) ) >> Basically, I t

Re: [RFC] QR encoding for Oops messages

2014-04-03 Thread Levente Kurusa
Hi, 2014-04-01 23:07 GMT+02:00 Teodora Băluţă : > On Tue, Apr 1, 2014 at 5:20 PM, Jason Cooper wrote: >> On Sun, Mar 30, 2014 at 12:17:17PM +0200, Levente Kurusa wrote: >>> Hi all, >>> >>> (sorry for the late reply, looks like this mail has ran away

[PATCH RESEND] tc: account for device_register() failure

2014-04-02 Thread Levente Kurusa
This patch makes the TURBOchannel driver bail out if the call to device_register() failed. Signed-off-by: Levente Kurusa --- Resending as per Maciej's request to proper list and people. --- tc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tc/t

Re: [PATCH] tc: account for device_register() failure

2014-04-01 Thread Levente Kurusa
Hi, 2014-04-01 2:30 GMT+02:00 Maciej W. Rozycki : > On Fri, 15 Nov 2013, Levente Kurusa wrote: > >> This patch makes the TURBOchannel driver bail out if the call >> to device_register() failed. >> >> Signed-off-by: Levente Kurusa > > Acked-by: Maciej W

Re: [RFC] QR encoding for Oops messages

2014-03-30 Thread Levente Kurusa
Hi all, (sorry for the late reply, looks like this mail has ran away from my clients) 2014-03-23 20:38 GMT+01:00 Jason Cooper : > All, > > On Sat, Mar 22, 2014 at 08:20:01PM +0200, Teodora Băluţă wrote: >> On Sat, Mar 22, 2014 at 7:09 PM, Levente Kurusa wrote: >> > On 03

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Levente Kurusa
ith whitspace too. > > What I think might be reasonable is: > > - get rid of the dependency list in form of a include into the Makefile and > just generate the cpio-archive every time make is called. Common initramfs > sizes are about a few megabytes and with today machines such a

Re: [RFC] QR encoding for Oops messages

2014-03-23 Thread Levente Kurusa
Hi, On 03/22/2014 07:29 PM, Levente Kurusa wrote: > Hi, > > On 03/22/2014 07:20 PM, Teodora Băluţă wrote: >> On Sat, Mar 22, 2014 at 7:09 PM, Levente Kurusa wrote: >>> Hi, >>> >>> On 03/21/2014 02:28 PM, Jason Cooper wrote: >>>> On Wed,

Re: [RFC] QR encoding for Oops messages

2014-03-22 Thread Levente Kurusa
Hi, On 03/22/2014 07:20 PM, Teodora Băluţă wrote: > On Sat, Mar 22, 2014 at 7:09 PM, Levente Kurusa wrote: >> Hi, >> >> On 03/21/2014 02:28 PM, Jason Cooper wrote: >>> On Wed, Mar 19, 2014 at 10:38:30PM +0200, Teodora Băluţă wrote: >>>> On Wed, M

Re: [RFC] QR encoding for Oops messages

2014-03-22 Thread Levente Kurusa
[0]. We should try to shorten it, imho. Not sure how to do that though. oops.kernel.org/?qr=CODE would look cool though. :-) > > Anyway, if you're interested, I'll be re-posting a patch for objdiff > separately maybe today or this weekend. [0]: http://paste.fedoraproject.org/87665/39550664/ -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] initramfs: print error and shell out for unsupported content

2014-03-20 Thread Levente Kurusa
ries are:\n$unsupported\n" >&2 > + exit 1 > + fi > + I think it would be worthy to tell the user what kind of characters are unsupported. For instance, tell them that 'spaces' are unsupported. > dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n") > > # If $dirlist is only one line, then the directory is empty > [...] -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] QR encoding for Oops messages

2014-03-19 Thread Levente Kurusa
Hi, 2014-03-19 21:50 GMT+01:00 Teodora Băluţă : > On Wed, Mar 19, 2014 at 10:28 PM, Levente Kurusa wrote: >> Hi, >> >> 2014-03-19 21:18 GMT+01:00 Dave Jones : >>> On Mon, Mar 17, 2014 at 02:59:47PM -0700, Teodora Baluta wrote: >>> > This feature encod

Re: [RFC] QR encoding for Oops messages

2014-03-19 Thread Levente Kurusa
we don't output kernel oopses in kanji for eg, and won't care about > multiple versions of the qr spec. > > How much of this could we drop ? A lot, most likely. Also, I wonder if we could do the same for panic()? I hate it when I receive a panic and I have no idea wha

Re: [PATCH] regmap: Ensure regmap_register_patch() is compatible with fast_io

2014-03-18 Thread Levente Kurusa
); > + if (p) { > + memcpy(p + map->patch_regs, regs, num_regs * sizeof(*regs)); > + map->patch = p; > + map->patch_regs += num_regs; > + } else { > + return -ENOMEM; > + } > + I think that is not c

Re: [PATCH] staging: comedi: fix memory leak

2014-03-14 Thread Levente Kurusa
On 03/15/2014 04:30 AM, Chase Southwood wrote: >> On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote: > >> Call kfree() on bdev. The variable is otherwise leaked. >> >> Signed-off-by: Levente Kurusa >> [...] >> > > > Levente, > > Th

[PATCH] staging: comedi: fix memory leak

2014-03-14 Thread Levente Kurusa
Call kfree() on bdev. The variable is otherwise leaked. Signed-off-by: Levente Kurusa --- drivers/staging/comedi/drivers/comedi_bond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c index 51a59e5

Re: [PATCH 1/1] Add documentation for proper usage and order of preference of calls to print diagnostic messages.

2014-03-04 Thread Levente Kurusa
bug messages. > Signed-off-by: Yogesh Chaudhari Acked-by: Levente Kurusa > --- > Documentation/CodingStyle | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 7fe0546..083f738 100644 > ---

Re: [PATCH 1/1] Add documentation for proper usage and order of preference of calls to print diagnostic messages.

2014-03-04 Thread Levente Kurusa
you have them, they can be a huge help for remote troubleshooting. Such > messages should be compiled out when the DEBUG symbol is not defined (that I think we should also mention *_warn, *_err etc not just *_dbg. -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "

Re: [Patch 1/1] Changes to scripts/checkpatch.pl for improving warning messages in case printk usage is detected in a patch

2014-03-04 Thread Levente Kurusa
prefered instead of preffered. > Signed-off-by: Yogesh Chaudhari Other than that: Acked-by: Levente Kurusa Thank you! > [...] -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
Hi, 2014-03-02 16:40 GMT+01:00 Joe Perches : > On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: >> IMHO, this message is too big. The one we already have is nice and clean. >> I would simply do: s/netdev/[subsystem]/ or something among the lines. > > maybe: >

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
Hi, [+CC LKML, Joe] [Leaving full copy for LKML, Joe] On 03/02/2014 04:29 PM, Yogesh Chaudhari wrote: > On 2 March 2014 20:50, Levente Kurusa wrote: >> Hi, >> >> On 03/02/2014 04:01 PM, Yogesh Chaudhari wrote: >>> Based on the discussion here: >>> http

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
2. dev_$level2(dev, ... for drivers with struct device > + 3. pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); > } > > if ($line =~ /\bpr_warning\s*\(/) { > IMHO, this message is too big. The one we already hav

Re: How to get rid of IRQF_DISABLED for good?

2014-02-20 Thread Levente Kurusa
ey don't reply, send it to Andrew Morton as well and CC a few people who know your work is good so that they can ACK it. Oh and maybe you could add an __attribute__((deprecated)) to it, but I am not sure that's possible and/or correct. -- Regards, Levente Kurusa -- To unsubscribe from t

[PATCH] staging: davinci_vpfe: fix error check

2014-02-15 Thread Levente Kurusa
The check would check the pointer, which is never less than 0. According to the error message, the correct check would be to check the return value of ipipe_mode. Check that instead. Reported-by: David Binderman Signed-off-by: Levente Kurusa --- drivers/staging/media/davinci_vpfe

Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

2014-02-15 Thread Levente Kurusa
On 02/15/2014 11:36 AM, Dan Carpenter wrote: > On Sat, Feb 15, 2014 at 08:53:34AM +0100, Levente Kurusa wrote: >> Thanks Dan, maybe you know some people who could test it? >> RTLXX guys? Or maybe we can take the patch as is? >> I cannot really think of any other solutio

[PATCH] staging: rts5208: fix always true condition

2014-02-15 Thread Levente Kurusa
ANDing anything with 0x1E and expecting it to be not 0x03 will always be true. AND instead with 0x03, so that we check the last two bits, which should be what was intended there. Reported-by: David Binderman Signed-off-by: Levente Kurusa --- drivers/staging/rts5208/sd.c | 2 +- 1 file changed

Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

2014-02-14 Thread Levente Kurusa
se, but since that was written to the file, there must have been some logic behind that. I am slightly disappointed get_maintainer didn't really find anybody for this patch... Greg, can you take it as is or you would need the RFC tag removed? (ie, repost) Maybe you know somebody who could test

[PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

2014-02-14 Thread Levente Kurusa
Since MSR_AP is 0x3, ANDing it with 0xFC will never be true. Add a NOT operation to 0xFC so that we will AND with the last three bits which will result in a possibility that the condition will succeed. Signed-off-by: Levente Kurusa --- Hi, This might not be the real solution since it is also

Re: [PATCH 3.11 229/233] ALSA: hda - hdmi: introduce patch_nvhdmi()

2014-02-07 Thread Levente Kurusa
+ err = patch_generic_hdmi(codec); > + if (err) > + return err; > + > + spec = codec->spec; > + > + return 0; > +} > [...] Is it just me or is it that the 'spec' variable has no use? -- Regards, Levente Kurusa -- To unsubscribe from t

[PATCH] backlight: replace kfree with put_device

2014-02-07 Thread Levente Kurusa
As per the comments on device_register, we shouldn't call kfree() right after a device_register() failure. Instead call put_device(), which in turn will call bl_device_release resulting in a kfree to the full structure. Signed-off-by: Levente Kurusa --- drivers/video/backlight/backlight.

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-22 Thread Levente Kurusa
) ) you can have my: Reviewed-by: Levente Kurusa Oh, and next time please if you post a patch that fixes something I pointed out, CC me as I had a hard time finding this patch, thanks. :-) > NOTE: > 1. Created a separate directory 'dma/xilinx' as Xilinx has two more >DMA IP

Re: [PATCH V3 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread Levente Kurusa
on.message; > + copy_size = sizeof(struct hv_start_fcopy); > + if (count < copy_size) > + return 0; > + } else { > + src = fcopy_transaction.fcopy_msg; > + copy_size = sizeof(struct hv_do_fcopy); > +

Re: [PATCH] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-16 Thread Levente Kurusa
err; > + } > + > + of_property_read_u32(node, "xlnx,flush-fsync", &xdev->flush_on_fsync); > + > + /* Initialize the DMA engine */ > + xdev->common.dev = &pdev->dev; > + > + INIT_LIST_HEAD(&xdev->common.channels); > +

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-16 Thread Levente Kurusa
D_REALTIME_WAKEUP); > + return type == ANDROID_ALARM_RTC_WAKEUP || > +type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP; > } This is the fourth patch that does the exact same, an other similar patch was already applied, hence this one will not apply. Please base your patches on -nex

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-14 Thread Levente Kurusa
gt; -- This is like the third patch in this two week period that does the exact same with more or less success, and I recall one getting applied (I might be wrong). Anyway, this one finally looks good! :-) -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH] AlarmDev: Changing is_wakeup() to be a function to pass checkpatch

2014-01-12 Thread Levente Kurusa
ilar patch was already applied, not sure though. > [...] -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [trivial] doc: cgroups: Fix typo in doc/cgroups

2013-12-21 Thread Levente Kurusa
ntation/cgroups/resource_counter.txt > @@ -97,8 +97,8 @@ to work with it. > (struct res_counter *rc, struct res_counter *top, >unsinged long val) ^^ should be unsigned. -- Regards, Levente Kurusa -- To unsubscribe from this list: send the

Re: [PATCH 21/38] workqueue: add missing put_device call

2013-12-19 Thread Levente Kurusa
[+Cc Greg] On 12/19/2013 04:34 PM, Tejun Heo wrote: > Hello, > > On Thu, Dec 19, 2013 at 10:31 AM, Levente Kurusa wrote: >> The reason I removed the kfree() was because the put_device() will decrement >> wq_dev->dev's reference count to zero (it is set to one by d

Re: [PATCH 21/38] workqueue: add missing put_device call

2013-12-19 Thread Levente Kurusa
core is notified. Also, if you take a look at the comment for the device_register() function, it explicitly says NOT to kfree the struct device, but instead call put_device() and let the device's release() function take care. -- Regards, Levente Kurusa -- To unsubscribe from this list: se

[PATCH 09/38] arm: mach-imx: add missing put_device calls

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/arm/mach-imx/devices/devices.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/devices/devices.c b/arch/arm/mach-imx/devices/devices.c index

[PATCH 10/38] arm: exynos: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/arm/mach-exynos/common.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index 61d2906..8b58829

[PATCH 04/38] powerpc: kernel: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/powerpc/kernel/vio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index e7d0c88f..e8ed87e 100644 --- a/arch/powerpc/kernel

[PATCH 02/38] powerpc: qe_lib: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/powerpc/sysdev/qe_lib/qe_ic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c b/arch/powerpc/sysdev/qe_lib/qe_ic.c index b2b87c3..2e15262 100644

[PATCH 32/38] pcie: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Removed the kfree() as put_device will result in release_pcie_device being called and hence the container of the device will be kfree'd. Signed-off-by: Levente Kurusa --- drivers/pci/pcie/portdrv_core.c | 2 +- 1 file ch

[PATCH 07/38] arm: locomo: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also, rework error path to remove the out label by return -ENOMEM explicitly if kzalloc fails. Signed-off-by: Levente Kurusa --- arch/arm/common/locomo.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[PATCH 05/38] sparc: kernel: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. The kfree() has been removed because put_device will set the underlying kref's reference count to zero and hence vio_dev_release will get called resulting in kfreeing the structure. Signed-off-by: Levente Kurusa ---

[PATCH 08/38] arm: mach-rpc: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/arm/mach-rpc/ecard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c index fcb1d59..1c5f7cb 100644 --- a/arch

[PATCH 11/38] arm: mach-integrator: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Calling put_device on the failed device will allow lm_device_release to be called which will kfree() the struct lm_device. Signed-off-by: Levente Kurusa --- arch/arm/mach-integrator/lm.c | 4 +++- 1 file changed, 3 insertions

[PATCH 13/38] arm: s390: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/s390/kernel/time.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/s390/kernel/time.c b/arch/s390/kernel/time.c index 064c308..16c717f 100644 --- a/arch/s390

[PATCH 15/38] mips: txx9: 7segled: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also, add a new tx_7segled_release function which will be called after the put_device to ensure that device is kfree'd. Signed-off-by: Levente Kurusa --- arch/mips/txx9/generic/7segled.c | 13 ++--- 1 file ch

[PATCH 18/38] ia64: kernel: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Removed kfree() as put_device() will result in tiocx_bus_release called. Signed-off-by: Levente Kurusa --- arch/ia64/sn/kernel/tiocx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/sn/kernel

[PATCH 17/38] parisc: kernel: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/parisc/kernel/drivers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c index 14285ca..b97cc05 100644

[PATCH 16/38] mips: sgi-ip22: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also, create a gio_bus_release() that calls kfree on the device argument to properly kfree() the memory allocated for the device. Signed-off-by: Levente Kurusa --- arch/mips/sgi-ip22/ip22-gio.c | 9 - 1 file changed

[PATCH 20/38] net: iucv: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- net/iucv/af_iucv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 168aff5..0096206 100644 --- a/net/iucv/af_iucv.c +++ b

[PATCH 25/38] pnp: card: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/pnp/card.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c index bc00693..874c236 100644 --- a/drivers/pnp/card.c +++ b/drivers/pnp/card.c

[PATCH 22/38] sound: ac97: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- sound/pci/ac97/ac97_codec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c index bf578ba2..55186f8 100644 --- a/sound/pci/ac97

[PATCH 23/38] sound: soc: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- sound/soc/soc-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 4e53d87..21caa09 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc

[PATCH 35/38] media: bt8xx: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Remove the kfree() because the put_device() call will actually call release_sub_device which in turn kfrees the device. Signed-off-by: Levente Kurusa --- drivers/media/pci/bt8xx/bttv-gpio.c | 2 +- 1 file changed, 1 insertion

[PATCH 37/38] uwb: umc-dev: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/uwb/umc-dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uwb/umc-dev.c b/drivers/uwb/umc-dev.c index 4613c13..7b0b268 100644 --- a/drivers/uwb/umc-dev.c +++ b/drivers

[PATCH 36/38] dio: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/dio/dio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c index 55dd88d..5d4d755 100644 --- a/drivers/dio/dio.c +++ b/drivers/dio/dio.c

[PATCH 34/38] infiniband: core: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/infiniband/core/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index faad2ca..bf279ce

[PATCH 38/38] bcma: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/bcma/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c index e15430a..5a9f6bd 100644 --- a/drivers/bcma/main.c +++ b/drivers/bcma

[PATCH 27/38] superhyway: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also, this makes superhyway_device_release actually used. Signed-off-by: Levente Kurusa --- drivers/sh/superhyway/superhyway.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/sh/superhyway

[PATCH 33/38] scsi: transport: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Remove the kfree() as well, because the put_device() will result in iscsi_endpoint_release being called and hence it will be kfree'd. Signed-off-by: Levente Kurusa --- drivers/scsi/scsi_transport_iscsi.c | 10

[PATCH 21/38] workqueue: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Remove the kfree() as that is the job of wq_device_release which will now be called due to the reference count actually reaching zero. Signed-off-by: Levente Kurusa --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion

[PATCH 06/38] arm: mach-s3c64: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/arm/mach-s3c64xx/dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c index 7e22c21..090852d 100644 --- a/arch/arm/mach

[PATCH 19/38] net: atm: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- net/atm/atm_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 350bf62..0e070c2 100644 --- a/net/atm/atm_sysfs.c

[PATCH 12/38] arm: s5pv210: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/arm/mach-s5pv210/common.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-s5pv210/common.c b/arch/arm/mach-s5pv210/common.c index 26027a2..81f43ae

[PATCH 26/38] xen: xenbus: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/xen/xenbus/xenbus_probe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index 3c0a74b

[PATCH 24/38] pcmcia: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/pcmcia/cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index 5292db6..5057de9 100644 --- a/drivers/pcmcia/cs.c +++ b/drivers/pcmcia

[PATCH 14/38] mips: txx9: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also, rework error path so that it is easier to read. Signed-off-by: Levente Kurusa --- arch/mips/txx9/generic/setup.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/arch

[PATCH 28/38] superhyway: intc: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- drivers/sh/intc/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c index 8f32a13..c89768e 100644 --- a/drivers/sh

[PATCH 30/38] vlynq: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. This will result in vlynq_device_release being called making the kfree() in the errorpath unneccessary. Signed-off-by: Levente Kurusa --- drivers/vlynq/vlynq.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH 29/38] superhyway: maple: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Also rework maple_release_device to use maple_free_dev instead, avoiding same code being in two functions at the same time. Signed-off-by: Levente Kurusa --- drivers/sh/maple/maple.c | 23 +-- 1 file

[PATCH 03/38] powerpc: cell: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/powerpc/platforms/cell/spu_base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c index f85db3a

[PATCH 01/38] sh: dma-sysfs: add missing put_device call

2013-12-19 Thread Levente Kurusa
This is required so that we give up the last reference to the device. Signed-off-by: Levente Kurusa --- arch/sh/drivers/dma/dma-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c index 4b15fed..76271e6

  1   2   >