Re: [PATCH] staging: rtl8821ae: rtl8821ae: hw.c: Cleaning up if statement that always evaluates to false

[Levente Kurusa]

On Sun, Jun 08, 2014 at 01:37:43PM -0700, David Rientjes wrote:
> >  drivers/staging/rtl8821ae/rtl8821ae/hw.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c 
> > b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > index 1b8583b..52322e3 100644
> > --- a/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > +++ b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > @@ -1623,7 +1623,7 @@ static int _rtl8821ae_set_media_status(struct 
> > ieee80211_hw *hw,
> >  
> >     rtl_write_byte(rtlpriv, (MSR), bt_msr);
> >     rtlpriv->cfg->ops->led_control(hw, ledaction);
> > -   if ((bt_msr & ~0xfc) == MSR_AP)
> > +   if ((bt_msr & MSR_AP) == MSR_AP)

I changed this line from '0xfc' to '~0xfc', and looking at the defines
it must have been the way your patch does, so:

Acked-by: Levente Kurusa <le...@linux.com>

if it wasn't applied yet, and you fix the problems David pointed out
with the commit message.

Thanks,
    Levente Kurusa

signature.asc
Description: Digital signature