On Fri, Oct 18, 2019 at 05:30:04PM +0100, Sudip Mukherjee wrote:
> The build of xtensa allmodconfig is giving a warning of:
> In function 'dsi_dump_dsidev_irqs':
> warning: the frame size of 1120 bytes is larger than 1024 bytes
>
> Allocate the memory for 'struct dsi_irq_stats' dynamically instead
IGH undeclared (first
> use in this function); did you mean GPIOF_INIT_HIGH?
> GPIOD_OUT_HIGH);
> ^~
> GPIOF_INIT_HIGH
>
> Reported-by: Hulk Robot
> Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver")
>
T_HIGH undeclared (first
> > use in this function); did you mean GPIOF_INIT_HIGH?
> > GPIOD_OUT_HIGH);
> > ^~
> > GPIOF_INIT_HIGH
> >
> > Reported-by: Hulk Robot
> > Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver
Dear YueHaibing,
On Sun, Oct 06, 2019 at 03:22:41PM +0800, YueHaibing wrote:
> If GPIOLIB is not set, building fails:
>
> sound/soc/codecs/tas2770.c: In function tas2770_reset:
> sound/soc/codecs/tas2770.c:38:3: error: implicit declaration of function
> gpiod_set_value_cansleep; did you mean gpi
On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote:
> * Markus Elfring [190826 06:31]:
> > From: Markus Elfring
> > Date: Mon, 26 Aug 2019 15:05:31 +0200
> >
> > A null pointer would be passed to a call of the function "kfree" directly
> > after a call of the function "kzalloc" failed
On Fri, Aug 16, 2019 at 10:14:09PM +0800, YueHaibing wrote:
> If CONFIG_ACPI is not set, gcc warning this:
>
> drivers/soundwire/slave.c:16:12: warning:
> 'sdw_slave_add' defined but not used [-Wunused-function]
>
> move them to #ifdef CONFIG_ACPI block.
...and that makes slave.c empty, right?
On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote:
> Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
> handler finished".
>
> fixes below issue reported by coccicheck
>
> sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
> primary handler re
On Thu, Apr 25, 2019 at 08:42:22PM +0200, Janusz Krzysztofik wrote:
> Hi Ladislav,
>
> On Thursday, April 25, 2019 12:14:28 AM CEST Ladislav Michl wrote:
> > Hi Janusz,
> >
> > On Wed, Apr 24, 2019 at 08:02:12PM +0200, Janusz Krzysztofik wrote:
> > > After re
Hi Janusz,
On Wed, Apr 24, 2019 at 08:02:12PM +0200, Janusz Krzysztofik wrote:
> After recent modifications, only a hardcoded partition info makes
> the driver device specific. Other than that, the driver uses GPIO
> exclusively and can be used on any hardware.
>
> Drop the partition info and us
Hello Nathan,
On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> static because its prototype was not defined in a header. Unfortunately,
> thi
pm_runtime_autosuspend_expiration calls ktime_get_mono_fast_ns
even when its returned value may be unused. Therefore get
current time later and remove gotos while there.
Signed-off-by: Ladislav Michl
Acked-by: Tony Lindgren
Acked-by: Vincent Guittot
---
This patch is based on top of bleeding
be slightly sub optimal.
> >
> > Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using
> > hrtimers")
> > Reported-by: Biju Das
> > Signed-off-by: Vincent Guittot
>
> I've queued this one up as a fix for 5.0, but unfortunately it clash
description: "In the worst case, this can
> > > result is a slightly wrong timestamp (a few nanoseconds)". For
> > > PM runtime autosuspend, this means only that the suspend decision can
> > > be slightly sub optimal.
> > >
> > > Fixes: 8234f67
pm_runtime_autosuspend_expiration calls ktime_get even when
its returned value may be unused. Therefore get current time
later and remove gotos while there.
Signed-off-by: Ladislav Michl
---
NOTE: Depends on Vincent's "[PATCH v2] PM/runtime: Fix autosuspend_delay
on 3
On Thu, Jan 10, 2019 at 08:50:14AM +0100, Vincent Guittot wrote:
> On Thu, 10 Jan 2019 at 08:46, Ladislav Michl wrote:
> >
> > On Wed, Jan 09, 2019 at 11:06:34PM +0100, Rafael J. Wysocki wrote:
> > > On Wed, Jan 9, 2019 at 7:05 PM Vincent Guittot
> > > wrote:
&
On Wed, Jan 09, 2019 at 11:06:34PM +0100, Rafael J. Wysocki wrote:
> On Wed, Jan 9, 2019 at 7:05 PM Vincent Guittot
> wrote:
> >
> > On Wed, 9 Jan 2019 at 18:26, Ladislav Michl wrote:
> > >
> > > On Wed, Jan 09, 2019 at 05:32:31PM +0100, Vincent Guittot wrote:
PM-runtime now uses the hrtimers infrastructure for autosuspend, however
comments still reference 'jiffies'.
Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers")
Signed-off-by: Ladislav Michl
---
Changes:
-v2: Reword comment accoring to Rafael&#x
On Wed, Jan 09, 2019 at 05:32:31PM +0100, Vincent Guittot wrote:
> On Wed, 9 Jan 2019 at 17:07, Ladislav Michl wrote:
> >
> > On Wed, Jan 09, 2019 at 03:12:25PM +0100, Vincent Guittot wrote:
> > > Please keep all thread list when replying :-)
> >
> > Ahh, sorry
PM-runtime now uses the hrtimers infrastructure for autosuspend, however
comments still reference 'jiffies'.
Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers")
Signed-off-by: Ladislav Michl
---
drivers/base/power/runtime.c | 4 ++--
1 file changed
On Wed, Jan 09, 2019 at 03:12:25PM +0100, Vincent Guittot wrote:
> Please keep all thread list when replying :-)
Ahh, sorry for that...
[snip]
> On Wed, 9 Jan 2019 at 14:33, Ladislav Michl wrote:
> > I agree, but it doea all the magic correctly, so you won't need
> >
On Wed, Jan 09, 2019 at 02:42:18AM +0100, Vincent Guittot wrote:
> Le Tuesday 08 Jan 2019 à 13:37:43 (-0800), Tony Lindgren a écrit :
> > * Vincent Guittot [190108 16:42]:
> > > On Tue, 8 Jan 2019 at 16:53, Tony Lindgren wrote:
> > > > Hmm so could it be that we now rely on timers that that may
>
On Fri, Dec 07, 2018 at 06:19:48AM +0530, Keerthy wrote:
> Use devm_regmap_add_irq_chip and clean up error path in probe.
> Hence clean up the probe error path and the remove function.
>
> Reported-by: Christian Hohnstaedt
> Signed-off-by: Keerthy
> ---
>
> Changes in v2:
>
> * Cleaned up re
ret is assigned later, no need to initialize it.
Signed-off-by: Ladislav Michl
---
CHANGES:
-v2: add missing Signed-off-by
(I'm sorry for that...)
sound/soc/codecs/max9867.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max9867.c b/soun
ary.
I'm going to use this patch as an argument against anybody complaining
kernel bugs do not get fixed. People just need to teach themselves to
be patient.
Tested-by: Ladislav Michl
> Before the patch (on Palm TE):
>
> mmc0: new SD card at address b368
> mmcblk0:
On Sun, Jul 29, 2018 at 08:32:41AM +0200, H. Nikolaus Schaller wrote:
> Hi,
>
> > Am 28.07.2018 um 22:35 schrieb Ladislav Michl :
> >
> > Hi Andreas,
> >
> > On Sat, Jul 28, 2018 at 06:59:14PM +0200, Andreas Kemnade wrote:
> >> I got this in the ker
Hi Andreas,
On Sat, Jul 28, 2018 at 06:59:14PM +0200, Andreas Kemnade wrote:
> I got this in the kernel log:
> [0.756042] omap-dmtimer-pwm dmtimer-pwm: dmtimer pdata structure NULL
> [0.756134] omap-dmtimer-pwm: probe of dmtimer-pwm failed with error -22
>
> the probe function has to wait
On Wed, Jul 25, 2018 at 06:27:45PM +0200, Andreas Kemnade wrote:
> On Wed, 25 Jul 2018 10:33:05 +0200
> Ladislav Michl wrote:
>
> > On Wed, Jul 25, 2018 at 10:18:28AM +0200, H. Nikolaus Schaller wrote:
> > >
> > > > Am 25.07.2018 um 10:07 schrieb Ladislav
On Wed, Jul 25, 2018 at 02:27:31PM +0200, H. Nikolaus Schaller wrote:
>
> > Am 25.07.2018 um 10:33 schrieb Ladislav Michl :
> >
> > On Wed, Jul 25, 2018 at 10:18:28AM +0200, H. Nikolaus Schaller wrote:
> >>
> >>> Am 25.07.2018 um 10:07 schrieb Ladislav
On Wed, Jul 25, 2018 at 10:18:28AM +0200, H. Nikolaus Schaller wrote:
>
> > Am 25.07.2018 um 10:07 schrieb Ladislav Michl :
> >
> > On Wed, Jul 25, 2018 at 08:58:41AM +0200, H. Nikolaus Schaller wrote:
> >> Vendor defined U-Boot has changed the partition scheme a
On Wed, Jul 25, 2018 at 10:16:28AM +0200, H. Nikolaus Schaller wrote:
> Hi,
>
> > Am 25.07.2018 um 10:10 schrieb Ladislav Michl :
> >
> > On Wed, Jul 25, 2018 at 08:58:42AM +0200, H. Nikolaus Schaller wrote:
> >> to better match omap3-beagle.dts (which was the
On Wed, Jul 25, 2018 at 08:59:04AM +0200, H. Nikolaus Schaller wrote:
> GTA04A5 has been produced with MCP chips either with
> 512MB RAM + 512MB NAND
> 512MB RAM + 1024MB NAND
> 1024MB RAM + 512MB OneNAND
>
> RAM setup is done by U-Boot (MLO/SPL) but OneNAND needs
> a different setup of the GP
On Wed, Jul 25, 2018 at 08:58:52AM +0200, H. Nikolaus Schaller wrote:
> McBSP1 needs sepcial "pinctrl" for the clocks.
Nit: "special" perhaps?
> Signed-off-by: H. Nikolaus Schaller
> ---
> arch/arm/boot/dts/omap3-gta04.dtsi | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff -
On Wed, Jul 25, 2018 at 08:58:42AM +0200, H. Nikolaus Schaller wrote:
> to better match omap3-beagle.dts (which was the basis
> of designing the GTA04).
>
> Signed-off-by: H. Nikolaus Schaller
> ---
> arch/arm/boot/dts/omap3-gta04.dtsi | 14 +++---
> 1 file changed, 7 insertions(+), 7 de
On Wed, Jul 25, 2018 at 08:58:41AM +0200, H. Nikolaus Schaller wrote:
> Vendor defined U-Boot has changed the partition scheme a while ago:
>
> * kernel partition 6MB
> * file system partition uses the remainder up to end of the NAND
> * increased size of the environment partition (to get an OneNA
On Wed, Jul 04, 2018 at 07:11:56PM +0200, Pavel Machek wrote:
> Hi!
>
> I started to use droid 4 as my primary phone... so I have battery
> monitor running for hours... Once every few days it dies with
> "connection refused" error reading battery's "voltage_now". I restart
> it and it continues wo
On Tue, Jul 03, 2018 at 09:39:51AM -0700, Florian Fainelli wrote:
>
>
> On 06/29/2018 02:40 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > On da850-evm board we can read the MAC address from MTD. It's currently
> > done in the relevant board file, but we want to get rid of
On Sat, May 19, 2018 at 11:55:51PM +0200, Janusz Krzysztofik wrote:
> On Saturday, May 19, 2018 8:00:38 PM CEST Andy Shevchenko wrote:
> > On Sat, May 19, 2018 at 2:15 AM, Janusz Krzysztofik
> wrote:
> > > On Friday, May 18, 2018 11:21:14 PM CEST Andy Shevchenko wrote:
> > >> On Sat, May 19, 2018
dma_map_single does not work for vmalloc-ed buffers,
so disable DMA in this case.
Signed-off-by: Ladislav Michl
Reported-by: "H. Nikolaus Schaller"
Tested-by: "H. Nikolaus Schaller"
---
Changes:
-v2: Added Tested-by tag, based on v4.17-rc1 (no change in patch itself)
Hi Boris,
(and apologies for delay)
On Fri, Apr 20, 2018 at 10:01:34PM +0200, Boris Brezillon wrote:
> Hi Ladislav,
>
> On Mon, 16 Apr 2018 08:52:59 +0200
> Ladislav Michl wrote:
>
> > dma_map_single doesn't get the proper DMA address for vmalloced area,
>
>
Hi Péter,
On Mon, Apr 16, 2018 at 02:34:54PM +0300, Peter Ujfalusi wrote:
> On 2018-04-16 09:52, Ladislav Michl wrote:
> > dma_map_single doesn't get the proper DMA address for vmalloced area,
>
> Which is not a big surprise as vmalloc will allocate contiguous virtual
&
dma_map_single doesn't get the proper DMA address for vmalloced area,
so disable DMA in this case.
Signed-off-by: Ladislav Michl
Reported-by: "H. Nikolaus Schaller"
Tested-by: "H. Nikolaus Schaller"
---
Changes:
-v2: Added Tested-by tag, based on v4.17-rc1 (
On Wed, Apr 11, 2018 at 10:52:01AM +0200, Boris Brezillon wrote:
> On Wed, 11 Apr 2018 10:27:46 +0200
> Ladislav Michl wrote:
>
> > On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon wrote:
> > > On Wed, 11 Apr 2018 09:36:56 +0200
> > > Ladislav Michl
On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon wrote:
> On Wed, 11 Apr 2018 09:36:56 +0200
> Ladislav Michl wrote:
>
> > Hi Boris,
> >
> > On Wed, Apr 11, 2018 at 09:15:28AM +0200, Boris Brezillon wrote:
[...]
> > > Not sure this approach is safe o
Hi Boris,
On Wed, Apr 11, 2018 at 09:15:28AM +0200, Boris Brezillon wrote:
> Hi Ladislav,
>
> On Wed, 11 Apr 2018 08:26:07 +0200
> Ladislav Michl wrote:
>
> > Hi Andreas,
> >
> > On Wed, Apr 11, 2018 at 06:59:03AM +0200, Andreas Kemnade wrote:
> > >
Hi Andreas,
On Wed, Apr 11, 2018 at 06:59:03AM +0200, Andreas Kemnade wrote:
> Hi Ladis,
>
> On Tue, 10 Apr 2018 22:56:43 +0200
> Ladislav Michl wrote:
>
> > Hi Nikolaus,
> >
> > On Tue, Apr 10, 2018 at 06:25:17PM +0200, H. Nikolaus Schaller wrote:
> >
((size_t)(buf + count - 1) & PAGE_MASK))
goto out_copy;
and in case it does not help put the same goto at the very beginning of
omap2_onenand_read_bufferram function and report result?
Thank you for cooperation,
ladis
> commit bdaca9345d41fd9420995469d27603
On Wed, Apr 04, 2018 at 11:41:23AM +0100, Colin Ian King wrote:
> On 04/04/18 11:24, Dan Carpenter wrote:
> > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote:
> >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
> >>> From: Colin I
On Tue, Apr 03, 2018 at 11:17:03AM -0700, Joe Perches wrote:
> On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote:
> > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote:
> > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote:
> > > > On Fri, Ma
On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote:
> On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote:
> > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
> > > From: Colin Ian King
> >
> > Hello Colin,
> >
> > > Trivia
On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
> From: Colin Ian King
Hello Colin,
> Trivial fix to spelling mistake in pr_debug message text
would you mind making this patch a bit less non-trivial and
change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix?
Thank you.
> Signed-
On Sun, Mar 18, 2018 at 10:51:33PM +0800, Jia-Ju Bai wrote:
> line6_read_data() is never called in atomic context.
>
> The call chains ending up at line6_read_data() are:
> [1] line6_read_data() <- line6_read_serial_number() -> pod_startup4()
> [2] line6_read_data() <- line6_read_serial_number() <
On Thu, Feb 15, 2018 at 11:31:45AM +0530, Keerthy wrote:
> Replace architecture specific guard with clocksource guard.
>
> Signed-off-by: Keerthy
> Replace architecture specific defines with clocksource
This looks like a bit unussual commit log. Also, what about merging
it with previous patch?
On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
> Add of dependency for STM32 ASoC drivers.
> DFSDM of dependency is already inherited
> from STM32_DFSDM_ADC dependency.
>
> Signed-off-by: olivier moysan
> ---
> sound/soc/stm/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
On Tue, Jan 30, 2018 at 11:35:38AM +0100, Pavel Machek wrote:
> On Tue 2018-01-30 11:10:46, Ladislav Michl wrote:
> > On Tue, Jan 30, 2018 at 11:00:23AM +0100, Pavel Machek wrote:
> > > On Tue 2018-01-30 10:38:38, Ladislav Michl wrote:
> > > > On Tue, Jan 30, 2
On Tue, Jan 30, 2018 at 11:00:23AM +0100, Pavel Machek wrote:
> On Tue 2018-01-30 10:38:38, Ladislav Michl wrote:
> > On Tue, Jan 30, 2018 at 10:11:02AM +0100, Filip Matijević wrote:
> > > Hi,
> > >
>
> > > > Well, notice I'm converting exist
On Tue, Jan 30, 2018 at 10:11:02AM +0100, Filip Matijević wrote:
> Hi,
>
> On 01/30/2018 09:53 AM, Pavel Machek wrote:
> > On Tue 2018-01-30 09:34:46, Ladislav Michl wrote:
> >> On Tue, Jan 30, 2018 at 12:33:01AM +0100, Pavel Machek wrote:
> >>> On Tue 2018-
On Tue, Jan 30, 2018 at 12:33:01AM +0100, Pavel Machek wrote:
> On Tue 2018-01-30 00:20:31, Ladislav Michl wrote:
> > On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
> > >
> > > This adds device tree support to tlv320dac33.c.
> > >
On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
>
> This adds device tree support to tlv320dac33.c.
>
> Signed-off-by: Pavel Machek
>
> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt
> b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
> new file mode
On Wed, Jan 24, 2018 at 06:21:38PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 24, 2018 at 12:07 PM, Ladislav Michl wrote:
> > Implement managed ioremap function for shared resources.
>
> > +#define devm_ioremap_resource(dev, res) \
> > + __devm_ioremap_
job of driver developers, new function for that
purpose is implemented and its usage shown on davinci
mtd driver.
Changes from previous version:
- moved function prototype in headers other way around (PATCH 1/3),
the rest of patches was dropped.
Ladislav Michl (3):
devres: Move
Implement managed ioremap function for shared resources.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: Rebased on top of PATCH v2 1/3
include/linux/io.h | 8 +++-
lib/devres.c | 22 ++
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/include
Simplify error handling by using devm_ioremap_shared_resource().
Signed-off-by: Ladislav Michl
---
Changes:
- v2: None
drivers/mtd/nand/davinci_nand.c | 24 +++-
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd
Move devm_ioremap_resource() out of device.h into io.h to be
consistent with similar APIs.
Signed-off-by: Ladislav Michl
---
Changes:
- v2: new patch
include/linux/device.h | 2 --
include/linux/io.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux
On Wed, Jan 24, 2018 at 01:58:19PM +0530, Keerthy wrote:
> On Wednesday 24 January 2018 12:54 PM, Ladislav Michl wrote:
> > Keerthy,
> >
> > On Wed, Jan 24, 2018 at 11:14:40AM +0530, Keerthy wrote:
> >> Adapt driver to utilize dmtimer pdata ops instead of pdata-q
Keerthy,
On Wed, Jan 24, 2018 at 11:14:40AM +0530, Keerthy wrote:
> Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks.
>
> Signed-off-by: Keerthy
> Acked-by: Neil Armstrong
> Reviewed-by: Claudiu Beznea
> ---
>
> Changes in v8:
>
> * Added of_node_put call in success case o
Lee,
On Tue, Jan 23, 2018 at 03:04:08PM +, Lee Jones wrote:
> On Tue, 23 Jan 2018, SF Markus Elfring wrote:
>
> > >> Applied, thanks.
> > >
> > > This patch does not apply.
> > >
> > > Please rebase and resend.
> >
> > Did you notice that this update suggestion could eventually be supersed
On Mon, Jan 22, 2018 at 03:33:52PM -0800, Dmitry Torokhov wrote:
> On Sun, Jan 21, 2018 at 10:15:39PM +0100, Ladislav Michl wrote:
> > devm_pci_remap_cfgspace() is using devm_ioremap_release()
> > devres release function. Move it to devres along with
> > similar PCI func
On Mon, Jan 22, 2018 at 09:49:03AM -0800, Dmitry Torokhov wrote:
> On Sun, Jan 21, 2018 at 10:15:08PM +0100, Ladislav Michl wrote:
> > Moving managed io function declarations into device.h allows
> > removing forward struct device and resource definitions from
> > io(port).h
&
119]
> [also build test ERROR on v4.15-rc9]
> [cannot apply to linus/master pci/next l2-mtd-boris/nand/next v4.15-rc8
> v4.15-rc7 v4.15-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/
gt; [also build test ERROR on v4.15-rc9]
> [cannot apply to linus/master pci/next l2-mtd-boris/nand/next v4.15-rc8
> v4.15-rc7 v4.15-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/
Dear Claudiu,
On Mon, Jan 22, 2018 at 11:17:08AM +0200, Claudiu Beznea wrote:
> On 17.01.2018 23:47, Ladislav Michl wrote:
> > @@ -334,18 +348,18 @@ static int pwm_omap_dmtimer_probe(struct
> > platform_device *pdev)
> >
> > mutex_init(&omap->mutex);
On Mon, Jan 22, 2018 at 11:26:44AM +0200, Claudiu Beznea wrote:
> On 17.01.2018 23:48, Ladislav Michl wrote:
> > As dmtimer no longer exports functions, make those previously
> > exported static.
> >
> > Signed-off-by: Ladislav Michl
> > ---
> > Note: onl
On Mon, Jan 22, 2018 at 11:00:15AM +0200, Claudiu Beznea wrote:
>
>
> On 17.01.2018 23:47, Ladislav Michl wrote:
> > Invalid value silently disables use of the prescaler.
> > Use -1 explicitely for that purpose and error out on
> > invalid value.
> >
Simplify error handling by using devm_ioremap_shared_resource().
Signed-off-by: Ladislav Michl
---
drivers/mtd/nand/davinci_nand.c | 24 +++-
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
Implement managed ioremap function for shared resources.
Signed-off-by: Ladislav Michl
---
include/linux/device.h | 9 -
lib/devres.c | 22 ++
2 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/include/linux/device.h b/include/linux/device.h
devm_ioremap_release() is an implementation detail and shouldn't
be public.
Signed-off-by: Ladislav Michl
---
include/linux/device.h | 1 -
lib/devres.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/device.h b/include/linux/device.h
devm_pci_remap_cfgspace() is using devm_ioremap_release()
devres release function. Move it to devres along with
similar PCI functions to allow hiding devm_ioremap_release()
from public.
Signed-off-by: Ladislav Michl
---
drivers/pci/pci.c | 82
Moving managed io function declarations into device.h allows
removing forward struct device and resource definitions from
io(port).h
Signed-off-by: Ladislav Michl
---
include/linux/device.h | 57 ++
include/linux/io.h | 39
job of driver developers, new function for that
purpose is implemented and its usage shown.
Also, there are few cleanup patches, which may bring some
controversy, but seemed usefull to do along the way.
Feel free to object or suggest something else. Thank you.
Ladislav Michl (5):
devres: Move
On Fri, Jan 19, 2018 at 07:03:10PM +0100, Ladislav Michl wrote:
> Two one-liners for the same issue, second bug occurrence is just
> a copy&pasted mistake from 2011...
>
> Ladislav Michl (2):
> devres: Fix double mem region release in devm_ioremap_resource()
> PCI:
Signed-off-by: Ladislav Michl
---
drivers/pci/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 764ca7b8840d..8f9d81a23ca5 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3607,7 +3607,6 @@ void __iomem *devm_pci_remap_cfg_resource(str
ource")
Signed-off-by: Ladislav Michl
---
lib/devres.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/devres.c b/lib/devres.c
index 5f2aedd58bc5..584356a568d0 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -156,7 +156,6 @@ void __iomem *devm_ioremap_resource(struct device *dev,
struct res
Two one-liners for the same issue, second bug occurrence is just
a copy&pasted mistake from 2011...
Ladislav Michl (2):
devres: Fix double mem region release in devm_ioremap_resource()
PCI: Fix double mem region release in devm_pci_remap_cfg_resource()
drivers/pci/pci.c | 1 -
lib/devr
As dmtimer no longer exports functions, make those previously
exported static.
Signed-off-by: Ladislav Michl
---
Note: only those functions assigned to timer ops are made static
as some others will be needed later for event capture.
drivers/clocksource/timer-dm.c | 218
Prescaler setting is currently not taken into account.
Fix that by introducing freq member variable and initialize
it at device probe time. This also avoids frequency
recomputing at each pwm configure time.
Signed-off-by: Ladislav Michl
---
drivers/pwm/pwm-omap-dmtimer.c | 92
Invalid value silently disables use of the prescaler.
Use -1 explicitely for that purpose and error out on
invalid value.
Signed-off-by: Ladislav Michl
---
drivers/clocksource/timer-dm.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-dm.c b
This series is build on top od Keerthy's 'omap: dmtimer: Move driver
out of plat-omap' v7.
Ladislav Michl (3):
clocksource: timer-dm: Check prescaler value
pwm: pwm-omap-dmtimer: Fix frequency when using prescaler
clocksource: timer-dm: Make unexported functions static
driv
Omit extra message for a memory allocation failure in probe function.
Signed-off-by: Ladislav Michl
---
drivers/eisa/eisa-bus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/eisa/eisa-bus.c b/drivers/eisa/eisa-bus.c
index 4155507052bd..1e8062f6dbfc 100644
--- a
Remove spaces on empty line and replace spaces with tabs.
Signed-off-by: Ladislav Michl
---
drivers/eisa/eisa-bus.c | 58 ++---
drivers/eisa/pci_eisa.c | 10
drivers/eisa/virtual_root.c | 19 +++
3 files changed, 43 insertions
Hi,
this is nothing dramatic, just whitespace cleanup and one error
logging line deletion. Sending it as preparation for SGI Indigo2
related patches which I'm unsure ever happens as my machine
stopped working few days ago.
Ladislav Michl (2):
EISA: Whitespace cleanup
EISA: Delete
Allocating memory to store clk array together with driver
data simplifies error unwinding and allows deleting memory
allocation failure message as there is now only single point
of failure already covered by allocation failure report.
Signed-off-by: Ladislav Michl
[Markus Elfring: simplified
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote:
> > dev_dbg(dev,
> > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
> > - ver, tll->nch);
> > + ver, nch);
> > break;
>
> Does this format strin
On Mon, Jan 15, 2018 at 08:04:03PM +0100, SF Markus Elfring wrote:
> >> So I hope that your solution approach will be also fine.
> >> Will it supersede my proposal?
> >
> > Who knows, perhaps it would be the best if you could judge yourself...
>
> I am also curious on how other contributors will
ATCH] mfd/omap-usb-tll: Allocate driver data at once
Allocating memory to store clk array together with driver
data simplifies error unwinding and allows deleting memory
allocation failure message as there is now only single point
where allocation could fail.
Signed-off-by: Ladislav Michl
---
dr
On Mon, Jan 15, 2018 at 06:06:20PM +0100, SF Markus Elfring wrote:
> >>> Now, if probe function calls devm_kzalloc two times and one of them fails,
> >>> you cannot easily say which one without looking at assembly listing.
> >>
> >> Will this situation change with any other implementation for such
On Mon, Jan 15, 2018 at 05:21:47PM +0100, SF Markus Elfring wrote:
> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device
> *pdev)
> GFP_KERNEL);
> if (!tll->ch_clk) {
> ret = -EN
Marcus,
On Mon, Jan 15, 2018 at 04:38:43PM +0100, SF Markus Elfring wrote:
> >> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device
> >> *pdev)
> >>GFP_KERNEL);
> >>if (!tll->ch_clk) {
> >>ret = -ENOMEM;
> >> -
Marcus,
On Mon, Jan 15, 2018 at 02:15:11PM +0100, SF Markus Elfring wrote:
> Omit extra messages for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/mfd/omap-usb-tll.c | 5 +
> 1 f
On Tue, Jan 09, 2018 at 05:24:21PM +0800, Qi Hou wrote:
> When more than one GP timers are used as kernel system timers and the
> corresponding nodes in device-tree are marked with the same "disabled"
> property, then the "attr" field of the property will be initialized
> more than once as the prop
On Sun, Jan 07, 2018 at 09:26:44PM +0530, Keerthy wrote:
> On 1/5/2018 4:17 AM, Ladislav Michl wrote:
> > On Tue, Jan 02, 2018 at 03:39:59PM +0530, Keerthy wrote:
> > > From: Ladislav Michl
> > >
> > > Invalid prescaler value is silently ignored. Fix that
>
1 - 100 of 161 matches
Mail list logo
