AFE is actually allowed to be turn on before configuration of DAIs
since each DAI has its own enabling control. Turn on/off AFE in
runtime resume/suspend to avoid AFE being shut down when closing a DAI
while other DAIs are still active.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe
support it.
soc_pcm_params_symmetry() will return error and the second stream stops.
This patch adds soc_pcm_apply_symmetry() for FE, BE, and codec DAIs
in DPCM path that was skipped in soc_pcm_open().
Signed-off-by: PC Liao
Signed-off-by: Koro Chen
---
sound/soc/soc-pcm.c | 57
On Thu, 2015-12-03 at 12:07 +0100, Takashi Iwai wrote:
> On Thu, 03 Dec 2015 12:01:58 +0100,
> Mark Brown wrote:
> >
> > On Thu, Dec 03, 2015 at 10:41:38AM +0100, Takashi Iwai wrote:
> >
> > > While reading this patch, I wondered how regmap can be used safely in
> > > an irq-disabled context. Ma
r and also hw_ptr in
struct mtk_afe_memif used to record that, and let pointer callback
reports current HW pointer instead.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe-common.h |1 -
sound/soc/mediatek/mtk-afe-pcm.c| 22 +++---
2 files changed, 11 inserti
22M/24M clocks are only required for I2S, so move the control to
I2S DAI ops.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe-pcm.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/sound/soc/mediatek/mtk-afe-pcm.c b/sound/soc/mediatek/mtk-afe-pcm.c
her suspend comes, a NULL pointer
dereference will happen in snd_pcm_suspend() when accessing
BE substream's runtime.
Signed-off-by: Koro Chen
---
sound/soc/soc-pcm.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index
On Thu, 2015-10-15 at 15:26 +0200, Lars-Peter Clausen wrote:
> On 10/15/2015 02:10 PM, Mark Brown wrote:
> > On Wed, Oct 14, 2015 at 11:00:01AM +0200, Lars-Peter Clausen wrote:
> >
> >> It was never intended that it is possible to bind a component to multiple
> >> cards. That it was possible was a
On Thu, 2015-10-15 at 13:10 +0100, Mark Brown wrote:
> On Wed, Oct 14, 2015 at 11:00:01AM +0200, Lars-Peter Clausen wrote:
>
> > It was never intended that it is possible to bind a component to multiple
> > cards. That it was possible was a bug that was overlooked and some people
> > tried to do i
On Tue, 2015-10-13 at 16:42 +0200, Lars-Peter Clausen wrote:
> On 10/13/2015 04:18 PM, Koro Chen wrote:
> > On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote:
> >> On 10/13/2015 03:37 PM, Koro Chen wrote:
> >>> The patch "ASoC: Prevent components
On Tue, 2015-10-13 at 15:44 +0200, Lars-Peter Clausen wrote:
> On 10/13/2015 03:37 PM, Koro Chen wrote:
> > The patch "ASoC: Prevent components from being bound to multiple cards"
> > adds check to prevent multiple cards from using the same component.
> > However,
ster_platform()
or snd_soc_register_codec().
Signed-off-by: Koro Chen
---
sound/soc/soc-core.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 42575b0..eca169a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1
On Wed, 2015-09-23 at 09:12 -0700, Mark Brown wrote:
> On Wed, Sep 23, 2015 at 06:03:19PM +0800, Koro Chen wrote:
> > Any suggestion for this patch?
> >
> > On Mon, 2015-09-14 at 14:51 +0800, Koro Chen wrote:
> > > In capture, there is chance that hw_ptr reported at
Any suggestion for this patch?
On Mon, 2015-09-14 at 14:51 +0800, Koro Chen wrote:
> In capture, there is chance that hw_ptr reported at IRQ is
> a little smaller than period_size due to internal AFE buffer.
> In the case of ping-pong buffer:
>
> |x
not be read since its size is smaller than
avail_min (which is period_size by default), and read thread continues
to sleep. If the next hw_ptr is just a little larger than buffer_size,
overrun occurs. One more period can hold the possible unread buffer.
Signed-off-by: Koro Chen
---
sound/
"ASoC: dapm: Add new widgets to the end of the
widget list") the first created widget (by snd_soc_dapm_new_controls)
is used, not the 2nd created one (by snd_soc_dapm_new_dai_widgets),
so audio path is broken.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe-pcm.c | 11 ---
are defined in a backup list array.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe-common.h | 8
sound/soc/mediatek/mtk-afe-pcm.c| 77 +
2 files changed, 77 insertions(+), 8 deletions(-)
diff --git a/sound/soc/mediatek/mtk-afe-common.h
b
The driver does not free irq when snd_soc_register_codec returns error.
It does not return error when request irq failed, either.
Add return when request irq failed, and free_irq if
snd_soc_register_codec failed.
Signed-off-by: Koro Chen
---
Change since v1:
- use free_irq instead of
This adds basic regulator support for rt5645.
Signed-off-by: Koro Chen
---
Change since v1:
- none
---
sound/soc/codecs/rt5645.c | 61 ---
sound/soc/codecs/rt5645.h | 26
2 files changed, 58 insertions(+), 29 deletions(-)
diff
On Thu, 2015-07-09 at 18:45 +0800, Daniel Kurtz wrote:
> On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Koro Chen
>
> Reviewed-by: Daniel Kurtz
>
> I believe
On Fri, 2015-07-10 at 14:30 +0900, Krzysztof Kozlowski wrote:
> platform_driver does not need to set an owner because
> platform_driver_register() will set it.
>
> Signed-off-by: Krzysztof Kozlowski
>
Acked-by: Koro Chen
Thank you!
--
To unsubscribe from this list
On Thu, 2015-07-09 at 12:10 +0100, Mark Brown wrote:
> On Thu, Jul 09, 2015 at 09:48:13AM +0800, Koro Chen wrote:
>
> > Do you think I should use devm_request_threaded_irq(), and change
> > free_irq to devm_free_irq in remove? Or I should keep the original
> > request_thre
This adds afe (audio front end) device node to the MT8173 dtsi file.
Signed-off-by: Koro Chen
---
This patch is based on Matthias's tree:
https://github.com/mbgg/linux-mediatek
branch: v4.2-next/arm64
Changes since v1:
- change node name to afe: audio-controller@1122
---
arch/arm64
This replaces the platform_name in snd_soc_dai_link by device tree node.
Signed-off-by: Koro Chen
---
.../devicetree/bindings/sound/mt8173-max98090.txt | 2 ++
.../bindings/sound/mt8173-rt5650-rt5676.txt | 2 ++
sound/soc/mediatek/mt8173-max98090.c | 17
On Wed, 2015-07-08 at 12:14 +0100, Mark Brown wrote:
> On Wed, Jul 08, 2015 at 04:25:50PM +0800, Koro Chen wrote:
>
> > The driver does not free irq if snd_soc_register_codec fails.
> > It does not return error when request irq failed, either.
> > Fix this by using d
This adds basic regulator support for rt5645.
Signed-off-by: Koro Chen
---
sound/soc/codecs/rt5645.c | 71 +++
sound/soc/codecs/rt5645.h | 26 -
2 files changed, 66 insertions(+), 31 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c
The driver does not free irq if snd_soc_register_codec fails.
It does not return error when request irq failed, either.
Fix this by using devm_request_threaded_irq(), and returns when error.
Signed-off-by: Koro Chen
---
sound/soc/codecs/rt5645.c | 15 ---
1 file changed, 8
On Tue, 2015-07-07 at 09:46 +0200, Matthias Brugger wrote:
> On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen wrote:
> > > This adds afe (audio front end) device node to the MT8173 dtsi file.
> > >
> > > Th
This adds afe (audio front end) device node to the MT8173 dtsi file.
This patch is based on Matthias's tree:
https://github.com/mbgg/linux-mediatek
branch: v4.2-next/arm64
Signed-off-by: Koro Chen
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
1
tion does not match the stream type.
Signed-off-by: Koro Chen
---
sound/soc/soc-pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 256b9c9..a6d3313 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -1306,7 +1306,12
This adds call to runtime suspend in dev remove. It fixs the problem that
suspend is not called in the case of CONFIG_PM=n. It also fixs build
warning when CONFIG_PM=n.
Signed-off-by: Koro Chen
---
sound/soc/mediatek/mtk-afe-pcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc
This adds basic support for the Mediatek AFE (Audio Front End) unit of MT8173.
This patch is based on Linux 4.1-rc1 and Sascha's SCPSYS power patch [1].
The AFE unit comprises several memory interfaces that communicate with CPU,
a multi input multi output digital audio interconnect,
and several
This is the DPCM based platform driver of AFE (Audio Front End) unit.
Signed-off-by: Sascha Hauer
Signed-off-by: Koro Chen
---
.../devicetree/bindings/sound/mtk-afe-pcm.txt | 45 +
sound/soc/Kconfig |1 +
sound/soc/Makefile
This is the DPCM based machine driver with MAX98090
Signed-off-by: Koro Chen
---
.../devicetree/bindings/sound/mt8173-max98090.txt | 13 ++
sound/soc/mediatek/Kconfig | 10 +
sound/soc/mediatek/Makefile| 2 +
sound/soc/mediatek/mt8173
This is the DPCM based machine driver with rt5650 and rt5676
Signed-off-by: Nicolas Boichat
Signed-off-by: Koro Chen
---
.../bindings/sound/mt8173-rt5650-rt5676.txt| 13 +
sound/soc/mediatek/Kconfig | 11 +
sound/soc/mediatek/Makefile
On Fri, 2015-06-12 at 14:13 +0100, Mark Brown wrote:
> On Wed, Jun 10, 2015 at 10:24:35PM +0800, Koro Chen wrote:
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8173-max98090.txt
> > @@ -0,0 +1,17 @@
> > +MT8173 with MAX98090 CODEC
On Fri, 2015-06-12 at 14:06 +0100, Mark Brown wrote:
> On Wed, Jun 10, 2015 at 10:24:34PM +0800, Koro Chen wrote:
> > This is the DPCM based platform driver of AFE (Audio Front End) unit.
> >
> > Signed-off-by: Koro Chen
> > Signed-off-by: Sascha Hauer
>
> Your
On Fri, 2015-06-12 at 09:37 +0200, Paul Bolle wrote:
> On Fri, 2015-06-12 at 09:55 +0800, Koro Chen wrote:
> > On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote:
> > > (What does negating a bool twice do?)
> > >
> > Because bool actually can be unsigne
On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote:
> On Wed, 2015-06-10 at 22:24 +0800, Koro Chen wrote:
> > --- /dev/null
> > +++ b/sound/soc/mediatek/Kconfig
>
> > +config SND_SOC_MEDIATEK
> > + bool "ASoC support for Mediatek chip"
>
This is the DPCM based machine driver with rt5650 and rt5676
Signed-off-by: Koro Chen
Signed-off-by: Nicolas Boichat
---
.../bindings/sound/mt8173-rt5650-rt5676.txt| 15 ++
sound/soc/mediatek/Kconfig | 12 +
sound/soc/mediatek/Makefile
This is the DPCM based machine driver with MAX98090
Signed-off-by: Koro Chen
---
.../devicetree/bindings/sound/mt8173-max98090.txt | 17 ++
sound/soc/mediatek/Kconfig | 11 +
sound/soc/mediatek/Makefile| 2 +
sound/soc/mediatek/mt8173
This is the DPCM based platform driver of AFE (Audio Front End) unit.
Signed-off-by: Koro Chen
Signed-off-by: Sascha Hauer
---
.../devicetree/bindings/sound/mtk-afe-pcm.txt | 45 +
sound/soc/Kconfig |1 +
sound/soc/Makefile
This adds basic support for the Mediatek AFE (Audio Front End) unit for MT8173.
This patch is based on Linux 4.1-rc1 and Sascha's SCPSYS power patch [1].
The AFE unit comprises several memory interfaces that communicate with CPU,
a multi input multi output digital audio interconnect,
and several e
: Koro Chen
---
sound/core/pcm_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index ac6b33f..7d45645 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -339,7 +339,7 @@ static int snd_pcm_update_hw_ptr0(struct
hould also add prefix for stream name
Signed-off-by: Koro Chen
---
sound/soc/soc-dapm.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index defe0f0..158204d 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
On Thu, 2015-04-30 at 21:12 +0100, Mark Brown wrote:
> On Wed, Apr 22, 2015 at 11:17:20AM +0800, Koro Chen wrote:
>
> > If using DPCM, it seems the most suitable FE DAIs will be memif, and
> > external interface like I2S should be BE DAIs. Do you think it is
> > suitabl
On Mon, 2015-04-20 at 21:48 +0100, Mark Brown wrote:
> On Mon, Apr 20, 2015 at 06:37:47AM +0200, Sascha Hauer wrote:
> > On Sat, Apr 18, 2015 at 06:34:07PM +0100, Mark Brown wrote:
> > > On Fri, Apr 10, 2015 at 04:14:07PM +0800, Koro Chen wrote:
>
> > > > +Each e
r 10, 2015 at 04:14:07PM +0800, Koro Chen wrote:
> >
> > > > > +Each external interface (called "IO" in this driver) is presented as
> > > > > a
> > > > > +DAI to ASoC. An IO must be connected via the interconnect to a memif.
> &g
On Mon, 2015-04-20 at 21:55 +0100, Mark Brown wrote:
> On Mon, Apr 20, 2015 at 02:22:24PM +0800, Koro Chen wrote:
> > On Sat, 2015-04-18 at 18:51 +0100, Mark Brown wrote:
> > > On Fri, Apr 10, 2015 at 04:14:09PM +0800, Koro Chen wrote:
>
> > > Ah, so the SRAM is d
On Sat, 2015-04-18 at 18:51 +0100, Mark Brown wrote:
> On Fri, Apr 10, 2015 at 04:14:09PM +0800, Koro Chen wrote:
>
> > + if (memif->use_sram) {
> > + struct snd_dma_buffer *dma_buf = &substream->dma_buffer;
> > + int
49 matches
Mail list logo